From: Lev Stipakov
There are two problems with the current implementation:
- due to the code bug, we never display actual error message
corresponding to the Windows error code. We use
FORMAT_MESSAGE_ALLOCATE_BUFFER, in which case we must pass
a pointer to the LPTSTR, not the LPTSTR itself.
-
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log
..
Patch Set 3:
(1 comment)
Patchset:
PS2:
> If that is so
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1195?usp=email )
Change subject: dco: Change sd argument to dco_new_peer from int to
socket_descriptor_t
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1196?usp=email )
Change subject: dev-tools/gerrit-send-mail.py: include Gerrit URL into the
commit message
...
Attention is currently required from: flichtenheld, ordex, plaisthos.
d12fk has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email )
Change subject: Install host routes for ifconfig-push routes when DCO is enabled
..
Attention is currently required from: flichtenheld, ordex, plaisthos.
d12fk has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email )
Change subject: Allow route_ipv6_match_host to be used outside of route.c
.
Attention is currently required from: flichtenheld, ordex, plaisthos.
d12fk has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email )
Change subject: Allow route_ipv6_match_host to be used outside of route.c
.
Attention is currently required from: d12fk, flichtenheld, ordex, plaisthos.
d12fk has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email )
Change subject: Install host routes for ifconfig-push routes when DCO is enabled
...
selvanair has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log
..
Patch Set 3:
(1 comment)
Patchset:
PS2:
> FWIW, bui
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1185?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log
..
openvpnserv: Fix writing messages to the event log
There are two pr
From: Frank Lichtenheld
Basically all users already wanted that anyway. And most
of the library functions also take size_t nowadays.
Change-Id: Ic88cd6e143bc48cab3c9ebb7c7007513803bd199
Signed-off-by: Frank Lichtenheld
Acked-by: MaxF
---
This change was reviewed on Gerrit and approved by at l
From: Gianmarco De Gregori
On Windows, multi-socket support failed with
mixed protocols due to repeated socket_set()
calls, which caused accept() to be triggered
before having an event to process.
This fix skips socket_set() calls for
non-UDP sockets in MODE_SERVER inside
multi_io_process_flags()
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1195?usp=email
to review the following change.
Change subject: dco: Change sd argument to dco_new_peer from int to
socket_descriptor_t
..
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1196?usp=email )
Change subject: dev-tools/gerrit-send-mail.py: include Gerrit URL into the
commit message
...
Attention is currently required from: cron2, plaisthos, stipa.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log
Meeting summary for 17 September 2025:
*
*Updated: Release 2.7*
OpenVPN 2.7 beta2 was planned for 18th of September but will be
shifted to early next week instead.
Reason is there's some concern and discussion about a recently
merged bit of code that must be cleared up first.
*
Same patch as commit 06919a60ae61, just adapted for different formatting
and other 2.6 <-> master/2.7 differences that "git cherry-pick" finds
hard to do, and stuff like openvpn_swprintf(), TEXT vs. L, etc...
The same caveat applies as for master: this currently breaks building
"openvpnserv.exe" w
Attention is currently required from: cron2, ordex, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1110?usp=email )
Change subject: Introduce msglvl_t to unify msglevel type handling
From: Frank Lichtenheld
msglevel was definitely unsigned as the first
argument to msg(), but many parts of the code
had it as signed. So this produced a LOT of
warnings when enabling -Wsign-conversion.
Introduce a msglvl_t typedef and switch all
users to it. This includes any values that
are sto
cron2 has uploaded a new patch set (#3) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by selvanair
Change subject: openvpnserv: Fix writing messages to the event log
..
Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1110?usp=email )
Change subject: Introduce msglvl_t to unify msglevel type handling
cron2 has uploaded a new patch set (#4) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1185?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: openvpnserv: Fix writing messages to the event log
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log
..
openvpnserv: Fix writing messages to the event log
There are two pr
So this has a bit of a complicated journey - the initial patch was
gerrit 1183 for 2.6, which had v1..v3, and then this one for master,
which only got up to v2 but is now the same code change, essentially.
I have tested a 2.6 installer with this, and it makes really nice
log entries in the event
Attention is currently required from: plaisthos.
Hello ordex, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1195?usp=email
to look at the new patch set (#6).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Seconded.
Sent with Proton Mail secure email.
On Wednesday, 17 September 2025 at 15:12, Jonathan K. Bullard
wrote:
> Thanks, Johan, for this report, and for all the other reports you've done!
> Much appreciated by those of us who are not "on"
Yay, my first Python code... :-)
And tested with this very e-mail - and of course, mail-archive.org is
acting up again, and not showing the "PATCH" e-mail..
Your patch has been applied to the master branch.
commit 168792766dedc2dab41347fa394fc244c73247e8
Author: Gert Doering
Date: Wed Sep 17 1
Thanks, Johan, for this report, and for all the other reports you've done!
Much appreciated by those of us who are not "on" IRC.
Best regards,
Jon Bullard
Tunnelblick
On Wed, Sep 17, 2025 at 5:58 AM Johan Draaisma wrote:
> Meeting summary for 17 September 2025:
>
>-
>
>*Updated: Rele
Attention is currently required from: d12fk, flichtenheld, ordex, plaisthos.
Hello flichtenheld, ordex,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email
to look at the new patch set (#7).
Change subject: Install host routes for ifconfig
Attention is currently required from: d12fk, flichtenheld, ordex, plaisthos.
Hello flichtenheld, ordex,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were rem
Attention is currently required from: flichtenheld, ordex, plaisthos.
Hello flichtenheld, ordex,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
C
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1196?usp=email )
Change subject: dev-tools/gerrit-send-mail.py: include Gerrit URL into the
commit message
..
dev-tools/gerrit-send-mail.py: include Gerri
flichtenheld has abandoned this change. (
http://gerrit.openvpn.net/c/openvpn/+/1189?usp=email )
Change subject: Change msglevel flags to int
..
Abandoned
Will go for #1110
--
To view, visit http://gerrit.openvpn.net/c/openvpn
Attention is currently required from: flichtenheld, plaisthos.
Hello ordex, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1195?usp=email
to look at the new patch set (#2).
The change is no longer submittable: checks~ChecksSubmitRule is un
So this is basically a cherry-pick of the master commit 518e122b4273
to 2.6 ("because it fixes a real problem for at least one server operator"),
adjusted for clang-format/uncrustify formatting differences.
I have only lightly tested this - it comes with its unit tests, those
pass, and t_client te
Attention is currently required from: d12fk, flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email )
Change subject: Install host routes with onlink scope iroutes for ifconfig-push
routes
...
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1196?usp=email )
Change subject: dev-tools/gerrit-send-mail.py: include Gerrit URL into the
commit message
...
Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1196?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were remove
From: Lev Stipakov
There are two problems with the current implementation:
- due to the code bug, we never display actual error message
corresponding to the Windows error code. We use
FORMAT_MESSAGE_ALLOCATE_BUFFER, in which case we must pass
a pointer to the LPTSTR, not the LPTSTR itself.
-
Attention is currently required from: d12fk, flichtenheld, ordex.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email )
Change subject: Install host routes with onlink scope iroutes for ifconfig-push
routes
...
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1184?usp=email )
Change subject: Check message id/acked ids too when doing sessionid cookie
checks
..
Check message id/acked ids too when doing sessionid
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1196?usp=email
to review the following change.
Change subject: dev-tools/gerrit-send-mail.py: include Gerrit U
Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1185?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log
Attention is currently required from: cron2, flichtenheld, plaisthos.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log
44 matches
Mail list logo
