[Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions

2024-04-08 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email ) Change subject: Remove openvpn_snprintf and similar functions ..

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter ..

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter ..

[Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions

2024-03-27 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email ) Change subject: Remove openvpn_snprintf and similar functions ..

[Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions

2024-03-24 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email ) Change subject: Remove openvpn_snprintf and similar functions ..

[Openvpn-devel] [XS] Change in openvpn[master]: Add bracket in fingerprint message and do not warn about missing veri...

2024-03-22 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/546?usp=email ) Change subject: Add bracket in fingerprint message and do not warn about missing verification

[Openvpn-devel] [M] Change in openvpn[master]: samples: Update sample configurations

2024-03-04 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/532?usp=email ) Change subject: samples: Update sample configurations .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: samples: Remove tls-*.conf

2024-03-04 Thread ordex (Code Review)
Attention is currently required from: flichtenheld. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/531?usp=email ) Change subject: samples: Remove tls-*.conf .. Patch Set 1: Code-Review+2

[Openvpn-devel] [M] Change in openvpn[master]: t_client.sh: Allow to skip tests

2024-02-21 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/521?usp=email ) Change subject: t_client.sh: Allow to skip tests .. Patch Set 2:

[Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-20 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/525?usp=email ) Change subject: Minor fix to process_ip_header ..

[Openvpn-devel] [S] Change in openvpn[master]: Make it more explicit and visible when pkg-config is not found

2024-01-05 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/465?usp=email ) Change subject: Make it more explicit and visible when pkg-config is not found

[Openvpn-devel] [S] Change in openvpn[master]: Make it more explicit and visible when pkg-config is not found

2024-01-04 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/465?usp=email ) Change subject: Make it more explicit and visible when pkg-config is not found

[Openvpn-devel] [M] Change in openvpn[master]: event/multi: add event_arg object to make event handling more generic

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/430?usp=email ) Change subject: event/multi: add event_arg object to make event handling more generic .. Restored -- To view, visit

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/431?usp=email ) Change subject: pass link_socket object to i/o functions .. Restored -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/431?usp=email

[Openvpn-devel] [L] Change in openvpn[master]: io_work: convert shift argument to uintptr_t

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/432?usp=email ) Change subject: io_work: convert shift argument to uintptr_t .. Restored -- To view, visit

[Openvpn-devel] [S] Change in openvpn[master]: io_work: pass event_arg object to event handler in case of socket event

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/433?usp=email ) Change subject: io_work: pass event_arg object to event handler in case of socket event .. Restored -- To view, visit

[Openvpn-devel] [L] Change in openvpn[master]: allow tcp/udp server to listen on multiple ports at the same time

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email ) Change subject: allow tcp/udp server to listen on multiple ports at the same time .. Restored -- To view, visit

[Openvpn-devel] [S] Change in openvpn[master]: if a local IPv6 address is provided, socket must be v6-only

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/435?usp=email ) Change subject: if a local IPv6 address is provided, socket must be v6-only .. Restored -- To view, visit

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files .. Restored -- To view, visit

[Openvpn-devel] [S] Change in openvpn[master]: override ai_family if 'local' numeric address was specified

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/437?usp=email ) Change subject: override ai_family if 'local' numeric address was specified .. Restored -- To view, visit

[Openvpn-devel] [L] Change in openvpn[master]: Bind to multiple ipv4/ipv6 addresses

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/438?usp=email ) Change subject: Bind to multiple ipv4/ipv6 addresses .. Restored -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/438?usp=email To

[Openvpn-devel] [M] Change in openvpn[master]: mroute: properly print protocol at the end of the string

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/439?usp=email ) Change subject: mroute: properly print protocol at the end of the string .. Restored -- To view, visit

[Openvpn-devel] [L] Change in openvpn[master]: Using the same wait function for both TCP and UDP

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/440?usp=email ) Change subject: Using the same wait function for both TCP and UDP .. Restored -- To view, visit

[Openvpn-devel] [XL] Change in openvpn[master]: multiproto: move generic event handling code in dedicated files

2023-11-15 Thread ordex (Code Review)
ordex has restored this change. ( http://gerrit.openvpn.net/c/openvpn/+/441?usp=email ) Change subject: multiproto: move generic event handling code in dedicated files .. Restored -- To view, visit

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/431?usp=email ) Change subject: pass link_socket object to i/o functions .. Abandoned -- To view, visit

[Openvpn-devel] [M] Change in openvpn[master]: mroute: properly print protocol at the end of the string

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/439?usp=email ) Change subject: mroute: properly print protocol at the end of the string .. Abandoned -- To view, visit

[Openvpn-devel] [M] Change in openvpn[master]: event/multi: add event_arg object to make event handling more generic

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/430?usp=email ) Change subject: event/multi: add event_arg object to make event handling more generic .. Abandoned -- To view, visit

[Openvpn-devel] [L] Change in openvpn[master]: Bind to multiple ipv4/ipv6 addresses

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/438?usp=email ) Change subject: Bind to multiple ipv4/ipv6 addresses .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/438?usp=email

[Openvpn-devel] [L] Change in openvpn[master]: allow tcp/udp server to listen on multiple ports at the same time

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email ) Change subject: allow tcp/udp server to listen on multiple ports at the same time .. Abandoned -- To view, visit

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files .. Abandoned -- To view, visit

[Openvpn-devel] [S] Change in openvpn[master]: io_work: pass event_arg object to event handler in case of socket event

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/433?usp=email ) Change subject: io_work: pass event_arg object to event handler in case of socket event .. Abandoned -- To view, visit

[Openvpn-devel] [L] Change in openvpn[master]: Using the same wait function for both TCP and UDP

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/440?usp=email ) Change subject: Using the same wait function for both TCP and UDP .. Abandoned -- To view, visit

[Openvpn-devel] [S] Change in openvpn[master]: if a local IPv6 address is provided, socket must be v6-only

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/435?usp=email ) Change subject: if a local IPv6 address is provided, socket must be v6-only .. Abandoned -- To view, visit

[Openvpn-devel] [L] Change in openvpn[master]: io_work: convert shift argument to uintptr_t

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/432?usp=email ) Change subject: io_work: convert shift argument to uintptr_t .. Abandoned -- To view, visit

[Openvpn-devel] [S] Change in openvpn[master]: override ai_family if 'local' numeric address was specified

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/437?usp=email ) Change subject: override ai_family if 'local' numeric address was specified .. Abandoned -- To view, visit

[Openvpn-devel] [XL] Change in openvpn[master]: multiproto: move generic event handling code in dedicated files

2023-11-15 Thread ordex (Code Review)
ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/441?usp=email ) Change subject: multiproto: move generic event handling code in dedicated files .. Abandoned -- To view, visit

[Openvpn-devel] [L] Change in openvpn[master]: Bind to multiple ipv4/ipv6 addresses

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/438?usp=email to review the following change. Change subject: Bind to multiple ipv4/ipv6 addresses

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=email to review the following change. Change subject: allow user to specify 'local' multiple times in

[Openvpn-devel] [L] Change in openvpn[master]: io_work: convert shift argument to uintptr_t

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/432?usp=email to review the following change. Change subject: io_work: convert shift argument to uintptr_t

[Openvpn-devel] [M] Change in openvpn[master]: mroute: properly print protocol at the end of the string

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/439?usp=email to review the following change. Change subject: mroute: properly print protocol at the end of

[Openvpn-devel] [L] Change in openvpn[master]: Using the same wait function for both TCP and UDP

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/440?usp=email to review the following change. Change subject: Using the same wait function for both TCP and

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/431?usp=email to review the following change. Change subject: pass link_socket object to i/o functions

[Openvpn-devel] [M] Change in openvpn[master]: event/multi: add event_arg object to make event handling more generic

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/430?usp=email to review the following change. Change subject: event/multi: add event_arg object to make event

[Openvpn-devel] [S] Change in openvpn[master]: if a local IPv6 address is provided, socket must be v6-only

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/435?usp=email to review the following change. Change subject: if a local IPv6 address is provided, socket

[Openvpn-devel] [S] Change in openvpn[master]: override ai_family if 'local' numeric address was specified

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/437?usp=email to review the following change. Change subject: override ai_family if 'local' numeric address

[Openvpn-devel] [S] Change in openvpn[master]: io_work: pass event_arg object to event handler in case of socket event

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/433?usp=email to review the following change. Change subject: io_work: pass event_arg object to event handler

[Openvpn-devel] [S] Change in openvpn[master]: Do not check key_state buffers that are in S_UNDEF state

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/426?usp=email ) Change subject: Do not check key_state buffers that are in S_UNDEF state

[Openvpn-devel] [XS] Change in openvpn[master]: Do not check key_state buffers that are in S_UNDEF state

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has removed a vote from this change. ( http://gerrit.openvpn.net/c/openvpn/+/426?usp=email ) Change subject: Do not check key_state buffers that are in S_UNDEF state

[Openvpn-devel] [XS] Change in openvpn[master]: Do not check key_state buffers that are in S_UNDEF state

2023-11-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/426?usp=email ) Change subject: Do not check key_state buffers that are in S_UNDEF state

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: buffer: use memcpy in buf_catrunc

2023-08-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/314?usp=email ) Change subject: buffer: use memcpy in buf_catrunc .. Patch Set 1:

[Openvpn-devel] [XS] Change in openvpn[master]: dco: fix crash when --multihome is used with --proto tcp

2023-08-15 Thread ordex (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/324?usp=email to review the following change. Change subject: dco: fix crash when --multihome is used with --proto tcp

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread ordex (Code Review)
Attention is currently required from: cron2, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets ..

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread ordex (Code Review)
Attention is currently required from: cron2, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/28?usp=email to look at the new patch set (#5). Change subject: dco: don't use NetLink to exchange control packets

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread ordex (Code Review)
Attention is currently required from: cron2, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets ..

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread ordex (Code Review)
Attention is currently required from: cron2, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets ..