Re: [os-libsynthesis] About 'autodate' and 'autoenddate'

2009-08-12 Thread Lukas Zeller
Hi Yongsheng, There's in fact a bug in the way the autoenddate case was handled. To detect end-of-day, it converted the timestamp into local time, and when it saw 23:59:59 this was converted to beginning of next day - but I forgot to write back the time context, so it came out as UTC 0:00

Re: [os-libsynthesis] About 'autodate' and 'autoenddate'

2009-08-12 Thread Lukas Zeller
Hi Patrick, On Aug 11, 2009, at 14:19 , Patrick Ohly wrote: "autoenddate" is significant only for vCalendar 1.0 rendering, "rendering" = "parsing"? "handling" would have been the right word - it affects both parsing and generating... as it will turn on detecting 23:59:59 as an end-of-d

Re: [os-libsynthesis] off-by-one error in rrule2internal?

2009-08-12 Thread Lukas Zeller
Hello Patrick, That looks ok to me as well. Parts of the RRULE v2 code is from a customer of ours, who needed v2 RRULEs long before we supported them on the SyncML side, he needed it to store RRULEs towards an Exchange server, if I correctly remember. I can see no reason for the -1, except

[os-libsynthesis] Your "client+statistics workaround" patch (f51c0bc3a77d29b5af33c5003b4752173ed35ddb in moblin git)

2009-08-12 Thread Lukas Zeller
Hi, thanks for the patch to fix the "client+statistics" problem with counting client adds as updates when the server returns 200 for them instead of 201. There is one basic problem with your solution: The fact that a entry in the database already has a change log entry does NOT mean that

[os-libsynthesis] empty anchor or dummy string

2009-08-12 Thread Lukas Zeller
Hi Patrick, I just saw your patch: slow sync: avoid empty anchors, that confuses ScheduleWorld This patch fixes http://bugzilla.moblin.org/show_bug.cgi?id=4703, "ScheduleWorld: delete on server can not sync to client (after doing slow sync)". Somehow the ScheduleWorld server has problems w

[os-libsynthesis] vCard 2.1 and quoted parameter values

2009-08-12 Thread Lukas Zeller
Hi Yongsheng, I have a question regarding your patch to allow vCard 2.1 parameters to have quoted values. IMHO the vCard 2.1 specs don't allow this: param = “TYPE” [ws] “=“ [ws] ptypeval / “VALUE” [ws] “=“ [ws] pvalueval / “ENCODING” [ws] “=“ [ws] pencodingval / “CHARSET” [ws]

Re: [os-libsynthesis] empty anchor or dummy string

2009-08-12 Thread Patrick Ohly
On Wed, 2009-08-12 at 17:40 +0100, Lukas Zeller wrote: > I just saw your patch: > > > slow sync: avoid empty anchors, that confuses ScheduleWorld > > > > This patch fixes http://bugzilla.moblin.org/show_bug.cgi?id=4703, > > "ScheduleWorld: delete on server can not sync to client (after doing > >

Re: [os-libsynthesis] empty anchor or dummy string

2009-08-12 Thread Lukas Zeller
Hi Patrick, On Aug 12, 2009, at 19:27 , Patrick Ohly wrote: Anyway, ScheduleWorld can handle that now, so it is safe to not merge the patch and remove it also in our git repo. ok, simple solution :-) Reason is that these variables have the semantic meaning of "no anchor" = "empty string". C

Re: [os-libsynthesis] vCard 2.1 and quoted parameter values

2009-08-12 Thread Patrick Ohly
On Wed, 2009-08-12 at 18:18 +0100, Lukas Zeller wrote: > Your example > > TEL;TYPE="X-EVOLUTION-COMPANY":12345 > > would be a typeval > > The definition of "word" allows the doublequote to be part of the > word, so interpreting it as a quote around the value is wrong. > > I admit a case whe

Re: [os-libsynthesis] empty anchor or dummy string

2009-08-12 Thread Patrick Ohly
On Wed, 2009-08-12 at 19:20 +0100, Lukas Zeller wrote: > On Aug 12, 2009, at 19:27 , Patrick Ohly wrote: > > I think the logic is the other way around: if first sync, then clear > > the > > anchor. At least that is what I patched in the code. "syncevolution" > > still reports "first time sync" de

Re: [os-libsynthesis] vCard 2.1 and quoted parameter values

2009-08-12 Thread Zhu, Yongsheng
>Yongsheng, do you agree that we no longer need this patch? It has never >been merged into our master branch either. The answer is yes. This should not be merged into the master due to funambol's changes for this issue. That example is absolutely not conformable to the vcard2.1 spec. Lukas, pleas

Re: [os-libsynthesis] About 'autodate' and 'autoenddate'

2009-08-12 Thread Zhu, Yongsheng
The patch does work! Thanks for your patch. Regards, Yongsheng -Original Message- From: Lukas Zeller [mailto:l...@synthesis.ch] Sent: Wednesday, August 12, 2009 6:40 PM To: Zhu, Yongsheng Cc: os-libsynthesis@synthesis.ch; Ohly, Patrick Subject: Re: [os-libsynthesis] About 'autodate' and

Re: [os-libsynthesis] Your "client+statistics workaround" patch (f51c0bc3a77d29b5af33c5003b4752173ed35ddb in moblin git)

2009-08-12 Thread Chen, Congwu
>The reason for this is that the changelog is shared between multiple >profiles (multiple servers), and thus the changelog entries are >created when ANY of the profiles first sees the entry. Ah, I now remember you have mentioned PRO version synthesis client use multi-profiles sharing the same cha