Re: [osg-users] Questions about Geometry implementation details

2007-10-19 Thread Christian Muschick
Robert Osfield wrote: > Hi Christian, > > On 10/19/07, Christian Muschick <[EMAIL PROTECTED]> wrote: >> Sorry to bother you again, but did you take a look at the other lines of >> code I pointed out? I think the same problem exists there. >> >> line 1123: >> if (!array->getVertexBufferObject()) vb

Re: [osg-users] Questions about Geometry implementation details

2007-10-19 Thread Robert Osfield
Hi Christian, I've done a check through the code and changed where I think there are issues - 4 more beyond the one I fixed earlier. I've checked these changes in. The changes I've made can be seen on the Tracs revision log: http://www.openscenegraph.org/projects/osg/log/OpenSceneGraph/trunk/sr

Re: [osg-users] Questions about Geometry implementation details

2007-10-19 Thread Robert Osfield
Hi Christian, On 10/19/07, Christian Muschick <[EMAIL PROTECTED]> wrote: > Sorry to bother you again, but did you take a look at the other lines of > code I pointed out? I think the same problem exists there. > > line 1123: > if (!array->getVertexBufferObject()) vbo = array->getVertexBufferObject(

Re: [osg-users] Questions about Geometry implementation details

2007-10-19 Thread Christian Muschick
Robert Osfield wrote: > Hi Ralf, > > Thanks for the clarification, I'm afraid my trip meant not following > threads too closely. > > I've reviewed the code and the if (!array->getVertex..()) line is > wrong, and Ulrich pointed to the correct implementation. > > I've fixed the relevant code and c

Re: [osg-users] Questions about Geometry implementation details

2007-10-19 Thread Robert Osfield
Hi Ralf, Thanks for the clarification, I'm afraid my trip meant not following threads too closely. I've reviewed the code and the if (!array->getVertex..()) line is wrong, and Ulrich pointed to the correct implementation. I've fixed the relevant code and checked it into SVN. Robert. On 10/19/0

Re: [osg-users] Questions about Geometry implementation details

2007-10-18 Thread Ralph Kern
Robert Osfield schrieb: > On 10/19/07, Ulrich Hertlein <[EMAIL PROTECTED]> wrote: >> Hello Christian, >> >> Quoting Christian Muschick <[EMAIL PROTECTED]>: >>> My last request concerning this question didn't get any reply, so let me >>> try this reformulated version: >>> ... >>> osg::Array

Re: [osg-users] Questions about Geometry implementation details

2007-10-18 Thread Robert Osfield
On 10/19/07, Ulrich Hertlein <[EMAIL PROTECTED]> wrote: > Hello Christian, > > Quoting Christian Muschick <[EMAIL PROTECTED]>: > > My last request concerning this question didn't get any reply, so let me > > try this reformulated version: > >... > > osg::Array* array = *vitr; > >

Re: [osg-users] Questions about Geometry implementation details

2007-10-18 Thread Ulrich Hertlein
Hello Christian, Quoting Christian Muschick <[EMAIL PROTECTED]>: > My last request concerning this question didn't get any reply, so let me > try this reformulated version: >... > osg::Array* array = *vitr; > if (!array->getVertexBufferObject()) vbo = > array->getVertexBufferObje