Re: [ovs-dev] [PATCH 06/27] db-ctl-base: Drop redundant 'table' field from struct ctl_row_id.

On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > The 'table' field is redundant because the required 'column' field > implies the table that the column is a part of. > > This simplifies the users and makes it harder to get these things wrong. > > Signed-off-by: Ben Pfaff Nice simplification!

Re: [ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

On 24/04/2017 14:35, Simon Horman wrote: On Tue, Apr 18, 2017 at 03:18:55PM +0300, Roi Dayan wrote: On 14/04/2017 04:11, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

[ovs-dev] I Have A Proposal

I am Capt. Brian I have special proposal that will do you good, contact me for more understanding Regard Capt. Brian ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] fedora: do not restart ovn svcs automatically on pkg upgrade

> From: "Russell Bryant" > To: "Lance Richardson" > Cc: "ovs dev" > Sent: Tuesday, 2 May, 2017 9:41:39 PM > Subject: Re: [ovs-dev] [PATCH] fedora: do not restart ovn svcs automatically > on pkg upgrade > > On Tue, May 2, 2017 at 4:18 PM, Lance Richardson wrote: > > Similar to commit 5771f4765

Re: [ovs-dev] [PATCH 04/27] ovn-nbctl: Drop gratuitous indentation for "show" output.

On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > "ovn-nbctl show" indented every line of output by at least 4 spaces, which > needlessly wastes horizontal space. This drops 4 spaces of indent from > each line of output. > > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou ___

Re: [ovs-dev] [PATCH 03/27] uuid: New function uuid_is_partial_match().

On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > This will have another caller in an upcoming commit. > > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou > --- > lib/db-ctl-base.c | 10 +- > lib/uuid.c| 11 +++ > lib/uuid.h| 3 ++- > 3 files changed, 14 inser

Re: [ovs-dev] [PATCH V2] netdev-dpdk: fix mempool_configure error state

Acked-by: Darrell Ball On 3/13/17, 4:46 AM, "ovs-dev-boun...@openvswitch.org on behalf of Stokes, Ian" wrote: > netdev_dpdk_mempool_configure obtains a handle to a DPDK memory pool via a > call to dpdk_mp_get. If dpdk_mp_get fails, the former informs the user > that insufficient me

Re: [ovs-dev] flake8 checking for release branches

On Mon, May 1, 2017 at 1:26 PM, Ben Pfaff wrote: > There's a bit of a problem with flake8 and release branches. The > release branches mainly stay the same, but flake8 marches on, and the > result is that building an old branch, e.g. branch-2.6, with modern > flake8 causes errors that break the b

Re: [ovs-dev] [PATCH] fedora: do not restart ovn svcs automatically on pkg upgrade

On Tue, May 2, 2017 at 4:18 PM, Lance Richardson wrote: > Similar to commit 5771f4765734 ("fedora: do not restart the > service on a pkg upgrade"), this change eliminates the > automatic restart of OVN services after upgrade. > > Note that the post-uninstall scriptlet affected by this change > is

Re: [ovs-dev] [PATCH 2/2] revalidator: Fix logging of xlate_key() failure.

On 1 May 2017 at 13:05, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme Thanks, applied to master and branch-2.7. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] revalidator: Revalidate ukeys created from flows.

On 1 May 2017 at 13:05, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme Thanks, applied to master and branch-2.[567]. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets.

On Thu, Apr 27, 2017 at 5:26 PM, Aaron Conole wrote: > Lance Richardson writes: > >>> From: "Russell Bryant" >>> To: "Ben Pfaff" >>> Cc: "ovs dev" , "Flavio Leitner" >>> , "Lance Richardson" , >>> "Aaron Conole" >>> Sent: Thursday, 27 April, 2017 3:04:43 PM >>> Subject: Re: [ovs-dev] [PATCH] b

Re: [ovs-dev] [PATCH v6 3/3] ovn-northd: Add logical flows to support native DNS

On Wed, May 3, 2017 at 4:38 AM, Ben Pfaff wrote: > On Tue, Apr 25, 2017 at 07:59:54PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > OVN implements native DNS resolution which can be used to resolve the > > internal DNS names belonging to a logical datapath. > > > > To suppor

Re: [ovs-dev] [PATCH 02/27] uuid: Change semantics of uuid_is_partial_string().

On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > Until now, uuid_is_partial_string() returned the number of characters at > the beginning of a string that were the beginning of a valid UUID. This > is useful, but all of the callers actually wanted to get a value of 0 if > the string contained

Re: [ovs-dev] [PATCH 01/27] ovn-nb: Fix grouping in manpage.

On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > DHCP columns shouldn't be part of "Common Columns" because that's just for > external_ids and other_config. > > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v6 3/3] ovn-northd: Add logical flows to support native DNS

On Tue, Apr 25, 2017 at 07:59:54PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > OVN implements native DNS resolution which can be used to resolve the > internal DNS names belonging to a logical datapath. > > To support this, a new table 'DNS' is added in the NB DB. A new column >

[ovs-dev] [PATCH] datapath: backport: vxlan: correctly handle ipv6.disable module parameter

From: Jiri Benc upstream commit: commit d074bf9600443403aa24fbc12c1f18eadc90f5aa Author: Jiri Benc Date: Thu Apr 27 21:24:35 2017 +0200 vxlan: correctly handle ipv6.disable module parameter When IPv6 is compiled but disabled at runtime, __vxlan_sock_add returns -EAFNO

[ovs-dev] [PATCH] ovn-controller: Add conditional monitoring support for DNS table.

For the DNS table, a given hypervisor only needs records for logical datapaths that are locally resident. Signed-off-by: Ben Pfaff --- ovn/controller/ovn-controller.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/

Re: [ovs-dev] [PATCH] OVN localport type support

On Tue, May 02, 2017 at 03:57:27PM -0400, Russell Bryant wrote: > On Tue, May 2, 2017 at 11:31 AM, Ben Pfaff wrote: > > On Tue, Apr 25, 2017 at 11:05:28AM +, Daniel Alvarez wrote: > >> This patch introduces a new type of OVN ports called "localport". > >> These ports will be present in every h

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add Cuckoo Distributor to Accelerate Megaflow Search

Thank you Darrell for the comment, we collect some data with the scalar version, please see my reply inlined. Our newest results show good speedup for both scalar and AVX version. We are still waiting for more feedback before implementing version 2. Please feel free to comment on the patch.

[ovs-dev] Normas de Información Financiera

Conceptos específicos financieros y de resultados. Normas de Información Financiera (NIF) Controles Internos 17 de Mayo - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00Hrs Tome el verdadero control de su empresa. Aprenda la manera óptima de regular, registrar y administrar sus estados financ

Re: [ovs-dev] [PATCH] rhel: fix the fedora spec

On Tue, May 2, 2017 at 4:17 PM, Aaron Conole wrote: > When commit d0c961a99f57 ("lib/automake.mk: don't install > runtime directories") landed, it broke RPM based builds since > the requisite directories were no longer available. This commit > adds those directories back when making RPMs so that

Re: [ovs-dev] Cover letters (was Re: [PATCH 0/7] Add OVS DPDK keep-alive functionality)

On Tue, 2017-05-02 at 12:21 -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Mon, May 01, 2017 at 04:45:56PM -0400, Aaron Conole wrote: > > > Ben Pfaff writes: > > > ... > > > > I think it'd be even better to include measurements in one of > > > > the commit messages, because those are av

Re: [ovs-dev] [PATCH 05/27] ovn-sbctl, ovn-nbctl, ovs-vsctl: Remove useless record id methods.

On Tue, May 2, 2017 at 4:30 PM, Russell Bryant wrote: > On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff wrote: >> These only did anything if both the first two members of the struct were >> nonnull, as you can see from the first test in get_row_by_id() in >> lib/db-ctl-base.c, so these never did anyth

Re: [ovs-dev] [PATCH 05/27] ovn-sbctl, ovn-nbctl, ovs-vsctl: Remove useless record id methods.

On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff wrote: > These only did anything if both the first two members of the struct were > nonnull, as you can see from the first test in get_row_by_id() in > lib/db-ctl-base.c, so these never did anything useful and I can't figure > out why they're there. > > S

Re: [ovs-dev] [PATCH v2] Avoid update probe interval to non-zero for unix socket.

On Tue, May 2, 2017 at 8:18 AM, Ben Pfaff wrote: > > Thanks for the testing and the fix. Can you please re-send this as a > full patch? The version that made it to the list got wordwrapped. > ok, I just re-sent the full patch: https://mail.openvswitch.org/pipermail/ovs-dev/2017-May/331827.html

[ovs-dev] [PATCH] ovn-controller: Disable probes by default for unix sockets.

Normally the OVS JSON-RPC library does not probe idle connections across Unix domain sockets, since the kernel can tell OVS whether the connections are truly connected without probes, but ovn-controller carelessly overrode that. (This should not be an issue in typical OVN deployments, because the

Re: [ovs-dev] [PATCH 04/27] ovn-nbctl: Drop gratuitous indentation for "show" output.

On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff wrote: > "ovn-nbctl show" indented every line of output by at least 4 spaces, which > needlessly wastes horizontal space. This drops 4 spaces of indent from > each line of output. > > Signed-off-by: Ben Pfaff > --- > ovn/utilities/ovn-nbctl.c | 26

[ovs-dev] [PATCH] fedora: do not restart ovn svcs automatically on pkg upgrade

Similar to commit 5771f4765734 ("fedora: do not restart the service on a pkg upgrade"), this change eliminates the automatic restart of OVN services after upgrade. Note that the post-uninstall scriptlet affected by this change is executed from the previously installed package when upgrading, so ex

[ovs-dev] [PATCH] rhel: fix the fedora spec

When commit d0c961a99f57 ("lib/automake.mk: don't install runtime directories") landed, it broke RPM based builds since the requisite directories were no longer available. This commit adds those directories back when making RPMs so that the package manager can see them. Fixes: d0c961a99f57 ("lib/

Re: [ovs-dev] [PATCH 03/27] uuid: New function uuid_is_partial_match().

On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff wrote: > This will have another caller in an upcoming commit. > > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant with a minor comment inline ... > diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c > index ab617f9e065d..18109691b1d6 100644 > --- a

Re: [ovs-dev] [PATCH 02/27] uuid: Change semantics of uuid_is_partial_string().

On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff wrote: > Until now, uuid_is_partial_string() returned the number of characters at > the beginning of a string that were the beginning of a valid UUID. This > is useful, but all of the callers actually wanted to get a value of 0 if > the string contained

Re: [ovs-dev] [PATCH 01/27] ovn-nb: Fix grouping in manpage.

On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff wrote: > DHCP columns shouldn't be part of "Common Columns" because that's just for > external_ids and other_config. > > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant ___ dev mailing list d...@openvswitc

Re: [ovs-dev] [PATCH] OVN localport type support

On Tue, May 2, 2017 at 11:31 AM, Ben Pfaff wrote: > On Tue, Apr 25, 2017 at 11:05:28AM +, Daniel Alvarez wrote: >> This patch introduces a new type of OVN ports called "localport". >> These ports will be present in every hypervisor and may have the >> same IP/MAC addresses. They are not bound

Re: [ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

One minor nit and one real comment below. On Tue, May 2, 2017 at 11:07 AM, Ben Pfaff wrote: > On Mon, May 01, 2017 at 05:50:57PM -0700, Mickey Spiegel wrote: > > On Mon, May 1, 2017 at 5:12 PM, Ben Pfaff wrote: > > > > > On Mon, May 01, 2017 at 03:39:32PM -0700, Mickey Spiegel wrote: > > > > On

Re: [ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

On Mon, May 01, 2017 at 05:50:57PM -0700, Mickey Spiegel wrote: > On Mon, May 1, 2017 at 5:12 PM, Ben Pfaff wrote: > > > On Mon, May 01, 2017 at 03:39:32PM -0700, Mickey Spiegel wrote: > > > On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > > > > > > > Without this support, ovn-trace is not ve

Re: [ovs-dev] [PATCH branch-2.7] mcast-snooping: Fix timing issue in the unit test

On Tue, May 02, 2017 at 10:44:25AM -0700, Yi-Hung Wei wrote: > Commit d46aab11bf12 ("mcast-snooping: Add and improve mcast-snooping > tests.") in master branch consists of both bug fix and a new test. > Split the patch for applying bug fix to branch 2.7. > > Fixes: 94a881c1c8e3e ("ofproto-dpif-xla

[ovs-dev] [PATCH branch-2.7] mcast-snooping: Fix timing issue in the unit test

Commit d46aab11bf12 ("mcast-snooping: Add and improve mcast-snooping tests.") in master branch consists of both bug fix and a new test. Split the patch for applying bug fix to branch 2.7. Fixes: 94a881c1c8e3e ("ofproto-dpif-xlate: Fix duplicate multicast packets") VMWare-BZ: #1862642 Signed-off-by

Re: [ovs-dev] [PATCH v4 0/5] Backport upstream mpls fix

On 2 May 2017 at 05:03, Simon Horman wrote: > On Mon, May 01, 2017 at 10:24:30AM -0700, Yi-Hung Wei wrote: >> This series backports the upstream mpls fixes and add a system traffic >> test for mpls actions. > > Thanks Yi-Hung, this looks good to me. > > Acked-by: Simon Horman > > Joe, were you co

Re: [ovs-dev] [PATCH 2/2] ovn-controller: add quiet mode

On Mon, May 01, 2017 at 03:02:33PM -0700, Han Zhou wrote: > On Mon, May 1, 2017 at 2:44 PM, Ben Pfaff wrote: > > > > On Fri, Apr 21, 2017 at 06:55:28PM -0700, Han Zhou wrote: > > > As discussed in [1], what the incremental processing code > > > actually accomplished was that the ovn-controller wou

Re: [ovs-dev] [PATCH v4 7/7] checkpatch: fix pointer declaration

On Tue, May 02, 2017 at 12:24:53PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Mon, May 01, 2017 at 04:39:30PM -0400, Aaron Conole wrote: > >> Ben Pfaff writes: > >> > >> > On Mon, May 01, 2017 at 04:14:09PM -0400, Aaron Conole wrote: > >> >> A common way of expressing 'raise to the

Re: [ovs-dev] [PATCH v4 7/7] checkpatch: fix pointer declaration

Ben Pfaff writes: > On Mon, May 01, 2017 at 04:39:30PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Mon, May 01, 2017 at 04:14:09PM -0400, Aaron Conole wrote: >> >> A common way of expressing 'raise to the power of' when authoring >> >> comments uses **. This is currently getting

Re: [ovs-dev] Cover letters (was Re: [PATCH 0/7] Add OVS DPDK keep-alive functionality)

Ben Pfaff writes: > On Mon, May 01, 2017 at 04:45:56PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> ... >> > I think it'd be even better to include measurements in one of the commit >> > messages, because those are available in the repository after the >> > patches are applied. It's harde

[ovs-dev] Utilize your budget wisely.

Hello, Get fresh and accurate data for your marketing campaign. We have recently updated our Ebay users list and have added new contacts in our list. We can provide you contacts across the globe and we can filter the contacts by industry and other filters. We provide 100% opt-in contacts

Re: [ovs-dev] [PATCH] OVN localport type support

On Tue, Apr 25, 2017 at 11:05:28AM +, Daniel Alvarez wrote: > This patch introduces a new type of OVN ports called "localport". > These ports will be present in every hypervisor and may have the > same IP/MAC addresses. They are not bound to any chassis and traffic > to these ports will never g

Re: [ovs-dev] [PATCH v2 3/3] ovn-controller: document command-line options in man page

On Mon, Apr 24, 2017 at 02:57:17PM -0400, Lance Richardson wrote: > Signed-off-by: Lance Richardson Thanks again! I applied this to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 2/3] northd: document command-line options in man page

On Mon, Apr 24, 2017 at 02:57:14PM -0400, Lance Richardson wrote: > Signed-off-by: Lance Richardson This is very nice. Thank you! I applied this to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] Avoid update probe interval to non-zero for unix socket.

On Mon, May 01, 2017 at 05:31:54PM -0700, Han Zhou wrote: > On Mon, May 1, 2017 at 11:19 AM, Ben Pfaff wrote: > > > > On Tue, Apr 18, 2017 at 11:12:14AM -0700, Han Zhou wrote: > > > In commit c1bfdd9d it disables probe when not needed, but commit > > > 715038b6 updates ovn-controller probe interva

Re: [ovs-dev] [PATCH] ovn.at: Fix "ovn -- 1 LR with distributed router gateway port" test

On Tue, May 02, 2017 at 02:48:00PM +0900, Takashi YAMAMOTO wrote: > On Tue, May 2, 2017 at 5:21 AM, Ben Pfaff wrote: > > > On Fri, Apr 21, 2017 at 10:32:57AM +0900, YAMAMOTO Takashi wrote: > > > NetBSD implementation of wc command outputs extra whitespaces > > > like the following. Tweak the tes

[ovs-dev] Confirm Your Bank Info

Dear Cardmember: We are having trouble authorizing your payment method for transaction. Please verify or update your payment method. * * Verify Now If you have any questions, or did not make this change

Re: [ovs-dev] [PATCH v4 0/5] Backport upstream mpls fix

On Mon, May 01, 2017 at 10:24:30AM -0700, Yi-Hung Wei wrote: > This series backports the upstream mpls fixes and add a system traffic > test for mpls actions. Thanks Yi-Hung, this looks good to me. Acked-by: Simon Horman Joe, were you considering applying this? I'm happy to do so myself if ther

Re: [ovs-dev] [RFC] [PATCH 0/6] Add port_group to prevent loopback between interfaces

On 22/04/17 03:45, Ben Pfaff wrote: > On Mon, Apr 03, 2017 at 11:40:54AM +0200, Matthias May wrote: >> When using openvswitch in combination with a hardware switch attached via dsa >> it may be desirable to prevent frames from being looped back to interfaces >> which reside on the same switch and a

[ovs-dev] Bug#858418: openvswitch-switch: deadlock in /usr/share/openvswitch/scripts/ifupdown.sh

Hello, I experienced the same issue on many routers with openvswitch-switch internal interfaces (aka SVIs). Commenting out the status test in '/usr/share/openvswitch/scripts/ifupdown.sh' solves the problem. #if /etc/init.d/openvswitch-switch status > /dev/null 2>&1; then :; else #/etc/i