This is adapted from a talk I gave at OpenStack Summit Sydney on Nov. 6.
Signed-off-by: Ben Pfaff
---
Documentation/automake.mk | 1 +
Documentation/topics/index.rst| 1 +
Documentation/topics/ovn-news-2.8.rst | 377 ++
3 files changed, 379
Open vSwitch has always deleted all flows from the flow table whenever a
controller is configured or whenever all the controllers are unconfigured.
After this commit, OVS additionally deletes all OpenFlow groups.
Suggested-by: Periyasamy Palanisamy
Signed-off-by: Ben Pfaff
---
AUTHORS.rst
Guru, we tried with a single client and did not see the source port translation
happening. As you suggested, we will try it with parallel connections and let
you know what we observe.
Thanks
On 11/6/17, 7:19 PM, "ovs-dev-boun...@openvswitch.org on behalf of Guru Shetty"
wrote:
I guess
I guess, I did not read the original question carefully. I would imagine
that we do port based SNATting, otherwise there would be conflicts. Have
you tried doing parallel connections with the same src port but different
source IP address?
On 6 November 2017 at 19:12, Guru Shetty wrote:
> We don'
We don't have that feature.
On 6 November 2017 at 18:53, Ritesh Rekhi wrote:
> Hi Guru,
>
> Thx for the reply , load balancer can change the dest port if directed to
> a single ip.
>
> The use case we are looking for is PAT where a whole subnet can go to
> internet using same IP .
>
> Thx
> Rite
Hi Guru,
Thx for the reply , load balancer can change the dest port if directed to a
single ip.
The use case we are looking for is PAT where a whole subnet can go to internet
using same IP .
Thx
Ritesh
Sent from my iPhone
On Nov 6, 2017, at 5:56 PM, Guru Shetty mailto:g...@ovn.org>>
wrote:
On Mon, Nov 6, 2017 at 7:33 AM, Alin Gabriel Serdean
wrote:
> From: Alin Serdean
>
> This fixes the static code analysis over the function
> 'OvsGetTcpPayloadLength'.
>
> Signed-off-by: Alin Gabriel Serdean
> ---
> v2: No change.
> ---
>
Acked-by: Shashank Ram
_
On Mon, Nov 6, 2017 at 7:33 AM, Alin Gabriel Serdean
wrote:
> From: Alin Serdean
>
> `ethHdr` cannot be NULL because we did a partial copy before it.
>
> Add an assert to keep the static analysis happy.
>
> Signed-off-by: Alin Gabriel Serdean
> ---
> v2: switch from if to assert
> ---
> datapa
You can use load-balancer with a single destination to achieve port NAtting.
On 6 November 2017 at 16:39, Manoj Sharma wrote:
> Hi Guru, Mickey,
>
>
>
> Does OVN currently support PORT based SNAT? By looking at the code in
> ovn/lib/actions.c, it seems to be doing only IP based NAT.
>
> Can you
From: Alin Serdean
>
> The result of `RtlStringCbLengthW` is not currently checked and triggers
> a warning using the WDK 8.1 static analysis.
>
> This patch treats the result of `RtlStringCbLengthW`.
>
> Signed-off-by: Alin Gabriel Serdean
> ---
> v2: s/Fail/Failed. Suggested by: Shashank Ram r.
From: Alin Serdean
>
> Found by inspection.
>
> Signed-off-by: Alin Gabriel Serdean
> ---
> v2: s/Fail/Failed. Suggested by: Shashank Ram r...@vmware.com
> ---
>
Acked-by: Shashank Ram
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.
a crash is seen in "netdev_ports_remove" when an interface is deleted and added
back in the system and when the interface is part of a bridge configuration.
e.g. steps:
create a tap0 interface using "ip tuntap add.."
add the tap0 interface to br0 using "ovs-vsctl add-port.."
delete the tap0 i
Hi Ben,
I have refactored the function "dpif_port_del" and removed the new function
"dpif_port_remove" added in the v1 patch.
Removed the braces around the if compare.
Sending v2 patch now.
Thanks for the review.
-Ashish
On Fri, Nov 3, 2017 at 2:26 PM, Ben Pfaff wrote:
> On Fri, Nov 03, 2017
On Mon, Nov 6, 2017 at 7:33 AM, Alin Gabriel Serdean
wrote:
> From: Alin Serdean
>
> Use only non-executable memory when using MmGetSystemAddressForMdlSafe.
>
> Introduce a new function called OvsGetMdlWithLowPriority for readability.
>
> Found using WDK 10 static code analysis.
>
> Signed-off-b
Hi Guru, Mickey,
Does OVN currently support PORT based SNAT? By looking at the code in
ovn/lib/actions.c, it seems to be doing only IP based NAT.
Can you please confirm?
This is the NAT table entry:
ovn-nbctl lr-nat-list R1
TYPE EXTERNAL_IPLOGICAL_IPEXTERNAL_MA
From: Browne, Kenadi
Sent: Tuesday, November 7, 2017 6:01 AM
Subject: Full Email Attached.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Nov 06, 2017 at 11:24:56PM +, Jan Scheurich wrote:
> This commit adjusts the NSH user space implementation in OVS to
> the latest wire format defined in draft-ietf-sfc-nsh-28 (November 3
> 2017). The NSH_MDTYPE field was reduced from 8 to 4 bits. The FLAGS
> field is reduced from 8 to 2
On Mon, Nov 06, 2017 at 11:24:54PM +, Jan Scheurich wrote:
> - Fix 2 incorrect length checks
> - Remove unnecessary limit of MD length to 16 bytes
> - Remove incorrect comments stating MD format 2 was not supported
> - Pad metadata in encap_nsh with zeroes to multiple of 4 bytes
>
> Signed-off
This commit adjusts the NSH user space implementation in OVS to
the latest wire format defined in draft-ietf-sfc-nsh-28 (November 3
2017). The NSH_MDTYPE field was reduced from 8 to 4 bits. The FLAGS
field is reduced from 8 to 2 bits. A new 6 bit TTL header field is
added. The TTL field is set to 6
- Fix 2 incorrect length checks
- Remove unnecessary limit of MD length to 16 bytes
- Remove incorrect comments stating MD format 2 was not supported
- Pad metadata in encap_nsh with zeroes to multiple of 4 bytes
Signed-off-by: Jan Scheurich
---
datapath/linux/compat/include/linux/openvswitch.h
This series adapts the userspace implementation for NSH in OVS to the
wire-format specified in the latest NSH IETF draft and fixes a few minor bugs
in the implementation.
The corrections are minimal and primarily meant to be backported to branch-2.8.
The NSH userspace support on master will be
On Mon, Nov 06, 2017 at 02:06:12PM +0800, duanjiong wrote:
>
>
> Signed-off-by: Duan Jiong
Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
FreeBSD insists that be included before and
that be included before . This adds guards to
the "sparse" headers to yield a warning if this order is violated. This
commit also adjusts the order of many #includes to suit this requirement.
Signed-off-by: Ben Pfaff
---
configure.ac
Hi Ben,
> > > It's time to take another look at NSH, by adding support for the latest
> > > draft. I posted a patch to kick this off:
> > >
> > > https://mail.openvswitch.org/pipermail/ovs-dev/2017-November/340365.html
> > >
> > > This is the sort of patch that could be backported to 2.8
On Mon, Nov 06, 2017 at 12:11:58PM +0200, Alin Gabriel Serdean wrote:
> Add `nologo` parameter to MSBuild to suppress the banner.
>
> This will make tidier log messages.
>
> Signed-off-by: Alin Gabriel Serdean
> Acked-by: Alin Balutoiu
Are you looking for more reviews? (Should I ask anyone at
On Mon, Nov 06, 2017 at 06:42:44PM +0800, Yang, Yi wrote:
> On Thu, Nov 02, 2017 at 04:53:15AM +0800, Ben Pfaff wrote:
> > On Wed, Aug 30, 2017 at 02:21:01AM +0800, Yi Yang wrote:
> > > IETF NSH draft will be approved by end of August, NSH header
> > > format has been finalized and won't be change
On Mon, Nov 06, 2017 at 06:51:57PM +0800, Yang, Yi wrote:
> On Thu, Nov 02, 2017 at 04:51:52AM +0800, Ben Pfaff wrote:
> > The NSH draft added a TTL field. This adds basic support.
> >
> > CC: Yi Yang
> > CC: Jan Scheurich
> > Signed-off-by: Ben Pfaff
> > ---
> > include/openvswitch/nsh.h | 1
On Mon, Nov 06, 2017 at 01:19:47PM +0200, aserd...@ovn.org wrote:
> > -Original Message-
> > From: Ben Pfaff [mailto:b...@ovn.org]
> > Sent: Friday, November 3, 2017 8:38 PM
> > To: Alin Gabriel Serdean
> > Cc: d...@openvswitch.org
> > Subject: Re: [ovs-dev] [PATCH 3/4] build-windows: Add
On Mon, Nov 06, 2017 at 05:51:54PM +0200, Alin Gabriel Serdean wrote:
> This series includes fixes that were found while compiling using
> WDK 1709 and Visual Studio 2017.
>
> Alin Gabriel Serdean (3):
> datapath-windows: Add directory to .gitignore
> datapath-windows: Change include type in I
> >From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> >Sent: Tuesday, October 31, 2017 6:46 AM
> >To: Kavanagh, Mark B ; d...@openvswitch.org
> >Subject: Re: [ovs-dev][PATCH] netdev-dpdk: replace uint8_t with
> >dpdk_port_t
> >
> >Thanks. I wanted to remove this function initially, that's why I
On Mon, Nov 06, 2017 at 05:29:26PM +, Bodireddy, Bhanuprakash wrote:
> Hi Ben,
> >
> >On Fri, Sep 15, 2017 at 05:40:23PM +0100, Bhanuprakash Bodireddy wrote:
> >> This commit introduces xnanosleep() for the threads needing high
> >> resolution sleep timeouts.
> >>
> >> Signed-off-by: Bhanupraka
> Add a command to dump vhost-user's information.
>
Thanks for the patch Flavio, I'll take a look in greater depth and test later
this week. On a first pass through though, I'd like to see the command being
added to the OVS DPDK vHost user how to also in documentation, just to double
up on the
Hi Ben,
>
>On Fri, Sep 15, 2017 at 05:40:23PM +0100, Bhanuprakash Bodireddy wrote:
>> This commit introduces xnanosleep() for the threads needing high
>> resolution sleep timeouts.
>>
>> Signed-off-by: Bhanuprakash Bodireddy
>>
>
>This is a little confusing. The name xnanosleep() implies that its
When trying to compile with WDK 10 the files under
datapath-windows/ovsext/Netlink
can't see the headers from datapath-windows/ovsext.
Add the project directory under the include files.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/ovsext.vcxproj | 6 +++---
1 file changed, 3
Found while compiling with VS2017.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/IpHelper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/IpHelper.h
b/datapath-windows/ovsext/IpHelper.h
index 6bda1b1..0556965 100644
--- a/datapath-
Visual Studio 2017 uses `.vs` directory for temporary files.
Add the directory to gitignore.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath-windows/.gitignore b/datapath-windows/.gitignore
index 5d84960..8e8f0c7 1
This series includes fixes that were found while compiling using
WDK 1709 and Visual Studio 2017.
Alin Gabriel Serdean (3):
datapath-windows: Add directory to .gitignore
datapath-windows: Change include type in Iphelper.h
datapath-windows: Add include directory to ovsext project
datapath-w
From: Alin Serdean
If we can't allocate the NBL just go to the cleanup sequence.
Found using WDK 10 static code analysis.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/IpFragment.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath-windows/ovsext/IpFragment.c
b/da
From: Alin Serdean
Check for return value when trying to initialize ovsInstanceListLock.
Also return the status back to caller of `OvsInitIpHelper`.
Signed-off-by: Alin Gabriel Serdean
---
v2: Removed an extra return. Suggested by: Shashank Ram r...@vmware.com
---
datapath-windows/ovsext/IpHe
From: Alin Serdean
This fixes the static code analysis over the function
'OvsGetTcpPayloadLength'.
Signed-off-by: Alin Gabriel Serdean
---
v2: No change.
---
datapath-windows/ovsext/Conntrack.h | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/datapath-wind
From: Alin Serdean
`ethHdr` cannot be NULL because we did a partial copy before it.
Add an assert to keep the static analysis happy.
Signed-off-by: Alin Gabriel Serdean
---
v2: switch from if to assert
---
datapath-windows/ovsext/Actions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/d
From: Alin Serdean
The result of `RtlStringCbLengthW` is not currently checked and triggers
a warning using the WDK 8.1 static analysis.
This patch treats the result of `RtlStringCbLengthW`.
Signed-off-by: Alin Gabriel Serdean
---
v2: s/Fail/Failed. Suggested by: Shashank Ram r...@vmware.com
-
From: Alin Serdean
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
v2: s/Fail/Failed. Suggested by: Shashank Ram r...@vmware.com
---
datapath-windows/ovsext/IpHelper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/IpHelper.c
b/da
From: Alin Serdean
Use only non-executable memory when using MmGetSystemAddressForMdlSafe.
Introduce a new function called OvsGetMdlWithLowPriority for readability.
Found using WDK 10 static code analysis.
Signed-off-by: Alin Gabriel Serdean
---
v2: Change OvsGetMdlWithLowPrio to OvsGetMdlWit
Add a command to dump vhost-user's information.
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 124 -
vswitchd/ovs-vswitchd.8.in | 4 ++
2 files changed, 126 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-d
On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote:
> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh)
> > +{
> > + struct nshhdr *nh;
> > + size_t length = nsh_hdr_len(pushed_nh);
> > + u8 next_proto;
> > +
> > + if (skb->mac_len) {
> > +
On Sun, Nov 5, 2017 at 8:19 PM, Yang, Yi wrote:
> On Sat, Nov 04, 2017 at 10:29:46PM +0800, Pravin Shelar wrote:
>> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote:
>> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh)
>> > +{
>> > + struct nshhdr *nh;
>> > + size_t l
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Friday, November 3, 2017 8:38 PM
> To: Alin Gabriel Serdean
> Cc: d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 3/4] build-windows: Add check for struct
> timespec
>
> On Wed, Nov 01, 2017 at 07:19:06PM +0200, Ali
On Thu, Nov 02, 2017 at 04:51:52AM +0800, Ben Pfaff wrote:
> The NSH draft added a TTL field. This adds basic support.
>
> CC: Yi Yang
> CC: Jan Scheurich
> Signed-off-by: Ben Pfaff
> ---
> include/openvswitch/nsh.h | 11 +++
> lib/flow.c| 2 +-
> lib/odp-execute.c
On Thu, Nov 02, 2017 at 04:53:15AM +0800, Ben Pfaff wrote:
> On Wed, Aug 30, 2017 at 02:21:01AM +0800, Yi Yang wrote:
> > IETF NSH draft will be approved by end of August, NSH header
> > format has been finalized and won't be change anymore, so we
> > need to follow this final spec to implement nsh
Add a new variable to know on which platform we are compiling.
Make the msbuild command to be aware of the platform we want to build.
Shorter the msbuild parameters from `property:`->`p:`. Change slashes
to double slashes so msys does not get confused.
Signed-off-by: Alin Gabriel Serdean
Acked-
Add variables to know for which platform we are building.
They are needed for the installer to know if it should install
in `Program Files (x86)` or `Program Files` and which registry
it needs to update.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Alin Balutoiu
---
v2: Change comment phrasing
Unfortunately all WIX binaries (candle, heat, etc) are only 32 bit (up to
the latest version 3.11).
For performance reasons they are run as .NET assemblies inside the MSBuild
process. Running 32 bit assemblies inside a 64 bit process (MSBuild) makes
them segfault.
Add a new option for heat to be
Until now the x64 build of the installer solution was pointing to the
x86 build of the WIX project.
This patch changes for them to match.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Alin Balutoiu
---
v2: Add acked
---
windows/ovs-windows-installer.sln | 4 ++--
1 file changed, 2 insertions(+
Add `nologo` parameter to MSBuild to suppress the banner.
This will make tidier log messages.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Alin Balutoiu
---
v2: Add acked
---
Makefile.am | 8
datapath-windows/automake.mk | 4 ++--
windows/automake.mk | 2 +-
Remove duplicate and obsolete entries from the installer WIX project.
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Alin Balutoiu
---
v2: Add acked
---
.../ovs-windows-installer.wixproj | 36 --
1 file changed, 36 deletions(-)
diff --g
56 matches
Mail list logo
