Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Propagate nb_cfg to the local OVS DB.

2020-11-18 Thread Numan Siddique
On Wed, Nov 18, 2020 at 6:27 PM Dumitru Ceara wrote: > > The NB.NB_Global.nb_cfg value gets propagated to > Chassis_Private.nb_cfg (and then to NB.NB_Global.hv_cfg) as soon as > ovn-controller has finished installing OVS flows corresponding to > the NB DB state. > > However, if the CMS runs

Re: [ovs-dev] [PATCH ovn v7 0/5] Add DDlog implementation of ovn-northd

2020-11-18 Thread Numan Siddique
On Thu, Nov 19, 2020 at 10:43 AM Ben Pfaff wrote: > > v1->v2: > - Applied several patches. > - New commit to add documentation for the system-userspace testsuite. > - New patches to improve the testsuite a couple of ways. > - Revised "Prepare for multiple northd types" to fix

Re: [ovs-dev] [PATCH ovn] northd: Fix leak of lflow scratchpads.

2020-11-18 Thread Numan Siddique
On Thu, Nov 19, 2020 at 4:28 AM Ilya Maximets wrote: > > Dynamic strings that backs 'match' and 'actions' are never destroyed > and leaked on every lflow re-build cycle. > > 28,224 bytes in 126 blocks are definitely lost in loss record 494 of 498 > at 0x483BD19: realloc

[ovs-dev] Loan Offer

2020-11-18 Thread Roland Marcus via dev
Hello, Apply for a loan, at a 3% interest rate. Do you need a personal loan? Do you need a business loan? Do you need a consolidation loan? Do you need a secure loan? Do you need an unsecured loan? Do you need a mortgage loan? Do you need a pay off debt loan?

Re: [ovs-dev] [PATCH ovn v7 5/5] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-18 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #4617 FILE: northd/ovn-northd-ddlog.c:1271: * XXX If the

Re: [ovs-dev] [PATCH ovn v7 1/5] Export `VLOG_WARN` and `VLOG_ERR` from libovn for use in ddlog

2020-11-18 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

[ovs-dev] [PATCH ovn v7 2/5] tests: Prepare for multiple northd types.

2020-11-18 Thread Ben Pfaff
The idea is to run each test twice, once with ovn-northd, once with ovn-northd-ddlog. To do that, we add a macro OVN_FOR_EACH_NORTHD and bracket each test that uses ovn-northd in it. Signed-off-by: Ben Pfaff --- tests/ovn-ic.at | 11 +- tests/ovn-macros.at | 96 ++--

[ovs-dev] [PATCH ovn v7 3/5] tests: Eliminate most "sleep" calls.

2020-11-18 Thread Ben Pfaff
Many of these could be replaced by "ovn-nbctl sync". Some weren't really needed at all because they were adjacent to something that itself called sync or otherwise used --wait. Some were more appropriately done with explicit waits for what was really needed. I left some "sleep"s. Some were

[ovs-dev] [PATCH ovn v7 4/5] tests: Improve debuggability of tests.

2020-11-18 Thread Ben Pfaff
These changes should make it easier to debug various tests. Signed-off-by: Ben Pfaff --- tests/ovn-controller-vtep.at | 6 +- tests/ovn-northd.at | 129 - tests/ovn.at | 348 +++ tests/ovs-macros.at | 20 +- 4

[ovs-dev] [PATCH ovn v7 1/5] Export `VLOG_WARN` and `VLOG_ERR` from libovn for use in ddlog

2020-11-18 Thread Ben Pfaff
From: Leonid Ryzhyk Export `ddlog_warn` and `ddlog_err` functions that are just wrappers around `VLOG_WARN` and `VLOG_ERR`. This is not ideal because the functions are exported by `ovn_util.c` and the resulting log messages use `ovn_util` as module name. More importantly, these functions do

[ovs-dev] [PATCH ovn v7 0/5] Add DDlog implementation of ovn-northd

2020-11-18 Thread Ben Pfaff
v1->v2: - Applied several patches. - New commit to add documentation for the system-userspace testsuite. - New patches to improve the testsuite a couple of ways. - Revised "Prepare for multiple northd types" to fix system-userspace testsuite. - Updated DDlog implementation of northd

Re: [ovs-dev] [PATCH] Allow to create tunnel ports with the same config

2020-11-18 Thread Ben Pfaff
On Wed, Nov 18, 2020 at 10:35:01PM -0500, Ihar Hrachyshka wrote: > It's a legal setup where tunnel ports with the same config are created > on different bridges served by Open vSwitch. Specifically, multiple > OVN controllers may emulate multiple chassis running on the same > physical host, in

Re: [ovs-dev] [PATCH ovn v5 5/8] tests: Eliminate most "sleep" calls.

2020-11-18 Thread Ben Pfaff
On Thu, Nov 12, 2020 at 12:25:24PM +0100, Dumitru Ceara wrote: > On 11/12/20 2:45 AM, Ben Pfaff wrote: > > Many of these could be replaced by "ovn-nbctl sync". Some weren't > > really needed at all because they were adjacent to something that itself > > called sync or otherwise used --wait. Some

Re: [ovs-dev] Referral - Credit Card Processing Fee Change (15 U.S. Code 1693o 2)

2020-11-18 Thread Amber Gauwain
Paying more than $500/month in Visa/MasterCard Credit Card Processing Fees? Give me 3 minutes to explain your alternative. 1) How much of your profit margin is 'spent' on fees every month? Tired of paying? Your processor isn't telling you about all the available options. Why don't they

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Fix nb_cfg update with monitor_cond_change in flight.

2020-11-18 Thread Ben Pfaff
On Tue, Nov 17, 2020 at 05:50:20PM +0100, Dumitru Ceara wrote: > It is not correct for ovn-controller to pass the current SB_Global.nb_cfg > value to ofctrl_put() if there are pending changes to conditional > monitoring clauses (local or in flight). It might be that after the > monitor condition

Re: [ovs-dev] [PATCH ovn v5 2/8] tests: Prepare for multiple northd types.

2020-11-18 Thread Ben Pfaff
On Thu, Nov 12, 2020 at 09:45:02AM +0100, Dumitru Ceara wrote: > Except the two minor comments above, the rest looks good to me: > > Acked-by: Dumitru Ceara Thanks, those will be fixed for v6, and I've added your ack. ___ dev mailing list

Re: [ovs-dev] [PATCH ovn v5 8/8] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-18 Thread Ben Pfaff
On Thu, Nov 12, 2020 at 05:15:45PM -0500, Flavio Fernandes wrote: > Sorry for making more work for you but > Could we also do something for the "make sandbox" target, where > we could have the ovn_start function optionally use ovn-northd-ddlog ? > Something like: > > make sandbox --ddlog

Re: [ovs-dev] [PATCH ovn v5 8/8] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-18 Thread Ben Pfaff
Can you explain further? I guess you must be saying that there is a dependency problem in v5, but I don't see the issue yet. On Thu, Nov 12, 2020 at 05:35:48PM -0500, Flavio Fernandes wrote: > Hm.. > > Could it be that you inadvertently remove this change in V5 ? > > > diff --git

Re: [ovs-dev] Order

2020-11-18 Thread heisaiboyakumeru
I've invited you to fill out the following form: Re: Order To fill it out, visit: https://docs.google.com/forms/d/e/1FAIpQLSdHKME52pOBKY4jFVW587totG-ZzKRT8P8yZZ-abPmsGaCvug/viewform?vc=0c=0w=1flr=0usp=mail_form_link Ive invited you to fill out a form: Google Forms: Create and analyze surveys.

Re: [ovs-dev] [PATCH] Update tutorial for newer versions of Faucet and Open vSwitch.

2020-11-18 Thread Brad Cowie
Hi Ilya, Sorry for the late reply, this email got lost in my inbox. Yes this patch is still good to go and happy for it to be merged. Thanks, Brad On 10/09/20 12:39 am, Ilya Maximets wrote: On 9/12/18 1:53 AM, Brad Cowie wrote: Newer versions of Faucet use a dynamic OpenFlow pipeline based

Re: [ovs-dev] [PATCH v12 ovn] Allow to run multiple controllers on the same machine

2020-11-18 Thread Ihar Hrachyshka
Note: this patch requires https://patchwork.ozlabs.org/project/openvswitch/patch/20201119033501.798597-1-ihrac...@redhat.com/ to allow OVN controller to complete tunnel port creation for multiple virtual colocated chassis to connect to a remote chassis. On Wed, Nov 18, 2020 at 10:21 PM Ihar

[ovs-dev] [PATCH] Allow to create tunnel ports with the same config

2020-11-18 Thread Ihar Hrachyshka
It's a legal setup where tunnel ports with the same config are created on different bridges served by Open vSwitch. Specifically, multiple OVN controllers may emulate multiple chassis running on the same physical host, in which case they may need to create separate tunnel ports to connect to the

Re: [ovs-dev] [PATCH v11 ovn] Allow to run multiple controllers on the same machine

2020-11-18 Thread Ihar Hrachyshka
On Tue, Nov 10, 2020 at 9:31 PM Ihar Hrachyshka wrote: > > On Tue, Nov 10, 2020 at 10:25 AM Numan Siddique wrote: > > > > " > > > > On Tue, Nov 3, 2020 at 4:45 AM Ihar Hrachyshka wrote: > > > > > > User stories: > > > 1) NFV: an admin wants to run two separate instances of OVN controller > > >

[ovs-dev] [PATCH v12 ovn] Allow to run multiple controllers on the same machine

2020-11-18 Thread Ihar Hrachyshka
User stories: 1) NFV: an admin wants to run two separate instances of OVN controller using the same database but configuring ports on different bridges. Some of these bridges may use DPDK while others may not. 2) Parallel OVN instances: an admin wants to run two separate instances of OVN

Re: [ovs-dev] Referral - Credit Card Processing - Unlimited Flat Fee Processing - Free Equipment

2020-11-18 Thread Darla Brancanto
Paying more than $500/month in Visa/MasterCard Credit Card Processing Fees? Give me 3 minutes to explain your alternative. 1) How much of your profit margin is 'spent' on fees every month? Tired of paying? Your processor isn't telling you about all the available options. Why don't they

Re: [ovs-dev] [PATCH] jsonrpc: Avoid disconnecting prematurely due to long poll intervals.

2020-11-18 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #118 FILE: lib/reconnect.c:568:

Re: [ovs-dev] [PATCH] Update scripts to support RHEL 7.9

2020-11-18 Thread Gregory Rose
Thanks again Guru! From: Guru Shetty Sent: Wednesday, November 18, 2020 2:32 PM To: Greg Rose Cc: ovs dev ; Gregory Rose Subject: Re: [ovs-dev] [PATCH] Update scripts to support RHEL 7.9 On Tue, 17 Nov 2020 at 13:32, Greg Rose mailto:gvrose8...@gmail.com>> wrote: From: Greg Rose

[ovs-dev] ovs-vswitchd with DPDK crashed when guest VM restarts network service

2020-11-18 Thread Alex Yeh (ayeh) via dev
Hi, We are seeing a ovs-vswitchd service crash with segfault in the librte_vhost library when a DPDK application within a guest VM is stopped. We are using OVS 2.11.1 on CentOS 7.6 (3.10.0-1062 Linux kernel) with DPDK 18.11.2. We are using OVS-DPDK

[ovs-dev] Errores comunes al utilizar la herramienta

2020-11-18 Thread Robot en Whatsapp Business
Webinar en Vivo: Cómo aumentar tus ventas con Whatsapp Business - 05 de Diciembre Whatsapp robot: cómo configurarlo para incrementar tus ventas - 12 de Diciembre - Horario de 10:00 a 14:00 Hrs.- BUEN FIN: 3 x 2 en todos nuestros cursos. Promoción válida durante noviembre y diciembre 2020 así

Re: [ovs-dev] ovsdb-idl conditional monitoring change bug

2020-11-18 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ben Pfaff needs to sign off. Lines checked: 41, Warnings: 0, Errors: 1 Please

[ovs-dev] [PATCH] jsonrpc: Avoid disconnecting prematurely due to long poll intervals.

2020-11-18 Thread Ben Pfaff
Open vSwitch has a few different jsonrpc-based protocols that depend on jsonrpc_session to make sure that the connection is up and working. In turn, jsonrpc_session uses the "reconnect" state machine to send probes if nothing is received. This works fine in normal circumstances. In unusual

[ovs-dev] ovsdb-idl conditional monitoring change bug

2020-11-18 Thread Ben Pfaff
There appears to be some bug in the ovsdb-idl logic for sending updates to the condition for conditional monitoring, exposed by test 2128 "simple idl, monitor_cond_since, cluster disconnect - C - tcp". When I apply the following patch, which should only affect performance (it just reduces the

[ovs-dev] [PATCH ovn] northd: Fix leak of lflow scratchpads.

2020-11-18 Thread Ilya Maximets
Dynamic strings that backs 'match' and 'actions' are never destroyed and leaked on every lflow re-build cycle. 28,224 bytes in 126 blocks are definitely lost in loss record 494 of 498 at 0x483BD19: realloc (vg_replace_malloc.c:834) by 0x4AEF14: xrealloc (util.c:149) by 0x465533:

[ovs-dev] WAITING FOR YOUR REPLY

2020-11-18 Thread djasylveste
Je vous ai invité à remplir le formulaire suivant : Formulaire sans titre Pour remplir ce formulaire, consultez : https://docs.google.com/forms/d/e/1FAIpQLSfXfG9XBYZC7KFtw3wnfupfhEto4MofdMOvQ9-aFcCC5PTL4g/viewform?vc=0c=0w=1flr=0usp=mail_form_link Dear Friend, I am Mr sylveste djakpa, work in

Re: [ovs-dev] [PATCH] Update scripts to support RHEL 7.9

2020-11-18 Thread Guru Shetty
On Tue, 17 Nov 2020 at 13:32, Greg Rose wrote: > From: Greg Rose > > Add support for RHEL7.9 GA release with kernel 3.10.0-1160 > > Signed-off-by: Greg Rose > --- > Thank you. I applied this to master. > rhel/openvswitch-kmod-fedora.spec.in | 6 -- >

[ovs-dev] [PATCH] checkpatch: Add check for a whitespace after cast.

2020-11-18 Thread Ilya Maximets
Coding style says: "Put a space between the ``()`` used in a cast and the expression whose type is cast: ``(void *) 0``.". This style rule is frequently overlooked. Let's check for it. Signed-off-by: Ilya Maximets --- tests/checkpatch.at | 17 + utilities/checkpatch.py | 13

[ovs-dev] [PATCH] perf-counter: Split numbers in the output.

2020-11-18 Thread Ilya Maximets
While trying to benchmark big functions, values could be longer than 12 digits. In this case all of them printed without spaces. It's hard ot read. Fixes: 619c3a42dc1e ("lib: add a hardware performance counter access library") Signed-off-by: Ilya Maximets --- lib/perf-counter.c | 2 +- 1 file

Re: [ovs-dev] OVS-DPDK patch review list update

2020-11-18 Thread Ilya Maximets
On 11/18/20 8:54 PM, Stokes, Ian wrote: > Hi All, > > Please see the updated patch review list from this week's call. > > Regards > Ian > > > Patch List > > Stats to Date for patch series > > Merged: 9 > Merge Candidate: 0 > Review in progress: 4 > No review in progress: 2 > Deferred: 3 >

[ovs-dev] OVS-DPDK patch review list update

2020-11-18 Thread Stokes, Ian
Hi All, Please see the updated patch review list from this week's call. Regards Ian Patch List Stats to Date for patch series Merged: 9 Merge Candidate: 0 Review in progress: 4 No review in progress: 2 Deferred: 3 Dropped: 2 === Merge Candidate (Close to merging) === N/A === Review In

Re: [ovs-dev] [PATCH dpdk-latest v1] build: Remove DPDK make build references.

2020-11-18 Thread Pai G, Sunil
Hi Ilya , Ian Thank you for the comments , response inline. > -Original Message- > From: Ilya Maximets > Sent: Wednesday, November 18, 2020 10:26 PM > To: Stokes, Ian ; Pai G, Sunil ; > d...@openvswitch.org > Cc: i.maxim...@ovn.org; david.march...@redhat.com; >

[ovs-dev] Play Hard Play Strong with our SPECIAL

2020-11-18 Thread Annette Snipe
image image imageimage image Javanen bekoeld evenals witheid op ze bezocht al ijzeren. Plaats alleen rijken de andere op. Afscheidt entrepots ik nu resideert en regentijd. Er interest schaffen hellende nu. Bladen af zijden om dreigt nu en slecht binnen. Veertien onnoodig

[ovs-dev] Fwd: Dringende overweging!76868

2020-11-18 Thread Lakshya Yashvir
Goedendag, Ik vertegenwoordig een familie die geld dat hier in Zuid-Afrika is gespaard (€ 45.000.000,00) moet investeren in een veilige economie in Europa. De reden hiervoor is de onzekere druk van de pandemie op onze economie. Heeft u investeringsvermogen? Of kunt u me gewoon helpen om

[ovs-dev] FEEL STRONGER & PLAY LONGER

2020-11-18 Thread Doris Khaleel
image image imageimage image Javanen bekoeld evenals witheid op ze bezocht al ijzeren. Plaats alleen rijken de andere op. Afscheidt entrepots ik nu resideert en regentijd. Er interest schaffen hellende nu. Bladen af zijden om dreigt nu en slecht binnen. Veertien onnoodig

Re: [ovs-dev] [PATCH V2] Update scripts to support RHEL 7.9

2020-11-18 Thread Yifeng Sun
LGTM. Reviewed-by: Yifeng Sun On Tue, Nov 17, 2020 at 3:26 PM Greg Rose wrote: > Add support for RHEL7.9 GA release with kernel 3.10.0-1160 > > Signed-off-by: Greg Rose > > --- > V2 - Correct the author > --- > rhel/openvswitch-kmod-fedora.spec.in | 6 -- >

[ovs-dev] Cierre fiscal 2020 de las personas morales.

2020-11-18 Thread Recomendaciones para la correcta elaboración
Webinar en Vivo: Puntos finos del cierre fiscal 2020 de las personas morales. Jueves 03 de Diciembre - Horario de 10:00 a 17:00 Hrs. BUEN FIN: 3 x 2 en todos nuestros cursos. Promoción válida durante noviembre y diciembre 2020 así como enero 2021 Identificaremos y conoceremos los puntos finos

[ovs-dev] Play Hard Play Strong with our SPECIAL

2020-11-18 Thread Helen Nilles
image image imageimage image Javanen bekoeld evenals witheid op ze bezocht al ijzeren. Plaats alleen rijken de andere op. Afscheidt entrepots ik nu resideert en regentijd. Er interest schaffen hellende nu. Bladen af zijden om dreigt nu en slecht binnen. Veertien onnoodig

Re: [ovs-dev] [PATCH v3 09/10] dpif-netdev: enable ISA optimized DPIF and miniflow extract

2020-11-18 Thread 0-day Robot
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CXX --mode=link g++ -std=gnu++11 -g -O2 -o

Re: [ovs-dev] [PATCH v3 07/10] dpif-netdev: Add command to switch dpif implementation

2020-11-18 Thread 0-day Robot
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH v3 06/10] dpif-avx512: Add ISA implementation of dpif

2020-11-18 Thread 0-day Robot
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH v3 03/10] dpif-netdev: Refactor to multiple header files

2020-11-18 Thread 0-day Robot
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH v3 01/10] dpdk: Cache result of CPU ISA checks

2020-11-18 Thread 0-day Robot
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH dpdk-latest v1] build: Remove DPDK make build references.

2020-11-18 Thread Ilya Maximets
On 11/17/20 5:38 PM, Stokes, Ian wrote: >> Building DPDK using Make is removed since DPDK 20.08. >> Hence, remove its references in OVS as well. >> While at it, address few comments on the commit [1]. >> > > Thanks for the patch, just a few comments below. > > @Ilya, I think Sunil has addressed

[ovs-dev] [PATCH v3 08/10] dpif-netdev/dpcls: Refactor function names to dpcls

2020-11-18 Thread Harry van Haaren
This commit refactors the function names from netdev_* namespace to the dpcls_* namespace, as they are only used by dpcls code. With the name change, it becomes more obvious that the functions belong to dpcls functionality, and in the dpif-netdev-private-dpcls.h header file. Signed-off-by: Harry

[ovs-dev] [PATCH v3 07/10] dpif-netdev: Add command to switch dpif implementation

2020-11-18 Thread Harry van Haaren
This commit adds a new command to allow the user to switch the active DPIF implementation at runtime. A probe function is executed before switching the DPIF implementation, to ensure the CPU is capable of running the ISA required. For example, the below code will switch to the AVX512 enabled DPIF

[ovs-dev] [PATCH v3 06/10] dpif-avx512: Add ISA implementation of dpif

2020-11-18 Thread Harry van Haaren
This commit adds the AVX512 implementation of DPIF functionality, specifically the dp_netdev_input_outer_avx512 function. This function only handles outer (no re-circulations), and is optimized to use the AVX512 ISA for packet batching and other DPIF work. Sparse is not able to handle the AVX512

[ovs-dev] [PATCH v3 09/10] dpif-netdev: enable ISA optimized DPIF and miniflow extract

2020-11-18 Thread Harry van Haaren
This commit refactors the way in which the DPIF component can call the miniflow-extract function. It creates flexibility in the DPIF component by adding a function pointer at the pmd level. A new miniflow extract implementation is created which allows the AVX-512 SIMD instructions to perform the

[ovs-dev] [PATCH v3 10/10] dpif-netdev: enable scalar datapath with optimized miniflow extract

2020-11-18 Thread Harry van Haaren
This commit enables the scalar datapath to utilize the SIMD accelerated packet parsing for the parsing of the outer packet. Signed-off-by: Harry van Haaren --- lib/dpif-netdev.c | 46 ++ 1 file changed, 30 insertions(+), 16 deletions(-) diff --git

[ovs-dev] [PATCH v3 03/10] dpif-netdev: Refactor to multiple header files

2020-11-18 Thread Harry van Haaren
Split the very large file dpif-netdev.c and the datastructures it contains into multiple header files. Each header file is responsible for the datastructures of that component. This logical split allows better reuse and modularity of the code, and reduces the very large file dpif-netdev.c to be

[ovs-dev] [PATCH v3 02/10] dpif-netdev: Move pmd_try_optimize function in file

2020-11-18 Thread Harry van Haaren
This commit moves the pmd_try_optimize function to a more appropriate location in the file - currently it sits in the DPCLS section, which is not its correct home. Signed-off-by: Harry van Haaren --- lib/dpif-netdev.c | 146 +++--- 1 file changed, 73

[ovs-dev] [PATCH v3 04/10] dpif-netdev: Split hwol out to own header file

2020-11-18 Thread Harry van Haaren
This commit moves the datapath lookup functions required for hardware offload to a seperate file. This allows other DPIF implementations to access the lookup functions, encouraging code reuse. Signed-off-by: Harry van Haaren --- v2: Fixed copyright header --- lib/automake.mk|

[ovs-dev] [PATCH v3 05/10] dpif-netdev: Add function pointer for netdev input

2020-11-18 Thread Harry van Haaren
This commit adds a function pointer to the pmd thread data structure, giving the pmd thread flexibility in its dpif-input function choice. This allows choosing of the implementation based on ISA capabilities of the runtime CPU, leading to optimizations and higher performance. Signed-off-by: Harry

[ovs-dev] [PATCH v3 00/10] DPIF & MFEX Refactor and AVX512 SIMD optimization

2020-11-18 Thread Harry van Haaren
v3 update Summary: (Cian Ferriter helping with rebases, review and code cleanups) - Split out partially related changes (these will be sent separately) --- netdev output action optimization --- avx512 dpcls 16-block support optimization - Squash commit which moves netdev struct flow into the

[ovs-dev] [PATCH v3 01/10] dpdk: Cache result of CPU ISA checks

2020-11-18 Thread Harry van Haaren
As a small optimization, this patch caches the result of a CPU ISA check from DPDK. Particularly in the case of running the DPCLS autovalidator (which repeatedly probes subtables) this reduces the amount of CPU ISA lookups from the DPDK level. By caching them at the OVS/dpdk.c level, the ISA

Re: [ovs-dev] [PATCH v2] python: Update build system to ensure dirs.py is created

2020-11-18 Thread Ilya Maximets
On 11/17/20 7:02 PM, Mark Gray wrote: > Update build system to ensure dirs.py is created when it is a > dependency for a build target. Also, update setup.py to > check for that dependency. > > Signed-off-by: Mark Gray > --- > > v2: Added v2 tag > > lib/automake.mk | 2 +- >

[ovs-dev] [PATCH ovn v3] Provide the option to pin ovn-controller and ovn-northd to a specific version.

2020-11-18 Thread numans
From: Numan Siddique OVN recommends updating/upgrading ovn-controllers first and then ovn-northd and OVN DB ovsdb-servers. This is to ensure that any new functionality specified by the database or logical flows created by ovn-northd is understood by ovn-controller. However certain deployments

Re: [ovs-dev] [PATCH ovn v2] Provide the option to pin ovn-controller and ovn-northd to a specific version.

2020-11-18 Thread Numan Siddique
On Wed, Nov 18, 2020 at 6:52 PM Dumitru Ceara wrote: > > On 11/18/20 2:08 PM, Numan Siddique wrote: > > On Wed, Nov 18, 2020 at 5:23 PM Dumitru Ceara wrote: > >> > >> On 11/17/20 12:57 PM, num...@ovn.org wrote: > >>> From: Numan Siddique > >>> > >>> OVN recommends updating/upgrading

Re: [ovs-dev] [PATCH ovn v2] Provide the option to pin ovn-controller and ovn-northd to a specific version.

2020-11-18 Thread Dumitru Ceara
On 11/18/20 2:08 PM, Numan Siddique wrote: > On Wed, Nov 18, 2020 at 5:23 PM Dumitru Ceara wrote: >> >> On 11/17/20 12:57 PM, num...@ovn.org wrote: >>> From: Numan Siddique >>> >>> OVN recommends updating/upgrading ovn-controllers first and then >>> ovn-northd and OVN DB ovsdb-servers. This is

Re: [ovs-dev] [PATCH ovn v2] Provide the option to pin ovn-controller and ovn-northd to a specific version.

2020-11-18 Thread Numan Siddique
On Wed, Nov 18, 2020 at 5:23 PM Dumitru Ceara wrote: > > On 11/17/20 12:57 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > OVN recommends updating/upgrading ovn-controllers first and then > > ovn-northd and OVN DB ovsdb-servers. This is to ensure that any > > new functionality

[ovs-dev] [PATCH ovn v2] ovn-controller: Propagate nb_cfg to the local OVS DB.

2020-11-18 Thread Dumitru Ceara
The NB.NB_Global.nb_cfg value gets propagated to Chassis_Private.nb_cfg (and then to NB.NB_Global.hv_cfg) as soon as ovn-controller has finished installing OVS flows corresponding to the NB DB state. However, if the CMS runs monitoring applications on the chassis itself, in order to detect that

Re: [ovs-dev] [PATCH ovn v2] Provide the option to pin ovn-controller and ovn-northd to a specific version.

2020-11-18 Thread Dumitru Ceara
On 11/17/20 12:57 PM, num...@ovn.org wrote: > From: Numan Siddique > > OVN recommends updating/upgrading ovn-controllers first and then > ovn-northd and OVN DB ovsdb-servers. This is to ensure that any > new functionality specified by the database or logical flows created > by ovn-northd is

Re: [ovs-dev] [PATCH ovn v5 7/7] sbctl: Add Load Balancer support for vflows option.

2020-11-18 Thread Dumitru Ceara
On 11/17/20 3:28 PM, num...@ovn.org wrote: > From: Numan Siddique > > Signed-off-by: Numan Siddique > --- Acked-by: Dumitru Ceara ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v5 6/7] ovn-detrace: Add SB Load Balancer cookier handler.

2020-11-18 Thread Dumitru Ceara
On 11/17/20 3:28 PM, num...@ovn.org wrote: > From: Numan Siddique > > Signed-off-by: Numan Siddique > --- Acked-by: Dumitru Ceara ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v5 5/7] northd: Make use of new hairpin actions.

2020-11-18 Thread Dumitru Ceara
On 11/17/20 3:28 PM, num...@ovn.org wrote: > From: Numan Siddique > > This patch makes use of the new hairpin OVN actions - chk_lb_hairpin, > chk_lb_hairpin_reply > and ct_snat_to_vip. > > Suppose there are 'm' load balancers associated to a logical switch and each > load balancer > has 'n'

Re: [ovs-dev] [PATCH ovn v5 4/7] actions: Add new actions chk_lb_hairpin, chk_lb_hairpin_reply and ct_snat_to_vip.

2020-11-18 Thread Dumitru Ceara
On 11/17/20 3:28 PM, num...@ovn.org wrote: > From: Numan Siddique > > The action - chk_lb_hairpin checks if the packet destined to a load balancer > VIP > is to be hairpinned back to the same destination and if so, sets the > destination register > bit to 1. > > The action -

Re: [ovs-dev] [PATCH ovn v5 3/7] controller: Add load balancer hairpin OF flows.

2020-11-18 Thread Dumitru Ceara
On 11/17/20 3:28 PM, num...@ovn.org wrote: > From: Numan Siddique > > Presently to handle the load balancer hairpin traffic (the traffic destined > to the > load balancer VIP is dnatted to the backend which originated the traffic), > ovn-northd > adds a lot of logical flows to check this