On Fri, Nov 20, 2020 at 8:04 AM Mark Michelson wrote:
>
> For the series:
>
> Acked-by: Mark Michelson
Thanks Dumitru and Mark for the reviews. I applied this series to master.
@Ben - There are changes in ovn-northd in this series which would
break the ddlog tests.
When you respin another versi
Jakub Kicinski wrote:
> On Mon, 16 Nov 2020 18:31:26 +0530 nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > There is no easy way to distinguish if a conntracked tcp packet is
> > marked invalid because of tcp_in_window() check error or because
> > it doesn't belong to an existing conn
On Mon, 16 Nov 2020 18:31:26 +0530 nusid...@redhat.com wrote:
> From: Numan Siddique
>
> There is no easy way to distinguish if a conntracked tcp packet is
> marked invalid because of tcp_in_window() check error or because
> it doesn't belong to an existing connection. With this patch,
> openvswi
LGTM.
--
taoyunxi...@cmss.chinamobile.com
>CC: Tao YunXiang
>Fixes: 5820502a5507 ("ovn-nbctl.c: Fix lr-policy-del command")
>Signed-off-by: Ilya Maximets
>---
> utilities/ovn-nbctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
My name is Sheryll Goedert. I was lucky enough to win a Powerball lottery
jackpot of $396.9 million on the Powerball lottery. Congratulations, your
email has won a donation of 3,200,000:00€. Contact me about the claim Via
Email: goederts...@gmail.com
__
For the series:
Acked-by: Mark Michelson
On 11/17/20 9:26 AM, num...@ovn.org wrote:
From: Numan Siddique
This patch series optimizes the load balancer hairpin logical flows.
Presently, ovn-northd generates a lot of these logical flows.
Suppose there are 'm' load balancers associated to a lo
Hi Numan,
I have one minor nit below. If you either address it or can explain it
away, then:
Acked-by: Mark Michelson
On 11/18/20 9:14 AM, num...@ovn.org wrote:
From: Numan Siddique
OVN recommends updating/upgrading ovn-controllers first and then
ovn-northd and OVN DB ovsdb-servers. This
Hi Ilya,
With regards to the test failures, I also see test 58 fail.
Test 59 sometimes passes and sometimes fails. I saw the crash you
referenced one time out of probably 25 test runs. As a double-check, I
reverted this series and ran the test in a loop. I never saw the test
fail or crash :(.
Webinar en Vivo:
Microsoft Excel: tablas dinámicas.
05 y 12de Diciembre - Horario de 10:00 a 14:00 Hrs.
BUEN FIN: 3 x 2 en todos nuestros cursos. Promoción válida durante noviembre y
diciembre 2020 así como enero 2021
Nuestro curso está diseñado para enseñarte a importar o construir bases de
d
On 11/19/20 8:40 PM, Ilya Maximets wrote:
> Result of 'normalize_v46_prefix()' should be freed and all dynamic
> strings should be destroyed.
>
> Direct leak of 156 byte(s) in 13 object(s) allocated from:
> #0 0x53700f in malloc (northd/ovn-northd+0x53700f)
> #1 0x71b146 in xmalloc ovs/l
CC: Tao YunXiang
Fixes: 5820502a5507 ("ovn-nbctl.c: Fix lr-policy-del command")
Signed-off-by: Ilya Maximets
---
utilities/ovn-nbctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
index 448c86f42..fa1522152 100644
--- a/utilities/ovn-nbctl.c
+
Cleanup needed instead of direct return.
Fixes: 43f42ecb3a5a ("Use normalized IP addreses in `ovn-nbctl lr-nat-add`")
Signed-off-by: Ilya Maximets
---
utilities/ovn-nbctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
index 895
CC: Ankur Sharma
Fixes: 20bc58a67f39 ("External IP based NAT: Add Columns and CLI")
Signed-off-by: Ilya Maximets
---
utilities/ovn-nbctl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
index fb6766839..89537edf0 100644
--- a/utilities/ovn-nb
'group_ports' never destroyed and re-created on each iteration.
CC: Manoj Sharma
Fixes: edb240081518 ("Forwarding group to load balance l2 traffic with liveness
detection")
Signed-off-by: Ilya Maximets
---
northd/ovn-northd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
CC: Manoj Sharma
Fixes: edb240081518 ("Forwarding group to load balance l2 traffic with liveness
detection")
Signed-off-by: Ilya Maximets
---
lib/actions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/actions.c b/lib/actions.c
index ea949e1bd..99ce04197 100644
--- a/lib/actions.c
+++
Fixes: 742474bad730 ("ovn-nbctl: Enhance lr-policy-add to set the options.")
Signed-off-by: Ilya Maximets
---
utilities/ovn-nbctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
index 526dbf86c..448c86f42 100644
--- a/utilities/ovn-nbctl.c
+++ b
shash contains pointers to the data that should be freed.
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x52100f in malloc (/controller/ovn-controller+0x52100f)
#1 0x752436 in xmalloc /lib/util.c:138:15
#2 0x5a2f0b in add_pending_ct_zone_entry /controller/ovn-controller
'smap_clear()' doesn't free allocated memory, but 'smap_clone()'
re-initializes hash map clearing internal pointers and leaking
this memory. 'smap_destroy()' should be used instead.
Also, all the records and array of datapaths should be freed on
destruction of a cache entry.
Direct leak of 16
'parse_ofp_meter_mod_str' allocates space for meter.bands that
should be freed.
Direct leak of 448 byte(s) in 7 object(s) allocated from:
#0 0x52100f in malloc (/controller/ovn-controller+0x52100f)
#1 0x7523a6 in xmalloc /lib/util.c:138:15
#2 0x6fd079 in ofpbuf_init /lib/ofpbuf.c:123
'dsts' should be freed in case of any error.
Direct leak of 4 byte(s) in 1 object(s) allocated from:
#0 0x502378 in realloc (/tests/ovstest+0x502378)
#1 0x622826 in xrealloc /lib/util.c:149:9
#2 0x8194f4 in parse_select_action /lib/actions.c:1185:20
#3 0x814f49 in parse_set_actio
'child_port_list' is an array of pointers that should be freed too.
Direct leak of 30 byte(s) in 6 object(s) allocated from:
#0 0x501fff in malloc (/tests/ovstest+0x501fff)
#1 0x6227e6 in xmalloc /lib/util.c:138:15
#2 0x6228b8 in xmemdup0 /lib/util.c:168:15
#3 0x8183d6 in parse_f
Error is allocated from heap and should be freed.
Fixes: 738295605b44 ("ovn: Detect and prevent duplicate address assignments.")
Signed-off-by: Ilya Maximets
---
utilities/ovn-nbctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
index b5633c72
No need to clone when assigning to the same variable.
Fixes: 024500aeab9a ("expr: Evaluate the condition expression in a separate
step.")
Signed-off-by: Ilya Maximets
---
tests/test-ovn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-ovn.c b/tests/test-ovn.c
ind
Result of 'normalize_v46_prefix()' should be freed and all dynamic
strings should be destroyed.
Fixes: 4fdca656857d ("Add ECMP symmetric replies.")
Signed-off-by: Ilya Maximets
---
northd/ovn-northd.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/northd/ovn-northd.c b/northd/ovn-north
Found by Clang AddressSanitizer.
All patches has correct and different 'Fixes' tags, so could be
backported to appropriate branches.
Ilya Maximets (14):
northd: Fix leaks of strings while formatting ecmp flows.
test-ovn: Fix expression leak.
actions: Fix leak of child ports in fwd group.
In commit f9cab11d5fabe2ae321a3b4bad5972b61df958c0, a LOG_TO_PHY flow
was changed so that it was no longer associated with a particular port
binding. The logic there was that the particular flow contains data
pertaining to the port binding's peer's datapath, so it didn't make
sense to associate the
BookConcierge is the worlds biggest online bookstore & lowest-price
determinator in 23 countries. Price. Speed. Variety: only the Best &
Cheapest & F
[http://australia.boo
A website where you may find your sweetheart!
Note:
It is likely that the quick wit and auty of our
members will leave you speechless.
Now you can enjoy your time:
Result of 'normalize_v46_prefix()' should be freed and all dynamic
strings should be destroyed.
Direct leak of 156 byte(s) in 13 object(s) allocated from:
#0 0x53700f in malloc (northd/ovn-northd+0x53700f)
#1 0x71b146 in xmalloc ovs/lib/util.c:138:15
#2 0x71b39a in xvasprintf ovs/lib
Here is the IRC log for the OVN meeting for 19 November, 2020
http://eavesdrop.openstack.org/meetings//ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-11-19-18.15.log.html
If you are interested in attending this meeting, it happens every
Thursday in the #openvs
Webinar en Vivo:
Cómo aumentar tus ventas con Whatsapp Business - 05 de Diciembre
Whatsapp robot: cómo configurarlo para incrementar tus ventas - 12 de Diciembre
- Horario de 10:00 a 14:00 Hrs.-
BUEN FIN: 3 x 2 en todos nuestros cursos. Promoción válida durante noviembre y
diciembre 2020 así c
On Thu, Nov 19, 2020 at 09:59:04AM -0800, Ben Pfaff wrote:
> On Thu, Nov 19, 2020 at 11:50:57AM +0100, Dumitru Ceara wrote:
> > On 11/19/20 5:15 AM, Ben Pfaff wrote:
> > > On Tue, Nov 17, 2020 at 05:50:20PM +0100, Dumitru Ceara wrote:
> > >> It is not correct for ovn-controller to pass the current
On Thu, Nov 19, 2020 at 11:50:57AM +0100, Dumitru Ceara wrote:
> On 11/19/20 5:15 AM, Ben Pfaff wrote:
> > On Tue, Nov 17, 2020 at 05:50:20PM +0100, Dumitru Ceara wrote:
> >> It is not correct for ovn-controller to pass the current SB_Global.nb_cfg
> >> value to ofctrl_put() if there are pending ch
On Thu, Nov 19, 2020 at 02:31:04PM +0530, Numan Siddique wrote:
> Thanks for v5. This patch doesn't apply cleanly on the latest master.
>
> I'd suggest to post the patch 1 was an independent patch rebased on on
> top of latest master
>
> I think you can submit the patch 2 once the patch 1 is acce
On Thu, Nov 19, 2020 at 09:11:38AM +0100, Dumitru Ceara wrote:
> On 11/19/20 6:13 AM, Ben Pfaff wrote:
> > From: Leonid Ryzhyk
> >
> > This implementation is incremental, meaning that it only recalculates
> > what is needed for the southbound database when northbound changes
> > occur. It is exp
On Thu, Nov 19, 2020 at 08:31:44AM -0500, Ihar Hrachyshka wrote:
> On Thu, Nov 19, 2020 at 12:51 AM Ben Pfaff wrote:
> >
> > On Wed, Nov 18, 2020 at 10:35:01PM -0500, Ihar Hrachyshka wrote:
> > > It's a legal setup where tunnel ports with the same config are created
> > > on different bridges serv
> > I proposed an earlier upload from git as a temporary measure to ease
> > the ABI transition. I worry that an ABI transition 2 months after the
> > transition freeze is too much to ask, even if it only affects
> > src:openvswitch (and src:collectd, but that's a straightforward
> > rebuild, no ch
...
> I proposed an earlier upload from git as a temporary measure to ease
> the ABI transition. I worry that an ABI transition 2 months after the
> transition freeze is too much to ask, even if it only affects
> src:openvswitch (and src:collectd, but that's a straightforward
> rebuild, no changes
Great service. Speedy delivery!
"Excellent service. Excellent product!"
- By Jacob
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> > Also, I would very much like to have OVS and OVN being packaged and
> > maintained on both Ubuntu and Debian the same way. I would very much
> > like if this could happen, because maintaining OVS is hard, and I really
> > feel alone doing it. Your thoughts?
> >
> > Cheers,
> >
> > Thomas Goiran
--
Greetings,
We guess you are healthy and as well coping with the Covid-19 pandemic
situation, our office has sent you a message earlier but there is no
answer from you, did you read our notice sent to you last week via
e-mail message?
Yours Faithfully,
MR. PETER HAMBROOK
IMF OFFICE LONDON UNI
On Thu, Nov 19, 2020 at 12:51 AM Ben Pfaff wrote:
>
> On Wed, Nov 18, 2020 at 10:35:01PM -0500, Ihar Hrachyshka wrote:
> > It's a legal setup where tunnel ports with the same config are created
> > on different bridges served by Open vSwitch. Specifically, multiple
> > OVN controllers may emulate
Building DPDK using Make is removed since DPDK 20.08.
Hence, remove its references in OVS as well.
Fixes: 540e70fba6d5 ("build: Add support for DPDK meson build.")
Tested-at: https://travis-ci.org/github/Sunil-Pai-G/ovs/builds/742699277
Signed-off-by: Sunil Pai G
---
v1->v2:
- replace python scr
On 11/19/20 5:15 AM, Ben Pfaff wrote:
> On Tue, Nov 17, 2020 at 05:50:20PM +0100, Dumitru Ceara wrote:
>> It is not correct for ovn-controller to pass the current SB_Global.nb_cfg
>> value to ofctrl_put() if there are pending changes to conditional
>> monitoring clauses (local or in flight). It mi
> Coding style says: "Put a space between the ``()`` used in a cast and
> the expression whose type is cast: ``(void *) 0``.".
> This style rule is frequently overlooked. Let's check for it.
>
> Signed-off-by: Ilya Maximets
Hi Ilya,
Thanks for the patch, it's a nice addition to checkpatch, tes
Paying more than $500/month in Visa/MasterCard Credit Card Processing Fees?
Give me 3 minutes to explain your alternative.
1) How much of your profit margin is 'spent' on fees every month? Tired of
paying?
Your processor isn't telling you about all the available options.
Why don't they
> On 11/18/20 8:54 PM, Stokes, Ian wrote:
> > Hi All,
> >
> > Please see the updated patch review list from this week's call.
> >
> > Regards
> > Ian
> >
> >
> > Patch List
> >
> > Stats to Date for patch series
> >
> > Merged: 9
> > Merge Candidate: 0
> > Review in progress: 4
> > No review in pro
Currently, the openvswitch module is not accepting the correctly formated
netlink message for the TTL decrement action. For both setting and getting
the dec_ttl action, the actions should be nested in the
OVS_DEC_TTL_ATTR_ACTION attribute as mentioned in the openvswitch.h uapi.
Fixes: 744676e77720
On 18/11/2020 15:11, Ilya Maximets wrote:
> On 11/17/20 7:02 PM, Mark Gray wrote:
>> Update build system to ensure dirs.py is created when it is a
>> dependency for a build target. Also, update setup.py to
>> check for that dependency.
>>
>> Signed-off-by: Mark Gray
>> ---
>>
>> v2: Added v2 tag
>
Update build system to ensure dirs.py is created when it is a
dependency for a build target. Also, update setup.py to
check for that dependency.
Signed-off-by: Mark Gray
---
v2: Added v2 tag
v3: Updated as per Ilya's comments
lib/automake.mk | 2 +-
ovsdb/automake.mk | 2 +-
python
楽天カードからのお知らせ
楽天カードアプリ | 楽天e-NAVI
【重要なお知らせ】カード情報更新のお知らせ
楽天市場のお客様
残念ながら、あなたのアカウントが
楽天会員のカード情報を更新できませんでした。
これは、カードが期限切れになったか、請求先住所が変更されたなど、さまざまな理由で発生する可能性があります。
アカウント情報の一部が誤っているため、お客様のアカウントを維持するために、楽天会員のカード情報を確認する必要があります。今アカウントを確認できます。
[AUTOVALS2]
楽天市場ログイン
なお、24時間以内にご確認できない場合、誠に勝手ながら、アカウントをロッ
On 11/19/20 8:31 AM, Numan Siddique wrote:
> On Wed, Nov 18, 2020 at 6:27 PM Dumitru Ceara wrote:
>>
>> The NB.NB_Global.nb_cfg value gets propagated to
>> Chassis_Private.nb_cfg (and then to NB.NB_Global.hv_cfg) as soon as
>> ovn-controller has finished installing OVS flows corresponding to
>> th
On 11/19/20 6:13 AM, Ben Pfaff wrote:
> From: Leonid Ryzhyk
>
> This implementation is incremental, meaning that it only recalculates
> what is needed for the southbound database when northbound changes
> occur. It is expected to scale better than the C implementation,
> for large deployments.
53 matches
Mail list logo