Signed-off-by: Peng He
Signed-off-by: Peng He
---
tests/checkpatch.at | 24 +---
utilities/checkpatch.py | 36 +---
2 files changed, 54 insertions(+), 6 deletions(-)
diff --git a/tests/checkpatch.at b/tests/checkpatch.at
index
Add a rcu_barrier before close_dpif_backer to ensure that
all meters have been freed before id_pool_destory meter's
id-pool.
Signed-off-by: Peng He
Tested-by: David Marchand
Reviewed-by: David Marchand
---
ofproto/ofproto-dpif.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
ovsrcu_barrier will block the current thread until all the postponed
rcu job has been finished. it's like a OVS version of the Linux
kernel rcu_barrier().
Signed-off-by: Peng He
Co-authored-by: Eelco Chaudron
Signed-off-by: Eelco Chaudron
Reviewed-by: David Marchand
---
lib/ovs-rcu.c| 37
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./ovn -I
./include -I ./lib
When the option is set to a comma separated list of chassis names, OVN
will attempt to bind the port at any number of other locations in
addition to the main chassis.
This is useful in live migration scenarios where it's important to
prepare the environment for workloads to move to, avoiding
When multiple chassis are set in requested-chassis, port binding is
configured in multiple cluster locations. In case of live migration
scenario, only one of the locations run a workload at a particular
point in time. Yet, it's expected that the workload may switch to
running at an additional
When options:activation-strategy is set to "rarp" for LSP, when used in
combination with multiple chassis names listed in
options:requested-chassis, additional chassis will install special flows
that would block all ingress and egress traffic for the port until a
special activation event happens.
In a future patch, there will be a scenario where the same port has
attachments at multiple (specifically, 2) chassis, so make sure that
'up' property is updated by the main chassis only.
Acked-by: Numan Siddique
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 9 ++---
Hi,
this is a rebase plus a number of issues handled in RARP activation
patch, that is also now included in the series.
There are still several outstanding issues with the last, RARP
activation, patch that need to be addressed. The rest of the series
should be ready to merge and is independent
I'm sending another version of the series with some of your comments
handled (plus rebase), while others are still pending clarifications.
See below.
On Fri, May 13, 2022 at 2:37 AM Han Zhou wrote:
>
>
>
> On Thu, May 5, 2022 at 6:38 AM Ihar Hrachyshka wrote:
> >
> > When
Hi Harry,
> -Original Message-
> From: Van Haaren, Harry
> Sent: Wednesday, May 25, 2022 8:00 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: echau...@redhat.com; ktray...@redhat.com; i.maxim...@ovn.org;
> Ferriter, Cian ; Stokes, Ian ;
> david.march...@redhat.com;
Add ovn-encap-df_default configuration option to set df_default on OVN tunnels.
Signed-off-by: Jochen Friedrich
---
controller/encaps.c | 8
controller/ovn-controller.8.xml | 7 +++
2 files changed, 15 insertions(+)
diff --git a/controller/encaps.c
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, May 25, 2022 4:33 PM
> To: Eelco Chaudron ; Van Haaren, Harry
>
> Cc: i.maxim...@ovn.org; ovs-dev@openvswitch.org; Stokes, Ian
> ; Amber, Kumar
> Subject: Re: [PATCH] dpcls: revert subtable-lookup-prio-get name change
>
> On
Eelco Chaudron writes:
> On 17 May 2022, at 17:09, Phelan, Michael wrote:
>
>>> -Original Message-
>>> From: Aaron Conole
>>> Sent: Tuesday 17 May 2022 15:38
>>> To: Eelco Chaudron
>>> Cc: 0-day Robot ; d...@openvswitch.org; Phelan, Michael
>>>
>>> Subject: Re: [ovs-dev] [PATCH v3
Hi Cian, Eelco
Thanks for the suggestions.
Replies inline.
> -Original Message-
> From: Ferriter, Cian
> Sent: Wednesday, May 25, 2022 9:09 PM
> To: Eelco Chaudron ; Amber, Kumar
>
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian
> ; Van Haaren, Harry
> Subject: RE:
> >>> diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at index
> >>> 7d2715c4a..ac83e5a57 100644
> >>> --- a/tests/system-dpdk.at
> >>> +++ b/tests/system-dpdk.at
> >>> @@ -226,17 +226,19 @@ dnl
> >>> --
> >>>
> >>>
On 5/25/22 16:32, Eelco Chaudron wrote:
>
>
> On 25 May 2022, at 16:10, Harry van Haaren wrote:
>
>> This commit reverts the name-change that was done (prio->info).
>> The change breaks a user visible ovs-appctl command, resulting in
>> breakage of tools/scripts/user-expectation outside of the
> On 25 May 2022, at 16:35, Stokes, Ian wrote:
>
> >> This commit reverts the name-change that was done (prio->info).
> >> The change breaks a user visible ovs-appctl command, resulting in
> >> breakage of tools/scripts/user-expectation outside of the OVS repo.
> >>
> >> This commit changes the
On Thu, May 5, 2022 at 12:21 PM Adrian Moreno wrote:
>
>
>
> On 4/12/22 13:49, Christophe Fontaine wrote:
> > This config param allows the delivery of broadcast and multicast packets
> > to the secondary interface of non-lacp bonds, equivalent to the option
> > "all_slaves_active" for kernel
On 25 May 2022, at 16:35, Stokes, Ian wrote:
>> This commit reverts the name-change that was done (prio->info).
>> The change breaks a user visible ovs-appctl command, resulting in
>> breakage of tools/scripts/user-expectation outside of the OVS repo.
>>
>> This commit changes the
> This commit reverts the name-change that was done (prio->info).
> The change breaks a user visible ovs-appctl command, resulting in
> breakage of tools/scripts/user-expectation outside of the OVS repo.
>
> This commit changes the documentation, command string, and unit tests
> back to the
On 25 May 2022, at 16:10, Harry van Haaren wrote:
> This commit reverts the name-change that was done (prio->info).
> The change breaks a user visible ovs-appctl command, resulting in
> breakage of tools/scripts/user-expectation outside of the OVS repo.
>
> This commit changes the
> -Original Message-
> From: Amber, Kumar
> Sent: Friday, May 6, 2022 6:23 AM
> To: ovs-dev@openvswitch.org
> Cc: echau...@redhat.com; ktray...@redhat.com; i.maxim...@ovn.org;
> Ferriter, Cian ; Stokes, Ian ;
> david.march...@redhat.com; f...@sysclose.org; Van Haaren, Harry
> ; Amber,
> -Original Message-
> From: Amber, Kumar
> Sent: Friday, May 6, 2022 6:23 AM
> To: ovs-dev@openvswitch.org
> Cc: echau...@redhat.com; ktray...@redhat.com; i.maxim...@ovn.org; Ferriter,
> Cian ; Stokes, Ian ;
> david.march...@redhat.com; f...@sysclose.org; Van Haaren, Harry
> ; Amber,
> -Original Message-
> From: Amber, Kumar
> Sent: Friday, May 6, 2022 6:23 AM
> To: ovs-dev@openvswitch.org
> Cc: echau...@redhat.com; ktray...@redhat.com; i.maxim...@ovn.org; Ferriter,
> Cian ; Stokes, Ian ;
> david.march...@redhat.com; f...@sysclose.org; Van Haaren, Harry
> ; Amber,
This commit reverts the name-change that was done (prio->info).
The change breaks a user visible ovs-appctl command, resulting in
breakage of tools/scripts/user-expectation outside of the OVS repo.
This commit changes the documentation, command string, and unit tests
back to the expected "prio"
Hi Greg,
On Mon, May 23, 2022 at 09:10:36PM +0200, Ilya Maximets wrote:
> On 5/19/22 20:04, Gregory Rose wrote:
> >
> >
> > On 4/15/2022 2:42 PM, Greg Rose wrote:
> >> It is time to remove support for the OVS kernel driver and push
> >> towards use of the upstream Linux openvswitch kernel
have to work the unit test for ovsrcu_barrier API.
will send all the fix in the next version.
Eelco Chaudron 于2022年5月25日周三 20:44写道：
>
>
> On 24 May 2022, at 16:29, Peng He wrote:
>
> > Signed-off-by: Peng He
> > Signed-off-by: Peng He
>
> This patch is making existing test fail:
>
> 10:
On 25 May 2022, at 12:59, Amber, Kumar wrote:
> Hi Eelco,
>
> Please find replies inline.
>
>>> +# Relative path for the pcap file location.
>>> path = str(sys.argv[1]) + "/pcap/fuzzy.pcap"
>>
>> Would it be better to supply the full file name, rather than a fixed file
>> name
>> and
On 17 May 2022, at 17:09, Phelan, Michael wrote:
>> -Original Message-
>> From: Aaron Conole
>> Sent: Tuesday 17 May 2022 15:38
>> To: Eelco Chaudron
>> Cc: 0-day Robot ; d...@openvswitch.org; Phelan, Michael
>>
>> Subject: Re: [ovs-dev] [PATCH v3 5/5] tests: Add check_pkt_len
On 24 May 2022, at 16:29, Peng He wrote:
> Signed-off-by: Peng He
> Signed-off-by: Peng He
This patch is making existing test fail:
10: checkpatch - sign-offs ok
11: checkpatch - parenthesized constructs FAILED (checkpatch.at:27)
12: checkpatch -
lic121 writes:
> Max allowed userspace dp conntrack entries is configurable with
> 'ovs-appctl dpctl/ct-set-maxconns' command. In real scenarios,
> this configuration is expected to survive from host reboot, from
> ovs service restart.
>
> Signed-off-by: lic121
> ---
Acked-by: Aaron Conole
David Marchand 于2022年5月25日周三 19:27写道：
> Title should be: "ovs-rcu: Add ovsrcu_barrier."
>
> On Wed, May 25, 2022 at 3:36 AM Peng He wrote:
> >
> > rcu_barrier will block the current thread until all the postponed
>
> ovsrcu_barrier*
>
> > rcu job has been finished. it's like the OVS's version
Title should be: "ofproto-dpif: Fix meter use-after-free."
On Wed, May 25, 2022 at 3:36 AM Peng He wrote:
>
> add a rcu_barrier before close_dpif_backer to ensure that
Add*
> all meters has been freed before id_pool_destory meter's
have*
> id-pool.
>
> Signed-off-by: Peng He
> Tested-by:
Title should be: "ovs-rcu: Add ovsrcu_barrier."
On Wed, May 25, 2022 at 3:36 AM Peng He wrote:
>
> rcu_barrier will block the current thread until all the postponed
ovsrcu_barrier*
> rcu job has been finished. it's like the OVS's version of
> the kernel rcu_barrier()
It's like a OVS version
Currently mempools for vhost are being assigned before the vhost device
is added. In some cases this may be just reusing an existing mempool but
in others it can require creation of a mempool.
For multi-NUMA, the NUMA info of the vhost port is not known until a
device is added to the port, so on
V2:
- Also implement delayed vhost mempool creation/reuse for single-NUMA
- Added David's RvB, as minor code change from v1 and David had
preference for common single/multi NUMA behaviour
V1 only operated for multi-NUMA, as potentially having to create a mempool
and then recreate it on a
Hi Eelco,
Please find replies inline.
> > +# Relative path for the pcap file location.
> > path = str(sys.argv[1]) + "/pcap/fuzzy.pcap"
>
> Would it be better to supply the full file name, rather than a fixed file name
> and directory being concatenated?
>
Sure, would make the script usable
On 24 May 2022, at 14:10, Kumar Amber wrote:
> The mfex pcap generation script is improved for varied length
> traffic and also removes the hard coded mfex_pcap and instead uses
> the script itself to generate complex traffic patterns for testing.
>
> Signed-off-by: Kumar Amber
> Acked-by:
On Tue, May 24, 2022 at 1:32 PM Ilya Maximets wrote:
>
> On 5/24/22 12:54, Frode Nordahl wrote:
> > On Mon, May 23, 2022 at 3:49 PM Ilya Maximets wrote:
> >>
> >> On 5/21/22 12:49, Frode Nordahl wrote:
> >>> On Thu, May 19, 2022 at 3:39 PM Frode Nordahl
> >>> wrote:
>
> On Sat, May
When localport is removed from NB, and it is the last port
remaining on the host, it is not part of local datapath
anymore. Which can cause troubles when there is recompute
happening in between the removal from NB and the removal
of interface from host. The localport would stay in lport_ids
set,
The localport should always delegate traffic locally,
move the definition into consider_port_binding as
the physical_run is not evaluated during I-P.
Reported-at: https://bugzilla.redhat.com/2076604
Signed-off-by: Ales Musil
---
v2: Rebase on newer main
---
controller/physical.c | 44
The first one being that the table 37 flow is not
populated on I-P updates and is being left behind
on removal of localport.
The second one is removal of localport from
controller sets, not being removed prevent
the flows to be created for newly acquired
localport.
---
v2: Rebase on newer main
On Tue, May 24, 2022 at 6:41 PM Numan Siddique wrote:
> On Mon, May 23, 2022 at 4:46 AM Ales Musil wrote:
> >
> > The localport should always delegate traffic locally,
> > move the definition into consider_port_binding as
> > the physical_run is not evaluated during I-P.
> >
> > Reported-at:
44 matches
Mail list logo
