Re: [ovs-dev] [PATCH ovn 2/2] northd.c: Add option to enable MAC learning on localnet

2022-06-03 Thread Numan Siddique
On Wed, Jun 1, 2022 at 8:28 AM Ales Musil wrote: > > The localnet is excluded from MAC learning for scale > reason. However there might be a valid workflow > when yo uwant to enable the learning and benefit > for that for HW offload. Add option called > 'localnet_learn_fdb' to LSP, which will

[ovs-dev] [PATCH ovn] Lock pinctrl_mutex for pinctrl_wait

2022-06-03 Thread Ihar Hrachyshka
The function is called from main thread, and wait_* subprocedures access data structures that are managed by pinctrl thread, so make sure the access to them is guarded. Signed-off-by: Ihar Hrachyshka --- controller/pinctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [ovs-dev] [PATCH v12 ovn] Implement RARP activation strategy for ports

2022-06-03 Thread Ihar Hrachyshka
Thanks Numan. All comments handled in v13 I just sent. Ihar On Thu, Jun 2, 2022 at 5:06 PM Numan Siddique wrote: > > On Wed, Jun 1, 2022 at 7:00 PM Ihar Hrachyshka wrote: > > > > This is the remaining piece in multi-chassis series. This new version > > has no flow modification done in pinctrl

[ovs-dev] [PATCH v13 ovn] Implement RARP activation strategy for ports

2022-06-03 Thread Ihar Hrachyshka
When options:activation-strategy is set to "rarp" for LSP, when used in combination with multiple chassis names listed in options:requested-chassis, additional chassis will install special flows that would block all ingress and egress traffic for the port until a special activation event happens.

Re: [ovs-dev] [PATCH ovn branch-22.06 2/2] Prepare for 22.06.1.

2022-06-03 Thread Mark Michelson
I merged these changes and tagged v22.06.0 On 6/3/22 15:26, Numan Siddique wrote: On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++

Re: [ovs-dev] [PATCH ovn branch-21.12 2/2] Prepare for 21.12.3.

2022-06-03 Thread Mark Michelson
I merged these changes and tagged v21.12.2 On 6/3/22 15:27, Numan Siddique wrote: On Fri, Jun 3, 2022 at 11:56 AM Mark Michelson wrote: Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++

Re: [ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.2.

2022-06-03 Thread Mark Michelson
I merged these changes and tagged v22.03.1. On 6/3/22 15:25, Numan Siddique wrote: On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++

Re: [ovs-dev] [PATCH ovn v2 0/3] Use masked ct_mark in a backwards compatible way.

2022-06-03 Thread Mark Michelson
I merged each of the individual patch series to their appropriate branches. On 6/3/22 09:25, Dumitru Ceara wrote: Explicit backports for these patches (except 3/3 which should only be applied to main) are available at: - branch-22.06:

Re: [ovs-dev] [PATCH ovn branch-22.06 2/2] Prepare for 22.06.1.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS

Re: [ovs-dev] [PATCH ovn branch-21.12 2/2] Prepare for 21.12.3.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:56 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS

Re: [ovs-dev] [PATCH ovn branch-21.12 1/2] Set release date for 21.12.2.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index de3330ab6..6ff9b8fdf

Re: [ovs-dev] [PATCH ovn branch-22.06 1/2] Set release date for 22.06.0.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 2 +- > debian/changelog | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index e27ae6c39..e335f64c2

Re: [ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.2.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS

Re: [ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.1.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 700a6830a..166470747

Re: [ovs-dev] [PATCH ovn branch-22.03 0/2] Release patches for v22.03.1.

2022-06-03 Thread Numan Siddique
On Fri, Jun 3, 2022 at 11:55 AM Mark Michelson wrote: > > > Mark Michelson (2): > Set release date for 22.03.1. > Prepare for 22.03.2. > > NEWS | 6 +- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 13 insertions(+), 3 deletions(-) For both

Re: [ovs-dev] [PATCH v2] ovs-ofctl: '--bundle' option can be used with OpenFlow 1.3

2022-06-03 Thread Mike Pattrick
On Mon, May 9, 2022 at 5:21 AM yangchang wrote: > > From the commit 25070e045e, bundle option has be used with OpenFlow 1.3 Nit, s/has/can/ But the content of the patch looks correct. Acked-by: Mike Pattrick Cheers, M > > Signed-off-by: yangchang > --- > utilities/ovs-ofctl.8.in | 10

Re: [ovs-dev] [PATCH 1/1] packets: Re-calculate IPv6 checksum only for last frags upon modify.

2022-06-03 Thread Mike Pattrick
On Sun, May 29, 2022 at 10:21 AM Salem Sol via dev wrote: > > In case of modifying an IPv6 packet src/dst address the checksum should be > recalculated only for the last frag. Currently it's done for all frags, > leading to incorrect reassembled packet checksum. > Fix it by adding a new flag to

Re: [ovs-dev] [PATCH v4 4/5] system-offloads-traffic: Properly initialize offload before testing.

2022-06-03 Thread Mike Pattrick
On Fri, Jun 3, 2022 at 4:58 AM Eelco Chaudron wrote: > > This patch will properly initialize offload, as it requires the > setting to be enabled before starting ovs-vswitchd (or do a > restart once configured). > > Signed-off-by: Eelco Chaudron > --- > v4: > - Use the existing dbinit-aux-args

Re: [ovs-dev] [PATCH] netdev-linux: skip some internal kernel stats gathering

2022-06-03 Thread Ilya Maximets
On 6/3/22 16:47, Jon Kohler wrote: > > >> On Jun 2, 2022, at 5:50 PM, Ilya Maximets wrote: >> >> On 6/2/22 23:13, Jon Kohler wrote: >>> Any takers? I’m hoping I’ve got the right mailing list, as I did see >>> the thread get generated on the mailing list website? >> >> Hey, Jon. >> >> Yes, it's

Re: [ovs-dev] [PATCH] dpcls: revert subtable-lookup-prio-get name change

2022-06-03 Thread Ilya Maximets
On 5/27/22 14:45, Van Haaren, Harry wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Friday, May 27, 2022 1:10 PM >> To: Van Haaren, Harry ; Eelco Chaudron >> >> Cc: i.maxim...@ovn.org; ovs-dev@openvswitch.org; Stokes, Ian >> ; Amber, Kumar >> Subject: Re: [PATCH] dpcls:

Re: [ovs-dev] [PATCH] python: use setuptools instead of distutils

2022-06-03 Thread Mike Pattrick
On Wed, May 11, 2022 at 2:14 PM Timothy Redaelli wrote: > > On Python 3.12, distutils will be removed and it's currently (3.10+) > deprecated (see PEP 632). > > Since the suggested and simplest replacement is setuptools, this commit > replaces distutils to use setuptools instead. > >

Re: [ovs-dev] [PATCH v3] dpif-netdev: Allow cross-NUMA polling on selected ports

2022-06-03 Thread Kevin Traynor
Hi Anurag, Thanks for submitting this. Some initial comments on the code below. On 03/06/2022 05:25, Anurag Agarwal wrote: From: Jan Scheurich Today dpif-netdev considers PMD threads on a non-local NUMA node for automatic assignment of the rxqs of a port only if there are no

Re: [ovs-dev] [PATCH ovn branch-21.12 1/2] Set release date for 21.12.2.

2022-06-03 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build:

[ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.2.

2022-06-03 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 166470747..3e1c6fb11 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v22.03.2 - xx xxx

[ovs-dev] [PATCH ovn branch-21.12 0/2] Release patches for v21.12.2.

2022-06-03 Thread Mark Michelson
Mark Michelson (2): Set release date for 21.12.2. Prepare for 21.12.3. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.31.1 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-21.12 2/2] Prepare for 21.12.3.

2022-06-03 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 6ff9b8fdf..31e08b015 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v21.12.3 - xx xxx

[ovs-dev] [PATCH ovn branch-22.06 2/2] Prepare for 22.06.1.

2022-06-03 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e335f64c2..cc58306d7 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v22.06.1 - xx xxx

[ovs-dev] [PATCH ovn branch-22.03 0/2] Release patches for v22.03.1.

2022-06-03 Thread Mark Michelson
Mark Michelson (2): Set release date for 22.03.1. Prepare for 22.03.2. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.31.1 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-22.06 0/2] Release patches for v22.06.0.

2022-06-03 Thread Mark Michelson
Mark Michelson (2): Set release date for 22.06.0. Prepare for 22.06.1. NEWS | 5 - configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 12 insertions(+), 3 deletions(-) -- 2.31.1 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-22.06 1/2] Set release date for 22.06.0.

2022-06-03 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index e27ae6c39..e335f64c2 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -OVN v22.06.0 - XX XXX +OVN v22.06.0 - 03 Jun 2022

[ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.1.

2022-06-03 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 700a6830a..166470747 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v22.03.1 - xx xxx +OVN v22.03.1 - 03 Jun 2022

[ovs-dev] [PATCH ovn branch-21.12 1/2] Set release date for 21.12.2.

2022-06-03 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index de3330ab6..6ff9b8fdf 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v21.12.2 - xx xxx +OVN v21.12.2 - 03 Jun 2022

Re: [ovs-dev] [PATCH] ovs-tcpdump: Fix error when stopping ovs-tcpdump.

2022-06-03 Thread Mike Pattrick
On Fri, May 20, 2022 at 5:55 AM Han Ding wrote: > > > Sometimes we need to dump packets on more than two interfaces in a bridge > at the same time. Then when we stop dumping in order, ovs-tcpdump print > traceback and fail to delete mirror interface for some interface. > > For example: > br-int

[ovs-dev] [PATCH v4] ofproto-dpif-xlate: No clone when tunnel push is last action

2022-06-03 Thread Rosemarie O'Riorden
When OVS sees a tunnel push with a nested list next, it will not clone the packet, as a clone is not needed. However, a clone action will still be created with the tunnel push encapulated inside. There is no need to create the clone action in this case, as extra parsing will need to be performed,

Re: [ovs-dev] [PATCH ovn v2 0/3] Use masked ct_mark in a backwards compatible way.

2022-06-03 Thread Dumitru Ceara
On 6/3/22 17:08, Mark Michelson wrote: > Acked-by: Mark Michelson > > On 6/3/22 09:25, Dumitru Ceara wrote: >> Explicit backports for these patches (except 3/3 which should only be >> applied >> to main) are available at: > > I'm curious why patch 3 shouldn't be applied to branch-22.06. > It

[ovs-dev] [PATCH 0/7] dp-packet: Refactor offload related names

2022-06-03 Thread Mike Pattrick
This patch refactors several function, variable, and definition names for consistency and brevity. cksum is changed to csum, p is the default name for a dp_packet, b is the default name for a dp_packet_batch, ol instead of hwol, and some checksum offload related functions are renamed to indicate

[ovs-dev] [PATCH 4/7] dp-packet: Use p for packet and b for batch.

2022-06-03 Thread Mike Pattrick
From: Flavio Leitner Currently 'p' and 'b' and used for packets, so use a convention that struct dp_packet is 'p' and struct dp_packet_batch is 'b'. Some comments needed new formatting to not pass the 80 column. Some variables were using 'p' or 'b' were renamed as well. There should be no

[ovs-dev] [PATCH 6/7] dp-packet: Rename dp_packet_ol l4 functions.

2022-06-03 Thread Mike Pattrick
From: Flavio Leitner Rename to better represent their flags. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/conntrack.c| 4 ++-- lib/dp-packet.h| 14 +++--- lib/ipf.c | 6 +++--- lib/netdev-linux.c | 14

[ovs-dev] [PATCH 5/7] dp-packet: Rename dp_packet_ol_tcp_seg

2022-06-03 Thread Mike Pattrick
From: Flavio Leitner Rename to dp_packet_ol_tcp_seg, because that is less redundant and allows other protocols. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/dp-packet.h| 2 +- lib/netdev-linux.c | 2 +- lib/netdev.c | 4 ++-- 3

[ovs-dev] [PATCH 7/7] dp-packet: Add _ol_ to functions using OL flags.

2022-06-03 Thread Mike Pattrick
From: Flavio Leitner This helps to identify when it is about the flags or the packet itself. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/conntrack.c | 8 lib/dp-packet.c | 2 +- lib/dp-packet.h |

[ovs-dev] [PATCH 3/7] Rename dp_packet_hwol to dp_packet_ol.

2022-06-03 Thread Mike Pattrick
From: Flavio Leitner The name correlates better with the flag names. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/conntrack.c| 8 lib/dp-packet.h| 28 ++-- lib/ipf.c | 6 +++---

[ovs-dev] [PATCH 1/7] Rename flags with CKSUM to CSUM.

2022-06-03 Thread Mike Pattrick
From: Flavio Leitner It seems csum is more common and shorter. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/dp-packet.h | 72 +-- lib/netdev-dpdk.c | 16 +- lib/netdev-linux.c|

[ovs-dev] [PATCH 2/7] Prefix netdev offload flags with NETDEV_OFFLOAD_.

2022-06-03 Thread Mike Pattrick
From: Flavio Leitner Use the 'NETDEV_OFFLOAD_' prefix in the flags to indicate we are talking about hardware offloading capabilities. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/netdev-dpdk.c | 20 ++--

Re: [ovs-dev] [PATCH ovn v2 0/3] Use masked ct_mark in a backwards compatible way.

2022-06-03 Thread Mark Michelson
Acked-by: Mark Michelson On 6/3/22 09:25, Dumitru Ceara wrote: Explicit backports for these patches (except 3/3 which should only be applied to main) are available at: I'm curious why patch 3 shouldn't be applied to branch-22.06. - branch-22.06:

Re: [ovs-dev] [PATCH] netdev-linux: skip some internal kernel stats gathering

2022-06-03 Thread Jon Kohler
> On Jun 2, 2022, at 5:50 PM, Ilya Maximets wrote: > > On 6/2/22 23:13, Jon Kohler wrote: >> Any takers? I’m hoping I’ve got the right mailing list, as I did see >> the thread get generated on the mailing list website? > > Hey, Jon. > > Yes, it's the right mailing list, though ovs-dev and

Re: [ovs-dev] [RFC PATCH 0/6] Remove OVS kernel driver

2022-06-03 Thread Frode Nordahl
On Thu, Jun 2, 2022 at 6:58 PM Ilya Maximets wrote: > > On 6/1/22 22:53, Gregory Rose wrote: > > > > > > On 5/31/2022 12:22 PM, Frode Nordahl wrote: > >> On Tue, May 31, 2022 at 7:05 PM Ilya Maximets wrote: > >>> > >>> On 5/31/22 17:36, Gregory Rose wrote: > > > On 5/25/2022 6:47

Re: [ovs-dev] [PATCH 1/2] handlers: Create additional handler threads when using CPU isolation

2022-06-03 Thread Aaron Conole
Michael Santana writes: > Additional threads are required to service upcalls when we have CPU > isolation (in per-cpu dispatch mode). The formula used to calculate > the number of handler threads to create is as follows > > handlers_n = min(next_prime(active_cores+1), total_cores) > > Where

Re: [ovs-dev] [PATCH v3 01/18] python: add generic Key-Value parser

2022-06-03 Thread Ilya Maximets
On 3/11/22 16:21, Adrian Moreno wrote: > Most of ofproto and dpif flows are based on key-value pairs. These > key-value pairs can be represented in several ways, eg: key:value, > key=value, key(value). > > Add the following classes that allow parsing of key-value strings: > * KeyValue: holds a

Re: [ovs-dev] [PATCH v3 13/18] python: detect changes in flow formatting code

2022-06-03 Thread Ilya Maximets
On 3/18/22 11:28, Eelco Chaudron wrote: > > > On 11 Mar 2022, at 16:21, Adrian Moreno wrote: > >> In order to minimize the risk of having the python flow parsing code and >> the C flow formatting code divert, add a target that checks if the >> formatting code has been changed since the last

Re: [ovs-dev] [PATCH v3 12/18] tests: Wrap test-odp to also run python parsers

2022-06-03 Thread Ilya Maximets
On 3/11/22 16:21, Adrian Moreno wrote: > test-odp is used to parse datapath flow actions and matches within the > odp tests. Wrap calls to this tool in a python script that also parses > them using the python flow parsing library. Same comment here as for 11/18. A separate command should be

Re: [ovs-dev] [PATCH v3 11/18] tests: wrap ovs-ofctl calls to test python parser

2022-06-03 Thread Ilya Maximets
On 3/11/22 16:21, Adrian Moreno wrote: > Some ovs-ofctl commands are used to parse or dump openflow flows, > specially in ofp-actions.at > > Use a wrapper around ovs-ofctl, called ovs-test-ofparse.py that, apart > from calling ovs-ofctl, also parses its output (or input, depending on > the

Re: [ovs-dev] [PATCH ovn 1/2] northd: ovn-controller: Use ct_mark.natted only when ct_lb_mark is used.

2022-06-03 Thread Dumitru Ceara
On 6/2/22 21:08, Han Zhou wrote: > On Thu, Jun 2, 2022 at 11:39 AM Dumitru Ceara wrote: >> >> On 6/2/22 19:22, Han Zhou wrote: >>> On Thu, Jun 2, 2022 at 10:09 AM Mark Michelson > wrote: On 6/2/22 11:22, Dumitru Ceara wrote: > Change the way ovn-controller decides whether it should

[ovs-dev] [PATCH ovn v2 3/3] controller: Use ct_mark by default for load balancer hairpin flows.

2022-06-03 Thread Dumitru Ceara
This allows us to remove the SB_Global.options:lb_hairpin_use_ct_mark config knob in the future. For now, ovn-northd will just remove it from the Southbound if it's explicitly set to 'true'. Signed-off-by: Dumitru Ceara --- controller/ovn-controller.c |2 +- northd/northd.c |

[ovs-dev] [PATCH ovn v2 2/3] northd: Use ct_mark.blocked and ecmp_reply_port only when all chassis support it.

2022-06-03 Thread Dumitru Ceara
Commit a075230e4a0f ("Use ct_mark for masked access to make flows HW-offloading friendly.") started using the ct_mark.blocked and ct_mark.ecmp_reply_port ct_label. In usual scenarios this new feature would be picked up when the next stable release becomes available (i.e., 22.06.0). However, the

[ovs-dev] [PATCH ovn v2 1/3] northd: ovn-controller: Use ct_mark.natted only when ct_lb_mark is used.

2022-06-03 Thread Dumitru Ceara
Change the way ovn-controller decides whether it should match on ct_mark.natted or ct_label.natted for hairpin load balancer traffic. Until now this was done solely based on the northd-reported internal version. However, to cover the case when OVN central components are not the last ones to be

[ovs-dev] [PATCH ovn v2 0/3] Use masked ct_mark in a backwards compatible way.

2022-06-03 Thread Dumitru Ceara
Explicit backports for these patches (except 3/3 which should only be applied to main) are available at: - branch-22.06: https://github.com/dceara/ovn/tree/bz2091565-ct-masked-mark-follow-up-22.06 - branch-22.03: https://github.com/dceara/ovn/tree/bz2091565-ct-masked-mark-follow-up-22.03 -

[ovs-dev] [PATCH v4 1/1] netdev-dpdk: Delay vhost mempool creation.

2022-06-03 Thread Kevin Traynor
Currently mempools for vhost are being assigned before the vhost device is added. In some cases this may be just reusing an existing mempool but in others it can require creation of a mempool. For multi-NUMA, the NUMA info of the vhost port is not known until a device is added to the port, so on

[ovs-dev] [PATCH v4 0/1] Delayed vhost mempool creation.

2022-06-03 Thread Kevin Traynor
V2: - Also implement delayed vhost mempool creation/reuse for single-NUMA - Added David's RvB, as minor code change from v1 and David had preference for common single/multi NUMA behaviour V1 only operated for multi-NUMA, as potentially having to create a mempool and then recreate it on a

Re: [ovs-dev] [PATCH v3 14/18] python: introduce unit tests

2022-06-03 Thread Ilya Maximets
On 3/11/22 16:21, Adrian Moreno wrote: > Use pytest to run unit tests as part of the standard testsuite. > > Acked-by: Eelco Chaudron > Signed-off-by: Adrian Moreno > --- > .github/workflows/build-and-test.yml| 3 + > Documentation/intro/install/general.rst | 4 ++ > python/automake.mk

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: Delay vhost mempool creation.

2022-06-03 Thread Ilya Maximets
On 6/3/22 11:19, Kevin Traynor wrote: > On 02/06/2022 17:10, Ilya Maximets wrote: >> On 6/2/22 16:28, Kevin Traynor wrote: >>> On 02/06/2022 15:00, Ilya Maximets wrote: On 6/2/22 13:01, Kevin Traynor wrote: > On 01/06/2022 14:30, David Marchand wrote: >> On Wed, May 25, 2022 at 1:11

Re: [ovs-dev] [PATCH v4 4/5] system-offloads-traffic: Properly initialize offload before testing.

2022-06-03 Thread Eelco Chaudron
Hi Mike/Roi, This is the patch with the changes in this revision. I removed your ACKs, so can you please re-review this patch? Below are the changes compared to the previous version to make things easy for you! Thanks, Eelco 1: f0020c3d5 ! 1: 6c21ec1f9 system-offloads-traffic: Properly

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: Delay vhost mempool creation.

2022-06-03 Thread Kevin Traynor
On 02/06/2022 17:10, Ilya Maximets wrote: On 6/2/22 16:28, Kevin Traynor wrote: On 02/06/2022 15:00, Ilya Maximets wrote: On 6/2/22 13:01, Kevin Traynor wrote: On 01/06/2022 14:30, David Marchand wrote: On Wed, May 25, 2022 at 1:11 PM Kevin Traynor wrote: Currently mempools for vhost are

[ovs-dev] [PATCH v4 5/5] tests: Add check_pkt_len action test to system-offload-traffic.

2022-06-03 Thread Eelco Chaudron
Signed-off-by: Eelco Chaudron Acked-by: Mike Pattrick Acked-by: Roi Dayan --- v2: - Added section in the NEWS document NEWS |2 tests/system-offloads-traffic.at | 413 ++ 2 files changed, 414 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH v4 4/5] system-offloads-traffic: Properly initialize offload before testing.

2022-06-03 Thread Eelco Chaudron
This patch will properly initialize offload, as it requires the setting to be enabled before starting ovs-vswitchd (or do a restart once configured). Signed-off-by: Eelco Chaudron --- v4: - Use the existing dbinit-aux-args argument, rather than creating a new pre-vswitchd command option.

[ovs-dev] [PATCH v4 3/5] netdev-offload-tc: Handle check_pkt_len datapath action.

2022-06-03 Thread Eelco Chaudron
This change implements support for the check_pkt_len action using the TC police action, which supports MTU checking. Signed-off-by: Eelco Chaudron Acked-by: Mike Pattrick Acked-by: Roi Dayan --- v3: Was using TCA_CSUM_PARMS instead of TCA_POLICE_TBF. lib/netdev-offload-tc.c | 171

[ovs-dev] [PATCH v4 2/5] netdev-offload-tc: Move flower_to_match action handling to isolated function.

2022-06-03 Thread Eelco Chaudron
Move handling of the individual actions in the parse_tc_flower_to_match() function to a separate function that will make recursive action handling easier. Signed-off-by: Eelco Chaudron Acked-by: Mike Pattrick Acked-by: Roi Dayan --- lib/netdev-offload-tc.c | 422

[ovs-dev] [PATCH v4 1/5] netdev-offload-tc: Move flow_put action handling to isolated function.

2022-06-03 Thread Eelco Chaudron
Move handling of the individual actions in the netdev_tc_flow_put() function to a separate function that will make recursive action handling easier. Signed-off-by: Eelco Chaudron Acked-by: Mike Pattrick Acked-by: Roi Dayan --- lib/netdev-offload-tc.c | 255

[ovs-dev] [PATCH v4 0/5] netdev-offload-tc: Add support for the check_pkt_len action.

2022-06-03 Thread Eelco Chaudron
This series adds support for the datapath action check_pkt_len for TC offload. It also includes some offload self-tests. v2: - Add ACKs - Unified all the OVS_TRAFFIC_VSWITCHD_START macro's - Added section in the NEWS document v3: - Add ACKs - Was using TCA_CSUM_PARMS instead of