Re: [ovs-dev] [PATCH ovn] utilities: Do not send 'set-db-change-aware' for non-daemon mode tools.

On Tue, Jan 10, 2023 at 6:09 PM Han Zhou wrote: > > This is to avoid annoying error logs from NB/SB/IC DB servers. > > Reported-by: Girish Moodalbail > Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-July/050343.html > Signed-off-by: Han Zhou > --- > This patch depends on

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Use Fedora 37 as base image.

On Mon, Jan 16, 2023 at 5:45 PM Dumitru Ceara wrote: > Fedora 35 is EOL: > https://docs.fedoraproject.org/en-US/releases/eol/ > > Signed-off-by: Dumitru Ceara > --- > .ci/ovn-kubernetes/Dockerfile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [ovs-dev] OVS "soft freeze" for 3.1 is in effect.

On Mon, Jan 16, 2023 at 7:41 AM Eelco Chaudron wrote: > > > > On 16 Jan 2023, at 14:05, Ilya Maximets wrote: > > > On 1/12/23 20:38, Dumitru Ceara wrote: > >> On 1/12/23 19:13, Han Zhou wrote: > >>> On Mon, Jan 2, 2023 at 3:08 PM Ilya Maximets wrote: > > Hi. As described in

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall.c: Add counters for reasons of DP flow deletions.

On Mon, Jan 16, 2023 at 7:36 AM Eelco Chaudron wrote: > > > > On 18 Oct 2022, at 18:11, Adrian Moreno wrote: > > > On 10/14/22 20:07, Han Zhou wrote: > >> > >> > >> On Thu, Oct 13, 2022 at 11:51 PM Adrian Moreno mailto:amore...@redhat.com>> wrote: > >>> > >>> > >>> > >>> On 8/9/22 03:41, Han Zhou

Re: [ovs-dev] [PATCH 1/2] Revalidator: Allow min-revalidator-pps to be 0 (disabled).

On Mon, Jan 16, 2023 at 7:14 AM Eelco Chaudron wrote: > > > > On 18 Oct 2022, at 18:08, Adrian Moreno wrote: > > > On 10/14/22 19:49, Han Zhou wrote: > >> > >> > >> On Thu, Oct 13, 2022 at 11:43 PM Adrian Moreno mailto:amore...@redhat.com>> wrote: > >>> > >>> Hi Han. > >>> > >>> On 8/9/22 03:40,

[ovs-dev] [PATCH v2] Revalidator: Allow min-revalidator-pps to be 0.

Today the minimum value for this setting is 1. This patch allows it to be 0, meaning not checking pps at all, and always do revalidation. This is particularly useful for environments where some of the applications with long-lived connections may have very low traffic for certain period but have

Re: [ovs-dev] [PATCH v6] revalidator: add a USDT probe after evaluation when flows are deleted.

On Fri, Oct 21, 2022 at 9:36 AM Kevin Sprague wrote: > > During normal operations, it is useful to understand when a particular flow > gets removed from the system. This can be useful when debugging performance > issues tied to ofproto flow changes, trying to determine deployed traffic >

Re: [ovs-dev] [PATCH ovn] doc: Explicitly mention the current LTS release.

On 1/13/23 03:01, Dumitru Ceara wrote: On 1/12/23 20:59, Han Zhou wrote: On Thu, Jan 12, 2023 at 9:50 AM Dumitru Ceara wrote: Until now we only mentioned it on the ovn.org releases page: https://www.ovn.org/en/releases/ Signed-off-by: Dumitru Ceara ---

Re: [ovs-dev] [PATCH ovn] northd, controller: Commit flows dropped by ACLs to conntrack

Hello Abhiram, I haven't taken a close look at every line of the series, but I have two high-level questions/observations. First, what is the benefit of using this compared to ACL logging or drop sampling? Second, I think that if we are to accept this patch, the behavior needs to be

Re: [ovs-dev] [PATCH v2 1/2] ovsdb-idl: Provide API to disable set_db_change_aware request.

On 1/12/23 18:08, Han Zhou wrote: > For ovsdb clients that are short-lived, e.g. when using > ovn-nbctl/ovn-sbctl to read some metrics from the OVN NB/SB server, they > don't really need to be aware of db changes, because they exit > immediately after getting the initial response for the requested

Re: [ovs-dev] [PATCH v7 0/2] Add extension for partial CT flush

On 1/16/23 12:45, Ales Musil wrote: > Add extension that will allow to flush > connection from CT specified by full > orig 5-tuple or partial match that combines > orig or reply direction. > > Ales Musil (2): > ofp, dpif: Allow CT flush based on partial match > openflow: Add extension to

[ovs-dev] OVS has now branched for the 3.1 release.

Hi, everyone. branch-3.1 was just created. Please, test it and report issues! Official release date, according to our release process, should be on Thursday, February 16th (1 month from now). Best regards, Ilya Maximets. ___ dev mailing list

Re: [ovs-dev] [PATCH 2/2] Prepare for post-3.1.0 (3.1.90).

On 1/16/23 18:12, Aaron Conole wrote: > Ilya Maximets writes: > >> Signed-off-by: Ilya Maximets >> --- > > Acked-by: Aaron Conole > Thanks! Applied. Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v3] dpif-netdev: Optimize flushing of output packet buffers

On 1/13/23 13:20, Dheeraj Kumar wrote: > Problem Statement: > Before OVS 2.12 the OVS-DPDK datapath transmitted processed rx packet batches > directly to the wanted tx queues. In OVS 2.12 each PMD stores the processed > packets in an intermediate buffer per output port and flushes these output >

Re: [ovs-dev] [PATCH v1 1/2] ofproto-ipfix: use per-domain template timeouts

On Mon, Jan 16, 2023 at 10:17 AM Adrián Moreno wrote: > > From: Adrian Moreno > > IPFIX templates have to be sent for each Observation Domain ID. > Currently, a timer is kept at each dpif_ipfix_exporter to send them. > This works fine for per-bridge sampling where there is only one > Observation

Re: [ovs-dev] [PATCH 2/2] Prepare for post-3.1.0 (3.1.90).

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] Prepare for 3.1.0.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] controller: use packet proto for hairpin traffic learned action if not specified

Thanks Lorenzo and Ales. I pushed this change all the way back to branch-21.12 On 1/13/23 06:14, Ales Musil wrote: On Wed, Jan 11, 2023 at 11:46 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: Rely on IP protocol from the incoming packet for learn action in table 68 if it has not

[ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Use Fedora 37 as base image.

Fedora 35 is EOL: https://docs.fedoraproject.org/en-US/releases/eol/ Signed-off-by: Dumitru Ceara --- .ci/ovn-kubernetes/Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.ci/ovn-kubernetes/Dockerfile b/.ci/ovn-kubernetes/Dockerfile index 7edf86a13a..1cb26d0d0e

[ovs-dev] [PATCH 2/2] Prepare for post-3.1.0 (3.1.90).

Signed-off-by: Ilya Maximets --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 933c5700f..02ef48590 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +Post-v3.1.0 +

[ovs-dev] [PATCH 1/2] Prepare for 3.1.0.

Signed-off-by: Ilya Maximets --- Documentation/faq/releases.rst | 1 + NEWS | 2 +- configure.ac | 2 +- debian/changelog | 4 ++-- debian/rules | 4 ++-- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git

[ovs-dev] [PATCH 0/2] Patches to branch for 3.1.

There is still a couple of changes that need to go in today before the actual branching, includng CT_FLUSH extention and db_change_aware change. Sending this patch set earlier to get it reviewed in time and not bother people later. Ilya Maximets (2): Prepare for 3.1.0. Prepare for post-3.1.0

Re: [ovs-dev] [PATCH ovn 5/6] controller: only sample flow if Collector Set exists

On 1/13/23 10:30, Adrian Moreno wrote: On 1/6/23 20:15, Mark Michelson wrote: The code change on its own is fine, so Acked-by: Mark Michelson I have a note down below. On 12/19/22 11:18, Adrian Moreno wrote: Adding a OFPACT_SAMPLE action to a flow is useless (and even detrimental in

Re: [ovs-dev] OVS "soft freeze" for 3.1 is in effect.

On 16 Jan 2023, at 14:05, Ilya Maximets wrote: > On 1/12/23 20:38, Dumitru Ceara wrote: >> On 1/12/23 19:13, Han Zhou wrote: >>> On Mon, Jan 2, 2023 at 3:08 PM Ilya Maximets wrote: Hi. As described in Documentation/internals/release-process.rst, we are in a "soft freeze" state:

Re: [ovs-dev] [PATCH v1 1/2] ofproto-ipfix: use per-domain template timeouts

Bleep bloop. Greetings Adrián Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #271 FILE: ofproto/ofproto-dpif-ipfix.c:2925: /*

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall.c: Add counters for reasons of DP flow deletions.

On 18 Oct 2022, at 18:11, Adrian Moreno wrote: > On 10/14/22 20:07, Han Zhou wrote: >> >> >> On Thu, Oct 13, 2022 at 11:51 PM Adrian Moreno > > wrote: >>> >>> >>> >>> On 8/9/22 03:41, Han Zhou wrote: Signed-off-by: Han Zhou mailto:hz...@ovn.org>> ---  

[ovs-dev] [PATCH v1 1/2] ofproto-ipfix: use per-domain template timeouts

From: Adrian Moreno IPFIX templates have to be sent for each Observation Domain ID. Currently, a timer is kept at each dpif_ipfix_exporter to send them. This works fine for per-bridge sampling where there is only one Observation Domain ID per exporter. However, this is does not work for per-flow

[ovs-dev] [PATCH v1 2/2] ipfix: make template and stats interval configurable

From: Adrian Moreno Add options to the IPFIX table configure the interval to send statistics and template information. Signed-off-by: Adrian Moreno --- - v1: - Added unit test. --- NEWS | 2 ++ ofproto/ofproto-dpif-ipfix.c | 38 +

Re: [ovs-dev] [PATCH v7 2/2] openflow: Add extension to flush CT by generic match

On Mon, Jan 16, 2023 at 12:45 PM Ales Musil wrote: > Add extension that allows to flush connections from CT > by specifying fields that the connections should be > matched against. This allows to match only some fields > of the connection e.g. source address for orig direction. > > Reported-at:

Re: [ovs-dev] [PATCH 1/2] Revalidator: Allow min-revalidator-pps to be 0 (disabled).

On 18 Oct 2022, at 18:08, Adrian Moreno wrote: > On 10/14/22 19:49, Han Zhou wrote: >> >> >> On Thu, Oct 13, 2022 at 11:43 PM Adrian Moreno > > wrote: >>> >>> Hi Han. >>> >>> On 8/9/22 03:40, Han Zhou wrote: Today the minimum value for this setting is 1. This

[ovs-dev] [PATCH ovn] northd: Add logical flows to allow rpl/rel traffic in acl_after_lb stage.

Otherwise we cannot correctly implement "allow-related" semantics when default_acl_drop is set to "true". Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1947807#c11 74d82e296f80 ("northd: Support the option to apply from-lport ACLs after load balancer.") Signed-off-by: Dumitru Ceara

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix deadlock due to virtqueue stats retrieval.

On 1/16/23 14:41, David Marchand wrote: > On Fri, Jan 13, 2023 at 4:57 PM Ilya Maximets wrote: > @@ -5766,6 +5804,7 @@ static const struct netdev_class dpdk_vhost_class = > { > static const struct netdev_class dpdk_vhost_client_class = { > .type = "dpdkvhostuserclient",

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix deadlock due to virtqueue stats retrieval.

On Fri, Jan 13, 2023 at 4:57 PM Ilya Maximets wrote: > >>> @@ -5766,6 +5804,7 @@ static const struct netdev_class dpdk_vhost_class = > >>> { > >>> static const struct netdev_class dpdk_vhost_client_class = { > >>> .type = "dpdkvhostuserclient", > >>> NETDEV_DPDK_CLASS_COMMON, > >>> +

Re: [ovs-dev] [PATCH ovn] Update release-process.rst to have the 2024 calendar.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Mark Michelson needs to sign off. Lines checked: 62, Warnings: 0, Errors: 1

[ovs-dev] [PATCH ovn] Update release-process.rst to have the 2024 calendar.

--- Documentation/internals/release-process.rst | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/Documentation/internals/release-process.rst b/Documentation/internals/release-process.rst index 13a22fa60..ac278bd4a 100644 ---

[ovs-dev] [PATCH v2] id-pool: Refactor to use a bitmap.

Using a bitmap makes the id-pool use less memory and be more cache-friendly. It theoretically should be faster since hashes do not have to be computed. This takes the approach of expanding the bitmap when necessary rather than allocating the entire space at once. This makes the approach less

Re: [ovs-dev] OVS "soft freeze" for 3.1 is in effect.

On 1/12/23 20:38, Dumitru Ceara wrote: > On 1/12/23 19:13, Han Zhou wrote: >> On Mon, Jan 2, 2023 at 3:08 PM Ilya Maximets wrote: >>> >>> Hi. As described in Documentation/internals/release-process.rst, we are >>> in a "soft freeze" state: >>> >>>During the freeze, we ask committers to

Re: [ovs-dev] [PATCH v7 1/2] ofp, dpif: Allow CT flush based on partial match

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 106 characters long (recommended limit is 79) #619 FILE: lib/dpctl.man:305:

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps

On 1/10/23 11:02, Eelco Chaudron wrote: > On 5 Jan 2023, at 14:39, Eelco Chaudron wrote: > > > I'm not saying that we don't have issue with statistics. We do have 2 separate issues here - dump duration and statistics update frequency. Just trying to figure out which is a primary

[ovs-dev] [PATCH v7 1/2] ofp, dpif: Allow CT flush based on partial match

Currently, the CT can be flushed by dpctl only by specifying the whole 5-tuple. This is not very convenient when there are only some fields known to the user of CT flush. Add new struct ofputil_ct_match which represents the generic filtering that can be done for CT flush. The match is done only on

[ovs-dev] [PATCH v7 0/2] Add extension for partial CT flush

Add extension that will allow to flush connection from CT specified by full orig 5-tuple or partial match that combines orig or reply direction. Ales Musil (2): ofp, dpif: Allow CT flush based on partial match openflow: Add extension to flush CT by generic match NEWS

[ovs-dev] [PATCH v7 2/2] openflow: Add extension to flush CT by generic match

Add extension that allows to flush connections from CT by specifying fields that the connections should be matched against. This allows to match only some fields of the connection e.g. source address for orig direction. Reported-at: https://bugzilla.redhat.com/2120546 Signed-off-by: Ales Musil

Re: [ovs-dev] [PATCH v6 1/2] ofp, dpif: Allow CT flush based on partial match

On Mon, Jan 16, 2023 at 12:20 PM Ilya Maximets wrote: > On 1/16/23 12:08, Ales Musil wrote: > > > > > > On Mon, Jan 16, 2023 at 10:53 AM Ilya Maximets > wrote: > > > > On 1/16/23 07:21, Ales Musil wrote: > > > > > > > > > On Fri, Jan 13, 2023 at 9:58

Re: [ovs-dev] [PATCH v6 1/2] ofp, dpif: Allow CT flush based on partial match

On 1/16/23 12:08, Ales Musil wrote: > > > On Mon, Jan 16, 2023 at 10:53 AM Ilya Maximets > wrote: > > On 1/16/23 07:21, Ales Musil wrote: > > > > > > On Fri, Jan 13, 2023 at 9:58 PM Ilya Maximets

Re: [ovs-dev] [PATCH v6 1/2] ofp, dpif: Allow CT flush based on partial match

On Mon, Jan 16, 2023 at 10:53 AM Ilya Maximets wrote: > On 1/16/23 07:21, Ales Musil wrote: > > > > > > On Fri, Jan 13, 2023 at 9:58 PM Ilya Maximets > wrote: > > > > On 1/12/23 18:17, Ales Musil wrote: > > > Currently, the CT can be flushed by dpctl only by

Re: [ovs-dev] [PATCH v6 1/2] ofp, dpif: Allow CT flush based on partial match

On 1/16/23 07:21, Ales Musil wrote: > > > On Fri, Jan 13, 2023 at 9:58 PM Ilya Maximets > wrote: > > On 1/12/23 18:17, Ales Musil wrote: > > Currently, the CT can be flushed by dpctl only by specifying > > the whole 5-tuple. This is not very convenient