Re: [ovs-dev] [PATCH ovn v2 00/18] northd lflow incremental processing

On Thu, Oct 26, 2023 at 11:12 AM wrote: > > From: Numan Siddique > > This patch series adds incremental processing in the lflow engine > node to handle changes to northd and other engine nodes. > Changed related to load balancers and NAT are mainly handled in > this patch series. > > This patch

Re: [ovs-dev] [PATCH branch-2.17] datapath-linux: Fix kmod build with recent CentOS Stream kernels

Hi Ilya, Thanks for the review. regards, Vladislav Odintsov > On 15 Nov 2023, at 00:17, Ilya Maximets wrote: > > On 11/14/23 13:47, Vladislav Odintsov wrote: >> With kernel 4.18.0-477.x.y there was a compilation error: >> >>

Re: [ovs-dev] [PATCH ovn v2 09/18] northd: Add a new node ls_lbacls.

On Thu, Oct 26, 2023 at 11:17 AM wrote: > > From: Numan Siddique > > This new engine now maintains the load balancer and ACL data of a > logical switch which was earlier part of northd engine node data. > The main inputs to this engine are: > - northd node > - NB logical switch node >

Re: [ovs-dev] [PATCH ovn v2 08/18] northd: Don't commit dhcp response flows in the conntrack.

On Thu, Oct 26, 2023 at 11:16 AM wrote: > > From: Numan Siddique > > This is not required. > Thanks Numan for the fix. Could you provide a little more detail why this is not required: - Is it a bug fix? What's the impact? - Shall we update the ovn-northd documentation for the related lflow

Re: [ovs-dev] [PATCH ovn v2 07/18] northd: Generate logical router's LB and NAT flows using lr_lbnat_data.

On Thu, Oct 26, 2023 at 11:16 AM wrote: > > From: Numan Siddique > > Previous commits added new engine nodes to store logical router's lb > and NAT data. Make use of the data stored by these engine nodes > to generate logical flows related to router's LBs and NATs. > > Signed-off-by: Numan

Re: [ovs-dev] [PATCH ovn v2 05/18] northd: Add a new engine 'lr-nat' to manage lr NAT data.

On Thu, Oct 26, 2023 at 11:15 AM wrote: > > From: Numan Siddique > > This new engine now maintains the NAT related data for each > logical router which was earlier maintained by the northd > engine node in the 'struct ovn_datapath'. Main inputs to > this engine node are: >- northd >- NB

Re: [ovs-dev] [PATCH ovn v2 04/18] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

On Tue, Nov 14, 2023 at 9:40 PM Han Zhou wrote: > > > > On Thu, Oct 26, 2023 at 11:15 AM wrote: > > > > From: Numan Siddique > > > > It also moves the logical router port IPv6 prefix delegation > > updates to "sync-from-sb" engine node. > > > > Signed-off-by: Numan Siddique > > --- > >

Re: [ovs-dev] [PATCH ovn v2 04/18] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

On Thu, Oct 26, 2023 at 11:15 AM wrote: > > From: Numan Siddique > > It also moves the logical router port IPv6 prefix delegation > updates to "sync-from-sb" engine node. > > Signed-off-by: Numan Siddique > --- > northd/en-northd.c | 2 +- > northd/en-sync-sb.c | 3 +- > northd/northd.c

Re: [ovs-dev] [PATCH ovn v2 02/18] northd: Track ovn_datapaths in northd engine track data.

On Thu, Oct 26, 2023 at 11:14 AM wrote: > > From: Numan Siddique > > northd engine tracked data now also stores the logical switches > and logical routers that got updated due to the changed load balancers. > > Eg 1. For this command 'ovn-nbctl ls-lb-add sw0 lb1 -- lr-lb-add lr0 > lb1', northd

Re: [ovs-dev] [PATCH ovn v2 01/18] northd: Refactor the northd change tracking.

On Thu, Oct 26, 2023 at 11:14 AM wrote: > > From: Numan Siddique > > northd engine tracking data now has the following tracking data > - changed ovn_ports (right now only changed logical switch ports are > tracked.) > - changed load balancers. > > This separation becomes easier to add

Re: [ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

Eelco Chaudron writes: > On 14 Nov 2023, at 8:49, Roi Dayan wrote: > >> On 13/11/2023 19:08, Aaron Conole wrote: >>> Roi Dayan writes: >>> codespell dictionary contains a list of widely used words which enchant alone could fail on. for an example: refcount, pthread, enqueuing,

Re: [ovs-dev] [RFC OVN] DHCP Relay Agent support for overlay subnets

> On 15-Nov-2023, at 3:01 AM, Numan Siddique wrote: > > On Fri, Nov 10, 2023 at 2:46 PM Naveen Yerramneni > wrote: >> >> >> >>> On 10-Nov-2023, at 10:52 PM, Numan Siddique wrote: >>> >>> On Fri, Nov 3, 2023 at 1:36 PM naveen.yerramneni >>> wrote: This patch contains changes

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

On Mon, Oct 30, 2023 at 03:00:29PM +0100, Ilya Maximets wrote: > There is no TCA_TUNNEL_KEY_ENC_SRC_PORT in the kernel, so the offload > should not be attempted if OVS_TUNNEL_KEY_ATTR_TP_SRC is requested > by OVS. Current code just ignores the attribute in the tunnel(set()) > action leading to a

Re: [ovs-dev] [RFC OVN] DHCP Relay Agent support for overlay subnets

On Fri, Nov 10, 2023 at 2:46 PM Naveen Yerramneni wrote: > > > > > On 10-Nov-2023, at 10:52 PM, Numan Siddique wrote: > > > > On Fri, Nov 3, 2023 at 1:36 PM naveen.yerramneni > > wrote: > >> > >>This patch contains changes to enable DHCP Relay Agent support for > >> overlay subnets. > >> >

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

(re-send as for some reason gmail rejected the previous attempt and it wasn't delivered to Vladislav) On 11/13/23 20:25, Ilya Maximets wrote: > On 11/13/23 13:13, Eelco Chaudron wrote: >> >> >> On 13 Nov 2023, at 12:43, Vladislav Odintsov wrote: >> On 13 Nov 2023, at 14:17, Eelco Chaudron

Re: [ovs-dev] [PATCH] build-aux/extract-ofp-fields: Fix the number of Summary columns.

On 11/14/23 14:28, Simon Horman wrote: > On Fri, Nov 03, 2023 at 08:04:53PM +0100, Ilya Maximets wrote: >> The table has only 6 columns, not 7. This doesn't really affect >> rendering. Only slightly affects calculations around how much space >> the table needs. >> >> Fixes: 96fee5e0a2a0

Re: [ovs-dev] [PATCH] release-process: Update LTS designation schedule example.

On 11/14/23 14:38, Eelco Chaudron wrote: > > > On 3 Nov 2023, at 20:01, Ilya Maximets wrote: > >> It is an example and the dates are not set in stone, so updating >> the table it is not very important. But it's nice to see currently >> supported releases there as well as the near future plans.

Re: [ovs-dev] [PATCH branch-2.17] datapath-linux: Fix kmod build with recent CentOS Stream kernels

On 11/14/23 13:47, Vladislav Odintsov wrote: > With kernel 4.18.0-477.x.y there was a compilation error: > > /builddir/build/BUILD/openvswitch-2.17.3/_4.18.0-477.10.1.el8_8.x86_64/../datapath/linux/compat/include/linux/mm.h:13:21: > error: redefinition of 'kvmalloc' > static inline void

Re: [ovs-dev] [PATCH ovn branch-22.03 v2] ovs: Bump submodule to use v3.0.5.

Thanks Dumitru, Acked-by: Mark Michelson On 11/13/23 11:35, Dumitru Ceara wrote: It's better to use a release tag now that one is available. Signed-off-by: Dumitru Ceara This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653

Re: [ovs-dev] [PATCH ovn branch-22.06 v2] ovs: Bump submodule to use v3.0.5.

Thanks Dumitru, Acked-by: Mark Michelson On 11/13/23 11:34, Dumitru Ceara wrote: It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil

Re: [ovs-dev] [PATCH ovn branch-22.09 v2] ovs: Bump submodule to use v3.0.5.

Thanks Dumitru, Acked-by: Mark Michelson On 11/13/23 11:32, Dumitru Ceara wrote: It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil

Re: [ovs-dev] [PATCH ovn branch-22.12 v2] ovs: Bump submodule to v3.1.3.

Thanks Dumitru, Acked-by: Mark Michelson On 11/13/23 11:31, Dumitru Ceara wrote: It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil

Re: [ovs-dev] [PATCH ovn branch-23.06 v2] ovs: Bump submodule to v3.1.3.

Thanks Dumitru, Acked-by: Mark Michelson On 11/13/23 11:27, Dumitru Ceara wrote: This picks up the following relevant patch: 4c027ebd3bb1 ("ovs.tmac: Fix troff warning in versions above groff-1.23.") Without it the 'rpm-fedora' make target is broken, failing with:

Re: [ovs-dev] [PATCH ovn branch-23.03 v2] ovs: Bump submodule to v3.1.3.

Thanks Dumitru, Acked-by: Mark Michelson On 11/13/23 11:29, Dumitru Ceara wrote: It's better to use a release tag now that one is available. This also partially backports the similar commit from branch-23.09: commit 558da0cd21ad0172405f7d93c5d0e7533edbf653 Author: Ales Musil

Re: [ovs-dev] [PATCH ovn v3] py-requirements: Remove hacking dependency and use recent flake8.

Thanks Dumitru, Acked-by: Mark Michelson On 11/14/23 06:38, Dumitru Ceara wrote: Without this, when using Python 3.12 and flake8 5.0.4, the following errors are flagged: tests/check_acl_log.py:97:25: E231 missing whitespace after ':' tests/check_acl_log.py:102:71: E231 missing

Re: [ovs-dev] [PATCH ovn v2 0/2] Documentation: Fix the Read The Docs build.

On 11/13/23 17:12, Dumitru Ceara wrote: On 11/13/23 17:30, Ilya Maximets wrote: Since last month ReadTheDocs only supports building with a new configuration file provided in the repository itself: https://blog.readthedocs.com/migrate-configuration-v2/ So, all our documentation builds are

[ovs-dev] [PATCH ovn v2 06/13] tests: Use fmt_pkt in 3 HVs, 3 LS, 3 lports/LS.

This test is slower than it used to be since some of the test_ip calls that were backgrounded (with '&') cannot do this anymore. This is because there is a race condition with starting the scapy server when the calls are backgrounded. Execution time: 36.471s Execution time on "main" branch:

[ovs-dev] [PATCH ovn v2 03/13] tests: Use fmt_pkt in VLAN transparency, ...

...passthru=true, ARP responder disabled Execution time: 2.466s Execution time on "main" branch: 1.751s Signed-off-by: Mark Michelson --- tests/ovn.at | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 1b76c0807..1f96f2091

[ovs-dev] [PATCH ovn v2 13/13] tests: Use fmt_pkt in icmp_reply: 1 HVs, 2 LSs, 1 lport/LS, 1 LR.

Execution time: 3.791s Execution time on "main" branch: 2.897s Signed-off-by: Mark Michelson --- tests/ovn.at | 66 +--- 1 file changed, 26 insertions(+), 40 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 27053d5ca..d1e049377 100644

[ovs-dev] [PATCH ovn v2 11/13] tests: Use fmt_pkt in 2 HVs, 3 LRs connected via LS, static routes.

Execution time: 4.308s Execution time on "main" branch: 3.170s Signed-off-by: Mark Michelson --- tests/ovn.at | 49 + 1 file changed, 29 insertions(+), 20 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index e3568b171..b8156caec 100644 ---

[ovs-dev] [PATCH ovn v2 10/13] tests: Use fmt_pkt in 2 HVs, 3 LS, 1 lport/LS, ...

... 2 peer LRs, static routes. Execution time: 4.114s Execution time on "main" branch: 3.428s Signed-off-by: Mark Michelson --- tests/ovn.at | 49 + 1 file changed, 29 insertions(+), 20 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index

[ovs-dev] [PATCH ovn v2 12/13] tests: Use fmt_pkt in 2 HVs, 2 LRs connected via LS, gateway router.

Execution time: 4.100s Execution time on "main" branch: 3.083s Signed-off-by: Mark Michelson --- tests/ovn.at | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index b8156caec..27053d5ca 100644 --- a/tests/ovn.at +++

[ovs-dev] [PATCH ovn v2 09/13] tests: Use fmt_pkt in 1 HV, 2 LSs, 1 lport/LS, 1 LR.

Execution time: 3.329s Execution time on "main" branch: 2.794s Signed-off-by: Mark Michelson --- tests/ovn.at | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 44b2c1650..a394e67bf 100644 --- a/tests/ovn.at +++

[ovs-dev] [PATCH ovn v2 07/13] tests: Use fmt_pkt in portsecurity : 3 HVs, 1 LS, 3 lports/HV.

This test is much slower with fmt_pkt compared to main. It's likely due to the high number of fmt_pkt calls made during the test. Execution time: 17.484s Execution time on "main" branch: 4.975s Signed-off-by: Mark Michelson --- tests/ovn.at | 225

[ovs-dev] [PATCH ovn v2 08/13] tests: Use fmt_pkt in 1 HV, 1 LS, 2 lport/LS, 1 LR.

Execution time: 3.413s Execution time on "main" branch: 2.675s Signed-off-by: Mark Michelson --- tests/ovn.at | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index c81566708..44b2c1650 100644 --- a/tests/ovn.at +++

[ovs-dev] [PATCH ovn v2 02/13] tests: Use fmt_pkt in 3 HVs, 1 LS, 3 lports/HV.

This only uses fmt_pkt in test_arp(). test_packet() purposely sends packets with odd and/or malformed ethertypes, which makes it a poor fit for fmt_pkt(). We could use some sort of raw packet method of scapy, but that seems like a roundabout way of getting what we already have in the test.

[ovs-dev] [PATCH ovn v2 04/13] tests: Use fmt_pkt in VLAN transparency, ...

...passthru=true, ND/NA responder disabled. Note that in order to be able to get the solicited node multicast address, we need access to the socket library. This commit imports the socket library from python. To reduce the amount of text in OVN test cases, we import *. Execution time: 2.290s

[ovs-dev] [PATCH ovn v2 05/13] tests: Use fmt_pkt in vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS.

I have no idea why, but this is the only patch in this series where the execution time is *improved* by switching to fmt_pkt. Execution time: 8.321s Execution time on "main" branch: 8.576s Signed-off-by: Mark Michelson --- tests/ovn.at | 77 ++--

[ovs-dev] [PATCH ovn v2 01/13] tests: Use fmt_pkt in ovn -- allows ACLs to match ...

... against vlan-transparent double tagged traffic L3 fields. Execution time: 2.377s Execution time on "main" branch: 1.997s Signed-off-by: Mark Michelson --- tests/ovn.at | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index

[ovs-dev] [PATCH ovn v2 00/13] Convert some tests to use fmt_pkt.

Note: v1 and v2 differences are listed at the bottom of this cover leter. The introduction of fmt_pkt has made construction of new tests easier since we no longer need to input packet data manually. fmt_pkt can also be applied to existing tests to improve their readability and debuggability. This

Re: [ovs-dev] [PATCH v5 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

On 11/7/23 08:30, Nobuhiro MIKI wrote: > A conjunctive flow consists of two or more multiple flows with > conjunction actions. When input to the ofproto/trace command > matches a conjunctive flow, it outputs flows of all dimensions. > > Acked-by: Simon Horman > Signed-off-by: Nobuhiro MIKI >

Re: [ovs-dev] [PATCH ovn 06/13] tests: Use fmt_pkt in 3 HVs, 3 LS, 3 lports/LS.

On 10/12/23 16:58, Ihar Hrachyshka wrote: On Tue, Oct 10, 2023 at 4:34 PM Mark Michelson > wrote: This test is slower than it used to be since some of the test_ip calls that were backgrounded (with '&') cannot do this anymore. This is because there is a

Re: [ovs-dev] [PATCH ovn 04/13] tests: Use fmt_pkt in VLAN transparency, ...

On 10/12/23 17:06, Ihar Hrachyshka wrote: On Tue, Oct 10, 2023 at 4:34 PM Mark Michelson > wrote: ...passthru=true, ND/NA responder disabled. Note that in order to be able to get the solicited node multicast address, we need access to the socket library.

Re: [ovs-dev] [PATCH v4 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

On 11/7/23 07:56, Nobuhiro MIKI wrote: > On 2023/11/02 5:39, Ilya Maximets wrote: >> On 10/30/23 06:00, Nobuhiro MIKI wrote: >>> A conjunctive flow consists of two or more multiple flows with >>> conjunction actions. When input to the ofproto/trace command >>> matches a conjunctive flow, it

[ovs-dev] [PATCH v5] ovs-ofctl: Implement compose-packet --bare [--bad-csum].

With --bare, it will produce a bare hexified payload with no spaces or offset indicators inserted, which is useful in tests to produce frames to pass to e.g. `ovs-ofctl receive`. With --bad-csum, it will produce a frame that has an invalid IP checksum (applicable to IPv4 only because IPv6 doesn't

Re: [ovs-dev] [PATCH ovn] README: Add build badges.

On 11/14/23 16:00, Ilya Maximets wrote: > On 11/14/23 13:31, Dumitru Ceara wrote: >> On 11/14/23 13:23, Ilya Maximets wrote: >>> On 11/14/23 13:12, Dumitru Ceara wrote: On 11/14/23 12:57, Ilya Maximets wrote: > On 11/14/23 12:52, Dumitru Ceara wrote: >> On 11/14/23 12:18, Ilya

Re: [ovs-dev] [PATCH ovn] README: Add build badges.

On 11/14/23 13:31, Dumitru Ceara wrote: > On 11/14/23 13:23, Ilya Maximets wrote: >> On 11/14/23 13:12, Dumitru Ceara wrote: >>> On 11/14/23 12:57, Ilya Maximets wrote: On 11/14/23 12:52, Dumitru Ceara wrote: > On 11/14/23 12:18, Ilya Maximets wrote: >> These are useful to spot build

Re: [ovs-dev] [PATCH ovn v3] py-requirements: Remove hacking dependency and use recent flake8.

On 11/14/23 12:38, Dumitru Ceara wrote: > Without this, when using Python 3.12 and flake8 5.0.4, the following > errors are flagged: > tests/check_acl_log.py:97:25: E231 missing whitespace after ':' > tests/check_acl_log.py:102:71: E231 missing whitespace after ':' > > This was reported and

Re: [ovs-dev] [PATCH ovn v3] py-requirements: Remove hacking dependency and use recent flake8.

On Tue, Nov 14, 2023 at 12:38 PM Dumitru Ceara wrote: > Without this, when using Python 3.12 and flake8 5.0.4, the following > errors are flagged: > tests/check_acl_log.py:97:25: E231 missing whitespace after ':' > tests/check_acl_log.py:102:71: E231 missing whitespace after ':' > > This was

Re: [ovs-dev] [PATCH] release-process: Update LTS designation schedule example.

On 3 Nov 2023, at 20:01, Ilya Maximets wrote: > It is an example and the dates are not set in stone, so updating > the table it is not very important. But it's nice to see currently > supported releases there as well as the near future plans. > > Signed-off-by: Ilya Maximets Thanks for

Re: [ovs-dev] [PATCH] release-process: Update LTS designation schedule example.

On Fri, Nov 03, 2023 at 08:01:40PM +0100, Ilya Maximets wrote: > It is an example and the dates are not set in stone, so updating > the table it is not very important. But it's nice to see currently > supported releases there as well as the near future plans. > > Signed-off-by: Ilya Maximets

Re: [ovs-dev] [PATCH] build-aux/extract-ofp-fields: Fix the number of Summary columns.

On Fri, Nov 03, 2023 at 08:04:53PM +0100, Ilya Maximets wrote: > The table has only 6 columns, not 7. This doesn't really affect > rendering. Only slightly affects calculations around how much space > the table needs. > > Fixes: 96fee5e0a2a0 ("ovs-fields: New manpage to document Open vSwitch

Re: [ovs-dev] [PATCH v6 1/3] netdev-linux: Use ethtool to detect offload support.

On Tue, Oct 31, 2023 at 03:51:36PM -0400, Mike Pattrick wrote: > Currently when userspace-tso is enabled, netdev-linux interfaces will > indicate support for all offload flags regardless of interface > configuration. This patch checks for which offload features are enabled > during netdev

Re: [ovs-dev] [PATCH v6 3/3] userspace: Add Generic Segmentation Offloading.

On Tue, Oct 31, 2023 at 03:51:38PM -0400, Mike Pattrick wrote: > From: Flavio Leitner > > This provides a software implementation in the case > the egress netdev doesn't support segmentation in hardware. > > The challenge here is to guarantee packet ordering in the > original batch that may be

Re: [ovs-dev] [PATCH v6 2/3] userspace: Respect tso/gso segment size.

On Tue, Oct 31, 2023 at 03:51:37PM -0400, Mike Pattrick wrote: > From: Flavio Leitner > > Currently OVS will calculate the segment size based on the > MTU of the egress port. That usually happens to be correct > when the ports share the same MTU, but that is not always true. > > Therefore, if

Re: [ovs-dev] [PATCH branch-2.17] datapath-linux: Fix kmod build with recent CentOS Stream kernels

Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: datapath-linux: Fix kmod

[ovs-dev] [PATCH branch-2.17] datapath-linux: Fix kmod build with recent CentOS Stream kernels

With kernel 4.18.0-477.x.y there was a compilation error: /builddir/build/BUILD/openvswitch-2.17.3/_4.18.0-477.10.1.el8_8.x86_64/../datapath/linux/compat/include/linux/mm.h:13:21: error: redefinition of 'kvmalloc' static inline void *kvmalloc(size_t size, gfp_t flags)

Re: [ovs-dev] [PATCH ovn] README: Add build badges.

On 11/14/23 13:23, Ilya Maximets wrote: > On 11/14/23 13:12, Dumitru Ceara wrote: >> On 11/14/23 12:57, Ilya Maximets wrote: >>> On 11/14/23 12:52, Dumitru Ceara wrote: On 11/14/23 12:18, Ilya Maximets wrote: > These are useful to spot build failures in different CI systems. > For

Re: [ovs-dev] [PATCH ovn] README: Add build badges.

On 11/14/23 13:12, Dumitru Ceara wrote: > On 11/14/23 12:57, Ilya Maximets wrote: >> On 11/14/23 12:52, Dumitru Ceara wrote: >>> On 11/14/23 12:18, Ilya Maximets wrote: These are useful to spot build failures in different CI systems. For example, documentation build is failing for about

Re: [ovs-dev] [PATCH ovn] README: Add build badges.

On 11/14/23 12:57, Ilya Maximets wrote: > On 11/14/23 12:52, Dumitru Ceara wrote: >> On 11/14/23 12:18, Ilya Maximets wrote: >>> These are useful to spot build failures in different CI systems. >>> For example, documentation build is failing for about 2 months >>> now, the badge might help with

Re: [ovs-dev] [PATCH ovn] README: Add build badges.

On 11/14/23 12:52, Dumitru Ceara wrote: > On 11/14/23 12:18, Ilya Maximets wrote: >> These are useful to spot build failures in different CI systems. >> For example, documentation build is failing for about 2 months >> now, the badge might help with spotting the issue earlier. >> >> Signed-off-by:

Re: [ovs-dev] [PATCH ovn] README: Add build badges.

On 11/14/23 12:18, Ilya Maximets wrote: > These are useful to spot build failures in different CI systems. > For example, documentation build is failing for about 2 months > now, the badge might help with spotting the issue earlier. > > Signed-off-by: Ilya Maximets > --- Awesome! One minor

Re: [ovs-dev] [PATCH ovn v2] py-requirements: Remove hacking dependency and use recent flake8.

On 11/14/23 11:58, Ilya Maximets wrote: > On 11/14/23 11:43, Dumitru Ceara wrote: >> On 11/14/23 11:33, Ilya Maximets wrote: >>> On 11/14/23 11:26, Ilya Maximets wrote: On 11/13/23 17:45, Dumitru Ceara wrote: > Without this, when using Python 3.12 and flake8 5.0.4, the following >

Re: [ovs-dev] [PATCH v4] Implement compose-packet --hexified [--bad-csum].

On 11/14/23 12:39, Ilya Maximets wrote: > On 11/2/23 19:02, Ihar Hrachyshka wrote: >> On Wed, Nov 1, 2023 at 5:42 PM Ilya Maximets > > wrote: >> >> On 10/24/23 19:04, Ihar Hrachyshka wrote: >> > With --hexified, it will produce a bare hexified payload with no

Re: [ovs-dev] [PATCH v8 0/3] netdev: Sync and clean {get, set}_config() callbacks.

On 14.11.23 12:17, Kevin Traynor wrote: > On 13/11/2023 08:53, jm...@redhat.com wrote: >> From: Jakob Meng >> >> This patch series incorporates Ilya's comments for v7 and has been rebased >> to master: >> * fixed afxdp status descriptions in vswitchd/vswitch.xml >> * be consistent with

Re: [ovs-dev] [PATCH v4] Implement compose-packet --hexified [--bad-csum].

On 11/2/23 19:02, Ihar Hrachyshka wrote: > On Wed, Nov 1, 2023 at 5:42 PM Ilya Maximets > wrote: > > On 10/24/23 19:04, Ihar Hrachyshka wrote: > > With --hexified, it will produce a bare hexified payload with no spaces > > or offset indicators inserted,

Re: [ovs-dev] [PATCH ovn] README: Add build badges.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 88 characters long (recommended limit is 79) #25 FILE: README.rst:10: ..

[ovs-dev] [PATCH ovn v3] py-requirements: Remove hacking dependency and use recent flake8.

Without this, when using Python 3.12 and flake8 5.0.4, the following errors are flagged: tests/check_acl_log.py:97:25: E231 missing whitespace after ':' tests/check_acl_log.py:102:71: E231 missing whitespace after ':' This was reported and discussed in a couple of contexts:

[ovs-dev] [PATCH ovn] README: Add build badges.

These are useful to spot build failures in different CI systems. For example, documentation build is failing for about 2 months now, the badge might help with spotting the issue earlier. Signed-off-by: Ilya Maximets --- README.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [ovs-dev] [PATCH v8 0/3] netdev: Sync and clean {get, set}_config() callbacks.

On 13/11/2023 08:53, jm...@redhat.com wrote: From: Jakob Meng This patch series incorporates Ilya's comments for v7 and has been rebased to master: * fixed afxdp status descriptions in vswitchd/vswitch.xml * be consistent with rx/Rx/RX/tx/Tx/TX in vswitchd/vswitch.xml Jakob Meng (3):

Re: [ovs-dev] [PATCH ovn v2] py-requirements: Remove hacking dependency and use recent flake8.

On 11/14/23 11:43, Dumitru Ceara wrote: > On 11/14/23 11:33, Ilya Maximets wrote: >> On 11/14/23 11:26, Ilya Maximets wrote: >>> On 11/13/23 17:45, Dumitru Ceara wrote: Without this, when using Python 3.12 and flake8 5.0.4, the following errors are flagged:

Re: [ovs-dev] [PATCH ovn v2] py-requirements: Remove hacking dependency and use recent flake8.

On 11/14/23 11:33, Ilya Maximets wrote: > On 11/14/23 11:26, Ilya Maximets wrote: >> On 11/13/23 17:45, Dumitru Ceara wrote: >>> Without this, when using Python 3.12 and flake8 5.0.4, the following >>> errors are flagged: >>> tests/check_acl_log.py:97:25: E231 missing whitespace after ':' >>>

Re: [ovs-dev] [PATCH ovn v2 0/2] Documentation: Fix the Read The Docs build.

On 11/13/23 23:12, Dumitru Ceara wrote: > On 11/13/23 17:30, Ilya Maximets wrote: >> Since last month ReadTheDocs only supports building with a new >> configuration file provided in the repository itself: >> https://blog.readthedocs.com/migrate-configuration-v2/ >> >> So, all our documentation

Re: [ovs-dev] [PATCH ovn v2] py-requirements: Remove hacking dependency and use recent flake8.

On 11/14/23 11:26, Ilya Maximets wrote: > On 11/13/23 17:45, Dumitru Ceara wrote: >> Without this, when using Python 3.12 and flake8 5.0.4, the following >> errors are flagged: >> tests/check_acl_log.py:97:25: E231 missing whitespace after ':' >> tests/check_acl_log.py:102:71: E231 missing

Re: [ovs-dev] [PATCH ovn v2] py-requirements: Remove hacking dependency and use recent flake8.

On 11/13/23 17:45, Dumitru Ceara wrote: > Without this, when using Python 3.12 and flake8 5.0.4, the following > errors are flagged: > tests/check_acl_log.py:97:25: E231 missing whitespace after ':' > tests/check_acl_log.py:102:71: E231 missing whitespace after ':' > > This was reported and

Re: [ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

On 14 Nov 2023, at 8:49, Roi Dayan wrote: > On 13/11/2023 19:08, Aaron Conole wrote: >> Roi Dayan writes: >> >>> codespell dictionary contains a list of widely used words >>> which enchant alone could fail on. for an example: >>> refcount, pthread, enqueuing, etc. >>> Load that dictionary, if

Re: [ovs-dev] [PATCH v3 1/2] checkpatch: Fix personal word list storage.

On 13 Nov 2023, at 14:00, Roi Dayan wrote: > From: Gaetan Rivet > > The enchant dictionary synchronizes additions to the source file. > Keep the two word source separate by adding the extra words only > to the current session. > > Signed-off-by: Gaetan Rivet > Acked-by: Roi Dayan This