Re: [ovs-dev] [PATCH v7 3/6] ovs-vsctl: Add limit to CT zone.

2023-11-28 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator

[ovs-dev] [PATCH v7 6/6] tests: Do not use zone 0 for CT limit system test.

2023-11-28 Thread Ales Musil
The zone 0 is default system zone, do not use this zone for the test because it might contain some entries already which could cause flakiness during the check. In order to still have the zone 0 parsing coverage add simple unit tests for dpctl. Signed-off-by: Ales Musil --- v7: Rebase on top of

Re: [ovs-dev] [PATCH v6 6/6] tests: Do not use zone 0 for CT limit system test.

2023-11-28 Thread Ales Musil
On Tue, Nov 28, 2023 at 3:06 PM Ilya Maximets wrote: > On 11/2/23 13:00, Ales Musil wrote: > > The zone 0 is default system zone, do not use this > > zone for the test because it might contain some > > entries already which could cause flakiness during > > the check. > > > > In order to still

Re: [ovs-dev] [PATCH v6 5/6] ct-dpif: Enforce CT zone limit protection.

2023-11-28 Thread Ales Musil
On Tue, Nov 28, 2023 at 3:01 PM Ilya Maximets wrote: > On 11/2/23 13:00, Ales Musil wrote: > > Make sure that if any zone limit was set via DB > > all zones are forced to be set there also. This > > is done by tracking which datapath has zone limit > > protection and it is reflected in the dpctl

Re: [ovs-dev] [PATCH v6 1/6] ct-dpif: Handle default zone limit the same way as other limits.

2023-11-28 Thread Ales Musil
On Tue, Nov 28, 2023 at 2:34 PM Ilya Maximets wrote: > On 11/2/23 13:00, Ales Musil wrote: > > Internally handle default CT zone limit as other limits that > > can be passed via the list with special value -1. Currently, > > the -1 is treated by both datapaths as default, add static > > asserts

Re: [ovs-dev] [PATCH v6 3/6] ovs-vsctl: Add limit to CT zone.

2023-11-28 Thread Ales Musil
On Tue, Nov 28, 2023 at 2:54 PM Ilya Maximets wrote: > On 11/2/23 13:00, Ales Musil wrote: > > Add limit to the CT zone DB table with ovs-vsctl > > helper methods. The limit has two special values > > besides any number, 0 is unlimited and empty limit > > is to leave the value untouched in the

Re: [ovs-dev] [PATCH v6 2/6] dpctl: Allow the default CT zone limit to de deleted.

2023-11-28 Thread Ales Musil
On Tue, Nov 28, 2023 at 2:47 PM Ilya Maximets wrote: > On 11/2/23 13:00, Ales Musil wrote: > > Add optional argument to dpctl ct-del-limits called > > "default", which allows to remove the default limit > > making it effectively system default. > > > > Signed-off-by: Ales Musil > > --- > > v6:

[ovs-dev] [PATCH v7 3/6] ovs-vsctl: Add limit to CT zone.

2023-11-28 Thread Ales Musil
Add limit to the CT zone DB table with ovs-vsctl helper methods. The limit has two special values besides any number, 0 is unlimited and empty limit is to leave the value untouched in the datapath. This is preparation step and the value is not yet propagated to the datapath. Signed-off-by: Ales

[ovs-dev] [PATCH v7 4/6] vswitchd, ofproto-dpif: Propagate the CT limit from database.

2023-11-28 Thread Ales Musil
Propagate the CT limit that is present in the DB into datapath. The limit is currently only propagated on change and can be overwritten by the dpctl commands. Signed-off-by: Ales Musil --- v7: Rebase on top of current master. v6: Rebase on top of current master. Address comments from Ilya:

[ovs-dev] [PATCH v7 1/6] ct-dpif: Handle default zone limit the same way as other limits.

2023-11-28 Thread Ales Musil
Internally handle default CT zone limit as other limits that can be passed via the list with special value -1. Currently, the -1 is treated by both datapaths as default, add static asserts to make sure that this remains the case in the future. This allows us to easily delete the default zone

[ovs-dev] [PATCH v7 5/6] ct-dpif: Enforce CT zone limit protection.

2023-11-28 Thread Ales Musil
Make sure that if any zone limit was set via DB all zones are forced to be set there also. This is done by tracking which datapath has zone limit protection and it is reflected in the dpctl command. If the datapath is protected the dpctl command will return permission error. Signed-off-by: Ales

[ovs-dev] [PATCH v7 2/6] dpctl: Allow the default CT zone limit to de deleted.

2023-11-28 Thread Ales Musil
Add optional argument to dpctl ct-del-limits called "default", which allows to remove the default limit making it effectively system default. Signed-off-by: Ales Musil --- v7: Rebase on top of current master. Address cosmetic comments. v6: Rebase on top of current master. Address

[ovs-dev] [PATCH v7 0/6] Expose CT limit via DB

2023-11-28 Thread Ales Musil
The series exposes CT limit via DB, adding user friendly ovs-vsctl interface. The DB value has priority before the dpctl interface, this is achieved by storing which datapath is protected. The dpctl will return an error if the limit is already set in DB for that datapath. Ales Musil (6):

Re: [ovs-dev] [PATCH OVN] Add support to make fdb table local to the chassis.

2023-11-28 Thread 0-day Robot
References: <20231129064550.96265-1-naveen.yerramn...@nutanix.com> Bleep bloop. Greetings naveen.yerramneni, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author

[ovs-dev] [PATCH OVN] Add support to make fdb table local to the chassis.

2023-11-28 Thread naveen.yerramneni
This functionality can be enabled at the logical switch level: - "other_config:fdb_local" can be used to enable/disable this functionality, it is disabled by default. - "other_config:fdb_local_idle_timeout" sepcifies idle timeout for locally learned fdb flows, default timeout is 300

Re: [ovs-dev] [PATCH v2 1/9] ci: Add make check-ovsdb-cluster tests to GitHub action ci.

2023-11-28 Thread Ilya Maximets
On 11/28/23 19:15, Eelco Chaudron wrote: > > > On 28 Nov 2023, at 13:07, Ilya Maximets wrote: > >> On 11/28/23 08:39, Eelco Chaudron wrote: >>> >>> >>> On 27 Nov 2023, at 18:58, Ilya Maximets wrote: >>> On 11/27/23 13:38, Eelco Chaudron wrote: > Signed-off-by: Eelco Chaudron > ---

Re: [ovs-dev] [PATCH v2 3/9] ci: Add make check-offloads to GitHub actions ci.

2023-11-28 Thread Eelco Chaudron
On 28 Nov 2023, at 13:10, Ilya Maximets wrote: > On 11/28/23 08:43, Eelco Chaudron wrote: >> >> >> On 27 Nov 2023, at 19:04, Ilya Maximets wrote: >> >>> On 11/27/23 13:39, Eelco Chaudron wrote: This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip tests that won't execute

Re: [ovs-dev] [PATCH v2 1/9] ci: Add make check-ovsdb-cluster tests to GitHub action ci.

2023-11-28 Thread Eelco Chaudron
On 28 Nov 2023, at 13:07, Ilya Maximets wrote: > On 11/28/23 08:39, Eelco Chaudron wrote: >> >> >> On 27 Nov 2023, at 18:58, Ilya Maximets wrote: >> >>> On 11/27/23 13:38, Eelco Chaudron wrote: Signed-off-by: Eelco Chaudron --- .ci/linux-build.sh |9

Re: [ovs-dev] [PATCH v2] ci: Add clang-analyze to GitHub actions.

2023-11-28 Thread Eelco Chaudron
On 27 Nov 2023, at 19:18, Ilya Maximets wrote: > On 11/27/23 18:36, Eelco Chaudron wrote: >> This patch detects new static analyze issues, and report them. >> It does this by reporting on the delta for this branch, compared >> to the previous branch. >> >> For example the error might look like

[ovs-dev] [PATCH ovn v2 4/4] fmt_pkt: make sure scapy-server is started once

2023-11-28 Thread Ihar Hrachyshka
When running fmt_pkt in parallel, before the patch, there could be several attempts to start scapy-server. Using flock on a test case specific file should guarantee that only one of the subshells will actually be able to start a daemon, which is designed to be a singleton. Now that

[ovs-dev] [PATCH ovn v2 0/4] misc fmt_pkt improvements

2023-11-28 Thread Ihar Hrachyshka
This series, combined with ovs series [1], will allow to execute fmt_pkt in parallel. This will allow to revert back to parallel execution of test_ip in a test conversion patch from Mark [2], and speed up the case while at it. (I will post a separate patch to switch back to background test_ip

[ovs-dev] [PATCH ovn v2 1/4] fmt_pkt: don't subshell when calling ovs-appctl

2023-11-28 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka Acked-by: Mark Michelson --- tests/ovn-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at index 8dc4ec75c..3191bb6ad 100644 --- a/tests/ovn-macros.at +++ b/tests/ovn-macros.at @@ -876,7 +876,7 @@

[ovs-dev] [PATCH ovn v2 3/4] fmt_pkt: improve scapy-server logging

2023-11-28 Thread Ihar Hrachyshka
The daemon will now log to scapy.log file. Log messages include stats on request processing time as well as any errors that may happen during processing. If you'd like to see even more logs (e.g. for debugging purposes), just pass --verbose to scapy-server. Signed-off-by: Ihar Hrachyshka ---

[ovs-dev] [PATCH ovn v2 2/4] fmt_pkt: use -S check to wait for scapy sock file

2023-11-28 Thread Ihar Hrachyshka
While either check works, it's better to use a more explicit check. Signed-off-by: Ihar Hrachyshka Acked-by: Mark Michelson --- tests/ovn-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at index 3191bb6ad..0b15bcc80 100644

Re: [ovs-dev] [PATCH ovn v2 00/18] northd lflow incremental processing

2023-11-28 Thread Dumitru Ceara
On 11/24/23 16:41, Numan Siddique wrote: > On Fri, Nov 24, 2023 at 10:38 AM Dumitru Ceara wrote: >> >> On 11/16/23 22:05, Numan Siddique wrote: >>> On Thu, Nov 16, 2023 at 2:54 PM Han Zhou wrote: On Wed, Nov 15, 2023 at 7:32 PM Numan Siddique wrote: > > On Wed, Nov 15, 2023 at

Re: [ovs-dev] Next OVN technical community meeting

2023-11-28 Thread Dumitru Ceara
On 11/26/23 18:59, Dumitru Ceara wrote: > On 10/24/23 09:34, Dumitru Ceara wrote: >> On 10/23/23 11:58, Dumitru Ceara wrote: In the meantime, as discussed, I sent out an invite to the people in this thread but I'm also sharing it here for anyone from the community to join if they

Re: [ovs-dev] [PATCH branch-2.17] dpdk: Use DPDK 21.11.5 release for OVS 2.17.

2023-11-28 Thread Kevin Traynor
On 27/11/2023 11:34, Ilya Maximets wrote: On 11/24/23 11:32, David Marchand wrote: On Thu, Nov 23, 2023 at 12:50 PM Kevin Traynor wrote: Update the CI and docs to use DPDK 21.11.5. Signed-off-by: Kevin Traynor --- .ci/linux-build.sh | 2 +-

[ovs-dev] [PATCH v2 branch-3.2] dpdk: Use DPDK 22.11.3 release for OVS 3.2.

2023-11-28 Thread Kevin Traynor
Update the CI and docs to use DPDK 22.11.3. Signed-off-by: Kevin Traynor Acked-by: Simon Horman Reviewed-by: David Marchand --- .github/workflows/build-and-test.yml | 2 +- Documentation/faq/releases.rst | 8 Documentation/intro/install/dpdk.rst | 8 NEWS

[ovs-dev] [PATCH v2 branch-3.1] dpdk: Use DPDK 22.11.3 release for OVS 3.1.

2023-11-28 Thread Kevin Traynor
Update the CI and docs to use DPDK 22.11.3. Signed-off-by: Kevin Traynor Acked-by: Simon Horman Reviewed-by: David Marchand --- .github/workflows/build-and-test.yml | 2 +- Documentation/faq/releases.rst | 6 +++--- Documentation/intro/install/dpdk.rst | 8 NEWS

[ovs-dev] [PATCH v2 branch-3.0] dpdk: Use DPDK 21.11.5 release for OVS 3.0.

2023-11-28 Thread Kevin Traynor
Update the CI and docs to use DPDK 21.11.5. Signed-off-by: Kevin Traynor Acked-by: Simon Horman Reviewed-by: David Marchand --- .ci/linux-build.sh | 2 +- Documentation/faq/releases.rst | 4 ++-- Documentation/intro/install/dpdk.rst | 8 NEWS

[ovs-dev] [PATCH v2 branch-2.17] dpdk: Use DPDK 21.11.5 release for OVS 2.17.

2023-11-28 Thread Kevin Traynor
Update the CI and docs to use DPDK 21.11.5. Signed-off-by: Kevin Traynor Acked-by: Simon Horman Reviewed-by: David Marchand --- .ci/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst | 8 NEWS

Re: [ovs-dev] [PATCH v6 6/6] tests: Do not use zone 0 for CT limit system test.

2023-11-28 Thread Ilya Maximets
On 11/2/23 13:00, Ales Musil wrote: > The zone 0 is default system zone, do not use this > zone for the test because it might contain some > entries already which could cause flakiness during > the check. > > In order to still have the zone 0 parsing coverage > add simple unit tests for dpctl. >

Re: [ovs-dev] [PATCH v6 5/6] ct-dpif: Enforce CT zone limit protection.

2023-11-28 Thread Ilya Maximets
On 11/2/23 13:00, Ales Musil wrote: > Make sure that if any zone limit was set via DB > all zones are forced to be set there also. This > is done by tracking which datapath has zone limit > protection and it is reflected in the dpctl command. > > If the datapath is protected the dpctl command

Re: [ovs-dev] [PATCH v6 3/6] ovs-vsctl: Add limit to CT zone.

2023-11-28 Thread Ilya Maximets
On 11/2/23 13:00, Ales Musil wrote: > Add limit to the CT zone DB table with ovs-vsctl > helper methods. The limit has two special values > besides any number, 0 is unlimited and empty limit > is to leave the value untouched in the datapath. > > This is preparation step and the value is not yet >

Re: [ovs-dev] [PATCH v6 2/6] dpctl: Allow the default CT zone limit to de deleted.

2023-11-28 Thread Ilya Maximets
On 11/2/23 13:00, Ales Musil wrote: > Add optional argument to dpctl ct-del-limits called > "default", which allows to remove the default limit > making it effectively system default. > > Signed-off-by: Ales Musil > --- > v6: Rebase on top of current master. > Address comments from Ilya: >

Re: [ovs-dev] [PATCH v6 1/6] ct-dpif: Handle default zone limit the same way as other limits.

2023-11-28 Thread Ilya Maximets
On 11/2/23 13:00, Ales Musil wrote: > Internally handle default CT zone limit as other limits that > can be passed via the list with special value -1. Currently, > the -1 is treated by both datapaths as default, add static > asserts to make sure that this remains the case in the future. > This

[ovs-dev] 答复: [PATCH v8] userspace: Support vxlan and geneve tso.

2023-11-28 Thread Dexia Li via dev
On Fri, Nov 3, 2023 at 12:01 AM Dexia Li via dev wrote: > > For userspace datapath, this patch provides vxlan and geneve tunnel tso. > Only support userspace vxlan or geneve tunnel, meanwhile support > tunnel outter and inner csum offload. If netdev do not support offload > features,

Re: [ovs-dev] [PATCH v2 7/9] ci: Allow make check-dpdk to run more tests.

2023-11-28 Thread Ilya Maximets
On 11/28/23 08:49, Eelco Chaudron wrote: > > > On 27 Nov 2023, at 19:14, Ilya Maximets wrote: > >> On 11/27/23 13:40, Eelco Chaudron wrote: >>> Install additional packages and drivers required by >>> make check-dpdk. >>> >>> Signed-off-by: Eelco Chaudron >>> --- >>> .ci/dpdk-build.sh

Re: [ovs-dev] [PATCH v2 3/9] ci: Add make check-offloads to GitHub actions ci.

2023-11-28 Thread Ilya Maximets
On 11/28/23 08:43, Eelco Chaudron wrote: > > > On 27 Nov 2023, at 19:04, Ilya Maximets wrote: > >> On 11/27/23 13:39, Eelco Chaudron wrote: >>> This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip >>> tests that won't execute successfully through GitHub actions. >>> We could not use the

Re: [ovs-dev] [PATCH v2 1/9] ci: Add make check-ovsdb-cluster tests to GitHub action ci.

2023-11-28 Thread Ilya Maximets
On 11/28/23 08:39, Eelco Chaudron wrote: > > > On 27 Nov 2023, at 18:58, Ilya Maximets wrote: > >> On 11/27/23 13:38, Eelco Chaudron wrote: >>> Signed-off-by: Eelco Chaudron >>> --- >>> .ci/linux-build.sh |9 + >>> .github/workflows/build-and-test.yml |3 +++

[ovs-dev] [PATCH ovn] ovn: add geneve PMTUD support

2023-11-28 Thread Lorenzo Bianconi
Introduce specif flows for E/W ICMPv{4,6} packets if tunnelled packets do not fit path MTU. This patch enable PMTUD for East/West Geneve traffic. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2241711 Tested-by: Jaime Ruiz Signed-off-by: Lorenzo Bianconi --- NEWS|

Re: [ovs-dev] [PATCH v5] system-dpdk: Test with mlx5 devices.

2023-11-28 Thread David Marchand
On Wed, Nov 22, 2023 at 5:34 PM David Marchand wrote: > > The DPDK unit test only runs if vfio or igb_uio kernel modules are loaded: > on systems with only mlx5, this test is always skipped. > > Besides, the test tries to grab the first device listed by dpdk-devbind.py, > regardless of the PCI

Re: [ovs-dev] [PATCH v2 6/9] ci: Fix dpdk build cache key generation.

2023-11-28 Thread Eelco Chaudron
On 28 Nov 2023, at 9:06, David Marchand wrote: > On Mon, Nov 27, 2023 at 3:26 PM Eelco Chaudron wrote: >> On 27 Nov 2023, at 13:53, David Marchand wrote: >>> On Mon, Nov 27, 2023 at 1:39 PM Eelco Chaudron wrote: When new drivers are introduced, the cache key is not accurately

Re: [ovs-dev] [PATCH v2 6/9] ci: Fix dpdk build cache key generation.

2023-11-28 Thread David Marchand
On Mon, Nov 27, 2023 at 3:26 PM Eelco Chaudron wrote: > On 27 Nov 2023, at 13:53, David Marchand wrote: > > On Mon, Nov 27, 2023 at 1:39 PM Eelco Chaudron wrote: > >> > >> When new drivers are introduced, the cache key is not accurately computed. > >> Previously, the dpdk build process was