On 11/22/23 11:16, Simon Horman wrote:
> On Tue, Nov 21, 2023 at 02:26:52PM -0500, Mike Pattrick wrote:
>> From: Flavio Leitner
>>
>> This provides a software implementation in the case
>> the egress netdev doesn't support segmentation in hardware.
>>
>> The challenge here is to guarantee packet
On 11/30/23 08:31, Ales Musil wrote:
> CT flush extension would silently ignore unknown properties,
> which could lead to potential surprise by deleting more than
> it was requested to. Return error on unknown property instead
> to avoid this problem and at the same time inform the user
> that the
On 11/20/23 11:42, Vladislav Odintsov wrote:
> Hi Ilya,
>
>> On 15 Nov 2023, at 21:51, Ilya Maximets wrote:
>>
>> On 11/15/23 14:13, Vladislav Odintsov wrote:
>>> Hi Ilya,
>>>
On 13 Nov 2023, at 22:25, Ilya Maximets wrote:
On 11/13/23 13:13, Eelco Chaudron wrote:
>
>
There is no TCA_TUNNEL_KEY_ENC_SRC_PORT in the kernel, so the offload
should not be attempted if OVS_TUNNEL_KEY_ATTR_TP_SRC is requested
by OVS. Current code just ignores the attribute in the tunnel(set())
action leading to a flow mismatch and potential incorrect datapath
behavior:
If a packet is received from a UDP tunnel, it has a source port
populated in the tunnel metadata. This field cannot be read or
changed with OpenFlow or the tunnel configuration. However, while
sending this packet to a different tunnel, the value remains in
the metadata and is being sent to the
Graph view leverages the tree format (specially the tree-based
filtering) and uses graphviz library to build a visual graph of the
datapath in graphviz format.
Conntrack zones are shown in random colors to help visualize connection
tracking interdependencies.
An html flag builds an HTML page
On 12/1/23 18:49, Adrian Moreno wrote:
> this series contains some miscelaneous fixes in the flow parsing
> library.
>
> Adrian Moreno (7):
> python: Do not compare types, use 'insinstance'.
> python: ovs: flow: Fix typo in n_packets.
> python: ovs: flow: Add sample to nested actions.
>
Using the existing FlowTree and HTMLFormatter, create an HTML tree
visualization that also supports collapsing and expanding entire flow
trees and subtrees.
Signed-off-by: Adrian Moreno
---
python/automake.mk | 1 +
python/ovs/flowviz/odp/cli.py | 10 ++
This view is interesting for debugging the logical pipeline. It arranges
the flows in "logical" groups (not to be confused with OVN's
Logical_Flows). A logical group of flows is a set of flows that:
- Have the same table number and priority
- Match on the same fields (regardless of the value they
It has two basic styles defined: "dark" and "light" intended for
dark and light terminals.
Signed-off-by: Adrian Moreno
---
python/automake.mk | 5 +-
python/ovs/flowviz/ovs-flowviz.conf | 94 +
2 files changed, 98 insertions(+), 1 deletion(-)
When anaylizing OVN issues, it might be useful to see what OpenFlow
flows were generated from each logical flow. In order to make it simpler
to visualize this, add a cookie format that simply sorts the flows first
by cookie, then by table.
Signed-off-by: Adrian Moreno
---
Add a new python package (just the scheleton for now) to hold a flow
visualization tool based on the flow parsing library.
Signed-off-by: Adrian Moreno
---
python/automake.mk | 12 +++--
python/ovs/flowviz/__init__.py | 0
python/ovs/flowviz/main.py | 41
process.py contains a useful base class that processes files
odp.py and ofp.py: contain datapath and openflow subcommand definitions
as well as the first formatting option: json.
Also, this patch adds basic filtering support.
Examples:
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow json
$
Add a flow formatting framework and one implementation for console
printing using rich.
The flow formatting framework is a simple set of classes that can be
used to write different flow formatting implementations. It supports
styles to be described by any class, highlighting and config-file based
Datapath flows can be arranged into a "tree"-like structure based on
recirculation ids, e.g:
recirc(0),eth(...),ipv4(...) actions=ct,recirc(0x42)
\-> recirc(42),ct_state(0/0),eth(...),ipv4(...) actions=1
\-> recirc(42),ct_state(1/0),eth(...),ipv4(...) actions=userspace(...)
This patch
Add a HTML Formatter and use it to print OpenFlow flows in an HTML list
with table links.
Signed-off-by: Adrian Moreno
---
python/automake.mk | 3 +-
python/ovs/flowviz/html_format.py | 136
python/ovs/flowviz/ofp/cli.py | 10 ++
This series introduces a python utility called ovs-flowviz.
The goal of this utility is to read both datapath and Openflow flows
(using the flow library already available) and print them in different
formats and styles to make it easier to understand them and troubleshoot
issues.
The formats are
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error,
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the
Add missing option to controller action.
Signed-off-by: Adrian Moreno
---
python/ovs/flow/ofp_act.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/python/ovs/flow/ofp_act.py b/python/ovs/flow/ofp_act.py
index c540443ea..2c85076a3 100644
--- a/python/ovs/flow/ofp_act.py
+++
In general, most actions must be lists since the keys can be repeated.
Signed-off-by: Adrian Moreno
---
python/ovs/flow/odp.py | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/python/ovs/flow/odp.py b/python/ovs/flow/odp.py
index 46697a1bc..7d9b165d4 100644
---
Add missing key.
Signed-off-by: Adrian Moreno
---
python/ovs/flow/ofp.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/python/ovs/flow/ofp.py b/python/ovs/flow/ofp.py
index f1a720d75..3d3226c91 100644
--- a/python/ovs/flow/ofp.py
+++ b/python/ovs/flow/ofp.py
@@ -176,6 +176,7 @@ class
Add missing actions.
Signed-off-by: Adrian Moreno
---
python/ovs/flow/odp.py | 9 +
1 file changed, 9 insertions(+)
diff --git a/python/ovs/flow/odp.py b/python/ovs/flow/odp.py
index ef7e5d6b8..46697a1bc 100644
--- a/python/ovs/flow/odp.py
+++ b/python/ovs/flow/odp.py
@@ -204,6 +204,7
Add the sample action to those that can be called in nested actions
(such as clone).
Signed-off-by: Adrian Moreno
---
python/ovs/flow/odp.py | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/python/ovs/flow/odp.py b/python/ovs/flow/odp.py
index
Recent versions of pycodestyle (used by flake8) flag these type
comparisons accoding to flake rule E721 [1].
Comply with rule by replacing type comparisons with 'isinstance()'.
https://www.flake8rules.com/rules/E721.html
Signed-off-by: Adrian Moreno
---
python/ovs/jsonrpc.py | 2 +-
They key used in flows is "n_packets".
Signed-off-by: Adrian Moreno
---
python/ovs/flow/ofp.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/ovs/flow/ofp.py b/python/ovs/flow/ofp.py
index 20231fd9f..f1a720d75 100644
--- a/python/ovs/flow/ofp.py
+++
this series contains some miscelaneous fixes in the flow parsing
library.
Adrian Moreno (7):
python: Do not compare types, use 'insinstance'.
python: ovs: flow: Fix typo in n_packets.
python: ovs: flow: Add sample to nested actions.
python: ovs: flow: Add dp hash and meter actions.
Hi Dumitru
Thanks for the detailed review.
All comments make sense to me.
Thanks
Xavier
On Thu, Nov 30, 2023 at 9:13 PM Dumitru Ceara wrote:
> On 11/30/23 17:53, Xavier Simonart wrote:
> > The group_table and meter_table are initialized in ovn-controller, with
> n_ids = 0.
> > Then they are
On Tue, Nov 28, 2023 at 9:40 AM David Marchand
wrote:
>
> On Wed, Nov 22, 2023 at 5:34 PM David Marchand
> wrote:
> >
> > The DPDK unit test only runs if vfio or igb_uio kernel modules are loaded:
> > on systems with only mlx5, this test is always skipped.
> >
> > Besides, the test tries to grab
Because a DPDK backed netdev configuration is done in an asynchronous way,
and a MTU change requires a reconfiguration, directly checking
ovs-vswitchd logs or querying ovsdb for the interface current MTU value
is racy.
Add synchronisation points on the interface MTU value in ovsdb as it
ensures
On Thu, Nov 30, 2023 at 03:18:22PM +0100, Eelco Chaudron wrote:
> This patch moves the SCTP test from the kernel only, to the general OVN
> system tests, enabling its execution in both the system-userspace and
> system-dpdk test scenarios.
>
> Signed-off-by: Eelco Chaudron
Acked-by: Simon
On Thu, Nov 30, 2023 at 03:18:03PM +0100, Eelco Chaudron wrote:
> The userspace lacks the supplementary protocol state machine for SCTP,
> resulting in the absence of 'protoinfo' fields. Nevertheless, this SCTP
> test doesn't need this feature, making the check for it unnecessary.
>
>
On 11/29/23 19:16, Eelco Chaudron wrote:
>
>
> On 29 Nov 2023, at 17:42, Ilya Maximets wrote:
>
>> FreeBSD 12 is going EOL in December [1] and will likley become
>
> nit: likely
>
>> unavailable shortly after. FreeBSD 14 was released recently,
>> so replacing the old with the new.
>>
>> [1]
On 12/1/23 15:14, David Marchand wrote:
> Because a DPDK backed netdev configuration is done in an asynchronous way,
> and a MTU change requires a reconfiguration, directly checking
> ovs-vswitchd logs or querying ovsdb for the interface current MTU value
> is racy.
>
> $
Bleep bloop. Greetings David Marchand, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: patch fragment without header at line 4: @@ -1,2 +1,2 @@
error: could not build fake
Because a DPDK backed netdev configuration is done in an asynchronous way,
and a MTU change requires a reconfiguration, directly checking
ovs-vswitchd logs or querying ovsdb for the interface current MTU value
is racy.
$ DPDK_DIR=/root/ovs/dpdk-dir/v22.11 make -C build check-dpdk \
On 11/30/23 22:34, Alin Serdean wrote:
> Thank you for fixing this!
>
> Acked-by: Alin Gabriel Serdean
>
>
>> On 30 Nov 2023, at 22:12, Ilya Maximets wrote:
>>
>> It may take a few days for AppVeyor to fix their broken
>> images [1], use the 'Previous' version of the image for now
>> to
Viacheslav Galaktionov writes:
> On 11/27/23 19:33, Aaron Conole wrote:
>> Viacheslav Galaktionov writes:
>>
>>> On 11/22/23 16:14, Aaron Conole wrote:
> Viacheslav Galaktionov writes:
>
> When a packet hits a flow rule without an explicitly specified helper,
> OvS has to rely
On 8 Nov 2023, at 11:07, Felix Huettner via dev wrote:
> this exposes the old constants regarding min backoff, max backoff and
This
> probe interval using environment variables. In case previously users
> wanted to tune the probe interval for all connections this required
> setting this
On 30 Nov 2023, at 16:38, Mohammad Heib wrote:
> Expose the mcast group protocol via the mdb/show
> command output.
Thanks for adding this additional patch to help debugging.
I have some comments regarding the output format, see below.
Cheers.
Eelco
> Signed-off-by: Mohammad Heib
> ---
>
On 30 Nov 2023, at 16:38, Mohammad Heib wrote:
> Store igmp/mld protocol version into the
> mcast_group internally, the multicast snooping feature
> is used by many OVS consumers and those consumers heavily rely
> on the OVS implementation to manage/deal with mcast groups,
> some of those
46 matches
Mail list logo
