Re: [ovs-dev] [PATCH v1] nedev-dpdk: Fix config with dpdk net_bonding offloads.

2024-04-12 Thread Jun Wang
>On 4/12/24 08:29, Jun Wang wrote: >> If it's a DPDK net_bonding, it may cause >> offload-related configurations to take effect, >> leading to offload failure. >> >> /usr/share/openvswitch/scripts/ovs-ctl restart --no-ovs-vswitchd \ >> --system-id=test >> ovs-vsctl --no-wait set open . external-ids

Re: [ovs-dev] [PATCH v9 6/6] ofproto: Add JSON output for 'dpif/show' command.

2024-04-12 Thread Ilya Maximets
On 4/12/24 09:26, jm...@redhat.com wrote: > From: Jakob Meng > > The 'dpif/show' command now supports machine-readable JSON output in > addition to the plain-text output for humans. An example would be: > > ovs-appctl --format json dpif/show > > Reported-at: https://bugzilla.redhat.com/182486

Re: [ovs-dev] [ovs-build] |fail| pw1922880 [ovs-dev, v9, 1/6] Add global option for JSON output to ovs-appctl.

2024-04-12 Thread Ilya Maximets
On 4/12/24 16:19, Phelan, Michael wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Friday, April 12, 2024 12:46 PM >> To: Phelan, Michael >> Cc: i.maxim...@ovn.org; Jakob Meng ; Aaron Conole >> ; Stokes, Ian ; ovs-dev > d...@openvswitch.org> >> Subject: Re: [ovs-build] |fail|

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-04-12 Thread Eelco Chaudron
On 12 Apr 2024, at 9:31, LIU Yulong wrote: > Unfortunately, removed that "ovsrcu_quiesce();" the ovs-vswitchd > still went core: > root root 957M Apr 12 01:35 core.52305 > > But good news is with such change the core dump does not occur so frequently, > it's about 7 days. > > Core trace back: >

Re: [ovs-dev] [PATCH v1] nedev-dpdk: Fix config with dpdk net_bonding offloads.

2024-04-12 Thread Ilya Maximets
On 4/12/24 08:29, Jun Wang wrote: > If it's a DPDK net_bonding, it may cause > offload-related configurations to take effect, > leading to offload failure. > > /usr/share/openvswitch/scripts/ovs-ctl restart --no-ovs-vswitchd \ > --system-id=test > ovs-vsctl --no-wait set open . external-ids:ovn-br

Re: [ovs-dev] [PATCH ovn v2 1/3] northd: Introduce ECMP_Nexthop table in SB db.

2024-04-12 Thread Dumitru Ceara
On 3/12/24 16:59, Lorenzo Bianconi wrote: > Introduce ECMP_Nexthop table in the SB db in order to track active > ecmp-symmetric-reply connections and flush stale ones. > > Signed-off-by: Lorenzo Bianconi > --- Hi Lorenzo, > northd/en-northd.c | 4 +++ > northd/inc-proc-northd.c | 8 +++

[ovs-dev] [PATCH ovn v2] controller: Track individual address set constants.

2024-04-12 Thread Ales Musil
Instead of tracking address set per struct expr_constant_set track it per individual struct expr_constant. This allows more fine grained control for I-P processing of address sets in controller. It helps with scenarios like matching on two address sets in one expression e.g. "ip4.src == {$as1, $as2

Re: [ovs-dev] [PATCH ovn] controller: Track individual address set constants.

2024-04-12 Thread Dumitru Ceara
On 3/27/24 08:45, Ales Musil wrote: > On Wed, Mar 27, 2024 at 7:14 AM Han Zhou wrote: > >> >> >> On Tue, Mar 19, 2024 at 9:45 AM Ales Musil wrote: >>> >>> >>> >>> On Tue, Mar 19, 2024 at 5:43 PM Ales Musil wrote: Instead of tracking address set per struct expr_constant_set track it >>

Re: [ovs-dev] [PATCH ovn] Start mcast id allocations from OVN_MIN_IP_MULTICAST.

2024-04-12 Thread Ihar Hrachyshka
On Fri, Apr 12, 2024 at 10:33 AM Dumitru Ceara wrote: > On 4/11/24 10:32, Ales Musil wrote: > > On Thu, Apr 4, 2024 at 11:44 PM Ihar Hrachyshka > wrote: > > > >> Strictly speaking, this is not *essential* to start from MIN and not > >> MIN+1 (once the hint reaches max, it will wrap back to MIN a

Re: [ovs-dev] [PATCH ovn] ovn-trace: Make sure we don't exit when the port is not specified.

2024-04-12 Thread Dumitru Ceara
On 4/9/24 14:36, Ales Musil wrote: > It might happen that the microflow doesn't have port specified or > the port is part of different datapath. In that case ovn-trace would > print warning and move to later crash on assert. Exit early instead > of crashing on assert. > > Signed-off-by: Ales Musil

Re: [ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

2024-04-12 Thread Dumitru Ceara
On 4/11/24 10:30, Ales Musil wrote: > On Mon, Apr 8, 2024 at 1:06 PM Ilya Maximets wrote: > >> Remaining bits from the OVS/OVN split. >> >> Fixes: 1af37d11be73 ("Remove XenServer Code") >> Signed-off-by: Ilya Maximets >> --- >> Documentation/tutorials/index.rst | 6 -- >> README.rst

Re: [ovs-dev] [PATCH ovn] northd: Fix BFD for policy routing.

2024-04-12 Thread Dumitru Ceara
On 4/9/24 20:42, Mark Michelson wrote: > Hi Lorenzo, > > This looks good to me. Thanks for fixing this! > > Acked-by: Mark Michelson > Thanks, Lorenzo and Mark! Applied to main and backported to 24.03. Regards, Dumitru ___ dev mailing list d...@op

Re: [ovs-dev] [PATCH ovn] Start mcast id allocations from OVN_MIN_IP_MULTICAST.

2024-04-12 Thread Dumitru Ceara
On 4/11/24 10:32, Ales Musil wrote: > On Thu, Apr 4, 2024 at 11:44 PM Ihar Hrachyshka wrote: > >> Strictly speaking, this is not *essential* to start from MIN and not >> MIN+1 (once the hint reaches max, it will wrap back to MIN anyway), but >> this is inconsistent with how we handle datapath and

Re: [ovs-dev] [PATCH ovn] actions: Remove ct_commit_v1.

2024-04-12 Thread Dumitru Ceara
On 4/9/24 14:38, Martin Kalcok wrote: > LGTM, thanks for helping with this clean-up. > > On Wed, Apr 3, 2024 at 7:43 AM Ales Musil wrote: > >> >> >> On Tue, Apr 2, 2024 at 5:31 PM Dumitru Ceara wrote: >> >>> It's not used by any logical flow since v20.12.0. It was kept for >>> backwards compat

Re: [ovs-dev] [PATCH ovn] tests: Add macro for checking flows after recompute.

2024-04-12 Thread Dumitru Ceara
On 4/5/24 11:55, Xavier Simonart wrote: > Hi Mark > > Thanks for the review. > > On Thu, Apr 4, 2024 at 10:25 PM Mark Michelson wrote: > >> Hi Xavier, the patch looks good, but I have one question down below. >> >> On 3/26/24 07:56, Xavier Simonart wrote: >>> The macro CHECK_FLOWS_AFTER_RECOMPU

Re: [ovs-dev] [ovs-build] |fail| pw1922880 [ovs-dev, v9, 1/6] Add global option for JSON output to ovs-appctl.

2024-04-12 Thread Phelan, Michael
> -Original Message- > From: Ilya Maximets > Sent: Friday, April 12, 2024 12:46 PM > To: Phelan, Michael > Cc: i.maxim...@ovn.org; Jakob Meng ; Aaron Conole > ; Stokes, Ian ; ovs-dev d...@openvswitch.org> > Subject: Re: [ovs-build] |fail| pw1922880 [ovs-dev, v9, 1/6] Add global > option

Re: [ovs-dev] [PATCH v2] docs: Document manual cluster recovery procedure.

2024-04-12 Thread Ilya Maximets
On 4/12/24 15:12, Ihar Hrachyshka wrote: > Remove the notion of cluster/leave --force since it was never > implemented. Instead of these instructions, document how a broken > cluster can be re-initialized with the old database contents. > > Signed-off-by: Ihar Hrachyshka Hi, Ihar. Thanks for cl

[ovs-dev] [PATCH v2] docs: Document manual cluster recovery procedure.

2024-04-12 Thread Ihar Hrachyshka
Remove the notion of cluster/leave --force since it was never implemented. Instead of these instructions, document how a broken cluster can be re-initialized with the old database contents. Signed-off-by: Ihar Hrachyshka --- v1: initial version. v2: remove --force mentioned in ovsd-server(1).

Re: [ovs-dev] [PATCH v2 ovn] northd: Fix pmtud for non routed traffic.

2024-04-12 Thread Dumitru Ceara
On 4/3/24 12:29, Lorenzo Bianconi wrote: > Similar to what is already implemented for routed e/w traffic, > introduce pmtud support for e/w traffic between two logical switch ports > connected to the same logical switch, but running on two different > hypervisors. > > Acked-by: Mark Michelson > R

Re: [ovs-dev] [PATCH ovn] Add dh-python to debian/control.

2024-04-12 Thread Dumitru Ceara
On 4/11/24 17:28, Igor Zhukov wrote: > I tried to build OVN in a fresh Ubuntu 24.04 Docker container. > > I only installed the Build-Depends. > > I ran: > > $ dpkg-buildpackage -us -uc -ui -b > > And I received the following output: > > dpkg-buildpackage: info: source package ovn > dpkg-buildp

Re: [ovs-dev] [ovs-build] |fail| pw1922880 [ovs-dev, v9, 1/6] Add global option for JSON output to ovs-appctl.

2024-04-12 Thread Ilya Maximets
> Test-Label: intel-ovs-compilation > Test-Status: fail > http://patchwork.ozlabs.org/api/patches/1922880/ > > AVX-512_compilation: failed > DPLCS Test: success > DPIF Test: fail > MFEX Test: fail > Actions Test: fail > Errors in DPCLS test: > None > > Errors in DPIF test: > git-pw patch

Re: [ovs-dev] [RFC ovn] controller: Always populate prefix-length for IPv6 PD.

2024-04-12 Thread Dumitru Ceara
On 3/19/24 10:14, Frode Nordahl wrote: > On Mon, Mar 18, 2024 at 10:12 PM Frode Nordahl wrote: >> Hi Frode, Sorry for taking so long to reply. >> The prefix we obtain is used to fill the ``ipv6_ra_prefixes`` >> option for configuration of instances through SLAAC. >> >> As discussed in RFC 7421

Re: [ovs-dev] [PATCH] appveyor: Fix too wide OpenSSL version regexp.

2024-04-12 Thread Ilya Maximets
On 4/12/24 11:29, Eelco Chaudron wrote: > > > On 12 Apr 2024, at 1:32, Ilya Maximets wrote: > >> Current regexp is not good enough. OpenSSL 3.3.0 is now available >> and unfortunately the regexp is matching both 3.3.0 and 3.0.13. >> >> All the AppVeyor runs are currently failing because of this

Re: [ovs-dev] [PATCH] rhel/systemd: Set ovsdb-server timeout to 5 minutes

2024-04-12 Thread Chris Riches
On 12/04/2024 10:20, Dumitru Ceara wrote: On 4/11/24 19:10, Chris Riches wrote: On 11/04/2024 17:10, Dumitru Ceara wrote: On 4/11/24 15:43, Chris Riches wrote: On 11/04/2024 14:24, Ilya Maximets wrote: On 4/11/24 10:59, Chris Riches wrote: Hi Chris, Ilya,   From what we know so far, the D

Re: [ovs-dev] [PATCH] checkpatch: Allow rST manpages to be added.

2024-04-12 Thread Simon Horman
On Wed, Apr 10, 2024 at 03:45:55PM +0200, Eelco Chaudron wrote: > > > On 9 Apr 2024, at 9:19, Adrian Moreno wrote: > > > The current __check_doc_is_listed() verifies that the new .rst file is > > listed in Documentation/automake.mk with the full path (i.e: > > "{directory}/{filename}"). > > > >

Re: [ovs-dev] [PATCH] docs: Document manual cluster recovery procedure.

2024-04-12 Thread Simon Horman
On Fri, Apr 12, 2024 at 02:31:43AM +, Ihar Hrachyshka wrote: > Remove the notion of cluster/leave --force since it was never > implemented. Instead of these instructions, document how a broken > cluster can be re-initialized with the old database contents. > > Signed-off-by: Ihar Hrachyshka

Re: [ovs-dev] [PATCH] socket: Increase listen backlog to 64 everywhere.

2024-04-12 Thread Simon Horman
On Fri, Apr 12, 2024 at 02:45:17AM +, Ihar Hrachyshka wrote: > Before the patch, the size of the backlog depended on the type of socket > (UNIX vs INET) as well as on the language (C vs Python), specifically: > > - python used backlog size = 10 for all sockets; > - C used 64 for UNIX sockets b

Re: [ovs-dev] [PATCH] appveyor: Fix too wide OpenSSL version regexp.

2024-04-12 Thread Eelco Chaudron
On 12 Apr 2024, at 1:32, Ilya Maximets wrote: > Current regexp is not good enough. OpenSSL 3.3.0 is now available > and unfortunately the regexp is matching both 3.3.0 and 3.0.13. > > All the AppVeyor runs are currently failing because of this. > > Making it more restrictive by matching on the

Re: [ovs-dev] [PATCH] appveyor: Fix too wide OpenSSL version regexp.

2024-04-12 Thread Simon Horman
On Fri, Apr 12, 2024 at 01:32:40AM +0200, Ilya Maximets wrote: > Current regexp is not good enough. OpenSSL 3.3.0 is now available > and unfortunately the regexp is matching both 3.3.0 and 3.0.13. > > All the AppVeyor runs are currently failing because of this. > > Making it more restrictive by

Re: [ovs-dev] [PATCH] rhel/systemd: Set ovsdb-server timeout to 5 minutes

2024-04-12 Thread Dumitru Ceara
On 4/11/24 19:10, Chris Riches wrote: > On 11/04/2024 17:10, Dumitru Ceara wrote: >> On 4/11/24 15:43, Chris Riches wrote: >>> On 11/04/2024 14:24, Ilya Maximets wrote: On 4/11/24 10:59, Chris Riches wrote: >> Hi Chris, Ilya, >> >   From what we know so far, the DB was full of stale >

Re: [ovs-dev] [PATCH v3 12/12] documentation: Document ovs-flowviz.

2024-04-12 Thread Eelco Chaudron
On 9 Apr 2024, at 9:06, Adrian Moreno wrote: > Add a man page for ovs-flowviz as well as a topic page with some more > detailed examples. > > Signed-off-by: Adrian Moreno In addition to Ilya’s comments, find 3 small comments below. The rest looks good. Cheers, Eelco > --- > Documentation/

Re: [ovs-dev] [PATCH v3 03/12] python: ovs: flowviz: Add console formatting.

2024-04-12 Thread Eelco Chaudron
On 9 Apr 2024, at 9:06, Adrian Moreno wrote: > Add a flow formatting framework and one implementation for console > printing using rich. > > The flow formatting framework is a simple set of classes that can be > used to write different flow formatting implementations. It supports > styles to be

Re: [ovs-dev] [PATCH v9 1/6] Add global option for JSON output to ovs-appctl.

2024-04-12 Thread 0-day Robot
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator #58

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-04-12 Thread LIU Yulong
Unfortunately, removed that "ovsrcu_quiesce();" the ovs-vswitchd still went core: root root 957M Apr 12 01:35 core.52305 But good news is with such change the core dump does not occur so frequently, it's about 7 days. Core trace back: #0 0x7ff0cf7ab387 in raise () from /lib64/libc.so.6 #1

[ovs-dev] [PATCH v9 4/6] python: Add option '--pretty' for pretty-printing JSON output.

2024-04-12 Thread jmeng
From: Jakob Meng With the '--pretty' option, appctl.py will now print JSON output in a more readable fashion, i.e. with additional line breaks, spaces and sorted dictionary keys. The pretty-printed output from appctl.py is not strictly the same as with ovs-appctl because of both use different pre

[ovs-dev] [PATCH v9 2/6] python: Add global option for JSON output to Python tools.

2024-04-12 Thread jmeng
From: Jakob Meng This patch introduces support for different output formats to the Python code, as did the previous commit for ovs-xxx tools like 'ovs-appctl --format json dpif/show'. In particular, tests/appctl.py gains a global option '-f,--format' which allows users to request JSON instead of

[ovs-dev] [PATCH v9 5/6] vswitchd: Add JSON output for 'list-commands' command.

2024-04-12 Thread jmeng
From: Jakob Meng The 'list-commands' command now supports machine-readable JSON output in addition to the plain-text output for humans. Reported-at: https://bugzilla.redhat.com/1824861 Signed-off-by: Jakob Meng --- NEWS | 1 + lib/unixctl.c | 46 ++

[ovs-dev] [PATCH v9 3/6] appctl: Add option '--pretty' for pretty-printing JSON output.

2024-04-12 Thread jmeng
From: Jakob Meng With the '--pretty' option, ovs-appctl will now print JSON output in a more readable fashion, i.e. with additional line breaks, spaces and sorted dictionary keys. Signed-off-by: Jakob Meng --- NEWS | 3 +++ lib/unixctl.c | 6 +++--- lib/unixctl.h

[ovs-dev] [PATCH v9 6/6] ofproto: Add JSON output for 'dpif/show' command.

2024-04-12 Thread jmeng
From: Jakob Meng The 'dpif/show' command now supports machine-readable JSON output in addition to the plain-text output for humans. An example would be: ovs-appctl --format json dpif/show Reported-at: https://bugzilla.redhat.com/1824861 Signed-off-by: Jakob Meng --- NEWS |

[ovs-dev] [PATCH v9 1/6] Add global option for JSON output to ovs-appctl.

2024-04-12 Thread jmeng
From: Jakob Meng For monitoring systems such as Prometheus it would be beneficial if OVS would expose statistics in a machine-readable format. This patch introduces support for different output formats to ovs-xxx tools, in particular ovs-appctl. The latter gains a global option '-f,--format' whi

[ovs-dev] [PATCH v9 0/6] Add global option to output JSON from ovs-appctl cmds.

2024-04-12 Thread jmeng
From: Jakob Meng Changes compared to v8 [0]: * Use "unsigned int" for format_flags variable in pretty patch for ovs-appctl. * Fix --pretty option in appctl.py. [0] https://patchwork.ozlabs.org/project/openvswitch/list/?series=402629&archive=both&state=* Jakob Meng (6): Add global option for

Re: [ovs-dev] [PATCH v1] nedev-dpdk: Fix config with dpdk net_bonding offloads.

2024-04-12 Thread junwan...@cestc.cn
>Hello, > >On Fri, Apr 12, 2024 at 8:30 AM Jun Wang wrote: >> >> If it's a DPDK net_bonding, it may cause >> offload-related configurations to take effect, >> leading to offload failure. > >I did not look at the patch for now. >What is the interest of using a net/bonding DPDK port when there is

Re: [ovs-dev] [PATCH v1] nedev-dpdk: Fix config with dpdk net_bonding offloads.

2024-04-12 Thread David Marchand
Hello, On Fri, Apr 12, 2024 at 8:30 AM Jun Wang wrote: > > If it's a DPDK net_bonding, it may cause > offload-related configurations to take effect, > leading to offload failure. I did not look at the patch for now. What is the interest of using a net/bonding DPDK port when there is native supp