[ovs-dev] [PATCH] test windows: appctl - route/add with gateway

This test passes on Windows, change the test accordingly. Signed-off-by: Alin Gabriel Serdean --- tests/ovs-router.at | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/ovs-router.at b/tests/ovs-router.at index 93a730a..4e0abdf 100644 ---

Re: [ovs-dev] [PATCH v1 0/5] datapath-windows: Add support for Ipv4 fragments

Hi, Thanks a lot for the series, it will be a great addition to the Windows datapath! One small nit it does not compile under release because of `ovspool` is defined only in debug mode. I also tried to set up an environment and for some reason the fragments were stalling. I tried icmp and

Re: [ovs-dev] [PATCH] datapath-windows: Add a wrapper to check for external vport

Hi, Thanks for the patch. Is this part of a series or is it a standalone patch? I don't see the added value to add the wrapper just from this patch. Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of

Re: [ovs-dev] [PATCH v2 4/5] datapath-windows: Add support for OVS_KEY_ATTR_UDP set action

Udp checksum should not be updated in the case it was 0. I will add the changes in the next version. Thanks, Alin. > -Original Message- > From: Alin Serdean > Sent: Friday, January 6, 2017 9:34 PM > To: d...@openvswitch.org > Cc: Alin Serdean <aserd...@cloudbasesoluti

[ovs-dev] [PATCH 4/6] datapath-windows: VXLAN Check for flow destination port

Change the UDP destination port(VXLAN header) to check if it was set by the userspace, use it if it was set. If the userspace did not specify a destination port, use the configured vport destination port. Signed-off-by: Alin Gabriel Serdean ---

[ovs-dev] [PATCH 3/6] datapath-windows: Add support for OVS_TUNNEL_KEY_ATTR_TP_DST

Add support for netlink attribute OVS_TUNNEL_KEY_ATTR_TP_DST get/set flow functions. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Flow.c | 8 1 file changed, 8 insertions(+) diff --git a/datapath-windows/ovsext/Flow.c

[ovs-dev] [PATCH 2/6] datapath-windows: Allow tunnel action to modify destination port

'OvsTunnelAttrToIPv4TunnelKey' modifies 'tunkey' with the received netlink attributes(i.e. OVS_TUNNEL_KEY_ATTR_IPV4_DST). Change the order of the value assignment to reflect the values received via userspace. Signed-off-by: Alin Gabriel Serdean ---

[ovs-dev] [PATCH 1/6] datapath-windows: Fix alignment in MapTunAttrToFlowPut

Found by inspection. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index 2e8b42b..749d83a 100644 ---

Re: [ovs-dev] [PATCH v2 5/5] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

Hi Sai, Thanks for the review! Comments inlined. > -Original Message- > From: Sairam Venugopal [mailto:vsai...@vmware.com] > Sent: Tuesday, January 10, 2017 3:40 AM > To: Alin Serdean <aserd...@cloudbasesolutions.com>; > d...@openvswitch.org > Subject: Re:

[ovs-dev] [PATCH v2 5/5] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

This patch adds support for set action with OVS_KEY_ATTR_TCP attribute (change TCP source or destination port). If the source or destination TCP port was changed, update the TCP checksum. A sample flow can look like the following: set(tcp(src=80,dst=443)) Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH v2 2/5] datapath-windows: Add function to get continuous buffer from context

This patch extracts the code that tries to get a continuous IPv4 header buffer from the function 'OvsUpdateIPv4Header' and moves it to a new function 'OvsGetHeaderBySize'. The new function can be used later when trying to change the UDP/TCP/MPLS etc., headers. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH v2 4/5] datapath-windows: Add support for OVS_KEY_ATTR_UDP set action

This patch adds support for set action with OVS_KEY_ATTR_UDP attribute (change UDP source or destination port). If the source or destination UDP port was changed, update the UDP checksum. A sample flow can look like the following: set(udp(src=67,dst=68)) Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH v2 3/5] datapath-windows: Fix typo in OvsUpdateIPv4Header

Found by inspection. Signed-off-by: Alin Gabriel Serdean --- v2: no change --- datapath-windows/ovsext/Actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c index

[ovs-dev] [PATCH 5/5] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

This patch adds support for set action with OVS_KEY_ATTR_TCP attribute (change TCP source or destination port). If the source or destination TCP port was changed, update the TCP checksum. A sample flow can look like the following: set(tcp(src=80,dst=443)) Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 3/5] datapath-windows: Fix typo in OvsUpdateIPv4Header

Found by inspection. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c index a5f8f06..467bfbc

[ovs-dev] [PATCH 4/5] datapath-windows: Add support for OVS_KEY_ATTR_UDP set action

This patch adds support for set action with OVS_KEY_ATTR_UDP attribute (change UDP source or destination port). If the source or destination UDP port was changed, update the UDP checksum. A sample flow can look like the following: set(udp(src=67,dst=68)) Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 2/5] datapath-windows: Add function to get continuous buffer from context

This patch extracts the code that tries to get a continuous IPv4 header buffer from the function 'OvsUpdateIPv4Header' and moves it to a new function 'OvsGetHeaderBySize'. The new function can be used later when trying to change the UDP/TCP/MPLS etc., headers. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 1/5] datapath-windows: OvsUpdateIPv4Header remove unnecessary addition

bufferStart can be used directly to access the data of the net buffer. Add the MDL offset to save unnecessary additions. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Actions.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[ovs-dev] [PATCH 0/5] Add support for actions needed by OVN

and TCP attribute. Some more cleanup and refactoring was done. Alin Serdean (5): datapath-windows: OvsUpdateIPv4Header remove unnecessary addition datapath-windows: Add function to get continuous buffer from context datapath-windows: Fix typo in OvsUpdateIPv4Header datapath-windows: Add

Re: [ovs-dev] [PATCH] Windows tests: Applications abort when using threading (ovs_rwlock_init)

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, January 4, 2017 7:21 PM > To: Alin Serdean <aserd...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] Windows tests: Applications abor

Re: [ovs-dev] Open vSwitch 2.7 release dates and process

Hi, Maybe it is a bit late to bring this to the table, but I was wondering if the series: https://mail.openvswitch.org/pipermail/ovs-dev/2016-December/326916.html would make the cut for 2.7 . The main advantages it allows the native implementation of Neutron ML2 with the existing ovs pypi

Re: [ovs-dev] [PATCH 0/5] Adds python tests support for Windows

Thanks a lot for the series! I don't think I make a good Python reviewer and I encourage any other reviewer to look over it. Implementation looks good and all of the unit tests are working. Adding this series to ovs_lib allows Neutron ML2 native implemention to work under Windows. Thanks for

Re: [ovs-dev] [PATCH 3/5] Python tests: Daemon ported to Windows

Acked-by: Alin Gabriel Serdean Tested-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Balutoiu > Sent: Thursday, December 29,

Re: [ovs-dev] [PATCH 2/5] Python tests: Ported UNIX sockets to Windows

Thanks for the patch! Python isn't my cup of tea but implemetation looks good. Acked-by: Alin Gabriel Serdean Tested-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >

Re: [ovs-dev] [PATCH 1/5] Python tests: Add winutils.py module

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Balutoiu > Sent: Thursday, December 29, 2016 7:41 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu

Re: [ovs-dev] [PATCH 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

Just one question: are the modifications to Xen Server necessarry? Acked-by: Alin Gabriel Serdean Tested-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >

Re: [ovs-dev] [PATCH 5/5] Python tests: Enable python tests on Windows

nstall the latest Python 2.x from python.org and verify that its path is >part of Windows' PATH environment variable. > + We require that you have Python six and pypiwin32 libraries installed. > + The libraries can be installed via pip command: > + > + .. code-block::

Re: [ovs-dev] [PATCH] datapath-windows: WDK 10 IpHelper rename local variables

Please ignore this patch. I forgot to add renaming for `link`. > -Original Message- > From: Alin Serdean > Sent: Thursday, December 29, 2016 2:26 AM > To: d...@openvswitch.org > Cc: Alin Serdean <aserd...@cloudbasesolutions.com> > Subject: [PATCH] datapath-windows

Re: [ovs-dev] [PATCH 2/5] datapath-windows: Add Windows 10 family to solution

Hi Guru, I rebased the patch: http://patchwork.ozlabs.org/patch/709439/ Thanks a lot, Alin. From: Guru Shetty [mailto:g...@ovn.org] Sent: Thursday, December 22, 2016 1:06 AM To: Alin Serdean <aserd...@cloudbasesolutions.com> Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH 2/5] da

[ovs-dev] [PATCH] datapath-windows: WDK 10 IpHelper rename local variables

Compiling under WDK 10 triggers some warnings in IpHelper, which lead to a failing build. The root cause is that local variables `ipAddr` and `link` hide the previous local declaration. This patch just renames the variables. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 2/2 v2] datapath-windows: Conntrack disable type truncation warning

Compiling with the WDK 10 gave the following warning: Warning C4311 'type cast': pointer truncation from 'POVS_CT_ENTRY' to 'UINT32' ovsext (OVSExt\ovsext) Conntrack.c 1139 This patch disables the warning on the file Conntrack.c. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 1/2 v2] datapath-windows: Add Windows 10 family to solution

This patch adds two more compiling targets: - one for Windows 10 release - one for Windows 10 Debug The new targets are flagged properly to use the new Windows 10 kernel mode driver and its toolchain. Signed-off-by: Alin Gabriel Serdean Acked-by: Sairam

Re: [ovs-dev] [PATCH] windows: WSAPoll broken on windows

: Guru Shetty [mailto:g...@ovn.org] Sent: Tuesday, December 20, 2016 7:30 PM To: Alin Serdean <aserd...@cloudbasesolutions.com> Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH] windows: WSAPoll broken on windows On 15 December 2016 at 18:50, Alin Serdean <aserd...@cloudbasesolu

[ovs-dev] [PATCH] Windows tests: Applications abort when using threading (ovs_rwlock_init)

Commit number: 1a15f390afd66efd161db78b86600832214dfb3c https://github.com/openvswitch/ovs/commit/1a15f390afd66efd161db78b86600832214dfb3c switched from `NULL` to `attr`. According to POSIX documentation this is correct, unfortunately on Windows the current implementation of pthreads does not

[ovs-dev] [PATCH 3/3 v8] Windows: document multiple NIC support setup

From: Alin Serdean <aserd...@cloudbasesolutions.com> This patch updates the documentation on how to set up OVS with multiple NICs. Also update the documentation to show users how new internal ports are created Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> Ac

[ovs-dev] [PATCH 2/3 v8] datapath-windows: Add multiple switch internal ports

This patch adds multiple internal ports support to the windows datapath. All tunnels types have been updated to accommodate this new functionality. Signed-off-by: Alin Gabriel Serdean Co-authored-by: Sorin Vinturis

[ovs-dev] [PATCH 1/3 v8] Windows: Add internal switch port per OVS bridge

From: Alin Serdean <aserd...@cloudbasesolutions.com> This patch updates the following commands in the vswitch: ovs-vsctl add-br br-test ovs-vsctl del-br br-test ovs-vsctl add-br br-test: This command will now create an internal port on the MSFT virtual switch using the WMI interfac

Re: [ovs-dev] [PATCH v3 0/4] datapath-windows: Enable support for tracking FTP connections

Thanks for the series! > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Sairam Venugopal > Sent: Saturday, December 17, 2016 12:28 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v3 0/4] datapath-windows:

Re: [ovs-dev] [PATCH v3 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Sairam Venugopal > Sent: Saturday, December 17, 2016 12:28 AM > To: d...@openvswitch.org > Subject:

Re: [ovs-dev] [PATCH 3/3 v6] Windows: document multiple NIC support setup

Finucane > Sent: Tuesday, November 29, 2016 11:40 AM > To: ovs-dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 3/3 v6] Windows: document multiple NIC > support setup > > On Mon, 2016-11-28 at 16:36 +, Alin Serdean wrote: > > This patch updates the documentation on ho

Re: [ovs-dev] [PATCH 1/3 v7] Windows: Add internal switch port per OVS bridge

I hope the following answers your questions. Alin. From: Shashank Ram [mailto:r...@vmware.com] Sent: Thursday, December 15, 2016 10:27 PM To: Alin Serdean <aserd...@cloudbasesolutions.com>; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/3 v7] Windows: Add internal switch port p

Re: [ovs-dev] [PATCH 1/3 v7] Windows: Add internal switch port per OVS bridge

(both windows and linux). Thanks, Alin. From: Shashank Ram [mailto:r...@vmware.com] Sent: Thursday, December 15, 2016 9:46 PM To: Alin Serdean <aserd...@cloudbasesolutions.com>; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/3 v7] Windows: Add internal switch port per OVS bridge H

[ovs-dev] [PATCH 2/3 v7] datapath-windows: Add multiple switch internal ports

This patch adds multiple internal ports support to the windows datapath. All tunnels types have been updated to accommodate this new functionality. Signed-off-by: Alin Gabriel Serdean Co-authored-by: Sorin Vinturis Acked-by:

[ovs-dev] [PATCH 3/3 v7] Windows: document multiple NIC support setup

This patch updates the documentation on how to set up OVS with multiple NICs. Also update the documentation to show users how new internal ports are created Signed-off-by: Alin Gabriel Serdean Acked-by: Paul Boca --- v7: Address

[ovs-dev] [PATCH 1/3 v7] Windows: Add internal switch port per OVS bridge

This patch updates the following commands in the vswitch: ovs-vsctl add-br br-test ovs-vsctl del-br br-test ovs-vsctl add-br br-test: This command will now create an internal port on the MSFT virtual switch using the WMI interface from Msvm_VirtualEthernetSwitchManagementService

[ovs-dev] [PATCH 1/3 v7] Windows: Add internal switch port per OVS bridge

This patch updates the following commands in the vswitch: ovs-vsctl add-br br-test ovs-vsctl del-br br-test ovs-vsctl add-br br-test: This command will now create an internal port on the MSFT virtual switch using the WMI interface from Msvm_VirtualEthernetSwitchManagementService

Re: [ovs-dev] [PATCH v2 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

../ovs-dev-v2-3-4-datapath-windows-Conntrack---Introduce-support-for-tracking-related-connections.patch:564: new blank line at EOF. + warning: 1 line adds whitespace errors. Acked-by: Alin Gabriel Serdean > -Original Message- > From:

Re: [ovs-dev] [PATCH v2 1/4] datapath-windows: Conntrack - Fix OvsGetTcpPayloadLength()

dr; > +char *ipBuf[sizeof(IPHdr)]; > +PNET_BUFFER curNb; > +curNb = NET_BUFFER_LIST_FIRST_NB(nbl); > +UINT32 hdrLen = sizeof(EthHdr); > +NdisAdvanceNetBufferDataStart(curNb, hdrLen, FALSE, NULL); > +ipHdr = NdisGetDataBuffer(curNb, sizeof *ipHdr, (PV

[ovs-dev] [PATCH] datapath-windows: Conntrack move null checks to functions

Add null checks inside OvsConntrackValidateIcmpPacket, OvsConntrackValidateTcpPacket to make the functions self-contained. Signed-off-by: Alin Gabriel Serdean Suggested-by: Yin Lin --- datapath-windows/ovsext/Conntrack-icmp.c | 4

[ovs-dev] [PATCH] datapath-windows: Remove dead code from PacketIO

Assigning value to 'nativeNbls' has no effect outside the function and the variable is not used inside the function. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/PacketIO.c | 1 - 1 file changed, 1 deletion(-) diff --git

[ovs-dev] [PATCH] [RFC] named-pipes-windows: Add pool for pending connections

Current named pipe implementation does not have a queue for pending connections, similar to the *nix ‘listen(fd, 1)’. This patch tries to tackle this drawback by creating a pool of instances. On each connect event we will retry to recreate the instances that were used. Creating a pool of

Re: [ovs-dev] [PATCH 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

Sounds good :). > -Original Message- > From: Sairam Venugopal [mailto:vsai...@vmware.com] > Sent: Tuesday, December 6, 2016 8:53 PM > To: Alin Serdean <aserd...@cloudbasesolutions.com>; > d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 3/4] datapath-window

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

ugopal [mailto:vsai...@vmware.com] > Sent: Tuesday, December 6, 2016 9:08 PM > To: Alin Serdean <aserd...@cloudbasesolutions.com>; > d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable > FTP support > > I feel that these ad

[ovs-dev] [PATCH] windows: Change driver and MSI company name to LF

Until now we used 'Open vSwitch' as the company/organization name. The project is now under The Linux Foundation ownership. This patch updates the MSI and driver attributes to reflect that ownership. Signed-off-by: Alin Gabriel Serdean ---

[ovs-dev] [PATCH 4/4] build-windows: Propagate PACKAGE_VERSION to the MSI

This patch propagates the automake variable PACKAGE_VERSION when building the MSI via msys. Signed-off-by: Alin Gabriel Serdean --- windows/automake.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/windows/automake.mk b/windows/automake.mk

[ovs-dev] [PATCH 2/4] build-windows: Propagate PACKAGE_VERSION to the driver files

This patch propagates the automake value 'PACKAGE_VERSION' to the driver specific information files, overwriting the Visual Studio default value of Version, when building the driver via msys. Signed-off-by: Alin Gabriel Serdean --- Makefile.am | 8 1

[ovs-dev] [PATCH 0/4] Unify the version used by the driver and MSI

' will be used as the version number. Alin Serdean (4): datapath-windows: Force driver version to depend on a variable build-windows: Propagate PACKAGE_VERSION to the driver files msi-windows: Add version variable build-windows: Propagate PACKAGE_VERSION to the MSI Makefile.am

[ovs-dev] [PATCH 1/4] datapath-windows: Force driver version to depend on a variable

The following components use Windows driver information: - System (inf file); used during device installation - Resource file (rc file); used by applications when looking over the driver file(sys) Currently we have the following for the driver version number: - (inf file)

Re: [ovs-dev] [PATCH] datapath-windows: null comparison for icmp and tcp header

the functions mentioned above? Thanks, Alin. > -Original Message- > From: Sairam Venugopal [mailto:vsai...@vmware.com] > Sent: Wednesday, November 30, 2016 8:15 PM > To: Yin Lin <yinli...@gmail.com>; Alin Serdean > <aserd...@cloudbasesolutions.com> > Cc: d...@openvswit

Re: [ovs-dev] [PATCH] datapath-windows: null comparison for icmp and tcp header

Thanks for the tips Joe! It causes a kernel crash under low resources. Thanks, Alin. > -Original Message- > From: Joe Stringer [mailto:j...@ovn.org] > Sent: Tuesday, November 29, 2016 9:35 PM > To: Alin Serdean <aserd...@cloudbasesolutions.com> > Cc: d...@openvswi

Re: [ovs-dev] OVS-Hyper-V-Discovery-Agent Design Document

Sorry for the late reply. We had a few days of bank holiday last week. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, November 29, 2016 2:28 AM > To: Nithin Raju <nit...@vmware.com> > Cc: Yin Lin <yinli...@gmail.com>; d...@op

Re: [ovs-dev] [PATCH 0/4] datapath-windows: Enable support for tracking FTP connections

Thanks a lot for the series. Overall it looks like a good start for the support! Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Sairam Venugopal > Sent: Thursday, December 1, 2016 11:19 PM > To:

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

ctAttr) { > +helper = NlAttrGet(ctAttr); > +if (!memchr(helper, '\0', 16)) { [Alin Serdean] We must be careful here, because the size may differ(i.e. a message could be forged). I think we should add https://github.com/openvswitch/ovs/blob/master/lib/netlink.c#L649 to the wind

Re: [ovs-dev] [PATCH 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

------ > + /* End of FTP response is either ) or \r\n */ [Alin Serdean] Check for \n as well. > +if (*buf == ')' || *buf == '\r') { ---->cut<-- [Alin Serdean] Maybe add define for 227 (Passive mode) and t

Re: [ovs-dev] [PATCH 2/4] datapath-windows: Cleanup Conntrack definitions and introduce related entries

Looks good, but I have a question regarding the includes. Do you need "NetProto.h", ? Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Sairam Venugopal > Sent: Thursday, December 1, 2016 11:19 PM > To:

Re: [ovs-dev] [PATCH 1/4] datapath-windows: Conntrack - Fix OvsGetTcpPayloadLength()

Thanks for the patch. Looks good. I was wondering if we could adapt and reuse OvsParseTcp (https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/PacketParser.c#L178) instead? Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-

[ovs-dev] [PATCH 5/5] datapath-windows: Conntrack disable type truncation warning

Compiling with the WDK 10 gave the following warning: Warning C4311 'type cast': pointer truncation from 'POVS_CT_ENTRY' to 'UINT32' ovsext (OVSExt\ovsext) Conntrack.c 1139 This patch disables the warning on the file Conntrack.c. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 4/5] datapath-windows: Fix function prototypes

There is a mismatch between OvsInitCompletionList and OvsAddPktCompletionList prototypes. Eg: https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/PacketIO.h#L33 https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/PacketIO.c#L54 Found while compiling with

[ovs-dev] [PATCH 3/5] datapath-windows: Remove unused section from driver inf

The new tool chain for Windows 10 driver contains a inf file checker. While compiling it found the following issue: - Common.Params.reg is missing. This patch removes the entry since it is not used, and at the moment we do not add any specific keys to the Windows registry. Signed-off-by: Alin

Re: [ovs-dev] [PATCH 1/2] ovsdb windows: Allow online compacting

> Thanks for testing. > > I applied this to master. [Alin Serdean] Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] datapath-windows: fix return value in conntrack

'status' is of type 'NTSTATUS' and NlFillOvsMsgForNfGenMsg is of type bool. Signed-off-by: Alin Gabriel Serdean Acked-by: Sairam Venugopal --- datapath-windows/ovsext/Conntrack.c | 14 -- 1 file changed, 8 insertions(+), 6

Re: [ovs-dev] [PATCH v2] datapath-windows: Avoid busy wait in OvsStartIpHelper

Hi Shashank, Thanks a lot for the patch! My only concern is that this issue has already been addresed in one of the multiple port patches: http://patchwork.ozlabs.org/patch/669598/ I plan to respin the series until the end of the week. Thanks, Alin. > -Original Message- > From:

Re: [ovs-dev] [PATCH] tests: offline compacting on Windows

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, November 2, 2016 12:37 AM > To: Alin Serdean <aserd...@cloudbasesolutions.com> > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] tests: offline compacting on Windows > &

<    1   2   3   4