Re: [ovs-dev] [PATCH v2] system-dpdk: Tolerate new warnings 23.11.1/24.03.

2024-06-06 Thread Christian Ehrhardt
On Thu, Jun 6, 2024 at 2:25 PM David Marchand wrote: > > On Thu, Jun 6, 2024 at 9:33 AM wrote: > > > > From: Christian Ehrhardt > > > > DPDK fixed counting of telemetry clients in 24.03 [1] which was also > > backported to 23.11.1 [2]. Due to that the dpdk re

[ovs-dev] [PATCH v2] system-dpdk: Tolerate new warnings 23.11.1/24.03.

2024-06-06 Thread christian . ehrhardt
From: Christian Ehrhardt DPDK fixed counting of telemetry clients in 24.03 [1] which was also backported to 23.11.1 [2]. Due to that the dpdk related openvswitch tests now fail in the following cases: 4: OVS-DPDK - ping vhost-user ports FAILED (system-dpdk.at:148) 5: OVS-DPDK - ping vhost

Re: [ovs-dev] [PATCH] system-dpdk: tolerate new warnings 23.11.1/24.03

2024-06-05 Thread Christian Ehrhardt
On Wed, Jun 5, 2024 at 12:44 PM wrote: > > From: Christian Ehrhardt To add some more context which didn't fit the commit message (a.k.a I shamefully forgot to add a cover letter :-/) I've seen the discussion on [1] planning to add support for 23.11.1 And the referred patch set of Da

[ovs-dev] [PATCH] system-dpdk: tolerate new warnings 23.11.1/24.03

2024-06-05 Thread christian . ehrhardt
From: Christian Ehrhardt DPDK fixed counting of telemetry clients in 24.03 [1] which was also backported to 23.11.1 [2]. Due to that the dpdk related openvswitch tests now fail in the following cases: 4: OVS-DPDK - ping vhost-user ports FAILED (system-dpdk.at:148) 5: OVS-DPDK - ping vhost

Re: [ovs-dev] [RFC PATCH v2] dpdk: Update to use v22.11.

2022-12-01 Thread Christian Ehrhardt
et one? > > Alternative solution is to temporarily disable DPDK-enabled build for > deb packages in GHA, until Ubuntu 23.04 is available. > > There is no rush, AFAIK, we have a bit of time before the soft freeze, > but it would be nice to have DPDK 22.11 support merged by the end of a > year. >

Re: [ovs-dev] [PATCH] ovs-ctl: Allow recording hostname separately

2021-02-19 Thread Christian Ehrhardt
t: https://bugs.launchpad.net/bugs/1915829 > Signed-off-by: Frode Nordahl I've looked at this for the Ubuntu problem that started Frodes work, and while I can't give any authoritative Ack I can at least say Reviewed-by: Christian Ehrhardt > --- > utilities/ovs-ctl.in | 12 +

Re: [ovs-dev] Bug#974588: openvswitch: DPDK 20.11 support and transition for bullseye

2021-01-07 Thread Christian Ehrhardt
irst OVS 2.15 to be in time for the Debian Feature Freeze. Ubuntu is in the same situation every spring (overlapping release dates) - so I shared before that this worked well for us in the past - and also this time seems to work well. > As an FYI OVS master now supports DPDK 20.11 as of the follow

Re: [ovs-dev] Bug#974588: openvswitch: DPDK 20.11 support and transition for bullseye

2021-01-07 Thread Christian Ehrhardt
nt commit def6eb1ea and for us it seems to work fine so far. See the package at: https://launchpad.net/ubuntu/+source/openvswitch/2.15.0~git20210104.def6eb1ea-0ubuntu3 With that confirmed and the feature freeze coming soon. Would you mind doing a similar

Re: [ovs-dev] Bug#974588: openvswitch: DPDK 20.11 support and transition for bullseye

2020-11-19 Thread Christian Ehrhardt
... > I proposed an earlier upload from git as a temporary measure to ease > the ABI transition. I worry that an ABI transition 2 months after the > transition freeze is too much to ask, even if it only affects > src:openvswitch (and src:collectd, but that's a straightforward > rebuild, no changes

Re: [ovs-dev] Bug#974588: openvswitch: DPDK 20.11 support and transition for bullseye

2020-11-19 Thread Christian Ehrhardt
> > Also, I would very much like to have OVS and OVN being packaged and > > maintained on both Ubuntu and Debian the same way. I would very much > > like if this could happen, because maintaining OVS is hard, and I really > > feel alone doing it. Your thoughts? > > > > Cheers, > > > > Thomas

Re: [ovs-dev] openvswitch crash on i386

2019-03-05 Thread Christian Ehrhardt
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1736390 [2]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1736390/comments/55 > Reverting that commit from 5.0 makes the problem go away. I'm not able to > reproduce the crash on x86_64. > > ...Juerg > _

Re: [ovs-dev] [PATCH v6 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-12 Thread Christian Ehrhardt
On Tue, Feb 12, 2019 at 11:47 PM Ben Pfaff wrote: > > On Tue, Feb 12, 2019 at 07:29:58AM +0100, Christian Ehrhardt wrote: > > DPDK 18.11 builds using the more modern meson build system no more > > provide the -ldpdk linker script. Instead it is expected to use > > pkgc

[ovs-dev] [PATCH v6 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-11 Thread Christian Ehrhardt
0.29.1. This should be backport-safe as these macro files are all versioned. autoconf is smart enough to check the version if you have it locally, and if the system's is higher, it will use that one instead. Acked-by: Luca Boccassi Acked-by: Aaron Conole Signed-off-by: Christian Ehrhardt Signed

[ovs-dev] [PATCH v6 0/1] fix build with DPDK 18.11 without -ldpdk

2019-02-11 Thread Christian Ehrhardt
to pass the build individually and not as a series they are now squashed to be acceptable Updates from v1: - add updated pkg.m4 to support PKG_CHECK_MODULES_STATIC - include local pkg.m4 in configure.ac Christian Ehrhardt (1): acinclude: Also use LIBS from dpkg pkg-config acinclude.m4 | 22

Re: [ovs-dev] [PATCH v5 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-11 Thread Christian Ehrhardt
On Tue, Feb 12, 2019 at 2:52 AM Ben Pfaff wrote: > > On Mon, Feb 11, 2019 at 08:36:47PM +0100, Christian Ehrhardt wrote: > > DPDK 18.11 builds using the more modern meson build system no more > > provide the -ldpdk linker script. Instead it is expected to use > > pkgc

[ovs-dev] [PATCH v5 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-11 Thread Christian Ehrhardt
0.29.1. This should be backport-safe as these macro files are all versioned. autoconf is smart enough to check the version if you have it locally, and if the system's is higher, it will use that one instead. Acked-by: Luca Boccassi Acked-by: Aaron Conole Signed-off-by: Christian Ehrhardt

[ovs-dev] [PATCH v5 0/1] fix build with DPDK 18.11 without -ldpdk

2019-02-11 Thread Christian Ehrhardt
to be acceptable Updates from v1: - add updated pkg.m4 to support PKG_CHECK_MODULES_STATIC - include local pkg.m4 in configure.ac Christian Ehrhardt (1): acinclude: Also use LIBS from dpkg pkg-config acinclude.m4 | 21 +++-- configure.ac | 1 + m4/pkg.m4| 217

Re: [ovs-dev] [PATCH v4 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-11 Thread Christian Ehrhardt
On Mon, Feb 11, 2019 at 11:06 AM Luca Boccassi wrote: > > On Mon, 2019-02-11 at 07:59 +0100, Christian Ehrhardt wrote: > > On Sun, Feb 10, 2019 at 5:53 PM Ben Pfaff wrote: > > > > > > On Thu, Feb 07, 2019 at 12:46:40PM +0100, Christian Ehrhardt wrote: > >

Re: [ovs-dev] [PATCH v4 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-10 Thread Christian Ehrhardt
On Sun, Feb 10, 2019 at 5:53 PM Ben Pfaff wrote: > > On Thu, Feb 07, 2019 at 12:46:40PM +0100, Christian Ehrhardt wrote: > > DPDK 18.11 builds using the more modern meson build system no more > > provide the -ldpdk linker script. Instead it is expected to use > > pkgc

Re: [ovs-dev] [PATCH v3 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-07 Thread Christian Ehrhardt
On Fri, Feb 8, 2019 at 4:55 AM Ben Pfaff wrote: > > On Thu, Feb 07, 2019 at 12:00:39PM +0100, Christian Ehrhardt wrote: > > [...] > > > > > case "$with_dpdk" in > > >yes) > > > DPDK_AUTO_DISCOVER=&

[ovs-dev] [PATCH v4 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-07 Thread Christian Ehrhardt
the PKG_PROG_PKG_CONFIG macro. Signed-off-by: Christian Ehrhardt --- acinclude.m4 | 21 +++-- configure.ac | 2 + m4/pkg.m4| 217 +-- 3 files changed, 157 insertions(+), 83 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 95241b142..8ada98623 100644

[ovs-dev] [PATCH v4 0/1] fix build with DPDK 18.11 without -ldpdk

2019-02-07 Thread Christian Ehrhardt
structured for reviewability, but to guarantee travis requirements to pass the build individually and not as a series they are now squashed to be acceptable Updates from v1: - add updated pkg.m4 to support PKG_CHECK_MODULES_STATIC - include local pkg.m4 in configure.ac Christian Ehrhardt (1

Re: [ovs-dev] [PATCH v3 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-07 Thread Christian Ehrhardt
[...] > case "$with_dpdk" in >yes) > DPDK_AUTO_DISCOVER="true" > -PKG_CHECK_MODULES([DPDK], [libdpdk], > - [DPDK_INCLUDE="$DPDK_CFLAGS"], > - [DPDK_INCLUDE="-I/usr/local/include/dpdk > -I/usr/include/dpdk"]) > +

[ovs-dev] [PATCH v3 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-04 Thread Christian Ehrhardt
the PKG_PROG_PKG_CONFIG macro. Signed-off-by: Christian Ehrhardt --- acinclude.m4 | 17 ++-- configure.ac | 2 + m4/pkg.m4| 217 +-- 3 files changed, 153 insertions(+), 83 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 95241b142..f82b989e6 100644

[ovs-dev] [PATCH v3 0/1] fix build with DPDK 18.11 without -ldpdk

2019-02-04 Thread Christian Ehrhardt
to be acceptable Updates from v1: - add updated pkg.m4 to support PKG_CHECK_MODULES_STATIC - include local pkg.m4 in configure.ac Christian Ehrhardt (1): acinclude: Also use LIBS from dpkg pkg-config acinclude.m4 | 17 ++-- configure.ac | 2 + m4/pkg.m4| 217

[ovs-dev] [PATCH v2 0/3] fix build with DPDK 18.11 without -ldpdk

2019-01-30 Thread Christian Ehrhardt
/409021278/buildlog_ubuntu-disco-amd64.openvswitch_2.11.0~git20190121.4e4f80ec2-0ubuntu1~ppa5_BUILDING.txt.gz Updates from v1: - add updated pkg.m4 to support PKG_CHECK_MODULES_STATIC - include local pkg.m4 in configure.ac Christian Ehrhardt (3): acinclude: Also use LIBS from dpkg pkg-config m4

[ovs-dev] [PATCH v2 1/3] acinclude: Also use LIBS from dpkg pkg-config

2019-01-30 Thread Christian Ehrhardt
flags around the PMDs skips the further wrapping in more whole-archive if that is already part of DPDK_LIB. Signed-off-by: Christian Ehrhardt --- acinclude.m4 | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index f038fd457..a45411860

[ovs-dev] [PATCH v2 2/3] m4: update pkg.m4 to pkg-config 0.29.1.

2019-01-30 Thread Christian Ehrhardt
-off-by: Christian Ehrhardt --- m4/pkg.m4 | 217 ++ 1 file changed, 139 insertions(+), 78 deletions(-) diff --git a/m4/pkg.m4 b/m4/pkg.m4 index c5b26b52e..82bea96ee 100644 --- a/m4/pkg.m4 +++ b/m4/pkg.m4 @@ -1,29 +1,60 @@ -# pkg.m4 - Macros

[ovs-dev] [PATCH v2 3/3] configure.ac: use the locally provided pkg.m4

2019-01-30 Thread Christian Ehrhardt
Include the locally provided pkg.m4 before calling the PKG_PROG_PKG_CONFIG macro. Signed-off-by: Christian Ehrhardt --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index 505e3d041..dc6eebbf5 100644 --- a/configure.ac +++ b/configure.ac @@ -28,6

Re: [ovs-dev] [PATCH] acinclude: Also use LIBS from dpkg pkg-config

2019-01-28 Thread Christian Ehrhardt
On Fri, Jan 25, 2019 at 5:53 PM Aaron Conole wrote: > > Luca Boccassi writes: > > > On Fri, 2019-01-25 at 16:39 +, Luca Boccassi wrote: > >> On Fri, 2019-01-25 at 11:28 -0500, Aaron Conole wrote: > >> > Christian Ehrhardt writes: > >> > > &

Re: [ovs-dev] [PATCH] acinclude: Also use LIBS from dpkg pkg-config

2019-01-24 Thread Christian Ehrhardt
On Thu, Jan 24, 2019 at 5:38 PM Christian Ehrhardt wrote: > > DPDK 18.11 builds using the more modern meson build system no more > provide the -ldpdk linker script. Instead it is expected to use > pkgconfig for linker options as well. A single patch didn't seem right for a 0/1 into

Re: [ovs-dev] OVS-DPDK public meeting

2018-06-05 Thread Christian Ehrhardt
On Tue, Jun 5, 2018 at 7:04 PM, Aaron Conole wrote: > Hi Christian, > > Christian Ehrhardt writes: > > > On Tue, Jun 5, 2018 at 3:28 PM, Stokes, Ian > wrote: > >> > On Wed, May 30, 2018 at 7:49 PM, Kevin Traynor > >> > wrote: &g

Re: [ovs-dev] OVS-DPDK public meeting

2018-06-05 Thread Christian Ehrhardt
jump from 17.11 to 18.11 in one shot. But if you have to kill support fot 17.11 to let it work with 18.05, then better not. Interested what other opinions on this are. > Thanks > Ian > > > ___ > > dev mailing list > > d...@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] OVS-DPDK public meeting

2018-06-05 Thread Christian Ehrhardt
On Wed, May 30, 2018 at 7:49 PM, Kevin Traynor wrote: > Minutes of meeting Wed 30th May. > > [...] > > - DPDK 18.05 > -- Will be released today/tomorrow > -- Some delays due to a lot of patches and last minute bug fixes > Hi, I wanted to ask if anyone is already looking at DPDK 18.05

Re: [ovs-dev] [ PATCH v2] dpdk: Use DPDK 17.11.2 release.

2018-05-08 Thread Christian Ehrhardt
On Tue, May 8, 2018 at 7:36 PM, Kevin Traynor <ktray...@redhat.com> wrote: > On 05/08/2018 09:19 AM, Christian Ehrhardt wrote: > > > > > > On Thu, May 3, 2018 at 6:22 PM, Stokes, Ian <ian.sto...@intel.com > > <mailto:ian.sto...@intel.com>> wrote:

Re: [ovs-dev] [ PATCH v2] dpdk: Use DPDK 17.11.2 release.

2018-05-08 Thread Christian Ehrhardt
gt; uint64_t iova, uint64_t size, uint8_t perm) { > > > if (!(dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))) > > > return rte_vhost_gpa_to_vva(dev->mem, iova); > > > > > > return __vhost_iova_to_vva(dev, vq, iova, size, perm); } > > > > > > So I fail to see how it could cause any regression. > > > > > > Regards, > > > Maxime > > > > > >> Just wondering if you see similar behavior in testing? > > >> > > >> Regards > > >> Ian > > >> > > >> > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

2018-01-15 Thread Christian Ehrhardt
On Mon, Jan 15, 2018 at 5:43 PM, Eric Garver wrote: > On Mon, Jan 15, 2018 at 11:32:32AM -0500, Eric Garver wrote: >> On Mon, Jan 15, 2018 at 03:17:28PM +, James Page wrote: >> > Hi Eric >> > >> > On Mon, 15 Jan 2018 at 16:54 Eric Garver wrote: >> > >> > > On Sat,

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

2018-01-15 Thread Christian Ehrhardt
> But that does not disable the central check. > And this only relies on the max_mtu values in the device struct gre's own check would be called by dev.c:dev_set_mtu * core check here* -> __dev_set_mtu -> ops->ndo_change_mtu But the check that refuses us is before the call to gre so it

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

2018-01-15 Thread Christian Ehrhardt
>> Looks like the kernel is limiting to 1500. > > I would expect setting with ip-link to fail as well. > What does the below show?: > > $ ip link set dev gre_sys mtu 65535 For your question - we just talked about that and yes on the new kernel that fails as well if set via ip. But those checks

Re: [ovs-dev] [RFC PATCH V2 1/2] netdev-dpdk: DPDK v17.11 upgrade

2017-11-20 Thread Christian Ehrhardt
g until I saw this mail. We discussed the option to handle things depending on the DPDK version built against via config time checks, but then as OVS "defines" a DPDK version that it matches you might not want/need that complexity. That said it implies I review

Re: [ovs-dev] [PATCH v2] acinclude: netdev-dpdk: use pkg-config of libdpdk

2017-08-07 Thread Christian Ehrhardt
On Mon, Aug 7, 2017 at 8:42 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Jul 14, 2017 at 08:36:39AM +0200, Christian Ehrhardt wrote: > > If available use dpdk pkg-config info of libdpdk to set the right > > include paths. > > That for example, allows packagers to

Re: [ovs-dev] [PATCH v2] acinclude: netdev-dpdk: use pkg-config of libdpdk

2017-08-07 Thread Christian Ehrhardt
Ping, any update on including this? On Fri, Jul 14, 2017 at 8:36 AM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > If available use dpdk pkg-config info of libdpdk to set the right > include paths. > That for example, allows packagers to provide non default

[ovs-dev] [PATCH v2] acinclude: netdev-dpdk: use pkg-config of libdpdk

2017-07-14 Thread Christian Ehrhardt
cross-compilation." Signed-off-by: Christian Ehrhardt <christian.ehrha...@canonical.com> Suggested-by: Luca Boccassi <luca.bocca...@gmail.com> Acked-by: Luca Boccassi <luca.bocca...@gmail.com> --- Documentation/intro/install/dpdk.rst | 6 +- acinclude.m4

Re: [ovs-dev] [PATCH] acinclude: netdev-dpdk: use pkg-config of libdpdk

2017-07-11 Thread Christian Ehrhardt
On Tue, Jul 11, 2017 at 5:53 PM, Timothy M. Redaelli wrote: > I like the idea, but I think it's better to wait for upstream (DPDK) to > add pkg-config support before pushing something that actually can only > be used in debian-based distributions (libdpdk-dev package). >

Re: [ovs-dev] [PATCH] acinclude: netdev-dpdk: use pkg-config of libdpdk

2017-07-11 Thread Christian Ehrhardt
Ping - any update on this thread - anybody looked into considering the config change? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] acinclude: netdev-dpdk: use pkg-config of libdpdk

2017-07-05 Thread Christian Ehrhardt
If available use dpdk pkg-config info of libdpdk to set the right include paths. That for example, allows packagers to provide non default include paths in a common way (pkg-config). Signed-off-by: Christian Ehrhardt <christian.ehrha...@canonical.com> Suggested-by: Luca Boccassi <l