strategy:
>
Hi, Eelco. Could you also apply this to branches down to 2.17?
We'll need to keep the image updated there as well since they are
going to be supported likely beyond 20.04 availability in GHA.
Assuming these branches should work fine with 22.04 (I didn't check).
Best rega
consumption.
Users for this data will be added in later commits.
Signed-off-by: Ilya Maximets
---
ovsdb/execution.c| 14 ---
ovsdb/file.c | 22 +++-
ovsdb/ovsdb-server.c | 7 --
ovsdb/table.c| 6 +++--
ovsdb/transaction.c | 60
applied, initial read of OVSDB
file containing 136K small transactions for large OVN port
groups and address sets on my laptop takes 11 seconds vs 24
seconds without.
Signed-off-by: Ilya Maximets
---
lib/ovsdb-data.c| 26 ++
lib/ovsdb-data.h| 1 +
ovsdb/transaction.c
ental reassessment of weak
refs.")
Signed-off-by: Ilya Maximets
---
ovsdb/transaction.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/ovsdb/transaction.c b/ovsdb/transaction.c
index bbe4cddc1..a482588a0 100644
--- a/ovsdb/transaction.c
+++ b/ovsdb/tra
on my laptop takes 24 seconds vs 43 seconds
without.
Fixes: 4dbff9f0a685 ("ovsdb: transaction: Incremental reassessment of weak
refs.")
Fixes: b2712d026eae ("ovsdb: transaction: Use diffs for strong reference
counting.")
Signed-off-by: Ilya Maximets
---
lib/
.
Fixes: 485ac63d10f8 ("ovsdb: Add lazy-copy support for ovsdb_datum objects.")
Signed-off-by: Ilya Maximets
---
ovsdb/row.h | 2 ++
ovsdb/transaction.c | 6 --
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/ovsdb/row.h b/ovsdb/row.h
index 59f498a20..6f5e58
(storage_read from raft module).
For example, with this change applied, initial read of OVSDB file
containing 136K transactions for large OVN port groups and address
sets on my laptop takes 11 seconds vs 43 seconds without.
Ilya Maximets (5):
ovsdb: Fix incorrect sharing of UUID and _version
On 12/16/23 15:23, Frode Nordahl wrote:
> On Fri, Dec 15, 2023 at 11:53 PM Ilya Maximets wrote:
>>
>> On 12/13/23 23:19, Frode Nordahl wrote:
>>> Since the topic of clustered database schema conversion issues was
>>> first brought up [0], there has been several p
log about QinQ offloading.
> https://patchwork.ozlabs.org/project/openvswitch/list/?series=385259=*
>
> Signed-off-by: David Marchand
> ---
Thanks, David! I didn't test this much, but it looks
correct to me:
Acked-by: Ilya Maximets
BTW, Just to not forget, there is one deferred change tha
70 ---
> tests/pmd.at | 350 --
> vswitchd/vswitch.xml | 31 ++-
> 6 files changed, 642 insertions(+), 50 deletions(-)
>
Thanks, Kevin! This version looks good to me and I also can't
reproduce the performance hit from v
On 12/11/23 16:39, Mike Pattrick wrote:
> Test that netdev-dummy is able to send and recieve segment offloaded
> packets.
>
> Signed-off-by: Mike Pattrick
>
> ---
> v2: Fix clang build error: mutex needed to access netdev_dummy members
>
> Signed-off-by: Mike Pattrick
> ---
>
r as offload flags aren't retained.
Hmm. I'm not sure this is the only case. For example, sFlow sampling
embeds packet header bytes into the sFlow header. It should probably
contain correct checksums at this point. There are maybe other cases
similar to this one as well.
Best regards, I
the same terminology (probe_interval), but a different implementation
that is not going to be affected by this change as well.
Is there a scenario that we still need to cover that will not be covered
by the configuration file? If there are some, we could try to come
up with solutions fo
1a86
It's not intended for the python library itself, but for the
application that uses asyncio/eventlet to be able to run housekeeping
of these frameworks while IDL is processing large updates.
What do you think? Does that make any sense?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
we need both steps,
because we need transaction to be populated with the data
from one table before the conversion fails on the second one.
ASAN or valgrind should catch the UAF condition.
What do you think?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
+--
> 13 files changed, 475 insertions(+), 127 deletions(-)
>
Hi, Ales. I updated the NEWS entry and fixed a couple of cosmetic issues.
With that, applied. Thanks!
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
pushes patches one by one.
The only solution I see here is to skip the test under this conditions,
at least it will be visible that it didn't run. Robot, I guess,
can be modified to first create a branch and then start pushing changes,
so the tests will not be skipped for it.
But humans will just have to pay attention to tests being or not being
run, unfortunately. If we used GitLab pipelines we could have worked
around the problem by providing git push options (git push -o my_base=SHA),
but GHA doesn't seem to support that, i.e. push options in GHA are not
accessible. I don't know if those are available in CirrusCI.
Thoughts?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 12/14/23 08:12, Frode Nordahl wrote:
> On Thu, Dec 14, 2023 at 2:04 AM Ilya Maximets wrote:
>>
>> The original problem was summarized on the OVS+OVN Conf'22 last year:
>> https://www.openvswitch.org/support/ovscon2022/#t19
>> Slides:
>> https://www.o
On 12/14/23 12:15, Kevin Traynor wrote:
> On 11/10/2023 20:08, Ilya Maximets wrote:
>> On 9/29/23 14:50, Kevin Traynor wrote:
>>> Extend 'pmd-sleep-max' so that individual PMD thread cores may have
>>> a specified max sleep request value.
>>>
>>> Exis
On 12/14/23 08:15, Frode Nordahl wrote:
> On Thu, Dec 14, 2023 at 2:05 AM Ilya Maximets wrote:
>>
>> Store KSON-RPC options for each remote separately, so it will be
>
> s/KSON/JSON
>
>> possible to have different configurations per remote in the futur
Add more tests specific to --config-file.
Signed-off-by: Ilya Maximets
---
tests/ovsdb-server.at | 640 ++
1 file changed, 640 insertions(+)
diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
index 488dfc36f..7085e72d4 100644
--- a/tests/ovsdb
"sb.db": {
"service-model": "clustered"
},
"OVN_Northbound": {
"service-model": "relay",
"source": {
"ssl:[fe:::1]:6642,ssl:[fe:::2]:6642": {
&
Allow setting all the options for the source connection, not only the
inactivity probe interval.
Signed-off-by: Ilya Maximets
---
lib/ovsdb-cs.c | 10 ++
lib/ovsdb-cs.h | 3 +++
2 files changed, 13 insertions(+)
diff --git a/lib/ovsdb-cs.c b/lib/ovsdb-cs.c
index c7c147cc0..b5eda88ad
Basic relay and active-backup command execution tests extended
to run some copies of ovsdb-server processes with --config-file.
Signed-off-by: Ilya Maximets
---
tests/ovsdb-server.at | 123 +-
1 file changed, 97 insertions(+), 26 deletions(-)
diff --git
Allow setting all the JSON-RPC session options at once.
While at it, allow updating options the same way the source
can be updated while calling 'ovsdb_relay_add_db()' if the
relay is already configured.
Signed-off-by: Ilya Maximets
---
ovsdb/ovsdb-server.c | 2 +-
ovsdb/relay.c| 6
Set all the options for the source connection, not only the
inactivity probe interval.
Signed-off-by: Ilya Maximets
---
ovsdb/ovsdb-server.c | 11 ---
ovsdb/replication.c | 6 +++---
ovsdb/replication.h | 3 ++-
3 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/ovsdb
It's useful to have a way to update all the JSON-RPC session
options all at once and not call 3 separate functions every
time. This may also allow the internals of these options
to be better abstracted, i.e. allow users to not know what
are these options exactly.
Signed-off-by: Ilya Maximets
n't need the
'role' or 'read-only' fields. This allows us to use the same
JSON parsing function for both the remotes ans database sources.
Can be changed in the future, but for now keeping as is to avoid
extra code complication.
Signed-off-by: Ilya Maximets
---
ovsdb/jsonrpc-server.c |
for '--no-dbs'. This
option is rarely used, so it doesn't seem to be worth a separate fix.
Signed-off-by: Ilya Maximets
---
ovsdb/ovsdb-server.c | 110 ++-
1 file changed, 109 insertions(+), 1 deletion(-)
diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb
type while opening the database.
Since the database 'source' connections can't use 'role' or
'read-only' options, a new flag added to corresponding JSON
parsing functions to skip these fields.
Signed-off-by: Ilya Maximets
---
ovsdb/jsonrpc-server.c | 31 +-
ovsdb/jsonrpc-server.h | 5
It is currently not possible for the role to change in runtime
(unless a manual DB transaction is crafted), but it will be with
addition of a config file.
If the role changes, listening socket will be closed, and all
the connections to this remote will be terminated.
Signed-off-by: Ilya Maximets
ion.
Signed-off-by: Ilya Maximets
---
ovsdb/ovsdb-server.c | 74 +++--
ovsdb/replication.c | 676 ---
ovsdb/replication.h | 36 +--
3 files changed, 384 insertions(+), 402 deletions(-)
diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c
index 7e95b3
When database is added to the replication, it should no longer
accept transactions that can modify it. When it's removed from
the replication, it should be writable again. Add this logic
to the replication module itself, so it can be removed from the
main ovsdb-server later.
Signed-off-by: Ilya
Small refactoring so we can re-use this function in later commits.
Signed-off-by: Ilya Maximets
---
ovsdb/ovsdb-server.c | 45 +++-
1 file changed, 32 insertions(+), 13 deletions(-)
diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c
index 7f65cadfe
after a crash.
Signed-off-by: Ilya Maximets
---
ovsdb/jsonrpc-server.c | 11
ovsdb/jsonrpc-server.h | 6 +-
ovsdb/ovsdb-server.c | 136 -
3 files changed, 110 insertions(+), 43 deletions(-)
diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c
values and only update them with what is provided
by the user explicitly. For example, replication and relay
have different default probe intervals.
Signed-off-by: Ilya Maximets
---
ovsdb/jsonrpc-server.c | 66 ++
ovsdb/jsonrpc-server.h | 6
2 files
in a single process.
Marking the _Server database as read only is not necessary, because
modifications of internal databases are not allowed anyway, but it
doesn't hurt.
Signed-off-by: Ilya Maximets
---
ovsdb/jsonrpc-server.c | 3 ++-
ovsdb/ovsdb-server.c | 3 +++
ovsdb/ovsdb.c | 2
It's not a big problem, but it would be nice to ensure that
the backup database cannot be locally converted.
Fixes: e51879e99b3e ("ovsdb: Make OVSDB backup sever read only")
Signed-off-by: Ilya Maximets
---
ovsdb/trigger.c | 8
1 file changed, 8 insertions(+)
diff --g
The DSCP_DEFAULT is not zero and is a value that supposed
to be used for all connections by default.
Fixes: f125905cdd3d ("Allow configuring DSCP on controller and manager
connections.")
Signed-off-by: Ilya Maximets
---
ovsdb/jsonrpc-server.c | 1 +
1 file changed, 1 insertion(+)
It's easier to analyze failures when the lines that are different
are shown next to each other.
Signed-off-by: Ilya Maximets
---
tests/ovsdb-client.at | 6 +++---
tests/ovsdb-server.at | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/ovsdb-client.at b/tests/ovsdb
It's almost impossible to debug test failures without them.
Signed-off-by: Ilya Maximets
---
tests/ovsdb-server.at | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
index d36c3c117..35286db37 100644
outgoing message is still not sorted.
Signed-off-by: Ilya Maximets
---
lib/jsonrpc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c
index c8ce5362e..3db5f76e2 100644
--- a/lib/jsonrpc.c
+++ b/lib/jsonrpc.c
@@ -221,19 +221,19
ound": {
"service-model": "relay",
"source": {
"ssl:[fe:::1]:6642,ssl:[fe:::2]:6642": {
"max-backoff": 8000,
"inactivity-probe": 1
On 12/4/23 15:21, Vladislav Odintsov wrote:
> Hi!
>
> I’m starting this thread as continuation after its first version, which was
> about OVN Interconnection usecase [0] ;)
> Tests are performed with OVN 22.09.x and latest OVS master branch with applied
> [1] and [2] patches.
>
> OVS
On 11/28/23 07:27, Ales Musil wrote:
>
>
> On Mon, Nov 27, 2023 at 7:36 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> On 11/16/23 16:08, Ales Musil wrote:
> > The CT flush is not capable of partial flush based
> > on the t
| 14
> 22 files changed, 709 insertions(+), 144 deletions(-)
>
Thanks, Ales!
I fixed a few typos and a misplaced NEWS entry and applied the set.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 12/5/23 15:38, Eelco Chaudron wrote:
>
>
> On 28 Nov 2023, at 8:52, Eelco Chaudron wrote:
>
>> On 27 Nov 2023, at 19:16, Ilya Maximets wrote:
>>
>>> On 11/27/23 13:41, Eelco Chaudron wrote:
>>>> I ran 80 series of full tests, and the follo
t change the state in patchwork yet.
>
> Recheck-request: github
>
I hope it was enough time for testing. :)
I applied the change now.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 12/4/23 06:11, Ales Musil wrote:
>
>
> On Sat, Dec 2, 2023 at 12:21 AM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> On 11/30/23 08:31, Ales Musil wrote:
> > CT flush extension would silently ignore unknown properties,
> > wh
On 12/4/23 16:24, Eelco Chaudron wrote:
>
>
> On 1 Dec 2023, at 22:04, Ilya Maximets wrote:
>
>> If a packet is received from a UDP tunnel, it has a source port
>> populated in the tunnel metadata. This field cannot be read or
>> changed with OpenFlow or the
On 12/4/23 14:18, Marcelo Leitner wrote:
> On Mon, Dec 04, 2023 at 01:57:50PM +0100, Ilya Maximets wrote:
>> On 12/4/23 13:40, Marcelo Leitner wrote:
>>> On Sat, Dec 02, 2023 at 12:06:59AM +0100, Ilya Maximets wrote:
>>> ...
>>>> Adding a test case that
On 12/2/23 16:16, Vladislav Odintsov wrote:
> Hi Ilya, thanks for the added test!
>
> I’ve got one question about it, psb.
>
>> On 2 Dec 2023, at 02:06, Ilya Maximets wrote:
>>
>> There is no TCA_TUNNEL_KEY_ENC_SRC_PORT in the kernel, so the offl
On 12/4/23 13:40, Marcelo Leitner wrote:
> On Sat, Dec 02, 2023 at 12:06:59AM +0100, Ilya Maximets wrote:
> ...
>> Adding a test case that demonstrates a scenario where the issue
>> occurs - bridging of two tunnels.
>
> I get the fix and it LGTM. What I don't get is the
> Have those changes settled down now?
>
> Other than the above, I do not have any questions regarding this patch(set).
> And I do see that the most recent review, of v6, has been addressed as of v7.
>
> Acked-by: Simon Horman
Thanks, Flavio, Mike and Simon! And also David for l
rint "\
> +01 04 00 28 00 00 00 03 00 00 23 20 00 00 00 20 \
> +06 \
> +00 00 00 00 00 00 00 \
> +00 00 00 10 00 00 00 00 \
> +00 80 00 08 00 50 00 00 \
> +"| grep -q OFPBPC_BAD_TYPE], [0], [ignore], [stderr])
> +AT_CHECK([grep -q "unknown ofp_ct_tuple property type 1
On 11/20/23 11:42, Vladislav Odintsov wrote:
> Hi Ilya,
>
>> On 15 Nov 2023, at 21:51, Ilya Maximets wrote:
>>
>> On 11/15/23 14:13, Vladislav Odintsov wrote:
>>> Hi Ilya,
>>>
>>>> On 13 Nov 2023, at 22:25, Ilya Maximets wr
loads: Implement netdev flow put using tc
interface")
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2023-October/052744.html
Reported-by: Vladislav Odintsov
Signed-off-by: Ilya Maximets
---
Version 2:
* Slightly adjusted a commit message now that we understand the
allows traffic from one tunnel to anther to be offloaded to TC,
as TC doesn't allow setting the source port at all.
Signed-off-by: Ilya Maximets
---
Vladislav, it would be great if you can test this change on your
setup along with the previous offloading fix:
https://patchwork.ozlabs.org/project
)
>
Hi, Adrian. Thanks for the patches! But it looks like this
patch set is based on some old version of OVS. For example,
the E721 was already fixed in a different way.
Could you, please, rebase?
Best regards, Ilya Maximets.
___
dev mailing li
On 11/29/23 19:16, Eelco Chaudron wrote:
>
>
> On 29 Nov 2023, at 17:42, Ilya Maximets wrote:
>
>> FreeBSD 12 is going EOL in December [1] and will likley become
>
> nit: likely
>
>> unavailable shortly after. FreeBSD 14 was released recently,
>> so r
.883Z|00151|netdev_dpdk|INFO|Port 0:
> 50:7c:6f:3c:0c:26
> 2023-12-01T13:55:46.884Z|00152|netdev_dpdk|INFO|phy0: rx-steering:
> default rss
Here also, exact date/times and sequence numbers of the logs are
not important and can be removed to make the log easier to read.
Slight indentation wo
On 11/30/23 22:34, Alin Serdean wrote:
> Thank you for fixing this!
>
> Acked-by: Alin Gabriel Serdean
>
>
>> On 30 Nov 2023, at 22:12, Ilya Maximets wrote:
>>
>> It may take a few days for AppVeyor to fix their broken
>> images [1], use the
It may take a few days for AppVeyor to fix their broken
images [1], use the 'Previous' version of the image for now
to unblock CI.
We'll need to revert this once the issue is fixed.
[1] https://github.com/appveyor/ci/issues/3893
Signed-off-by: Ilya Maximets
---
This builds successfully
On 11/30/23 10:18, Phelan, Michael wrote:
>
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Wednesday, November 29, 2023 7:07 PM
>> To: Phelan, Michael ; ovs-dev > d...@openvswitch.org>
>> Cc: i.maxim...@ovn.org; Marchand, David ;
>>
On 11/30/23 10:18, Phelan, Michael wrote:
>
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Wednesday, November 29, 2023 7:07 PM
>> To: Phelan, Michael ; ovs-dev > d...@openvswitch.org>
>> Cc: i.maxim...@ovn.org; Marchand, David ;
>>
On 11/30/23 14:25, Ilya Maximets wrote:
> On 11/30/23 14:08, Eelco Chaudron wrote:
>>
>>
>> On 30 Nov 2023, at 13:29, Simon Horman wrote:
>>
>>> On Tue, Nov 28, 2023 at 06:50:59PM +0100, Eelco Chaudron wrote:
>>>>
>>>>
>>>>
On 11/30/23 14:08, Eelco Chaudron wrote:
>
>
> On 30 Nov 2023, at 13:29, Simon Horman wrote:
>
>> On Tue, Nov 28, 2023 at 06:50:59PM +0100, Eelco Chaudron wrote:
>>>
>>>
>>> On 27 Nov 2023, at 19:18, Ilya Maximets wrote:
>>>
>>>>
22.11.3
>
>
Should be fine to not update the master to 22.11.3 as long
as we move to 23.11 soon enough. Thanks!
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
: support double VLAN"), which
is only in DPDK 23.07+, while we should still be using 22.11 here.
Could you, please, check?
But also, is something needs to be changed for the support of 23.11
so the tests will not fail once we upgrade? Looks like some driver
configuration error tha
FreeBSD 12 is going EOL in December [1] and will likley become
unavailable shortly after. FreeBSD 14 was released recently,
so replacing the old with the new.
[1] https://www.freebsd.org/security/
Signed-off-by: Ilya Maximets
---
.cirrus.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion
1, 1, ofctl_ofp_parse, OVS_RW },
Hi, Ales. The subject of this patch should say 'ovs-ofctl' and
not 'ovs-vsctl'.
I fixed that and applied the change (only this one patch). Also
backported down to 2.17 with necessary adjustments.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 11/29/23 17:04, Kevin Traynor wrote:
> On 29/11/2023 15:35, Ilya Maximets wrote:
>> On 11/29/23 16:31, Kevin Traynor wrote:
>>> On 29/11/2023 15:19, Ilya Maximets wrote:
>>>> On 11/28/23 15:13, Kevin Traynor wrote:
>>>>> Update the CI and doc
On 11/29/23 16:31, Kevin Traynor wrote:
> On 29/11/2023 15:19, Ilya Maximets wrote:
>> On 11/28/23 15:13, Kevin Traynor wrote:
>>> Update the CI and docs to use DPDK 22.11.3.
>>>
>>> Signed-off-by: Kevin Traynor
>>> Acked-by: Simon Horman
>>&
> + $ export DPDK_DIR=/usr/src/dpdk-stable-22.11.3
> $ cd $DPDK_DIR
>
> diff --git a/NEWS b/NEWS
> index eb7a9b1ba..6e1f175c5 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,4 +1,6 @@
> v3.2.2 - xx xxx
>
> + - DPDK:
> + * OVS v
$ cd $DPDK_DIR
>
> diff --git a/NEWS b/NEWS
> index 13229cb3a..70d9f5ade 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,4 +1,6 @@
> v3.1.4 - xx xxx
>
> + - DPDK:
> + * OVS validated with DPDK 22.11.3
Ditto.
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> - $ export DPDK_DIR=/usr/src/dpdk-stable-21.11.2
> + $ wget https://fast.dpdk.org/rel/dpdk-21.11.5.tar.xz
> + $ tar xf dpdk-21.11.5.tar.xz
> + $ export DPDK_DIR=/usr/src/dpdk-stable-21.11.5
> $ cd $DPDK_DIR
>
> diff
$ wget https://fast.dpdk.org/rel/dpdk-21.11.5.tar.xz
> + $ tar xf dpdk-21.11.5.tar.xz
> + $ export DPDK_DIR=/usr/src/dpdk-stable-21.11.5
> $ cd $DPDK_DIR
>
> diff --git a/NEWS b/NEWS
> index 7d4a8c081..ceecc25da 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -
bool
> *with_zone,
> }
> error = ofpprop_parse_u16(, zone_id);
> break;
> +
> +default:
> +error = OFPPROP_UNKNOWN(false, "ofp_ct_match", type);
> +break;
Hi, Ales.
There is a similar check mi
On 11/29/23 08:23, Ales Musil wrote:
> Add limit to the CT zone DB table with ovs-vsctl
> helper methods. The limit has two special values
> besides any number, 0 is unlimited and empty limit
> is to leave the value untouched in the datapath.
>
> This is preparation step and the value is not yet
On 11/28/23 19:15, Eelco Chaudron wrote:
>
>
> On 28 Nov 2023, at 13:07, Ilya Maximets wrote:
>
>> On 11/28/23 08:39, Eelco Chaudron wrote:
>>>
>>>
>>> On 27 Nov 2023, at 18:58, Ilya Maximets wrote:
>>>
>>>> On 11/27/2
On 11/2/23 13:00, Ales Musil wrote:
> The zone 0 is default system zone, do not use this
> zone for the test because it might contain some
> entries already which could cause flakiness during
> the check.
>
> In order to still have the zone 0 parsing coverage
> add simple unit tests for dpctl.
>
cros.at b/tests/ofproto-macros.at
> index d2e6ac768..09d21f916 100644
> --- a/tests/ofproto-macros.at
> +++ b/tests/ofproto-macros.at
> @@ -171,14 +171,14 @@ m4_define([_OVS_VSWITCHD_START],
> AT_CHECK([[sed < stderr '
> /vlog|INFO|opened log file/d
> /ovsdb_server|INFO|ovsdb-server (Open vSwitch)/d']])
> - AT_CAPTURE_FILE([ovsdb-server.log])
> + #AT_CAPTURE_FILE([ovsdb-server.log])
>
> dnl Initialize database.
> AT_CHECK([ovs-vsctl --no-wait init $2])
>
> dnl Start ovs-vswitchd.
> AT_CHECK([ovs-vswitchd $1 --detach --no-chdir --pidfile --log-file
> -vvconn -vofproto_dpif -vunixctl], [0], [], [stderr])
> - AT_CAPTURE_FILE([ovs-vswitchd.log])
> + #AT_CAPTURE_FILE([ovs-vswitchd.log])
> on_exit "kill_ovs_vswitchd `cat ovs-vswitchd.pid`"
> AT_CHECK([[sed < stderr '
> /ovs_numa|INFO|Discovered /d
This chunk looks like a testing artifact.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 11/2/23 13:00, Ales Musil wrote:
> Add limit to the CT zone DB table with ovs-vsctl
> helper methods. The limit has two special values
> besides any number, 0 is unlimited and empty limit
> is to leave the value untouched in the datapath.
>
> This is preparation step and the value is not yet
>
On 11/2/23 13:00, Ales Musil wrote:
> Add optional argument to dpctl ct-del-limits called
> "default", which allows to remove the default limit
> making it effectively system default.
>
> Signed-off-by: Ales Musil
> ---
> v6: Rebase on top of current master.
> Address comments from Ilya:
>
On 11/2/23 13:00, Ales Musil wrote:
> Internally handle default CT zone limit as other limits that
> can be passed via the list with special value -1. Currently,
> the -1 is treated by both datapaths as default, add static
> asserts to make sure that this remains the case in the future.
> This
On 11/28/23 08:49, Eelco Chaudron wrote:
>
>
> On 27 Nov 2023, at 19:14, Ilya Maximets wrote:
>
>> On 11/27/23 13:40, Eelco Chaudron wrote:
>>> Install additional packages and drivers required by
>>> make check-dpdk.
>>>
>>> Signed-
On 11/28/23 08:43, Eelco Chaudron wrote:
>
>
> On 27 Nov 2023, at 19:04, Ilya Maximets wrote:
>
>> On 11/27/23 13:39, Eelco Chaudron wrote:
>>> This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip
>>> tests that won't execute successfully through
On 11/28/23 08:39, Eelco Chaudron wrote:
>
>
> On 27 Nov 2023, at 18:58, Ilya Maximets wrote:
>
>> On 11/27/23 13:38, Eelco Chaudron wrote:
>>> Signed-off-by: Eelco Chaudron
>>> ---
>>> .ci/linux-build.sh |9 +
>
mand.
Hi, Ales. Thanks for the new version!
Are you planning to send a fix for unknown properties?
I think, we need to get it before extending the functionality
as we'll also need to backport it.
Best regards, Ilya Maximets.
>
> Ales Musil (3):
> ofp-prop: Add helper for parsing and storin
On 11/27/23 18:36, Eelco Chaudron wrote:
> This patch detects new static analyze issues, and report them.
> It does this by reporting on the delta for this branch, compared
> to the previous branch.
>
> For example the error might look like this:
>
> error level: +0 -0 no changes
> warning
ease, try to avoid such a long lines in the commit message.
Some can be split, some can be trimmed as most of the info in
them is not actually useful.
I didn't fully review the actual code change here.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ements.txt
> +++ b/python/test_requirements.txt
> @@ -2,4 +2,5 @@ netaddr
> pyftpdlib
> pyparsing
> pytest
> +scapy
I'd vote against enabling scapy-based tests. They are mainly randomized
autovalidator tests that we cannot meaningfully test in GHA anyway. The
one that is about configura
On 11/27/23 13:39, Eelco Chaudron wrote:
> Signed-off-by: Eelco Chaudron
> ---
> .github/workflows/build-and-test.yml |4
> 1 file changed, 4 insertions(+)
>
> diff --git a/.github/workflows/build-and-test.yml
> b/.github/workflows/build-and-test.yml
> index db0a1ac39..d74668f61
On 11/27/23 13:39, Eelco Chaudron wrote:
> Signed-off-by: Eelco Chaudron
> ---
> .github/workflows/build-and-test.yml |4
> 1 file changed, 4 insertions(+)
>
> diff --git a/.github/workflows/build-and-test.yml
> b/.github/workflows/build-and-test.yml
> index 586b0cdd9..db0a1ac39
On 11/27/23 13:39, Eelco Chaudron wrote:
> This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip
> tests that won't execute successfully through GitHub actions.
> We could not use the -k !keyword option, as it can not be
> combined with a range of tests.
>
> Signed-off-by: Eelco Chaudron
On 11/27/23 13:38, Eelco Chaudron wrote:
Some minimal commit message would be nice, since this patch
contains several design decisions that may use justification,
e.g. split of the testsuite in two parts, base image upgrade
and new dependencies.
> Signed-off-by: Eelco Chaudron
> ---
>
kflows/build-and-test.yml
> b/.github/workflows/build-and-test.yml
> index 09654205e..5d441157c 100644
> --- a/.github/workflows/build-and-test.yml
> +++ b/.github/workflows/build-and-test.yml
> @@ -164,6 +164,9 @@ jobs:
> m32: m32
>
ting process.
Not saying we shouldn't do this, just highlighting the potential issue.
Best regards, Ilya Maximets.
>
> V2:
> Added patch to fix DPDK cache key generation.
>
> Eelco Chaudron (9):
> ci: Add make check-ovsdb-cluster tests to GitHub action ci.
> ci
-21.11.5.tar.xz
>> + $ export DPDK_DIR=/usr/src/dpdk-stable-21.11.5
>> $ cd $DPDK_DIR
>>
>> diff --git a/NEWS b/NEWS
>> index 7d4a8c081..642beb45b 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -1,4 +1,7 @@
>> v2.17.9 - xx xxx
>>
m/browse/FDP-70
> Suggested-by: Ilya Maximets
> Signed-off-by: Dumitru Ceara
> Acked-by: Numan Siddique
> ---
> V4:
> - Addressed Numan's comment and added his ack:
> - copy the table name argument
> - kept Numan's ack as the other changes since v3 were not
> functional
701 - 800 of 6950 matches
Mail list logo
