Re: [ovs-dev] [PATCH V2] datapath: Prevent panic

On Tue, Apr 17, 2018 at 12:34 PM, Greg Rose wrote: > On RHEL 7.x kernels we observe a panic induced by a paging error > when the timer kicks off a job that subsequently accesses memory > that belonged to the openvswitch kernel module but was since > unloaded - thus the

Re: [ovs-dev] [PATCH] datapath: Prevent panic

On Mon, Apr 16, 2018 at 10:58 AM, Greg Rose wrote: > On RHEL 7.x kernels we observe a panic induced by a paging error > when the timer kicks off a job that subsequently accesses memory > that belonged to the openvswitch kernel module but was since > unloaded - thus the

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

On Mon, Mar 5, 2018 at 8:29 PM, Justin Pettit <jpet...@ovn.org> wrote: > >> On Feb 20, 2018, at 1:16 AM, Justin Pettit <jpet...@ovn.org> wrote: >> >>> On Feb 19, 2018, at 4:30 PM, Pravin Shelar <pshe...@ovn.org> wrote: >>> >>> On Mon, Fe

Re: [ovs-dev] [PATCH 2/2] compat: Fix RHEL 7 build warnings

On Mon, Feb 26, 2018 at 2:10 PM, Greg Rose wrote: > A prior commit to fix up netdev_master_upper_dev_link for recent > kernels caused a compile warning on RHEL 7 builds. > > Fixes: 36d3520b5f ("datapath: Fix netdev_master_upper_dev_link for 4.14") > Signed-off-by: Greg Rose

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

On Mon, Feb 19, 2018 at 3:23 PM, Justin Pettit <jpet...@ovn.org> wrote: > >> On Feb 19, 2018, at 9:50 AM, Justin Pettit <jpet...@ovn.org> wrote: >> >> >>> On Feb 16, 2018, at 5:32 PM, Justin Pettit <jpet...@ovn.org> wrote: >>> >>>

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

On Fri, Feb 16, 2018 at 2:16 PM, Justin Pettit <jpet...@ovn.org> wrote: > > >> On Feb 16, 2018, at 1:25 PM, Pravin Shelar <pshe...@ovn.org> wrote: >> >> On Fri, Feb 16, 2018 at 1:44 AM, Justin Pettit <jpet...@ovn.org> wrote: >>> >> At this

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

On Fri, Feb 16, 2018 at 1:44 AM, Justin Pettit <jpet...@ovn.org> wrote: > > >> On Feb 16, 2018, at 12:52 AM, Pravin Shelar <pshe...@ovn.org> wrote: >> >> On Wed, Feb 14, 2018 at 3:18 PM, Greg Rose <gvrose8...@gmail.com> wrote: >>>

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

On Wed, Feb 14, 2018 at 3:18 PM, Greg Rose wrote: > Pull in the remaining available upstream bug fixes for the openvswitch > Linux kernel datapath. In addition, allow building the openvswitch > OOT kernel datapath on kernels up to and including Linux kernel release > 4.15.

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

On Wed, Feb 14, 2018 at 11:09 PM, Justin Pettit wrote: > Pravin, thank you for integrating Greg's 4.14 series. We'd like to release > OVS 2.9 in the next couple of days. Would you be able to look at this series > and see if it's appropriate to bring into OVS 2.9? I'm sorry

Re: [ovs-dev] [PATCH v2 00/11] Add upstream Linux 4.14 kernel support

On Wed, Feb 7, 2018 at 7:49 AM, Greg Rose wrote: > This patch set includes new features from upstream Linux kernel > 4.14 as well as some additional bug fixes specific to the new > feature. It also updates the travis build kernel list and makes > a few other small changes

Re: [ovs-dev] [PATCH V2 00/10] Upstream Linux bug fixes for datapath

On Wed, Feb 7, 2018 at 7:30 AM, Greg Rose wrote: > Reorganized patch set that includes bug fixes and compatability > layer changes that can be backported to 2.9 as well as applied > to master. > > V2 of these patches include suggested changes from the first patch > set. > >

Re: [ovs-dev] [PATCH 00/20] Update and backport of upstream Linux

On Tue, Jan 30, 2018 at 3:40 PM, Greg Rose wrote: > Allow OVS to compile and build on Linux 4.14.x kernels. Added > necessary compatability layer changes to the respective patches > as required for our OOT build environment. > > Note that NSH and ERSPAN patches are not in

Re: [ovs-dev] [PATCH 11/20] datapath: Add meter netlink definitions

On Tue, Jan 30, 2018 at 3:40 PM, Greg Rose wrote: > From: Andy Zhou > > Upstream commit: > commit 5794040647de4011598a6d005fdad95d24fd385b > Author: Andy Zhou > Date: Fri Nov 10 12:09:40 2017 -0800 > > openvswitch: Add meter

Re: [ovs-dev] [PATCH 18/20] datapath: use ktime_get_ts64() instead of ktime_get_ts()

On Tue, Jan 30, 2018 at 4:40 PM, Gregory Rose wrote: > On 1/30/2018 3:40 PM, Greg Rose wrote: >> >> From: Arnd Bergmann >> >> Upstream commit: >> commit 311af51dcb5629f04976a8e451673f77e3301041 >> Author: Arnd Bergmann >> Date:

Re: [ovs-dev] [PATCH 12/20] datapath: Add meter infrastructure

On Tue, Jan 30, 2018 at 3:40 PM, Greg Rose wrote: > From: Andy Zhou > > Upstream commit: > commit 96fbc13d7e770b542d2d1fcf700d0baadc6e8063 > Author: Andy Zhou > Date: Fri Nov 10 12:09:42 2017 -0800 > > openvswitch: Add meter

Re: [ovs-dev] [PATCH 09/20] datapath: reliable interface indentification in port dumps

On Tue, Jan 30, 2018 at 3:40 PM, Greg Rose wrote: > From: Jiri Benc > > Upstream commit: > commit 9354d452034273a50a4fd703bea31e5d6b1fc20b > Author: Jiri Benc > Date: Thu Nov 2 17:04:37 2017 -0200 > > openvswitch:

Re: [ovs-dev] [PATCH 01/20] datapath: Fix netdev_master_upper_dev_link for 4.14

On Tue, Jan 30, 2018 at 3:40 PM, Greg Rose wrote: > An extended netlink ack has been added for 4.14 - add compat layer > changes so that it compiles for all kernels up to and including > 4.14. > > Signed-off-by: Greg Rose > --- > acinclude.m4

Re: [ovs-dev] [PATCH v4] openvswitch: Remove padding from packet before L3+ conntrack processing

On Wed, Jan 31, 2018 at 6:48 PM, Ed Swierk wrote: > IPv4 and IPv6 packets may arrive with lower-layer padding that is not > included in the L3 length. For example, a short IPv4 packet may have > up to 6 bytes of padding following the IP payload when received on an >

Re: [ovs-dev] [PATCH v3 1/2] skbuff: Add skb_network_trim

On Mon, Jan 22, 2018 at 6:42 PM, Ed Swierk wrote: > IPv4 and IPv6 packets may arrive with lower-layer padding that is not > included in the L3 length. For example, a short IPv4 packet may have > up to 6 bytes of padding following the IP payload when received on an >

Re: [ovs-dev] [PATCH 0/3] Check gso_size of packets when forwarding

On Mon, Jan 22, 2018 at 12:14 PM, David Miller <da...@davemloft.net> wrote: > From: Pravin Shelar <pshe...@ovn.org> > Date: Fri, 19 Jan 2018 13:54:15 -0800 > >> I agree it is not perfect. But the other proposed patch does not fix >> the connectivity issue. I

Re: [ovs-dev] [PATCH v3 1/2] skbuff: Add skb_network_trim

On Mon, Jan 22, 2018 at 6:42 PM, Ed Swierk wrote: > IPv4 and IPv6 packets may arrive with lower-layer padding that is not > included in the L3 length. For example, a short IPv4 packet may have > up to 6 bytes of padding following the IP payload when received on an >

Re: [ovs-dev] [PATCH v3 2/2] openvswitch: Remove padding from packet before L3+ conntrack processing

On Mon, Jan 22, 2018 at 6:42 PM, Ed Swierk wrote: > In the OVS conntrack receive path, ovs_ct_execute() pulls the skb to > the L3 header but does not trim it to the L3 length before calling > nf_conntrack_in(NF_INET_PRE_ROUTING). When nf_conntrack_proto_tcp >

Re: [ovs-dev] [PATCH 2/2] datapath: add ct_clear action

On Mon, Jan 22, 2018 at 11:10 AM, Eric Garver wrote: > Upstream commit: > commit b8226962b1c49c784aeddb9d2fafbf53dfdc2190 > Author: Eric Garver > Date: Tue Oct 10 16:54:44 2017 -0400 > > openvswitch: add ct_clear action > > This adds a ct_clear

Re: [ovs-dev] [PATCH 2/2] datapath: add ct_clear action

On Mon, Jan 22, 2018 at 3:56 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Jan 22, 2018 at 02:34:53PM -0800, Pravin Shelar wrote: >> On Mon, Jan 22, 2018 at 11:10 AM, Eric Garver <e...@erig.me> wrote: >> > Upstream commit: >> > commit b8226962b1c49c784

Re: [ovs-dev] [PATCH 2/2] datapath: add ct_clear action

On Mon, Jan 22, 2018 at 11:10 AM, Eric Garver wrote: > Upstream commit: > commit b8226962b1c49c784aeddb9d2fafbf53dfdc2190 > Author: Eric Garver > Date: Tue Oct 10 16:54:44 2017 -0400 > > openvswitch: add ct_clear action > > This adds a ct_clear

Re: [ovs-dev] [PATCH 2/2] datapath: add ct_clear action

On Mon, Jan 22, 2018 at 11:10 AM, Eric Garver wrote: > Upstream commit: > commit b8226962b1c49c784aeddb9d2fafbf53dfdc2190 > Author: Eric Garver > Date: Tue Oct 10 16:54:44 2017 -0400 > > openvswitch: add ct_clear action > > This adds a ct_clear

Re: [ovs-dev] [PATCH 0/3] Check gso_size of packets when forwarding

On Fri, Jan 19, 2018 at 3:58 AM, Daniel Axtens <d...@axtens.net> wrote: > Pravin Shelar <pshe...@ovn.org> writes: > >> On Thu, Jan 18, 2018 at 5:28 PM, Daniel Axtens <d...@axtens.net> wrote: >>> Pravin Shelar <pshe...@ovn.org> writes: >>>

Re: [ovs-dev] [PATCH 0/3] Check gso_size of packets when forwarding

On Thu, Jan 18, 2018 at 5:28 PM, Daniel Axtens <d...@axtens.net> wrote: > Pravin Shelar <pshe...@ovn.org> writes: > >> On Thu, Jan 18, 2018 at 5:08 AM, Daniel Axtens <d...@axtens.net> wrote: >>> Pravin Shelar <pshe...@ovn.org> writes: >>>

Re: [ovs-dev] [PATCH 0/3] Check gso_size of packets when forwarding

On Thu, Jan 18, 2018 at 5:08 AM, Daniel Axtens <d...@axtens.net> wrote: > Pravin Shelar <pshe...@ovn.org> writes: > >> On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens <d...@axtens.net> wrote: >>> When regular packets are forwarded, we validate their size

Re: [ovs-dev] [PATCH 0/3] Check gso_size of packets when forwarding

On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: > When regular packets are forwarded, we validate their size against the > MTU of the destination device. However, when GSO packets are > forwarded, we do not validate their size against the MTU. We > implicitly assume that

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Mon, Jan 8, 2018 at 7:02 PM, Ed Swierk <eswi...@skyportsystems.com> wrote: > On 1/6/18 10:57, Pravin Shelar wrote: >> On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk <eswi...@skyportsystems.com> >> wrote: >>> >>> >>> On Jan 5, 2018 22:17, "

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Sat, Jan 6, 2018 at 10:57 AM, Pravin Shelar <pshe...@ovn.org> wrote: > On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk <eswi...@skyportsystems.com> wrote: >> >> >> On Jan 5, 2018 22:17, "Pravin Shelar" <pshe...@ovn.org> wrote: >

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk <eswi...@skyportsystems.com> wrote: > > > On Jan 5, 2018 22:17, "Pravin Shelar" <pshe...@ovn.org> wrote: > > On Fri, Jan 5, 2018 at 3:20 PM, Ed Swierk <eswi...@skyportsystems.com> > wrote: >&

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Fri, Jan 5, 2018 at 3:20 PM, Ed Swierk <eswi...@skyportsystems.com> wrote: > On Fri, Jan 5, 2018 at 10:14 AM, Ed Swierk <eswi...@skyportsystems.com> > wrote: >> On Thu, Jan 4, 2018 at 7:36 PM, Pravin Shelar <pshe...@ovn.org> wrote: >>> OVS already pull

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Wed, Jan 3, 2018 at 7:49 PM, Ed Swierk <eswi...@skyportsystems.com> wrote: > On Fri, Dec 22, 2017 at 3:31 PM, Pravin Shelar <pshe...@ovn.org> wrote: >> On Thu, Dec 21, 2017 at 7:17 AM, Ed Swierk <eswi...@skyportsystems.com> >> wrote: >>> IPv4 an

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Fri, Dec 22, 2017 at 4:39 PM, Ed Swierk <eswi...@skyportsystems.com> wrote: > On Fri, Dec 22, 2017 at 3:31 PM, Pravin Shelar <pshe...@ovn.org> wrote: >> On Thu, Dec 21, 2017 at 7:17 AM, Ed Swierk <eswi...@skyportsystems.com> >> wrote: >>> IPv4 an

Re: [ovs-dev] Pravin Shelar

On Tue, Jan 2, 2018 at 11:36 AM, David Miller <da...@davemloft.net> wrote: > From: Pravin Shelar <pshe...@ovn.org> > Date: Thu, 28 Dec 2017 15:47:39 -0800 > >> Thanks Joe for the patch. But it is corrupted. I will send updated patch >> soon. > > I'm stil

Re: [ovs-dev] Pravin Shelar

On Wed, Dec 27, 2017 at 10:33 AM, Joe Perches <j...@perches.com> wrote: > On Wed, 2017-12-27 at 10:25 -0800, Ben Pfaff wrote: >> On Wed, Dec 27, 2017 at 04:22:55PM +0100, Julia Lawall wrote: >> > The email address pshe...@nicira.com listed for Pravin Shelar in >> >

Re: [ovs-dev] [PATCH] MAINTAINERS: Update Pravin's email address.

On Wed, Dec 27, 2017 at 10:24 AM, Ben Pfaff <b...@ovn.org> wrote: > Reported-by: Julia Lawall <julia.law...@lip6.fr> > CC: Pravin Shelar <pshe...@ovn.org> > Signed-off-by: Ben Pfaff <b...@ovn.org> Thanks Ben, I pushed it to master. ___

Re: [ovs-dev] [PATCH] openvswitch: Trim off padding before L3 conntrack processing

On Thu, Dec 14, 2017 at 12:05 PM, Ed Swierk <eswi...@skyportsystems.com> wrote: > On Wed, Dec 13, 2017 at 4:58 PM, Pravin Shelar <pshe...@ovn.org> wrote: >> On Tue, Dec 12, 2017 at 8:17 AM, Ed Swierk <eswi...@skyportsystems.com> >> wrote: >>> A short IPv

Re: [ovs-dev] [PATCH] openvswitch: Trim off padding before L3 conntrack processing

On Tue, Dec 12, 2017 at 8:17 AM, Ed Swierk wrote: > A short IPv4 packet may have up to 6 bytes of padding following the IP > payload when received on an Ethernet device. > > In the normal IPv4 receive path, ip_rcv() trims the packet to > ip_hdr->tot_len before invoking

Re: [ovs-dev] [PATCH 7/8] net: ovs: remove unused hardirq.h

Yang Shi <yan...@alibaba-inc.com> > Cc: Pravin Shelar <pshe...@nicira.com> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: d...@openvswitch.org Acked-by: Pravin B Shelar <pshe...@ovn.org> ___ dev mailing list

Re: [ovs-dev] [PATCH] openvswitch: use ktime_get_ts64() instead of ktime_get_ts()

On Mon, Nov 27, 2017 at 5:11 PM, Arnd Bergmann wrote: > timespec is deprecated because of the y2038 overflow, so let's convert > this one to ktime_get_ts64(). The code is already safe even on 32-bit > architectures, since it uses monotonic times. On 64-bit architectures, > nothing

Re: [ovs-dev] [PATCH net-next] openvswitch: Using kfree_rcu() to simplify the code

On Tue, Nov 14, 2017 at 11:57 AM, Wei Yongjun wrote: > The callback function of call_rcu() just calls a kfree(), so we > can use kfree_rcu() instead of call_rcu() + callback function. > > Signed-off-by: Wei Yongjun Acked-by: Pravin B Shelar

Re: [ovs-dev] [PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static

On Tue, Nov 14, 2017 at 11:57 AM, Wei Yongjun wrote: > Fixes the following sparse warnings: > > net/openvswitch/flow_netlink.c:340:8: warning: > symbol 'ovs_nsh_key_attr_size' was not declared. Should it be static? > Acked-by: Pravin B Shelar >

Re: [ovs-dev] [PATCH net-next] openvswitch: Fix return value check in ovs_meter_cmd_features()

On Tue, Nov 14, 2017 at 11:50 AM, Wei Yongjun wrote: > In case of error, the function ovs_meter_cmd_reply_start() returns > ERR_PTR() not NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 96fbc13d7e77 ("openvswitch: Add meter

Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

On Sat, Nov 11, 2017 at 11:53 PM, Guru Shetty wrote: > On 10 November 2017 at 22:54, Gregory Rose wrote: > >> On 11/11/2017 9:57 AM, William Tu wrote: >> >>> yes, this is an artificial dependency. Another way I'm thinking is for > ovs-vswitchd > to

Re: [ovs-dev] [PATCH] openvswitch: add null pointer check on upcall

On Thu, Nov 9, 2017 at 7:29 PM, Colin King wrote: > From: Colin Ian King > > upcall may be assigned a NULL pointer as genlmsg_put can potentially > return a NULL. Add a null check to avoid a null pointer dereference > on upcall. > > Detected

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi <yi.y.y...@intel.com> wrote: > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi <yi.y.y...@intel.com> wrote: >> > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin She

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi <yi.y.y...@intel.com> wrote: > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc <jb...@redhat.com> wrote: >> > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc <jb...@redhat.com> wrote: > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) >> > +{ >> > + struct nshhdr *nh; >> >

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Sun, Nov 5, 2017 at 8:19 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > On Sat, Nov 04, 2017 at 10:29:46PM +0800, Pravin Shelar wrote: >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang <yi.y.y...@intel.com> wrote: >> > +int nsh_push(struct sk_buff *skb,

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > v14->v15 > - Check size in nsh_hdr_from_nlattr > - Fixed four small issues pointed out By Jiri and Eric > > v13->v14 > - Rename skb_push_nsh to nsh_push per Dave's comment > - Rename skb_pop_nsh to nsh_pop per Dave's

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Thu, Nov 2, 2017 at 6:40 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: >> On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi <yi.y.y...@intel.com> wrote: >> > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shel

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang <yi.y.y...@intel.com> wrote: >> > >> > OVS master and 2.8 branch has merged NSH

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > v14->v15 > - Check size in nsh_hdr_from_nlattr > - Fixed four small issues pointed out By Jiri and Eric > > v13->v14 > - Rename skb_push_nsh to nsh_push per Dave's comment > - Rename skb_pop_nsh to nsh_pop per Dave's

Re: [ovs-dev] [PATCH net-next v2] openvswitch: add ct_clear action

On Tue, Oct 10, 2017 at 1:54 PM, Eric Garver wrote: > This adds a ct_clear action for clearing conntrack state. ct_clear is > currently implemented in OVS userspace, but is not backed by an action > in the kernel datapath. This is useful for flows that may modify a > packet tuple

Re: [ovs-dev] [PATCH net-next] openvswitch: add ct_clear action

On Fri, Oct 6, 2017 at 9:44 AM, Eric Garver wrote: > This adds a ct_clear action for clearing conntrack state. ct_clear is > currently implemented in OVS userspace, but is not backed by an action > in the kernel datapath. This is useful for flows that may modify a > packet tuple

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 6:39 PM, Yang, Yi wrote: > On Tue, Sep 26, 2017 at 06:49:14PM +0800, Jiri Benc wrote: >> On Tue, 26 Sep 2017 12:55:39 +0800, Yang, Yi wrote: >> > After push_nsh, the packet won't be recirculated to flow pipeline, so >> > key->eth.type must be set

Re: [ovs-dev] [PATCH v2] openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()'

On Mon, Sep 11, 2017 at 12:56 PM, Christophe JAILLET wrote: > All other error handling paths in this function go through the 'error' > label. This one should do the same. > > Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") > Signed-off-by:

Re: [ovs-dev] [PATCH 2/2] openvswitch: Optimize operations for OvS flow_stats.

On Sun, Jul 16, 2017 at 11:29 PM, Tonghao Zhang wrote: > When calling the flow_free() to free the flow, we call many times > (cpu_possible_mask, eg. 128 as default) cpumask_next(). That will > take up our CPU usage if we call the flow_free() frequently. > When we put all

Re: [ovs-dev] [PATCH 0/5] Fix unaligned pointer values reported by clang 4.0.

On Wed, May 24, 2017 at 12:18 PM, Greg Rose wrote: > On Tue, 2017-05-23 at 16:02 -0700, Joe Stringer wrote: >> Clang 4.0 has added some new warnings around taking the address of packed >> members of structures which may result in unaligned pointer values. This >> series >>

Re: [ovs-dev] [PATCH] datapath: backport: vxlan: do not output confusing error message

On Thu, May 4, 2017 at 10:01 AM, Joe Stringer wrote: > On 3 May 2017 at 19:05, Pravin B Shelar wrote: >> From: Jiri Benc >> >> Upstream commit: >> commit baf4d7860771287f30fbe9b6b2dc18b04361439d >> Author: Jiri Benc >>

Re: [ovs-dev] [PATCH] datapath: backport: vxlan: correctly handle ipv6.disable module parameter

On Wed, May 3, 2017 at 11:10 AM, Joe Stringer wrote: > On 2 May 2017 at 16:08, Pravin B Shelar wrote: >> From: Jiri Benc >> >> upstream commit: >> commit d074bf9600443403aa24fbc12c1f18eadc90f5aa >> Author: Jiri Benc >>

Re: [ovs-dev] [PATCH 1/1] openvswitch: check return value of nla_nest_start

On Sat, Apr 22, 2017 at 11:43 PM, Pan Bian wrote: > Function nla_nest_start() will return a NULL pointer on error, and its > return value should be validated before it is used. However, in function > queue_userspace_packet(), its return value is ignored. This may result > in

Re: [ovs-dev] ip route command not adding entry into ovs-appctl ovs/route/show

On Thu, Feb 9, 2017 at 10:30 AM, Srikanth Lingala wrote: > Hi, > I am using OVS 2.6.1 which is installed on aarch64 Ubuntu 14.04 node. > When I add a 'route' it is adding into linux routing table. But, when I > execute the command 'ovs-appctl ovs/route/show', that

Re: [ovs-dev] [PATCH v2 3/3] ovs-router: introduce pkt-mark.

On Wed, Jan 25, 2017 at 3:19 PM, Jarno Rajahalme wrote: > Also, IMO this series is good to go to the branch-2.7 as well. > I think it is bit late for 2.7, so I pushed it to master. Thanks for all reviews. ___ dev mailing list

Re: [ovs-dev] [PATCH 3/3] ovs-router: introduce pkt-mark.

On Mon, Jan 23, 2017 at 9:04 AM, Jarno Rajahalme wrote: > >> On Dec 28, 2016, at 1:44 AM, Pravin B Shelar wrote: >> >> OVS router is basically partial copy of linux kernel FIB. >> kernel routing table use skb-mark along with usual routing > > “use”->”uses” > >

Re: [ovs-dev] [PATCH 1/3] tunnel: Add support to configure ptk_mark

On Mon, Jan 23, 2017 at 9:04 AM, Jarno Rajahalme wrote: > Pravin, > > Sorry for the delay, I hope you find time to respond. > >> On Dec 28, 2016, at 1:44 AM, Pravin B Shelar wrote: >> >> Today packet mark action is broaken for Tunnel ports with >> tunnel

Re: [ovs-dev] [PATCH] datapath: internal-dev: Disable rtnl_link_ops register under linux < 3.17

On Mon, Jan 23, 2017 at 10:04 AM, Jarno Rajahalme wrote: > Thomas & Pravin, > > Apparently the commit 5282e284ac57 (“datapath: introduce rtnl ops stub”) > applied to OVS two years ago is not compatible with Linux 3.16 or earlier, > as the corresponding upstream change was only

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

On Wed, Jan 18, 2017 at 4:53 PM, Yang, Yi wrote: > On Wed, Jan 18, 2017 at 01:29:14PM -0800, Joe Stringer wrote: >> On 18 January 2017 at 11:54, Eric Garver wrote: >> > On Tue, Jan 17, 2017 at 12:37:19AM +, Yang, Yi Y wrote: >> >> What userspace do "802.1ad

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Tue, Jan 10, 2017 at 8:14 PM, Jiri Benc <jb...@redhat.com> wrote: > On Tue, 10 Jan 2017 19:29:21 +0530, Pravin Shelar wrote: >> OVS kernel module has compile time checks for various kernel features, >> if any of required tunnel feature is missing OVS kernel module >>

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Tue, Jan 10, 2017 at 3:23 AM, Eric Garver <e...@erig.me> wrote: > On Fri, Dec 09, 2016 at 03:12:39PM -0800, Pravin Shelar wrote: >> On Fri, Dec 9, 2016 at 12:43 AM, Jiri Benc <jb...@redhat.com> wrote: >> > On Thu, 8 Dec 2016 22:49:56 -0800, Pravin Shelar wrote

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

ning changes. Thanks, Pravin. > -Original Message----- > From: Pravin Shelar [mailto:pshe...@ovn.org] > Sent: Sunday, January 1, 2017 3:45 PM > To: Yang, Yi Y <yi.y.y...@intel.com> > Cc: ovs dev <d...@openvswitch.org>; Jarno Rajahalme <ja...@ovn.org> >

Re: [ovs-dev] ovs-vswitch kernel panic randomly started after 400+ days uptime

y :) > Reading the bug report and comments bug was clear to me. I did not tried to reproduce this issue since looking at current code, specific IP-GRE packet can trigger the assertion in code. That particular OVS can not process IP-GRE packets so we should reject such packet irrespective of the a

Re: [ovs-dev] [PATCH 0/3] Tunnel: add support for packet marking

On Fri, Jan 6, 2017 at 10:21 PM, Ben Pfaff wrote: > On Wed, Dec 28, 2016 at 01:44:11AM -0800, Pravin B Shelar wrote: >> Following patch series adds support for setting packet >> mark for tunnel traffic. This allows better integration >> with linux networking stack. > > Who do you

Re: [ovs-dev] ovs-vswitch kernel panic randomly started after 400+ days uptime

Thanks for all investigation. On Sat, Jan 7, 2017 at 12:57 AM, Joe Stringer wrote: > > > On 5 January 2017 at 19:24, Uri Foox wrote: >> >> Hey Joe, >> >> Thank you so much for responding! After 10 days of trying to figure this >> out I'm at a loss. >> >>

Re: [ovs-dev] [PATCH v8] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

On Fri, Dec 30, 2016 at 1:58 AM, Chandran, Sugesh <sugesh.chand...@intel.com> wrote: > > > Regards > _Sugesh > > >> -Original Message- >> From: Pravin Shelar [mailto:pshe...@ovn.org] >> Sent: Saturday, December 24, 2016 1:13 PM >> To: Chandra

Re: [ovs-dev] [PATCH v8] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

On Fri, Dec 23, 2016 at 8:16 PM, Sugesh Chandran wrote: > Add Rx checksum offloading feature support on DPDK physical ports. By default, > the Rx checksum offloading is enabled if NIC supports. However, > the checksum offloading can be turned OFF either while adding a

Re: [ovs-dev] [PATCH v7] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

On Fri, Dec 16, 2016 at 4:03 PM, Chandran, Sugesh <sugesh.chand...@intel.com> wrote: > > > Regards > _Sugesh > >> -Original Message- >> From: Pravin Shelar [mailto:pshe...@ovn.org] >> Sent: Friday, December 16, 2016 7:50 AM >> To: Chandran, Suge

Re: [ovs-dev] [PATCH 0/8] port Jiri's 8 support patches for layer 3 encapsulated packets from net-next

On Thu, Dec 15, 2016 at 5:23 PM, Joe Stringer wrote: > On 15 December 2016 at 05:27, Yi Yang wrote: >> This patch set just ports Jiri's 8 support patches for layer 3 encapsulated >> packets from net-next to current ovs, this is a cornerstone for L3 tunnel >>

Re: [ovs-dev] Backporting "net: mpls: Fixups for GSO"

On Thu, Dec 15, 2016 at 4:33 PM, Jarno Rajahalme wrote: > Simon, > > I was looking at backporting upstream commit 48d2ab609b6b (“net: mpls: Fixups > for GSO”), but quickly figured out I’m out of my depth here. > > This commit changes how the skb offsets are set up for an MPLS

Re: [ovs-dev] [PATCH v7] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

Thanks for the patch. I have couple of questions. On Wed, Dec 14, 2016 at 7:30 AM, Sugesh Chandran wrote: > Add Rx checksum offloading feature support on DPDK physical ports. By default, > the Rx checksum offloading is enabled if NIC supports. However, > the checksum

Re: [ovs-dev] [PATCH] datapath: enable vxlangpe creation in compat mode

On Thu, Dec 8, 2016 at 9:41 PM, Yi Yang wrote: > Current out-of-tree ovs vxlan module has included vxlangpe code, but > it can't create vxlangpe port, this patch enables out-of-tree ovs vxlan > module to create vxlangpe port without Linux kernel v4.7 or above needed, > this

Re: [ovs-dev] [PATCH] travis: Update build matrix for latest kernels.

On Tue, Dec 13, 2016 at 4:00 PM, Joe Stringer wrote: > Signed-off-by: Joe Stringer LGTM. Acked-by: Pravin B Shelar ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Fri, Dec 9, 2016 at 12:43 AM, Jiri Benc <jb...@redhat.com> wrote: > On Thu, 8 Dec 2016 22:49:56 -0800, Pravin Shelar wrote: >> OVS out of tree kernel module is using compat tunnel code upto kernel >> 4.5 kernel even thought LWT is available in these kernels. This is due &

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Thu, Dec 8, 2016 at 1:14 AM, Jiri Benc <jb...@redhat.com> wrote: > On Wed, 7 Dec 2016 16:35:59 -0800, Pravin Shelar wrote: >> In compat mode, OVS tunnel devices are not used in same way as LWT, >> since OVS do support kernel version that does not have core LWT >>

Re: [ovs-dev] [PATCH net-next] openvswitch: fix VxLAN-gpe port can't be created in ovs compat mode

On Thu, Dec 8, 2016 at 12:20 AM, Yi Yang wrote: > In ovs compat mode, ovs won't use LWT in current kernel, this is to > make sure ovs can work on the old kernels, Linux kernel v4.7 includes > VxLAN-gpe support but many Linux distributions' kernels are odler than > v4.7, this

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Wed, Dec 7, 2016 at 12:37 AM, Jiri Benc wrote: > On Wed, 7 Dec 2016 09:03:39 +0800, Yang, Yi wrote: >> But ovs userspace use genetlink to create vxlan tunnel port when we >> build ovs to use its own compat modules, this is case 3 Pravin, how >> do you think we can handle

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Tue, Dec 6, 2016 at 4:24 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > On Tue, Dec 06, 2016 at 09:46:04AM -0800, Pravin Shelar wrote: >> > lib/dpif-netlink.c | 4 >> > 1 file changed, 4 insertions(+) >> > >> > diff --git a/lib/dpif-netlink.c b/l

Re: [ovs-dev] [PATCH] netdev: Fix sockaddr cast warning.

On Wed, Nov 16, 2016 at 5:25 AM, Thadeu Lima de Souza Cascardo wrote: > On Tue, Nov 15, 2016 at 09:15:26PM -0800, Pravin B Shelar wrote: >> Following warning was reported by Travis:- >> >> lib/netdev.c:1916:19: error: cast from 'struct sockaddr *' to 'struct >> sockaddr_in *'

Re: [ovs-dev] [PATCH] datapath: compat: vxlan: Avoid possible NULL dereference in vxlan_gro_receive.

On Sun, Nov 13, 2016 at 6:59 PM, 张东亚 wrote: > With Linux kernel that does not have HAVE_UDP_OFFLOAD_ARG_UOFF macro > detected, > struct vxlan_sock *vs will be NULL, which will make kernel crash when > receiving > VXLAN packet that have RCO flag turn on or even invalid

<    1   2