Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-15 Thread Vladislav Odintsov
Hi Ilya, > On 13 Nov 2023, at 22:25, Ilya Maximets wrote: > > On 11/13/23 13:13, Eelco Chaudron wrote: >> >> >> On 13 Nov 2023, at 12:43, Vladislav Odintsov wrote: >> >>>> On 13 Nov 2023, at 14:17, Eelco Chaudron wrote: >>>> >

Re: [ovs-dev] [PATCH ovn] controller: Disable inactivity probe for statctrl

2023-11-15 Thread Vladislav Odintsov
Thanks Ales for the patch. My patch was under review for a long period of time and there appeared a new OF connection :) Acked-by: Vladislav Odintsov mailto:odiv...@gmail.com>> > On 15 Nov 2023, at 14:06, Ales Musil wrote: > > The inactivity probe was disabled for all connecti

Re: [ovs-dev] [PATCH branch-2.17] datapath-linux: Fix kmod build with recent CentOS Stream kernels

2023-11-14 Thread Vladislav Odintsov
Hi Ilya, Thanks for the review. regards, Vladislav Odintsov > On 15 Nov 2023, at 00:17, Ilya Maximets wrote: > > On 11/14/23 13:47, Vladislav Odintsov wrote: >> With kernel 4.18.0-477.x.y there was a compilation error: >> >> /builddir/build/BUILD/openvswitch-2.

[ovs-dev] [PATCH branch-2.17] datapath-linux: Fix kmod build with recent CentOS Stream kernels

2023-11-14 Thread Vladislav Odintsov
7;kvmalloc' was here This was introduced by upstream kernel commit [0]. This patch fixes this error adding a new path to searched functions to lookup. 0: https://lore.kernel.org/all/20211105203507.gvgl5bzmw%25a...@linux-foundation.org/ Signed-off-by: Vladislav Odintsov --- acinclude.m4 | 1

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-13 Thread Vladislav Odintsov
> On 13 Nov 2023, at 14:17, Eelco Chaudron wrote: > > > > On 8 Nov 2023, at 14:39, Vladislav Odintsov wrote: > >> Hi Ilya, Eelco, >> >> I’ve tried this patch against 3.1 and latest master branch. There are no >> warnings anymore, >> bu

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-08 Thread Vladislav Odintsov
majority of scenarios the source port doesn't actually end >> up in the action itself. >> Having a mismatch between the userspace and TC leads to constant >> revalidation of the flow and warnings in the log, and might >> potentially cause mishandling of the traffic,

Re: [ovs-dev] [PATCH ovn] controller: disable OpenFlow inactivity probing

2023-11-08 Thread Vladislav Odintsov
Thanks Numan! > On 2 Nov 2023, at 23:44, Numan Siddique wrote: > > On Fri, Sep 22, 2023 at 2:40 PM Han Zhou <mailto:hz...@ovn.org>> wrote: >> >> On Mon, Sep 11, 2023 at 7:31 AM Vladislav Odintsov >> wrote: >>> >>> Hi Dumitru, >>&g

Re: [ovs-dev] OVN weekly community meeting

2023-10-24 Thread Vladislav Odintsov
> On 24 Oct 2023, at 12:01, Dumitru Ceara wrote: > > On 10/24/23 10:57, Vladislav Odintsov wrote: >> Hi Dumitru! >> >>> On 24 Oct 2023, at 10:34, Dumitru Ceara wrote: >>> >>> On 10/23/23 11:58, Dumitru Ceara wrote: >>>>> In th

Re: [ovs-dev] OVN weekly community meeting

2023-10-24 Thread Vladislav Odintsov
4KCto-GH_C3tIXSnZZ8 > > Best regards, > Dumitru > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] controller: disable OpenFlow inactivity probing

2023-09-11 Thread Vladislav Odintsov
60s). Maybe you can give any hint how to solve this [1]. 1: https://mail.openvswitch.org/pipermail/ovs-dev/2023-June/405445.html > On 11 Sep 2023, at 15:57, Dumitru Ceara wrote: > > On 9/11/23 14:54, Dumitru Ceara wrote: >> On 6/14/23 20:02, Vladislav Odintsov wrote: >>>

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Assume well-known tables are in the SB schema.

2023-08-17 Thread Vladislav Odintsov
0dbde. > > Ack, I did that now. > >> Otherwise it looks good to me! >> >> Acked-by: Han Zhou mailto:hz...@ovn.org>> >> > > Thanks, applied to main and backported to all branches down to 22.03. > > Regards, > Dumitru Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-08-01 Thread Vladislav Odintsov
] introduced such behaviour was backported). 0: https://github.com/ovn-org/ovn/commit/525829c47d09a114de8536d23784c458977d8321 > On 31 Jul 2023, at 14:43, Vladislav Odintsov wrote: > > Thanks Dumitru! > > I’ll test this patch in a few days. > >> On 28 Jul 2023, at 14:36, Dumitru

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-31 Thread Vladislav Odintsov
out on your data set too. > > Thanks, > Dumitru > > [0] > https://github.com/ovn-org/ovn/blob/5a1d82cb28c554276e0c17718f808b8f244cb162/Documentation/intro/install/ovn-upgrades.rst?plain=1#L28 > > On 7/25/23 10:19, Vladislav Odintsov wrote: >> Many thanks for the informatio

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-25 Thread Vladislav Odintsov
Many thanks for the information! > On 25 Jul 2023, at 11:14, Dumitru Ceara wrote: > > On 7/24/23 21:10, Vladislav Odintsov wrote: >> Hi Dumitru, >> > > Hi Vladislav, > >> I just wanted to ask wether you need any help (maybe, testing) in this? >> I’

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-24 Thread Vladislav Odintsov
, Dumitru Ceara wrote: >>> On 7/11/23 18:33, Vladislav Odintsov wrote: >>>> Hi Dumitru, >>>> >>>> The system on which I reproduced this issue is running 22.09.x version. >>>> I’ve tried to upgrade ovn-controller to main branch + your patch

Re: [ovs-dev] [PATCH 1/2] utilities: add "--detach" option to ovs-ctl

2023-07-17 Thread Vladislav Odintsov
Sorry, there was a typo. regards, Vladislav Odintsov > On 17 Jul 2023, at 23:59, Vladislav Odintsov wrote: > > Hi Ilya, > > My usecase is to run ovsdb-server to serve hardware_vtep ovsdb schema in OVN > controller vtep scenario. Container is used to run service on top

Re: [ovs-dev] [PATCH 1/2] utilities: add "--detach" option to ovs-ctl

2023-07-17 Thread Vladislav Odintsov
problem is we need to re-apply this patch to newer versions unless it is not accepted to upstream… I’m wonder what’s the problem to use this script not only to run ovsdb-server with Open_vSwitch schema with known limitations? regards, Vladislav Odintsov > On 14 Jul 2023, at 20:20, Ilya Maxim

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-11 Thread Vladislav Odintsov
/runs/5519892057 > On 11 Jul 2023, at 14:39, Dumitru Ceara wrote: > > On 7/10/23 22:20, Vladislav Odintsov wrote: >> Hi Dumitru, >> >> thanks for digging into this! I highly appreciate your help! >> > > No worries, my pleasure! :) > >> Please, s

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-10 Thread Vladislav Odintsov
Hi Dumitru, thanks for digging into this! I highly appreciate your help! Please, see my answers inline. > On 10 Jul 2023, at 15:28, Dumitru Ceara wrote: > > On 7/10/23 12:57, Dumitru Ceara wrote: >> On 7/6/23 13:00, Vladislav Odintsov wrote: >>> >>> >&g

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-06 Thread Vladislav Odintsov
> On 5 Jul 2023, at 20:07, Vladislav Odintsov wrote: > > Hi Dumitru, > > thanks for the quick response! > >> On 5 Jul 2023, at 19:53, Dumitru Ceara wrote: >> >> On 7/5/23 17:14, Vladislav Odintsov wrote: >>> Hi, >>> >> >>

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-05 Thread Vladislav Odintsov
Hi Dumitru, thanks for the quick response! > On 5 Jul 2023, at 19:53, Dumitru Ceara wrote: > > On 7/5/23 17:14, Vladislav Odintsov wrote: >> Hi, >> > > Hi Vladislav, > >> we’ve noticed there is a huge ovn-controller memory consumption introduced >>

[ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-05 Thread Vladislav Odintsov
ovn/commit/1b0dbde940706e5de6e60221be78a278361fa76d Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] controller: disable OpenFlow inactivity probing

2023-06-14 Thread Vladislav Odintsov
out. regards, Vladislav Odintsov > On 9 Jun 2023, at 18:28, Mark Michelson wrote: > > Hi, > > Thanks for linking the email thread, since I had the exact same concern that > Numan did about detecting if ovs-vswitchd goes down. It sounds like because > of the nature

Re: [ovs-dev] [PATCH ovn v2] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-06-14 Thread Vladislav Odintsov
Thanks Dumitru! > On 14 Jun 2023, at 16:37, Dumitru Ceara wrote: > > On 5/30/23 17:03, Vladislav Odintsov wrote: >> This patch is intended to make next two changes: >> >> 1. Support create/update of MAC_Binding for GARP/ND from HW VTEP. >> >> Prior

Re: [ovs-dev] [PATCH 1/2] utilities: add "--detach" option to ovs-ctl

2023-06-13 Thread Vladislav Odintsov
Hi Ilya, thanks for the attention on this patchset. > On 13 Jun 2023, at 14:58, Ilya Maximets wrote: > > On 6/7/23 08:33, Vladislav Odintsov wrote: >> Default is yes (current behavior). This means that after start process >> will be run in background. When "no&qu

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-06-08 Thread Vladislav Odintsov
andard OVS controller socket (br-int.mgmt), please give an advice. Alternatively I’ve been thinking about creation another socket with another path for ovs-vswitchd<->ovn-controller OF communication. But I’m concerned about paths consistency across different distributions… Thoughts? > On 6 Jun

[ovs-dev] [PATCH ovn] controller: disable OpenFlow inactivity probing

2023-06-08 Thread Vladislav Odintsov
vs-dev/2023-May/404625.html Signed-off-by: Vladislav Odintsov --- NEWS| 5 + controller/ofctrl.c | 14 ++ controller/ofctrl.h | 4 +--- controller/ovn-controller.8.xml | 14 -- controller/ovn-controller

Re: [ovs-dev] [PATCH ovn v2] northd: match only on supported protocols to handle_svc_check

2023-06-08 Thread Vladislav Odintsov
Thanks, Dumitru! > On 8 Jun 2023, at 16:31, Dumitru Ceara wrote: > > On 5/30/23 14:41, Vladislav Odintsov wrote: >> Depending on the udp service, it can reply with some udp data. >> In that case ovn-controller will warn with next message: >> >> pinctrl(ovn_pi

[ovs-dev] [PATCH 1/2] utilities: add "--detach" option to ovs-ctl

2023-06-06 Thread Vladislav Odintsov
seful when running ovs-ctl inside docker container to make ovs* process to be a pid 1. Note, that with `--detach=no` database settings initialization is not done. db-version, system-ids are not set and transient ports are not deleted. Signed-off-by: Vladislav Odintsov --- utilities/ovs-

[ovs-dev] [PATCH 2/2] utilities: add --in-db-ssl option to ovs-ctl

2023-06-06 Thread Vladislav Odintsov
ssl", which has default behavior as it is now: run ovsdb server with ssl options. User must pass "--in-db-ssl=no" to run ovsdb-server without these arguments. Signed-off-by: Vladislav Odintsov --- utilities/ovs-ctl.in | 11 --- 1 file changed, 8 insertions(+), 3 deletions(

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-06-06 Thread Vladislav Odintsov
Hi Han, thanks for your inputs! Please see comments inline. > On 5 Jun 2023, at 21:01, Han Zhou wrote: > > On Mon, Jun 5, 2023 at 8:58 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> Hi Dumitru, Ilya, Han, >> >> do you guys have any

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-06-05 Thread Vladislav Odintsov
Hi Dumitru, Ilya, Han, do you guys have any comments here? I’m gonna start working on this change in near future... Thank you. > On 17 May 2023, at 18:34, Numan Siddique wrote: > > On Wed, May 17, 2023 at 4:44 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >>

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-05-30 Thread Vladislav Odintsov
v2 of patch #5 was submitted: https://patchwork.ozlabs.org/project/ovn/patch/20230530150328.1224972-1-odiv...@gmail.com/ > On 30 May 2023, at 13:12, Vladislav Odintsov wrote: > > > >> On 30 May 2023, at 13:10, Dumitru Ceara wrote: >> >> On 5/30/23 11:59, Vl

[ovs-dev] [PATCH ovn v2] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-05-30 Thread Vladislav Odintsov
: Vladislav Odintsov --- v1 -> v2: - Addressed Dumitru's review comments. --- NEWS| 2 + controller/binding.c| 47 +++ controller/local_data.h | 3 ++ controller/physical.c | 45 ++- northd/northd.c | 10 + northd/ovn-nort

Re: [ovs-dev] [PATCH ovn] controller: don't report UDP as unsupported proto in svc_check

2023-05-30 Thread Vladislav Odintsov
; On 5/24/23 13:03, Ales Musil wrote: >> On Mon, May 22, 2023 at 11:18 PM Vladislav Odintsov >> wrote: >> >>> Depending on the udp service, it can reply with some udp data. >>> In that case ovn-controller will warn with next message: >>> >>&g

[ovs-dev] [PATCH ovn v2] northd: match only on supported protocols to handle_svc_check

2023-05-30 Thread Vladislav Odintsov
ff-by: Vladislav Odintsov --- v1 -> v2: - Addressed Dumitru's suggestion to match on supported protocols instead of validating protocol inside pinctrl thread. --- northd/northd.c | 2 +- tests/ovn-northd.at | 30 +++--- 2 files changed, 16 insertions(+),

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-05-30 Thread Vladislav Odintsov
> On 30 May 2023, at 13:10, Dumitru Ceara wrote: > > On 5/30/23 11:59, Vladislav Odintsov wrote: >> Hi Dumitru, >> >> thanks for the review! >> My answers are inline. >> >>> On 30 May 2023, at 12:27, Dumitru Ceara wrote: >>> >&g

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-05-30 Thread Vladislav Odintsov
Hi Dumitru, thanks for the review! My answers are inline. > On 30 May 2023, at 12:27, Dumitru Ceara wrote: > > On 5/19/23 20:18, Vladislav Odintsov wrote: >> This patch is intended to make next two changes: >> >> 1. Support create/update of MAC_Binding for GARP/ND

[ovs-dev] [PATCH ovn] controller: don't report UDP as unsupported proto in svc_check

2023-05-22 Thread Vladislav Odintsov
is not something abnormal, so don't write warnings. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1913162 Signed-off-by: Vladislav Odintsov --- controller/pinctrl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/controller/pinctrl.c b/controller/pinctrl.c index b4be

Re: [ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

2023-05-19 Thread Vladislav Odintsov
...@gmail.com/ > On 17 May 2023, at 19:05, Vladislav Odintsov wrote: > > Thanks Dumitru for the response. > > I’ve looked through this code and even tried to implement similar logic for > vtep lport, but realized, that vtep mcast traffic is a bit different from > localnet

[ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-05-19 Thread Vladislav Odintsov
: Vladislav Odintsov --- controller/binding.c| 48 controller/local_data.h | 3 ++ controller/physical.c | 46 +-- northd/northd.c | 10 + northd/ovn-northd.8.xml | 6 +++ tests/ovn.at| 99 - 6

[ovs-dev] [PATCH ovn 3/5] controller: move put_load&resubmit for port-binding in function

2023-05-19 Thread Vladislav Odintsov
This is done to simplify and remove duplication of code. New function will be used in next patch. Signed-off-by: Vladislav Odintsov --- controller/physical.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/controller/physical.c b/controller

[ovs-dev] [PATCH ovn 2/5] northd: build vtep hairpin lflows only for lswitches with vtep lports

2023-05-19 Thread Vladislav Odintsov
There is no need to build lflows for datapaths, where there are no vtep type lports. For instance, edge-outside logical switch, which has no vtep lports but has many chassis redirect lport, can have many useless lflows. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 5

[ovs-dev] [PATCH ovn 4/5] controller: fix typo in comments

2023-05-19 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- controller/binding.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/controller/binding.c b/controller/binding.c index 28218b2e8..c7a2b3f10 100644 --- a/controller/binding.c +++ b/controller/binding.c @@ -2092,7 +2092,7 @@ binding_run

[ovs-dev] [PATCH ovn 1/5] northd: fix ls_in_hairpin l3dgw flow generation

2023-05-19 Thread Vladislav Odintsov
f55c2e ("controller, northd, vtep: support routed networks with HW VTEP") Signed-off-by: Vladislav Odintsov --- northd/northd.c | 35 ++- northd/ovn-northd.8.xml | 13 +++-- tests/ovn.at| 17 +++-- 3 files chang

[ovs-dev] [PATCH ovn 0/5] VTEP lport ARP handling fixes & GARP support

2023-05-19 Thread Vladislav Odintsov
, which removes some code duplication. Patch #5 adds support for GARP coming from vtep lport handling on chassisredirect port and makes some changes in ARP/ND responder logic. Vladislav Odintsov (5): northd: fix ls_in_hairpin l3dgw flow generation northd: build vtep hairpin lflows only for

Re: [ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

2023-05-17 Thread Vladislav Odintsov
lport mcast packets to other remote chassis. I guess I need to reject mcast l2 flood to remote ports if REGBIT_FROM_RAMP == 1. Do you have an idea for the correct place to put such logic in? > On 16 May 2023, at 23:02, Dumitru Ceara wrote: > > On 5/16/23 21:48, Vladislav Odintsov wro

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-05-17 Thread Vladislav Odintsov
> On 16 May 2023, at 23:54, Numan Siddique wrote: > > Hi Vladislav, > > Sorry for the late reply. > > PSB for few comments. Thanks for your reply! My answers are inline. > > > > On Tue, May 16, 2023 at 3:42 PM Vladislav Odintsov <mailto:odiv..

Re: [ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

2023-05-16 Thread Vladislav Odintsov
Hi Numan, Dumitru, Ilya, Mark, if someone can help, I’ll be very grateful. Thanks in advance. > On 15 May 2023, at 15:06, Vladislav Odintsov wrote: > > Hi, > > I’m implementing neighbour learning on the chassis-redirect ports for > traffic coming from lport of vtep

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-05-16 Thread Vladislav Odintsov
Hi Numan, Dumitru, Ilya, I guess I’ve managed to deal with some of these problems and have some conclusions. Please see inline. > On 14 Apr 2023, at 16:26, Vladislav Odintsov wrote: > > And as a follow-up, I see sometimes next error message in ovn-controller log, > thoug

[ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

2023-05-15 Thread Vladislav Odintsov
from localnet to vif located on other chassis? Am I missing something? Let me know if any additional information is needed. Thanks! Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] ovn-controller docs: fix typo in ovn-monitor-all description

2023-05-05 Thread Vladislav Odintsov
Make it more clear that ovn-monitor-all option has effect on OVN Southbound database rather than local OVS. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2023-May/052421.html Reported-by: Ilya Maximets Signed-off-by: Vladislav Odintsov --- controller/ovn-controller.8.xml

Re: [ovs-dev] [PATCH ovn v2] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-04 Thread Vladislav Odintsov
Hi Dumitru, Mark, The new version (v4) has been submitted at https://patchwork.ozlabs.org/project/ovn/patch/20230504165510.4026066-1-odiv...@gmail.com/ > On 3 May 2023, at 17:18, Dumitru Ceara wrote: > > On 5/3/23 16:12, Vladislav Odintsov wrote: >> Hi Dumitru and Mark, >&g

[ovs-dev] [PATCH ovn v4] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-04 Thread Vladislav Odintsov
option was provided, the initial (12 ms) interval is left. Signed-off-by: Vladislav Odintsov --- v3 -> v4: - Rebased on a fresh main branch. v2 -> v3: - Addressed Dumitru's and Mark's suggestion to split ovn-{n,s}bctl configuration option dbctl_probe_interval for nbct

[ovs-dev] [PATCH ovn v3] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-04 Thread Vladislav Odintsov
option was provided, the initial (12 ms) interval is left. Signed-off-by: Vladislav Odintsov --- v2 -> v3: - Addressed Dumitru's and Mark's suggestion to split ovn-{n,s}bctl configuration option dbctl_probe_interval for nbctl_... and sbctl_... . - Added NEWS entry.

Re: [ovs-dev] [PATCH ovn v2] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-03 Thread Vladislav Odintsov
Hi Dumitru and Mark, thanks for the review! > On 3 May 2023, at 16:56, Dumitru Ceara wrote: > > On 5/3/23 15:47, Mark Michelson wrote: >> On 5/3/23 09:03, Dumitru Ceara wrote: >>> Hi Vladislav, >>> >>> On 5/3/23 02:55, Vladislav Odintsov wrot

Re: [ovs-dev] [PATCH ovn] utilities: disable OVSDB inactivity probes for non-daemon ovn-nbctl

2023-05-02 Thread Vladislav Odintsov
1: https://patchwork.ozlabs.org/project/ovn/patch/20230503005531.4005891-1-odiv...@gmail.com/ > On 18 Apr 2023, at 18:31, Vladislav Odintsov wrote: > > > >> On 18 Apr 2023, at 16:59, Dumitru Ceara wrote: >> >> On 4/14/23 15:37, Vladislav Odintsov wrote: >>&g

[ovs-dev] [PATCH ovn v2] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-02 Thread Vladislav Odintsov
to configure intervals in OVN Northbound database: OVN_Northbound.NB_Global.options.dbctl_inactivity_probe for ovn-nbctl and ovn-sbctl utilities. If no DB configuration option was provided, the initial (12 ms) interval is left. Signed-off-by: Vladislav Odintsov --- lib/ovn-util.h

Re: [ovs-dev] [PATCH ovn] utilities: disable OVSDB inactivity probes for non-daemon ovn-nbctl

2023-04-18 Thread Vladislav Odintsov
> On 18 Apr 2023, at 16:59, Dumitru Ceara wrote: > > On 4/14/23 15:37, Vladislav Odintsov wrote: >> Hi Dumitru, >> >>> On 13 Apr 2023, at 11:55, Dumitru Ceara wrote: >>> >>> Hi Vladislav, >>> >>> On 4/3/23 12:08, Ilya Maxi

Re: [ovs-dev] [PATCH ovn] utilities: disable OVSDB inactivity probes for non-daemon ovn-nbctl

2023-04-14 Thread Vladislav Odintsov
Hi Dumitru, > On 13 Apr 2023, at 11:55, Dumitru Ceara wrote: > > Hi Vladislav, > > On 4/3/23 12:08, Ilya Maximets wrote: >> On 3/31/23 17:17, Dumitru Ceara wrote: >>> On 3/31/23 16:51, Vladislav Odintsov wrote: >>>> As I understood from Ilya, in case

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-04-14 Thread Vladislav Odintsov
al_ids:ovn-openflow-probe-interval "60" > On 30 Mar 2023, at 23:19, Vladislav Odintsov wrote: > > Hi all, > > I’m facing a false positive failover in the event of openflow connection got > dropped after inactivity probe timeout due to high load of ovn-controller &

Re: [ovs-dev] [PATCH ovn] utilities: disable OVSDB inactivity probes for non-daemon ovn-nbctl

2023-03-31 Thread Vladislav Odintsov
Ceara wrote: > > On 3/31/23 14:46, Vladislav Odintsov wrote: >> Hi Dumitru, >> >>> On 31 Mar 2023, at 15:01, Dumitru Ceara wrote: >>> >>> On 3/31/23 11:43, Ales Musil wrote: >>>> On Thu, Mar 23, 2023 at 8:25 PM Vladislav Odintsov >>&g

Re: [ovs-dev] [PATCH ovn] utilities: disable OVSDB inactivity probes for non-daemon ovn-nbctl

2023-03-31 Thread Vladislav Odintsov
Hi Dumitru, > On 31 Mar 2023, at 15:01, Dumitru Ceara wrote: > > On 3/31/23 11:43, Ales Musil wrote: >> On Thu, Mar 23, 2023 at 8:25 PM Vladislav Odintsov >> wrote: >> >>> For large OVN_Southbound DBs defatult interval of 5000 ms could be not >&g

Re: [ovs-dev] [PATCH] ovsdb: add unixctl cmd to show memory-trim-on-compaction setting

2023-03-30 Thread Vladislav Odintsov
> On 21 Mar 2023, at 17:01, Ilya Maximets wrote: > > On 3/20/23 13:51, Vladislav Odintsov wrote: >> No, my usecase with 2.17 is that I just want to check agains a running >> process wether memory compaction is enabled or not without searching >> specific line in log

[ovs-dev] [ovn] ha-chassis-group false positive failover

2023-03-30 Thread Vladislav Odintsov
ng on try to release unknown interface, which was relased right before. Is it normal situation or also should be investigated? Thanks. Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn 0/6] Inactivity probe configuration for ic, controller-vtep

2023-03-23 Thread Vladislav Odintsov
Hi Numan, thanks for the review and patches applying. I’ve re-submitted the last patch here: https://patchwork.ozlabs.org/project/ovn/patch/20230323192520.3903330-1-odiv...@gmail.com/ > On 23 Mar 2023, at 22:15, Numan Siddique wrote: > > On Sat, Mar 18, 2023 at 7:50 PM Vladislav

[ovs-dev] [PATCH ovn] utilities: disable OVSDB inactivity probes for non-daemon ovn-nbctl

2023-03-23 Thread Vladislav Odintsov
For large OVN_Southbound DBs defatult interval of 5000 ms could be not sufficient. This patch disables OVSDB inactivity probes for ovn-*ctl running in non-daemon mode. Signed-off-by: Vladislav Odintsov --- utilities/ovn-dbctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utilities

Re: [ovs-dev] [PATCH] ovsdb: add unixctl cmd to show memory-trim-on-compaction setting

2023-03-20 Thread Vladislav Odintsov
No, my usecase with 2.17 is that I just want to check agains a running process wether memory compaction is enabled or not without searching specific line in logs, which in addition can be rotated. > On 20 Mar 2023, at 15:27, Ilya Maximets wrote: > > On 3/20/23 13:20, Vladislav Odint

Re: [ovs-dev] [PATCH] ovsdb: add unixctl cmd to show memory-trim-on-compaction setting

2023-03-20 Thread Vladislav Odintsov
. At least in versions were it’s off by default. > On 20 Mar 2023, at 15:07, Ilya Maximets wrote: > > On 3/20/23 10:24, Vladislav Odintsov wrote: >> In commit [1] there was added support to enable memory trimming on OVSDB tlog >> compation. However there was no option to get

[ovs-dev] [PATCH] ovsdb: add unixctl cmd to show memory-trim-on-compaction setting

2023-03-20 Thread Vladislav Odintsov
1: https://github.com/openvswitch/ovs/commit/f38f98a2c0dd7fcaf20fbe11d1e67a9b2afc0b2a Signed-off-by: Vladislav Odintsov --- NEWS | 4 ovsdb/ovsdb-server.c | 28 2 files changed, 32 insertions(+) diff --git a/NEWS b/NEWS index 72b9024e6..8515f4aaa 10

[ovs-dev] [PATCH ovn 7/6] utilities: disable OVSDB inactivity probes for non-daemon ovn-nbctl

2023-03-18 Thread Vladislav Odintsov
For large OVN_Southbound DBs default interval of 5000 ms could be not sufficient. This patch disables OVSDB inactivity probes for ovn-{n,s}ctl running in non-daemon mode. Signed-off-by: Vladislav Odintsov --- utilities/ovn-dbctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a

Re: [ovs-dev] [PATCH ovn 1/6] controller, northd: move inactivity probe configuration to lib/

2023-03-18 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov > On 19 Mar 2023, at 02:50, Vladislav Odintsov wrote: > > ovn-northd and ovn-controller had similar code to configure inactivity > probe interval. This patch moves common logic to lib/ovn-util module. > --- > controller/ovn-controller.c |

[ovs-dev] [PATCH ovn 4/6] controller-vtep: add unixctl commands to show DB connection status

2023-03-18 Thread Vladislav Odintsov
New unixctl commands were added: - sb-connection-status - vtep-connection-status Signed-off-by: Vladislav Odintsov --- controller-vtep/ovn-controller-vtep.c | 5 + 1 file changed, 5 insertions(+) diff --git a/controller-vtep/ovn-controller-vtep.c b/controller-vtep/ovn-controller-vtep.c

[ovs-dev] [PATCH ovn 6/6] NEWS: add info about ic/controller-vtep inactivity probe support

2023-03-18 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index 637adcff3..fc1b68324 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,8 @@ Post v23.03.0 - - Enhance LSP.options:arp_proxy to support IPv6, configurable MAC addresses

[ovs-dev] [PATCH ovn 5/6] ovn-ic: add unixctl commands to report db connection status

2023-03-18 Thread Vladislav Odintsov
New unixctl commands were added: - nb-connection-status - sb-connection-status - ic-nb-connection-status - ic-sb-connection-status Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 9 + 1 file changed, 9 insertions(+) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index feb100859..6f31037ec

[ovs-dev] [PATCH ovn 3/6] controller-vtep: add support to configure inactivity probe interval

2023-03-18 Thread Vladislav Odintsov
This patch adds new configuration option for ovn-controller-vtep service to supply OVSDB (only OVN_Southbound DB) probe interval value. It can be configured through Hardware_Vtep database, Global table, column other_config:ovn-remote-probe-interval. Signed-off-by: Vladislav Odintsov

[ovs-dev] [PATCH ovn 2/6] ic: add support to configure ovsdb inactivity probe

2023-03-18 Thread Vladislav Odintsov
: Vladislav Odintsov --- ic/ovn-ic.c | 28 ovn-ic-nb.xml | 14 ++ ovn-nb.xml| 13 + 3 files changed, 55 insertions(+) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index 1d0a062f6..feb100859 100644 --- a/ic/ovn-ic.c +++ b/ic/ovn-ic.c @@ -35,6 +35,7

[ovs-dev] [PATCH ovn 1/6] controller, northd: move inactivity probe configuration to lib/

2023-03-18 Thread Vladislav Odintsov
ovn-northd and ovn-controller had similar code to configure inactivity probe interval. This patch moves common logic to lib/ovn-util module. --- controller/ovn-controller.c | 8 ++-- lib/ovn-util.c | 22 ++ lib/ovn-util.h | 4 northd/ovn-no

[ovs-dev] [PATCH ovn 0/6] Inactivity probe configuration for ic, controller-vtep

2023-03-18 Thread Vladislav Odintsov
added to ovn-ic and ovn-controller-vtep. Vladislav Odintsov (6): controller,northd: move inactivity probe configuration to lib/ ic: add support to configure ovsdb inactivity probe controller-vtep: add support to configure inactivity probe interval controller-vtep: add unixctl commands to

Re: [ovs-dev] [PATCH ovn] rhel: pass options to stop daemon command in systemd units

2023-03-08 Thread Vladislav Odintsov
Thanks Dumitru! > On 8 Mar 2023, at 15:45, Dumitru Ceara wrote: > > On 3/7/23 10:19, Ales Musil wrote: >> On Mon, Feb 27, 2023 at 7:41 PM Vladislav Odintsov >> wrote: >> >>> This patch fixes ovn-northd.service and ovn-db@.service systemd units >>>

[ovs-dev] [PATCH ovn] rhel: pass options to stop daemon command in systemd units

2023-02-27 Thread Vladislav Odintsov
ed by ovn-db@nb / ovn-db@sb or manually with ovn-ctl, so ovsdb-server processes for these services will be unexpectedly stopped. Fixes: 497ec3fdfbdb ("rhel: add ovn-db@.service systemd-unit") Signed-off-by: Vladislav Odintsov --- rhel/usr_lib_systemd_system_ovn-db

Re: [ovs-dev] [PATCH v3] utilities: add support to set umask in ovs-ctl

2023-02-20 Thread Vladislav Odintsov
Thanks, Ilya! > On 20 Feb 2023, at 22:21, Ilya Maximets wrote: > > On 2/15/23 22:20, Vladislav Odintsov wrote: >> Hi Ilya, >> >> Thats my bad - they were the initial names of options, which I renamed later >> and missed this place before sending a patch. >

Re: [ovs-dev] [PATCH v3] utilities: add support to set umask in ovs-ctl

2023-02-15 Thread Vladislav Odintsov
Hi Ilya, Thats my bad - they were the initial names of options, which I renamed later and missed this place before sending a patch. I’m absolutely fine with proposed change. Please fold it while applying the patch. Thanks. regards, Vladislav Odintsov > On 15 Feb 2023, at 22:25, Ilya Maxim

Re: [ovs-dev] [PATCH v2] utilities: add support to set umask in ovs-ctl

2023-02-10 Thread Vladislav Odintsov
Thanks Eelco, requested changes addressed here: https://patchwork.ozlabs.org/project/openvswitch/patch/20230210160229.3689298-1-odiv...@gmail.com/ > On 10 Feb 2023, at 11:21, Eelco Chaudron wrote: > > > > On 8 Feb 2023, at 16:22, Vladislav Odintsov wrote: > >> Thi

[ovs-dev] [PATCH v3] utilities: add support to set umask in ovs-ctl

2023-02-10 Thread Vladislav Odintsov
tchd-umask=0002" will set umask to ovs-vswitchd daemon. Previous behaviour (not setting umask) is left as default. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2023-January/401501.html Signed-off-by: Vladislav Odintsov --- v2 -> v3: - addressed Eelco's review comment

Re: [ovs-dev] [PATCH] utilities: add support to set umask in ovs-ctl

2023-02-08 Thread Vladislav Odintsov
ote: > > > > On 7 Feb 2023, at 16:04, Vladislav Odintsov wrote: > >> Thanks for the review, Eelco! >> Answers are inline. >> >>> On 7 Feb 2023, at 17:02, Eelco Chaudron wrote: >>> >>> See some comments inline below. >>> >>

[ovs-dev] [PATCH v2] utilities: add support to set umask in ovs-ctl

2023-02-08 Thread Vladislav Odintsov
tchd-umask=0002" will set umask to ovs-vswitchd daemon. Previous behaviour (not setting umask) is left as default. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2023-January/401501.html Signed-off-by: Vladislav Odintsov --- v1 -> v2: - added item in NEWS file as Ilya'

Re: [ovs-dev] [PATCH] utilities: add support to set umask in ovs-ctl

2023-02-07 Thread Vladislav Odintsov
Thanks for the review, Eelco! Answers are inline. > On 7 Feb 2023, at 17:02, Eelco Chaudron wrote: > > See some comments inline below. > > Cheers, > > Eelco > > On 27 Jan 2023, at 14:29, Vladislav Odintsov wrote: > >> This patch adds a new ovs-ctl option

Re: [ovs-dev] [PATCH] utilities: add support to set umask in ovs-ctl

2023-02-07 Thread Vladislav Odintsov
Hi, sure, no problem. Should I do in a separate patch or incorporate into this one? > On 7 Feb 2023, at 15:35, Ilya Maximets wrote: > > On 1/27/23 14:29, Vladislav Odintsov wrote: >> This patch adds a new ovs-ctl option to pass umask configuration to allow >> OVS dae

Re: [ovs-dev] Wrong unix socket file permissions

2023-01-27 Thread Vladislav Odintsov
I’ve sent a patch [0], please take a look on it when you have time. 0: https://patchwork.ozlabs.org/project/openvswitch/patch/20230127132950.3670502-1-odiv...@gmail.com/ > On 27 Jan 2023, at 13:14, Ilya Maximets wrote: > > On 1/27/23 10:25, Vladislav Odintsov wrote: >> What do

[ovs-dev] [PATCH] utilities: add support to set umask in ovs-ctl

2023-01-27 Thread Vladislav Odintsov
to ovs sockets from that user. Previous behaviour (not setting umask) is left as default. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2023-January/401501.html Signed-off-by: Vladislav Odintsov --- utilities/ovs-ctl.in | 8 1 file changed, 8 insertions(+) diff --git a

Re: [ovs-dev] Wrong unix socket file permissions

2023-01-27 Thread Vladislav Odintsov
/utilities/ovs-ctl.in @@ -544,6 +544,7 @@ do done case $command in start) +umask 0002 start_ovsdb || exit 1 start_forwarding || exit 1 add_managers > On 26 Jan 2023, at 14:30, Ilya Maximets wrote: > > On 1/25/23 17:35, Vladislav Odint

Re: [ovs-dev] Wrong unix socket file permissions

2023-01-25 Thread Vladislav Odintsov
Regards, Vladislav Odintsov > On 25 Jan 2023, at 19:16, Ilya Maximets wrote: > > On 1/25/23 16:15, Vladislav Odintsov wrote: >> Hi, >> >> I’m a bit confused about linux unix socket files permissions, created by ovs >> daemons. >> >> From sour

[ovs-dev] Wrong unix socket file permissions

2023-01-25 Thread Vladislav Odintsov
-unix.c#L264 Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [OVN RFC 0/7] OVN IC bugfixes & proposals/questions

2023-01-24 Thread Vladislav Odintsov
Thanks Ilya for the quick and useful response! We’ll dig into monitor/db_change_aware logic. Regards, Vladislav Odintsov > On 24 Jan 2023, at 17:00, Ilya Maximets wrote: > > On 1/24/23 14:12, Vladislav Odintsov wrote: >> Hi Ilya, >> >> could you please take a loo

Re: [ovs-dev] [OVN RFC 0/7] OVN IC bugfixes & proposals/questions

2023-01-24 Thread Vladislav Odintsov
Hi Ilya, could you please take a look on this? Maybe you can advice any direction how to investigate this issue? Thanks in advance. Regards, Vladislav Odintsov > On 24 Nov 2022, at 21:10, Anton Vazhnetsov wrote: > > Hi, Terry! > > In continuation to our yesterday’s conversati

Re: [ovs-dev] [PATCH ovn v2 1/2] northd: make traffic routed to vtep lport distributed

2023-01-23 Thread Vladislav Odintsov
Thanks Dumitru! Regards, Vladislav Odintsov > On 23 Jan 2023, at 17:58, Dumitru Ceara wrote: > > On 1/23/23 10:15, Simon Horman wrote: >> On Sat, Jan 21, 2023 at 07:46:07PM +0300, Vladislav Odintsov wrote: >>> There were two issues prior to this patch: >>> 1. I

Re: [ovs-dev] [PATCH ovn v3 0/4] Add support for OVSDB Relay in OVN SB DB

2023-01-23 Thread Vladislav Odintsov
Thanks Dumitru! Regards, Vladislav Odintsov > On 23 Jan 2023, at 17:59, Dumitru Ceara wrote: > > On 1/21/23 15:54, Vladislav Odintsov wrote: >> v2->v3: >> - Address Dumitru's comment regarding wrong %systemd_postun rpm macro >> usage. >> - Reb

Re: [ovs-dev] [PATCH ovn 1/2] northd: make traffic routed to vtep lport distributed

2023-01-21 Thread Vladislav Odintsov
Please check out the v2: https://patchwork.ozlabs.org/project/ovn/patch/20230121164609.3625347-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 21 Jan 2023, at 15:47, Vladislav Odintsov wrote: > > Hi Simon, > > thanks for the review. > I agree with all your comments and

[ovs-dev] [PATCH ovn v2 2/2] northd: fix typo in consider_l3d{wg, gw}... function

2023-01-21 Thread Vladislav Odintsov
This patch fixes typo in consider_l3dgw_port_is_centralized() function. Signed-off-by: Vladislav Odintsov Reviewed-by: Simon Horman --- northd/northd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index 46ed39850..bc2d79164 100644

<    1   2   3   4   5   6   >