Hi Yi-Hung,
Thanks for your review.
On Wed, Apr 22, 2020 at 03:52:20PM -0700, Yi-Hung Wei wrote:
> On Sun, Apr 19, 2020 at 9:05 AM William Tu wrote:
> >
> > Commit 1f1613183733 ("ct-dpif, dpif-netlink: Add conntrack timeout
> > policy support") adds conntrack tim
On Fri, Apr 17, 2020 at 02:51:34PM +0200, Eelco Chaudron wrote:
> This adds the ovs_dump_ifpacts command:
>
> (gdb) help ovs_dump_ofpacts
> Dump all actions in an ofpacts set
> Usage: ovs_dump_ofpacts
>
> : Pointer to set of ofpact structures.
> : Total length of the set
On Thu, Apr 23, 2020 at 05:35:14AM +, 姜立东 via dev wrote:
> From df9ff3b67f11e467928ca0873031d81b87f3d0c5 Mon Sep 17 00:00:00 2001
> From: Jiang Lidong
> Date: Thu, 23 Apr 2020 11:07:28 +0800
> Subject: [PATCH] netdev-linux: remove sum of vport stats and kernel netdev
> stats
> When using
On Fri, Apr 24, 2020 at 02:54:00PM +0530, Martin Varghese wrote:
> On Fri, Apr 24, 2020 at 01:06:21AM -0700, Pravin Shelar wrote:
> > On Sun, Apr 19, 2020 at 8:11 PM Martin Varghese
> > wrote:
> > >
> > > From: Martin Varghese
> > >
> > > UDP tunnel encapsulation module for tunnelling different p
On Fri, Apr 24, 2020 at 3:06 AM Eelco Chaudron wrote:
>
>
>
> On 23 Apr 2020, at 17:32, William Tu wrote:
>
> > On Thu, Apr 23, 2020 at 6:29 AM Eelco Chaudron
> > wrote:
> >>
> >> Hi Ben et al.
> >>
> >> We recently had an issue
On Thu, Apr 23, 2020 at 6:29 AM Eelco Chaudron wrote:
>
> Hi Ben et al.
>
> We recently had an issue where OVS would crash as it was running out of
> stack space processing an OVN flow loop :) I was hoping it would jump
> out of the loop, but due to change, "790c5d269 ofproto-dpif: Do not
> count
On Tue, Apr 21, 2020 at 3:24 PM Yi-Hung Wei wrote:
>
> ovsdb_function_from_string() and ovsdb_function_to_string() are defined
> both in ovsdb/condition.c and lib/ovsdb-condidtion.c with the same function
> definition. Remove the one in ovsdb/condition.c to avoid duplication.
>
> This also resolv
On Tue, Apr 21, 2020 at 09:23:57AM +0100, anton.iva...@cambridgegreys.com wrote:
> From: Anton Ivanov
>
> We do not check metadata - mtime, atime, anywhere, so we
> do not need to update it every time we sync the log.
> if the system supports it, the log update should be
> data only
>
> Signed-o
On Tue, Apr 21, 2020 at 01:33:55PM +0200, Eelco Chaudron wrote:
> Signed-off-by: Eelco Chaudron
> ---
Applied to master, thanks!
Should we backport?
William
> utilities/gdb/ovs_gdb.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/utilities/gdb/ovs_gdb.py b/utilities/gdb/ovs_gdb.py
>
On Tue, Apr 21, 2020 at 09:24:38AM +0100, anton.iva...@cambridgegreys.com wrote:
> From: Anton Ivanov
>
> Avoid grabbing any mutexes if the log levels specify that
> no logging is to take place.
>
> Signed-off-by: Anton Ivanov
> ---
Looks good to me, thanks
Acked-by: Willi
x-gnu/libc.so.6
(gdb) source utilities/gdb/ovs_gdb.py
File "utilities/gdb/ovs_gdb.py", line 62
from __future__ import print_function
SyntaxError: from __future__ imports must occur at the beginning of the file
(gdb)
William
>
>
> On 20 Apr 2020, at 15:27, Eelco Chaudron w
On Mon, Apr 20, 2020 at 10:02:15AM +0200, Eelco Chaudron wrote:
>
>
> On 19 Apr 2020, at 17:58, William Tu wrote:
>
> >On Fri, Apr 17, 2020 at 02:51:34PM +0200, Eelco Chaudron wrote:
> >>This adds the ovs_dump_ifpacts command:
> >>
> >>(gdb) hel
On Tue, Apr 14, 2020 at 03:55:55PM -0700, Yifeng Sun wrote:
> Thanks for fixing gcc10, looks good to me.
>
> Tested-by: Yifeng Sun
>
> Reviewed-by: Yifeng Sun
>
Thanks, I applied to master.
William
___
dev mailing list
d...@openvswitch.org
https://m
r ICMP and UDP cases.
Signed-off-by: William Tu
---
v3:
- address feedback from Yi-Hung
- use ID 0 as default policy
- move conn_{init,update}_expiration to lib/conntrack-tp.c
- s/tpid/tp_id/
- add default timeout value to CT_DPIF_TP_*_ATTRs
- reduce the CT_CLEAN_INTERVAL f
On Fri, Apr 17, 2020 at 02:51:34PM +0200, Eelco Chaudron wrote:
> This adds the ovs_dump_ifpacts command:
>
> (gdb) help ovs_dump_ofpacts
> Dump all actions in an ofpacts set
> Usage: ovs_dump_ofpacts
>
> : Pointer to set of ofpact structures.
> : Total length of the set
on to remove a value in
> tun_metadata if the value is present. This patch fulfills the gap
> by adding the delete_field action. For example, the OpenFlow
> syntax to delete tun_metadata1 is:
>
> actions=delete_field:tun_metadata1
>
> Signed-off-by: Yi-Hung Wei
> ---
LG
On Fri, Apr 17, 2020 at 09:21:55AM -0700, Yi-Hung Wei wrote:
> On Thu, Apr 16, 2020 at 12:55 PM William Tu wrote:
> >
> > Add a coverage counter when userspace conntrack receives a packet
> > with invalid l4 checksum. When using veth for testing, users
> > often forget
On Mon, Feb 10, 2020 at 01:48:53PM +, Ciara Loftus wrote:
> If RTE_LIBRTE_PMD_PCAP is enabled in the DPDK build, OVS must link
> the pcap library, otherwise build failures will occur.
>
> Signed-off-by: Ciara Loftus
Applied to master, thanks.
___
d
On Mon, Feb 10, 2020 at 01:48:54PM +, Ciara Loftus wrote:
> If RTE_LIBRTE_AF_XDP is enabled in the DPDK build, OVS must link
> the libbpf library, otherwise build failures will occur.
>
> Signed-off-by: Ciara Loftus
Applied to master, thanks.
___
d
On Fri, Apr 17, 2020 at 9:02 AM Ilya Maximets wrote:
>
> On 4/17/20 3:14 PM, William Tu wrote:
> > When enabling RTE_LIBRTE_PMD_PCAP in DPDK, we need to link the libpcap
> > library, otherwise 'make' will fail. I'm using this for creating a
> > pcap-based
Signed-off-by: William Tu
---
acinclude.m4 | 4
1 file changed, 4 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index 0901f2870239..fd139ec9ea36 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -359,6 +359,10 @@ AC_DEFUN([OVS_CHECK_DPDK], [
AC_DEFINE([VHOST_NUMA], [1], [NUMA Awar
conntrack state.
Suggested-by: Yi-Hung Wei
Signed-off-by: William Tu
---
v2: add also icmp csum error
---
lib/conntrack.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 0cbc8f6d2b25..95d48c5eecae 100644
--- a/lib/conntrack.c
+++ b/lib
On Thu, Apr 16, 2020 at 10:35 AM Yi-Hung Wei wrote:
>
> On Thu, Apr 16, 2020 at 7:17 AM William Tu wrote:
> >
> > Add a coverage counter when userspace conntrack receives a packet
> > with invalid l4 checksum. When using veth for testing, users
> > often forget to
conntrack state.
Suggested-by: Yi-Hung Wei
Signed-off-by: William Tu
---
lib/conntrack.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 0cbc8f6d2b25..98a62ce3bae6 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -44,6 +44,7 @@ VLOG_DEFINE_THIS_MODULE
On Fri, Feb 28, 2020 at 7:34 AM Ilya Maximets wrote:
>
> On 2/14/20 2:03 PM, Flavio Leitner wrote:
> > This patchset disables unsupported offload features for vhost
> > device such as UFO and ECN.
> >
> > Then it includes UDP checksum offload as a must have to enable
> > userspace TSO, but leave S
On Mon, Apr 13, 2020 at 4:32 PM Yi-Hung Wei wrote:
>
> On Tue, Apr 7, 2020 at 2:08 PM William Tu wrote:
> >
> > Commit 1f1613183733 ("ct-dpif, dpif-netlink: Add conntrack timeout
> > policy support") adds conntrack timeout policy for kernel datapath.
>
On Tue, Apr 14, 2020 at 05:45:14PM -0700, Yifeng Sun wrote:
> LGTM, thanks Greg.
>
> Reviewed-by: Yifeng Sun
>
Applied to master, thanks Greg and Yifeng.
William
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/o
531098
0x51aefc
0x445ca9
0x5056fd
0x7f4e2b65f6ba
0x7f4e2ac6941d
0x0 <+0x0>
Tested-at: https://travis-ci.org/github/williamtu/ovs-travis/builds/674901331
Signed-off-by: William Tu
---
v3:
- use memcpy to avoid gcc10 warning b
On Mon, Apr 13, 2020 at 3:37 PM Yifeng Sun wrote:
>
> Thanks, looks good to me.
>
> Tested-by: Yifeng Sun
>
> Reviewed-by: Yifeng Sun
>
>
> On Wed, Mar 25, 2020 at 11:51 AM William Tu wrote:
>>
>> Function snprintf is not async-signal-safe. Replace it w
00% when there is no traffic.
Signed-off-by: William Tu
---
v5:
- add NETDEV_AFXDP_CLASS_COMMON
v4:
- Previously crash and fix it with qid = qid % netdev_n_txq(netdev)
Now remove it because Ilya's fix:
"dpif-netdev: Force port reconfiguration to change dynamic_txqs.&qu
On Mon, Apr 13, 2020 at 9:26 AM Yifeng Sun wrote:
>
> Looks good to me, thanks.
>
> Reviewed-by: Yifeng Sun
>
Applied to master, thanks
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Apr 13, 2020 at 3:20 PM Ilya Maximets wrote:
>
> On 3/25/20 10:44 PM, William Tu wrote:
> > The patch adds a new netdev class 'afxdp-nonpmd' to enable afxdp
> > interrupt mode. This is similar to 'type=afxdp', except that the
> > is_pmd fi
On Mon, Apr 13, 2020 at 2:02 AM Yi Yang (杨燚)-云服务集团 wrote:
>
> Hi, William
>
> As you have known, I sent out a tpacket_v3 kernel side patch to net-next,
> tpacket maintainer worries it can impact on other use cases, so he hopes we
> can use TPACKET_V2 for TSO, I tried TPACKET_V2 for TSO, it is in
Need to free the memory before return. Detected by gcc10.
Signed-off-by: William Tu
---
lib/ofp-actions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index ef8b2b4527f9..a94d1a7ca918 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -5966,6
On Sat, Apr 11, 2020 at 10:18 AM Ravi Kerur wrote:
>
> Hi William,
>
> On Fri, Apr 10, 2020 at 7:06 AM William Tu wrote:
>>
>> On Thu, Apr 09, 2020 at 02:14:26PM -0700, Ravi Kerur wrote:
>> > Hi OvS DPDK team,
>> >
>> > I am looking at ixgbe_
On Sat, Apr 11, 2020 at 10:20 AM Ravi Kerur wrote:
>
>
>
> On Thu, Apr 9, 2020 at 8:45 PM William Tu wrote:
>>
>> On Wed, Jul 17, 2019 at 4:25 PM Ravi Kerur wrote:
>> >
>> > Hi,
>> >
>> > I am sending this email to gauge if OVS team or
On Fri, Apr 10, 2020 at 06:02:47PM +0800, xiangxia.m@gmail.com wrote:
> From: Tonghao Zhang
>
> When offloading the flows which matching the vlan feild,
> there is an error[1]. Then we can't offload them, though
> TC flower supports this. To fix it, we should use the
> *dl_type_is_ip_any* ins
Hi Yi-Hung,
I read through the patch and have some questions and comments.
On Fri, Apr 10, 2020 at 01:05:24PM -0700, Yi-Hung Wei wrote:
> This patch adds a new OpenFlow action, delete field, to delete a
> field in packets. Currently, only the tun_metadata fields are
> supported.
>
> One use cas
On Fri, Apr 10, 2020 at 02:54:41PM -0700, William Tu wrote:
> On Thu, Apr 09, 2020 at 11:37:39AM -0700, Yifeng Sun wrote:
> > This patch enhances a system traffic test to prevent regression on
> > the tunnel metadata table (tun_table) handling with frozen state.
> > Without a
On Thu, Apr 09, 2020 at 11:37:39AM -0700, Yifeng Sun wrote:
> This patch enhances a system traffic test to prevent regression on
> the tunnel metadata table (tun_table) handling with frozen state.
> Without a proper fix this test can crash ovs-vswitchd due to a
> use-after-free bug on tun_table.
>
On Thu, Apr 09, 2020 at 11:37:38AM -0700, Yifeng Sun wrote:
> Tun_metadata can be referened by flow and frozen_state at the same
> time. When ovs-vswitchd handles TLV table mod message, the involved
> tun_metadata gets freed. The call trace to free tun_metadata is
> shown as below:
>
> ofproto_run
On Thu, Apr 09, 2020 at 02:14:26PM -0700, Ravi Kerur wrote:
> Hi OvS DPDK team,
>
> I am looking at ixgbe_set_rx_function and ixgbe_set_tx_function and would
> like to enable vectorized packet handling. Looking at ixgbe_set_rx_function
Do you mean this "27.1. Vector PMD for IXGBE"?
https://doc.dp
On Wed, Jul 17, 2019 at 4:25 PM Ravi Kerur wrote:
>
> Hi,
>
> I am sending this email to gauge if OVS team or community using OVS would
> be interested in this effort. I read some discussions which had happened
> couple of years back with OVS and Qosmos integration and at least it looked
> like OV
On Wed, Mar 25, 2020 at 05:33:51PM -0700, William Tu wrote:
> On Thu, Mar 19, 2020 at 12:20:19PM -0700, William Tu wrote:
> > On Thu, Mar 19, 2020 at 12:05 PM Timothy Redaelli
> > wrote:
> > >
> > > Currently ovs-bugtool tool doesn't start on Python 3.
>
included in calculation
> of meter bucket to make it more precise.
>
> Signed-off-by: Jiang Lidong
>
> Acked-by: William Tu
Applied to master, thanks.
William
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Apr 08, 2020 at 11:59:25PM +0800, Tonghao Zhang wrote:
> On Wed, Apr 8, 2020 at 11:09 PM William Tu wrote:
> >
> > On Wed, Apr 01, 2020 at 06:50:09PM +0800, Tonghao Zhang wrote:
> > > On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote:
> > > >
>
On Mon, Mar 30, 2020 at 08:54:00PM +0800, Lance Yang wrote:
> In order to increase CI coverage for arm, the patches enabled clang and
> testsuite jobs (skipped some UT cases on arm temporarily) by modifying
> the existing arm CI jobs. This does not add any extra jobs.
>
> Lance Yang (1):
> [ovs-
On Wed, Apr 8, 2020 at 8:16 AM Yifeng Sun wrote:
>
> ovsrcu_set() is not necessary here because frozen_flow is on stack.
>
Ok, thanks.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Apr 01, 2020 at 06:50:09PM +0800, Tonghao Zhang wrote:
> On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote:
> >
> > On Sun, Mar 29, 2020 at 5:35 PM Tonghao Zhang
> > wrote:
> > >
> > > On Mon, Mar 30, 2020 at 12:46 AM Pravin Shelar wrote:
> > > >
> > > > On Sat, Mar 28, 2020 at 8:46
On Tue, Apr 07, 2020 at 02:57:03PM -0700, Yi-Hung Wei wrote:
> On Tue, Apr 7, 2020 at 2:50 PM Yifeng Sun wrote:
> >
> > Tun_metadata can be referened by flow and frozen_state at the same
> > time. When ovs-vswitchd handles TLV table mod message, the involved
> > tun_metadata gets freed. The call t
Hi Patrick,
Thanks for trying this feature.
On Wed, Apr 08, 2020 at 08:44:19AM +0200, Patrick Talbert wrote:
> Hello,
>
> The kernel grew support for a ct action "timeout" property here:
>
> openvswitch: Add timeout support to ct action
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds
aarch64
>
> .travis.yml| 9 -
> tests/atlocal.in | 10 ++
> tests/bfd.at | 1 +
> tests/ovsdb-idl.at | 1 +
> 4 files changed, 16 insertions(+), 5 deletions(-)
>
> --
Thanks for the patch.
On Tue, Apr 07, 2020 at 11:09:33AM -0700, Archana Holla via dev wrote:
> OVS_TYPEOF macro doesn’t return the type of object for non __GNUC__ platforms.
> Updating it to use "decltype" keyword when used from C++ code.
>
> Signed-off-by: Archana Holla
looks good to me, thanks
I applied to master.
On Tue, Apr 07, 2020 at 10:47:50AM -0700, Gregory Rose wrote:
>
>
> On 4/6/2020 4:59 PM, William Tu wrote:
> >Currently the userspace datapath implements conntrack ICMP reply state
> >as when ICMP packets have been seen on both directions. However, the
> >descripti
r ICMP and UDP cases.
Signed-off-by: William Tu
---
v2:
- enable icmp_reply timeout for userspace datapath
- travis: https://travis-ci.org/github/williamtu/ovs-travis/builds/672248069
---
Documentation/faq/releases.rst | 2 +-
NEWS | 2 +
lib/automake.mk
hen passes
this information back to handle_packet_upcall, and save the packet at
a list. And every time when hitting handle_packet_upcall, flush the list
first.
I feel this is a little complicated and there might be a better solution?
Regards,
William
On Wed, Mar 11, 2020 at 11:59 AM William Tu
included in calculation
> of meter bucket to make it more precise.
>
> Signed-off-by: Jiang Lidong
one minor typo s/microsendcond/microsecond/
Otherwise, looks good to me, thanks!
Acked-by: William Tu
> ---
> lib/dpif-netdev.c | 5 +
> 1 file changed, 5 insertions(+)
>
On Mon, Apr 6, 2020 at 8:47 AM William Tu wrote:
>
> On Thu, Mar 26, 2020 at 12:58:21PM -0700, Yifeng Sun wrote:
> > Tun_metadata can be referened by flow and frozen_state at the same
> > time. When ovs-vswitchd handles TLV table mod message, the involved
> > tun_metad
: Add Datapath, CT_Zone, and CT_Zone_Policy
tables.")
Signed-off-by: William Tu
---
vswitchd/vswitch.xml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index f9339af85edd..6d334370d252 100644
--- a/vswitchd/vswitch.xml
+++
On Wed, Apr 1, 2020 at 3:33 PM wrote:
>
> From: Usman Ansari
>
> Coverity reports unreachable code in "?" statement
> Fixed by removing code segment and unused variables & defines
>
> Signed-off-by: Usman Ansari
> ---
Applied to master, thanks
___
dev
The timeout value of icmp_reply is defined as timeout of the connection
after an ICMP error is replied in response to an ICMP packet. Currently
this is not implemented.
Fixes: 61a5264d60d0c ("ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy
tables.")
Signed-off-by:
On Mon, Apr 6, 2020 at 8:29 AM William Tu wrote:
>
> Hi Yifeng,
>
> Thanks for the patch, I can reproduce the issue using
> $ make check-system-userspace TESTSUITEFLAGS='-k resume'
> ASAN reports
> ==127707==ERROR: AddressSanitizer: heap-use-after-free on
On Thu, Mar 26, 2020 at 12:58:21PM -0700, Yifeng Sun wrote:
> Tun_metadata can be referened by flow and frozen_state at the same
> time. When ovs-vswitchd handles TLV table mod message, the involved
> tun_metadata gets freed. The call trace to free tun_metadata is
> shown as below:
>
> ofproto_run
Hi Yifeng,
Thanks for the patch, I can reproduce the issue using
$ make check-system-userspace TESTSUITEFLAGS='-k resume'
ASAN reports
==127707==ERROR: AddressSanitizer: heap-use-after-free on address
0x61f20690 at pc 0x0089cecf bp 0x7fff38f95690 sp
0x7fff38f95688
READ of size 4 at 0x61f00
Hi Hepeng,
Thanks for your reply. Can you re-send a separate v3 patch email?
I can't apply your patch to master.
Also some comment below
On Thu, Mar 26, 2020 at 7:21 PM 贺鹏 wrote:
>
> Hi, I rebase the patch on the latest master branch.
>
>
> From 07f10707699a39e3a6de68012dd6c0453120c543 Mon Sep
r ICMP and UDP cases.
Tested-at: https://travis-ci.org/github/williamtu/ovs-travis/builds/671278549
Signed-off-by: William Tu
---
Documentation/faq/releases.rst | 2 +-
NEWS | 2 +
lib/automake.mk | 2 +
lib/conntrack-icmp.c |
elps
> to solve at least this one kind of issues.
>
> Signed-off-by: Ilya Maximets
> ---
I tested it and LGTM.
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Sun, Mar 22, 2020 at 10:42:16AM +0800, 贺鹏 wrote:
> if the tunnel is specified as "remote_ip=flow", we can try to generate
> a megaflow
> which ignores all source address, such as source mac, source IP address
> in the outter header of the packet. This can reduce the number of
> megaflows and avo
On Tue, Mar 24, 2020 at 03:03:24PM -0700, William Tu wrote:
> GTP, GPRS Tunneling Protocol, is a group of IP-based communications
> protocols used to carry general packet radio service (GPRS) within
> GSM, UMTS and LTE networks. GTP protocol has two parts: Signalling
> (GTP-Control
On Thu, Mar 19, 2020 at 12:20:19PM -0700, William Tu wrote:
> On Thu, Mar 19, 2020 at 12:05 PM Timothy Redaelli
> wrote:
> >
> > Currently ovs-bugtool tool doesn't start on Python 3.
> > This commit fixes ovs-bugtool to make it works on Python 3.
> >
00% when there is no traffic.
Tested-at: https://travis-ci.org/github/williamtu/ovs-travis/builds/666980138
Signed-off-by: William Tu
---
v4:
- Previously crash and fix it with qid = qid % netdev_n_txq(netdev)
Now remove it because Ilya's fix:
"dpif-netdev: Force port reconfig
ange their 'dynamic_txqs' value.
> >
> > It looks like the issue could be reproduced only with afxdp ports,
> > because all other non-dpdk ports ignores Tx queue ids and dpdk ports
> > requests for reconfiguration on set_tx_multiq().
> >
> > Reported-by: Willi
531098
0x51aefc
0x445ca9
0x5056fd
0x7f4e2b65f6ba
0x7f4e2ac6941d
0x0 <+0x0>
Tested-at: https://travis-ci.org/github/williamtu/ovs-travis/builds/666875084
Signed-off-by: William Tu
---
v2:
- avoid strcat overflow buffer, s
On Wed, Mar 25, 2020 at 8:39 AM Ben Pfaff wrote:
>
> On Wed, Mar 25, 2020 at 07:34:13AM -0700, William Tu wrote:
> > Function snprintf is not async-signal-safe. Replace it with
> > our own implementation. Example ovs-vswitchd.log output:
> > 2020-03-25T01:08:19.673Z|00
On Wed, Mar 25, 2020 at 08:21:38AM -0700, William Tu wrote:
> On Wed, Mar 25, 2020 at 10:08:14AM -0400, Tim Rozet wrote:
> > Hi All,
> > I've run into this question several times, and several folks have different
> > opinions. I was hoping we could resolve it. The quest
On Wed, Mar 25, 2020 at 10:08:14AM -0400, Tim Rozet wrote:
> Hi All,
> I've run into this question several times, and several folks have different
> opinions. I was hoping we could resolve it. The question centers around
Me too. Thanks for bringing this up.
> having multiple OVS vswitchd instance
ly with afxdp ports,
> because all other non-dpdk ports ignores Tx queue ids and dpdk ports
> requests for reconfiguration on set_tx_multiq().
>
> Reported-by: William Tu
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2020-March/368364.html
> Fixes: e32971b8ddb4
On Wed, Mar 25, 2020 at 12:53:18AM +0100, Ilya Maximets wrote:
> On 3/6/20 5:11 PM, Ilya Maximets wrote:
> > On 3/4/20 7:09 PM, William Tu wrote:
> >> On Fri, Feb 28, 2020 at 12:12 AM Ilya Maximets wrote:
> >>>
> >>> On 2/27/20 8:52 PM, William Tu wrot
531098
0x51aefc
0x445ca9
0x5056fd
0x7f4e2b65f6ba
0x7f4e2ac6941d
0x0 <+0x0>
Tested-at: https://travis-ci.org/github/williamtu/ovs-travis/builds/666596271
Signed-off-by: William Tu
---
lib/fatal-s
packet
size, we see better performance.
Consider container to container use cases:
iperf3 -c (ns0) -> veth peer -> OVS -> veth peer -> iperf3 -s (ns1)
And I got around 6Gbps, similar to TSO with DPDK-enabled.
Signed-off-by: William Tu
Acked-by: Flavio Leitner
---
v9:
- make nam
Similar to using veth across namespaces, this patch creates
tap devices, assigns to namespaces, and allows traffic to
go through different test cases.
Signed-off-by: William Tu
Acked-by: Flavio Leitner
---
tests/automake.mk | 1 +
tests/system-tap.at | 34
:
https://tools.ietf.org/html/draft-hmm-dmm-5g-uplane-analysis-00
Signed-off-by: Feng Yang
Co-authored-by: Feng Yang
Signed-off-by: Yi Yang
Co-authored-by: Yi Yang
Signed-off-by: William Tu
Acked-by: Ben Pfaff
---
I tested it again and thinking about applying this patch if no more comments.
v7
On Tue, Mar 24, 2020 at 12:31:33PM -0700, Ben Pfaff wrote:
> On Tue, Mar 24, 2020 at 12:16:38PM -0700, William Tu wrote:
> > Pass lock objects, not their addresses, to the annotation macros.
> >
> > Signed-off-by: William Tu
>
> Acked-by:
Pass lock objects, not their addresses, to the annotation macros.
Signed-off-by: William Tu
---
lib/vlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vlog.c b/lib/vlog.c
index 6d17d4837e9c..ee6b0d3a620a 100644
--- a/lib/vlog.c
+++ b/lib/vlog.c
@@ -257,7 +257,7
On Tue, Mar 24, 2020 at 09:33:13AM -0700, Yi-Hung Wei wrote:
> On Tue, Mar 24, 2020 at 8:42 AM Greg Rose wrote:
> >
> > The extra development repo for RHEL 8 has changed. Document it.
> >
> > Signed-off-by: Greg Rose
> >
> > ---
> > V2 - Break long line
> > ---
> > Documentation/intro/install/f
On Tue, Mar 24, 2020 at 09:31:23AM -0700, Yi-Hung Wei wrote:
> On Tue, Mar 24, 2020 at 8:42 AM Greg Rose wrote:
> >
> > From: Greg Rose
> >
> > A RHEL release version check was only checking for RHEL releases
> > greater than 7.0 so that ended up including a compat fixup that
> > is not needed fo
focus=true
[1] https://github.com/features/actions
Signed-off-by: William Tu
---
.github/workflows/ovs.yml | 26 ++
Makefile.am | 1 +
2 files changed, 27 insertions(+)
create mode 100644 .github/workflows/ovs.yml
diff --git a/.github/workflows/ovs.yml
On Mon, Mar 23, 2020 at 06:54:29PM +0100, Ilya Maximets wrote:
> On 3/20/20 9:52 PM, William Tu wrote:
> > On Fri, Mar 20, 2020 at 7:32 AM Ilya Maximets wrote:
> >>
> >> On 3/20/20 12:56 AM, William Tu wrote:
> >>> This patch enables TSO support for non-D
On Tue, Mar 24, 2020 at 03:38:31PM +0100, Ilya Maximets wrote:
> On 3/24/20 3:27 PM, Ilya Maximets wrote:
> > On 3/24/20 3:17 PM, William Tu wrote:
> >> Due to not acquiring lock, clang reports:
> >> lib/vlog.c:618:12: error: reading variable 'log_
On Mon, Mar 23, 2020 at 04:48:42PM -0700, Ben Pfaff wrote:
> On Mon, Mar 23, 2020 at 04:34:37PM -0700, William Tu wrote:
> > Pass lock objects, not their addresses, to the annotation macros.
> >
> > Fixes: f21fa45f3085 ("lockfile: Minor code cleanup.")
> >
On Mon, Mar 23, 2020 at 9:26 PM William Tu wrote:
>
> On Mon, Mar 23, 2020 at 4:13 PM Ilya Maximets wrote:
> >
> > On 3/23/20 11:34 PM, William Tu wrote:
> > > On Mon, Mar 23, 2020 at 2:58 PM William Tu wrote:
> > >>
> > >> On Mon, Mar 23, 2
unsafely.
Tested-at: https://travis-ci.org/github/williamtu/ovs-travis/builds/666165883
Fixes: ecd4a8fcdff2 ("fatal-signal: Log backtrace when no monitor daemon.")
Suggested-by: Ilya Maximets
Signed-off-by: William Tu
---
include/openvswitch/vlog.h | 4 ++--
lib/fatal-signal.c
On Mon, Mar 23, 2020 at 4:13 PM Ilya Maximets wrote:
>
> On 3/23/20 11:34 PM, William Tu wrote:
> > On Mon, Mar 23, 2020 at 2:58 PM William Tu wrote:
> >>
> >> On Mon, Mar 23, 2020 at 2:34 PM Ben Pfaff wrote:
> >>>
> >>> On Mon, Mar 23, 202
On Mon, Mar 23, 2020 at 4:13 PM Ilya Maximets wrote:
>
> On 3/23/20 11:34 PM, William Tu wrote:
> > On Mon, Mar 23, 2020 at 2:58 PM William Tu wrote:
> >>
> >> On Mon, Mar 23, 2020 at 2:34 PM Ben Pfaff wrote:
> >>>
> >>> On Mon, Mar 23, 202
Pass lock objects, not their addresses, to the annotation macros.
Fixes: f21fa45f3085 ("lockfile: Minor code cleanup.")
Tested-at: https://travis-ci.org/github/williamtu/ovs-travis/builds/666098338
Signed-off-by: William Tu
---
lib/lockfile.c | 16
1 file changed, 8
On Mon, Mar 23, 2020 at 2:58 PM William Tu wrote:
>
> On Mon, Mar 23, 2020 at 2:34 PM Ben Pfaff wrote:
> >
> > On Mon, Mar 23, 2020 at 02:22:17PM -0700, William Tu wrote:
> > > Due to not acquiring lock, clang reports:
> > > lib/vlog.c:618:12: error: readin
On Mon, Mar 23, 2020 at 2:34 PM Ben Pfaff wrote:
>
> On Mon, Mar 23, 2020 at 02:22:17PM -0700, William Tu wrote:
> > Due to not acquiring lock, clang reports:
> > lib/vlog.c:618:12: error: reading variable 'log_fd' requires holding mutex
> > 'log_file_m
travis-ci.org/github/williamtu/ovs-travis/builds/666051210
Fixex: ecd4a8fcdff2 ("fatal-signal: Log backtrace when no monitor daemon.")
Signed-off-by: William Tu
---
lib/fatal-signal.c | 55 +-
lib/vlog.c | 1 +
2 files
On Mon, Mar 23, 2020 at 12:32 PM Ben Pfaff wrote:
>
> On Mon, Mar 23, 2020 at 12:23:10PM -0700, William Tu wrote:
> > On Mon, Mar 23, 2020 at 11:55 AM William Tu wrote:
> > >
> > > On Mon, Mar 23, 2020 at 11:33 AM Dave Tucker wrote:
> > > >
> > &
On Mon, Mar 23, 2020 at 11:55 AM William Tu wrote:
>
> On Mon, Mar 23, 2020 at 11:33 AM Dave Tucker wrote:
> >
> > Hi all!
> >
> > Current master branch is failing to compile under clang.
> > The problem was introduced in this commit (applied 4 hours ago).
&g
301 - 400 of 1254 matches
Mail list logo
