Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-06-10 Thread Gaƫtan Rivet
On 27/05/20 17:49 +0200, Ilya Maximets wrote: > On 4/20/20 9:26 AM, Roni Bar Yanai wrote: > > Hi Ben, Ilya > > > > Going back to this thread. We've tried app-ctl approach and it fails on > > consistency > > problem. Orchestrator can configure on full system init, but now executing > > local >

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-05-27 Thread Ilya Maximets
ets. > >> -Original Message- >> From: dev On Behalf Of Roni Bar Yanai >> Sent: Sunday, January 26, 2020 9:47 AM >> To: Ben Pfaff >> Cc: d...@openvswitch.org; Adrian Chiris ; Ilya Maximets >> ; Ameer Mahagneh ; Eveline >> Raine >> Subj

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-04-20 Thread Roni Bar Yanai
gt;Subject: Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK >interfaces > >Thanks Ben. > >>-Original Message- >>From: Ben Pfaff >>Sent: Thursday, January 23, 2020 11:33 PM >>To: Roni Bar Yanai >>Cc: Ilya Maximets ; Ophir Munk >

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-25 Thread Roni Bar Yanai
Thanks Ben. >-Original Message- >From: Ben Pfaff >Sent: Thursday, January 23, 2020 11:33 PM >To: Roni Bar Yanai >Cc: Ilya Maximets ; Ophir Munk >; Eveline Raine ; >d...@openvswitch.org; Moshe Levi ; Adrian Chiris >; Majd Dibbiny ; Ameer >Mahagneh >Subject: Re: [PATCH 1/1] vswitchd:

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-23 Thread Ben Pfaff
The main problem is that the database is stateful. I would not have the same objection to an RPC to set an Ethernet address. This could be implemented via the ovs-appctl interface, if local-only is acceptable, or via OpenFlow, if the controller needs to do it. On Wed, Jan 22, 2020 at 02:49:47PM

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-22 Thread Roni Bar Yanai
Hi Ilya, Ben What is the plan to manage MAC addresses of DPDK ports with representors? The solution should be generic and support non bifurcated drivers. Currently we cannot integrate DPDK with port representors in platforms such as open stack. Thanks, Roni >-Original Message- >From:

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-13 Thread Roni Bar Yanai
>-Original Message- >From: Ilya Maximets >Sent: Thursday, January 9, 2020 3:28 PM >To: Ophir Munk ; Ben Pfaff ; Ilya >Maximets >Cc: Eveline Raine ; d...@openvswitch.org; Moshe Levi >; Adrian Chiris ; Majd Dibbiny >; Roni Bar Yanai ; Ameer >Mahagneh >Subject: Re: [PATCH 1/1] vswitchd:

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-09 Thread Ilya Maximets
es the same confusion. > > Testing both patches [1] and [2] - passed successfully. > Acked-by: Ophir Munk > > I hope patches [1] and [2] can be merged to master. > > [1] > https://patchwork.ozlabs.org/patch/1186896/ > ("[ovs-dev,v2] netdev-dpdk: Add ability to set

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-08 Thread Ophir Munk
[1] and [2] - passed successfully. Acked-by: Ophir Munk I hope patches [1] and [2] can be merged to master. [1] https://patchwork.ozlabs.org/patch/1186896/ ("[ovs-dev,v2] netdev-dpdk: Add ability to set MAC address.") [2] https://patchwork.ozlabs.org/patch/1215075/ ("[ovs-

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-06 Thread Ben Pfaff
On Fri, Jan 03, 2020 at 03:56:59PM +0100, Ilya Maximets wrote: > Ben, do you see any other drawbacks that we should handle if we'll allow > changing MAC addresses for non-internal ports? Or, maybe some issues with > my logic? It can cause surprises for interactions with regular system tools.

Re: [ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2020-01-03 Thread Ilya Maximets
On 23.12.2019 22:34, Eveline Raine wrote: > When setting mac address for an interface using ovs-vsctl command: > > ovs-vsctl set interface mac=XX:XX:XX:XX:XX:XX > > iface_set_mac() is responsible to delegate a request to set MAC to a > netdev-specific set_etheraddr(). > > At the moment

[ovs-dev] [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces

2019-12-23 Thread Eveline Raine
When setting mac address for an interface using ovs-vsctl command: ovs-vsctl set interface mac=XX:XX:XX:XX:XX:XX iface_set_mac() is responsible to delegate a request to set MAC to a netdev-specific set_etheraddr(). At the moment iface_set_mac() skips all interfaces except those with type =