Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

2018-01-09 Thread Ben Pfaff
On Tue, Jan 09, 2018 at 09:27:11AM -0800, Ben Pfaff wrote: > On Tue, Jan 09, 2018 at 05:02:11PM +, Markos Chandras wrote: > > Hi Ben, > > > > On 09/01/18 16:56, Ben Pfaff wrote: > > >> Sure, I was just concerned was it fixing a compilation issue or such for > > >> you. I've seen it's been

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

2018-01-09 Thread Ben Pfaff
On Tue, Jan 09, 2018 at 05:02:11PM +, Markos Chandras wrote: > Hi Ben, > > On 09/01/18 16:56, Ben Pfaff wrote: > >> Sure, I was just concerned was it fixing a compilation issue or such for > >> you. I've seen it's been applied already and I've given it a quick > >> validation check without

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

2018-01-09 Thread Stokes, Ian
> Hi Ben, > > On 09/01/18 16:56, Ben Pfaff wrote: > >> Sure, I was just concerned was it fixing a compilation issue or such > for you. I've seen it's been applied already and I've given it a quick > validation check without issue so no worries. > > > > I interpreted your Signed-off-by as a

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

2018-01-09 Thread Markos Chandras
Hi Ben, On 09/01/18 16:56, Ben Pfaff wrote: >> Sure, I was just concerned was it fixing a compilation issue or such for >> you. I've seen it's been applied already and I've given it a quick >> validation check without issue so no worries. > > I interpreted your Signed-off-by as a request to

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

2018-01-09 Thread Ben Pfaff
On Tue, Jan 09, 2018 at 04:43:32PM +, Stokes, Ian wrote: > > > > -Original Message- > > From: Markos Chandras [mailto:mchand...@suse.de] > > Sent: Tuesday, January 9, 2018 4:23 PM > > To: Stokes, Ian ; d...@openvswitch.org > > Cc: Kavanagh, Mark B

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

2018-01-09 Thread Stokes, Ian
> -Original Message- > From: Markos Chandras [mailto:mchand...@suse.de] > Sent: Tuesday, January 9, 2018 4:23 PM > To: Stokes, Ian ; d...@openvswitch.org > Cc: Kavanagh, Mark B ; Ilya Maximets > > Subject: Re:

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

2018-01-09 Thread Markos Chandras
Hi Ian, On 09/01/18 16:16, Stokes, Ian wrote: >> -Original Message- >> From: Markos Chandras [mailto:mchand...@suse.de] >> Sent: Tuesday, January 9, 2018 3:55 PM >> To: d...@openvswitch.org >> Cc: Kavanagh, Mark B ; Ilya Maximets >> ;

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

2018-01-09 Thread Ben Pfaff
On Tue, Jan 09, 2018 at 03:54:45PM +, Markos Chandras wrote: > From: Mark Kavanagh > > netdev_dpdk_detach() declares a 'port_id' variable, of type uint8_t. > This variable should instead be of type dpdk_port_t. > > Fixes: bb37956ac ("netdev-dpdk: Use uint8_t for

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

2018-01-09 Thread Stokes, Ian
> -Original Message- > From: Markos Chandras [mailto:mchand...@suse.de] > Sent: Tuesday, January 9, 2018 3:55 PM > To: d...@openvswitch.org > Cc: Kavanagh, Mark B ; Ilya Maximets > ; Stokes, Ian ; Markos > Chandras

[ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

2018-01-09 Thread Markos Chandras
From: Mark Kavanagh netdev_dpdk_detach() declares a 'port_id' variable, of type uint8_t. This variable should instead be of type dpdk_port_t. Fixes: bb37956ac ("netdev-dpdk: Use uint8_t for port_id.") CC: Ilya Maximets Signed-off-by: Mark