Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

On Thu, Apr 25, 2019 at 12:19 PM Ilya Maximets wrote: > > > On 25.04.2019 13:03, Kevin Traynor wrote: > > On 25/04/2019 10:50, Maxime Coquelin wrote: > >> > >> > >> On 4/19/19 9:58 AM, Ilya Maximets wrote: > >>> On 18.04.2019 17:05, David Marchand wrote: > > > On Wed, Apr 17, 2019

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

On 4/25/19 12:19 PM, Ilya Maximets wrote: On 25.04.2019 13:03, Kevin Traynor wrote: On 25/04/2019 10:50, Maxime Coquelin wrote: On 4/19/19 9:58 AM, Ilya Maximets wrote: On 18.04.2019 17:05, David Marchand wrote: On Wed, Apr 17, 2019 at 4:16 PM Kevin Traynor

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

On 25.04.2019 13:03, Kevin Traynor wrote: > On 25/04/2019 10:50, Maxime Coquelin wrote: >> >> >> On 4/19/19 9:58 AM, Ilya Maximets wrote: >>> On 18.04.2019 17:05, David Marchand wrote: On Wed, Apr 17, 2019 at 4:16 PM Kevin Traynor >>> > wrote:

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

On 25/04/2019 10:50, Maxime Coquelin wrote: > > > On 4/19/19 9:58 AM, Ilya Maximets wrote: >> On 18.04.2019 17:05, David Marchand wrote: >>> >>> >>> On Wed, Apr 17, 2019 at 4:16 PM Kevin Traynor >> > wrote: >>> >>> On 16/04/2019 10:45, David Marchand wrote: >>>

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

On 4/19/19 9:58 AM, Ilya Maximets wrote: On 18.04.2019 17:05, David Marchand wrote: On Wed, Apr 17, 2019 at 4:16 PM Kevin Traynor mailto:ktray...@redhat.com>> wrote: On 16/04/2019 10:45, David Marchand wrote: > @@ -1171,6 +1173,9 @@ pmd_info_show_rxq(struct ds *reply, struct

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

On 16/04/2019 10:45, David Marchand wrote: > We currently poll all available queues based on the max queue count > exchanged with the vhost peer and rely on the vhost library in DPDK to > check the vring status beneath. > This can lead to some overhead when we have a lot of unused queues. > > To

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

On 17.04.2019 11:35, David Marchand wrote: > Hello Ilya, > > > On Tue, Apr 16, 2019 at 3:41 PM Ilya Maximets > wrote: > > Hi. > > One comment for the patch names. It's not a rule, but it's better > to make the part of the subject a complete

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

Hello Ilya, On Tue, Apr 16, 2019 at 3:41 PM Ilya Maximets wrote: > Hi. > > One comment for the patch names. It's not a rule, but it's better > to make the part of the subject a complete sentence. > i.e. start with a capital letter and end with a period. > > Same rule is applicable to the

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

Hi. One comment for the patch names. It's not a rule, but it's better to make the part of the subject a complete sentence. i.e. start with a capital letter and end with a period. Same rule is applicable to the comments in the code, but this is documented in coding-style. More comments inline.

[ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

We currently poll all available queues based on the max queue count exchanged with the vhost peer and rely on the vhost library in DPDK to check the vring status beneath. This can lead to some overhead when we have a lot of unused queues. To enhance the situation, we can skip the disabled queues.