Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-02-07 Thread Simon Horman
On Tue, Feb 07, 2023 at 01:04:41PM +0800, Han Ding wrote: > > Function is_gratuitous_arp() and function is_garp() are all used to judge > whether the flow is gratuitous arp. It is not necessary to use two functions > to do the same thing and just keep one. > > Signed-off-by: Han Ding > --- >

Re: [ovs-dev] [PATCH v6] conntrack: Properly unNAT inner header of related traffic

2023-02-07 Thread Simon Horman
p too :) Reviewed-by: Simon Horman > diff --git a/lib/conntrack.c b/lib/conntrack.c > index 550b2be9b..3162924ca 100644 > --- a/lib/conntrack.c > +++ b/lib/conntrack.c ... > static void > -reverse_nat_packet(struct dp_packet *pkt, const struct conn *conn) > +nat_inner_packet

Re: [ovs-dev] [PATCH v1 1/2] ovs-router: introduce src param in ovs/route/add.

2023-02-07 Thread Simon Horman
when caching routes from > Kernel FIB with Netlink, but are not dealt with in this patch. > > Signed-off-by: Nobuhiro MIKI Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v1 2/2] route-table: retrieving the preferred source address from Netlink.

2023-02-07 Thread Simon Horman
t; calculated with its own logic. This patch resolves the difference > between kernel FIB and OVS route table cache by retrieving the > RTA_PREFSRC attribute of Netlink messages. > > Signed-off-by: Nobuhiro MIKI Reviewed-by: Simon Horman

Re: [ovs-dev] [PATCH v11 01/11] tests: Include working system-traffic tests into the system-offloads-testsuite.

2023-02-08 Thread Simon Horman
On Wed, Feb 08, 2023 at 05:32:30PM +0100, Simon Horman wrote: > On Tue, Feb 07, 2023 at 03:03:57PM +0100, Eelco Chaudron wrote: > > Include and run the system-traffic.at tests as part of the system offload > > testsuite. Exclude all the tests that will not run without any special &g

Re: [ovs-dev] [PATCH v11 01/11] tests: Include working system-traffic tests into the system-offloads-testsuite.

2023-02-08 Thread Simon Horman
t supported" message, so tests > will not fail with older kernels. This is not an error level message, but > should be debug, like all other, EOPNOTSUPP, related log messages. > > Signed-off-by: Eelco Chaudron > Acked-by: Roi Dayan Reviewed-b

Re: [ovs-dev] [PATCH v11 07/11] test: Fix 'conntrack - Multiple ICMP traverse' for tc case.

2023-02-08 Thread Simon Horman
tc-offload.rst. > > Signed-off-by: Eelco Chaudron > Acked-by: Roi Dayan Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v11 10/11] tests: Fix reading of OpenFlow byte counters in GRE test cases.

2023-02-08 Thread Simon Horman
On Tue, Feb 07, 2023 at 03:07:24PM +0100, Eelco Chaudron wrote: > With some datapaths, read TC, it takes a bit longer to update the > OpenFlow statistics. Rather than adding an additional delay, try > to read the counters multiple times until we get the desired value. > > Signed-off-by: Eelco

Re: [ovs-dev] [PATCH v11 02/11] test: Do not use MPLS implicit null label in test cases.

2023-02-08 Thread Simon Horman
On Tue, Feb 07, 2023 at 03:04:17PM +0100, Eelco Chaudron wrote: > TC flower does not allow the push of the implicit null labels (RFC3032). > Avoid the use of such labels in the MPLS test cases. > > Signed-off-by: Eelco Chaudron > Acked-by: Roi Dayan Reviewed-by: Simon Horman T

Re: [ovs-dev] [PATCH v11 01/11] tests: Include working system-traffic tests into the system-offloads-testsuite.

2023-02-08 Thread Simon Horman
t supported" message, so tests > will not fail with older kernels. This is not an error level message, but > should be debug, like all other, EOPNOTSUPP, related log messages. > > Signed-off-by: Eelco Chaudron > Acked-by: Roi Dayan Reviewed-b

Re: [ovs-dev] [PATCH v11 06/11] test: tc does not support conntrack timeout, skip the related test.

2023-02-08 Thread Simon Horman
he related test by overriding the support macro. > > Signed-off-by: Eelco Chaudron > Acked-by: Roi Dayan Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v11 04/11] test: Flush datapath when changing rules on the fly.

2023-02-08 Thread Simon Horman
On Tue, Feb 07, 2023 at 03:05:07PM +0100, Eelco Chaudron wrote: > Flush datapath flows as TC flows take some more time to be flushed out. > The flush speeds this up. > > Signed-off-by: Eelco Chaudron > Acked-by: Roi Dayan Reviewed-by: Simon Horman Tested-b

Re: [ovs-dev] [PATCH v11 03/11] netdev-offload-tc: Fix tc conntrack force commit support.

2023-02-08 Thread Simon Horman
-by: Eelco Chaudron > Acked-by: Roi Dayan Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v11 05/11] netdev-offload-tc: Conntrack ALGs are not supported with tc.

2023-02-08 Thread Simon Horman
; the kernel module, return traffic might flow through a tc conntrack > rule, and it will not invoke the ALG helper. > > Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support") > Signed-off-by: Eelco Chaudron > Acked-by: Roi Dayan Reviewed-by:

Re: [ovs-dev] [PATCH v11 09/11] netdev-offload-tc: If the flow has not been used, report it as such.

2023-02-08 Thread Simon Horman
delay is also present > in other ICMP/IGMP tests. > > f98e418fbdb6 ("tc: Add tc flower functions") > Signed-off-by: Eelco Chaudron > Acked-by: Roi Dayan Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openv

Re: [ovs-dev] [PATCH v11 08/11] odp-util: Make odp_flow_key_from_flow__ nlattr order the same as the kernel.

2023-02-08 Thread Simon Horman
e order for all datapath. > > Signed-off-by: Eelco Chaudron > Acked-by: Roi Dayan Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/7] netdev-linux: use 64-bit rates in htb tc classes

2023-05-04 Thread Simon Horman
On Wed, May 03, 2023 at 04:05:36PM +0200, Adrian Moreno wrote: > > > On 4/25/23 14:51, Simon Horman wrote: > > On Fri, Apr 21, 2023 at 05:16:48PM +0200, Adrian Moreno wrote: > > > Currently, htb rates are capped at ~34Gbps because they are internally > >

Re: [ovs-dev] [PATCH 6/7] netdev-linux: refactor nl_msg_put_act_police

2023-05-04 Thread Simon Horman
On Wed, May 03, 2023 at 03:53:14PM +0200, Adrian Moreno wrote: > > > On 4/26/23 15:39, Simon Horman wrote: > > On Fri, Apr 21, 2023 at 05:16:50PM +0200, Adrian Moreno wrote: > > > In preparation for supporting 64-bit rates in tc policies, move the > > > alloca

Re: [ovs-dev] [PATCH v12 4/8] ovsdb: Assert and check return values of `ovsdb_table_schema_get_column`

2023-06-14 Thread Simon Horman
. > > Signed-off-by: James Raphael Tiovalen Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v12 2/8] lib, ovs-vsctl: Add zero-initializations

2023-06-14 Thread Simon Horman
uch as Coverity, happy. > > Signed-off-by: James Raphael Tiovalen Reviewed-by: Simon Horman I do see a failure in the Intel test run [1][2], but it seems unrelated to this patch. [1] https://patchwork.ozlabs.org/project/openvswitch/patch/20230613183443.31540-3-jamestio...@gmail.com/ [2] htt

Re: [ovs-dev] [PATCH v4 7/9] tc: Add vxlan encap action with gbp option offload

2023-06-14 Thread Simon Horman
On Wed, Jun 14, 2023 at 11:22:37AM +0300, Roi Dayan wrote: > From: Gavin Li > > Add TC offload support for vxlan encap with gbp option > > Signed-off-by: Gavin Li > Reviewed-by: Gavi Teitz > Reviewed-by: Roi Dayan Revi

Re: [ovs-dev] [PATCH v4 5/9] tc: Add vxlan gbp option flower match offload

2023-06-14 Thread Simon Horman
On Wed, Jun 14, 2023 at 11:22:35AM +0300, Roi Dayan wrote: > From: Gavin Li > > Add TC offload support for filtering vxlan tunnels with gbp option > > Signed-off-by: Gavin Li > Reviewed-by: Gavi Teitz > Reviewed-by: Roi Dayan Revi

Re: [ovs-dev] [PATCH v4 8/9] netdev-tc-offloads: Probe for allowing vxlan gbp support

2023-06-14 Thread Simon Horman
ing the knowing ones. > > To solve the issue, probe and disallow inserting rules with vxlan gbp > action/match if kernel does not support it. > > Signed-off-by: Gavin Li > Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ___ dev mailin

Re: [ovs-dev] [ovs-dev v2] dpif-netdev: fix dpif_netdev_flow_put

2023-06-14 Thread Simon Horman
On Tue, Jun 13, 2023 at 09:41:42AM +0800, Peng He wrote: > Hi, Simon, > > I guess it's not related, as my patch fixes the code in dpif-netdev.c it > should has any impact on the ovsdb side. > But I am not sure that. > Is this test case a spike test case? Is there any testsuite log? * Please

Re: [ovs-dev] [PATCH v4 4/9] netlink: Add new function to add NLA_F_NESTED to nested netlink messages

2023-06-14 Thread Simon Horman
d is controlled by > message policy. To avoid this, add NLA_F_NESTED explicitly for all > nested netlink messages with a new function > nl_msg_start_nested_with_flag(). > > Signed-off-by: Gavin Li > Reviewed-by: Roi Dayan Reviewed-by: Simon Horman __

Re: [ovs-dev] [PATCH v4 9/9] system-offloads-traffic.at: Add vxlan gbp offload test

2023-06-14 Thread Simon Horman
On Wed, Jun 14, 2023 at 11:22:39AM +0300, Roi Dayan wrote: > From: Gavin Li > > Add a vxlan gbp offload test case: > > vxlan offloads with gbp extention - ping between two ports - offloads > enabled ok > > Signed-off-by: Gavin Li R

Re: [ovs-dev] [PATCH v6 2/2] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-07-03 Thread Simon Horman
On Thu, Jun 29, 2023 at 04:55:25PM +0200, Simon Horman wrote: > On Thu, Jun 29, 2023 at 04:15:09PM +0200, Ilya Maximets wrote: > > On 6/6/23 13:35, Ivan Malov wrote: > > > Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead. > > > > AFAICT, not all drive

Re: [ovs-dev] [PATCH v6 2/2] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT

2023-07-04 Thread Simon Horman
On Mon, Jul 03, 2023 at 01:28:06PM +0200, Ilya Maximets wrote: > On 7/3/23 10:45, Simon Horman wrote: > > On Thu, Jun 29, 2023 at 04:55:25PM +0200, Simon Horman wrote: > >> On Thu, Jun 29, 2023 at 04:15:09PM +0200, Ilya Maximets wrote: > >>> On 6/6/23 13:35, Ivan Malo

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-05-26 Thread Simon Horman
at.com/show_bug.cgi?id=2104779 > Signed-off-by: Mike Pattrick > > --- > > Since v1: > - Refactored code into specialized functions and renamed variables for > improved readability. > Since v2: > - Removed inline keywords Thanks! Reviewed-by: Simon Horman ___

Re: [ovs-dev] [PATCH v3 5/7] tc: Add vxlan gbp option flower match offload

2023-05-26 Thread Simon Horman
On Fri, May 26, 2023 at 12:43:52PM +0200, Eelco Chaudron wrote: > > > On 15 May 2023, at 10:23, Roi Dayan wrote: > > > From: Gavin Li > > > > Add TC offload support for filtering vxlan tunnels with gbp option > > > > Signed-off-by: Gavin Li > > Reviewed-by: Gavi Teitz > > Reviewed-by: Roi

Re: [ovs-dev] [PATCH v4 ovn] northd: centralized reply lb traffic even if FIP is defined

2023-05-26 Thread Simon Horman
eply traffic is never centralized. Fix the issue centralizing the > traffic if it is the reply packet for the load balancer. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2023609 > Signed-off-by: Lorenzo Bianconi Reviewed-by: Simon Horman ___

Re: [ovs-dev] [PATCH v2] python: Add aync DNS support

2023-05-26 Thread Simon Horman
The bare minimum change was done to inet_parse_active() to support > sync/async dns, as there is no equivalent to > parse_sockaddr_components(), inet_parse_passive(), etc. A TODO > was added to bring socket_util.py up to equivalency to the C > version. > > Signed-off-by: T

Re: [ovs-dev] [PATCH ovn v2] controller: Ignore DNS queries with RRs

2023-05-26 Thread Simon Horman
On Thu, May 25, 2023 at 12:23:43PM -0400, Brian Haley wrote: > Sorry for the top post, but I was wondering if there was a way to re-trigger > the bot testing action on a patch? Somehow the testing on the v2 one failed > even though v1 passed [0]. Since the only change was in the commit message >

Re: [ovs-dev] [PATCH v2 ovn] northd: centralized reply lb traffic even if FIP is defined

2023-05-24 Thread Simon Horman
Thanks Lorenzo, a few suggestions from my side. On Thu, May 18, 2023 at 10:20:34PM +0200, Lorenzo Bianconi wrote: > In the current codebase for distributed gw router port use-case, > it is not possible to add a load balancer that redirects the traffic > to a backed if it is even the internal IP

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Check rx/tx descriptor sizes for device.

2023-05-24 Thread Simon Horman
lue and log. > > Reported-at: https://bugzilla.redhat.com/2119876 > Signed-off-by: Kevin Traynor Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4 1/2] netdev-dpdk: Remove requested descriptors from get_config.

2023-05-24 Thread Simon Horman
ximets > Reviewed-by: David Marchand > Signed-off-by: Kevin Traynor Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] tests: layer3-tunnels: Skip bareudp tests if not supported by kernel.

2023-05-24 Thread Simon Horman
On Wed, May 24, 2023 at 03:39:53PM +0200, Frode Nordahl wrote: > The bareudp tests depend on specific kernel configuration to > succeed. Skip the test if the feature is not enabled in the > running kernel. > > Signed-off-by: Frode Nordahl Tested-by: Simon Horman Reviewed-b

Re: [ovs-dev] [PATCH] relay: allow setting probe interval

2023-05-24 Thread Simon Horman
decided to reuse it instead > of adding a new one. > > Signed-off-by: Felix Huettner Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-05-24 Thread Simon Horman
On Thu, May 18, 2023 at 04:08:34PM -0400, Mike Pattrick wrote: > Several xlate actions used in recursive translation currently store a > large amount of information on the stack. This can result in handler > threads quickly running out of stack space despite before >

Re: [ovs-dev] [PATCH v11] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-05-25 Thread Simon Horman
On Thu, May 25, 2023 at 10:58:36AM +0200, Balazs Nemeth wrote: > The only way that stats->{n_packets,n_bytes} would decrease is due to an > overflow, or if there are bugs in how statistics are handled. In the > past, there were multiple issues that caused a jump backward. A > workaround was in

Re: [ovs-dev] [PATCH] tests: layer3-tunnels: Skip bareudp tests if not supported by kernel.

2023-05-25 Thread Simon Horman
On Wed, May 24, 2023 at 09:23:59PM +0200, Ilya Maximets wrote: > On 5/24/23 15:39, Frode Nordahl wrote: > > The bareudp tests depend on specific kernel configuration to > > succeed. Skip the test if the feature is not enabled in the > > running kernel. > > > > Signed-off-by: Frode Nordahl > >

Re: [ovs-dev] [PATCH 3/3] netdev-vport: RCU-fy tunnel config.

2023-05-25 Thread Simon Horman
; used by different threads within RCU grace period. > > Signed-off-by: Ilya Maximets Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/3] smap: Make argument of smap_add_ipv6 constant.

2023-05-25 Thread Simon Horman
On Sat, May 20, 2023 at 02:31:19AM +0200, Ilya Maximets wrote: > The address is not getting modified inside. > > Signed-off-by: Ilya Maximets Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.or

Re: [ovs-dev] [PATCH] userspace: modify the width of tpa and spa

2023-05-25 Thread Simon Horman
On Thu, May 25, 2023 at 05:54:37PM +0800, yangchang wrote: > Arp_spa and arp_tpa are IP addresses, their width should be 32 bits. > > Signed-off-by: yangchang Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.

Re: [ovs-dev] [PATCH 1/3] netdev-vport: Fix unsafe handling of GRE sequence number.

2023-05-25 Thread Simon Horman
structure > instead and using an atomic counter. > > Fixes: 04975308 ("userspace: add gre sequence number support.") > Fixes: 7dc18ae96d33 ("userspace: add erspan tunnel support.") > Fixes: 3c6d05a02e0f ("userspace: Add GTP-U

Re: [ovs-dev] [PATCH ovn v2] lflow-cache: Introduce cache for lflow actions

2023-05-25 Thread Simon Horman
On Wed, May 24, 2023 at 11:12:28AM +0200, Ihtisham ul Haq via dev wrote: > Using cache improves performance of recomputation of lflows(by > about 30%) > > Exising lflow cache for `matches` and `expressions` is adopted > to include `actions` as well. > > Co-authored-by: Felix Huettner >

Re: [ovs-dev] [PATCH 2/2] tests: Check ovsdb-server logs in OVSDB tests.

2023-05-25 Thread Simon Horman
detect some internal warnings if there are some. > > Moving the OVSDB_SERVER_SHUTDOWN macro to the common place, adding > the call to check_logs into it and making OVSDB tests use this macro. > > Signed-off-by: Ilya Maximets Reviewed-by: Simon Horman As an aside. Some of

Re: [ovs-dev] [PATCH ovn] controller: Handle OpenFlow errors.

2023-05-25 Thread Simon Horman
eported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2134880 > Reported-by: François Rigault > CC: Ilya Maximets > Signed-off-by: Dumitru Ceara Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovsdb: condition: Process condition changes incrementally.

2023-05-25 Thread Simon Horman
On Thu, May 18, 2023 at 02:14:25PM +0200, Ilya Maximets wrote: > In most cases, after the condition change request, the new condition > is the same as old one plus minus a few clauses. Today, ovsdb-server > will evaluate every database row against all the old clauses and then > against all the

Re: [ovs-dev] [PATCH 1/2] stream-ssl: Disable alerts on unexpected EOF.

2023-05-25 Thread Simon Horman
rnings in the log. > > Signed-off-by: Ilya Maximets Reviewed-by: Simon Horman Are there any plans to enhance the client-side behaviour? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

2023-06-08 Thread Simon Horman
On Wed, Jun 07, 2023 at 11:09:58AM +0200, Eelco Chaudron wrote: ... > >> We moved the per cpu upcall counter allocation to the existing vport > >> alloc and free functions to solve this. > >> > >> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on > >> failure") > >> Fixes:

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: do not unwildcard source address if not needed

2023-06-08 Thread Simon Horman
On Sun, May 17, 2020 at 01:08:47PM +0800, hepeng.0320 wrote: > From: hepeng > > if the tunnel is specified as "remote_ip=flow", we can try to generate a > megaflow > which ignores all source address, such as source mac, source IP address > in the outter header of the packet. This can reduce the

Re: [ovs-dev] [PATCH 1/2] utilities: add "--detach" option to ovs-ctl

2023-06-08 Thread Simon Horman
stem-ids are not set and transient ports are not deleted. > > Signed-off-by: Vladislav Odintsov Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] utilities: add --in-db-ssl option to ovs-ctl

2023-06-08 Thread Simon Horman
; and "cacert" columns. > > This patch adds configuration knob "--in-db-ssl", which has default > behavior as it is now: run ovsdb server with ssl options. > > User must pass "--in-db-ssl=no" to run ovsdb-server without t

Re: [ovs-dev] [ovs-dev v9 1/2] ipf: add ipf context

2023-06-08 Thread Simon Horman
On Thu, Mar 10, 2022 at 01:55:30AM +, Peng He wrote: > From: Peng He > > ipf_postprocess will emit packets into the datapath pipeline ignoring > the conntrack context, this might casuse weird issues when a packet > batch has less space to hold all the fragments belonging to single > packet.

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: do not unwildcard source address if not needed

2023-06-08 Thread Simon Horman
On Thu, Jun 08, 2023 at 10:32:45PM +0800, Peng He wrote: > This patch has a bug, it needs 2 patches to realize the purpose in fact. I > can rebase if needed I am unclear on any need. Perhaps it's best to drop this for now. And revisit if the need arises.

Re: [ovs-dev] [ovs-dev v2] dpif-netdev: change execute->flow->in_port into odp_port

2023-06-08 Thread Simon Horman
On Thu, Mar 10, 2022 at 04:41:15AM +, Peng He wrote: > the flow->in_port value is previously ignored. We normally use > the the md->in_port of the first packet in the batch to get the > value. However, since some actions might need to be redo due to > the fix of ipf issues, we might have an

Re: [ovs-dev] [PATCH] bond/mirror: fix duplicate output when mix bond and mirror

2023-06-08 Thread Simon Horman
On Sat, Apr 06, 2019 at 01:59:13PM +, ? ? wrote: > When we configured bond that use recirc and configure mirror, we > observed that mirror destination has duplicated outputs. This is > because bond's frozen_state is not updated to reflect the mirror > already composed the output, and when the

Re: [ovs-dev] [PATCH] ovsdb: monitor: Destroy initial change set when new columns added.

2023-06-08 Thread Simon Horman
hat by destroying the initial change set every time new columns > are added to the monitor. This will trigger re-generation of the > change set and it will contain all the necessary columns afterwards. > > Fixes: 07c27226ee96 ("ovsdb: Monitor: Keep and maintain the initial change

Re: [ovs-dev] [PATCH 1/2] netdev-offload-dpdk: Fix flushing of a physdev

2023-06-08 Thread Simon Horman
On Wed, Jun 07, 2023 at 12:21:08PM +0200, David Marchand wrote: > Hello, > > On Tue, Jun 6, 2023 at 7:10 AM Eli Britstein wrote: > > >> > > > >> > Vport's offloads are done on the tracked orig-in-port, but the flow > > >> > itself is associated in the vport's map. > > >> > > > >> > Removing the

Re: [ovs-dev] [PATCH v2] seq: Make read of the current value atomic

2023-06-08 Thread Simon Horman
e change > should not impact the current behavior. > > Signed-off-by: Eelco Chaudron Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net] net: openvswitch: fix upcall counter access before allocation

2023-06-05 Thread Simon Horman
On Mon, Jun 05, 2023 at 10:59:50AM +0200, Eelco Chaudron wrote: > Currently, the per cpu upcall counters are allocated after the vport is > created and inserted into the system. This could lead to the datapath > accessing the counters before they are allocated resulting in a kernel > Oops. > >

Re: [ovs-dev] [PATCH net] net: openvswitch: fix upcall counter access before allocation

2023-06-05 Thread Simon Horman
On Mon, Jun 05, 2023 at 02:54:35PM +0200, Eelco Chaudron wrote: > > > On 5 Jun 2023, at 14:41, Simon Horman wrote: > > > On Mon, Jun 05, 2023 at 10:59:50AM +0200, Eelco Chaudron wrote: > >> Currently, the per cpu upcall counters are allocated after the vport i

Re: [ovs-dev] [PATCH v10 5/8] file, monitor: Add null pointer assertions for old and new ovsdb_rows

2023-05-23 Thread Simon Horman
On Wed, May 03, 2023 at 02:30:30AM +0800, James Raphael Tiovalen wrote: > This commit adds non-null pointer assertions in some code that performs > some decisions based on old and new input ovsdb_rows. > > Signed-off-by: James Raphael Tiovalen Reviewed-by:

Re: [ovs-dev] [PATCH v10 7/8] lib, ovsdb: Add various null pointer checks

2023-05-23 Thread Simon Horman
g > early or skipping some action if a null pointer is encountered. > > Signed-off-by: James Raphael Tiovalen Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v10 2/8] lib, ovs-vsctl: Add zero-initializations

2023-05-23 Thread Simon Horman
On Wed, May 03, 2023 at 02:30:27AM +0800, James Raphael Tiovalen wrote: > This commit adds zero-initializations by changing `SFL_ALLOC` from > `malloc` to `xzalloc`, adding a `memset` call to `sflAlloc`, > initializing a `pollfd` struct variable with zeroes, and changing some > calls to `xmalloc`

Re: [ovs-dev] [PATCH v10 4/8] ovsdb: Assert and check return values of `ovsdb_table_schema_get_column`

2023-05-23 Thread Simon Horman
control flow will now be redirected to alternative paths which will > output the appropriate error messages. > > Signed-off-by: James Raphael Tiovalen Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch

Re: [ovs-dev] [PATCH v10 3/8] shash, simap, smap: Add assertions to `*_count` functions

2023-05-23 Thread Simon Horman
of `shash_sort`, `simap_sort`, > or `smap_sort` are NULL, then the following for loops would not attempt > to access the pointer, which might result in segmentation faults or > undefined behavior. > > Signed-off-by: James Raphael Tioval

Re: [ovs-dev] [PATCH v3 4/7] netlink: Add new function to add NLA_F_NESTED to nested netlink messages

2023-05-23 Thread Simon Horman
eck is optional and is controlled by > message policy. To avoid this, add NLA_F_NESTED explicitly for all > nested netlink messages with a new function > nl_msg_start_nested_with_flag(). > > Signed-off-by: Gavin Li > Reviewed-by: Roi Dayan Reviewed-by: Simon Horman __

Re: [ovs-dev] [PATCH v3 5/7] tc: Add vxlan gbp option flower match offload

2023-05-23 Thread Simon Horman
On Mon, May 15, 2023 at 11:23:54AM +0300, Roi Dayan via dev wrote: > From: Gavin Li > > Add TC offload support for filtering vxlan tunnels with gbp option > > Signed-off-by: Gavin Li > Reviewed-by: Gavi Teitz > Reviewed-by: Roi Dayan Revi

Re: [ovs-dev] [PATCH v3 7/7] tc: Add vxlan encap action with gbp option offload

2023-05-23 Thread Simon Horman
On Mon, May 15, 2023 at 11:23:56AM +0300, Roi Dayan via dev wrote: > From: Gavin Li > > Add TC offload support for vxlan encap with gbp option > > Signed-off-by: Gavin Li > Reviewed-by: Gavi Teitz > Reviewed-by: Roi Dayan Revi

Re: [ovs-dev] [PATCH v10 2/8] lib, ovs-vsctl: Add zero-initializations

2023-05-23 Thread Simon Horman
uch as Coverity, happy. > > Signed-off-by: James Raphael Tiovalen Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [ovs-dev v2] dpif-netdev: fix dpif_netdev_flow_put

2023-06-12 Thread Simon Horman
On Mon, Jun 12, 2023 at 02:10:17AM +, Peng He wrote: > OVS allows overlapping megaflows, as long as the actions of these > megaflows are equal. However, the current implementation of action > modification relies on flow_lookup instead of ufid, this could result > in looking up a wrong megaflow

Re: [ovs-dev] [PATCH v11 4/8] ovsdb: Assert and check return values of `ovsdb_table_schema_get_column`

2023-06-12 Thread Simon Horman
control flow will now be redirected to alternative paths which will > output the appropriate error messages. > > Signed-off-by: James Raphael Tiovalen > Reviewed-by: Simon Horman Hi James, unfortunately the CI is showing a number of failures with this patch applied. I haven't dug

Re: [ovs-dev] [PATCH v2] ovs-save: add bindir to PATH

2023-06-12 Thread Simon Horman
On Fri, Jun 17, 2022 at 05:03:46PM +0200, Adrian Moreno wrote: > If openvswitch is not installed in the default system's path ovs-save > script will fail to find the tools it requires. > > Fix this by adding $bindir to the PATH. > Refactor common path calculation into ovs-lib. > > Signed-off-by:

Re: [ovs-dev] [PATCH ovn v2] controller: Ignore DNS queries with RRs

2023-05-30 Thread Simon Horman
On Fri, May 26, 2023 at 01:38:54PM +0200, Ales Musil wrote: > On Fri, May 26, 2023 at 12:56 PM Simon Horman > wrote: > > > On Thu, May 25, 2023 at 12:23:43PM -0400, Brian Haley wrote: > > > Sorry for the top post, but I was wondering if there was a way to > > re

Re: [ovs-dev] [PATCH 1/2] stream-ssl: Disable alerts on unexpected EOF.

2023-05-30 Thread Simon Horman
On Fri, May 26, 2023 at 06:57:09PM +0200, Ilya Maximets wrote: > On 5/25/23 15:21, Simon Horman wrote: > > On Wed, May 17, 2023 at 06:51:04PM +0200, Ilya Maximets wrote: > >> OpenSSL 3.0 enabled alerts for unexpected EOF by default. It supposed > >> to ale

Re: [ovs-dev] [PATCH v2] ovsdb: Condition: Process condition changes incrementally.

2023-05-30 Thread Simon Horman
On Fri, May 26, 2023 at 07:56:06PM +0200, Ilya Maximets wrote: > My commit hook capitalized 'c' in the 'condition'. I can fix that > before applying. Sounds good. Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 2/2] tests: Check ovsdb-server logs in OVSDB tests.

2023-05-30 Thread Simon Horman
On Fri, May 26, 2023 at 03:11:01PM +0200, Ilya Maximets wrote: > On 5/25/23 15:20, Simon Horman wrote: > > On Wed, May 17, 2023 at 06:51:05PM +0200, Ilya Maximets wrote: > >> Many OVSDB tests are not checking the server log for warnings or > >> errors. Some are not eve

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation

2023-06-06 Thread Simon Horman
upcall counter allocation to the existing vport > alloc and free functions to solve this. > > Fixes: 95637d91fefd ("net: openvswitch: release vport resources on failure") > Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets") > Signe

Re: [ovs-dev] [PATCH net] net: openvswitch: fix upcall counter access before allocation

2023-06-06 Thread Simon Horman
On Mon, Jun 05, 2023 at 03:53:59PM +0200, Eelco Chaudron wrote: > > > On 5 Jun 2023, at 15:07, Simon Horman wrote: > > > On Mon, Jun 05, 2023 at 02:54:35PM +0200, Eelco Chaudron wrote: > >> > >> > >> On 5 Jun 2023, at 14:41, Simon Horman wrote:

Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

2023-05-25 Thread Simon Horman
yant > CC: Alin Serdean > CC: Andy Zhou > CC: Ansis Atteka > CC: Daniele Di Proietto > CC: Gurucharan Shetty > CC: Ian Stokes > CC: Ilya Maximets > CC: Jarno Rajahalme > CC: Jesse Gross > CC: Justin Pettit > CC: Pravin B Shelar > CC: Simon Horman

Re: [ovs-dev] [PATCH v3 net-next 0/5] selftests: openvswitch: add flow programming cases

2023-08-03 Thread Simon Horman
validate > the control path. > > Add the ability to program some of the more common flows with actions. This > can be improved overtime to include regression testing, etc. Thanks Aaron. For series, Reviewed-by: Simon Horman ___ dev mailing list

Re: [ovs-dev] [ovs-dev v12] ofproto-dpif-upcall: fix push_dp_ops

2023-07-26 Thread Simon Horman
On Thu, Jul 06, 2023 at 04:59:36PM +0800, Peng He wrote: ... > +dnl Replace OpenFlow rules, trigger revalidation and wait for it to > >>> complete. > +AT_CHECK([echo 'table=0,in_port=p1,ip actions=ct(commit)' | ovs-ofctl > >>> --bundle replace-flows br0 -]) > +AT_CHECK([ovs-appctl

Re: [ovs-dev] [PATCH v2] ovs-tcpdump: Bugfix-of-ovs-tcpdump

2023-07-26 Thread Simon Horman
On Thu, Jul 20, 2023 at 11:38:41AM -0400, Aaron Conole wrote: > Hi Simon, > > Thanks for the contribution! > > Simon Jones writes: > > > From: simon > > > > Fix bug of ovs-tcpdump, which will cause megaflow action wrong. > > > > As use ovs-tcpdump will add mipxxx NIC, and this NIC has IPv6

Re: [ovs-dev] [PATCH v2 net-next 2/5] selftests: openvswitch: support key masks

2023-07-30 Thread Simon Horman
On Fri, Jul 28, 2023 at 07:59:37AM -0400, Aaron Conole wrote: > From: Adrian Moreno > > From: Adrian Moreno > > The default value for the mask actually depends on the value (e.g: if > the value is non-null, the default is full-mask), so change the convert > functions to accept the full,

Re: [ovs-dev] [PATCH] bond: Always revalidate unbalanced bonds when active member changes

2023-08-11 Thread Simon Horman
will always mark unbalanced bonds for revalidation if the > active member changes. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2214979 > Signed-off-by: Mike Pattrick Acked-by: Simon Horman ___ dev mailing list d...@openvsw

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-08-11 Thread Simon Horman
On Fri, Aug 11, 2023 at 11:16:33AM -0400, Mike Pattrick wrote: > On Fri, Aug 11, 2023 at 11:00 AM Simon Horman wrote: > > > > On Wed, Aug 09, 2023 at 10:58:14PM -0400, Mike Pattrick wrote: > > > When the a revalidator thread is updating statistics for an XC_

Re: [ovs-dev] [PATCH v3] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-08-11 Thread Simon Horman
On Wed, Aug 09, 2023 at 10:58:14PM -0400, Mike Pattrick wrote: > When the a revalidator thread is updating statistics for an XC_LEARN > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn. > The revalidator will update stats for rules even if they are in a > removed state or

[ovs-dev] [PATCH] MAINTAINERS: Add Aaron Conole.

2023-08-12 Thread Simon Horman
Aaron Conole was recently elected by the Open vSwitch committers. This formalizes his status as an Open vSwitch committer. Welcome Aaron! Signed-off-by: Simon Horman --- MAINTAINERS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index a3e923195c3e

Re: [ovs-dev] [PATCH v1] lacp: Improve visibility with LACP

2023-08-04 Thread Simon Horman
On Wed, Aug 02, 2023 at 04:06:51PM -0400, Mike Pattrick wrote: > Diagnosing connectivity issues involving a bond can be complicated by a > lack of logging in LACP. It is difficult to determine the health of > sending and receving LACP packets. This is further complicated by the > tendency of some

Re: [ovs-dev] [PATCH v2 1/2] netdev-tc-offload: Add csum offload of protocols IGMP/UDPLITE/SCTP

2023-08-04 Thread Simon Horman
On Wed, Aug 02, 2023 at 04:59:35PM +0800, Faicker Mo via dev wrote: > Add tc csum offload support of protocols IGMP/UDPLITE/SCTP > > Signed-off-by: Faicker Mo UDPLite will be deprecated in the Linux kernel from v6.4 [1]. Are you sure that we want to increase it's support in OvS at this time?

Re: [ovs-dev] [PATCH] conntrack: Allow flush of SCTP protocol

2023-08-04 Thread Simon Horman
> > Signed-off-by: Ales Musil Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 2/2] netdev-tc-offload: Add IPIP/GRE protocols to offload in ip rewrite

2023-08-04 Thread Simon Horman
ten. > > Fixes: d6118e628988 ("netdev-tc-offloads: Verify csum flags on dump from tc") > Signed-off-by: Faicker Mo Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] MAINTAINERS: Add Kevin Traynor.

2023-08-05 Thread Simon Horman
Kevin Traynor was recently elected by the Open vSwitch committers. This formalises his status as an Open vSwitch committer. Welcome Kevin! Signed-off-by: Simon Horman --- MAINTAINERS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 2fc2517177e1

Re: [ovs-dev] [PATCH 2/2] checkpatch: Overwrite patch file to include provisional subject.

2023-08-07 Thread Simon Horman
On Fri, Aug 04, 2023 at 04:58:34PM -0400, Chandan Somani wrote: > If a subject is missing, then a command like > utilities/checkpatch.py -S file.patch will write in the new subject > to file.patch itself. > > Signed-off-by: Chandan Somani Hi Chandan, I'm unclear on the motivation for this

Re: [ovs-dev] [PATCH v8 3/4] netdev-dpdk: Add support for egress packet-per-second policing.

2023-08-07 Thread Simon Horman
On Sat, Aug 05, 2023 at 12:14:37AM +0800, mit...@outlook.com wrote: > From: Lin Huang > > OvS has supported packet-per-second policer which can be set at ingress > and egress side in kernel datapath. But the userspace datapath doesn't > support for ingress and egress packet-per-second policing

Re: [ovs-dev] [PATCH v4 2/4] dpif: Probe support for OVS_ACTION_ATTR_DROP.

2023-08-07 Thread Simon Horman
On Fri, Aug 04, 2023 at 03:58:45PM -0400, Eric Garver wrote: > Kernel support is being added for this action. As such, we need to probe > the datapath for support. > > Signed-off-by: Eric Garver Acked-by: Simon Horman ___ dev ma

Re: [ovs-dev] [PATCH v4 1/4] dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.

2023-08-07 Thread Simon Horman
> Signed-off-by: Eric Garver Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4 3/4] system-common-macros: Check for drop action in datapath.

2023-08-07 Thread Simon Horman
On Fri, Aug 04, 2023 at 03:58:46PM -0400, Eric Garver wrote: nit: I would slightly prefer if there was a patch description here. Or, alternatively, perhaps this patch could be squashed into the following one. > Signed-off-by: Eric Garver > --- > tests/system-common-macros.at | 4

<    6   7   8   9   10   11   12   13   14   15   >