Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-17 Thread Jan Kandziora
Am 17.11.2016 um 18:00 schrieb Enrico Hoepfner: > Hi Jan, > > thank you for the Answer and the description! > I've never made this procedure. > > I've try this steps, but where should I send the email to? > the output looks like this: > To the list. > > owserver hangs some minutes when sequen

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-17 Thread Enrico Hoepfner
Hi Jan, thank you for the Answer and the description! I've never made this procedure. I've try this steps, but where should I send the email to? the output looks like this: owserver hangs some minutes when sequence number run over 0x $ git format-patch master --stdout c14b0e446e686b4ab158

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-17 Thread Jan Kandziora
Am 17.11.2016 um 07:13 schrieb Enrico Hoepfner: > > the patch below works perfectly! thank you all for your help! > > how can I commit this patch to owfs source? can this do someone of > the developers or is there a description how I can do that? > Install git and gitk. Setup git: $ git config

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-16 Thread Enrico Hoepfner
Hello, the patch below works perfectly! thank you all for your help! how can I commit this patch to owfs source? can this do someone of the developers or is there a description how I can do that? best regards eni On 15.11.2016 16:36, Enrico Hoepfner wrote: Hello Stefano, reference to you

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-15 Thread Enrico Hoepfner
Hello Stefano, reference to your suggestion, I've test an other patch, which is also working well for me. pi@raspberrypi:~/owfs/owfs-3.1p4 $ diff -u module/owlib/src/c/ow_w1_parse.c.orig module/owlib/src/c/ow_w1_parse.c --- module/owlib/src/c/ow_w1_parse.c.orig 2016-11-14 20:40:17.88

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-13 Thread Enrico Hoepfner
Hello Stefano, Thank you for the answer! in my opinion the source looks like there are 2 upper Bytes for bus and 2 lower Bytes for seq reserved in nlmsg_seq ... so seq can grow maximal to 0x. In the case seq is greater 0x for instance seq = 0x1 and bus = 0x1 ./module/owlib/src/c

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-13 Thread Stefano Miccoli
Sorry for flooding the list short snippets: I have to correct myself: obviously 0x are 16bits, two bytes (not four). My mistake. S. > On 13 Nov 2016, at 12:28, Stefano Miccoli wrote: > > I don’t get the point. > > Netlink sequence numbers are opaque and are needed only to correlate > r

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-13 Thread Stefano Miccoli
This line looks suspicious: module/owlib/src/c/ow_w1_parse.c:235: if ( NL_SEQ(nlp.nlm->nlmsg_seq) != (unsigned int) seq ) { Hope this helps. S. > On 13 Nov 2016, at 12:28, Stefano Miccoli wrote: > > I don’t get the point. > > Netlink sequence numbers are opaque and are needed onl

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-13 Thread Stefano Miccoli
I don’t get the point. Netlink sequence numbers are opaque and are needed only to correlate request/response. Netlink sequence numbers are build by this macro (module/owlib/src/include/ow_w1.h): #define MAKE_NL_SEQ( bus, seq ) ((uint32_t)(( ((bus) & 0x) << 16 ) | ((seq) & 0x))) This

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-13 Thread Enrico Hoepfner
Hello Jan, Sorry for the confusion. What does the patch do: Problem: In case of overrun of seq over 0x, the owserver try 4 minutes to get an answer from 1w-bus, but without success, because the expected sequence number is not mach with the seqence-number he hve send and get back. After t

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-13 Thread Jan Kandziora
Am 13.11.2016 um 00:53 schrieb Enrico Hoepfner: > Hi Jan, > > Thank you for the fast answer! > I dont understand exacly , which patch and test from Paul you mean. > Maybe I have take the diff in the wrong direction sorry for that! > > this are the new lines > > < // seq = ++in-

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-12 Thread Enrico Hoepfner
Hi Jan, Thank you for the fast answer! I dont understand exacly , which patch and test from Paul you mean. Maybe I have take the diff in the wrong direction sorry for that! this are the new lines < // seq = ++in->master.w1.seq ; < // seq should not be zero or > 0x

Re: [Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-12 Thread Jan Kandziora
Am 12.11.2016 um 19:31 schrieb Enrico Hoepfner: > in my opinion there is a bug in ow_w1_send.c - that sequence number for > netlink can run over 0x. > this makes the problem that the message which is send (65536 & 0x), > has a different sequence number as the Response is watinting for (65

[Owfs-developers] owfs - bug in ow_w1_send.c

2016-11-12 Thread Enrico Hoepfner
in my opinion there is a bug in ow_w1_send.c - that sequence number for netlink can run over 0x. this makes the problem that the message which is send (65536 & 0x), has a different sequence number as the Response is watinting for (65536). I've try the following patch to reset sequence nu