[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-04-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-04-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|fedora-gooey-karma-0.1-4.fc

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-04-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #32 from Adam Williamson awill...@redhat.com --- We should probably write up gooey-karma in the appropriate places on the wiki, just like easy-karma... -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-03-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- fedora-gooey-karma-0.1-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fedora-gooey-karma-0.1-4.fc19 -- You are receiving

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-03-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-03-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- fedora-gooey-karma-0.1-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/fedora-gooey-karma-0.1-4.fc20 -- You are receiving

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-03-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-03-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-03-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #26 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-03-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Branislav Blaskovic branis...@blaskovic.sk changed: What|Removed |Added CC|

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-03-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-03-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs:

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-03-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #23 from Branislav Blaškovič bblas...@redhat.com --- Spec URL: http://blaskovic.fedorapeople.org/fedora-gooey-karma/fedora-gooey-karma.spec SRPM URL:

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Flags|needinfo?(msu...@redhat.com |

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2014-01-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Branislav Blaškovič bblas...@redhat.com changed: What|Removed |Added Flags|

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-12-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #20 from Branislav Blaškovič bblas...@redhat.com --- Spec URL: http://blaskovic.fedorapeople.org/fedora-gooey-karma/fedora-gooey-karma.spec SRPM URL:

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-11-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #19 from Miroslav Suchý msu...@redhat.com --- Can you please post link to your latest SPEC and SRC.RPM? Oh, I see you are still updating the same files. Please do not do that. Every change - even if it is just your own and it does

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added CC||msu...@redhat.com

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #17 from Branislav Blaškovič bblas...@redhat.com --- (In reply to Terje Røsten from comment #15) Thanks for improvements, if you could post urls to your updated spec, srpm and do a koji scratch build it would help a lot :-) It

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #15 from Terje Røsten terje...@phys.ntnu.no --- Thanks for improvements, if you could post urls to your updated spec, srpm and do a koji scratch build it would help a lot :-) -- You are receiving this mail because: You are on

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #16 from Michael Schwendt bugs.mich...@gmx.net --- File at Spec URL differs from spec file in src.rpm at SRPM URL. The %doc line is different. If you kept those two lines in the review ticket up-to-date, it would become convenient

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #14 from Branislav Blaškovič bblas...@redhat.com --- Created attachment 816073 -- https://bugzilla.redhat.com/attachment.cgi?id=816073action=edit Icon mockup fedora-gooey-karma has icon! I've asked Máirín Duffy for them and she

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #13 from Adam Williamson awill...@redhat.com --- branislav: I think it's fine to skip the man pages, and the other two steps would be nice but probably don't block the review. We should probably try and find you a sponsor. -- You

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #11 from Branislav Blaškovič bblas...@redhat.com --- I might change the Source0 to https://github.com/blaskovic/fedora-gooey-karma/archive/%{name}-%{version}. tar.gz , as that's what the file is actually called once it gets

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #12 from Branislav Blaškovič bblas...@redhat.com --- TODO: - Man pages for binary? (man fedora-gooey-karma) - Graphical icon? - Summary improve. -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added CC|

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Branislav Blaškovič bblas...@redhat.com changed: What|Removed |Added Blocks||177841

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Adam Williamson awill...@redhat.com changed: What|Removed |Added CC|

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #1 from Adam Williamson awill...@redhat.com --- First thing I see, no check on the .desktop file is run: It is not simply enough to just include the .desktop file in the package, one MUST run desktop-file-install (in %install) OR

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #2 from Adam Williamson awill...@redhat.com --- You can drop the Buildroot: Fedora (as of F-10) does not require the presence of the BuildRoot tag in the spec and if one is defined it will be ignored. The provided buildroot will

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #3 from Adam Williamson awill...@redhat.com --- The provided .src.rpm doesn't seem to have been built from the provided .spec: its Source0 is http://blaskovic.fedorapeople.org/fedora-gooey-karma/0.1.tar.gz , which doesn't match the

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #4 from Adam Williamson awill...@redhat.com --- The source tree clearly specifies the license to be GPLv3+, but the License: tag in the spec file states GPLv2+ . -- You are receiving this mail because: You are on the CC list for

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #5 from Branislav Blaškovič bblas...@redhat.com --- Thank you for review! (In reply to Adam Williamson from comment #1) First thing I see, no check on the .desktop file is run: Added. (In reply to Adam Williamson from comment

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #6 from Adam Williamson awill...@redhat.com --- I might change the Source0 to https://github.com/blaskovic/fedora-gooey-karma/archive/%{name}-%{version}.tar.gz , as that's what the file is actually called once it gets through

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #7 from Adam Williamson awill...@redhat.com --- Why is the .desktop file marked OnlyShowIn=GNOME; ? Is there some reason it won't work on other desktops? The app not having an icon is kinda bad, you could ask if the art team could

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 Adam Williamson awill...@redhat.com changed: What|Removed |Added Assignee|awill...@redhat.com

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839 --- Comment #9 from Adam Williamson awill...@redhat.com --- Going through the review process, consider all 'MUST' and 'SHOULD' elements as OK unless posted here... rpmlint output: [adamw@vaioz noarch]$ rpmlint