[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #15 from

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #14 from Fabio Valentini --- Just as a friendly reminder (I got used to doing this after approving packages): You might want to add the python-packagers-sig and / or rust-sig groups as co-maintainers of this package (like

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #13 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rpds-py -- You are receiving this mail because: You are always notified about changes to

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #12 from Mattia Verga --- Thanks, I'll apply the above suggestions in the final import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 Ben Beasley changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 Ben Beasley changed: What|Removed |Added Flags||fedora-review? Status|NEW

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #10 from Fabio Valentini --- Looks OK from Rust POV now. I have not much experience with modern Python packaging ... Ben, do you want to finish the offial review, or should I do that? -- You are receiving this mail because: You

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 Mattia Verga changed: What|Removed |Added Blocks||2223179 Referenced Bugs:

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #9 from Ben Beasley --- (In reply to Ben Beasley from comment #8) > Ignoring the duplicates is the usual approach, and is unproblematic. By this, I don’t mean using %ignore, I just mean allowing the license files to be

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #8 from Ben Beasley --- (In reply to Mattia Verga from comment #7) > Ok, so I've updated the specfile by manually adding the license files with > %license macro. > This obviously will install duplicated license files, as %license

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #7 from Mattia Verga --- Ok, so I've updated the specfile by manually adding the license files with %license macro. This obviously will install duplicated license files, as %license macro copies files in the appropriate dir. Or

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #6 from Ben Beasley --- (In reply to Mattia Verga from comment #3) > The LICENSES.dependencies file is already added to the package by python > macros in the same dir as the main license file. Is there a way to know it > is

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #5 from Fedora Review Service --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6174902 (succeeded) Review template:

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #4 from Fedora Review Service --- Created attachment 1975909 --> https://bugzilla.redhat.com/attachment.cgi?id=1975909=edit The .spec file difference from Copr build 6166611 to 6174902 -- You are receiving this mail because:

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 --- Comment #3 from Mattia Verga --- (In reply to Fabio Valentini from comment #2) > Quick comments from Rust point of view: > > - outdated BuildRequires: > > "BuildRequires: rust-packaging" is obsolete, that package no longer exists. >

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com --- Comment

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 Fedora Review Service changed: What|Removed |Added URL||https://github.com/crate-py

[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

https://bugzilla.redhat.com/show_bug.cgi?id=367 Mattia Verga changed: What|Removed |Added Doc Type|--- |If docs needed, set a value