Re: [pacman-dev] [PATCH v2] lock file may be left behind when a signal arrives while in cleanup

2020-12-02 Thread Andrew Gregory
On 12/02/20 at 08:02pm, lilydjwg wrote: > Hi there, > > Is there anything remaining I could do to get this merged? Yesterday we > had a dangling db.lck again when a member lost his connection to the > server while running devtools. > > On Wed, Aug 12, 2020 at 11:17:49PM +0800, lilydjwg wrote: >

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Andrew Gregory
On 10/28/20 at 01:17am, Morgan Adamiec wrote: > > > On 28/10/2020 01:13, Eli Schwartz wrote: > > On 10/27/20 8:59 PM, Morgan Adamiec wrote: > >> On 28/10/2020 00:46, Eli Schwartz wrote: > >>> It remains unclear to me, why the ambiguity matters. > >>> > >> > >> I guess if you were to officially

Re: [pacman-dev] [PATCH] repo-add: add --include-sigs option

2020-09-20 Thread Andrew Gregory
On 09/21/20 at 03:19pm, Allan McRae wrote: > On 4/9/20 12:55 pm, Allan McRae wrote: > > On 4/9/20 12:40 pm, Eli Schwartz wrote: > >> On 9/2/20 11:02 PM, Allan McRae wrote: > >>> Pacman now downloads the signature files for all packages when present in > >>> a > >>> repository. That makes

Re: [pacman-dev] [PATCH] util.c: table_print_line: properly align texts involving CJK

2020-09-12 Thread Andrew Gregory
On 09/12/20 at 04:25pm, Chih-Hsuan Yen wrote: > Fixes FS#59229 > > Signed-off-by: Chih-Hsuan Yen > --- > src/pacman/util.c | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/src/pacman/util.c b/src/pacman/util.c > index e9187529..b45ca22d 100644 >

Re: [pacman-dev] [PATCH v4] libalpm: Add support for trigger dropins

2020-09-04 Thread Andrew Gregory
On 09/04/20 at 12:22pm, Allan McRae wrote: ... > I'm trying to figure out how includes would address this problem. > > We have a hook that runs when its triggers are met. We want to have a > package add additional triggers, by dropping in a file into our config, > but do not want to duplicate

Re: [pacman-dev] [PATCH] Add pacman-conf zsh completions

2020-09-03 Thread Andrew Gregory
On 08/21/20 at 08:20pm, Ronan Pigott wrote: > From: Ronan Pigott > > Signed-off-by: Ronan Pigott Sure, I guess. pacman-conf is meant for use in scripts; who on Earth is running it in a terminal?

Re: [pacman-dev] [PATCH 0/1] Introduce "AssumeInstalled" option in the config file

2020-09-03 Thread Andrew Gregory
On 09/03/20 at 12:17pm, Damjan Georgievski wrote: > On Sun, 30 Aug 2020 at 19:13, Eli Schwartz wrote: > > > > On 8/30/20 1:07 PM, Дамјан Георгиевски wrote: > > > I have had at least two or three use cases for this option, > > > * one has been since I always have to type > > > pacman -Syu

Re: [pacman-dev] [PATCH] NO_MSGSIGNAL and SIGPOLL don't exist on darwin

2020-09-03 Thread Andrew Gregory
On 09/01/20 at 03:50pm, Cameron Katri wrote: > I believe I found a more portable solution. We use signal(SIGPIPE, > SIG_IGN); which will block SIGPIPE, and if MSG_NOSIGNAL is not > supported we set it to 0x0 so that it just gets ignored. Hopefully > this is a more comprehensive solution. ... >

Re: [pacman-dev] [PATCH v4] libalpm: Add support for trigger dropins

2020-08-30 Thread Andrew Gregory
On 08/24/20 at 10:34pm, Daan De Meyer wrote: > > What about adding Include support to hooks? Then hooks that need this > > type of functionality could explicitly include trigger files from > > a particular directory, insulating the process from simple hook > > renaming and hopefully making it

Re: [pacman-dev] [PATCH] Disable embedded signatures by default

2020-08-30 Thread Andrew Gregory
On 08/28/20 at 02:37pm, Allan McRae wrote: > On 27/8/20 10:26 am, Anatol Pomozov wrote: > > Hi > > > > On Mon, Aug 10, 2020 at 2:45 PM Eli Schwartz > > wrote: > >> This is the right approach, yeah. I was thinking we'd wait until pacman > >> 6.1 before stopping the signature embedding, to

Re: [pacman-dev] [PATCH v4] libalpm: Add support for trigger dropins

2020-08-24 Thread Andrew Gregory
On 08/24/20 at 11:22am, Allan McRae wrote: > Lets take a step back here... > > I don't really care about the kernel use case, but more whether this > could be more generally used. Here are other examples I came up with. > > Font caches: > A package could drop a config file in /etc/font/conf.d/

Re: [pacman-dev] [PATCH] lock file may be left behind when a signal arrives while in cleanup

2020-08-12 Thread Andrew Gregory
On 08/12/20 at 01:36pm, lilydjwg wrote: > When a SIGINT or SIGHUP arrives before alpm_unlock (in alpm_release) but > after remove_soft_interrupt_handler, the lock file will be left behind. > > Signed-off-by: lilydjwg > --- > src/pacman/pacman.c | 2 +- > 1 file changed, 1 insertion(+), 1

[pacman-dev] [GIT] The official pacman repository annotated tag, v5.2.2, created. v5.2.2

2020-06-26 Thread Andrew Gregory
1af39 (tag) tagging 5537881b2525a4f114fcf10b00413b4575a74968 (commit) replaces v5.2.1 tagged by Andrew Gregory on Thu Jun 25 23:46:11 2020 -0700 - Log - v5.2.2 -BEGIN PGP SIGNATURE- iQEzBAABCAAdFiEEuBUbEXA3

[pacman-dev] [GIT] The official pacman repository branch, release/5.2.x, updated. v5.2.2

2020-06-26 Thread Andrew Gregory
or: Andrew Gregory Date: Mon Jun 22 02:15:23 2020 -0700 Release 5.2.2 Signed-off-by: Andrew Gregory commit 027c87ae3f7f4728b4058adb23baf7612cc5ea77 Author: Andrew Gregory Date: Mon Jun 22 02:12:41 2020 -0700 update NEWS for 5.2.2 Signed-off-by: Andrew Gregor

[pacman-dev] [GIT] The official pacman repository branch, release/5.2.x, updated. v5.2.1-24-g1e9cd30e

2020-06-18 Thread Andrew Gregory
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, release/5.2.x has been updated via 1e9cd30e488cd133d24eac7ed9cac7806db2c406 (commit)

Re: [pacman-dev] [PATCH v3] Fallback to detached signatures during keyring check

2020-06-03 Thread Andrew Gregory
On 06/01/20 at 11:45pm, Anatol Pomozov wrote: > Pacman has a 'key in keyring' verification step that makes sure the signatures > have a valid keyid. Currently pacman parses embedded package signatures only. > > Add a fallback to detached signatures. If embedded signature is missing then > it >

Re: [pacman-dev] [PATCH] libalpm/signing.c: Fix calculation of packet size in parse_subpacket

2020-05-31 Thread Andrew Gregory
On 05/20/20 at 02:22pm, Allan McRae wrote: > Given RFC 4880 provides the code to do this calculation, I am not sure > how I managed to stuff that up! This bug was only exposed when a > signature made with "include-key-block" was added to the Arch repos, > which provided a subpacket with the

Re: [pacman-dev] [PATCH v2] Fallback to detached signatures during keyring check

2020-05-31 Thread Andrew Gregory
On 05/31/20 at 01:37am, Anatol Pomozov wrote: > Hi Andrew, thank you for the quick response > > On Sat, May 30, 2020 at 9:31 PM Andrew Gregory > wrote: > > > > On 05/30/20 at 07:51pm, Anatol Pomozov wrote: > > > Pacman has a 'key in keyring'

Re: [pacman-dev] [PATCH v2] Fallback to detached signatures during keyring check

2020-05-30 Thread Andrew Gregory
On 05/30/20 at 07:51pm, Anatol Pomozov wrote: > Pacman has a 'key in keyring' verification step that makes sure the signatures > have a valid keyid. Currently pacman parses embedded package signatures only. > > Add a fallback to detached signatures. If embedded signature is missing then > it >

Re: [pacman-dev] [PATCH v2] alpm: Add better logging when a command fails to execute correctly

2020-05-23 Thread Andrew Gregory
On 05/23/20 at 02:04pm, Daan De Meyer wrote: > This makes debugging hook failures when running pacman less of a > hassle. Instead of a generic "command failed to execute correctly", > we now get the exact command and its arguments, as well as the exit > code of the command logged. > >

Re: [pacman-dev] [PATCH] Avoid depending on side effects in assert(...) expressions

2020-05-15 Thread Andrew Gregory
On 05/14/20 at 11:30pm, Anatol Pomozov wrote: > Hi > > On Wed, May 13, 2020 at 7:54 PM Andrew Gregory > wrote: > > > > You say > > that the only way there would not be a corresponding progress bar is > > if the progress event is called without an init eve

Re: [pacman-dev] [PATCH] Avoid depending on side effects in assert(...) expressions

2020-05-13 Thread Andrew Gregory
On 05/13/20 at 12:08pm, Anatol Pomozov wrote: > > --- > > It's perhaps worth mentioning that nowhere else in the ALPM codebase > > do we use assert(). > > I quite like the idea of defensive programming. This is something that > I learnt the hard way when I was working with chips firmware. > So I

Re: [pacman-dev] [PATCH] Split target output

2020-04-18 Thread Andrew Gregory
On 04/17/20 at 06:57pm, Carson Black wrote: > This patch splits the monolithic 'Packages (count):' output on transactions > into > multiple package outputs per category of action: 'Installing (count):', > 'Upgrading > (count):', and 'Removing (count):'. > > Signed-off-by: Carson Black > --- >

Re: [pacman-dev] [PATCH] Use noextract with pacman-conf NoExtract

2020-04-01 Thread Andrew Gregory
On 04/01/20 at 11:29am, Eli Schwartz wrote: > From: Earnestly > > Current code accidently uses noupgrade for the NoExtract directive. > > https://medium.com/@Code_Analysis/the-last-line-effect-7b1cb7f0d2a1 > > Signed-off-by: Eli Schwartz > --- ACK

Re: [pacman-dev] [PATCH] Increase maximum database size

2020-01-18 Thread Andrew Gregory
On 01/19/20 at 09:42am, Allan McRae wrote: > We previously has the maximum database size as 25MB. This was set in the days > before repos had as many packages as they do now, and before we started > distributing files databases. Increase this limit to 128MB. > > Signed-off-by: Allan McRae >

Re: [pacman-dev] [PATCH 1/2] Attempted to free lock on failure in alpm_db_update()

2019-12-18 Thread Andrew Gregory
On 12/19/19 at 11:17am, Allan McRae wrote: > On 17/12/19 5:13 pm, Andrew Gregory wrote: > > s/Attempted to//? > > > > On 12/17/19 at 01:04am, Allan McRae wrote: > >> Also fixes a memory leak under an error condition. > >> > >> Signed-off-by: Allan

Re: [pacman-dev] [PATCH 2/2] Backup old database before updating and restore on failure

2019-12-18 Thread Andrew Gregory
On 12/17/19 at 01:05am, Allan McRae wrote: > If alpm_db_update() fails due to an invalid signature, then the system > is left with an unusable repo database. Instead, backup the currently > working database before performing the update, and restore on error. > > Note that the calls rename and

Re: [pacman-dev] [PATCH 1/2] Attempted to free lock on failure in alpm_db_update()

2019-12-16 Thread Andrew Gregory
s/Attempted to//? On 12/17/19 at 01:04am, Allan McRae wrote: > Also fixes a memory leak under an error condition. > > Signed-off-by: Allan McRae > --- > lib/libalpm/be_sync.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/lib/libalpm/be_sync.c

Re: [pacman-dev] [PATCH] Handle .part files that are the size of the correct package

2019-11-15 Thread Andrew Gregory
On 11/15/19 at 11:46pm, Allan McRae wrote: > In rare cases, likely due to a well timed Ctrl+C, but possibly due to a > broken mirror, a ".part" file may have size at least that of the correct > package size. > > When encountering this issue, currently pacman fails in different ways > depending on

Re: [pacman-dev] [PATCH] Add Eli to current maintainers

2019-11-15 Thread Andrew Gregory
On 11/16/19 at 12:15am, Allan McRae wrote: > Also retire Dan into past major contributors. ACK.

Re: [pacman-dev] Alternatives system brainstorm

2019-10-19 Thread Andrew Gregory
On 10/19/19 at 10:43pm, Allan McRae wrote: > On 19/10/19 10:41 pm, Allan McRae wrote: > > On 19/10/19 10:38 pm, Allan McRae wrote: > >> On 19/10/19 10:24 pm, Andrew Gregory wrote: > >>> No rebuilding necessary if the conflicts are changed to just 'sh'. > >>

Re: [pacman-dev] Alternatives system brainstorm

2019-10-19 Thread Andrew Gregory
On 10/19/19 at 10:15pm, Allan McRae wrote: > On 19/10/19 9:57 pm, Daan van Rossum wrote: > > * on Saturday, 2019-10-19 18:15 +1000, Allan McRae > > wrote: > > > >> /bin/sh -> bash/dash > >> /usr/bin/awk -> gawk/nawk > >> /usr/bin/cc -> gcc/clang > > > > Can we provide alternatives by means of

Re: [pacman-dev] configure syntax error even after issuing autogen.sh

2019-10-18 Thread Andrew Gregory
On 10/18/19 at 06:38pm, Saul Tigh wrote: > Dear pacman developers, > > First time poster here, so please be gentle. I've been trying to compile > pacman from git and I constantly run into an issue. First I issue > ./autogen.sh and then ./configure but this error always pops up: > > ./configure:

[pacman-dev] [PATCH] remove: improve broken dependency error message

2019-10-13 Thread Andrew Gregory
This message was clarified for sync operations in 2b1b7b70753eb56bee08cd270efc7cfa342bc0ec. Signed-off-by: Andrew Gregory --- src/pacman/remove.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pacman/remove.c b/src/pacman/remove.c index 9d44cf53..0eeb19d3 100644

Re: [pacman-dev] [PATCH v2 3/3] run XferCommand via exec

2019-10-12 Thread Andrew Gregory
On 10/12/19 at 09:11pm, Allan McRae wrote: > On 12/10/19 1:45 pm, Andrew Gregory wrote: > > system() runs the provided command via a shell, which is subject to > > command injection. Even though pacman already provides a mechanism to > > sign and verify the databases contain

[pacman-dev] [PATCH v2 2/3] add arg_to_string helper

2019-10-11 Thread Andrew Gregory
Converts an argc/argv pair to a string for presentation to the user. Signed-off-by: Andrew Gregory --- src/pacman/pacman.c | 26 +- src/pacman/util.c | 23 +++ src/pacman/util.h | 1 + 3 files changed, 29 insertions(+), 21 deletions(-) diff

[pacman-dev] [PATCH v2 3/3] run XferCommand via exec

2019-10-11 Thread Andrew Gregory
vulnerable to MITM attacks. Replacing the system call with an almost equivalent exec call removes the possibility of a shell-injection attack for those users. Signed-off-by: Andrew Gregory --- v2: * properly deal with signals * pass errno via pipe instead of mmap * fix debug logging src

[pacman-dev] [PATCH v2 1/3] move wordsplit into common for sharing

2019-10-11 Thread Andrew Gregory
Signed-off-by: Andrew Gregory --- v2: removes _alpm_prefix and moves to util-common lib/libalpm/hook.c | 119 +-- src/common/util-common.c | 112 src/common/util-common.h | 3 + 3 files changed, 118 insertions

Re: [pacman-dev] [PATCH 2/4] libalpm: resolvedep(): don't compare names twice

2019-09-10 Thread Andrew Gregory
On 09/08/19 at 10:45pm, morganamilo wrote: > If we failed to get the pkg from pkgcache then we know no satisfying > package exists by name. So only compare provides. > --- > lib/libalpm/deps.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/libalpm/deps.c

Re: [pacman-dev] [PATCH] pacman: better handle -F when file is not found

2019-09-10 Thread Andrew Gregory
On 09/09/19 at 05:49pm, morganamilo wrote: > Error messages are now printed. > Pacman now returns 1 if any of the files queried are not found. > --- > src/pacman/files.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/src/pacman/files.c

Re: [pacman-dev] pacman --print bug

2019-08-12 Thread Andrew Gregory
On 08/12/19 at 02:15pm, AstroSnail via pacman-dev wrote: > Hi, > > I think I found a bug in pacman. > > When a package remove operation can't be satisfied, pacman prints an > error, describes what went wrong, and does nothing: > $ sudo pacman -R linux-api-headers > checking

Re: [pacman-dev] [PATCH] pacman/callback: fix buffer over-read

2019-08-03 Thread Andrew Gregory
On 08/03/19 at 01:27am, László Várady wrote: > Commit 11ab9aa9f5f0f3873df89c73e8715b82f485bd9b replaced a strcpy() call > with memcpy(), without copying the terminating null character. > > Since fname is allocated with malloc(), subsequent strstr() calls will > overrun the buffer's boundary. > >

Re: [pacman-dev] [PATCH] libalpm: fix documentation for alpm_pkg_mtree_next

2019-07-03 Thread Andrew Gregory
On 06/21/19 at 03:24pm, Morgan Adamiec wrote: > On Thu, 20 Jun 2019 at 05:46, Allan McRae wrote: > > > > On 14/6/19 11:26 pm, Dave Reisner wrote: > > > On Fri, Jun 14, 2019 at 02:19:52PM +0100, Morgan Adamiec wrote: > > >> On Fri, 14 Jun 2019 at 14:09, Dave Reisner wrote: > > >>> > > >>> On Fri,

Re: [pacman-dev] [PATCH v2] doc: Add a man page describing PKGINFO

2019-06-30 Thread Andrew Gregory
On 06/29/19 at 11:18pm, Eli Schwartz wrote: > On 6/28/19 2:55 PM, Jelle van der Waa wrote: > > From: Jelle van der Waa > > > > Describe the PKGINFO format which resides in a package produced makepkg. > As mentioned on IRC, there's a lot of duplication with the PKGBUILD > fields, so I'd feel

Re: [pacman-dev] [PATCH v2] doc: Add a man page describing PKGINFO

2019-06-29 Thread Andrew Gregory
On 06/28/19 at 08:55pm, Jelle van der Waa wrote: > From: Jelle van der Waa > > Describe the PKGINFO format which resides in a package produced makepkg. > --- > doc/Makefile.am| 4 +- > doc/PKGINFO.5.asciidoc | 87 ++ > doc/meson.build| 1

Re: [pacman-dev] [PATCH] fixup run XferCommand via exec

2019-06-11 Thread Andrew Gregory
On 06/11/19 at 11:06am, Allan McRae wrote: > On 10/6/19 6:50 am, Andrew Gregory wrote: > > Does anybody know what usepart was for? It was unset unless %o was > > used in XferCommand, but I'm not sure what the use case for an > > XferCommand without %o would be. > > Wh

[pacman-dev] [PATCH] fixup run XferCommand via exec

2019-06-09 Thread Andrew Gregory
--- A few changes I omitted from the initial patch. Does anybody know what usepart was for? It was unset unless %o was used in XferCommand, but I'm not sure what the use case for an XferCommand without %o would be. src/pacman/conf.c | 11 ---

[pacman-dev] [PATCH 2/2] [WIP] run XferCommand via exec

2019-06-09 Thread Andrew Gregory
--- systemvp should pretty much be a drop-in replacement for system with the exception that it takes an argv array and uses exec. If anybody wants to play with it to stress test it a little, I have a self-contained copy and test program at:

[pacman-dev] [PATCH 1/2] [WIP] move wordsplit into ini for sharing

2019-06-09 Thread Andrew Gregory
Not technically related to INI parsing, but we use it with INI files. --- lib/libalpm/hook.c | 113 - src/common/ini.c | 113 + src/common/ini.h | 3 ++ 3 files changed, 116 insertions(+), 113

[pacman-dev] [PATCH] use consistent time notation for the log

2019-06-08 Thread Andrew Gregory
%X is locale-dependent, making it impossible to reliably parse and potentially overflowing the buffer. %T is consistent across locales. Also fixes some adjacent whitespace. Signed-off-by: Andrew Gregory --- lib/libalpm/log.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[pacman-dev] [PATCH 2/2] create coredump on segfault

2019-06-07 Thread Andrew Gregory
Overriding the segfault handler prevents the creation of core dumps by the default handler, which makes debugging segfaults difficult. Signed-off-by: Andrew Gregory --- src/pacman/sighandler.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/src

[pacman-dev] [PATCH 1/2] sighandler: block signals while handling SIGSEGV

2019-06-07 Thread Andrew Gregory
If we get SIGSEGV we need to bail out quickly, leaving other signals unblocked could lead to other signal handlers getting triggered. Signed-off-by: Andrew Gregory --- Signals are hard. I'd appreciate if somebody could double check my math on these patches. src/pacman/sighandler.c | 2 +- 1

[pacman-dev] [PATCH] hooks: rename type File to Path

2019-06-03 Thread Andrew Gregory
in a future release. See FS#53136. Signed-off-by: Andrew Gregory --- doc/alpm-hooks.5.asciidoc | 17 + lib/libalpm/hook.c | 8 ++-- test/pacman/tests/hook-file-change-packages.py | 2 +- .../tests/hook-file-remove-trigger

[pacman-dev] [PATCH] makepkg: restrict pkgname and pkgver to ascii

2019-06-03 Thread Andrew Gregory
reducing the number of packages with non-ascii data in the wild before updating libalpm to reject them outright. See https://github.com/libarchive/libarchive/wiki/Filenames and https://github.com/libarchive/libarchive/issues/587 Signed-off-by: Andrew Gregory --- scripts/libmakepkg/lint_pkgbuild

Re: [pacman-dev] [PATCH] Add config var to limit repo connection timeout

2019-04-07 Thread Andrew Gregory
On 04/06/19 at 04:43pm, Nathan Aclander wrote: > > I'm fairly new to using git send-email, so I wasn't sure how to add an > explanation to the patch while cleanly separating it from the git commit > message. I can speak more to why I found it useful. Use --annotate and put comments you don't

Re: [pacman-dev] [PATCH] Fix clang 8 string-plus-int warnings

2019-04-06 Thread Andrew Gregory
On 04/05/19 at 12:02am, Rikard Falkeborn wrote: > Clang 8 warns that adding a string to an integer does not append to > string. Indeed it doesn't, but that was not the intentetion. Use array > indexing as suggested by the compiler to silence the warning. There > should be no functional change. >

Re: [pacman-dev] [PATCH] Style: Removing unecessary indentation level.

2019-04-06 Thread Andrew Gregory
On 04/04/19 at 12:21am, Leonardo Bras wrote: > Signed-off-by: Leonardo Bras > --- > src/pacman/sync.c | 84 --- > 1 file changed, 43 insertions(+), 41 deletions(-) I appreciate the reduction of indentation, but I think this does more harm than good.

Re: [pacman-dev] Alternatives system

2019-03-31 Thread Andrew Gregory
On 04/01/19 at 09:56am, Allan McRae wrote: > Hi all, > > I plan to finish implementing an alternatives system for pacman post 5.2 > release: > https://wiki.archlinux.org/index.php/User:Allan/Alternatives > > Any comments or suggestions? "All alternatives are symlinked in /usr/bin so no need to

Re: [pacman-dev] should repo-add handle *.links.db?

2019-03-26 Thread Andrew Gregory
On 03/26/19 at 10:42pm, Erich Eckner wrote: > On Wed, 27 Mar 2019, Allan McRae wrote: > > > On 27/3/19 7:20 am, Erich Eckner wrote: > >> https://mirror.pkgbuild.com/core/os/x86_64/core.links.tar.gz > >> > >> It contains (as far as I can tell) the names and versions of libraries > >> against which

Re: [pacman-dev] New Optional Dependencies Aren't Logged.

2019-03-17 Thread Andrew Gregory
On 03/17/19 at 06:02pm, Ralph Corderoy wrote: > Hi Andrew, > > > I'm not trying to weaken anything; you simply haven't told us why you > > needed the information beyond "I wanted to". If there was an actual > > problem you were trying to solve, describing it might help us come up > > with a

Re: [pacman-dev] New Optional Dependencies Aren't Logged.

2019-03-17 Thread Andrew Gregory
On 03/17/19 at 04:49pm, Ralph Corderoy wrote: > Hi Andrew, > > > Based on your description, this sounds like a case of "I was mildly > > curious about something this one time > > No, it would have been useful to know. There's no need to overly weaken > it. I'm not trying to weaken anything;

Re: [pacman-dev] New Optional Dependencies Aren't Logged.

2019-03-17 Thread Andrew Gregory
On 03/17/19 at 03:31pm, Ralph Corderoy wrote: > `pacman -Su' suggested an optional dependency of gst-plugins-bad. > I looked to see what that was and didn't want it. Later, due to > discussion on the local LUG IRC, I wanted to look up what package had > the new optional depends but found

Re: [pacman-dev] [PATCH 0/5][RFC] Die delta, die!

2019-03-03 Thread Andrew Gregory
On 03/04/19 at 11:23am, Allan McRae wrote: > On 2/3/19 8:19 pm, Allan McRae wrote: > > Deltas are broken. So much so that I would strongly recommend never > > using a delta from a repo that you did not generate yourself. In short, > > we call "system(command)", with a command that includes the

Re: [pacman-dev] [PATCH] libalpm: Check cachedir access before re-creating

2019-02-04 Thread Andrew Gregory
On 01/23/19 at 10:52pm, David Phillips wrote: > If users have mounted a filesystem such as sshfs or NFS that doesn't > allow root access by default for security reasons, _alpm_filecache_setup > will blindly try and re-create the components of the cachedir path, > eating EACCES (to be liek mkdir

Re: [pacman-dev] [PATCH] Check for all return values of _alpm_key_in_keychain

2019-01-24 Thread Andrew Gregory
On 04/21/17 at 04:07pm, David Phillips wrote: > This fixes a bug I encountered with a GPG keyring where the > key id used to locate a key in the keyring was ambiguous within > my keychain. > > This commit ensures that all valid return values are checked to > catch this and related error cases

Re: [pacman-dev] [PATCH] Add [ignored] to -Qu output for packages in repos that are not Usage = Upgrade

2019-01-04 Thread Andrew Gregory
On 01/04/19 at 02:21pm, Allan McRae wrote: > The behaviour of "pacman -Qu" was very strange... It would only consider > packages from repos with Usage = Search (or All), and ignore those with > Usage = Sync, Install or Upgrade. > > This is because alpm_sync_newversion() used ALPM_DB_USAGE_SEARCH

[pacman-dev] [GIT] The official pacman repository annotated tag, v5.1.2, created. v5.1.2

2018-12-25 Thread Andrew Gregory
114f7 (tag) tagging 0b36d8781783d7f4a0086e12eb7cae542e7f6bd7 (commit) replaces v5.1.1 tagged by Andrew Gregory on Tue Dec 25 01:57:46 2018 -0800 - Log - v5.1.2 -BEGIN PGP SIGNATURE- iQEzBAABCAAdFiEEuBUbEXA3

[pacman-dev] [GIT] The official pacman repository branch, release/5.1.x, updated. v5.1.2

2018-12-25 Thread Andrew Gregory
email; so we list those revisions in full, below. - Log - commit 0b36d8781783d7f4a0086e12eb7cae542e7f6bd7 Author: Andrew Gregory Date: Sun Dec 23 14:33:01 2018 -0800 Release v5.1.2 Signed-off-by: Andrew Gregor

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-86-g6b541404

2018-12-25 Thread Andrew Gregory
ow. - Log - commit 6b541404cc691b2aea3d373e663d9628fda15a2b Author: Andrew Gregory Date: Sun Dec 23 14:30:49 2018 -0800 update NEWS for v5.1.2 Signed-off-by: Andrew Gregory (cherry picked from commit f8c73464c9cf86d6b917542585d745

[pacman-dev] [PATCH 3/4] tap.py: add skip_all function

2018-12-22 Thread Andrew Gregory
Signed-off-by: Andrew Gregory --- test/pacman/tap.py | 5 + 1 file changed, 5 insertions(+) diff --git a/test/pacman/tap.py b/test/pacman/tap.py index 6a3bee0d..eb0747be 100644 --- a/test/pacman/tap.py +++ b/test/pacman/tap.py @@ -21,6 +21,11 @@ def _output(msg): print("

[pacman-dev] [PATCH 2/4] remove unused test summary code

2018-12-22 Thread Andrew Gregory
Unused since 12e00af5315135a29a66c9aaa01e141a32d4634b Signed-off-by: Andrew Gregory --- test/pacman/pactest.py | 3 --- test/pacman/pmenv.py | 5 - 2 files changed, 8 deletions(-) diff --git a/test/pacman/pactest.py b/test/pacman/pactest.py index 85cce6a1..a563fa72 100755 --- a/test

[pacman-dev] [PATCH 4/4] allow tests for disabled features to be skipped

2018-12-22 Thread Andrew Gregory
with a single test (as both autotools and meson do), but will affect anybody manually running pactest.py with multiple tests at once. Signed-off-by: Andrew Gregory --- Makefile.am | 6 ++ test/pacman/meson.build | 25 - test/pacman/pactest.py

[pacman-dev] [PATCH 1/4] silence warning when built without curl

2018-12-22 Thread Andrew Gregory
Signed-off-by: Andrew Gregory --- lib/libalpm/handle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/libalpm/handle.c b/lib/libalpm/handle.c index f912d2f5..c491d87c 100644 --- a/lib/libalpm/handle.c +++ b/lib/libalpm/handle.c @@ -876,6 +876,8 @@ int SYMEXPORT

Re: [pacman-dev] [PATCH] Move skipping of duplicate sync/remove targets into libalpm

2018-12-13 Thread Andrew Gregory
On 12/13/18 at 11:44am, Michael Straube wrote: > sync: > As pointed out by Andrew Gregory there could be an error when adding > duplicates if they are two separate packages with the same name. Add a > check in alpm_add_pkg() to test whether the duplicate is actually the > same pac

Re: [pacman-dev] [PATCH] pacman: better warning message when skipping duplicate targets

2018-12-11 Thread Andrew Gregory
On 12/11/18 at 06:14pm, Michael Straube wrote: > Am 09.12.18 um 19:47 schrieb Andrew Gregory: > > On 12/09/18 at 06:31pm, Michael Straube wrote: > > > Change the warning message to reflect the reason when skipping duplicate > > > targets. skipping target -

Re: [pacman-dev] [PATCH] pacman: better warning message when skipping duplicate targets

2018-12-09 Thread Andrew Gregory
On 12/09/18 at 06:31pm, Michael Straube wrote: > Change the warning message to reflect the reason when skipping duplicate > targets. skipping target -> skipping duplicate target > > FS#49377 > > Signed-off-by: Michael Straube > --- > src/pacman/remove.c | 2 +- > src/pacman/sync.c | 2 +- >

Re: [pacman-dev] [PATCH] check localdb before upgrading package

2018-12-04 Thread Andrew Gregory
On 11/27/18 at 09:24pm, Allan McRae wrote: > On 17/11/18 1:47 pm, Andrew Gregory wrote: > > Commit 2ee7a8d89ad693617307260604e1d58757fd2978 replaced a manual check > > for a local package with a check for the "oldpkg" member, which gets set > > at the beginning of t

[pacman-dev] [PATCH 2/3] always allow explicit empty siglevel for sync dbs

2018-11-24 Thread Andrew Gregory
An empty siglevel does not do any signature verification which is exactly what we want when compiled without gpg support. This is already allowed in other parts of the codebase and required for the test suite to pass when compiled without gpg support. Fixes: FS#60880 Signed-off-by: Andrew

[pacman-dev] [PATCH 1/3] add specific error for missing gpg support

2018-11-24 Thread Andrew Gregory
"wrong or NULL argument passed" is a useless error for end users. Fixes FS#60880. Signed-off-by: Andrew Gregory --- lib/libalpm/alpm.h| 4 +++- lib/libalpm/be_sync.c | 2 +- lib/libalpm/error.c | 3 +++ lib/libalpm/handle.c | 6 +++--- 4 files changed, 10 insertions(+), 5

[pacman-dev] [PATCH 3/3] require actual siglevel for default

2018-11-24 Thread Andrew Gregory
ALPM_SIG_USE_DEFAULT does not refer to an actual siglevel, rather it indicates that the global default should be used in place of the operation-specific one. Setting this value for the global default itself makes no sense. Signed-off-by: Andrew Gregory --- lib/libalpm/handle.c | 5 - 1

[pacman-dev] [GIT] The official pacman repository branch, release/5.1.x, updated. v5.1.1-8-g3a88fcb1

2018-11-18 Thread Andrew Gregory
tification email; so we list those revisions in full, below. - Log - commit 3a88fcb19199c5b5fa18162f5f9dc8990311dbd2 Author: Andrew Gregory Date: Fri Oct 12 19:16:53 2018 -0700 handle EINTR while polling scripts/hooks

Re: [pacman-dev] [PATCH] check localdb before upgrading package

2018-11-17 Thread Andrew Gregory
On 11/17/18 at 08:02pm, Eli Schwartz wrote: > On 11/16/18 10:47 PM, Andrew Gregory wrote: > > Commit 2ee7a8d89ad693617307260604e1d58757fd2978 replaced a manual check > > for a local package with a check for the "oldpkg" member, which gets set > > at t

[pacman-dev] [PATCH] add missing tests to meson.build

2018-11-16 Thread Andrew Gregory
Signed-off-by: Andrew Gregory --- test/pacman/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/pacman/meson.build b/test/pacman/meson.build index 90885015..3ad1fcd0 100644 --- a/test/pacman/meson.build +++ b/test/pacman/meson.build @@ -158,6 +158,8 @@ pacman_tests

[pacman-dev] [PATCH] common/ini: remove unnecessary alpm include

2018-11-16 Thread Andrew Gregory
Signed-off-by: Andrew Gregory --- src/common/ini.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/common/ini.c b/src/common/ini.c index 8e646528..30f1fac8 100644 --- a/src/common/ini.c +++ b/src/common/ini.c @@ -19,10 +19,9 @@ #include #include +#include

[pacman-dev] [PATCH] check localdb before upgrading package

2018-11-16 Thread Andrew Gregory
no longer be in the local db and pacman would try to remove it twice, resulting in superfluous error messages. Fixes: FS#50875, FS#5554 Signed-off-by: Andrew Gregory --- lib/libalpm/add.c | 2 +- test/pacman/meson.build | 1 + test/pacman/t

Re: [pacman-dev] [PATCH] Add meson.build files to build with meson

2018-11-01 Thread Andrew Gregory
On 11/01/18 at 08:51pm, Dave Reisner wrote: > On Thu, Nov 01, 2018 at 01:03:27AM -0700, Andrew Gregory wrote: > > On 10/21/18 at 05:46pm, Dave Reisner wrote: ... > > > +libcommon = static_library( > > > + 'common', > > > + libcommon_sources, > > >

Re: [pacman-dev] [PATCH] Add meson.build files to build with meson

2018-11-01 Thread Andrew Gregory
On 10/21/18 at 05:46pm, Dave Reisner wrote: -- >8 -- (lots of words) > diff --git a/meson.build b/meson.build > new file mode 100644 > index ..3f9b2ae0 > --- /dev/null > +++ b/meson.build > @@ -0,0 +1,487 @@ -- >8 -- (many more words) > +PYTHON = find_program('python') This should

[pacman-dev] [GIT] The official pacman repository annotated tag, v3.0.0-rc1, updated. v3.0.0-rc1

2018-10-20 Thread Andrew Gregory
a77cf (tag) from 59ae306a5453e0113ffba8395db9df1b5507c650 (which is now obsolete) tagging 11fbc595d48d55be929e259285bb65e53ef33007 (commit) tagged by Andrew Gregory on Sat Oct 20 12:47:37 2018 -0700 - Log - repla

[pacman-dev] [GIT] The official pacman repository annotated tag, v3.0.0-rc2, updated. v3.0.0-rc2

2018-10-20 Thread Andrew Gregory
fa4a4 (tag) from b977b9c030861decd22376e4d2a9147e830ebfae (which is now obsolete) tagging 9e3a1853451230d887c3c89f49f04e502fb69621 (commit) replaces v3.0.0-rc1 tagged by Andrew Gregory on Sat Oct 20 12:53:22 2018 -0

[pacman-dev] [GIT] The official pacman repository annotated tag, v3.0.0, updated. v3.0.0

2018-10-20 Thread Andrew Gregory
48c18 (tag) from c6b17b224f264973f32291ec0e4101d1a9fd0af1 (which is now obsolete) tagging 58fe79eef64fb87b2553e6514a47beaa6d0249c1 (commit) replaces v3.0.0-rc2 tagged by Andrew Gregory on Sat Oct 20 12:45:51 2018 -0

Re: [pacman-dev] [PATCH] pacman: don't error when a group exists but all packages are ignored

2018-10-18 Thread Andrew Gregory
On 10/18/18 at 08:45pm, morganamilo wrote: > Currently when attempting to sync a group where all packages are > ignored (either by ignorepkg, ignoregroup or --needed) pacman > will error with "target not found". > > Instead, if a group has no packages, check if the group exists > and only throw

Re: [pacman-dev] [PATCH v2] libalpm: process needed before group selection

2018-10-17 Thread Andrew Gregory
On 10/17/18 at 04:40pm, morganamilo wrote: > When --needed is used, up to date packages are now filtered out > before showing the group select. > > Fixes FS#22870. > > Signed-off-by: morganamilo > --- > v2: Changed per Andrew's feedback. I wasn't concerned about the misleading message for this

Re: [pacman-dev] [PATCH] alpm: Do not raise SIGINT when filesize goes over limit

2018-10-17 Thread Andrew Gregory
On 10/09/18 at 06:29pm, Olivier Brunel wrote: > Variable dload_interrupted is used both to abort a download because > SIGINT was caught, and when a file limit is reached. But raising SIGINT > is only meant to happen in the first case. > > Signed-off-by: Olivier Brunel > --- ACK.

Re: [pacman-dev] [PATCH] alpm: Fix SIGINT handling re: aborting download

2018-10-17 Thread Andrew Gregory
On 10/09/18 at 06:29pm, Olivier Brunel wrote: > Upon receiving SIGINT a flag is set to abort the (curl) download. > However, since it was never reset/initialized, if a front-end doesn't > actually exit on SIGINT, and later tries any operation that needs to > perform a new download, said download

Re: [pacman-dev] [PATCH] libalpm: process needed before group selection

2018-10-17 Thread Andrew Gregory
On 09/22/18 at 05:24pm, morganamilo wrote: > When --needed is used, up to date packages are now filtered out > before showing the group select. > > Signed-off-by: morganamilo > --- > > This patch set is currently incomplete. There is a problem where if every > package in the group is already

Re: [pacman-dev] [PATCH 1/2] Port pactest to python3

2018-10-17 Thread Andrew Gregory
On 09/20/18 at 05:43am, Dave Reisner wrote: > Use BytesIO instead of StringIO, and ensure that we unicode-encode data > where needed. > --- Any particular reason for the bump or just dropping the (allegedly) dead python2? I've held off from doing this so far because asciidoc is python2, hoping

Re: [pacman-dev] [PATCH v2] pacman: fix possible buffer overflow

2018-10-16 Thread Andrew Gregory
On 09/22/18 at 11:30pm, morganamilo wrote: > in the function query_fileowner, if the user enters a string longer > than PATH_MAX then rpath will buffer overflow when lrealpath tries to > strcat everything together. > > So make sure to bail early if the generated path is going to be bigger > than

[pacman-dev] [PATCH] handle EINTR while polling scripts/hooks

2018-10-12 Thread Andrew Gregory
If poll() is interrupted by a signal, alpm was closing the socket it uses for listening to script/hook output. This would drop script output at the least and kill the script at the worst. Fixes FS#60396 Signed-off-by: Andrew Gregory --- lib/libalpm/util.c | 10

Re: [pacman-dev] [PATCH v2] libalpm: parse {check, make}depends when reading database

2018-10-08 Thread Andrew Gregory
On 10/09/18 at 02:20am, Morgan Adamiec wrote: > On 09/10/2018 2:15 am, Allan McRae wrote: > > On 9/10/18 11:05 am, morganamilo wrote: > >> static struct pkg_operations local_pkg_ops = { > >> - .get_base= _cache_get_base, > >> - .get_desc= _cache_get_desc, > >> - .get_url

[pacman-dev] [PATCH] reset signal handlers before running scripts/hooks

2018-10-03 Thread Andrew Gregory
-off-by: Andrew Gregory --- Hopefully nobody ignores or depends on signals outside of the POSIX list. As far as I can tell, the only way to reset all signal handlers is to iterate over the entire range of positive integers. lib/libalpm/util.c | 20

  1   2   3   4   5   6   7   8   9   >