Re: [perl #57026] [BUG]: Changes to Parrot::Ops2c::Utils in remove_getfd branch cause failures in buildtools_tests

2008-07-17 Thread Bernhard Schmalhofer
Will Coleda schrieb: On Wed, Jul 16, 2008 at 10:54 PM, James Keenan via RT [EMAIL PROTECTED] wrote: This module is written in Perl 5 and is called in a program written in Perl 5. In the work I've done in this project, I've taken the approach to return values which I think is more Perlish,

[perl #57026] [BUG]: Changes to Parrot::Ops2c::Utils in remove_getfd branch cause failures in buildtools_tests

2008-07-16 Thread via RT
# New Ticket Created by James Keenan # Please include the string: [perl #57026] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=57026 r29522 |

Re: [perl #57026] [BUG]: Changes to Parrot::Ops2c::Utils in remove_getfd branch cause failures in buildtools_tests

2008-07-16 Thread Will Coleda
On Wed, Jul 16, 2008 at 7:31 PM, via RT James Keenan [EMAIL PROTECTED] wrote: # New Ticket Created by James Keenan # Please include the string: [perl #57026] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=57026

[perl #57026] [BUG]: Changes to Parrot::Ops2c::Utils in remove_getfd branch cause failures in buildtools_tests

2008-07-16 Thread James Keenan via RT
On Wed Jul 16 16:56:20 2008, coke wrote: I suspect that the merger/committer failed either to run 'perl Configure.pl --test' or 'make buildtools_tests' prior to 'make'. I can't remember the last time I ran these particular test targets, so that's easy (for me) to forgive. (Well, I

[perl #57026] [BUG]: Changes to Parrot::Ops2c::Utils in remove_getfd branch cause failures in buildtools_tests

2008-07-16 Thread James Keenan via RT
On Wed Jul 16 18:53:05 2008, [EMAIL PROTECTED] wrote: So if you really think lib/Parrot/Ops2c/Utils.pm could be better designed while achieving the same functionality, have a go at it! But in the short run I would recommend simply reverting to the last prior version of the module. I

Re: [perl #57026] [BUG]: Changes to Parrot::Ops2c::Utils in remove_getfd branch cause failures in buildtools_tests

2008-07-16 Thread Will Coleda
On Wed, Jul 16, 2008 at 9:53 PM, James Keenan via RT [EMAIL PROTECTED] wrote: On Wed Jul 16 16:56:20 2008, coke wrote: I suspect that the merger/committer failed either to run 'perl Configure.pl --test' or 'make buildtools_tests' prior to 'make'. I can't remember the last time I ran these

[perl #57026] [BUG]: Changes to Parrot::Ops2c::Utils in remove_getfd branch cause failures in buildtools_tests

2008-07-16 Thread James Keenan via RT
On Wed Jul 16 19:25:46 2008, coke wrote: Attached is a patch which passes all tests by removing the tests for the explicit true value of these methods. Coke: I don't think we should accept this patch, for the simple reason that I think the changes made to lib/Parrot/Ops2c/Utils.pm were both

[perl #57026] [BUG]: Changes to Parrot::Ops2c::Utils in remove_getfd branch cause failures in buildtools_tests

2008-07-16 Thread James Keenan via RT
This module is written in Perl 5 and is called in a program written in Perl 5. In the work I've done in this project, I've taken the approach to return values which I think is more Perlish, namely, if a subroutine completes and does what you wanted it to, it should return a true value. A bare

Re: [perl #57026] [BUG]: Changes to Parrot::Ops2c::Utils in remove_getfd branch cause failures in buildtools_tests

2008-07-16 Thread Will Coleda
On Wed, Jul 16, 2008 at 10:54 PM, James Keenan via RT [EMAIL PROTECTED] wrote: This module is written in Perl 5 and is called in a program written in Perl 5. In the work I've done in this project, I've taken the approach to return values which I think is more Perlish, namely, if a subroutine

Re: [perl #57026] [BUG]: Changes to Parrot::Ops2c::Utils in remove_getfd branch cause failures in buildtools_tests

2008-07-16 Thread chromatic
On Wednesday 16 July 2008 19:54:57 James Keenan via RT wrote: This module is written in Perl 5 and is called in a program written in Perl 5. In the work I've done in this project, I've taken the approach to return values which I think is more Perlish, namely, if a subroutine completes and