Re: pdd17pmc branch review

2008-03-17 Thread François Perrad
chromatic wrote: On Monday 10 March 2008 07:24:44 François Perrad wrote: chromatic wrote: I fixed all of the compilation errors I could find as of r26285. 280 tests fail on the trunk for me and 308 fail on the branch, but they don't look like compilation errors or PDD 17 porting errors.

Re: pdd17pmc branch review

2008-03-16 Thread chromatic
On Monday 10 March 2008 07:24:44 François Perrad wrote: > chromatic wrote: > > I fixed all of the compilation errors I could find as of r26285. 280 > > tests fail on the trunk for me and 308 fail on the branch, but they don't > > look like compilation errors or PDD 17 porting errors. > I think

Re: pdd17pmc branch review

2008-03-15 Thread chromatic
On Saturday 08 March 2008 17:10:00 Bob Rogers wrote: >From: chromatic <[EMAIL PROTECTED]> >Let it be known that Kea-CL gets the Official chromatic Seal of Much >Approval! > Thanks! Does that come with a check? If so, I should be sure to > deposit it before you see my next GC bug re

Re: pdd17pmc branch review

2008-03-10 Thread chromatic
On Monday 10 March 2008 14:31:27 Will Coleda wrote: > I know "replace" is invalid (that's why I marked it with a comment). > That doesn't stop pmc2c.pl from trying to convert that invocation of > Parrot_PCCINVOKE when it shouldn't. The regex is in lib/Parrot/Pmc2c/PCCMETHOD.pm, specifically rewr

Re: pdd17pmc branch review

2008-03-10 Thread Will Coleda
On Mon, Mar 10, 2008 at 5:04 PM, chromatic <[EMAIL PROTECTED]> wrote: > On Monday 10 March 2008 13:51:40 Will Coleda wrote: > > > On Mon, Mar 10, 2008 at 4:33 PM, chromatic <[EMAIL PROTECTED]> wrote: > > > > On Monday 10 March 2008 13:19:59 Will Coleda wrote: > > > > > > Also, if you're not care

Re: pdd17pmc branch review

2008-03-10 Thread chromatic
On Monday 10 March 2008 13:51:40 Will Coleda wrote: > On Mon, Mar 10, 2008 at 4:33 PM, chromatic <[EMAIL PROTECTED]> wrote: > > On Monday 10 March 2008 13:19:59 Will Coleda wrote: > > > Also, if you're not careful, pmc2c.pl tries to rewrite > > > Parrot_PCCINVOKE too, not just PCCINVOKE. (I us

Re: pdd17pmc branch review

2008-03-10 Thread chromatic
On Monday 10 March 2008 13:19:59 Will Coleda wrote: > Note that: > > > +STRING* orig,repl; > > doesn't DWIM. That's why abutting the star and the type is an abomination under heaven, and our style guidelines recommend strongly against it. > Also, if you're not careful, pmc2c.pl tries t

Re: pdd17pmc branch review

2008-03-10 Thread Will Coleda
On Mon, Mar 10, 2008 at 4:33 PM, chromatic <[EMAIL PROTECTED]> wrote: > On Monday 10 March 2008 13:19:59 Will Coleda wrote: > > > Note that: > > > > +STRING* orig,repl; > > > > doesn't DWIM. > > That's why abutting the star and the type is an abomination under heaven, and > our style

Re: pdd17pmc branch review

2008-03-10 Thread Will Coleda
On Mon, Mar 10, 2008 at 3:52 PM, chromatic <[EMAIL PROTECTED]> wrote: > On Monday 10 March 2008 12:37:50 Will Coleda wrote: > > > The conversion of tcllist.pmc to PDD17 isn't complete: there are > > currently several invocations of String's replace method which in > > trunk is the old C-style ME

Re: pdd17pmc branch review

2008-03-10 Thread chromatic
On Monday 10 March 2008 12:37:50 Will Coleda wrote: > The conversion of tcllist.pmc to PDD17 isn't complete: there are > currently several invocations of String's replace method which in > trunk is the old C-style METHOD but in branch, is the new PDD17 style > METHOD. I tried to replace these, for

Re: pdd17pmc branch review

2008-03-10 Thread Will Coleda
On Mon, Mar 10, 2008 at 1:44 PM, Will Coleda <[EMAIL PROTECTED]> wrote: > On Mon, Mar 10, 2008 at 9:25 AM, Will Coleda <[EMAIL PROTECTED]> wrote: > > This was mentioned on a ticket, but to add it to this thread: tcl > > seems to work as well in this branch as it does in trunk now, > > chromati

Re: pdd17pmc branch review

2008-03-10 Thread Allison Randal
François Perrad wrote: After reverting commit 26097 ([core] Implement does_pmc and ...), Why revert it? The behavior wasn't quite right, but we fixed it in the pdd17pmc branch. The compiler generates : - a call to VTABLE_neg (in luaany.pmc) when "print(-nil)" - a call to METHOD len (in

Re: pdd17pmc branch review

2008-03-10 Thread chromatic
On Monday 10 March 2008 09:43:11 François Perrad wrote: > After reverting commit 26097 ([core] Implement does_pmc and ...), I see > a different behavior between trunk and ppd17pmc : > > on trunk : > parrot --no-gc lua.pbc -e "print(-nil)" > lua.pbc: EVAL_1:30: attempt to perform arithmetic on a ni

Re: pdd17pmc branch review

2008-03-10 Thread Will Coleda
On Mon, Mar 10, 2008 at 9:25 AM, Will Coleda <[EMAIL PROTECTED]> wrote: > This was mentioned on a ticket, but to add it to this thread: tcl > seems to work as well in this branch as it does in trunk now, > chromatic++. > > -- > Will "Coke" Coleda > Closer inspection shows that partcl is not fa

Re: pdd17pmc branch review

2008-03-10 Thread François Perrad
Will Coleda wrote: I wanted to call attention to part of today's Parrot Sketch: - Otherwise, the PMC branch is ready for language testing, will plan to merge it back into trunk next weekend. So, language developers (and others); please grab a copy of https://svn.perl.org/parrot/branches/pdd17p

Re: pdd17pmc branch review

2008-03-10 Thread Allison Randal
François Perrad wrote: I think the problem is in the wmlsbytecode.pmc (a singleton PMC with only one method 'load'), because the following command has no output : parrot wmlsd.pir t/examples_1.wmlsc The script wmlsd.pir is a disassembler that loads a WMLScript bytecode and dumps it. Other

Re: pdd17pmc branch review

2008-03-10 Thread François Perrad
chromatic wrote: On Friday 07 March 2008 02:22:58 François Perrad wrote: in r26261 with MinGW32, Lua PMCs seem OK (thank to chromatic). Several tests fail for me, but it looks like a problem with caller() in Lua, so it's probably beyond my expertise. It looks simpler to fix (if you know ho

Re: pdd17pmc branch review

2008-03-10 Thread François Perrad
chromatic wrote: On Friday 07 March 2008 02:22:58 François Perrad wrote: but WMLScript PMCs don't compile : many error like .\wmlsinteger.pmc: In function `Parrot_WmlsInteger_subtract_WmlsString': .\wmlsinteger.pmc:251: error: void value not ignored as it ought to be I fixed all of the compil

Re: pdd17pmc branch review

2008-03-10 Thread Will Coleda
On Mon, Mar 10, 2008 at 12:32 AM, chromatic <[EMAIL PROTECTED]> wrote: > On Friday 07 March 2008 02:22:58 François Perrad wrote: > > > > but WMLScript PMCs don't compile : > > many error like > > .\wmlsinteger.pmc: In function `Parrot_WmlsInteger_subtract_WmlsString': > > .\wmlsinteger.pmc:251:

Re: pdd17pmc branch review

2008-03-09 Thread chromatic
On Friday 07 March 2008 02:22:58 François Perrad wrote: > but WMLScript PMCs don't compile : > many error like > .\wmlsinteger.pmc: In function `Parrot_WmlsInteger_subtract_WmlsString': > .\wmlsinteger.pmc:251: error: void value not ignored as it ought to be I fixed all of the compilation errors

Re: pdd17pmc branch review

2008-03-08 Thread Bob Rogers
From: chromatic <[EMAIL PROTECTED]> Date: Sat, 8 Mar 2008 01:03:12 -0800 On Friday 07 March 2008 19:24:53 Bob Rogers wrote: > Using pdd17pmc, Kea-CL passes all tests (after s/DYNSELF/SELF/g, of > course), with no regression on either of the memory bugs reported > recently. L

Re: pdd17pmc branch review

2008-03-08 Thread Allison Randal
chromatic wrote: ... I have to ask, if we switched to METHOD instead of PCCMETHOD, why do we have PCCRETURN instead of RETURN? =-) Hysterical raisins, as far as I know. Largely because I forgot to mention PCCRETURN in that step of the migration plan. Committed fix in r26268. Allison

Re: pdd17pmc branch review

2008-03-08 Thread Klaas-Jan Stol
Hi, I'm on win32 xp pro, msvc express Punie, Pynie, ecmascript are passing tests. (c99 does not, but that's not different from trunk.) kjs On Wed, Mar 5, 2008 at 1:48 AM, Will Coleda <[EMAIL PROTECTED]> wrote: > I wanted to call attention to part of today's Parrot Sketch: > > - Otherwise, th

Re: pdd17pmc branch review

2008-03-08 Thread chromatic
On Friday 07 March 2008 19:24:53 Bob Rogers wrote: >From: "Will Coleda" <[EMAIL PROTECTED]> >Date: Tue, 4 Mar 2008 19:48:09 -0500 > >I wanted to call attention to part of today's Parrot Sketch: > > - Otherwise, the PMC branch is ready for language testing, >will plan to merge i

pdd17pmc branch review

2008-03-07 Thread Bob Rogers
From: "Will Coleda" <[EMAIL PROTECTED]> Date: Tue, 4 Mar 2008 19:48:09 -0500 I wanted to call attention to part of today's Parrot Sketch: - Otherwise, the PMC branch is ready for language testing, will plan to merge it back into trunk next weekend. Using pdd17pmc, Kea-CL passes a

Re: pdd17pmc branch review

2008-03-07 Thread François Perrad
chromatic wrote: On Friday 07 March 2008 02:22:58 François Perrad wrote: in r26261 with MinGW32, Lua PMCs seem OK (thank to chromatic). Several tests fail for me, but it looks like a problem with caller() in Lua, so it's probably beyond my expertise. It looks simpler to fix (if you know ho

Re: pdd17pmc branch review

2008-03-07 Thread chromatic
On Friday 07 March 2008 02:22:58 François Perrad wrote: > in r26261 with MinGW32, Lua PMCs seem OK (thank to chromatic). Several tests fail for me, but it looks like a problem with caller() in Lua, so it's probably beyond my expertise. It looks simpler to fix (if you know how the Lua compiler

Re: pdd17pmc branch review

2008-03-07 Thread François Perrad
Will Coleda wrote: I wanted to call attention to part of today's Parrot Sketch: - Otherwise, the PMC branch is ready for language testing, will plan to merge it back into trunk next weekend. So, language developers (and others); please grab a copy of https://svn.perl.org/parrot/branches/pdd17p

Re: pdd17pmc branch review

2008-03-06 Thread chromatic
On Thursday 06 March 2008 18:25:57 Will Coleda wrote: > I applied this change, as well as updating the methods to use the > PDD17 conventions (PCCRETURN), etc. Now down to only six failing sub > tests. Again, if I can get PIR that corresponds to these tests (or find out how to generate it myself

Re: pdd17pmc branch review

2008-03-06 Thread Will Coleda
On Thu, Mar 6, 2008 at 2:45 PM, Patrick R. Michaud <[EMAIL PROTECTED]> wrote: > > On Tuesday 04 March 2008 16:48:09 Will Coleda wrote: > > So, language developers (and others); please grab a copy of > > https://svn.perl.org/parrot/branches/pdd17pmc and check out the > > languages to see how they

Re: pdd17pmc branch review

2008-03-06 Thread Patrick R. Michaud
> On Tuesday 04 March 2008 16:48:09 Will Coleda wrote: > So, language developers (and others); please grab a copy of > https://svn.perl.org/parrot/branches/pdd17pmc and check out the > languages to see how they fare compared to their counterparts in > trunk. APL doesn't run. I suspect the aplvect

Re: pdd17pmc branch review

2008-03-06 Thread Patrick R. Michaud
On Tue, Mar 04, 2008 at 06:39:38PM -0800, chromatic wrote: > On Tuesday 04 March 2008 16:48:09 Will Coleda wrote: > > So, language developers (and others); please grab a copy of > > https://svn.perl.org/parrot/branches/pdd17pmc and check out the > > languages to see how they fare compared to their

Re: pdd17pmc branch review

2008-03-05 Thread chromatic
On Wednesday 05 March 2008 09:34:48 Bernhard Schmalhofer wrote: > Plumhead: Can't build the PHPArray PMC: Fixed in r26288. After r26234, PHPArray's mark() works correctly, which fixes one segfault for me. r26235 fixed an order-of-destruction error that was Parrot's problem, not PHPArray's, bu

Re: Re: pdd17pmc branch review

2008-03-05 Thread Jim Keenan
>From: Will Coleda <[EMAIL PROTECTED]> >I am confused why this wasn't failing for allison & chromatic. I added >in the missing headers in r26227. > All tests passed at r26228 (except the macro.t test that's been failing in trunk). kid51

Re: pdd17pmc branch review

2008-03-05 Thread chromatic
On Wednesday 05 March 2008 09:34:48 Bernhard Schmalhofer wrote: > Plumhead: Can't build the PHPArray PMC: > > usr/bin/perl > /home/bernhard/devel/Parrot/branches/pdd17pmc/tools/build/pmc2c.pl > --library php_group --c phparray.pmc > cc -c -o phparray.o ... > ./phparray.c: In Funktion »Parrot_PHP

Re: pdd17pmc branch review

2008-03-05 Thread Bernhard Schmalhofer
Will Coleda schrieb: I wanted to call attention to part of today's Parrot Sketch: - Otherwise, the PMC branch is ready for language testing, will plan to merge it back into trunk next weekend. So, language developers (and others); please grab a copy of https://svn.perl.org/parrot/branches/pdd1

Re: pdd17pmc branch review

2008-03-05 Thread Will Coleda
On Wed, Mar 5, 2008 at 12:17 PM, jerry gay <[EMAIL PROTECTED]> wrote: > > On Wed, Mar 5, 2008 at 8:44 AM, Will Coleda <[EMAIL PROTECTED]> wrote: > > > > On Tue, Mar 4, 2008 at 10:14 PM, chromatic <[EMAIL PROTECTED]> wrote: > > > > > > On Tuesday 04 March 2008 19:09:48 Will Coleda wrote: > >

Re: Re: pdd17pmc branch review

2008-03-05 Thread Jim Keenan
>From: Will Coleda <[EMAIL PROTECTED]> > > >I am confused why this wasn't failing for allison & chromatic. I added >in the missing headers in r26227. > Note that I was reporting on an earlier revision. In "20080304.26216.pdd17pmc.txt", the second bunch of digits is the revision number at which

Re: pdd17pmc branch review

2008-03-05 Thread jerry gay
On Wed, Mar 5, 2008 at 8:44 AM, Will Coleda <[EMAIL PROTECTED]> wrote: > > On Tue, Mar 4, 2008 at 10:14 PM, chromatic <[EMAIL PROTECTED]> wrote: > > > > On Tuesday 04 March 2008 19:09:48 Will Coleda wrote: > > > > > On Tue, Mar 4, 2008 at 9:39 PM, chromatic <[EMAIL PROTECTED]> wrote: > > > >

Re: Re: pdd17pmc branch review

2008-03-05 Thread Jim Keenan
>From: Will Coleda <[EMAIL PROTECTED]> > >I am confused why this wasn't failing for allison & chromatic. I added >in the missing headers in r26227. > I'll try to update and give it another spin later today.

Re: pdd17pmc branch review

2008-03-05 Thread Will Coleda
On Tue, Mar 4, 2008 at 10:14 PM, chromatic <[EMAIL PROTECTED]> wrote: > > On Tuesday 04 March 2008 19:09:48 Will Coleda wrote: > > > On Tue, Mar 4, 2008 at 9:39 PM, chromatic <[EMAIL PROTECTED]> wrote: > > > > Tcl: doesn't run > > > > > > unable to assign self to this type > > > # current i

Re: pdd17pmc branch review

2008-03-05 Thread Will Coleda
On Tue, Mar 4, 2008 at 9:59 PM, James E Keenan <[EMAIL PROTECTED]> wrote: > James E Keenan wrote: > > > > > As I would have expected, the branch passed all the tests run via 'perl > > Configure.pl --test'. > > > But having said that, it failed 'make' on the same box (a box where > trunk consis

Re: pdd17pmc branch review

2008-03-04 Thread Will Coleda
On Tue, Mar 4, 2008 at 10:30 PM, Will Coleda <[EMAIL PROTECTED]> wrote: > > On Tue, Mar 4, 2008 at 10:14 PM, chromatic <[EMAIL PROTECTED]> wrote: > > > > On Tuesday 04 March 2008 19:09:48 Will Coleda wrote: > > > > > On Tue, Mar 4, 2008 at 9:39 PM, chromatic <[EMAIL PROTECTED]> wrote: > > >

Re: pdd17pmc branch review

2008-03-04 Thread Will Coleda
On Tue, Mar 4, 2008 at 10:14 PM, chromatic <[EMAIL PROTECTED]> wrote: > > On Tuesday 04 March 2008 19:09:48 Will Coleda wrote: > > > On Tue, Mar 4, 2008 at 9:39 PM, chromatic <[EMAIL PROTECTED]> wrote: > > > > Tcl: doesn't run > > > > > > unable to assign self to this type > > > # current i

Re: pdd17pmc branch review

2008-03-04 Thread chromatic
On Tuesday 04 March 2008 19:09:48 Will Coleda wrote: > On Tue, Mar 4, 2008 at 9:39 PM, chromatic <[EMAIL PROTECTED]> wrote: > > Tcl: doesn't run > > > > unable to assign self to this type > > # current instr.: '__list' pc 25773 > > (languages/tcl/runtime/conversions.pir:27) # called from Sub '

Re: pdd17pmc branch review

2008-03-04 Thread Will Coleda
On Tue, Mar 4, 2008 at 9:39 PM, chromatic <[EMAIL PROTECTED]> wrote: > Tcl: doesn't run > > unable to assign self to this type > # current instr.: '__list' pc 25773 > (languages/tcl/runtime/conversions.pir:27) > # called from Sub '&proc' pc 22110 > (languages/tcl/runtime/builtin/proc.pir:106

Re: pdd17pmc branch review

2008-03-04 Thread James E Keenan
James E Keenan wrote: As I would have expected, the branch passed all the tests run via 'perl Configure.pl --test'. But having said that, it failed 'make' on the same box (a box where trunk consistently passes 'make'). src/scheduler.c seems to have a problem. See attached. kid51 Compil

Re: pdd17pmc branch review

2008-03-04 Thread chromatic
On Tuesday 04 March 2008 16:48:09 Will Coleda wrote: > I wanted to call attention to part of today's Parrot Sketch: > > - Otherwise, the PMC branch is ready for language testing, > will plan to merge it back into trunk next weekend. > > So, language developers (and others); please grab a copy of

Re: pdd17pmc branch review

2008-03-04 Thread James E Keenan
Will Coleda wrote: I wanted to call attention to part of today's Parrot Sketch: - Otherwise, the PMC branch is ready for language testing, will plan to merge it back into trunk next weekend. As I would have expected, the branch passed all the tests run via 'perl Configure.pl --test'.

pdd17pmc branch review

2008-03-04 Thread Will Coleda
I wanted to call attention to part of today's Parrot Sketch: - Otherwise, the PMC branch is ready for language testing, will plan to merge it back into trunk next weekend. So, language developers (and others); please grab a copy of https://svn.perl.org/parrot/branches/pdd17pmc and check out the