Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-30 Thread Dave Page
It's a visual design update. As for the actual dialogue; a wizard really isn't appropriate as the typical workflow will be very inconsistent and often non-linear. I have no idea how to improve it further, except through improving the visuals to make it clearer. It's 100x easier to use than the pgA

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-30 Thread Shirley Wang
+1 to Rob. By the time a user drills into seeing column properties, she'll have gone through 5 layers of navigation. Is there another way to display this information so that it's not nested? If this is a visual design revamp that's a different conversation. What kind of feedback are you looking fo

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-30 Thread Robert Eckhardt
How does this reflect actual user workflow? I have never quite understood how a user was supposed to navigate through this, it seems like the expectation is to continually click until they see the thing they want rather than just going through as though it were a wizard. Is this something that coul

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-28 Thread Akshay Joshi
Thanks patch applied. On Mon, Aug 28, 2017 at 12:27 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find a patch to fix the issue for PG9.6 in Dashboard, this is > regression of RM#2597. > > *Error:* > 2017-08-28 11:49:28,238: ERROR pgadmin: Failed to execute q

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-27 Thread Murtuza Zabuawala
Hi, Please find a patch to fix the issue for PG9.6 in Dashboard, this is regression of RM#2597. *Error:* 2017-08-28 11:49:28,238: ERROR pgadmin: Failed to execute query (execute_dict) for the server #34- DB:postgres (Query-id: 320468): Error Message:ERROR: column "backend_type" does not exist LI

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-25 Thread Dave Page
Thanks, patch applied. On Wed, Aug 9, 2017 at 12:19 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find the updated patch with new UI style in dashboard subnode > control based on Chethana's design suggestion. > > @Shirley, > Yes, DBA needs to click on the dro

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-09 Thread Murtuza Zabuawala
Hi, Please find the updated patch with new UI style in dashboard subnode control based on Chethana's design suggestion. @Shirley, Yes, DBA needs to click on the drop down to expand. - If we make whole row clickable then how are we going to identify if user is trying to expand the row or trying to

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-08 Thread Shirley Wang
Nice! Would a DBA need to click on the drop down to expand? I think that drop down icon might be too small. Perhaps the whole row could be a clickable area to show further details. This is a good thing to test with some people > On Aug 8, 2017, at 12:52, Ashesh Vashi wrote: > >> On Mon, Aug

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-07 Thread Ashesh Vashi
On Mon, Aug 7, 2017 at 9:06 PM, Dave Page wrote: > > > On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar < > chethana.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Could you comment on the new design update for subnode control ? >> >> Attached designs - >> >> 1. subnode_current.png - The exist

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-07 Thread Dave Page
On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Dave, > > Could you comment on the new design update for subnode control ? > > Attached designs - > > 1. subnode_current.png - The existing view > 2. subnode_new.png - The updated view > 3. current_new.p

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Dave Page
On Fri, Jul 28, 2017 at 12:24 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Jul 28, 2017 at 4:11 PM, Dave Page wrote: > >> Hi >> >> I took a quick look at this and have a couple of thoughts: >> >> - Instead of the "edit" icon to open the subnode, we sho

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Murtuza Zabuawala
Hi Dave, On Fri, Jul 28, 2017 at 4:11 PM, Dave Page wrote: > Hi > > I took a quick look at this and have a couple of thoughts: > > - Instead of the "edit" icon to open the subnode, we should use something > more appropriate - a "properties" icon perhaps. > > I used default subnode's edit icon fo

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Dave Page
Hi I took a quick look at this and have a couple of thoughts: - Instead of the "edit" icon to open the subnode, we should use something more appropriate - a "properties" icon perhaps. - There seems to be a lot of different shades of grey on there (maybe a subnode design in general that just show

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Murtuza Zabuawala
++ Attaching the patch -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA patch to display additional information from pg_stat

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Murtuza Zabuawala
Hi Dave, PFA patch to display additional information from pg_stat_activity table using subnode control. RM#2597 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang wrote: > >> O

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-25 Thread Shirley Wang
Ok, I understand that this is a feature that should exist. We should decouple the need for a feature existing from the way the feature is designed and used. I think we need a broader discussion on how to do this. On Tue, Jul 25, 2017 at 3:59 PM Dave Page wrote: > On Tue, Jul 25, 2017 at 6:26 AM,

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-25 Thread Dave Page
On Tue, Jul 25, 2017 at 6:26 AM, Shirley Wang wrote: > >> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang wrote: >>> 2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can th

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Shirley Wang
> > > On Mon, Jul 24, 2017 at 8:11 PM, Dave Page wrote: > >> >> >> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang wrote: >> >>> 2-3 days is a lot of valuable engineering time. Is this a 'drop >>> everything now' kind of feature or can this wait for some user validation >>> on a mock up first? >>>

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Harshal Dhumal
-- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 24, 2017 at 8:11 PM, Dave Page wrote: > > > On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang wrote: > >> 2-3 days is a lot of valuable engineering time. Is th

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Dave Page
On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang wrote: > 2-3 days is a lot of valuable engineering time. Is this a 'drop everything > now' kind of feature or can this wait for some user validation on a mock up > first? > Most of the time will likely be on the infrastructure to change the display t

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Shirley Wang
2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can this wait for some user validation on a mock up first? > On Jul 24, 2017, at 20:41, Murtuza Zabuawala > wrote: > > Sure. > > RM created: https://redmine.postgresql.org/issues/2597. > >> On

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Murtuza Zabuawala
Sure. RM created: https://redmine.postgresql.org/issues/2597. On Mon, Jul 24, 2017 at 6:04 PM, Dave Page wrote: > > > On Mon, Jul 24, 2017 at 1:12 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> On Mon, Jul 24, 2017 at 4:44 PM, Dave Page wrote: >> >>> Thanks, applied. >>> >

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Dave Page
On Mon, Jul 24, 2017 at 1:12 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Jul 24, 2017 at 4:44 PM, Dave Page wrote: > >> Thanks, applied. >> >> How much effort do you think it would take to turn the table into a >> subnode control so we can show the SQ

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Murtuza Zabuawala
Hi Dave, On Mon, Jul 24, 2017 at 4:44 PM, Dave Page wrote: > Thanks, applied. > > How much effort do you think it would take to turn the table into a > subnode control so we can show the SQL query and other missing fields from > pg_stat_activity on that tab? > I think around 2-3 days would be ne

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Dave Page
Thanks, applied. How much effort do you think it would take to turn the table into a subnode control so we can show the SQL query and other missing fields from pg_stat_activity on that tab? On Mon, Jul 24, 2017 at 11:45 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala wrote: > Hi Shirley, > > On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang wrote: > >> Hi! >> >> I can't seem to get the patch to completely work on my computer, only the >> close icon shows up plus the dialog a

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-18 Thread Murtuza Zabuawala
Hi Shirley, On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang wrote: > Hi! > > I can't seem to get the patch to completely work on my computer, only the > close icon shows up plus the dialog and success/error messages, but here > are some comments: > > Because we are just cancelling the active runn

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-17 Thread Shirley Wang
Hi! I can't seem to get the patch to completely work on my computer, only the close icon shows up plus the dialog and success/error messages, but here are some comments: +1 to Dave's comment about refreshing after the cancel operation - We're working on a patch for updating alerts in the Dashboa

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-17 Thread Murtuza Zabuawala
On Mon, Jul 17, 2017 at 3:01 PM, Dave Page wrote: > Hi > > On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> hiHi, >> >> PFA patch to add functionality which will allow super user to cancel long >> running queries from dashboard. >> RM#1812 >> >> *Steps used to tes

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-17 Thread Dave Page
Hi On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > hiHi, > > PFA patch to add functionality which will allow super user to cancel long > running queries from dashboard. > RM#1812 > > *Steps used to test:* > 1) Open psql session, Connect to 'test'

[pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-13 Thread Murtuza Zabuawala
hiHi, PFA patch to add functionality which will allow super user to cancel long running queries from dashboard. RM#1812 *Steps used to test:* 1) Open psql session, Connect to 'test' database on respective server 2) Execute "select pg_sleep(1000);" 3) Open pgAdmin4 4) Connect to respective server