Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

work as they should? > ​I will add.​ > > Thanks again! > > On Thu, Jun 15, 2017 at 11:55 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find attached patch. It should work. >> In previous patch I was unaware

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

page$ git apply ~/Downloads/fix_scripts_in_ > query_tool.patch > error: web/pgadmin/static/js/setup_connection.js: No such file or > directory > > On Thu, Jun 15, 2017 at 6:36 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> PF

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

eDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Jun 13, 2017 at 4:04 PM, Dave Page wrote: > >> Use a more sensible name for Query Tool tabs. Fixes #2482 >> >> Branch >> -- >> master >> >> Details >>

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

On Tue, Jun 13, 2017 at 11:24 PM, Shirley Wang wrote: > > > On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang wrote: >> >>> Awesome!! This is super helpf

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

e]. It was showing 'Query - untitled' when opened from context menu because no tree information was passed. > > On Mon, Jun 12, 2017 at 10:25 PM Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> Changes: >> >> 1) When Query

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

;. > > On Tue, Jun 13, 2017 at 11:34 AM, Dave Page wrote: > > Thanks, patch applied. > > > > On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar > > wrote: > >> Hi > >> > >> Changes: > >> > >> 1) When Query tool is opened

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Hi On Tue, Jun 13, 2017 at 2:54 PM, Dave Page wrote: > On Mon, Jun 12, 2017 at 5:55 PM, Shirley Wang wrote: > >>> > >>> > >>> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar > >>> wrote: > >>> > Hi > >>> > >

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 4:05 PM, Dave Page wrote: > On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar > wrote: > > > > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > >> > >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi > >> wrote: > >&g

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi > wrote: > > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: > >> > >> And then I find a problem. Sigh. > >> > >> When running in the desktop runtime, under QtWekKit (the forked, > >> updated ve

[pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Hi Changes: 1) When Query tool is opened, right now - panel title is displayed as "Query - 1 ", instead it should display Query - [db_name] on [server_name] as in pgAdmin3. 2) When Edit grid is opened for table, the panel title should display Edit Data - [server_name] - [db_name] - [table_name]

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi Dave, Please find updated patch. On Mon, Jun 12, 2017 at 7:58 PM, Dave Page wrote: > Hi > > On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar > wrote: > > Hi > > > > I confirm this is updated patch. > > Thanks. Something else seems to have changed that I c

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

follows the standards in the > WIP styleguide please? I see that the current patch is using the wrong > font for example. > > http://pgadmin4-styleguide.cfapps.io/ > > Thanks! > > On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar > wrote: > > Hi > > > > C

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi I confirm this is updated patch. PFA patch. On Mon, Jun 12, 2017 at 6:20 PM, Dave Page wrote: > Hi > > Is that the correct patch? Hitting in a comment text area is > still causing the dialogue to close.​ > Thanks. > > On Mon, Jun 12, 2017 at 12:55 PM, Surinder K

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi Please find rebased patch Thanks On Mon, Jun 12, 2017 at 5:20 PM, Dave Page wrote: > Could you rebase this please? > > Thanks. > > On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar > wrote: > > Ignore previous patch as it doesn't contains new changes. &

[pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Hi Changes: 1) Calculate text editor position properly when the size of the grid exceeds the size of the window. 2) Assign NumberEditor to cell types('oid', 'xid', 'real'). 3) Remove inline styles from rendered editors and move its styles to CSS file. Please find attached patch and review. Th

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Ignore previous patch as it doesn't contains new changes. Please find attached patch. On Fri, Jun 9, 2017 at 3:06 PM, Surinder Kumar wrote: > Hi > > PFA patch and review. > > > On Fri, Jun 9, 2017 at 1:47 PM, Dave Page wrote: > >> Hi >> >> Ahh, no

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

comment. That's > clearly not right :-( > ​Now if event.target is its child elements(for example input, textarea etc), the function "handleKeyDown(event)" won't call. > > On Fri, Jun 9, 2017 at 7:48 AM, Surinder Kumar > wrote: > > Hi > > > > Pl

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

n Wed, Jun 7, 2017 at 4:03 PM, Surinder Kumar > wrote: > > PFA patch after rebase > > > > On Wed, Jun 7, 2017 at 6:26 PM, Surinder Kumar > > wrote: > >> > >> Hi > >> > >> Please find rebased patch. > >> > >> On Wed, Jun 7, 2

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi Please find updated patch. Thanks, Surinder On Thu, Jun 8, 2017 at 7:16 PM, Dave Page wrote: > Hi > > On Thu, Jun 8, 2017 at 5:38 AM, Surinder Kumar > wrote: > > Hi > > > > The attribute key for Ok, Save buttons should be mapped to 13(Enter), > > for He

Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

e changes look great. Could you change the > grays > > to match the style guide? > > > > Silver, #222, and #aaa aren't listed in pgadmin.style.css. > > > > Thanks so much! > > Shirley & Sarah > > > > On Thu, Jun 8, 2017 at 9:34 AM, Surinder

[pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

Hi, *Changes:* 1) Display only border-top for data-grid header instead of border on whole data-grid. 2) Remove dotted border from cell right for consistency. 3) Add border-bottom for header-row so that on scroll to bottom header rows are differentiated from cells. Also, due to these changes, t

[pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi The attribute key for Ok, Save buttons should be mapped to 13(Enter), for Help - 112(F1) and for Cancel - 27(Esc) The above changes are made into all dialog related template files. PFA patch and review. Thanks Surinder Feature_1535.patch Description: Binary data -- Sent via pgadmin-hacker

[pgadmin-hackers] [pgAdmin4][Patch][Feature_1533]: Set focus on first field when new dialog window is presented

Hi PFA patch and review. Thanks Surinder Feature_1533.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

PFA patch after rebase On Wed, Jun 7, 2017 at 6:26 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Please find rebased patch. > > On Wed, Jun 7, 2017 at 6:15 PM, Dave Page wrote: > >> Hi, >> >> Could you rebase this please? >&

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017 at 9:28 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Sure I will send. >> >> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page wrote: >> >>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar >>> wrote: >>> > Hi >>&

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Sure I will send. On Wed, Jun 7, 2017 at 6:54 PM, Dave Page wrote: > On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar > wrote: > > Hi > > > > With the latest pull, I found: > > The header color of Properties panel disappears and background color of > > foo

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Hi With the latest pull, I found: The header color of Properties panel disappears and background color of footer area in Edit Properties panel is changed. On Wed, Jun 7, 2017 at 6:28 PM, Dave Page wrote: > Thanks, applied. I removed the doc comments from the CSS for now as we > don't have minim

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

Hi Please find rebased patch. On Wed, Jun 7, 2017 at 6:15 PM, Dave Page wrote: > Hi, > > Could you rebase this please? > > Thanks. > > On Tue, Jun 6, 2017 at 9:22 AM, Surinder Kumar > wrote: > > Hi All, > > > > Please find updated patch which

[pgadmin-hackers] [pgAdmin4][Patch][RM_ 2368]: Allow cell editing on single click in edit grid

Hi Please find attached patch and review. Thanks, Surinder RM_2368.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch][RM_2461]: Unable to drop defaut value from the column in table

Hi Add drop column syntax for dropping default value of a column if default value is kept empty. Please find attached patch and review. Thanks, Surinder RM_2461.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your su

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

idth. > > Also, we suggest that you rename calculate_column_width to > calculateColumnWidth for consistency with javascript code style. > > Thanks, > Shruti and Matt > > On Mon, Jun 5, 2017 at 9:16 AM Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> St

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi On Tue, Jun 6, 2017 at 12:13 AM, Shruti B Iyer wrote: > Hi Surinder, > > On Mon, Jun 5, 2017 at 2:09 PM Robert Eckhardt > wrote: > >> On Mon, Jun 5, 2017 at 9:09 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi M

[pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

Staged changes are missed in previous patch, so please ignore. Please find attached updated patch. On Mon, Jun 5, 2017 at 4:29 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > This patch contains two fixes: > > 1) In Query/tool or Edit grid, the width o

[pgadmin-hackers] [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

st that hash in object. Is there any way to get temporary table name(avoiding unique hash) for such queries ?​ Also, Moved utilities functions into pgadmin/static/utils.js Please find attached patch and review. Thanks, Surinder Kumar Feature_1971.patch Description: Binary data -- Sent via

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

nce last 2 years. I need to check with latest version and I will update on this. Thanks Surinder On Mon, May 29, 2017 at 5:45 AM, Dave Page wrote: > On Fri, May 26, 2017 at 12:01 AM, Surinder Kumar > wrote: > > On Fri, May 26, 2017 at 3:02 AM, Dave Page wrote: > >> >

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

inter": "eslint pgadmin/static/jsx/**/*.jsx > pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx > regression/javascript/**/*.js *.js" > } > > To call it on the command line - > yarn run linter > > - Matt > > On Wed, May 31, 2017 at 12:

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

ompared with actual values. It eliminates the use of wait_timeout. Also, I added a print statement for debugging where a TimeoutException was occurred last time. On Sun, May 28, 2017 at 1:58 AM, Dave Page wrote: > Here's the screenshot. > > On Sat, May 27, 2017 at 4:26 PM, Dave Page w

[pgadmin-hackers] [pgAdmin4][Patch][RM_2448]: Multiple button presses to switch boolean fields

Hi The behaviour for checkbox click will go "false -> true -> null ->" Please find attached patch and review. Thanks, Surinder Kumar RM_2448.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

t; > On Wed, May 31, 2017 at 1:02 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: >> >> Hi Joao >> >> On Wed, May 31, 2017 at 1:19 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: >>> >>> Hello >>>

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin4 and boolean columns

; > Cheers > > > > Nigel > > > > > > > > *Dr Nigel Tucker* > > System Architect > > Specialised Structures NZ > > Telephone Direct (NZ) +64 (0) 3 482 2473 > > > > [image: SS with Custom] > > > > *

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

> > Thanks, > Joao & Matt > > > On Sat, May 27, 2017 at 2:19 PM, Dave Page wrote: > >> On Sat, May 27, 2017 at 9:02 AM, Surinder Kumar >> wrote: >> > Hi Dave, >> > On Sat, May 27, 2017 at 3:07 AM, Dave Page wrote: >> >> >>

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Wed, May 31, 2017 at 12:01 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > The motivation is simple - we want a solution that works for the whole >> app, can handle debug vs. release execution, pluggable modules, and >> installations in read-only directories. > > With

[pgadmin-hackers] [pgAdmin4][RM_2424]: Menu Items don't appear in tools menu for modules that are loaded using deps

Hi *Issue:* If modules are loaded without any node dependency(i.e: on page load), the function 'create_menu' is called implicitly to generate menu items. But when the modules are loaded when its dependent node expands, the function 'create_menus' has to explicitly call after 'add_menus' from res

Re: [pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

Hi Dave, The grid was being re-rendered after add new row and copy/paste to add a blank row in the end of grid, but in case of copy/paste batch operation it should run once, so that code is moved out of addNewRow(...) and put into a function grid.addBlankRow() and called separately for copy/paste

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

min4/web/regression/feature_utils/pgad > min_page.py", > line 68, in close_query_tool > self.driver.switch_to.frame(self.driver.find_elements_by_tag > _name("iframe")[0]) > IndexError: list index out of range > > On Sat, May 27, 2017 at 9:11 AM, Surinder Kumar > w

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Dave Please find updated Feature test case and review. This patch is dependent on RM_2400v2.patch On Fri, May 26, 2017 at 8:45 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Joao, > > On May 26, 2017 8:33 PM, "Joao Pedro De Almeida Pereira

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi Dave, On Sat, May 27, 2017 at 3:07 AM, Dave Page wrote: > Hi > > OK, so we're getting somewhere now :-). Here's what I found: > > - The grid looks and feels great now. Selection works nicely, and > copying rows seems to work well. > > - Patch 5 doesn't apply - but only to slick.grid.js. I manu

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

urinder > > Thanks > Joao & Shruti > > On Fri, May 26, 2017 at 10:18 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: >> >> Hi Joao, >> >> Please apply patch RM_2400v2.patch first then apply Feature test cases patch. >> >> >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

ite-packages/selenium/webdriver/support/wait.py", line 80, in until raise TimeoutException(message, screen, stacktrace) TimeoutException: Message: Timed out waiting for div element to appear ​ We also noticed that the function _wait is no longer used. Maybe we can remove it. Tha

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

; types(number, text, json and boolean) and write test cases for these >> cell >> > types with different input values. >> > >> > Following are the test cases covered: >> > >> > 1) Add a new row, save and compare the resulted value with expected >&

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

On Fri, May 26, 2017 at 3:02 AM, Dave Page wrote: > On Tue, May 23, 2017 at 4:21 PM, Dave Page wrote: > > > > I'm actually thinking that maybe it would be easier to start with the > > CSS files > > Which i did yesterday. However, it soon became obvious that that isn't > so easy either, as th

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

l, expected value is [null] c) Insert a string \’\’, expected value is '' d) Insert a string \\’\\’, expected value is \’\’ e) Insert a string ’’, expected value is \\’\\’ f) If a checkbox cell is double clicked, return value must be 'true' Thanks Surinder

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

Hi On Mon, May 22, 2017 at 4:22 PM, Dave Page wrote: > Hi > > On Monday, May 22, 2017, Surinder Kumar > wrote: > >> Hi >> >> As per pgAdmin4 design, template JS files can either be preloaded or load >> when a specific node expands (by adding for e.g.:

[pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

Hi As per pgAdmin4 design, template JS files can either be preloaded or load when a specific node expands (by adding for e.g.: when: 'server'). The JS files of several modules found to be loaded when pgAdmin4 loads which results in increasing: - the number of http requests - latency(greate

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

re edge cases the Unit Tests are much cheaper to run > and create. > ​I will write test cases for functions once they are moved into their separate files as discussed above. > > Thanks > Joao & Shruti > > > On Thu, May 18, 2017 at 1:22 AM, Surinder Kumar < > surinde

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Dave, Please review the updated patch. On Wed, May 17, 2017 at 8:46 PM, Dave Page wrote: > Hi > > On Wed, May 17, 2017 at 3:08 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> *Implementation:* >> >>

[pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

dering all rows again. 5) Moved the common logic into functions. This patch pass the feature test cases and jasmine test case. Also I will add the test cases for copy row and send an updated patch. Please find attached patch and review. Thanks, Surinder Kumar RM_2400.patch Description:

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi, The array temp_new_rows is used to keep track to new added rows in View data. It is used to add 'disabled_row'class for new rows to highlight when grid renders after delete/copy/add row operation. Please find attached patch. On Mon, May 15, 2017 at 10:14 PM, Surinder Kumar <

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

spatch (jquery-1.11.2.js:4665) >>> at HTMLDivElement.$event.dispatch (jquery.event.drag-2.2.js:374) >>> at HTMLDivElement.elemData.handle (jquery-1.11.2.js:4333) >>> >>> ​ >>> >>> Thanks >>> George & Joao >>> >>>

[pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi The regression test cases for 'copy row' was failing. This patch was assuming that each selected row will have primary key due to selection was not working. Fixed. Please find revised patch. Thanks Surinder Kumar On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <

[pgadmin-hackers] [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

esn't appear). 4) After deleting a row, add new row doesn't work. 5) New row added with explicitly given primary key should not disabled. Please review. Thanks, Surinder Kumar RM_2399.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgres

Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in the d

Hi Dave, Please find attached patch and review. Also, I found an issue <https://redmine.postgresql.org/issues/2399> which logged and will work on it. On Fri, May 12, 2017 at 5:19 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Fri, May 12, 2017 at 5:00 PM, D

Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in the d

On Fri, May 12, 2017 at 5:00 PM, Dave Page wrote: > > > On Fri, May 12, 2017 at 12:19 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Below code snippet from above commit assumes that we have to disable last >> row after saving. >> >> @@ -2320,6 >>

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2 11:00:00,861:ERROR:STDERR:-- > > 2017-05-12 11:00:00,861:ERROR:STDERR:Ran 6 tests in 208.850s > 2017-05-12 11:00:00,861:ERROR:STDERR:FAILED > 2017-05-12 11:00:00,861:ERROR:STDERR: (failures=1) > On Wed, May 10,

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

for numeric type fields. Now added.​ > >> - I'm able to edit a freshly added row immediately after saving but >> before refreshing. This shouldn't be allowed if we don't know what the >> primary key value is, as it leads to failed updates such as: >> >>

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > Please find attached patch for RM only. > > *Changes:* > > - All formatters now handles both [null] and [default] values > > - the cell values are validated on server side as in pgAdmin3. > >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

PM, Dave Page wrote: > > > On Wed, May 10, 2017 at 9:39 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, May 10, 2017 at 2:06 PM, Dave Page wrote: >> >>> Any chance we can get this wrapped up today

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

today eod. > > On Tue, May 9, 2017 at 11:29 AM, Dave Page wrote: > >> >> >> On Tue, May 9, 2017 at 11:03 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Mon, May 8, 2017 at 4:37 PM,

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi Dave, On Mon, May 8, 2017 at 4:37 PM, Dave Page wrote: > > > On Mon, May 8, 2017 at 11:51 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> On Mon, May 8, 2017 at 3:51 PM, Dave Page wrote: >> >>> Hi &

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi On Mon, May 8, 2017 at 3:51 PM, Dave Page wrote: > Hi > > On Mon, May 8, 2017 at 11:13 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Mon, May 8, 2017 at 3:28 PM, Dave Page wrote: >> >>> Hi &

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi Dave, On Mon, May 8, 2017 at 3:28 PM, Dave Page wrote: > Hi > > On Fri, May 5, 2017 at 12:52 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> The support to handle [null] and [default] values is added for follo

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

formatters. Will send separate patch for feature test cases once completed. Please review updated patch. On Tue, May 2, 2017 at 5:57 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, May 2, 2017 at 5:21 PM, Dave Page wrote: > >> Hi, >> >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

; self.error_handler.check_response(response) > File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/errorhandler.py", line 193, in > check_response > raise exception_class(message, screen, stacktrace) > UnexpectedAle

[pgadmin-hackers] [pgAdmin4][Patch]: Delete row server error not shown to GUI user

Hi The variable list_of_rowid doesn't keep track of rows to be deleted. If this list is empty simply return 0 since '_rowid' is being used to highlight the row for which error is occurred in only insert and update operation. Please find attached patch and review. Thanks,

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

ave Page wrote: > Hi > > On Sat, Apr 1, 2017 at 12:45 PM, Surinder Kumar > wrote: > > Hi > > > > Issues fixed: > > > > 1. If a column is defined with a default modifier, there is now way to > > insert the row with those defaults. > > The col

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

Hi Dave, Please find rebased patch. On Wed, Apr 12, 2017 at 5:44 PM, Dave Page wrote: > Can you rebase this please? > > On Tue, Apr 11, 2017 at 1:23 PM, Surinder Kumar > wrote: > > Hi Dave, > > > > On Tue, Apr 11, 2017 at 4:28 PM, Dave Page wrote: > >>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

Hi Dave, On Tue, Apr 11, 2017 at 4:28 PM, Dave Page wrote: > On Tue, Apr 11, 2017 at 10:51 AM, Surinder Kumar > wrote: > > Hi > > > > When a server is disconnected, listen to 'pgadmin:server:disconnect' > event > > and trigger refresh button of Serve

[pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activity data is not updating when server is disconnected in Dashboards

disconnect'event. Please find attached patch and review. Thanks, Surinder Kumar RM_2333.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi Issues fixed: 1. If a column is defined with a default modifier, there is now way to insert the row with those defaults. The column will be left blank and it will take default value automatically. 2. If a column has a not-null constraint then an error is returned and the row is not inserted.

[pgadmin-hackers] [pgAdmin4][Patch]: RM#2205 - Indeterminate state for [null] values in boolean type cell doesn't show up

Hi While looking into issue 2199 <https://redmine.postgresql.org/issues/2199>, I found while performing select query in query tool, the checkbox indeterminate state doesn't show up for [null] value on double click. Please find attached patch and review. Thanks Surinder Kumar R

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM2039 - Big (numeric) numbers are sometimes rounded up when displayed

wrote: > Hi > > On Friday, December 23, 2016, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi, >> >> Added 'numeric' type into string typecaster to prevent python from >> rounded up. >> >> Please find attached

[pgadmin-hackers] [pgAdmin4][Patch]: Expanded columns under table are in the wrong order

Hi, The sorting for the object types 'column' and 'catalog_object_column' is not required as their columns need to display as per their order of creation. For other nodes sorting will work. Please find attached patch and review. Thanks, Surinder Kumar RM_2185.patch Desc

[pgadmin-hackers] [pgAdmin4][Patch]: RM2115 - Wrong SQL displayed for exclusion constraints with gist method

Hi The Macro template was referring to the old code that's why it generates wrong sql. Now the changes made in RM1840 are incorporated into macro template as well. Please find attached patch. Thanks Surinder Kumar RM2115.patch Description: Binary data -- Sent via pgadmin-hackers ma

[pgadmin-hackers] [pgAdmin4][Patch]: Fixes RM2126 - Duplicate values displayed for functions and procedures in Preferences

. Thanks Surinder Kumar RM2126.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

onday morning my time please? > ​Thanks.​ > > > > Thanks! > > > > On Sat, Feb 4, 2017 at 5:34 AM, Surinder Kumar > > wrote: > >> Hi Dave, > >> > >> Please find updated patch and review. > >> > >> On Fri, Feb 3, 2017 at 2

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

Hi Dave, Please find updated patch and review. On Fri, Feb 3, 2017 at 2:43 PM, Dave Page wrote: > On Fri, Feb 3, 2017 at 7:28 AM, Surinder Kumar > wrote: > > Hi Dave, > > > > On Mon, Jan 30, 2017 at 6:18 PM, Dave Page wrote: > >> > >> On Fri

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

Hi Dave, On Mon, Jan 30, 2017 at 6:18 PM, Dave Page wrote: > On Fri, Jan 27, 2017 at 10:32 AM, Surinder Kumar > wrote: > > Hi Dave, > > > > Please find updated patch. > > > > On Mon, Jan 16, 2017 at 10:01 PM, Dave Page wrote: > >> > >>

[pgadmin-hackers] [pgAdmin4][Patch]: RM2047 - Allow user to move panel over the menu bar

Hi Dave, *Solution:* Setting z-index: 10 of .pg-navbar menu class to allow panel float over the menu bar. Please find attached patch. Thanks, Surinder Kumar RM2047.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

Hi Dave, Please find updated patch. On Mon, Jan 16, 2017 at 10:01 PM, Dave Page wrote: > Hi > > On Fri, Jan 13, 2017 at 9:24 AM, Surinder Kumar > wrote: > > Hi > > > > Please find attached patch and review. > > > > On Sun, Jan 8, 2017 at 3:27 PM, D

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

x27;btree'. If its is true, the values for options 'ASC/DESC' and 'NULLS' are included in 'create' sql for exclusion and index otherwise not. Please find updated patch and review. On Tue, Jan 17, 2017 at 3:43 PM, Dave Page wrote: > Hi > > On Tue, Ja

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

Hi On Tue, Jan 17, 2017 at 3:08 PM, Dave Page wrote: > Hi > > On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar > wrote: > > Hi > > > > Please find updated patch following changes: > > 1) Keep field 'opclass' combo box enabled. > > That doesn&#

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

Hi Please find attached patch and review. On Sun, Jan 8, 2017 at 3:27 PM, Dave Page wrote: > Hi > > On Friday, December 23, 2016, Surinder Kumar com> wrote: > >> Forgot to attach patch in last thread. please find patch. >> > > It looks good for the most pa

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

On Thu, Nov 24, 2016 at 12:13 PM, Surinder Kumar > wrote: > > Hi > > > > Please find updated patch with change. > > > > On Fri, Oct 21, 2016 at 9:16 PM, Dave Page wrote: > >> > >> On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar > >>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1938 - Backgrid sorting not working for Integer/Number types

Hi Dave, I just missed the code for swapping left and right values if order is descending. It's fixed. Please find attached patch and review. On Mon, Jan 9, 2017 at 9:05 AM, Dave Page wrote: > Hi > > On Friday, January 6, 2017, Surinder Kumar com> wrote: > >> Hi, &g

[pgadmin-hackers] [pgAdmin4][Patch]: RM1938 - Backgrid sorting not working for Integer/Number types

atch and review. Thanks, Surinder Kumar RM1938.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: RM1830 - Error generating reversed engineering sql

Hi, This issue is due to syntax error in query. The issue was found in sql template files for "post8_4", "post9_0" and "post9_1" servers. Please find attached patch and review. Thanks, Surinder Kumar RM1830.patch Description: Binary data -- Sent via pgadmin

[pgadmin-hackers] [pgAdmin4][Patch]: RM1832 - Dependency information not displayed for Synonym node

Hi, Issue: It was python list index error - when we try to access an empty list. This case is handled in the patch. Please find attached patch and review. Thanks, Surinder Kumar RM1832.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

[pgadmin-hackers] [pgAdmin4][Patch]: RM#2033 - Image missing for dependents objects in dependents tab

Hi, The icons for unique constraint and exclusion constraint were not displaying due to incorrect object names given for icon. This is now fixed. Please find attached patch and review. Thanks, Surinder Kumar RM2033.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] [pgAdmin4][Patch]: RM2039 - Big (numeric) numbers are sometimes rounded up when displayed

Hi, Added 'numeric' type into string typecaster to prevent python from rounded up. Please find attached patch and review. Thanks, Surinder Kumar RM2039.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make chang

[pgadmin-hackers] [pgAdmin4][Patch]: RM 2012 - Disable Save button if name is empty in Server-group

Hi, The issue is with validation which is now fixed. Please find attached patch and review. Thanks, Surinder Kumar RM2012.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

  1   2   3   4   >