Re: [BUGS] BUG #7811: strlen(NULL) cause psql crash

2013-01-15 Thread Tom Lane
Heikki Linnakangas writes: > Hmm, I wonder if an empty string would be better? It'd look a bit odd, > but at least it would not mislead you to think you're connected to a > database called "none". Works for me as a back-branch fix, especially since then we're adding zero new strings to the back

Re: [BUGS] BUG #7811: strlen(NULL) cause psql crash

2013-01-15 Thread Heikki Linnakangas
On 15.01.2013 21:13, Tom Lane wrote: Heikki Linnakangas writes: On 15.01.2013 20:29, Tom Lane wrote: But you already introduced "none" as a stand-alone (and probably almost untranslatable without context) string. That's better? I figured it would be. One little untranslated string in paren

Re: [BUGS] BUG #7811: strlen(NULL) cause psql crash

2013-01-15 Thread Tom Lane
Heikki Linnakangas writes: > On 15.01.2013 20:29, Tom Lane wrote: >> But you already introduced "none" as a stand-alone (and probably almost >> untranslatable without context) string. That's better? > I figured it would be. One little untranslated string in parens, versus > the whole is untrans

Re: [BUGS] BUG #7811: strlen(NULL) cause psql crash

2013-01-15 Thread Heikki Linnakangas
On 15.01.2013 20:29, Tom Lane wrote: Heikki Linnakangas writes: On 15.01.2013 20:10, Tom Lane wrote: I think that patch could use more thought. As is, it will print connect to new database (currently "none") which to me is claiming that we are connected to a database whose name is "no

Re: [BUGS] BUG #7811: strlen(NULL) cause psql crash

2013-01-15 Thread Tom Lane
Heikki Linnakangas writes: > On 15.01.2013 20:10, Tom Lane wrote: >> I think that patch could use more thought. As is, it will print >> connect to new database (currently "none") >> which to me is claiming that we are connected to a database whose name >> is "none". The quotes should not be

Re: [BUGS] BUG #7811: strlen(NULL) cause psql crash

2013-01-15 Thread Heikki Linnakangas
On 15.01.2013 20:10, Tom Lane wrote: Heikki Linnakangas writes: I committed a local fix to help.c to print "none" as the database name when not connected. I think that patch could use more thought. As is, it will print connect to new database (currently "none") which to me is claim

Re: [BUGS] BUG #7811: strlen(NULL) cause psql crash

2013-01-15 Thread Tom Lane
Heikki Linnakangas writes: > That'd change the behavior of all sprintf calls, not sure we want to go > there. I don't think so; especially since the proposed fix doesn't help on systems where we are using the native printf. > I committed a local fix to help.c to print "none" as the database nam

Re: [BUGS] BUG #7811: strlen(NULL) cause psql crash

2013-01-15 Thread Heikki Linnakangas
On 15.01.2013 16:18, 1584171...@qq.com wrote: I give you a description about how to trigger this bug first: (1) start the server with the command "postgres -D pgdata" (2) start the client with the command "psql" (3) close the server (4) execute a

[BUGS] BUG #7811: strlen(NULL) cause psql crash

2013-01-15 Thread 1584171677
The following bug has been logged on the website: Bug reference: 7811 Logged by: Meng Qingzhong Email address: 1584171...@qq.com PostgreSQL version: 9.2.2 Operating system: Windows 7 Description: I find a bug this time really and I have fixed it. The bug is in psql,