pgsql: Consider materializing the cheapest inner path in parallel nestl

2024-07-11 Thread Richard Guo
when building partial nestloop paths. This approach potentially reduces the need to rescan the inner side of a partial nestloop path for each outer tuple. Author: Tender Wang Reviewed-by: Richard Guo, Robert Haas, David Rowley, Alena Rybakina Reviewed-by: Tomasz Rybak, Paul Jungwirth, Yuki Fujii

pgsql: Remove an extra period in code comment

2024-07-07 Thread Richard Guo
Remove an extra period in code comment Author: Junwang Zhao Discussion: https://postgr.es/m/CAEG8a3L9GgfKc+XT+NMHPY7atAOVYqjUqKEFQKhcPHFYRW=p...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d7db04dfdae361479e77054670ee9d806c6a6420 Modified Files

pgsql: Fix right-anti-joins when the inner relation is proven unique

2024-07-07 Thread Richard Guo
-right-anti-join does not suffer from this wrong results issue, we apply the same change to it as well, to help save cycles for the same reason. Per bug #18522 from Antti Lampinen, and bug #18526 from Feliphe Pozzer. Back-patch to v16 where right-anti-join was introduced. Author: Richard Guo

pgsql: Fix right-anti-joins when the inner relation is proven unique

2024-07-07 Thread Richard Guo
-right-anti-join does not suffer from this wrong results issue, we apply the same change to it as well, to help save cycles for the same reason. Per bug #18522 from Antti Lampinen, and bug #18526 from Feliphe Pozzer. Back-patch to v16 where right-anti-join was introduced. Author: Richard Guo

pgsql: Fix right-anti-joins when the inner relation is proven unique

2024-07-07 Thread Richard Guo
-right-anti-join does not suffer from this wrong results issue, we apply the same change to it as well, to help save cycles for the same reason. Per bug #18522 from Antti Lampinen, and bug #18526 from Feliphe Pozzer. Back-patch to v16 where right-anti-join was introduced. Author: Richard Guo

pgsql: Support "Right Semi Join" plan shapes

2024-07-04 Thread Richard Guo
in this patch. Note that this patch also modifies a test query in join.sql to ensure it continues testing as intended. With this patch the original query would result in a right-semi-join rather than semi-join, compromising its original purpose of testing the fix for neqjoinsel's behavior for semi-joins.

pgsql: Fix comment about cross-checking the varnullingrels

2024-06-09 Thread Richard Guo
Fix comment about cross-checking the varnullingrels The nullingrels match checks are not limited to debugging builds. Oversight in commit 867be9c07. Author: Richard Guo Reviewed-by: Alvaro Herrera, Tom Lane, Robert Haas Discussion: https://postgr.es/m/CAMbWs4_SDsdYD7DdQw7RXc3jv3axbg

Re: pgsql: Remove over-optimistic Assert.

2023-02-02 Thread Richard Guo
On Thu, Feb 2, 2023 at 8:40 AM Tom Lane wrote: > Remove over-optimistic Assert. > > In commit 2489d76c4, I'd thought it'd be safe to assert that a > PlaceHolderVar appearing in a scan-level expression has empty > nullingrels. However this is not so, as when we determine that a > join relation