Re: [COMMITTERS] pgsql: Remove secondary checkpoint

On Wed, Nov 8, 2017 at 4:43 AM, Tom Lane wrote: > Andres Freund writes: >> I think you misunderstand my point - I'm saying that pg_resetxlog should >> be able to force the use of older checkpoints, basically as a fallback >> to cases where the previous

Re: [COMMITTERS] pgsql: Stamp 9.2.24.

On Tue, Nov 7, 2017 at 7:39 AM, Tom Lane wrote: > Peter Geoghegan writes: >> Tom Lane wrote: >>> Stamp 9.2.24. > >> Uh, I thought 9.2 was EOL. > > Now it is ... 9.2.24 is the last of the 9.2-series, November being the last minor release

Re: [COMMITTERS] pgsql: Replace most usages of ntoh[ls] and hton[sl] with pg_bswap.h.

On Mon, Oct 2, 2017 at 8:08 AM, Andres Freund wrote: > Replace most usages of ntoh[ls] and hton[sl] with pg_bswap.h. > > All postgres internal usages are replaced, it's just libpq example > usages that haven't been converted. External users of libpq can't > generally rely on

Re: [COMMITTERS] pgsql: Fix bogus size calculation introduced by commit cc5f81366.

On Mon, Sep 18, 2017 at 6:58 AM, Thomas Munro wrote: > While googling around trying to find where I could read Coverity's > output myself I was intrigued to see that https://scan.coverity.com > offers integration with Travis CI[1], which suggests the possibility >

Re: [COMMITTERS] pgsql: pg_receivewal: Improve verbose mode

On Wed, Aug 16, 2017 at 9:27 AM, Peter Eisentraut wrote: > pg_receivewal: Improve verbose mode > > Some informational messages showed up even if verbose mode was not > used. Move them to verbose mode. Perhaps this should be back-patched? It seems to me that this is an oversight

Re: [COMMITTERS] Vendor LLVM 4.0.

On Sat, Apr 1, 2017 at 5:27 PM, Thomas Munro wrote: > On Sat, Apr 1, 2017 at 8:41 PM, Andres Freund wrote: >> For the upcoming JIT support LLVM is required. To avoid issues with >> having to support multiple LLVM versions, add a vendored

Re: [COMMITTERS] pgsql: Faster expression evaluation and targetlist projection.

On Sun, Mar 26, 2017 at 7:58 AM, David Rowley wrote: > On 26 March 2017 at 09:55, Thomas Munro wrote: >> On Sun, Mar 26, 2017 at 11:11 AM, Andres Freund wrote: >>> Faster expression evaluation and targetlist

Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

On Wed, Feb 22, 2017 at 8:39 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Wed, Feb 22, 2017 at 6:57 AM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> Fujii Masao

Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane wrote: > Fujii Masao writes: >> Fix connection leak in DROP SUBSCRIPTION command. >> Previously the command forgot to close the connection to the publisher >> when it failed to drop the replication slot. > > If

Re: [COMMITTERS] pgsql: Add new function dsa_allocate0.

On Fri, Feb 17, 2017 at 12:03 PM, Thomas Munro wrote: > On Fri, Feb 17, 2017 at 11:34 AM, Thomas Munro > wrote: >> On Fri, Feb 17, 2017 at 7:02 AM, Robert Haas wrote: >>>

Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

On Wed, Dec 7, 2016 at 7:46 AM, Andres Freund wrote: > On 2016-12-05 11:44:37 +, Heikki Linnakangas wrote: >> Replace PostmasterRandom() with a stronger source, second attempt. > > Since this went in I've seen > 2016-12-06 14:42:17.005 PST [23658][] LOG: wrong key in

Re: [COMMITTERS] pgsql: Use latch instead of select() in walreceiver

On Fri, Dec 2, 2016 at 10:29 AM, Peter Eisentraut wrote: > Use latch instead of select() in walreceiver > > Replace use of poll()/select() by WaitLatchOrSocket(), which is more > portable and flexible. > > Also change walreceiver to use its procLatch instead of a custom latch. >

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

On Tue, Oct 18, 2016 at 6:28 AM, Tom Lane wrote: > Heikki Linnakangas writes: >> Use OpenSSL EVP API for symmetric encryption in pgcrypto. > > BTW, "narwhal" seems to have a problem with this. > Not very clear what, maybe an incompatibility with old

Re: [COMMITTERS] pgsql: pg_ctl: Detect current standby state from pg_control

On Mon, Sep 26, 2016 at 12:54 AM, Tom Lane wrote: > Peter Eisentraut writes: >> pg_ctl: Detect current standby state from pg_control > > Coverity thinks that this patch introduced a bunch of > null-pointer-dereference hazards, and AFAICS it is right. > The

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

On Tue, Sep 6, 2016 at 5:36 PM, Christian Ullrich <ch...@chrullrich.net> wrote: > * Michael Paquier wrote: >> In order to avoid any problems with the load and unload windows, my >> bet goes for 0001, 0002 and 0003, with the last two patches merged >> together, 0001 bein

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

On Thu, Sep 1, 2016 at 4:03 PM, Christian Ullrich <ch...@chrullrich.net> wrote: > * Michael Paquier wrote: > >> On Wed, Apr 27, 2016 at 2:39 AM, Christian Ullrich <ch...@chrullrich.net> >> wrote: > >>> * Christian Ullrich wrote: > >> And actually

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

On Wed, Apr 27, 2016 at 2:39 AM, Christian Ullrich wrote: > * Christian Ullrich wrote: > >> wrong even without considering the debug/release split. If we load a >> compiled extension built with a CRT we have not seen yet, _after_ the >> first call to pgwin32_putenv(), that

Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

On Wed, Apr 27, 2016 at 12:04 PM, Andres Freund wrote: > On 2016-04-26 22:59:44 -0400, Tom Lane wrote: >> What's the argument that it makes debugging harder? Especially if >> you aren't using it? > > If you try to write a V1 function, but forget or mistype/rename the >

Re: [COMMITTERS] pgsql: Use GRANT system to manage access to sensitive functions

On Thu, Apr 7, 2016 at 10:45 AM, Stephen Frost wrote: > Use GRANT system to manage access to sensitive functions > > Now that pg_dump will properly dump out any ACL changes made to > functions which exist in pg_catalog, switch to using the GRANT system > to manage access to

Re: [COMMITTERS] pgsql: Generic Messages for Logical Decoding

On Wed, Apr 6, 2016 at 6:08 PM, Simon Riggs wrote: > Generic Messages for Logical Decoding > > API and mechanism to allow generic messages to be inserted into WAL that are > intended to be read by logical decoding plugins. This commit adds an optional > new callback to the

Re: [HACKERS] [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

On Wed, Apr 6, 2016 at 9:27 PM, Andres Freund wrote: > On 2016-04-06 13:11:40 +0100, Simon Riggs wrote: >> On 6 April 2016 at 10:09, Andres Freund wrote: >> > On 2016-04-06 10:04:42 +0100, Simon Riggs wrote: >> > The issue there is that we continue to

Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

On Mon, Apr 4, 2016 at 4:50 PM, Andres Freund wrote: > On 2016-04-04 08:44:47 +0100, Simon Riggs wrote: >> That patch does exactly the same thing as the patch you prefer, just >> does it differently; > > No, it doesn't; as explained above. FWIW, I vote also for reverting this

Re: [COMMITTERS] pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

t; >> Bug 13685 reported by Laurence Rowe, investigated in detail by Michael >> Paquier, >> though this is not his proposed fix. >> 20151016203031.3019.72...@wrigleys.postgresql.org >> >> Simple non-invasive patch to allow later backpatch to 9.4 and 9.5 Well... &g

Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches

On Thu, Mar 31, 2016 at 8:45 AM, Alvaro Herrera wrote: > Tom Lane wrote: >> Alvaro Herrera writes: >> > Enable logical slots to follow timeline switches >> >> Buildfarm doesn't like this one bit :-( > > Argh, forgot the alternate expected file

Re: [COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'remote_apply'.

On Wed, Mar 30, 2016 at 10:39 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Mar 29, 2016 at 9:37 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> On Wed, Mar 30, 2016 at 10:31 AM, Robert Haas <rh...@postgresql.org> wrote: >>> Add

Re: [COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'remote_apply'.

and at least avoids any extra replies for > people not using the feature at all. > > Thomas Munro, reviewed by Michael Paquier and by me. Some additional > tweaks by me. The commit message does not directly mention that the spec of walrcv_receive has been changed in a backward-incompatib

Re: [COMMITTERS] pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.

On Tue, Mar 22, 2016 at 10:20 AM, Andrew Dunstan wrote: > > > On 03/21/2016 09:25 AM, Tom Lane wrote: >> >> Andres Freund writes: >>> >>> On 2016-03-21 22:38:50 +1300, David Rowley wrote: Perl is not my native tongue, but after a little study

Re: [COMMITTERS] pgsql: Convert psql's flex lexer to be re-entrant, and make it compile

On Sat, Mar 19, 2016 at 10:22 AM, Tom Lane wrote: > Also, stop compiling psqlscan as part of mainloop.c, and make it a > standalone build target instead. This is a lot cleaner than before, though > it doesn't really change much in practice as of this commit. (I'm not sure >

Re: [COMMITTERS] pgsql: Don't vacuum all-frozen pages.

On Fri, Mar 11, 2016 at 2:08 AM, Amit Langote wrote: > On 2016/03/11 8:19, Peter Geoghegan wrote: >> On Thu, Mar 10, 2016 at 1:22 PM, Andres Freund wrote: >>> Yeha! >> >> Fantastic effort, particularly from Masahiko. Well done. > > +1! Yuhu. --

Re: [COMMITTERS] pgsql: Checkpoint sorting and balancing.

On Fri, Mar 11, 2016 at 2:29 AM, Andres Freund wrote: > Checkpoint sorting and balancing. +1. -- Michael -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Add pg_size_bytes() to parse human-readable size strings.

On Sat, Feb 20, 2016 at 7:17 PM, Dean Rasheed <dean.a.rash...@gmail.com> wrote: > On 20 February 2016 at 10:12, Michael Paquier <michael.paqu...@gmail.com> > wrote: >> Happy first commit. > > Arg. Not so much. > > Looks like I broke something -- looking into

Re: [COMMITTERS] pgsql: Add pg_size_bytes() to parse human-readable size strings.

On Sat, Feb 20, 2016 at 7:12 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sat, Feb 20, 2016 at 7:07 PM, Dean Rasheed <dean.a.rash...@gmail.com> > wrote: >> Add pg_size_bytes() to parse human-readable size strings. >> >> This will

Re: [COMMITTERS] pgsql: Add pg_size_bytes() to parse human-readable size strings.

ed-by: Vitaly Burovoy, Oleksandr Shulgin, Kyotaro Horiguchi, > Michael Paquier and Robert Haas Happy first commit. -- Michael -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Support parallel joins, and make related improvements.

On Thu, Jan 21, 2016 at 7:59 AM, Bruce Momjian wrote: > On Wed, Jan 20, 2016 at 07:41:07PM +, Robert Haas wrote: >> Support parallel joins, and make related improvements. > > Wow, that is big news! Yuhu! -- Michael -- Sent via pgsql-committers mailing list

Re: [COMMITTERS] pgsql: some bullshit

On Tue, Dec 22, 2015 at 8:16 AM, Alvaro Herrera wrote: > Alvaro Herrera wrote: >> some bullshit > > This commit was supposed to be squashed with the next one --- hence > the, err, not-terribly-descriptive commit message. This mistake may > cause future "git bisect" runs

Re: [COMMITTERS] pgsql: Code and docs review for multiple -c and -f options in psql.

On Mon, Dec 14, 2015 at 11:16 AM, Michael Paquier wrote: > - cell = (SimpleActionListCell *) > - pg_malloc(offsetof(SimpleActionListCell, val) + vallen + 1); > Thanks! Among all those things this bit is a bit shameful.. (I am the one at the origin of that FWIW) -- Michael --

Re: [COMMITTERS] pgsql: Code and docs review for multiple -c and -f options in psql.

On Mon, Dec 14, 2015 at 4:52 AM, Tom Lane wrote: > Code and docs review for multiple -c and -f options in psql. > > Commit d5563d7df94488bf drew complaints from Coverity, which quite > correctly complained that one copy of each -c or -f string was being > leaked. What's more,

Re: [COMMITTERS] pgsql: Fix bug leading to restoring unlogged relations from empty files

On Mon, Dec 14, 2015 at 2:26 PM, Peter Eisentraut wrote: > the call to LWLockHeldByMe() is useless. Yes, but it should be an Assert. I guess that Andres is on it.. -- Michael -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your

Re: [COMMITTERS] pgsql: pg_rewind: Don't error if the two clusters are already on the sa

On Sat, Dec 12, 2015 at 9:11 AM, Tom Lane wrote: > Peter Eisentraut writes: >> pg_rewind: Don't error if the two clusters are already on the same timeline >> This previously resulted in an error and a nonzero exit status, but >> after discussion this should

Re: [COMMITTERS] pgsql: Refactor Perl test code

On Thu, Dec 3, 2015 at 8:38 AM, Tom Lane wrote: > Test Summary Report > --- > t/001_initdb.pl (Wstat: 6400 Tests: 8 Failed: 0) > Non-zero exit status: 25 > Parse errors: Bad plan. You planned 14 tests but ran 8. > Files=1, Tests=8, 0 wallclock secs ( 0.02 usr 0.00 sys +

Re: [COMMITTERS] pgsql: libpq: Notice errors a backend may have sent just before dying.

On Fri, Nov 13, 2015 at 1:54 AM, Tom Lane wrote: > I wrote: >> After looking around, I suspect what actually happened in your test >> was that we kept pumping pqReadData until it realized it was seeing EOF, >> whereupon it did pqDropConnection(), and guess what that does: > >>

Re: [COMMITTERS] pgsql: Generate parallel sequential scan plans in simple cases.

On Thu, Nov 12, 2015 at 4:06 AM, Joe Conway wrote: > On 11/11/2015 10:54 AM, Robert Haas wrote: >> On Wed, Nov 11, 2015 at 10:35 AM, Magnus Hagander >> wrote: >>> On Wed, Nov 11, 2015 at 4:32 PM, Simon Riggs wrote: On 11

Re: [COMMITTERS] pgsql: Add missing_ok option to the SQL functions for reading files.

On Fri, Aug 28, 2015 at 9:39 PM, Bruce Momjian br...@momjian.us wrote: On Sun, Jul 5, 2015 at 08:44:41PM +0900, Michael Paquier wrote: On Mon, Jun 29, 2015 at 3:39 AM, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Add missing_ok option to the SQL functions for reading files

Re: [COMMITTERS] pgsql: Reduce lock levels for ALTER TABLE SET autovacuum storage option

On Fri, Aug 14, 2015 at 10:20 PM, Simon Riggs si...@2ndquadrant.com wrote: Reduce lock levels for ALTER TABLE SET autovacuum storage options Reduce lock levels down to ShareUpdateExclusiveLock for all autovacuum-related relation options when setting them using ALTER TABLE. Add infrastructure

Re: [COMMITTERS] pgsql: Allow pg_create_physical_replication_slot() to reserve WAL.

On Tue, Aug 11, 2015 at 7:47 PM, Andres Freund and...@anarazel.de wrote: Allow pg_create_physical_replication_slot() to reserve WAL. When creating a physical slot it's often useful to immediately reserve the current WAL position instead of only doing after the first feedback message arrives.

Re: [COMMITTERS] pgsql: Allow pg_create_physical_replication_slot() to reserve WAL.

On Fri, Aug 14, 2015 at 3:50 PM, Andres Freund and...@anarazel.de wrote: On 2015-08-14 15:32:17 +0900, Michael Paquier wrote: Why hasn't this addition been spread as well in the replication protocol? It seems to me that most of the refactoring work has been done with ReplicationSlotReserveWal

Re: [COMMITTERS] pgsql: Optionally don't error out due to preexisting slots in commandli

On Mon, Jul 13, 2015 at 5:17 AM, Andres Freund and...@anarazel.de wrote: Optionally don't error out due to preexisting slots in commandline utilities. pg_receivexlog and pg_recvlogical error out when --create-slot is specified and a slot with the same name already exists. In some cases,

Re: [COMMITTERS] pgsql: This routine was calling ecpg_alloc to allocate to memory but di

On Wed, Aug 12, 2015 at 8:59 PM, Michael Meskes mes...@postgresql.org wrote: On 23.07.2015 09:19, Michael Paquier wrote: On Thu, Feb 5, 2015 at 11:14 PM, Michael Meskes mes...@postgresql.org wrote: This routine was calling ecpg_alloc to allocate to memory but did not actually check

Re: [COMMITTERS] pgsql: Fix pg_rewind when pg_xlog is a symlink.

On Mon, Aug 3, 2015 at 10:37 PM, Heikki Linnakangas wrote: That's only on master, though. The TAP tests don't run on Windows in 9.5 anyway. Oops, yes I got mistaken by the commit on 9.5. I guess the pg_rewind tests used to work, but we didn't really advertise or make it easy to run it, so

Re: [COMMITTERS] pgsql: Fix pg_rewind when pg_xlog is a symlink.

On Mon, Aug 3, 2015 at 9:34 PM, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Fix pg_rewind when pg_xlog is a symlink. pg_xlog is often a symlink, typically to a different filesystem. Don't get confused and comlain about by that, and just always pretend that it's a normal directory,

Re: [COMMITTERS] pgsql: pg_basebackup: Add tests for -X option

On Wed, Jul 29, 2015 at 9:34 AM, Peter Eisentraut pete...@gmx.net wrote: pg_basebackup: Add tests for -X option One thing that I noticed after more tests is that actually the LSN position restart_lsn is not necessarily 8-character long as this tests, but it can be 7-character length as well:

Re: [COMMITTERS] pgsql: This routine was calling ecpg_alloc to allocate to memory but di

by Michael Paquier mich...@otacoo.com Coming back to it, perhaps this meritates a backpatch? Even if that's unlikely to happen... -- Michael -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [COMMITTERS] pgsql: pg_upgrade: fix one-byte per empty db memory leak

On Tue, Jul 21, 2015 at 10:29 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Sat, Jan 10, 2015 at 2:12 AM, Bruce Momjian br...@momjian.us wrote: pg_upgrade: fix one-byte per empty db memory leak Report by Tatsuo Ishii, Coverity Shouldn't this commit

Re: [COMMITTERS] pgsql: vacuumlo: Avoid unlikely memory leak.

On Thu, Jan 15, 2015 at 5:18 AM, Robert Haas rh...@postgresql.org wrote: vacuumlo: Avoid unlikely memory leak. Spotted by Coverity. This isn't likely to matter in practice, but there's no harm in fixing it. Coming back to this one, shouldn't this commit be backpatched? -- Michael -- Sent

Re: [COMMITTERS] pgsql: pg_upgrade: fix one-byte per empty db memory leak

On Sat, Jan 10, 2015 at 2:12 AM, Bruce Momjian br...@momjian.us wrote: pg_upgrade: fix one-byte per empty db memory leak Report by Tatsuo Ishii, Coverity Shouldn't this commit be backpatched where needed.? -- Michael -- Sent via pgsql-committers mailing list

Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY

On Fri, Jul 17, 2015 at 11:16 PM, Kevin Grittner kgri...@ymail.com wrote: Heikki Linnakangas heikki.linnakan...@iki.fi wrote: This fixes bug #13126, reported by Kirill Simonov. It looks like you missed something with the addition of AT_ReAddComment: test_ddl_deparse.c:80:11: warning:

Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY

On Tue, Jul 14, 2015 at 10:02 PM, Tom Lane t...@sss.pgh.pa.us wrote: Heikki Linnakangas heikki.linnakan...@iki.fi writes: Retain comments on indexes and constraints at ALTER TABLE ... TYPE ... One or the other of these patches has broken the majority of the buildfarm. Some ORDER BY clauses

Re: [COMMITTERS] pgsql: Add missing_ok option to the SQL functions for reading files.

On Mon, Jun 29, 2015 at 3:39 AM, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Add missing_ok option to the SQL functions for reading files. This makes it possible to use the functions without getting errors, if there is a chance that the file might be removed or renamed concurrently.

Re: [COMMITTERS] pgsql: Run the C portions of guc-file.l through pgindent.

On Mon, Jun 29, 2015 at 9:49 AM, Tom Lane t...@sss.pgh.pa.us wrote: Run the C portions of guc-file.l through pgindent. Yeah, I know, pretty anal-retentive of me. But we oughta find some way to automate this for the .y and .l files. .y files may be tricky and .l files less. Still one good way

Re: [COMMITTERS] pgsql: Fixed some memory leaks in ECPG.

On Sat, Jun 13, 2015 at 6:06 PM, Michael Meskes mes...@postgresql.org wrote: On Sat, Jun 13, 2015 at 12:21:49PM +0900, Michael Paquier wrote: Shouldn't this commit be cherry-picked on back-branches? Yes and it will, I'm currently working on it. I somehow got into the habbit of doing

Re: [COMMITTERS] pgsql: Fix intoasc() in Informix compat lib. This function used to be a

On Fri, Jun 12, 2015 at 10:05 PM, Michael Meskes mes...@postgresql.org wrote: Fix intoasc() in Informix compat lib. This function used to be a noop. Shouldn't this commit be cherry-picked on back-branches? -- Michael -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)

Re: [COMMITTERS] pgsql: pgindent: more doc updates for skipping __asm__ files

On Mon, May 25, 2015 at 10:51 AM, Bruce Momjian br...@momjian.us wrote: pgindent: more doc updates for skipping __asm__ files s/they contains/they contain/. -- Michael -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription:

Re: [COMMITTERS] pgsql: Recognize REGRESS_OPTS += ... syntax in MSVC build scripts.

On Tue, May 19, 2015 at 2:40 AM, Tom Lane t...@sss.pgh.pa.us wrote: Recognize REGRESS_OPTS += ... syntax in MSVC build scripts. Necessitated by commit b14cf229f4bd7238be2e31d873dc5dd241d3871e. Per buildfarm. Perhaps \+? could be spread to REGRESS as well in fetchTests? -- Michael -- Sent

Re: [COMMITTERS] pgsql: Separate block sampling functions

On Fri, May 15, 2015 at 8:44 PM, Andrew Dunstan and...@dunslane.net wrote: On 05/15/2015 06:04 AM, Simon Riggs wrote: On 15 May 2015 at 04:59, Tom Lane t...@sss.pgh.pa.us mailto:t...@sss.pgh.pa.us wrote: The difference there was that that was specifically adding a new feature

Re: [COMMITTERS] pgsql: contrib/tsm_system_time

On Sat, May 16, 2015 at 5:28 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, May 15, 2015 at 3:32 PM, Simon Riggs si...@2ndquadrant.com wrote: contrib/tsm_system_time I don't want to be overly critical here, but I find that a pretty worthless commit message. And there is no

Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension

On Sat, May 16, 2015 at 4:44 AM, Stephen Frost sfr...@snowman.net wrote: Fujii, * Fujii Masao (masao.fu...@gmail.com) wrote: pg_audit uses 1.0.0 as its version number. But, is the third digit really required? Why? We usually uses the version number with two digits in contrib modules. I

Re: [COMMITTERS] pgsql: Separate block sampling functions

On Fri, May 15, 2015 at 12:03 PM, Simon Riggs si...@2ndquadrant.com wrote: On 15 May 2015 at 03:50, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: Separate block sampling functions This patch broke buildfarm member crake. OK, thanks. I missed that amongst

Re: [COMMITTERS] pgsql: Separate block sampling functions

On Fri, May 15, 2015 at 12:12 PM, Simon Riggs si...@2ndquadrant.com wrote: On 15 May 2015 at 04:06, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, May 15, 2015 at 12:03 PM, Simon Riggs si...@2ndquadrant.com wrote: On 15 May 2015 at 03:50, Tom Lane t...@sss.pgh.pa.us wrote

Re: [COMMITTERS] pgsql: Separate block sampling functions

On Fri, May 15, 2015 at 12:22 PM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: On Fri, May 15, 2015 at 12:03 PM, Simon Riggs si...@2ndquadrant.com wrote: On 15 May 2015 at 03:50, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

On Wed, May 13, 2015 at 12:31 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: Mind share more details about that? How would you detect that a given test in serial_schedule needs to be considered by test_ddl_deparse automatically? WIth a new type of keyword

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

On Tue, May 12, 2015 at 11:43 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Not sure what's the real

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

On Tue, May 12, 2015 at 1:05 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 11:43 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

On Tue, May 12, 2015 at 1:18 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, May 12, 2015 at 1:05 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 11:43 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, May 12, 2015

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Allow on-the-fly capture of DDL event details This feature lets user code inspect and take action on DDL events. Whenever a ddl_command_end event trigger is installed, DDL actions executed are saved to a list which

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Allow on-the-fly capture of DDL event details This feature lets user code inspect and take action on DDL

Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.

On Fri, May 8, 2015 at 1:09 PM, Andres Freund and...@anarazel.de wrote: On May 7, 2015 9:07:55 PM PDT, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, May 8, 2015 at 12:43 PM, Andres Freund and...@anarazel.de wrote: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. magpie

Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.

On Fri, May 8, 2015 at 12:43 PM, Andres Freund and...@anarazel.de wrote: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. magpie is complaining: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=magpiedt=2015-05-08%2003%3A45%3A15 And I can reproduce the failure as well on my OSX

Re: [COMMITTERS] pgsql: Move interpreter shared library detection to configure

On Sat, May 2, 2015 at 10:39 AM, Peter Eisentraut pete...@gmx.net wrote: Move interpreter shared library detection to configure For building PL/Perl, PL/Python, and PL/Tcl, we need a shared library of libperl, libpython, and libtcl, respectively. Previously, this was checked in the

Re: [COMMITTERS] pgsql: Copy editing of the replication origins patch.

On Fri, May 1, 2015 at 7:26 PM, Andres Freund and...@anarazel.de wrote: Copy editing of the replication origins patch. Michael Paquier and myself. -* Needs to fit into a uint16, so we don't waste too much space in WAL +* Needs to fit into an uint16, so we don't waste too much

Re: [COMMITTERS] pgsql: Introduce replication progress tracking infrastructure.

On Thu, Apr 30, 2015 at 2:37 AM, Andres Freund and...@anarazel.de wrote: Introduce replication progress tracking infrastructure. [...] Some comments about the docs: 1) the the: + entry +Create a replication origin with the the passed in external +name, and create an

Re: [COMMITTERS] pgsql: Add transforms feature

On Tue, Apr 28, 2015 at 10:01 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Apr 28, 2015 at 9:55 AM, Andrew Dunstan wrote: w.r.t MSVC builds, it looks like we need entries in $contrib_extraincludes in src/tools/msvc/Mkvcbuild.pm at the very least. If our goal is to put back

Re: [COMMITTERS] pgsql: Add transforms feature

On Mon, Apr 27, 2015 at 1:36 AM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: Add transforms feature I don't know why this patch is fooling around with compile/link flags, but it's broken at least prairiedog and some of the Windows critters. It breaks as well

Re: [COMMITTERS] pgsql: Add transforms feature

On Tue, Apr 28, 2015 at 9:55 AM, Andrew Dunstan wrote: w.r.t MSVC builds, it looks like we need entries in $contrib_extraincludes in src/tools/msvc/Mkvcbuild.pm at the very least. If our goal is to put back to green the Windows nodes as quick as possible, we could bypass their build this way ,

Re: [COMMITTERS] pgsql: Make the pg_rewind regression tests more robust on slow systems.

On Wed, Apr 22, 2015 at 8:37 PM, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Make the pg_rewind regression tests more robust on slow systems. There were a couple of hard-coded sleeps in the tests: to wait for standby to catch up with master, and to wait for promotion with pg_ctl

Re: [COMMITTERS] pgsql: Add missing installcheck target to pg_rewind's Makefile

On Wed, Apr 22, 2015 at 5:38 AM, Tom Lane t...@sss.pgh.pa.us wrote: (I chanced to notice this while wondering why hamster is failing on this test. I can't reproduce the failure locally, but ...) With a very slow environment you will be able to reproduce the failure. -- Michael

Re: [COMMITTERS] pgsql: Move pg_test_fsync from contrib/ to src/bin/

On Mon, Apr 20, 2015 at 11:39 AM, Peter Eisentraut pete...@gmx.net wrote: Move pg_test_fsync from contrib/ to src/bin/ Point of detail that I just noticed: wouldn't it be better to have a header in pg_test_fsync.c of a shape similar to the other files. Now there is only that: /* *

Re: [COMMITTERS] pgsql: Mark the second argument of pg_log as the translatable string in

On Wed, Apr 15, 2015 at 4:55 PM, Heikki Linnakangas wrote: On 04/15/2015 06:41 AM, Fujii Masao wrote: Another question is; should we output the progress report to stderr rather than stdout? I thought this because I found that pg_basebackup reports the progress to stderr. Yeah, probably. We

Re: [COMMITTERS] pgsql: Error out in pg_rewind if lstat() fails.

On Thu, Apr 16, 2015 at 5:15 AM, Heikki Linnakangas heikki.linnakan...@iki.fi wrote: Error out in pg_rewind if lstat() fails. A file not found is expected if the source server is running, so don't complain about that. But any other error is definitely not expected. Nitpicking: strings of

Re: [COMMITTERS] pgsql: Fix multiple bugs and infelicities in pg_rewind.

On Mon, Mar 30, 2015 at 9:02 AM, Tom Lane t...@sss.pgh.pa.us wrote: Fix multiple bugs and infelicities in pg_rewind. Bugs all spotted by Coverity, including wrong realloc() size request and memory leaks. Cosmetic improvements by me. The usage of the global variable filemap here is still

Re: [COMMITTERS] pgsql: Mark the second argument of pg_log as the translatable string in

On Sun, Apr 12, 2015 at 10:17 AM, Alvaro Herrera wrote: What pg_basebackup's progress_report() does is have the message in the translatable part not include the \r; the \r is in a separate fprintf() call. Like the attached then. -- Michael diff --git a/src/bin/pg_rewind/logging.c

Re: [COMMITTERS] pgsql: Mark the second argument of pg_log as the translatable string in

On Wed, Apr 8, 2015 at 11:06 AM, Fujii Masao fu...@postgresql.org wrote: Mark the second argument of pg_log as the translatable string in nls.mk. nls.mk is still missing file_ops.c in GETTEXT_FILES as it contains some calls to pg_fatal. -- Michael -- Sent via pgsql-committers mailing list

Re: [COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

On Thu, Apr 2, 2015 at 10:29 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Apr 2, 2015 at 8:10 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: psql: fix \connect with URIs and conninfo strings psql was already accepting conninfo strings as the first parameter

Re: [COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

On Thu, Apr 2, 2015 at 10:58 AM, Michael Paquier michael.paqu...@gmail.com wrote: On other Linux machines, tests for dblink are failing: + ERROR: could not load library /usr/src/pgfarm/build/HEAD/inst/lib/postgresql/dblink.so: /usr/src/pgfarm/build/HEAD/inst/lib/libpq.so.5: undefined symbol

Re: [COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

On Thu, Apr 2, 2015 at 8:10 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: psql: fix \connect with URIs and conninfo strings psql was already accepting conninfo strings as the first parameter in \connect, but the way it worked wasn't sane; some of the other parameters would get the

Re: [COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

On Thu, Apr 2, 2015 at 11:49 AM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: The patch attached fixes all those inconsistencies (tested build on OSX and Windows). I think this is going in the wrong direction entirely, ie doubling down on Alvaro's

Re: [COMMITTERS] pgsql: Centralize definition of integer limits.

On Mon, Mar 30, 2015 at 7:48 PM, Andres Freund and...@anarazel.de wrote: Hi, On 2015-03-30 14:01:25 +0900, Michael Paquier wrote: On Thu, Mar 26, 2015 at 6:49 AM, Andres Freund and...@anarazel.de wrote: Centralize definition of integer limits. Several submitted and even committed

Re: [COMMITTERS] pgsql: Centralize definition of integer limits.

On Thu, Mar 26, 2015 at 6:49 AM, Andres Freund and...@anarazel.de wrote: Centralize definition of integer limits. Several submitted and even committed patches have run into the problem that C89, our baseline, does not provide minimum/maximum values for various integer datatypes. C99's

Re: [COMMITTERS] pgsql: Centralize definition of integer limits.

On Mon, Mar 30, 2015 at 2:01 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Mar 26, 2015 at 6:49 AM, Andres Freund and...@anarazel.de wrote: Centralize definition of integer limits. Several submitted and even committed patches have run into the problem that C89, our

Re: [COMMITTERS] pgsql: Merge the various forms of transaction commit abort records.

On Mon, Mar 16, 2015 at 1:38 AM, Andres Freund and...@anarazel.de wrote: Merge the various forms of transaction commit abort records. Coverity is complaining about the following block of code: + xact_info = XLogRecGetInfo(record) XLOG_XACT_COMMIT; + + if (xact_info !=

Re: [COMMITTERS] pgsql: vacuumdb: enable parallel mode

On Sat, Jan 24, 2015 at 3:06 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: vacuumdb: enable parallel mode This mode allows vacuumdb to open several server connections to vacuum or analyze several tables simultaneously. Coverity is still complaining about this block of code where the

  1   2   >