On Mon, Nov 13, 2017 at 12:41 PM, amul sul wrote:
> On Sun, Nov 12, 2017 at 3:01 AM, Andreas Seltenreich
> wrote:
>> Robert Haas writes:
>>
>>> Add hash partitioning.
>>
>> sqlsmith triggers coredumps calling satisfies_hash_partition().
>> ISTM this function is lacking argument validation. Exam
On Sun, Nov 12, 2017 at 3:01 AM, Andreas Seltenreich wrote:
> Robert Haas writes:
>
>> Add hash partitioning.
>
> sqlsmith triggers coredumps calling satisfies_hash_partition().
> ISTM this function is lacking argument validation. Example:
>
Thanks for the bug report. Please find attached patch
Add post-2010 ecpg tests to checktcp.
This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it. To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line. Back-patch to 9.3 (all sup
Add post-2010 ecpg tests to checktcp.
This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it. To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line. Back-patch to 9.3 (all sup
Add post-2010 ecpg tests to checktcp.
This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it. To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line. Back-patch to 9.3 (all sup
Add post-2010 ecpg tests to checktcp.
This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it. To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line. Back-patch to 9.3 (all sup
Add post-2010 ecpg tests to checktcp.
This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it. To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line. Back-patch to 9.3 (all sup
Add post-2010 ecpg tests to checktcp.
This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it. To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line. Back-patch to 9.3 (all sup
Robert Haas writes:
> Add hash partitioning.
sqlsmith triggers coredumps calling satisfies_hash_partition().
ISTM this function is lacking argument validation. Example:
,
| PostgreSQL stand-alone backend 11devel
| backend> select satisfies_hash_partition('pg_class'::regclass,null,null,null)
Add some const decorations to prototypes
Reviewed-by: Fabien COELHO
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/0e1539ba0d0a43de06c6e0572a565e73b9472538
Modified Files
--
contrib/dict_xsyn/dict_xsyn.c | 2 +-
contrib/fuzzystrma
Add -wnet to SP invocations
This causes a warning when accidentally backpatching an XML-style
empty-element tag like .
Branch
--
REL9_5_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/2d7e35b3a931fcef48a1faf0a0fb04f3db57cbde
Modified Files
--
doc/src/sgml/Makefil
Add -wnet to SP invocations
This causes a warning when accidentally backpatching an XML-style
empty-element tag like .
Branch
--
REL9_6_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/0abc7cdb875e63ff110f292eb666078d7abd1e90
Modified Files
--
doc/src/sgml/Makefil
Add -wnet to SP invocations
This causes a warning when accidentally backpatching an XML-style
empty-element tag like .
Branch
--
REL9_4_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/18d431bda22f1b0f9ad758338a282705ab6b21b5
Modified Files
--
doc/src/sgml/Makefil
Add -wnet to SP invocations
This causes a warning when accidentally backpatching an XML-style
empty-element tag like .
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/9a8d3c4eeaf34966056a41a263c6e2ca4d5e4012
Modified Files
--
doc/src/sgml/Makefile | 3 +
Add -wnet to SP invocations
This causes a warning when accidentally backpatching an XML-style
empty-element tag like .
Branch
--
REL9_3_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/89afa724c6384b8f64f115f7b866c8625e158f22
Modified Files
--
doc/src/sgml/Makefil
Add -wnet to SP invocations
This causes a warning when accidentally backpatching an XML-style
empty-element tag like .
Branch
--
REL_10_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/a11e5a67d9a61bddb4ba7eec77e6671a0437f9fb
Modified Files
--
doc/src/sgml/Makefil
Add hash partitioning.
Hash partitioning is useful when you want to partition a growing data
set evenly. This can be useful to keep table sizes reasonable, which
makes maintenance operations such as VACUUM faster, or to enable
partition-wise join.
At present, we still depend on constraint exclus
Add tests for json{b}_populate_recordset() crash case.
The problem reported as CVE-2017-15098 was already resolved in HEAD by
commit 37a795a60, but let's add the relevant test cases anyway.
Michael Paquier and Tom Lane, per a report from David Rowley.
Security: CVE-2017-15098
Branch
--
mast
Add a temp-install prerequisite to "check"-like targets not having one.
Makefile.global assigns this prerequisite to every target named "check",
but similar targets must mention it explicitly. Affected targets
failed, tested $PATH binaries, or tested a stale temporary installation.
The src/test/m
Add a temp-install prerequisite to "check"-like targets not having one.
Makefile.global assigns this prerequisite to every target named "check",
but similar targets must mention it explicitly. Affected targets
failed, tested $PATH binaries, or tested a stale temporary installation.
The src/test/m
Add a temp-install prerequisite to "check"-like targets not having one.
Makefile.global assigns this prerequisite to every target named "check",
but similar targets must mention it explicitly. Affected targets
failed, tested $PATH binaries, or tested a stale temporary installation.
The src/test/m
Add a temp-install prerequisite to "check"-like targets not having one.
Makefile.global assigns this prerequisite to every target named "check",
but similar targets must mention it explicitly. Affected targets
failed, tested $PATH binaries, or tested a stale temporary installation.
The src/test/m
Add sanity check for pg_proc.provariadic
Check that the values from pg_proc.h match what ProcedureCreate would
have done.
Robert Haas and Amul Sul
Discussion:
http://postgr.es/m/ca+tgmoz_ugxfq5ygeddmdusj4j_vx7nfnjc6mfy6bgoj3qz...@mail.gmail.com
Branch
--
master
Details
---
https://git
Add hash_combine64.
Extracted from a larger patch by Amul Sul, with some comment additions
by me.
Discussion: http://postgr.es/m/[email protected]
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/b7f3eb31405f1dbbf086e5a8f88569a6dc8515
Add table_constraint synopsis to ALTER TABLE documentation.
This is already present in the CREATE TABLE documentation, but it's
nicer not to have to refer to CREATE TABLE to find out the syntax
for ALTER TABLE.
Lætitia Avrot
Branch
--
master
Details
---
https://git.postgresql.org/pg/com
Add a utility function to extract variadic function arguments
This is epecially useful in the case or "VARIADIC ANY" functions. The
caller can get the artguments and types regardless of whether or not and
explicit VARIADIC array argument has been used. The function also
provides an option to conve
Add a utility function to extract variadic function arguments
This is epecially useful in the case or "VARIADIC ANY" functions. The
caller can get the artguments and types regardless of whether or not and
explicit VARIADIC array argument has been used. The function also
provides an option to conve
Add a utility function to extract variadic function arguments
This is epecially useful in the case or "VARIADIC ANY" functions. The
caller can get the artguments and types regardless of whether or not and
explicit VARIADIC array argument has been used. The function also
provides an option to conve
Add a utility function to extract variadic function arguments
This is epecially useful in the case or "VARIADIC ANY" functions. The
caller can get the artguments and types regardless of whether or not and
explicit VARIADIC array argument has been used. The function also
provides an option to conve
Add a utility function to extract variadic function arguments
This is epecially useful in the case or "VARIADIC ANY" functions. The
caller can get the artguments and types regardless of whether or not and
explicit VARIADIC array argument has been used. The function also
provides an option to conve
Add more tests for reloptions
This is preparation for a future patch to extensively change how
reloptions work.
Author: Nikolay Shaplov
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/2615372.orqtEn8VGB@x200m
Branch
--
master
Details
---
https://git.postgresql.org/pg/commit
Add missing options to pg_regress help() output
A few command line options accepted by pg_regress were not being output
by help(), including --help itself. Add that one, as well as --version
and --bindir, and the corresponding short options for the first two.
We could consider this for backpatchi
On 2017-10-13 18:32:08 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Add pg_noinline macro to c.h.
>
> I think you want this to be parenthesized so that pgindent doesn't
> go nuts when you use it. At least, that was the reason why
> pg_attribute_noreturn() has parens. Even if the current v
Andres Freund writes:
> Add pg_noinline macro to c.h.
I think you want this to be parenthesized so that pgindent doesn't
go nuts when you use it. At least, that was the reason why
pg_attribute_noreturn() has parens. Even if the current version
of pgindent doesn't have that problem, I would argu
Add pg_noinline macro to c.h.
Forcing a function not to be inlined can be useful if it's the
slow-path of a performance critical function, or should be visible in
profiles to allow for proper cost attribution.
Author: Andres Freund
Discussion:
https://postgr.es/m/20170914061207.zxotvyopetm7l...@
Andres Freund writes:
> But it's easy to do so in configure, and then have a separate definition
> in pg_config.h.win32. Done so in the attached commit. It's slightly ugly
> to have two definitions of restrict in pg_config.h.in, but whatever.
WFM.
regards, tom lane
--
Hi,
On 2017-10-12 11:03:34 -0700, Andres Freund wrote:
> On 2017-10-12 13:55:07 -0400, Tom Lane wrote:
> > Or, if you insist on having it, we're going to have to go the pg_restrict
> > route. I don't see why that means duplicating any configure logic: on
> > non-Windows we can use the autoconf pr
Hi,
On 2017-10-12 13:55:07 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2017-10-12 11:30:00 -0400, Tom Lane wrote:
> >> I don't actually see why you need a #define at all --- "restrict" is the
> >> standard spelling of the keyword no?
>
> > It is, but a lot of compilers name it differe
Andres Freund writes:
> On 2017-10-12 11:30:00 -0400, Tom Lane wrote:
>> I don't actually see why you need a #define at all --- "restrict" is the
>> standard spelling of the keyword no?
> It is, but a lot of compilers name it differently, e.g. __restrict in
> the case of msvc.
It's 2017 and they
On 2017-10-12 11:30:00 -0400, Tom Lane wrote:
> Andres Freund writes:
> > I've temporarily silenced that error by moving the stdlib.h include
> > before the definition of restrict, but that seems fairly fragile. I
> > primarily wanted to see whether there's other problems. At least thrips
> > is
I wrote:
> On reflection, let's just go with the solution of building libpgport_lib.a
> with the right flags (fPIC + threading) and leave libpgport.a alone.
> That way we don't need a debate about whether there's an efficiency
> cost worth worrying about.
I looked into this and got discouraged aft
Andres Freund writes:
> I've temporarily silenced that error by moving the stdlib.h include
> before the definition of restrict, but that seems fairly fragile. I
> primarily wanted to see whether there's other problems. At least thrips
> is is now happy.
> I see a number of options to continue:
On 2017-10-11 21:59:53 -0700, Andres Freund wrote:
> That fixed that problem I think. But unfortunately since then another
> problem has been reported by some other animals, all with older msvc
> versions afaict (thrips - vs 2012, bowerbird - vs 2012).
Correction, thrips is vs 2010, not 2012.
--
On 2017-10-11 17:13:20 -0700, Andres Freund wrote:
> Hi,
>
> On 2017-10-11 23:11:15 +, Andres Freund wrote:
> > Add configure infrastructure to detect support for C99's restrict.
> >
> > Will be used in later commits improving performance for a few key
> > routines where information about ali
Hi,
On 2017-10-11 23:11:15 +, Andres Freund wrote:
> Add configure infrastructure to detect support for C99's restrict.
>
> Will be used in later commits improving performance for a few key
> routines where information about aliasing allows for significantly
> better code generation.
>
> Thi
Add more efficient functions to pqformat API.
There's three prongs to achieve greater efficiency here:
1) Allow reusing a stringbuffer across pq_beginmessage/endmessage,
with the new pq_beginmessage_reuse/endmessage_reuse. This can be
beneficial both because it avoids allocating the initial
Add configure infrastructure to detect support for C99's restrict.
Will be used in later commits improving performance for a few key
routines where information about aliasing allows for significantly
better code generation.
This allows to use the C99 'restrict' keyword without breaking C89, or
fo
Andres Freund writes:
> On 2017-10-11 11:58:58 -0400, Tom Lane wrote:
>> I agree the PITA factor of the current approach keeps increasing.
>> It sounds a bit silly to build libpgport three ways, but maybe
>> we should just do that.
> We already kinda are, just by copying things around ;)
Yeah.
Hi,
On 2017-10-11 11:58:58 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Phew. This is a bit a sad state of affairs. The separate libpq logic for
> > getting pgport is presumably because of possibly different threading
> > flags and then because of the appropriate compiler/linker flags for a
Andres Freund writes:
> Phew. This is a bit a sad state of affairs. The separate libpq logic for
> getting pgport is presumably because of possibly different threading
> flags and then because of the appropriate compiler/linker flags for a
> shared library?
I don't see why threading would matter,
On 2017-10-11 15:28:16 +, Tom Lane wrote:
> Add port/strnlen support to libpq and ecpg Makefiles.
>
> In the wake of fffd651e8, any makefile that pulls in snprintf.c
> from src/port/ needs to be prepared to pull in strnlen.c as well.
> Per buildfarm.
Thanks.
> Modified Files
> -
Add port/strnlen support to libpq and ecpg Makefiles.
In the wake of fffd651e8, any makefile that pulls in snprintf.c
from src/port/ needs to be prepared to pull in strnlen.c as well.
Per buildfarm.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/46912d9b1504cfaede1
On 2017-10-10 18:10:15 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Here's a fix. Not quite sure whether we really need the
> > HAVE_DECL_STRNLEN test, added it for symmetry.
>
> LGTM.
Thanks for checking.
> I think the DECL test is a good idea; the system definition
> might be a macro o
Andres Freund writes:
> Here's a fix. Not quite sure whether we really need the
> HAVE_DECL_STRNLEN test, added it for symmetry.
LGTM. I think the DECL test is a good idea; the system definition
might be a macro or otherwise weird, in which case we'd cause problems
if we write an extern definiti
On 2017-10-10 17:34:17 -0400, Andrew Dunstan wrote:
> This test is governed by the test at line 946 of configure.in. You need
> to move it somewhere else.
Yea, sorry for the noise :(.
Greetings,
Andres Freund
--
Sent via pgsql-committers mailing list ([email protected])
To make
On 2017-10-10 13:53:15 -0700, Andres Freund wrote:
> On 2017-10-10 16:51:39 -0400, Tom Lane wrote:
> > Andres Freund writes:
> > > As far as I can tell it's still somehow using a configure from before
> > > the last commits:
> >
> > No, it's pilot error. The AC_CHECK_FUNCS call you added strnlen
On 10/10/2017 03:48 PM, Andres Freund wrote:
> On 2017-10-09 23:33:36 -0400, Andrew Dunstan wrote:
>>
>> On 10/09/2017 07:15 PM, Andres Freund wrote:
>>> Hi Andrew,
>>>
>>> On 2017-10-09 22:22:04 +, Andres Freund wrote:
Add pg_strnlen() a portable implementation of strlen.
As t
On 2017-10-10 16:51:39 -0400, Tom Lane wrote:
> Andres Freund writes:
> > As far as I can tell it's still somehow using a configure from before
> > the last commits:
>
> No, it's pilot error. The AC_CHECK_FUNCS call you added strnlen to
> is only executed if
> AS_IF([test "$enable_thread_safety"
Andres Freund writes:
> As far as I can tell it's still somehow using a configure from before
> the last commits:
No, it's pilot error. The AC_CHECK_FUNCS call you added strnlen to
is only executed if
AS_IF([test "$enable_thread_safety" = yes -a "$PORTNAME" != "win32"],
A better place would be
On 2017-10-10 16:37:04 -0400, Tom Lane wrote:
> Andres Freund writes:
> > (there's definitely fixes to be made to where strnlen's replacement is
> > located, but regardless, this needs to be fixed too)
>
> Given that strnlen is standardized by POSIX, and has been for nigh a
> decade, I think it'd
Andres Freund writes:
> (there's definitely fixes to be made to where strnlen's replacement is
> located, but regardless, this needs to be fixed too)
Given that strnlen is standardized by POSIX, and has been for nigh a
decade, I think it'd be all right for us to treat it as a straight
port replac
On 2017-10-09 23:33:36 -0400, Andrew Dunstan wrote:
>
>
> On 10/09/2017 07:15 PM, Andres Freund wrote:
> > Hi Andrew,
> >
> > On 2017-10-09 22:22:04 +, Andres Freund wrote:
> >> Add pg_strnlen() a portable implementation of strlen.
> >>
> >> As the OS version is likely going to be more optimi
Add missing clean step to src/test/modules/brin/Makefile.
I noticed the tmp_check subdirectory wasn't getting cleaned up
after a check-world run. Apparently pgxs.mk will only do this
for you if you've defined REGRESS. The only other src/test/modules
Makefile that does not set that is snapshot_to
Add missing clean step to src/test/modules/brin/Makefile.
I noticed the tmp_check subdirectory wasn't getting cleaned up
after a check-world run. Apparently pgxs.mk will only do this
for you if you've defined REGRESS. The only other src/test/modules
Makefile that does not set that is snapshot_to
Andres Freund writes:
> I think the current split between common and port isn't particularly
> meaningful. But as long as we have it, this probably belongs more in
> port than in common.
Well, port is supposed to be for stuff that we expect to find in libc
on common platforms, but is missing some
On 2017-10-10 00:25:52 -0400, Tom Lane wrote:
> Andrew Dunstan writes:
> > frogmouth is using some code not yet released that makes the config
> > cache persistent. I just identified and fixed a stupid bug in the code
> > that obsoletes the cache, and I have removed frogmouth's cache file and
> >
Andrew Dunstan writes:
> frogmouth is using some code not yet released that makes the config
> cache persistent. I just identified and fixed a stupid bug in the code
> that obsoletes the cache, and I have removed frogmouth's cache file and
> set it running again, so we'll see if that fixes things.
On 10/09/2017 07:15 PM, Andres Freund wrote:
> Hi Andrew,
>
> On 2017-10-09 22:22:04 +, Andres Freund wrote:
>> Add pg_strnlen() a portable implementation of strlen.
>>
>> As the OS version is likely going to be more optimized, fall back to
>> it if available, as detected by configure.
> I'm
Hi Andrew,
On 2017-10-09 22:22:04 +, Andres Freund wrote:
> Add pg_strnlen() a portable implementation of strlen.
>
> As the OS version is likely going to be more optimized, fall back to
> it if available, as detected by configure.
I'm a bit confused, frogmouth
https://buildfarm.postgresql.o
Add pg_strnlen() a portable implementation of strlen.
As the OS version is likely going to be more optimized, fall back to
it if available, as detected by configure.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/8a241792f968ed5be6cf4d41e32c0d264f6c0c65
Modified F
On 09/30/2017 10:32 PM, Andres Freund wrote:
>> Haven't tested on MSVC but with this patch it passes on jacana (mingw).
> Yay! Thanks for testing.
>
I have now tested on bowerbird (MSVC) and it passes. This suggests that
we can run tests there in cases where we can use IPC::Run's finish()
inst
Add list of acknowledgments to release notes
This contains all individuals mentioned in the commit messages during
PostgreSQL 10 development.
current through babf18579455e85269ad75e1ddb03f34138f77b6
Discussion:
https://www.postgresql.org/message-id/flat/54ad0e42-770e-dfe1-123e-bce9361ad452%402n
Add list of acknowledgments to release notes
This contains all individuals mentioned in the commit messages during
PostgreSQL 10 development.
current through babf18579455e85269ad75e1ddb03f34138f77b6
Discussion:
https://www.postgresql.org/message-id/flat/54ad0e42-770e-dfe1-123e-bce9361ad452%402n
Hi,
On 2017-09-30 22:28:39 -0400, Andrew Dunstan wrote:
> >> But even after fixing that, there unfortunately is:
> >>
> >> static void
> >> set_sig(char *signame)
> >> {
> >> …
> >> #if 0
> >>/* probably should NOT provide SIGKILL */
> >>else if (strcmp(signame, "KILL") == 0)
> >>
On 09/30/2017 06:44 PM, Andres Freund wrote:
> On 2017-09-30 15:27:12 -0700, Andres Freund wrote:
>> On 2017-09-30 18:21:33 -0400, Andrew Dunstan wrote:
>>> [re-adding commiters which I inadvertently left off]
>>>
>>>
>>> On 09/30/2017 06:10 PM, Andres Freund wrote:
> I was just looking
On 2017-09-30 15:27:12 -0700, Andres Freund wrote:
> On 2017-09-30 18:21:33 -0400, Andrew Dunstan wrote:
> >
> > [re-adding commiters which I inadvertently left off]
> >
> >
> > On 09/30/2017 06:10 PM, Andres Freund wrote:
> > >
> > >
> > >> I was just looking at this. Why aren't we using "pg_ct
On 2017-09-30 18:21:33 -0400, Andrew Dunstan wrote:
>
> [re-adding commiters which I inadvertently left off]
>
>
> On 09/30/2017 06:10 PM, Andres Freund wrote:
> >
> >
> >> I was just looking at this. Why aren't we using "pg_ctl kill" to
> >> terminate the backend? That's supposed to be portable
[re-adding commiters which I inadvertently left off]
On 09/30/2017 06:10 PM, Andres Freund wrote:
>
>
>> I was just looking at this. Why aren't we using "pg_ctl kill" to
>> terminate the backend? That's supposed to be portable.
> Because pg_ctl can't do that for any process but postmaster, no? T
Add background worker type
Add bgw_type field to background worker structure. It is intended to be
set to the same value for all workers of the same type, so they can be
grouped in pg_stat_activity, for example.
The backend_type column in pg_stat_activity now shows bgw_type for a
background work
Add lcov --initial
By just running lcov on the produced .gcda data files, we don't account
for source files that are not touched by tests at all. To fix that, run
lcov --initial to create a base line info file with all zero counters,
and merge that with the actual counters when creating the final
Add PostgreSQL version to coverage output
Also make overriding the title easier. That helps telling where the
report came from and labeling different variants of a report.
Reviewed-by: Michael Paquier
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/d2773f9bcd980c
Andres Freund writes:
> If the buildfarm doesn't complain about the use of IPC::Run's timeout
> functionality, we should probably patch that into the other use of
> IPC::Run as well, but especially into the other user of the pump() until
> ... scheme.
jacana hasn't passed this regression test yet
Add some more pg_receivewal tests
Add some more tests for the --create-slot and --drop-slot options,
verifying that the right kind of slot was created and that the slot was
dropped. While working on an unrelated patch for pg_basebackup, some of
this was temporarily broken without any tests notici
Add inline murmurhash32(uint32) function.
The function already existed in tidbitmap.c but more users requiring
fast hashing of 32bit ints are coming up.
Author: Andres Freund
Discussion:
https://postgr.es/m/[email protected]
Branch
--
master
Details
---
Peter Eisentraut writes:
> Add basic TAP test setup for pg_upgrade
> The plan is to convert the current pg_upgrade test to the TAP
> framework. This commit just puts a basic TAP test in place so that we
> can see how the build farm behaves, since the build farm client has some
> special knowledge
Add basic TAP test setup for pg_upgrade
The plan is to convert the current pg_upgrade test to the TAP
framework. This commit just puts a basic TAP test in place so that we
can see how the build farm behaves, since the build farm client has some
special knowledge of the pg_upgrade tests.
Author:
On 2017-09-19 09:58:26 -0700, Andres Freund wrote:
>
>
> On September 19, 2017 9:53:28 AM PDT, Tom Lane wrote:
> >Well, please fix it ASAP, if you don't want to take it out pending
> >the fixes.
>
> Will as soon as I finished my morning coffee. Uncaffeinated, which my phone
> fittingly autocor
On September 19, 2017 9:53:28 AM PDT, Tom Lane wrote:
>Well, please fix it ASAP, if you don't want to take it out pending
>the fixes.
Will as soon as I finished my morning coffee. Uncaffeinated, which my phone
fittingly autocorrects to unvaccinated, commits aren't a good idea.
Andres
--
Sent
Andres Freund writes:
> On 2017-09-19 12:13:54 -0400, Tom Lane wrote:
>> IOW, the "$monitor" instance of psql did not complete making its
>> connection until after the crash/restart cycle had occurred.
> That'd be easy enough to fix...
> Just something like
> $monitor_stdin .= q[
> SELECT $$am-
Hi,
On 2017-09-19 12:13:54 -0400, Tom Lane wrote:
> IOW, the "$monitor" instance of psql did not complete making its
> connection until after the crash/restart cycle had occurred.
That'd be easy enough to fix...
Just something like
$monitor_stdin .= q[
SELECT $$am-i-up$$;
];
$monitor->pump unti
I discovered that prairiedog has been hung up for many hours in the
013_crash_restart.pl. It looks to me like the explanation is that
the test has a race condition, because what I find in the postmaster
log is
2017-09-19 00:31:48.194 EDT [27839] [unknown] LOG: connection received:
host=[local]
Add citext_pattern_ops for citext contrib module
This is similar to text_pattern_ops.
Alexey Chernyshov, reviewed by Jacob Champion.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/f2464997644c64b5dec93ab3c08305f48bfe14f1
Modified Files
--
contrib/cite
On September 18, 2017 8:55:35 PM PDT, Tom Lane wrote:
>Andres Freund writes:
>> Add test for postmaster crash restarts.
>
>Hm, calliphoridae doesn't like this.
Yea. Not clear to me why yet. The machine ran a number of instances with nearly
the same config successfully. Can't imagine that copy
Andres Freund writes:
> Add test for postmaster crash restarts.
Hm, calliphoridae doesn't like this.
regards, tom lane
--
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/p
Add test for postmaster crash restarts.
Given that I managed to break this... We probably should extend the
tests to also cover other sub-processes dying, but that's something
for later.
Author: Andres Freund
Discussion:
https://postgr.es/m/[email protected]
Bra
On Sat, Sep 16, 2017 at 7:07 AM, Tom Lane wrote:
> Andres Freund writes:
>> On 2017-09-15 10:33:37 -0400, Tom Lane wrote:
>>> I don't much like your proposed comment; the only way that this code
>>> is even approximately correct is if we're exiting the process and
>>> will never touch the RecordC
On 2017-09-15 15:07:14 -0400, Tom Lane wrote:
> It's moot as long as we're not reusing workers, anyway: nothing is
> going to touch any of the record-tupdesc data before process exit.
Right - I'm ok with the end-result, I was just a bit confused about the
justification, because neither before nor
Andres Freund writes:
> On 2017-09-15 10:33:37 -0400, Tom Lane wrote:
>> I don't much like your proposed comment; the only way that this code
>> is even approximately correct is if we're exiting the process and
>> will never touch the RecordCacheArray again. (Otherwise, it risks
>> reassigning a
On 2017-09-15 10:33:37 -0400, Tom Lane wrote:
> Thomas Munro writes:
> > Yeah. The regress tests in d36f7efb39e1b9613193b2e12717dbe2418ddae5
> > tested this stuff in parallel mode, but only a happy case to
> > demonstrate blessed RECORD types travelling through tqueue.c correctly
> > before and a
On 2017-09-15 00:59:35 -0400, Tom Lane wrote:
> Thomas Munro writes:
> > Rebased on your fix.
>
> Ah, yet a different issue :-(. Pushed that too.
Thanks for pushing the fixes - I'd waited till the first few animals
came back green, and then went to somebody's birthday
celebrations. Didn't wait
1 - 100 of 4266 matches
Mail list logo
