[COMMITTERS] pgsql: Improve log messages related to tablespace_map file

2015-09-15 Thread Fujii Masao
Improve log messages related to tablespace_map file This patch changes the log message which is logged when the server successfully renames backup_label file to *.old but fails to rename tablespace_map file during the shutdown. Previously the WARNING message "online backup mode was not canceled" w

[COMMITTERS] pgsql: Improve log messages related to tablespace_map file

2015-09-15 Thread Fujii Masao
Improve log messages related to tablespace_map file This patch changes the log message which is logged when the server successfully renames backup_label file to *.old but fails to rename tablespace_map file during the shutdown. Previously the WARNING message "online backup mode was not canceled" w

[COMMITTERS] pgsql: Fix comment regarding the meaning of infinity for timeline histo

2015-09-15 Thread Fujii Masao
Fix comment regarding the meaning of infinity for timeline history entry Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/05ec71eea265622e1a311c9de3d3b186924e736a Modified Files -- src/include/access/timeline.h |3 ++- 1 file changed, 2

[COMMITTERS] pgsql: Add POLICY to COMMENT documentation

2015-09-15 Thread Stephen Frost
Add POLICY to COMMENT documentation COMMENT supports POLICY but the documentation hadn't caught up with that fact. Patch by Charles Clavadetscher Back-patch to 9.5 where POLICY was added. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/225f539bd00ad58bac41d8

[COMMITTERS] pgsql: Add POLICY to COMMENT documentation

2015-09-15 Thread Stephen Frost
Add POLICY to COMMENT documentation COMMENT supports POLICY but the documentation hadn't caught up with that fact. Patch by Charles Clavadetscher Back-patch to 9.5 where POLICY was added. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6820094d1ad37429f910cf46e9f37

[COMMITTERS] pgsql: Revert "Fix an O(N^2) problem in foreign key references".

2015-09-15 Thread Tom Lane
Revert "Fix an O(N^2) problem in foreign key references". Commit 5ddc72887a012f6a8b85707ef27d85c274faf53d does not actually work because it will happily blow away ri_constraint_cache entries that are in active use in outer call levels. In any case, it's a very ugly, brute-force solution to the pr

[COMMITTERS] pgsql: Revert "Fix an O(N^2) problem in foreign key references".

2015-09-15 Thread Tom Lane
Revert "Fix an O(N^2) problem in foreign key references". Commit 5ddc72887a012f6a8b85707ef27d85c274faf53d does not actually work because it will happily blow away ri_constraint_cache entries that are in active use in outer call levels. In any case, it's a very ugly, brute-force solution to the pr

[COMMITTERS] pgsql: Revert "Fix an O(N^2) problem in foreign key references".

2015-09-15 Thread Tom Lane
Revert "Fix an O(N^2) problem in foreign key references". Commit 5ddc72887a012f6a8b85707ef27d85c274faf53d does not actually work because it will happily blow away ri_constraint_cache entries that are in active use in outer call levels. In any case, it's a very ugly, brute-force solution to the pr

[COMMITTERS] pgsql: Revert "Fix an O(N^2) problem in foreign key references".

2015-09-15 Thread Tom Lane
Revert "Fix an O(N^2) problem in foreign key references". Commit 5ddc72887a012f6a8b85707ef27d85c274faf53d does not actually work because it will happily blow away ri_constraint_cache entries that are in active use in outer call levels. In any case, it's a very ugly, brute-force solution to the pr

[COMMITTERS] pgsql: Fix whitespace

2015-09-15 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/000a21336b8e218deb856f73dc8972073cb8a649 Modified Files -- src/bin/pg_dump/dumputils.h |2 +- src/bin/pg_dump/pg_dump.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Se

[COMMITTERS] pgsql: Enforce ALL/SELECT policies in RETURNING for RLS

2015-09-15 Thread Stephen Frost
Enforce ALL/SELECT policies in RETURNING for RLS For the UPDATE/DELETE RETURNING case, filter the records which are not visible to the user through ALL or SELECT policies from those considered for the UPDATE or DELETE. This is similar to how the GRANT system works, which prevents RETURNING unless

[COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Stephen Frost
RLS refactoring This refactors rewrite/rowsecurity.c to simplify the handling of the default deny case (reducing the number of places where we check for and add the default deny policy from three to one) by splitting up the retrival of the policies from the application of them. This also allowed

[COMMITTERS] pgsql: Enforce ALL/SELECT policies in RETURNING for RLS

2015-09-15 Thread Stephen Frost
Enforce ALL/SELECT policies in RETURNING for RLS For the UPDATE/DELETE RETURNING case, filter the records which are not visible to the user through ALL or SELECT policies from those considered for the UPDATE or DELETE. This is similar to how the GRANT system works, which prevents RETURNING unless

[COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Stephen Frost
RLS refactoring This refactors rewrite/rowsecurity.c to simplify the handling of the default deny case (reducing the number of places where we check for and add the default deny policy from three to one) by splitting up the retrival of the policies from the application of them. This also allowed

Re: [COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Tom Lane
Stephen Frost writes: > RLS refactoring It looks to me like this changed the representation of stored rules, so it should have included a catversion bump. This is particularly relevant to the 9.5 branch where people already have alpha installations. regards, tom lane -

Re: [COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Stephen Frost
* Tom Lane ([email protected]) wrote: > Stephen Frost writes: > > RLS refactoring > > It looks to me like this changed the representation of stored rules, so it > should have included a catversion bump. This is particularly relevant to > the 9.5 branch where people already have alpha installati

Re: [COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Alvaro Herrera
Stephen Frost wrote: > * Tom Lane ([email protected]) wrote: > > Stephen Frost writes: > > > > It looks to me like this changed the representation of stored rules, so it > > should have included a catversion bump. This is particularly relevant to > > the 9.5 branch where people already have alp

Re: [COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Tom Lane
Stephen Frost writes: > * Tom Lane ([email protected]) wrote: >> It looks to me like this changed the representation of stored rules, so it >> should have included a catversion bump. This is particularly relevant to >> the 9.5 branch where people already have alpha installations. > I had consid

Re: [COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Stephen Frost
* Tom Lane ([email protected]) wrote: > Stephen Frost writes: > > * Tom Lane ([email protected]) wrote: > >> It looks to me like this changed the representation of stored rules, so it > >> should have included a catversion bump. This is particularly relevant to > >> the 9.5 branch where people

Re: [COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Tom Lane
Alvaro Herrera writes: > Stephen Frost wrote: >> The WithCheckOption node which was changed doesn't ever end up in the >> catalog, I don't believe; certainly not in pg_policy which just stores >> the expressions which come from transformWhereClause, which haven't >> changed. > Uhm, so why is it i

Re: [COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Stephen Frost
* Tom Lane ([email protected]) wrote: > Alvaro Herrera writes: > > Stephen Frost wrote: > >> The WithCheckOption node which was changed doesn't ever end up in the > >> catalog, I don't believe; certainly not in pg_policy which just stores > >> the expressions which come from transformWhereClause,

Re: [COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Tom Lane
Stephen Frost writes: > Agreed. I will see about improving on that situation with at least > documentation changes. If we want to remove it completely then we'd > need to bump catversion.. Not against doing that if we want to though. > Might be better that way. readfuncs.c doesn't actually sto

Re: [COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Andres Freund
On 2015-09-15 19:16:06 -0400, Tom Lane wrote: > readfuncs.c doesn't actually stop to verify that the field name in stored > rules is what it expects. This reminds me: Is there a reason for that? ISTM that adding checks for the field names would make error messages about borked stored trees much ea

Re: [COMMITTERS] pgsql: RLS refactoring

2015-09-15 Thread Tom Lane
Andres Freund writes: > On 2015-09-15 19:16:06 -0400, Tom Lane wrote: >> readfuncs.c doesn't actually stop to verify that the field name in stored >> rules is what it expects. > This reminds me: Is there a reason for that? ISTM that adding checks for > the field names would make error messages ab

[COMMITTERS] pgsql: Review program help output for wording and formatting

2015-09-15 Thread Peter Eisentraut
Review program help output for wording and formatting Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5878a377ba47a39d8d3ecc1240986916eb9dbaf5 Modified Files -- src/bin/pg_basebackup/pg_receivexlog.c |2 +- src/bin/pg_basebackup/pg_recvlogical.c |

[COMMITTERS] pgsql: Review program help output for wording and formatting

2015-09-15 Thread Peter Eisentraut
Review program help output for wording and formatting Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ea00ff5f1058d2ede0b3ddda47b8713f11a6832a Modified Files -- src/bin/pg_basebackup/pg_receivexlog.c |2 +- src/bin/pg_basebackup/pg_recvlogical.