pplying the attached to make those three "restartpoint" to
keep the docs consistent?
--
Daniel Gustafsson
restartpoint.diff
Description: Binary data
pen
files each server subprocess is allowed to have simultaneously;"? That being
said, your suggestion is better so I'll go with that.
I will push the patch with the above changes a bit later today.
--
Daniel Gustafsson
g changes and a stab at commit message that I
think we should go ahead with.
--
Daniel Gustafsson
v3-0001-doc-Assorted-documentation-improvements.patch
Description: Binary data
bsite team.
That being said, AFAICT there are no LLM providers who have publicly stated
that they are using this proposed standard at all, and the author has not
submitted it to IETF for a formal review in the RFC process, so it doesn't seem
all that promising.
--
Daniel Gustafsson
s?
>
> I agree that it may seem redundant, I added "function" here for the sake of
> consistency with lines 1829/1830 (if applied to the master branch)
> where the documentation mentions "standard internal function library".
I hadn't seen that, but with that in mind I agree that being consistent is good
so I'll withdraw that comment.
--
Daniel Gustafsson
> On 7 Oct 2025, at 14:27, Shinya Kato wrote:
> Attached is a doc-only fix that adds a missing closing parenthesis in
> monitoring.sgml (pg_stat_progress_analyze: delay_time).
Thanks, will fix (with a backpatch to 18).
--
Daniel Gustafsson
report, and a very nice catch it is, turns out this duplication
has existed in every presskit since Postgres v11..
I've removed it from the v18 presskit but I opted to leave it in the older kits
as they exist as historic records at this point.
--
Daniel Gustafsson
L_18_STABLE branch.
As you mentioned downthread, this is also for master. Our workflow is to
always apply to master and backpatch from there.
--
Daniel Gustafsson
x entry for the term, as well as a glossary
> entry which explains how it is commonly used.
This seems like a good idea.
--
Daniel Gustafsson
> On 7 Aug 2025, at 18:23, Yaroslav Saburov wrote:
>
> Sorry, my mistake.
No problems at all, thanks for the report!
--
Daniel Gustafsson
s look a bit like a subsection heading given that there
is only one entry.
--
Daniel Gustafsson
> On 12 Jul 2025, at 18:41, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> Or perhaps ”values are separated by a tab character”?
>
> WFM
Thanks, I'll get this pushed once the freeze is over on REL_18_STABLE.
--
Daniel Gustafsson
> On 12 Jul 2025, at 18:23, Tom Lane wrote:
>
> Fujii Masao writes:
>>> On 2025/07/12 7:18, Daniel Gustafsson wrote:
>>> It should, fixed in v3.
>
>> LGTM. Thanks!
>
> I'm okay with this too. I find myself niggling a bit at the
> par
> On 11 Jul 2025, at 01:36, Fujii Masao wrote:
> Since the prcp column isn't specified, its value is NULL. So shouldn't
> the fourth field in the data line above be \N instead of 0.0?
It should, fixed in v3.
--
Daniel Gustafsson
v3-0001-doc-Add-example-file-for-COP
> On 5 Jul 2025, at 19:29, Tom Lane wrote:
>
> Fujii Masao writes:
>> On 2020/01/28 19:18, Daniel Gustafsson wrote:
>>> This is only mentioned as an example of another input method, with a link to
>>> the COPY page for more information. That being s
you propose to change, it's a
mish-mash of incorrect proposal and unexplained comment removals against a file
not present in our tree. Please make an actual patch against the docs you
propose to change for us to have something to consider.
--
Daniel Gustafsson
> On 24 Jun 2025, at 09:44, Michael Paquier wrote:
>
> On Tue, Jun 24, 2025 at 09:36:20AM +0200, Magnus Hagander wrote:
>> On Tue, Jun 24, 2025 at 9:20 AM Daniel Gustafsson wrote:
>>> Downloading what newbiedoc still ships shows no trace of docbook
>>> introdoc
> On 24 Jun 2025, at 07:37, Fujii Masao wrote:
> I've committed the proposed patch first. If we later agree to change
> this part as well, we can commit that separately.
What you committed is perfectly fine, thanks!
--
Daniel Gustafsson
pleasure. The
- http://newbiedoc.sourceforge.net/metadoc/docbook-guide.html";>
- NewbieDoc Docbook Guide is very helpful for beginners.
+ a complete O'Reilly book for your online reading pleasure.
The https://www.freebsd.org/docproj/";>
FreeBSD Documentation Project
orodin)
--
Daniel Gustafsson
1.1 support, which is a fair bit into the future).
--
Daniel Gustafsson
Going over the docs with a spellchecker now that v18 closed found a few typos
as per the attached. I'll apply that shortly unless objected to.
--
Daniel Gustafsson
v18_doc_typos.diff
Description: Binary data
ifferent. Should it not link to this instead? :
> https://www.postgresql.org/docs/current/logicaldecoding-explanation.html#LOGICALDECODING-REPLICATION-SLOTS
Agreed, that seems like the right change. Unless objected to I'll apply the
attached diff with the appropriate level of backpatching.
--
uoia 2000?
The attached fixes the above, with a link to the Stonebraker paper.
--
Daniel Gustafsson
404links.diff
Description: Binary data
a note should probably
> be added to the entry stating that it is correctly spelled.
Thanks for the report! I can see the confusion, but it is indeed correctly
spelled as the SQL standard defines it as END-EXEC. I'm not convinced we need
to add a footnote on it though.
--
Daniel Gustafsson
unable to set the before-rewrite url attribute
as the child in case there are no children before invoking the ulink template.
Maybe someone has better XSLT skills and can make it work?
--
Daniel Gustafsson
> On 18 Nov 2024, at 20:51, Bruce Momjian wrote:
>
> On Wed, Nov 6, 2024 at 03:58:18PM +0100, Daniel Gustafsson wrote:
>>> On 6 Nov 2024, at 15:51, Alvaro Herrera wrote:
>>>
>>> On 2024-Nov-06, Daniel Gustafsson wrote:
>>>
>>>> Com
ly tested) diff should fix that according to the currently
chosen colorscheme.
--
Daniel Gustafsson
id_link_bgcolor.diff
Description: Binary data
> On 6 Nov 2024, at 20:34, David Rowley wrote:
>
> On Thu, 7 Nov 2024 at 03:58, Daniel Gustafsson wrote:
>>
>>> On 6 Nov 2024, at 15:51, Alvaro Herrera wrote:
>>> Ah, but we kept the #? I thought it was going to be changed to ¶ ...
>>> was there any
> On 6 Nov 2024, at 15:51, Alvaro Herrera wrote:
>
> On 2024-Nov-06, Daniel Gustafsson wrote:
>
>> Committed, and with some help from Magnus, the docs site has been reloaded
>> with
>> the new CSS. Everything seems to behave as expected when testing in Firef
> On 6 Nov 2024, at 07:10, David Rowley wrote:
>
> On Wed, 30 Oct 2024 at 11:39, Daniel Gustafsson wrote:
>>
>>> On 29 Oct 2024, at 23:36, David Rowley wrote:
>>> Do you have access to make this change? I think it needs to go into
>>> https://www.
gweb commitbit so if you roll a patch for it I can take care of the
rest.
--
Daniel Gustafsson
> On 29 Oct 2024, at 12:31, David Rowley wrote:
>
> On Thu, 17 Oct 2024 at 20:20, Daniel Gustafsson wrote:
>> My main concern is that the relative positioning will push it off screen
>> with a
>> break on smaller viewports (like phones).
>
> I can recreate wha
don't know about regression test internals, I think
"extra" would be hard to interpret the meaning of. How about "unexpected"?
--
Daniel Gustafsson
> On 22 Oct 2024, at 10:12, PG Doc comments form wrote:
> The correct syntax for inserting data should read:
>
> INSERT INTO people (name, address) VALUES ('A', 'foo');
> INSERT INTO people (name, address) VALUES ('B', 'bar');
Nice catch, will fix.
--
Daniel Gustafsson
ion where it's rendered on top of the other content (to keep
it from adding vertical scroll) and using absolute positioning anchored on the
tag? That would require the h2 to use a position: attribute though.
--
Daniel Gustafsson
devel/reference-server.html
--
Daniel Gustafsson
> On 7 Oct 2024, at 11:33, jian he wrote:
>
> NAMES
> SET NAMES value is an alias for SET client_encoding TO value.
>
> it should be:
> SET NAMES 'value' is an alias for SET client_encoding TO value.
Good find, it indeed should. Fixed.
--
Daniel Gustafsson
t; The third version of the patch is attached for your consideration.
Thanks, I have gone over and applied most of these changes. I did leave out a
few (like the libc one) where the current page had multiple different versions.
--
Daniel Gustafsson
lowercase "join" matches
the remainder of the paragraph and makes it more readable IMHO. It's not
discussing syntax the user is expected to type so need to make it so.
--
Daniel Gustafsson
f rows from the cursor
specified by the parameter cursor"
That could be rewritten to include the name of the parameter like: "fetches the
number of rows indicated by the parameter count from the cursor specified by
the parameter cursor". We do mention every other parameter explicitl
laces on that same page which should be built-in
rather than builtin to separate the concept from the parameter value.
--
Daniel Gustafsson
for NOT NULL constraints at all, so they are not
This seems mostly to be a question of taste, I don't think not-null is
incorrect here.
--
Daniel Gustafsson
This is probably the source of your problem. IIRC, pg_upgrade
> needs to be pointed at the actual old data directory, not
> PGDATA=/var/lib/pgsql/10/data.
Correct, pg_upgrade use the PGDATANEW and PGDATAOLD env variables for the
cluster data directories.
--
Daniel Gustafsson
n the description to avoid any confusion.
Something like:
-INSERT command. The value specified must be a
+INSERT command to be
nrows. The value specified must be a
There are many more options without parameters named in the description though.
--
Daniel Gustafsson
ight have misunderstood the grammarfrom not being a native speaker), but I'm still inclined to change since weconsistently use "result sets" in the rest of the documentation.
--Daniel Gustafsson
0001-doc-Consistent-use-result-set-in-documentation.patch
Description: Binary data
> On 18 Jul 2024, at 15:49, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> While not a standard the pilcrow [0] is, AFAICT from a bit of looking at
>> other
>> docs, commonly used for this. There is a lot of variability though so
>> whichever we choose
ndard the pilcrow [0] is, AFAICT from a bit of looking at other
docs, commonly used for this. There is a lot of variability though so
whichever we choose it will be wrong one for someone.
--
Daniel Gustafsson
[0] https://en.wikipedia.org/wiki/Pilcrow
> On 4 Jul 2024, at 22:22, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> On 4 Jul 2024, at 07:40, Tom Lane wrote:
>>> I happened to come across this:
>>> https://arxiv.org/pdf/1901.01973
>>> I found this to be really interesting reading,
> On 4 Jul 2024, at 17:12, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> Unrelated to that, but reading history.sgml I found this sentend at the end
>> of
>> the page to be sort of misleading:
>
>> "Details about what has happened in PostgreSQL
Ports, in the
> bibliography leads to a forbidden page.
Does it still do that? Clicking the link leads me to the referenced paper.
--
Daniel Gustafsson
> On 3 Jul 2024, at 11:49, Peter Eisentraut wrote:
>
> On 03.07.24 11:23, Daniel Gustafsson wrote:
>> In the documentation for ssl_prefer_server_ciphers we only say it's not in
>> "older version" but we omit to specify it further. Since it's a fairly
>
appened in PostgreSQL since then can be found
in Appendix E."
While technically true, it seems a bit overpromising in a history section to
refer to the release notes which are written in a very different way from the
prose here (and the release notes are not even in Appendix E anymore).
--
Daniel Gustafsson
> On 3 Jul 2024, at 18:22, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> In the documentation for ssl_prefer_server_ciphers we only say it's not in
>> "older version" but we omit to specify it further. Since it's a fairly
>> important setting
dds proper markup in the
paragraph while in there).
--
Daniel Gustafsson
ssl_prefer_cipher.diff
Description: Binary data
e schema/table in the backup file.
+least one schema/table in the file to be restored.
Would it make sense to use "import" in some cases instead?
--
Daniel Gustafsson
> On 22 Apr 2024, at 10:45, Daniel Gustafsson wrote:
>
>> On 21 Apr 2024, at 12:57, PG Doc comments form
>> wrote:
>>
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/16/app-psql.html
gt; documentation is needed here.
This sounds like a question for the Homebrew maintainers, the postgres project
is not packaging postgres for Homebrew and have no insight into how they do it.
--
Daniel Gustafsson
stdb(> FROM my_table t1 CROSS JOIN my_table t2 ORDER BY 1 DESC
> testdb(> \crosstabview "A" "B" "AxB" ord
> ```
That's an impressively eagle-eyed observation, it is indeed showing an open
parenthesis where none is. Will fix.
--
Daniel Gustafsson
> On 16 Apr 2024, at 12:42, Pavel Luzanov wrote:
>
> Please consider a small correction of the link to the initial data
> synchronization section on the pg_createsubscriber page.
Agreed, that makes sense. Applied.
--
Daniel Gustafsson
> On 4 Apr 2024, at 12:41, Daniel Gustafsson wrote:
>
>> On 3 Apr 2024, at 14:23, Magnus Hagander wrote:
>>
>> On Wed, Apr 3, 2024 at 1:18 PM Daniel Gustafsson > <mailto:[email protected]>> wrote:
>> The tools.ietf.org <http://tools.ietf.org/> serv
> On 9 Apr 2024, at 18:33, Daniel Gustafsson wrote:
>
>> On 9 Apr 2024, at 16:05, PG Doc comments form wrote:
>>
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/16/app-psql.html
>>
gt;
> https://www.postgresql.org/docs/current/app-psql.html
Nice catch, will fix.
--
Daniel Gustafsson
ion which the project still supports with bugfixes.
--
Daniel Gustafsson
reading for your version if Postgres:
https://www.postgresql.org/docs/12/index.html
--
Daniel Gustafsson
> On 9 Apr 2024, at 16:02, Arne Sommerfelt wrote:
>
Thats the documentation for v16, not the version you are running.
--
Daniel Gustafsson
> On 3 Apr 2024, at 14:23, Magnus Hagander wrote:
>
> On Wed, Apr 3, 2024 at 1:18 PM Daniel Gustafsson <mailto:[email protected]>> wrote:
> The tools.ietf.org <http://tools.ietf.org/> server which we use for all
> RFC/BCP links in the docs has
> been deco
locations.
--
Daniel Gustafsson
v1-0001-doc-Update-links-to-RFC-documents-to-avoid-redire.patch
Description: Binary data
e changed, will fix.
>> - Add a statement 'The option specified on a table overrides an option
>> specified for the server.'
>
> I think that applies to all options. It would be better to have a general
> statement to that effect at the beginning of the "Options" section.
Yeah, that might be a good idead.
--
Daniel Gustafsson
x27;t have a copy of the standard though so
I'll leave it to someone who does comment.
--
Daniel Gustafsson
, unless Peter (on cc:) objects.
--
Daniel Gustafsson
f303.diff
Description: Binary data
> On 21 Feb 2024, at 03:24, Erik Wienhold wrote:
>
> The docs on pg_reload_conf() in v15, v16, and devel have an incorrect
> link to pg_ident_file_mappings. The attached patch fixes that.
Nice catch, will fix.
--
Daniel Gustafsson
> On 13 Feb 2024, at 21:24, Magnus Hagander wrote:
>
> On Tue, Feb 13, 2024 at 9:08 PM Tom Lane wrote:
>>
>> Daniel Gustafsson writes:
>>> On 13 Feb 2024, at 20:42, Tom Lane wrote:
>>>> I'm a little dubious about the "Technical References
> On 13 Feb 2024, at 20:42, Tom Lane wrote:
>
> Magnus Hagander writes:
>> On Tue, Feb 13, 2024 at 7:12 PM Daniel Gustafsson wrote:
>>> However, I wonder if we aren't better off removing the "Useful Reading"
>>> section
>>> altog
is unlikely to provide more insights than what more
curated sites can do.
--
Daniel Gustafsson
writer GUCs so it doesn't seem like an
unreasonable idea. It might not help too many, but not printing it at all
clearly doesn't really help anyone.
--
Daniel Gustafsson
> On 7 Feb 2024, at 22:33, PG Doc comments form wrote:
> [ STRATEGY [=] strategy ] ]
>
> ...has a superfluous ], I think?
Nice catch, it sure seems like so. Will fix, thanks for the report!
--
Daniel Gustafsson
> On 6 Feb 2024, at 11:46, Alvaro Herrera wrote:
>
> On 2024-Feb-06, Daniel Gustafsson wrote:
>
>>> On 5 Feb 2024, at 22:23, PG Doc comments form
>>> wrote:
>>
>>> This page has a link that says "See the release notes for Postgr
ase notes though.
While not directly to the v12 release notes, it leads to a page where the
release notes are linked from which seems good enough here. This is a note on
a change that happened in the oldest still supported version, with the previous
behavior EOL.
--
Daniel Gustafsson
> On 1 Feb 2024, at 08:35, David G. Johnston wrote:
> maybe move the wording to the cert page and replace the content in
> pg_hba.conf with a link to there. Leaning toward the later ATM.
That sounds like the best option IMHO, care to propose a patch?
--
Daniel Gustafsson
ingle dash. Thanks for the report, I'll fix
this backpatched down to 14 where it was introduced.
--
Daniel Gustafsson
eral mailinglist
or pgsql-novice list for help getting started:
https://www.postgresql.org/list/
--
Daniel Gustafsson
login_trigger enable always trigger;
^
The attached trivial patch removes the extra keyword, which needs to be
backpatched all the way down.
--
Daniel Gustafsson
alter_evt.diff
Description: Binary data
inherit the privileges of the
>owning role) and able to SET ROLE to the new owning
> role.
> + All object privileges of the old owner are transferred to the new owner
> + along with the ownership.
>
Doesn't seem unreasonable to me, it won't make the docs harder to read and use
for experienced users while it may make them easier to follow for new users.
--
Daniel Gustafsson
it doesn't hurt to spell out what we take for granted but a
newcomer have to figure out in order to make the documentation easy to follow
for new users. Something like the attached would be enough I think.
--
Daniel Gustafsson
pg_basebackup_X.diff
Description: Binary data
t, the attached diff updates the compiler and comment as
per the above. Unless there are objections I'll go ahead with that.
--
Daniel Gustafsson
freebsd_compiler.diff
Description: Binary data
_data_wrapper where fdwname='dummy';
fdwoptions
--
{foo=1,drop=bar}
(1 row)
This has been incorrect since forever so I will backpatch this into all
supported versions.
--
Daniel Gustafsson
This form is not intended to be used for general questions about postgres,
please use the appropriate mailinglist for this. In your case I would
recomment pgsql-general.
https://www.postgresql.org/list/
--
Daniel Gustafsson
> On 13 Nov 2023, at 12:20, Alvaro Herrera wrote:
>
> On 2023-Nov-13, Daniel Gustafsson wrote:
>
>> That's a fair point. It's sort of hard to refer back from the acronym list
>> though since we don't have a single Access Method section but instead o
es.
No need for an apology. *All* contributions are valuable, big and small. I'll
go ahead and fix this, thanks for the report!
--
Daniel Gustafsson
for
Indexes and one for Relations. In the attached diff I propose that we add a
glossary entry for Access Method (suggested better wording much appreciated)
which the acronym can refer to. Being such a core concept it doesn't seem like
a bad idea to explain it.
--
Daniel Gustafsson
am_acronym.diff
Description: Binary data
not I
think it should be backpatched all the way since it exists for all supported
versions.
--
Daniel Gustafsson
0604%40agliodbs.com>
>
> Read the notes section.
The notes section is pretty hidden though, I can sympathize with anyone missing
it and maybe making the info a bit more visible would be good?
--
Daniel Gustafsson
book referred to for the example, we don't
expect our readers to either so it seems to me that we could remove it from the
example to avoid risk of confusion. Would you like to propose a patch for this?
--
Daniel Gustafsson
docs/11/view-pg-sequences.html) is incorrect, so
> I've fixed it. Patches are attached, please have a look.
Thanks for the report, this is indeed incorrect. I've applied this patch to 11
and 12.
--
Daniel Gustafsson
's intended to be a variable or column reference than
> a built-in function.
Agreed, and "user" is a hard search term to use for discovering what it is. +1
for changing to current_user.
--
Daniel Gustafsson
> On 27 Sep 2023, at 15:18, Peter Eisentraut wrote:
>
> On 25.09.23 13:09, Daniel Gustafsson wrote:
>> Commit b73c3a11963 introduced xyz
>> hyperlinks for files in the postgres source tree by linking to the gitweb
>> interface at git.postgresql.org. This, IMO, ma
od point, how is this attached patch?
LGTM.
--
Daniel Gustafsson
> On 25 Sep 2023, at 14:22, Alvaro Herrera wrote:
>
> On 2023-Sep-25, Daniel Gustafsson wrote:
>
>> This does of course present a question for the backbranches, pointing to the
>> HEAD version in the docs for a previous major release isn't entirely
>> accurat
e that we might as well sort out now what to do about that.
--
Daniel Gustafsson
1 - 100 of 286 matches
Mail list logo
