Re: Documentation: 21.5. Default Roles

2021-04-02 Thread Jonathan S. Katz
On 4/2/21 9:11 AM, Stephen Frost wrote: > Greetings, > > * Jonathan S. Katz (jk...@postgresql.org) wrote: >> Thanks Stephen! Do we have any additional follow up on the pgweb side? > > Yes and no. :) > > Once the next set of minor releases is pushed out, I'll double-check > that everything is wo

Re: Documentation: 21.5. Default Roles

2021-04-02 Thread Stephen Frost
Greetings, * Jonathan S. Katz (jk...@postgresql.org) wrote: > On 4/1/21 3:34 PM, Stephen Frost wrote: > > * Stephen Frost (sfr...@snowman.net) wrote: > > >> I've written a patch to begin to make this change and sent it into > >> -hackers for comments, thread is here: > >> > >> https://postgr.es/m

Re: Documentation: 21.5. Default Roles

2021-04-02 Thread Jonathan S. Katz
On 4/1/21 3:34 PM, Stephen Frost wrote: > Greetings, > > * Stephen Frost (sfr...@snowman.net) wrote: >> I've written a patch to begin to make this change and sent it into >> -hackers for comments, thread is here: >> >> https://postgr.es/m/20201120211304.gg16...@tamriel.snowman.net > > Just to wr

Re: Documentation: 21.5. Default Roles

2021-04-01 Thread Stephen Frost
Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Bruce Momjian (br...@momjian.us) wrote: > > On Fri, Oct 23, 2020 at 05:40:37PM -0400, Stephen Frost wrote: > > > Therefore, on the whole, the proposal that I would put out there is: > > > > > > - Rename everything (code, docs, etc) to 'pr

Re: Documentation: 21.5. Default Roles

2020-11-23 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Fri, Oct 23, 2020 at 05:40:37PM -0400, Stephen Frost wrote: > > Therefore, on the whole, the proposal that I would put out there is: > > > > - Rename everything (code, docs, etc) to 'predefined roles' for v14+ > > - Update the documentatio

Re: Documentation: 21.5. Default Roles

2020-10-26 Thread Bruce Momjian
On Fri, Oct 23, 2020 at 05:40:37PM -0400, Stephen Frost wrote: > Therefore, on the whole, the proposal that I would put out there is: > > - Rename everything (code, docs, etc) to 'predefined roles' for v14+ > - Update the documentation (only) in back-branches to mention that the > feature was re

Re: Documentation: 21.5. Default Roles

2020-10-23 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > OK, Stephen, I believe you have a more comprehensive patch to make this > change. When can you complete it? The above email is from April. Having gone back through this thread (again) to figure out where we are on this, and chatting with Jo

Re: Documentation: 21.5. Default Roles

2020-10-05 Thread Bruce Momjian
On Tue, Apr 28, 2020 at 04:02:25PM -0400, Jonathan Katz wrote: > On 4/28/20 2:19 PM, Magnus Hagander wrote: > > On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz > > wrote: > > > > On 4/9/20 11:45 PM, Bruce Momjian wrote: > > > On Thu, Apr  9, 2020 at 08:47:56P

Re: Documentation: 21.5. Default Roles

2020-04-29 Thread Peter Eisentraut
On 2020-04-10 05:45, Bruce Momjian wrote: On Thu, Apr 9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote: On 4/9/20 4:57 PM, Bruce Momjian wrote: Jonathan, Stephen, with the minor release done, can we focus on adding the URL redirect and completing the patch to rename this feature in the docs?

Re: Documentation: 21.5. Default Roles

2020-04-28 Thread Jonathan S. Katz
On 4/28/20 2:19 PM, Magnus Hagander wrote: > On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz > wrote: > > On 4/9/20 11:45 PM, Bruce Momjian wrote: > > On Thu, Apr  9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote: > >> On 4/9/20 4:57 PM, Bruce Momjian wro

Re: Documentation: 21.5. Default Roles

2020-04-28 Thread Magnus Hagander
On Tue, Apr 28, 2020 at 8:20 PM Stephen Frost wrote: > Greetings, > > * Magnus Hagander (mag...@hagander.net) wrote: > > On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz > > wrote: > > > > > On 4/9/20 11:45 PM, Bruce Momjian wrote: > > > > On Thu, Apr 9, 2020 at 08:47:56PM -0400, Jonathan Katz

Re: Documentation: 21.5. Default Roles

2020-04-28 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz > wrote: > > > On 4/9/20 11:45 PM, Bruce Momjian wrote: > > > On Thu, Apr 9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote: > > >> On 4/9/20 4:57 PM, Bruce Momjian wrote: > > >>> Jonatha

Re: Documentation: 21.5. Default Roles

2020-04-28 Thread Magnus Hagander
On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz wrote: > On 4/9/20 11:45 PM, Bruce Momjian wrote: > > On Thu, Apr 9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote: > >> On 4/9/20 4:57 PM, Bruce Momjian wrote: > >>> Jonathan, Stephen, with the minor release done, can we focus on adding > >>> the

Re: Documentation: 21.5. Default Roles

2020-04-24 Thread Jonathan S. Katz
On 4/9/20 11:45 PM, Bruce Momjian wrote: > On Thu, Apr 9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote: >> On 4/9/20 4:57 PM, Bruce Momjian wrote: >>> Jonathan, Stephen, with the minor release done, can we focus on adding >>> the URL redirect and completing the patch to rename this feature in the

Re: Documentation: 21.5. Default Roles

2020-04-09 Thread Bruce Momjian
On Thu, Apr 9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote: > On 4/9/20 4:57 PM, Bruce Momjian wrote: > > Jonathan, Stephen, with the minor release done, can we focus on adding > > the URL redirect and completing the patch to rename this feature in the > > docs? Thanks. > > Yes, I have a proto

Re: Documentation: 21.5. Default Roles

2020-04-09 Thread Jonathan S. Katz
On 4/9/20 4:57 PM, Bruce Momjian wrote: > On Thu, Feb 6, 2020 at 10:59:09AM -0500, Jonathan Katz wrote: >> On 2/6/20 12:11 AM, Bruce Momjian wrote: >>> On Tue, Feb 4, 2020 at 11:31:19AM -0500, Jonathan Katz wrote: > Using this feature to handle the rename of a file *between* major > versi

Re: Documentation: 21.5. Default Roles

2020-04-09 Thread Bruce Momjian
On Thu, Feb 6, 2020 at 10:59:09AM -0500, Jonathan Katz wrote: > On 2/6/20 12:11 AM, Bruce Momjian wrote: > > On Tue, Feb 4, 2020 at 11:31:19AM -0500, Jonathan Katz wrote: > >>> Using this feature to handle the rename of a file *between* major > >>> versions, thus leaving the changes in master, sh

Re: Documentation: 21.5. Default Roles

2020-02-09 Thread Stephen Frost
Greetings, On Sun, Feb 9, 2020 at 14:24 Tom Lane wrote: > Stephen Frost writes: > > * Jonathan S. Katz (jk...@postgresql.org) wrote: > >> On 2/6/20 12:11 AM, Bruce Momjian wrote: > >>> Folks, is it Thursday. Can we revert this and return to it when we are > >>> not rushed? Alternatively, can

Re: Documentation: 21.5. Default Roles

2020-02-09 Thread Tom Lane
Stephen Frost writes: > * Jonathan S. Katz (jk...@postgresql.org) wrote: >> On 2/6/20 12:11 AM, Bruce Momjian wrote: >>> Folks, is it Thursday. Can we revert this and return to it when we are >>> not rushed? Alternatively, can someone who controls all the moving >>> parts, like redirects and St

Re: Documentation: 21.5. Default Roles

2020-02-06 Thread Bruce Momjian
On Thu, Feb 6, 2020 at 11:05:04AM -0500, Stephen Frost wrote: > * Jonathan S. Katz (jk...@postgresql.org) wrote: > > I don't have the power to revert changes directly to the documentation > > in core, so I cannot take ownership of that part. However, I am happy to > > own the completion of the red

Re: Documentation: 21.5. Default Roles

2020-02-06 Thread Stephen Frost
Greetings, * Jonathan S. Katz (jk...@postgresql.org) wrote: > On 2/6/20 12:11 AM, Bruce Momjian wrote: > > On Tue, Feb 4, 2020 at 11:31:19AM -0500, Jonathan Katz wrote: > >>> Using this feature to handle the rename of a file *between* major > >>> versions, thus leaving the changes in master, shou

Re: Documentation: 21.5. Default Roles

2020-02-06 Thread Jonathan S. Katz
On 2/6/20 12:11 AM, Bruce Momjian wrote: > On Tue, Feb 4, 2020 at 11:31:19AM -0500, Jonathan Katz wrote: >>> Using this feature to handle the rename of a file *between* major >>> versions, thus leaving the changes in master, should be safe (as long >>> as we add an entry to that table in pgweb). >

Re: Documentation: 21.5. Default Roles

2020-02-05 Thread Bruce Momjian
On Tue, Feb 4, 2020 at 11:31:19AM -0500, Jonathan Katz wrote: > > Using this feature to handle the rename of a file *between* major > > versions, thus leaving the changes in master, should be safe (as long > > as we add an entry to that table in pgweb). > > > > As for back branches, I think we ha

Re: Documentation: 21.5. Default Roles

2020-02-04 Thread Jonathan S. Katz
On 2/4/20 3:34 AM, Magnus Hagander wrote: > On Mon, Feb 3, 2020 at 9:59 PM Jonathan S. Katz wrote: >> So, if there was something done to redirect people from specific >> deprecated documentation pages historically, it was before my time. Most >> of the redirects have been as general purposes ones

Re: Documentation: 21.5. Default Roles

2020-02-04 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > On 2020-Feb-03, Jonathan S. Katz wrote: > > > So, if there was something done to redirect people from specific > > deprecated documentation pages historically, it was before my time. Most > > of the redirects have been as general pur

Re: Documentation: 21.5. Default Roles

2020-02-04 Thread Magnus Hagander
On Mon, Feb 3, 2020 at 9:59 PM Jonathan S. Katz wrote: > > On 2/3/20 3:42 PM, Bruce Momjian wrote: > > On Thu, Jan 23, 2020 at 07:12:08PM -0500, R Ransbottom wrote: > >> On Mon, Jan 20, 2020 at 12:23:48PM +0900, Ian Barwick wrote: > >>> On 2020/01/19 12:56, R Ransbottom wrote: > >> > I would

Re: Documentation: 21.5. Default Roles

2020-02-03 Thread Alvaro Herrera
On 2020-Feb-03, Jonathan S. Katz wrote: > So, if there was something done to redirect people from specific > deprecated documentation pages historically, it was before my time. Most > of the redirects have been as general purposes ones (e.g. /docs/12), the > rules we put in for getting rid of "sta

Re: Documentation: 21.5. Default Roles

2020-02-03 Thread Jonathan S. Katz
On 2/3/20 3:42 PM, Bruce Momjian wrote: > On Thu, Jan 23, 2020 at 07:12:08PM -0500, R Ransbottom wrote: >> On Mon, Jan 20, 2020 at 12:23:48PM +0900, Ian Barwick wrote: >>> On 2020/01/19 12:56, R Ransbottom wrote: >> I would hope to find correct documentation somewhere--that somewhere >> >>> In

Re: Documentation: 21.5. Default Roles

2020-02-03 Thread Bruce Momjian
On Thu, Jan 23, 2020 at 07:12:08PM -0500, R Ransbottom wrote: > On Mon, Jan 20, 2020 at 12:23:48PM +0900, Ian Barwick wrote: > > On 2020/01/19 12:56, R Ransbottom wrote: > > > > I would hope to find correct documentation somewhere--that somewhere > > > Indeed, however it's important that the Post

Re: Documentation: 21.5. Default Roles

2020-01-23 Thread R Ransbottom
On Mon, Jan 20, 2020 at 12:23:48PM +0900, Ian Barwick wrote: > On 2020/01/19 12:56, R Ransbottom wrote: > > I would hope to find correct documentation somewhere--that somewhere > Indeed, however it's important that the PostgreSQL documentation remains > stable for released versions. > As-is, the

Re: Documentation: 21.5. Default Roles

2020-01-21 Thread Tom Lane
Bruce Momjian writes: > I looked at that option. If the section was a hash reference, > "#section_name", we could just add another hash, but in this case the > section name is part of the file name: > https://www.postgresql.org/docs/12/default-roles.html Yeah, IDs propagate into HTML page

Re: Documentation: 21.5. Default Roles

2020-01-21 Thread Bruce Momjian
On Tue, Jan 21, 2020 at 10:06:43AM +0100, Laurenz Albe wrote: > On Mon, 2020-01-20 at 17:13 -0500, Bruce Momjian wrote: > > Well, I am renaming the documentation label for the feature. Is that > > different than wording? I guess I can see that. If everyone agrees I > > can revert the backpatch,

Re: Documentation: 21.5. Default Roles

2020-01-21 Thread Laurenz Albe
On Mon, 2020-01-20 at 17:13 -0500, Bruce Momjian wrote: > Well, I am renaming the documentation label for the feature. Is that > different than wording? I guess I can see that. If everyone agrees I > can revert the backpatch, but I don't want to do that if other people > are going to say this sh

Re: Documentation: 21.5. Default Roles

2020-01-20 Thread Bruce Momjian
On Mon, Jan 20, 2020 at 06:45:16PM +, Simon Riggs wrote: > On Mon, 20 Jan 2020 at 16:03, Bruce Momjian wrote: > Usually when I apply "wording" doc patches to head only, someone > complains that it should be backpatched, so I did that in this case.  If > we want to change that idea,

Re: Documentation: 21.5. Default Roles

2020-01-20 Thread Simon Riggs
On Mon, 20 Jan 2020 at 16:03, Bruce Momjian wrote: > On Mon, Jan 20, 2020 at 12:23:48PM +0900, Ian Barwick wrote: > > > I would hope to find correct documentation somewhere--that somewhere > > > should be Postgresql's own documentation. > > > > Indeed, however it's important that the PostgreSQL d

Re: Documentation: 21.5. Default Roles

2020-01-20 Thread Bruce Momjian
On Mon, Jan 20, 2020 at 12:23:48PM +0900, Ian Barwick wrote: > > I would hope to find correct documentation somewhere--that somewhere > > should be Postgresql's own documentation. > > Indeed, however it's important that the PostgreSQL documentation remains > stable for released versions. > > As-i

Re: Documentation: 21.5. Default Roles

2020-01-19 Thread Ian Barwick
On 2020/01/19 12:56, R Ransbottom wrote: Hi, On Tue, Jan 14, 2020 at 02:45:02PM -0500, Stephen Frost wrote: * Bruce Momjian (br...@momjian.us) wrote: On Tue, Jan 7, 2020 at 11:46:31AM +0100, Laurenz Albe wrote: On Fri, 2019-12-27 at 12:16 -0500, Bruce Momjian wrote: On Fri, Dec 27, 2019 at

Re: Documentation: 21.5. Default Roles

2020-01-19 Thread R Ransbottom
Hi, On Tue, Jan 14, 2020 at 02:45:02PM -0500, Stephen Frost wrote: > * Bruce Momjian (br...@momjian.us) wrote: > > On Tue, Jan 7, 2020 at 11:46:31AM +0100, Laurenz Albe wrote: > > > On Fri, 2019-12-27 at 12:16 -0500, Bruce Momjian wrote: > > > > On Fri, Dec 27, 2019 at 05:44:10AM +, PG Doc co

Re: Documentation: 21.5. Default Roles

2020-01-14 Thread Bruce Momjian
On Tue, Jan 14, 2020 at 02:45:02PM -0500, Stephen Frost wrote: > > > I think that "predefined role" is better than "default role". > > > > Thanks, patch applied through 9.6. > > Erm, I didn't agree with this and pointed to reasons why it was based, > for starters, on a misunderstanding and furthe

Re: Documentation: 21.5. Default Roles

2020-01-14 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Tue, Jan 7, 2020 at 11:46:31AM +0100, Laurenz Albe wrote: > > On Fri, 2019-12-27 at 12:16 -0500, Bruce Momjian wrote: > > > On Fri, Dec 27, 2019 at 05:44:10AM +, PG Doc comments form wrote: > > > > The following documentation comment h

Re: Documentation: 21.5. Default Roles

2020-01-14 Thread Bruce Momjian
On Tue, Jan 7, 2020 at 11:46:31AM +0100, Laurenz Albe wrote: > On Fri, 2019-12-27 at 12:16 -0500, Bruce Momjian wrote: > > On Fri, Dec 27, 2019 at 05:44:10AM +, PG Doc comments form wrote: > > > The following documentation comment has been logged on the website: > > > > > > Page: https://www.

Re: Documentation: 21.5. Default Roles

2020-01-07 Thread Laurenz Albe
On Fri, 2019-12-27 at 12:16 -0500, Bruce Momjian wrote: > On Fri, Dec 27, 2019 at 05:44:10AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/default-roles.html > > Description: > > > > The

Re: Documentation: 21.5. Default Roles

2019-12-27 Thread Stephen Frost
Greetings, * PG Doc comments form (nore...@postgresql.org) wrote: > The title is wrong. The roles are not defaults; they are predefined and > privileged. The title suggests that a user should expect to be assigned > these roles. "21.5 Sub-Administrator Roles" would be accurate--improving >

Re: Documentation: 21.5. Default Roles

2019-12-27 Thread Bruce Momjian
On Fri, Dec 27, 2019 at 05:44:10AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/default-roles.html > Description: > > The title is wrong. The roles are not defaults; they are predefined and

Documentation: 21.5. Default Roles

2019-12-27 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/default-roles.html Description: The title is wrong. The roles are not defaults; they are predefined and privileged. The title suggests that a user should expect to be assigned these ro