Hi,
2) The test is failing intermittently because it's executed in parallel
with stats_ext test, which is also creating extended statistics. So
depending on the timing the \dX may list some of the stats_ext stuff.
I'm not sure what to do about this. Either this part needs to be moved
to a sepa
On 2020/11/05 23:54, Seino Yuki wrote:
2020-11-02 20:01 に Fujii Masao さんは書きました:
On 2020/11/02 14:02, Yuki Seino wrote:
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant:
On 11/3/20 10:22 AM, Magnus Hagander wrote:
On Thu, Sep 24, 2020 at 5:17 AM Michael Paquier wrote:
No objections from here to remove that from the core tests. It is
worth noting that Debian Code Search hints that this is used in some
extensions:
https://codesearch.debian.net/search?q=TG_RELNAM
On Tue, Nov 10, 2020 at 11:18 AM Dilip Kumar wrote:
>
> On Tue, Nov 10, 2020 at 10:52 AM Amit Kapila wrote:
> >
> > On Tue, Nov 10, 2020 at 10:26 AM Dilip Kumar wrote:
> > >
> > > On Tue, Nov 10, 2020 at 8:14 AM Amit Kapila
> > > wrote:
> > > >
> > > > On Mon, Nov 9, 2020 at 6:00 PM Dilip Kuma
I did some effort to review your patch which seems legit to me.
I think some minor things are better to be improved i.e.
1. Comment regarding
--
347 * Check for the possibility that the target is in fact a direct
348 * ancestor of the source. In that case, there is no diverge
On Fri, Nov 6, 2020 at 11:26 PM Anastasia Lubennikova <
a.lubennik...@postgrespro.ru> wrote:
> Status update for a commitfest entry.
>
> According to CFbot this patch fails to apply. Richard, can you send an
> update, please?
>
> Also, I see that the thread was inactive for a while.
> Are you goin
On 2020/11/10 16:17, Kyotaro Horiguchi wrote:
At Sat, 7 Nov 2020 19:31:21 +0530, Bharath Rupireddy
wrote in
The main reason for having SetLatch() in
SignalHandlerForConfigReload() is to wake up the calling process if
waiting in WaitLatchOrSocket() or WaitLatch() and reload the new
config fil
> On Nov 9, 2020, at 6:41 PM, Bharath Rupireddy
> wrote:
>
> On Tue, Nov 3, 2020 at 4:54 PM Bharath Rupireddy
> wrote:
>>
>> If the approach followed in the patch looks okay, I can work on a separate
>> patch for multi inserts in refresh materialized view cases.
>>
>
> Hi, I'm attaching a v2 p
I was doing some testing, and I found some issues. Two issues. The
first one, seems to be a behaviour that might be acceptable, the
second one not so much.
I was using test_decoding, not sure how this might behave with the
pg_output plugin.
Test 1:
A transaction that is immediately rollbacked afte
On Wed, Nov 4, 2020 at 11:32 AM Amit Langote wrote:
> On Tue, Nov 3, 2020 at 9:05 PM Heikki Linnakangas wrote:
> > On 03/11/2020 10:27, Amit Langote wrote:
> > > Please check the attached if that looks better.
> >
> > Great, thanks! Yeah, I like that much better.
> >
> > This makes me a bit unhap
Hello
> If someone changes restore_command to '' then reload while crash
> recovery is running, the server stops for no valid reason.
While *crash* recovery is running? It's possible only during Point-in-Time
Recovery, no?
At the beginning of validateRecoveryParameters we check
ArchiveRecoveryR
Hi
I notice that there are no Nullif case in eval_const_expression.
Since Nullif is similar to Opexpr and is easy to implement,
I try add this case in eval_const_expressions_mutator.
Best regards,
houzj
0001-patch-eval-NULLIF.patch
Description: 0001-patch-eval-NULLIF.patch
At Thu, 5 Nov 2020 16:03:12 +0900, yuzuko wrote in
> Hi Justin,
>
> Thank you for your comments.
> I attached the latest patch(v11) to the previous email.
>
> >
> > +* Get its all ancestors to propagate changes_since_analyze
> > count.
> > +* However, when ANALY
Hello.
At Tue, 10 Nov 2020 14:13:17 +0300, Sergei Kornilov wrote in
> Hello
>
> > If someone changes restore_command to '' then reload while crash
> > recovery is running, the server stops for no valid reason.
>
> While *crash* recovery is running? It's possible only during Point-in-Time
> Re
On Mon, Nov 9, 2020 at 4:58 PM Tom Lane wrote:
>
> Magnus Hagander writes:
> > On Wed, Nov 4, 2020 at 2:10 AM Tom Lane wrote:
> >> ... looking at this again, BackendRun certainly looks ridiculously
> >> over-engineered for what it still does.
>
> > Yeah, looking at it again, I agree. PFA an upda
On Tue, Nov 10, 2020 at 3:04 PM Fujii Masao wrote:
>
> >> The main reason for having SetLatch() in
> >> SignalHandlerForConfigReload() is to wake up the calling process if
> >> waiting in WaitLatchOrSocket() or WaitLatch() and reload the new
> >> config file and use the reloaded config variables.
Hi,
Attaching a patch that replaces custom signal handlers for SIGHUP and
SIGTERM in worker_spi.c.
Thoughts?
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
From a212163b64bc3ab4b8d4493e6d53f32979e3e9bf Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy
Date: Tue, 10 N
On Tue, Nov 3, 2020 at 2:28 PM Amit Kapila wrote:
>
> On Mon, Nov 2, 2020 at 12:40 PM Heikki Linnakangas wrote:
> >
> > On 02/11/2020 08:14, Amit Kapila wrote:
> > > On Fri, Oct 30, 2020 at 10:11 PM Heikki Linnakangas
> > > wrote:
> > >>
> > >> In this design, you don't need to keep line bounda
On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar wrote:
>
> On Tue, Nov 10, 2020 at 11:18 AM Dilip Kumar wrote:
> >
> > On Tue, Nov 10, 2020 at 10:52 AM Amit Kapila
> > wrote:
> > > For this case, users can use skip_empty_xacts = true and
> > > skip_empty_streams = false. I am just asking if the use
On Tue, Nov 10, 2020 at 7:12 PM vignesh C wrote:
>
> On Tue, Nov 3, 2020 at 2:28 PM Amit Kapila wrote:
> >
>
> I have worked to provide a patch for the parallel safety checks. It
> checks if parallely copy can be performed, Parallel copy cannot be
> performed for the following a) If relation is t
Greetings,
* Kyotaro Horiguchi (horikyota@gmail.com) wrote:
> At Mon, 9 Nov 2020 10:18:08 -0500, Stephen Frost wrote
> in
> > Greetings,
> >
> > * osumi.takami...@fujitsu.com (osumi.takami...@fujitsu.com) wrote:
> > > When I consider the use case is the system of data warehouse
> > > as de
‐‐‐ Original Message ‐‐‐
On Monday, November 9, 2020 7:50 PM, Soumyadeep Chakraborty
wrote:
> Hey Georgios,
>
> Thanks for looking for more avenues to invoke tableAM APIS! Please find
> my review below:
A great review Soumyadeep, it is much appreciated.
Please remember to add your
Greetings,
* Kyotaro Horiguchi (horikyota@gmail.com) wrote:
> For fuel(?) of the discussion, I tried a very-quick PoC for in-place
> ALTER TABLE SET LOGGED/UNLOGGED and resulted as attached. After some
> trials of several ways, I drifted to the following way after poking
> several ways.
>
> 1
Hi,
Thanks for working on this!
On 11/10/20 1:45 AM, tsunakawa.ta...@fujitsu.com wrote:
> Hello,
>
>
> The attached patch implements the new bulk insert routine for
> postgres_fdw and the executor utilizing it. It passes make
> check-world.
>
I haven't done any testing yet, just a quick revi
On Tue, Nov 10, 2020 at 10:17:15AM +, Paul Guo wrote:
> Raw insert could be used on CTAS & Create MatView. For Refresh MatView the
> code is a bit
> different. I did not spend more time on this so not sure raw insert could be
> used for that.
>
> But I think the previous multi insert work co
On 10/11/2020 13:12, Amit Langote wrote:
On Wed, Nov 4, 2020 at 11:32 AM Amit Langote wrote:
On Tue, Nov 3, 2020 at 9:05 PM Heikki Linnakangas wrote:
A) We could change FDW API so that BeginDirectModify takes the same
arguments as BeginForeignModify(). That avoids the assumption that it's
a F
On Mon, 9 Nov 2020 at 16:26, Dave Cramer wrote:
>
>
> On Wed, 30 Sep 2020 at 18:14, Andrew Dunstan <
> andrew.duns...@2ndquadrant.com> wrote:
>
>>
>> On 8/4/20 12:19 PM, Dave Cramer wrote:
>> > Attached is the rebased patch for consideration.
>> >
>> >
>>
>>
>> It's a bit sad this has been hangin
On 2020-11-09 23:25, Tom Lane wrote:
Alexey Kondratov writes:
On 2020-11-09 21:53, Tom Lane wrote:
0002 seems like a pretty clear bug fix, though I wonder if this is
exactly
what we want to do going forward. It seems like a very large
fraction of
the callers of TimestampDifference would like
On 2020/11/09 18:02, Seino Yuki wrote:
2020-11-09 15:39 に Seino Yuki さんは書きました:
However, let me confirm the following.
Is this information really useful?
If there is no valid use case for this, I'd like to drop it.
Thought?
I thought it would be easy for users to see at a glance that if th
On 11/10/20 4:05 PM, Tomas Vondra wrote:
> Hi,
>
> Thanks for working on this!
>
> On 11/10/20 1:45 AM, tsunakawa.ta...@fujitsu.com wrote:
>> Hello,
>>
>>
>> The attached patch implements the new bulk insert routine for
>> postgres_fdw and the executor utilizing it. It passes make
>> check-wo
On Tue, Nov 10, 2020 at 12:03 PM Ranier Vilela wrote:
>
> Em sex., 26 de jun. de 2020 às 08:21, Ranier Vilela
> escreveu:
>>
>> Em qui., 11 de jun. de 2020 às 10:28, Ranier Vilela
>> escreveu:
>>>
>>> Em qui., 11 de jun. de 2020 às 10:01, Andrew Dunstan
>>> escreveu:
On 6/11/2
On 11/10/20 6:16 PM, Russell Foster wrote:
> On Tue, Nov 10, 2020 at 12:03 PM Ranier Vilela wrote:
>>
>> Em sex., 26 de jun. de 2020 às 08:21, Ranier Vilela
>> escreveu:
>>>
>>> Em qui., 11 de jun. de 2020 às 10:28, Ranier Vilela
>>> escreveu:
Em qui., 11 de jun. de 2020 às 10:01,
On 11/10/20 7:16 AM, Andrey Borodin wrote:
>
>
>> 10 нояб. 2020 г., в 05:13, Tomas Vondra
>> написал(а):
>> After the issue reported in [1] got fixed, I've restarted the multi-xact
>> stress test, hoping to reproduce the issue. But so far no luck :-(
>
>
> Tomas, many thanks for looking in
Tomas Vondra writes:
> That's unlikely, I think. The regression tests are constructed so that
> the estimates are stable. It's more likely this is some difference in
> rounding behavior, for example.
The reported delta is in the actual row count, not an estimate.
How could that be subject to roun
Hi,
I needed to look at this patch while working on something related, and I
found it got broken by 6973533650c a couple days ago. So here's a fixed
version, to keep cfbot happy. I haven't done any serious review yet.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterpr
On Wed, Nov 11, 2020 at 7:07 AM Tomas Vondra
wrote:
> Seems we haven't made much progress in reproducing the issue :-( I guess
> we'll need to know more about the machine where this happens. Is there
> anything special about the hardware/config? Are you monitoring size of
> the pg_multixact direct
n conflicts within setrefs.c.
>>
>
> fresh patch
>
rebase
> Regards
>
> Pavel
>
> --
>> Michael
>>
>
schema-variables-20201110.patch.gz
Description: application/gzip
On 11/10/20 7:15 PM, Tom Lane wrote:
> Tomas Vondra writes:
>> That's unlikely, I think. The regression tests are constructed so that
>> the estimates are stable. It's more likely this is some difference in
>> rounding behavior, for example.
>
> The reported delta is in the actual row count,
Hi,
I noticed that the cfbot fails for this patch.
For this, I am setting the status to: 'Waiting on Author'.
Cheers,
//Georgios
The new status of this patch is: Waiting on Author
Hi,
I noticed that this patch is failing on the cfbot.
For this, I changed the status to: 'Waiting on Author'
Cheers,
Georgios
The new status of this patch is: Waiting on Author
Hi,
I noticed that this patch fails on the cfbot.
For this, I changed the status to: 'Waiting on Author'.
Cheers,
//Georgios
The new status of this patch is: Waiting on Author
Hi,
I noticed that this patch fails on the cfbot.
For this, I changed the status to: 'Waiting on Author'.
Cheers,
//Georgios
The new status of this patch is: Waiting on Author
Hi,
I noticed that this patch fails on the cfbot.
For this, I changed the status to: 'Waiting on Author'.
Cheers,
//Georgios
The new status of this patch is: Waiting on Author
Hi,
just a quick comment that this patch fails on the cfbot.
Cheers,
//Georgios
Hi,
I noticed that this patch fails on the cfbot.
For this, I changed the status to: 'Waiting on Author'.
Cheers,
//Georgios
The new status of this patch is: Waiting on Author
Hi,
I noticed that this patch fails on the cfbot.
For this, I changed the status to: 'Waiting on Author'.
Cheers,
//Georgios
The new status of this patch is: Waiting on Author
I spent some time looking this over, and have a few thoughts:
1. I think it's useful to split the test changes into two patches,
as I've done below: first, just add the additional row in point_tbl
and let the fallout from that happen, and then in the second patch
make the code changes. This way,
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
Patch looks good to me. Seems like a useful feature, and I agree that
Greetings,
* Pavel Stehule (pavel.steh...@gmail.com) wrote:
> rebase + minor change - using pg_get_line_buf instead pg_get_line_append
I started looking at this and went back through the thread and while I
tend to agree that JSON may not be a good choice for this, it's not the
only possible alter
On Tue, Nov 10, 2020 at 1:15 PM Tom Lane wrote:
>
> Tomas Vondra writes:
> > That's unlikely, I think. The regression tests are constructed so that
> > the estimates are stable. It's more likely this is some difference in
> > rounding behavior, for example.
>
> The reported delta is in the actual
Hello
> Even if PITR is commanded, crash recovery can run before starting
> archive recovery if the server was not gracefully shut down.
Hmm... Still not sure how it's possible. Both readRecoverySignalFile and
validateRecoveryParameters are called early in StartupXLOG. If PITR was
commanded - w
On Nov 6, 2020, at 3:11 PM, Daniel Gustafsson wrote:
>
> The attached switches to SSL_ConfigServerSessionIDCacheWithOpt
> with which one can explicitly make the cache non-shared, which in turn backs
> the mutexes with NSPR locks rather than the missing sem_init. Can you test
> this version and s
Em ter., 10 de nov. de 2020 às 14:16, Russell Foster <
russell.foster.cod...@gmail.com> escreveu:
> On Tue, Nov 10, 2020 at 12:03 PM Ranier Vilela
> wrote:
> >
> > Em sex., 26 de jun. de 2020 às 08:21, Ranier Vilela
> escreveu:
> >>
> >> Em qui., 11 de jun. de 2020 às 10:28, Ranier Vilela <
> ra
On Tue, Nov 10, 2020 at 1:52 PM Tomas Vondra
wrote:
>
>
>
>
> On 11/10/20 7:15 PM, Tom Lane wrote:
> > Tomas Vondra writes:
> >> That's unlikely, I think. The regression tests are constructed so that
> >> the estimates are stable. It's more likely this is some difference in
> >> rounding behavior
On Sun, Nov 8, 2020 at 8:56 AM Jürgen Purtz wrote:
> Good catches. Everything applied.
>
MVCC Section
The first paragraph and example in the MVCC section is a good example but
seems misplaced - its relationship to MVCC generally is tenuous, rather I
would expect a discussion of the serializable
On Tue, 10 Nov 2020 at 03:07, Alvaro Herrera wrote:
>
> On 2020-Nov-06, David Rowley wrote:
>
> > +# Handle makefile rules for when file to be added to the project
> > +# does not exist. Returns 1 when the original file add should be
> > +# skipped.
> > +sub FindAndAddAdditionalFiles
> > +{
> > +
> On 10 Nov 2020, at 21:11, Jacob Champion wrote:
> On Nov 6, 2020, at 3:11 PM, Daniel Gustafsson wrote:
>> The attached switches to SSL_ConfigServerSessionIDCacheWithOpt
>> with which one can explicitly make the cache non-shared, which in turn backs
>> the mutexes with NSPR locks rather than th
On Tue, Nov 3, 2020 at 02:06:13PM -0400, John Naylor wrote:
> I was thinking of not having the next updates during commitfest, but it could
> also be argued this is a type of review, and the things here will be returned
> with feedback or rejected, in a way. Ultimately, it comes down to "when time
On Tue, Nov 10, 2020 at 09:50:15AM +0100, Andreas Karlsson wrote:
> I submitted patches to pgformatter, bucardo and ledgersmb. Both davical and
> sql-ledger only seems to have them in old upgrade scripts.
Thanks, Andreas!
--
Michael
signature.asc
Description: PGP signature
On Wed, Nov 11, 2020 at 11:01:57AM +1300, David Rowley wrote:
> I'm still working through some small differences in some of the
> .vcxproj files. I've been comparing these by copying *.vcxproj out to
> another directory with patched and unpatched then diffing the
> directory. See attached txt file
On Tue, Nov 10, 2020 at 04:22:37PM -0500, Russell Foster wrote:
> Never claimed they were the same, but they are both Windows x64. Here
> are some more details:
>
> Test Passes:
> VM machine (Build Server)
> Microsoft Windows 10 Pro
> Version 10.0.18363 Build 18363
> Microsoft (R) C/C++ Optimizing
On Tue, Nov 10, 2020 at 10:21:04AM +0900, Michael Paquier wrote:
> On Mon, Nov 09, 2020 at 03:47:22PM +0100, Peter Eisentraut wrote:
>> You should just remove those calls. There is no need to replace them with
>> vacuumdb calls. The reason those calls were there is that they were testing
>> the g
On Mon, Nov 09, 2020 at 11:42:33AM -0300, Alvaro Herrera wrote:
> On 2020-Nov-07, Noah Misch wrote:
> > On Sat, Nov 07, 2020 at 11:57:20AM -0500, Tom Lane wrote:
> > > A completely different approach we could consider is to weaken the
> > > permissions requirements for LOCK on a view, say "allow it
Horiguchi-San
On Tuesday, November 10, 2020 10:00 AM Kyotaro Horiguchi
wrote:
> FWIW, the following is that, I think it works not only when wal_level=minimal
> for SET UNLOGGED, and only works when minimal for SET LOGGED.
>
> https://www.postgresql.org/message-id/20201002.100621.1668918756520
Alexey Kondratov writes:
> After looking on the autoprewarm code more closely I have realised that
> this 'double dump' issues was not an issues at all. I have just
> misplaced a debug elog(), so its second output in the log was only
> indicating that we calculated delay_in_ms one more time.
A
On Tue, Nov 10, 2020 at 2:22 PM Craig Ringer
wrote:
>
> The main things I'd really like to get in place are a way to get the
> version as an ELF data symbol, and a simple way to ID the binary.
>
> So the minimal change would be to declare:
>
> const char LIBPQ_VERSION_STR[] = PG_VERSION_STR;
> co
On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila wrote:
>
> On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar wrote:
> >
> > On Tue, Nov 10, 2020 at 11:18 AM Dilip Kumar wrote:
> > >
> > > On Tue, Nov 10, 2020 at 10:52 AM Amit Kapila
> > > wrote:
> > > > For this case, users can use skip_empty_xacts = tr
Hi
út 10. 11. 2020 v 21:09 odesílatel Stephen Frost
napsal:
> Greetings,
>
> * Pavel Stehule (pavel.steh...@gmail.com) wrote:
> > rebase + minor change - using pg_get_line_buf instead pg_get_line_append
>
> I started looking at this and went back through the thread and while I
> tend to agree th
Hi
Perhaps this feature could co-exist with a full blown configuration for
>> pg_dump, but even then there's certainly issues with what's proposed-
>> how would you handle explicitly asking for a table which is named
>> " mytable" to be included or excluded? Or a table which has a newline
>> in
Hi
čt 24. 9. 2020 v 19:47 odesílatel Pavel Stehule
napsal:
> Hi
>
> rebase + minor change - using pg_get_line_buf instead pg_get_line_append
>
>
fresh rebase
Regards
>
> Pavel
>
diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
index 0aa35cf0c3..068821583f 100644
---
Hi all,
Following the report of Coverity that led to 3636efa, I have reviewed
the existing callers of parsePGArray() in pg_dump and some of its
error handling is a bit sloppy.
It could theoretically be possible to reach an OOM in parsePGArray()
with a dump able to finish. This is very unlikely g
On Mon, Nov 09, 2020 at 10:48:09PM +0300, Anastasia Lubennikova wrote:
> I see Tom's objection above. Still, I tend to agree that if 'WITH NO DATA'
> was specified explicitly, CREATE AS should behave more like a utility
> statement rather than a regular query. So I think that this patch can be
> us
st 11. 11. 2020 v 6:32 odesílatel Pavel Stehule
napsal:
> Hi
>
> út 10. 11. 2020 v 21:09 odesílatel Stephen Frost
> napsal:
>
>> Greetings,
>>
>> * Pavel Stehule (pavel.steh...@gmail.com) wrote:
>> > rebase + minor change - using pg_get_line_buf instead pg_get_line_append
>>
>> I started looking
From: Tomas Vondra
> I see the patch builds the "bulk" query in execute_foreign_modify. IMO
> that's something we should do earlier, when we're building the simple
> query (for 1-row inserts). I'd understand if you were concerned about
> overhead in case of 1-row inserts, trying to not plan the bu
74 matches
Mail list logo
