On Thu, Aug 17, 2023 at 11:44 AM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 8/14/23 11:52 AM, shveta malik wrote:
>
> >
> > We (myself and Ajin) performed the tests to compute the lag in standby
> > slots as compared to primary slots with different number of slot-sync
> > workers configured.
> >
>
>
On 2023-08-17 14:49, Drouvot, Bertrand wrote:
Hi hackers,
While working on [1] it has been noticed by Masahiro-san that the
description field
in the new pg_wait_event view contains 2 blanks for one row.
It turns out that it comes from wait_event_names.txt (added in
fa88928).
Attached a tiny
On Wed, Aug 16, 2023 at 4:51 PM Zhijie Hou (Fujitsu)
wrote:
>
> 4.
> +intnum_slots_on_old_cluster;
>
> Instead of a new global variable, would it be better to record this in the
> cluster info ?
>
I was thinking whether we can go a step ahead and remove this variable
altogether. In old clust
Hi,
On 8/14/23 11:52 AM, shveta malik wrote:
We (myself and Ajin) performed the tests to compute the lag in standby
slots as compared to primary slots with different number of slot-sync
workers configured.
Thanks!
3 DBs were created, each with 30 tables and each table having one
logical-p
Hi,
On 8/17/23 3:57 AM, Michael Paquier wrote:
On Thu, Aug 17, 2023 at 10:53:02AM +0900, Masahiro Ikeda wrote:
BTW, although I think this is outside the scope of this patch,
it might be a good idea to be able to add a description to the
API for custom wait events.
Somebody on twitter has rais
Hi,
On 8/17/23 3:53 AM, Masahiro Ikeda wrote:
Hi,
Thank you for creating the patch!
I think it is a very useful view as a user.
I will share some thoughts about the v6 patch.
Thanks for looking at it!
1)
The regular expression needs to be changed in generate-wait_event_types.pl.
I have c
Hi,
On 8/16/23 2:08 PM, Michael Paquier wrote:
On Wed, Aug 16, 2023 at 01:43:35PM +0200, Drouvot, Bertrand wrote:
Yeah, agree, done that way in v6 (also added a test in 001_worker_spi.pl
to ensure that "worker_spi_main" is reported in pg_wait_event).
-typedef struct WaitEventExtensionEntryByN
Hi hackers,
While working on [1] it has been noticed by Masahiro-san that the description
field
in the new pg_wait_event view contains 2 blanks for one row.
It turns out that it comes from wait_event_names.txt (added in fa88928).
Attached a tiny patch to fix this entry in wait_event_names.txt
On Wed, Aug 16, 2023 at 3:55 PM Hayato Kuroda (Fujitsu)
wrote:
>
> > > > It was primarily for upgrade purposes only. So, as we can't see a good
> > > > reason
> > to
> > > > go via pg_dump let's do it in upgrade unless someone thinks otherwise.
> > >
> > > Removed the new option in pg_dump and mo
On 17.08.2023 05:36, Bruce Momjian wrote:
On Wed, Aug 9, 2023 at 08:35:21PM -0400, Bruce Momjian wrote:
On Sat, Aug 5, 2023 at 04:08:47PM -0700, Noah Misch wrote:
Author: Robert Haas
2022-08-25 [e3ce2de09] Allow grant-level control of role inheritance behavior.
-->
Allow GRANT to control
On Wed, Aug 16, 2023 at 9:24 PM Nathan Bossart
wrote:
>
> On Wed, Aug 16, 2023 at 10:35:27AM +0700, John Naylor wrote:
> > Now I'm struggling to understand why each and every instance has its own
> > nominal buffer, passed down to the implementation. All we care about is
the
> > result -- is ther
On Tue, Aug 15, 2023 at 02:23:43PM +0530, Dilip Kumar wrote:
> Yeah, good idea, actually we can do this insert outside of the
> exclusive insert lock and set the LSN of this insert as the
> checkpoint. redo location. So now we do not need to compute the
> checkpoint. redo based on the current inse
On Wed, Aug 16, 2023 at 4:11 AM Heikki Linnakangas wrote:
> Makes sense.
Thanks for looking!
> If you change smgrclose() to do what smgrrelease() does now, then it
> will apply automatically to extensions.
>
> If an extension is currently using smgropen()/smgrclose() correctly,
> this patch alon
On Tue, Aug 8, 2023 at 12:27 AM Tristan Partin wrote:
> I agree that the change look good.
Thanks both. Pushed.
On Wed, Aug 16, 2023 at 08:17:05AM -0700, Nathan Bossart wrote:
> On Wed, Aug 16, 2023 at 08:10:10AM +0900, Michael Paquier wrote:
>> On Tue, Aug 08, 2023 at 01:06:06PM -0700, Nathan Bossart wrote:
>> +else
>> +{
>> +while (errno = 0, (de = readdir(dir)) != NULL)
>> +
On Thu, Aug 17, 2023 at 12:42 PM Andres Freund wrote:
> I like BMR better!
Thanks Andres and Peter. Here's a version like that. I hesitated
about BufMgrRelation instead, but neither name appears in code
currently and full words are better. In this version I also renamed
all the 'eb' variables
On Wed, Aug 9, 2023 at 08:35:21PM -0400, Bruce Momjian wrote:
> On Sat, Aug 5, 2023 at 04:08:47PM -0700, Noah Misch wrote:
> > > Author: Robert Haas
> > > 2022-08-25 [e3ce2de09] Allow grant-level control of role inheritance
> > > behavior.
> > > -->
> > >
> > >
> > >
> > > Allow GRANT to con
You can view the Postgres 16 release notes, with markup and links to our
docs, here:
https://momjian.us/pgsql_docs/release-16.html
--
Bruce Momjian https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important t
On 2023-08-17 10:57, Michael Paquier wrote:
On Thu, Aug 17, 2023 at 10:53:02AM +0900, Masahiro Ikeda wrote:
BTW, although I think this is outside the scope of this patch,
it might be a good idea to be able to add a description to the
API for custom wait events.
Somebody on twitter has raised t
On Wed, Aug 16, 2023 at 08:23:25AM -0700, Nathan Bossart wrote:
> Ah, it looks like this code used to treat fsync() errors as non-fatal, but
> it was changed in commit 1420617. I still find it a bit strange that some
> errors that prevent a file from being sync'd are non-fatal while others
> _are_
On Thu, Aug 17, 2023 at 10:53:02AM +0900, Masahiro Ikeda wrote:
> BTW, although I think this is outside the scope of this patch,
> it might be a good idea to be able to add a description to the
> API for custom wait events.
Somebody on twitter has raised this point. I am not sure that we need
to
Hi,
Thank you for creating the patch!
I think it is a very useful view as a user.
I will share some thoughts about the v6 patch.
1)
The regular expression needs to be changed in
generate-wait_event_types.pl.
I have compared the documentation with the output of the pg_wait_event
view and foun
> About pgbench exit on abort v4:
>
> Patch applies cleanly, compiles, local make check ok, doc looks ok.
>
> This looks ok to me.
I have tested the v4 patch with default_transaction_isolation =
'repeatable read'.
pgbench --exit-on-abort -N -p 11002 -c 10 -T 30 test
pgbench (17devel, server 15.
On Wed, Aug 16, 2023 at 12:01:01PM +0200, Tomas Vondra wrote:
> To me losing messages seems like a bad thing, but if the users are aware
> of it and are fine with it ... I'm simply arguing that if we conclude
> this is a durability bug, we should not leave it unfixed because it
> might have perform
On 2023-08-17 11:31:27 +1200, Thomas Munro wrote:
> On Thu, Aug 17, 2023 at 10:49 AM Andres Freund wrote:
> > On 2023-08-12 12:29:05 +1200, Thomas Munro wrote:
> > > Commit 31966b15 invented a way for functions dealing with relation
> > > extension to accept a Relation in online code and an SMgrRe
On Wed, Aug 16, 2023 at 05:02:09PM +0900, Michael Paquier wrote:
> if (kill(PostmasterPid, SIGUSR1) != 0)
> {
> -ereport(WARNING,
> -(errmsg("failed to send signal to postmaster: %m")));
> (void) unlink(PROMOTE_SIGNAL_FILE);
> -PG_RETURN_BOOL(false
On Wed, Aug 16, 2023 at 12:29:56PM -0700, Nathan Bossart wrote:
> I moved the definitions out to a separate file in v6.
Looks sensible seen from here.
This patch is missing the installation of protocol.h in
src/tools/msvc/Install.pm for MSVC. For pqcomm.h, we are doing that:
lcopy('src/include/l
On Wed, Aug 16, 2023 at 4:32 PM Thomas Munro wrote:
> Does anyone else want to object? Restating the case in brief: commit
> 31966b15's naming is short-sighted and likely to lead to a
> proliferation of similar things or a renaming in later releases.
+1 to proceeding with this change.
--
Peter
On Thu, Aug 17, 2023 at 10:49 AM Andres Freund wrote:
> On 2023-08-12 12:29:05 +1200, Thomas Munro wrote:
> > Commit 31966b15 invented a way for functions dealing with relation
> > extension to accept a Relation in online code and an SMgrRelation in
> > recovery code (instead of using the earlier
On 8/15/23 15:39, Alvaro Herrera wrote:
On 2023-Aug-16, Michael Paquier wrote:
Personally I think backpatching 28b5726 has a really low risk of
breaking anything.
I agree about the low-risk argument, though. This is just new code.
Here's a way to think about it. If 16.1 was already out, w
On Wed, Aug 16, 2023 at 11:18 PM Antonin Houska wrote:
> I try to understand this patch (commit 5ffb7c7750) because I use condition
> variable in an extension. One particular problem occured to me, please
> consider:
>
> ConditionVariableSleep() gets interrupted, so AbortTransaction() calls
> Cond
On 2023-08-16 13:15:46 +0200, Alvaro Herrera wrote:
> Since the wins from this patch were replicated and it has been pushed, I
> understand that this open item can be marked as closed, so I've done
> that.
Thanks!
Hi,
On 2023-08-12 12:29:05 +1200, Thomas Munro wrote:
> Commit 31966b15 invented a way for functions dealing with relation
> extension to accept a Relation in online code and an SMgrRelation in
> recovery code (instead of using the earlier FakeRelcacheEntry
> concept). It seems highly likely that
On Wed, Aug 16, 2023 at 6:27 AM Shaun Thomas
wrote:
>
> > We could do something like a LOG "connection: method=%s user=%s
> > (%s:%d)", without the "authenticated" and "identity" terms from
> > set_authn_id(). Just to drop an idea.
>
> That would be my inclination as well. Heck, just slap a log m
On Tue, 2023-08-15 at 13:04 -0400, Robert Haas wrote:
> I suspect that dodging the GUC stack machinery is not a very good
> idea. The timing of when TRY/CATCH blocks are called is different
> from
> when subtransactions are aborted, and that distinction has messed me
> up more than once when trying
On Tue, Aug 15, 2023 at 1:31 PM Nathan Bossart wrote:
> Should we add those? Patch attached.
I think that that makes sense. I just don't want to normalize updating
.git-blame-ignore-revs very frequently. (Actually, it's more like I
don't want to normalize any scheme that makes updating the ignor
On Wed, Aug 16, 2023 at 09:29:10PM +0200, Michail Nikolaev wrote:
> As answer: probably we need to change
> "If we know that we're holding ProcArrayLock exclusively, we don't
> need the read barrier."
> to
> "If we're removing xid, we don't need the read barrier because only
> the startup process c
Hi,
The date for PostgreSQL 16 Release Candidate 1 (RC1) is August 31, 2023.
Please ensure all open items[1] are completed and committed before
August 26, 2023 12:00 UTC.
This means the current target date for the PostgreSQL 16 GA release is
September 14, 2023. While this date could change i
On Tue, Aug 15, 2023 at 11:40:07PM +0200, Alvaro Herrera wrote:
> On 2023-Aug-16, Michael Paquier wrote:
>
>> On Wed, Aug 16, 2023 at 06:25:09AM +0900, Tatsuo Ishii wrote:
>> > Currently pqcomm.h needs c.h which is not problem for Pgpool-II. But
>> > what about other middleware?
>>
>> Why do you
Hello, good question!
Thanks for your edits.
As answer: probably we need to change
"If we know that we're holding ProcArrayLock exclusively, we don't
need the read barrier."
to
"If we're removing xid, we don't need the read barrier because only
the startup process can remove and add xids to Known
On Wed, Aug 16, 2023 at 05:30:59PM +0200, Michail Nikolaev wrote:
> Updated version (with read barriers is attached).
Thanks for the updated patch. I've attached v4 in which I've made a number
of cosmetic edits.
> I'll think more, but can't find something wrong here so far.
IIUC this memory bar
On Wed, 2023-08-16 at 08:51 +0200, Peter Eisentraut wrote:
> On 12.08.23 04:35, Jeff Davis wrote:
> > The attached patch implements a new SEARCH clause for CREATE
> > FUNCTION.
> > The SEARCH clause controls the search_path used when executing
> > functions that were created without a SET clause.
>
On Wed, Aug 16, 2023 at 2:28 PM Andy Fan wrote:
>
> update with the correct patch..
regression=# select proname, pg_catalog.pg_get_function_arguments(oid)
from pg_proc
where proname = 'jsonb_extract_path_type';
proname | pg_get_function_arguments
Hello!
Updated version (with read barriers is attached).
> One remaining question I have is whether it is okay if we see an updated value
> for one of the head/tail variables but not the other. It looks like the
> tail variable is only updated with ProcArrayLock held exclusively, which
> IIUC wo
On Wed, Aug 16, 2023 at 08:17:05AM -0700, Nathan Bossart wrote:
> On Wed, Aug 16, 2023 at 08:10:10AM +0900, Michael Paquier wrote:
>> + pg_log_error("could not synchronize file system for file \"%s\":
>> %m", path);
>> + (void) close(fd);
>> + exit(EXIT_FAILURE);
>>
>> walkdir()
Thanks for taking a look.
On Wed, Aug 16, 2023 at 08:10:10AM +0900, Michael Paquier wrote:
> On Tue, Aug 08, 2023 at 01:06:06PM -0700, Nathan Bossart wrote:
>> I ran a couple of tests for pg_upgrade with 100k tables (created using the
>> script here [0]) in order to demonstrate the potential benef
On Wed, Aug 16, 2023 at 8:55 AM Peter Eisentraut
wrote:
> This warning comes from parse_expr.c transformJsonValueExpr() and is
> triggered for example by the following test case:
>
> SELECT JSON_OBJECT('foo': NULL::json FORMAT JSON);
> WARNING: FORMAT JSON has no effect for json and jsonb types
On 16.08.23 09:34, Zhang Mingli wrote:
The Chinese words there are ok, but the `Unix-domian` should be
`Unix-domain`.
fixed, thanks
On Wed, Aug 16, 2023 at 10:35:27AM +0700, John Naylor wrote:
> ```
> *ptr = '\0';
>
> do
> ```
>
> to
>
> ```
> *ptr = '\0';
> do
> ```
Oh, I misunderstood. I thought you meant that there might be a whitespace
change on that line, not the surrounding ones. This is fixed in v6.
> Now I'm stru
Hi Etsuro,
Thanks for the response!
> Maybe we could do so by leaving to extensions the decision whether
> they replace joins with pseudoconstant clauses, but I am not sure that
> that is a good idea, because that would require the authors to modify
> and recompile their extensions to fix the is
This warning comes from parse_expr.c transformJsonValueExpr() and is
triggered for example by the following test case:
SELECT JSON_OBJECT('foo': NULL::json FORMAT JSON);
WARNING: FORMAT JSON has no effect for json and jsonb types
But I don't see anything in the SQL standard that would require
On 09.08.23 04:50, Peter Smith wrote:
On Tue, Aug 8, 2023 at 6:52 PM Amit Kapila wrote:
On Tue, Aug 8, 2023 at 1:50 PM Peter Eisentraut wrote:
This patch added the following error message:
errdetail_plural("Subscribed publication %s is subscribing to other
publications.",
"Subscribed publi
> We could do something like a LOG "connection: method=%s user=%s
> (%s:%d)", without the "authenticated" and "identity" terms from
> set_authn_id(). Just to drop an idea.
That would be my inclination as well. Heck, just slap a log message
right in the specific case statements that don't have act
On Wed, Aug 16, 2023 at 01:43:35PM +0200, Drouvot, Bertrand wrote:
> Yeah, agree, done that way in v6 (also added a test in 001_worker_spi.pl
> to ensure that "worker_spi_main" is reported in pg_wait_event).
-typedef struct WaitEventExtensionEntryByName
-{
- charwait_event_name[NAMEDATAL
Hi,
On 8/16/23 8:22 AM, Michael Paquier wrote:
On Wed, Aug 16, 2023 at 07:04:53AM +0200, Drouvot, Bertrand wrote:
I'd prefer the singular form. There is a lot of places where it's already used
(pg_database, pg_user, pg_namespace...to name a few) and it looks like that
using
the plural form are
On Wednesday, August 16, 2023 6:25 PM Kuroda, Hayato/黒田 隼人 wrote:
>
> Dear hackers,
>
> > > > It was primarily for upgrade purposes only. So, as we can't see a
> > > > good reason
> > to
> > > > go via pg_dump let's do it in upgrade unless someone thinks otherwise.
> > >
> > > Removed the new opt
Thomas Munro wrote:
> On Tue, Aug 15, 2023 at 2:23 AM Tomas Vondra
> wrote:
> > I'm not familiar with the condition variable code enough to have an
> > opinion, but the patch seems to resolve the issue for me - I can no
> > longer reproduce the high CPU usage.
>
> Thanks, pushed.
I try to unde
Hello,
On 2023-Aug-12, Andres Freund wrote:
> On 2023-08-08 12:45:05 +0900, Masahiko Sawada wrote:
> > > Any chance you could your benchmark? I don't see as much of a regression
> > > vs 16
> > > as you...
> >
> > Sure. The results are promising for me too:
> >
> > nclients = 1, execution tim
On Tue, Aug 15, 2023 at 6:53 PM John Naylor
wrote:
>
> On Tue, Aug 15, 2023 at 9:34 AM Masahiko Sawada
wrote:
>
> > BTW cfbot reported that some regression tests failed due to OOM. I've
> > attached the patch to fix it.
>
> Seems worth doing now rather than later, so added this and squashed most
Dear hackers,
> > > It was primarily for upgrade purposes only. So, as we can't see a good
> > > reason
> to
> > > go via pg_dump let's do it in upgrade unless someone thinks otherwise.
> >
> > Removed the new option in pg_dump and modified the pg_upgrade
> > directly use the slot info to restore
On Mon, Jul 3, 2023 at 5:15 PM David Rowley wrote:
>
> On Fri, 30 Jun 2023 at 18:45, John Naylor
wrote:
> I looked over your patch and don't see anything to report aside from
> the unfinished/undecided part around the tiebreak function for
> tuplesort_begin_index_hash().
I went ahead and added
I have two small patches that you can integrate into your patch set:
The first just changes the punctuation of "Not-null constraints" in the
psql output to match what the documentation mostly uses.
The second has some changes to ddl.sgml to reflect that not-null
constraints are now named and
On 2023-Aug-16, Erik Rijkers wrote:
> Hello,
>
> The following surprised me enough to think it might be a bug:
> (17devel)
>
> select
>regexp_replace('Abc Def'
> , '([a-z]) ([A-Z])'
> , '\1 ' || lower('\2') );
>
> regexp_replace
>
> Abc Def
What's happening here is t
On 8/16/23 06:13, Andres Freund wrote:
> Hi,
>
> On 2023-08-16 03:20:53 +0200, Tomas Vondra wrote:
>> On 8/16/23 02:33, Andres Freund wrote:
>>> Hi,
>>>
>>> On 2023-08-16 06:58:56 +0900, Michael Paquier wrote:
On Tue, Aug 15, 2023 at 11:37:32AM +0200, Tomas Vondra wrote:
> Shouldn't th
Hi Richard,
On Wed, Aug 16, 2023 at 9:41 AM Richard Guo wrote:
> On Tue, Aug 15, 2023 at 7:50 PM Etsuro Fujita wrote:
>> So we should have modified the second one as well? Attached is a
>> small patch for that.
> Agreed, nice catch! +1 to the patch.
Thanks for looking!
Best regards,
Etsuro
Hi,
On Tue, Aug 15, 2023 at 11:02 PM Önder Kalacı wrote:
> The commit[1] seems to break some queries in Citus[2], which is an extension
> which relies on set_join_pathlist_hook.
>
> Although the comment says /*Finally, give extensions a chance to manipulate
> the path list.*/ we use it to extr
On Thu, Aug 10, 2023 at 5:06 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
> On Tue, Jul 4, 2023 at 9:45 AM Daniel Gustafsson wrote:
>
>> As there is no new patch submitted I will go ahead and do that, please
>> feel
>> free to resubmit when there is renewed interest in wor
Hi hackers,
Earlier this year I proposed a small change for the pg_stat_subscription view:
--
...it would be very useful to have an additional "kind" attribute for
this view. This will save the user from needing to do mental
gymnastics every time just to recognise what kind of process they ar
On Wed, Mar 8, 2023 at 2:19 PM Michael Paquier wrote:
>
> On Fri, Mar 03, 2023 at 09:37:27AM +0900, Michael Paquier wrote:
> > Thanks for double-checking, applied 0001 to finish this part of the
> > work. I am attaching the remaining bits as of the attached, combined
> > into a single patch.
>
>
Hi Erik,
The regexp doesn't match your string because you're not allowing for
any repeat characters, try adding a '+'.
On Wed, 16 Aug 2023 at 09:07, Erik Rijkers wrote:
>
> Hello,
>
> The following surprised me enough to think it might be a bug:
> (17devel)
>
> select
> regexp_replace('Abc D
Hello,
The following surprised me enough to think it might be a bug:
(17devel)
select
regexp_replace('Abc Def'
, '([a-z]) ([A-Z])'
, '\1 ' || lower('\2') );
regexp_replace
Abc Def
(1 row)
-- 'Abc Def' got
-- 'Abc def' expected
What do you think?
Thanks,
Erik Rijker
Hello Nathan,
I'm unclear about what variety of scripts that could be provided given the
tables made available with pgbench. ISTM that other scenari would involve
both an initialization and associated scripts, and any proposal would be
bared because it would open the door to anything.
Why's
On 15.08.23 11:57, Dean Rasheed wrote:
Something else I noticed when reading the SQL standard is that a
user-defined CHECK (col IS NOT NULL) constraint should be recognised
by the system as also making the column not null (setting its
"nullability characteristic" to "known not nullable"). I think
On Thu, Jun 08, 2023 at 04:53:50PM +0530, Ashutosh Sharma wrote:
> Thanks for sharing your thoughts, Laurenz and Fujii-san. I've prepared
> a patch that makes pg_promote error out if it couldn't send SIGUSR1 to
> the postmaster or if the postmaster died in the middle of standby
> promotion. PFA. Pl
On Tue, Aug 15, 2023 at 09:16:53PM -0700, Andres Freund wrote:
> To be clear: I don't just object to backpatching, I also object to making
> existing invocations flush WAL in HEAD. I do not at all object to adding a
> parameter that indicates flushing, or a separate function to do so. The latter
>
Hi, The Chinese words there are ok, but the `Unix-domian` should be `Unix-domain`.
v1-0001-Fix-typo-src-interfaces-libpq-po-zh_CN.po.patch
Description: Binary data
Zhang MingliHashData https://www.hashdata.xyz
Hello pgsql-hackers,
After doing some more debugging on the matter, I believe this issue might be a
minor regression from commit 5332b8cec541. Prior to that commit, the archiver
process when first started on a previously promoted primary would have all the
timeline history files marked as ready fo
77 matches
Mail list logo
