RE: cleanup patches for incremental backup

Hi, Thank you for developing the new tool. I have attached a patch that corrects the spelling of the --individual option in the SGML file. Regards, Noriyoshi Shinoda -Original Message- From: Robert Haas Sent: Friday, January 12, 2024 3:13 AM To: PostgreSQL Hackers ; Jakub Wartak

RE: remaining sql/json patches

Hi, Thank you for developing such a great feature. The attached patch formats the documentation like any other function definition: - Added right parenthesis to json function calls. - Added to json functions. - Added a space to the 'expression' part of the json_scalar function. - Added a space

RE: add \dpS to psq [16beta1]

Hi, Thank you for developing a good feature. I found while testing PostgreSQL 16 Beta 1 that the output of the \? metacommand did not include \dS, \dpS. The attached patch changes the output of the \? meta command to: Current output psql=# \? \z [PATTERN] same as \dp \dp

RE: [16Beta1][doc] pgstat: Track time of the last scan of a relation

Hi, David. > I've now pushed this change. Thank you so much. -Original Message- From: David Rowley Sent: Monday, June 5, 2023 2:37 PM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: PostgreSQL-development ; dp...@pgadmin.org; and...@anarazel.de; br...@momjian.us; v...@postgresfriends.

RE: [16Beta1][doc] pgstat: Track time of the last scan of a relation

- From: David Rowley Sent: Wednesday, May 31, 2023 3:14 PM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: PostgreSQL-development ; dp...@pgadmin.org; and...@anarazel.de; br...@momjian.us; v...@postgresfriends.org Subject: Re: [16Beta1][doc] pgstat: Track time of the last scan of a relation On W

[16Beta1][doc] pgstat: Track time of the last scan of a relation

Hi, hackers. PostgreSQL 16 Beta1, added last access time to pg_stat_all_tables and pg_stat_all_indexes views by this patch [1]. According to the documentation [2], the data type of the columns added to these views is 'timestamptz'. However, columns of the same data type in

[16Beta1][doc] Add BackendType for standalone backends

Hi, hackers. In PostgreSQL 16 Beta 1, standalone backend was added to the backend type by this patch [1]. I think this patch will change the value of backend_type column in the pg_stat_activity view, but it's not explained in the documentation. The attached patch fixes monitoring.sgml. [1] Add

RE: running logical replication as the subscription owner

Hi hackers, Thank you for developing a great feature. The following commit added a column to the pg_subscription catalog. https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=482675987bcdffb390ae735cfd5f34b485ae97c6

RE: run pgindent on a regular basis / scripted manner

Hi, I tried the committed pgindent. The attached small patch changes spaces in the usage message to tabs. Options other than --commit start with a tab. Regards, Noriyoshi Shinoda From: Andrew Dunstan Sent: Thursday, February 9, 2023 7:10 AM To: Jelte Fennema Cc: Robert Haas ; Tom Lane ; Justin

RE: Perform streaming logical transactions by background workers and parallel apply

Regards, Noriyoshi Shinoda -Original Message- From: houzj.f...@fujitsu.com Sent: Monday, January 9, 2023 7:15 PM To: Shinoda, Noriyoshi (PN Japan FSIP) ; Amit Kapila Cc: Masahiko Sawada ; wangw.f...@fujitsu.com; Peter Smith ; shiy.f...@fujitsu.com; PostgreSQL Hackers ; Dilip Kumar Su

RE: Perform streaming logical transactions by background workers and parallel apply

Hi, Thanks for the great new feature. Applied patches include adding wait events LogicalParallelApplyMain, LogicalParallelApplyStateChange. However, it seems that monitoring.sgml only contains descriptions for pg_locks. The attached patch adds relevant wait event information. Please update if

RE: pg_upgrade: Make testing different transfer modes easier

Hi, With the addition of --copy option, pg_upgrade now has three possible transfer mode options. Currently, an error does not occur even if multiple transfer modes are specified. For example, we can also run "pg_upgrade --link --copy --clone" command. As discussed in Horiguchi-san's previous

RE: Improve logging when using Huge Pages

behavior as huge_pages=try in PostgreSQL. Regards, Noriyoshi Shinoda -Original Message- From: Thomas Munro Sent: Thursday, November 3, 2022 10:10 AM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: Jacob Champion ; Masahiko Sawada ; Fujii Masao ; Justin Pryzby ; PostgreSQL-development

[PG15 Doc] remove "tty" connect string from manual

Hello, hackers. As of PostgreSQL 14, "tty" in the libpq connection string has already been removed with the commit below. https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=14d9b37607ad30c3848ea0f2955a78436eff1268 But

RE: Improve logging when using Huge Pages

oposed this time and consider it again. Regards, Noriyoshi Shinoda -Original Message- From: Jacob Champion Sent: Tuesday, August 2, 2022 5:45 AM To: Shinoda, Noriyoshi (PN Japan FSIP) ; Masahiko Sawada ; Fujii Masao Cc: Justin Pryzby ; PostgreSQL-development ; Julien Rouhaud ; To

RE: Add --{no-,}bypassrls flags to createuser

Hi, Thanks to the developers and reviewers. The attached small patch fixes the message in "createuser --help" command. The patch has changed to specify a time stamp for the --valid-for option. I don't think the SGML description needs to be modified. Regards, Noriyoshi Shinoda -Original

RE: PG15 beta1 fix pg_stats_ext/pg_stats_ext_exprs view manual

Thanks for your comment. sorry for the late reply. I hope it will be fixed during the period of PostgreSQL 15 Beta. Regards, Noriyoshi Shinoda -Original Message- From: Justin Pryzby Sent: Tuesday, June 14, 2022 11:30 PM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: pgsql-hack

PG15 beta1 fix pg_stats_ext/pg_stats_ext_exprs view manual

Hi hackers, Thanks to all the developers. The attached patch updates the manual for the pg_stats_ext and pg_stats_ext_exprs view. The current pg_stats_ext/pg_stats_ext_exprs view manual are missing the inherited column. This column was added at the same time as the stxdinherit column in the

PG15 beta1 fix pg_database view document

Hi hackers, Thanks to all the developers. The attached patch updates the manual for the pg_database catalog. The current pg_database view definition is missing the datlocprovider column. The attached patch adds this column info. https://www.postgresql.org/docs/15/catalog-pg-database.html

PG15 beta1 fix pg_stat_recovery_prefetch view manual

Hi hackers, Thanks to all the developers. The attached patch updates the manual for the pg_stat_recovery_prefetch view. The current pg_stat_recovery_prefetch view definition is missing the stats_reset column. The attached patch adds information in the stats_reset column.

RE: PG15 beta1 fix pg_stat_statements view document

Hi, Thank you for your comment. I attached the fixed patch. -Original Message- From: Michael Paquier Sent: Saturday, May 21, 2022 12:33 PM To: Nathan Bossart Cc: Shinoda, Noriyoshi (PN Japan FSIP) ; PostgreSQL-development ; mag...@hagander.net Subject: Re: PG15 beta1 fix

PG15 beta1 fix pg_stat_statements view document

Hi hackers, The attached patch modifies the pg_stat_statements view documentation updated in PostgreSQL 15 Beta 1. The data type of the following columns in the pg_stat_statements view is bigint in the current document, but it is actually double precision. jit_generation_time

RE: Documentation issue with pg_stat_recovery_prefetch

Hi, Thank you for developing the new feature. The pg_stat_recovery_prefetch view documentation doesn't seem to have a description of the stats_reset column. The attached small patch adds a description of the stats_reset column. Regards, Noriyoshi Shinoda -Original Message- From:

RE: WIP: WAL prefetch (another approach)

Hi, Thank you for your reply. I missed the message, sorry. Regards, Noriyoshi Shinoda -Original Message- From: Thomas Munro Sent: Tuesday, April 12, 2022 6:28 PM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: Justin Pryzby ; Tomas Vondra ; Stephen Frost ; Andres Freund ; Jakub Wartak

RE: WIP: WAL prefetch (another approach)

Hi, Thank you for developing the great feature. I tested this feature and checked the documentation. Currently, the documentation for the pg_stat_prefetch_recovery view is included in the description for the pg_stat_subscription view.

RE: Expose JIT counters/timing in pg_stat_statements

Hi, thank you for the great features. The attached small patch changes the data type in the document. The following columns are actually double precision but bigint in the docs. jit_generation_time jit_inlining_time jit_optimization_time jit_emission_count Regards, Noriyoshi Shinoda From:

RE: Column Filtering in Logical Replication

Hello, The 'prattrs' column has been added to the pg_publication_rel catalog, but the current commit to catalog.sgml seems to have added it to pg_publication_namespace. The attached patch fixes this. Regards, Noriyoshi Shinoda -Original Message- From: Tomas Vondra Sent: Saturday,

RE: ICU for global collation

Hi, Thank you to all the developers. I found that the description of the pg_database.daticulocale column was not written in the documentation. The attached small patch adds a description of the daticulocale column to catalogs.sgml. Regards, Noriyoshi Shinoda -Original Message- From:

RE: row filtering for logical replication

> You can give it for multiple tables. See below as an example: Thank you very much. I understood. Regards, Noriyoshi Shinoda -Original Message- From: Amit Kapila Sent: Thursday, February 24, 2022 11:25 AM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: Euler Taveira ; houz

RE: row filtering for logical replication

Hi, Thank you for developing of the great feature. If multiple tables are specified when creating a PUBLICATION, is it supposed that the WHERE clause condition is given to only one table? I attached the operation log below. --- operation log --- postgres=> CREATE TABLE data1(c1 INT PRIMARY

RE: refactoring basebackup.c

Hi, Hackers. Thank you for developing a great feature. The current help message shown below does not seem to be able to specify the 'client-' or 'server-' for lz4 compression. --compress = {[{client, server}-]gzip, lz4, none}[:LEVEL] The attached small patch fixes the help message as follows:

RE: refactoring basebackup.c

Hi, Thank you for committing a great feature. I have tested the committed features. The attached small patch fixes the output of the --help message. In the previous commit, only gzip and none were output, but in the attached patch, client-gzip and server-gzip are added. Regards, Noriyoshi

RE: Improve logging when using Huge Pages

this specification. Regards, Noriyoshi Shinoda -Original Message- From: Masahiko Sawada [mailto:sawada.m...@gmail.com] Sent: Thursday, November 11, 2021 2:45 PM To: Fujii Masao Cc: Justin Pryzby ; Shinoda, Noriyoshi (PN Japan FSIP) ; PostgreSQL-development ; Julien Rouhaud ; Tom Lane

RE: Improve logging when using Huge Pages

...@oss.nttdata.com] Sent: Tuesday, November 2, 2021 11:35 PM To: Shinoda, Noriyoshi (PN Japan FSIP) ; pgsql-hack...@postgresql.org; Masahiko Sawada Cc: rjuju...@gmail.com; t...@sss.pgh.pa.us; Kyotaro Horiguchi ; Justin Pryzby Subject: Re: Improve logging when using Huge Pages On 2021/11/02

RE: Improve logging when using Huge Pages

d uses IsPostmasterEnvironment to suppress the output message. Regards, Noriyoshi Shinoda -Original Message- From: Fujii Masao [mailto:masao.fu...@oss.nttdata.com] Sent: Tuesday, November 2, 2021 1:25 AM To: Masahiko Sawada ; Shinoda, Noriyoshi (PN Japan FSIP) Cc: pgsql-hack...@postgresql.org;

RE: Improve logging when using Huge Pages

, October 22, 2021 11:38 AM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: masao.fu...@oss.nttdata.com; pgsql-hack...@postgresql.org; rjuju...@gmail.com; t...@sss.pgh.pa.us; Kyotaro Horiguchi Subject: Re: Improve logging when using Huge Pages + ereport(LOG, (errmsg("Anonymous s

RE: Improve logging when using Huge Pages

Cc: masao.fu...@oss.nttdata.com; Shinoda, Noriyoshi (PN Japan FSIP) ; pgsql-hack...@postgresql.org; rjuju...@gmail.com; t...@sss.pgh.pa.us Subject: Re: Improve logging when using Huge Pages At Tue, 21 Sep 2021 19:23:22 -0500, Justin Pryzby wrote in > On Wed, Sep 22, 2021 at 02:03:11AM +0900,

RE: Improve logging when using Huge Pages

mentation. Regards, Noriyoshi Shinoda -Original Message- From: Kyotaro Horiguchi [mailto:horikyota@gmail.com] Sent: Friday, September 17, 2021 1:15 PM To: masao.fu...@oss.nttdata.com Cc: pry...@telsasoft.com; Shinoda, Noriyoshi (PN Japan FSIP) ; pgsql-hack...@postgresql.org; rju

RE: Improve logging when using Huge Pages

Regards, Noriyoshi Shinoda -Original Message- From: Kyotaro Horiguchi [mailto:horikyota@gmail.com] Sent: Wednesday, September 8, 2021 11:18 AM To: pry...@telsasoft.com Cc: masao.fu...@oss.nttdata.com; Shinoda, Noriyoshi (PN Japan FSIP) ; pgsql-hack...@postgresql.org; rjuju...@gmail.co

RE: Improve logging when using Huge Pages

] https://www.postgresql.org/message-id/20210903.141206.103927759882272221.hor Regards, Noriyoshi Shinoda -Original Message- From: Fujii Masao [mailto:masao.fu...@oss.nttdata.com] Sent: Saturday, September 4, 2021 1:36 AM To: Tom Lane Cc: Kyotaro Horiguchi ; Shinoda, Noriyoshi (PN Japan FSIP

RE: New predefined roles- 'pg_read/write_all_data'

Thank you for your quick response. I understood the specifications from your explanation. Regards, Noriyoshi Shinoda From: Stephen Frost [mailto:sfr...@snowman.net] Sent: Sunday, September 5, 2021 8:50 PM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: Anastasia Lubennikova ; Michael Banck

RE: New predefined roles- 'pg_read/write_all_data'

Hi hackers, I have tested this new feature with PostgreSQL 14 Beta 3 environment. I created a user granted with pg_write_all_data role and executed UPDATE and DELETE statements on tables owned by other users. If there is no WHERE clause, it can be executed as expected, but if the WHERE clause

RE: Improve logging when using Huge Pages

ards, Noriyoshi Shinoda -Original Message- From: Fujii Masao [mailto:masao.fu...@oss.nttdata.com] Sent: Wednesday, September 1, 2021 2:06 AM To: Julien Rouhaud ; Shinoda, Noriyoshi (PN Japan FSIP) Cc: pgsql-hack...@postgresql.org Subject: Re: Improve logging when using Huge Pages On 2

Improve logging when using Huge Pages

Hi Hackers, In the current version, when GUC huge_pages=try, which is the default setting, no log is output regardless of the success or failure of the HugePages acquisition. If you want to output logs, you need to set log_min_messages=DEBUG3, but it will output a huge amount of extra logs.

RE: WIP: WAL prefetch (another approach)

Hi, Thank you for developing a great feature. I tested this feature and checked the documentation. Currently, the documentation for the pg_stat_prefetch_recovery view is included in the description for the pg_stat_subscription view.

RE: list of extended statistics on psql

Hi, hackers. I tested this committed feature. It doesn't seem to be available to non-superusers due to the inability to access pg_statistics_ext_data. Is this the expected behavior? --- operation --- postgres=> CREATE STATISTICS stat1_data1 ON c1, c2 FROM data1; CREATE STATISTICS postgres=>

RE: pgsql: Add key management system

Hi, Thank you for developing a great feature. I tested it immediately. The attached patch changes the value of the --file-encryption-keylen option of the initdb command to mandatory. No value is currently required. I also changed the help message and the manual. Regards, Noriyoshi Shinoda

RE: Tab complete for CREATE OR REPLACE TRIGGER statement

day, November 18, 2020 2:07 PM To: Tom Lane Cc: Shinoda, Noriyoshi (PN Japan FSI) ; pgsql-hackers@lists.postgresql.org Subject: Re: Tab complete for CREATE OR REPLACE TRIGGER statement On Mon, Nov 16, 2020 at 10:14:10PM -0500, Tom Lane wrote: > Michael Paquier writes: >> I

Tab complete for CREATE OR REPLACE TRIGGER statement

Hi, Hackers. Yesterday, OR REPLACE clause was provided to the CREATE TRIGGER statement, so I wrote a patch for tab completion for the psql command. TRIGGER adds tab completion to the CREATE OR REPLACE statement, and the CREATE TRIGGER and CREATE OR REPLACE TRIGGER statements are completed in

RE: Online checksums verification in the backend

Hi, I have tested this great feature in the latest commit environment on Red Hat Enterprise Linux 7.8. I modified a few blocks in a relation file to raise a checksum error. When I executed the pg_relation_check_pages function, the backend terminated abnormally. The attached file is the

RE: Resetting spilled txn statistics in pg_stat_replication

uesday, October 20, 2020 9:24 PM To: Amit Kapila Cc: Shinoda, Noriyoshi (PN Japan A Delivery) ; Dilip Kumar ; Magnus Hagander ; Tomas Vondra ; PostgreSQL Hackers ; Ajin Cherian Subject: Re: Resetting spilled txn statistics in pg_stat_replication On Tue, 20 Oct 2020 at 20:11, Amit Kapila

RE: Resetting spilled txn statistics in pg_stat_replication

i Shinoda -Original Message- From: Amit Kapila [mailto:amit.kapil...@gmail.com] Sent: Thursday, October 15, 2020 5:52 PM To: Masahiko Sawada Cc: Shinoda, Noriyoshi (PN Japan A Delivery) ; Dilip Kumar ; Magnus Hagander ; Tomas Vondra ; PostgreSQL Hackers ; Ajin Cherian Subject: Re: Resetting sp

RE: Resetting spilled txn statistics in pg_stat_replication

nges only the column names and macros. Regards, Noriyoshi Shinoda -Original Message- From: Masahiko Sawada [mailto:masahiko.saw...@2ndquadrant.com] Sent: Tuesday, October 13, 2020 9:11 AM To: Shinoda, Noriyoshi (PN Japan A Delivery) Cc: Amit Kapila ; Dilip Kumar ; Magnus Hagander ; Tom

RE: Resetting spilled txn statistics in pg_stat_replication

, Noriyoshi (PN Japan A Delivery) Cc: Amit Kapila ; Dilip Kumar ; Magnus Hagander ; Tomas Vondra ; PostgreSQL Hackers ; Ajin Cherian Subject: Re: Resetting spilled txn statistics in pg_stat_replication On Mon, 12 Oct 2020 at 18:29, Shinoda, Noriyoshi (PN Japan A Delivery) wrote: > > Hi, tha

RE: Resetting spilled txn statistics in pg_stat_replication

Hi, thank you for the awesome feature. As it may have been discussed, I think the 'name' column in pg_stat_replication_slots is more consistent with the column name and data type matched to the pg_replication_slots catalog. The attached patch changes the name and data type of the 'name' column

RE: pg_validatebackup -> pg_verifybackup?

Hi, Sorry this email is not a discussion about word selection. Since part of the manual had left pg_validatebackup in commit dbc60c5593f26dc777a3be032bff4fb4eab1ddd1. I've attached a patch to fix this. Regards, Noriyoshi Shinoda -Original Message- From: Tom Lane

RE: SLRU statistics

Hi, Thank you for developing great features. The attached patch is a small fix to the committed documentation for the data type name of blks_hit column. Best regards, Noriyoshi Shinoda -Original Message- From: Tomas Vondra [mailto:tomas.von...@2ndquadrant.com] Sent: Thursday, April

RE: Multivariate MCV list vs. statistics target

agree? Thank you for your comment. I agree with the text you suggested. Regards, Noriyoshi Shinoda -Original Message- From: Tomas Vondra [mailto:tomas.von...@2ndquadrant.com] Sent: Wednesday, March 18, 2020 9:36 PM To: Shinoda, Noriyoshi (PN Japan A Delivery) Cc: Alvaro Herrera ; Thoma

RE: Multivariate MCV list vs. statistics target

Hello, I found a missing column description in the pg_statistic_ext catalog document for this new feature. The attached patch adds a description of the 'stxstattarget' column to pg_statistic_ext catalog's document. If there is a better explanation, please correct it. Regards, Noriyoshi

RE: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side

Hi, Thank you for developing good features. The attached patch is a small fix to the committed documentation. This patch fixes the description literal for the backup_streamed column. Regards, Noriyoshi Shinoda -Original Message- From: Fujii Masao [mailto:masao.fu...@oss.nttdata.com]

RE: psql small improvement patch

Thank you very much for your comments. I seem to have thought easily. I will reconsider. Regards. -Original Message- From: Mark Dilger [mailto:hornschnor...@gmail.com] Sent: Sunday, December 8, 2019 12:20 AM To: Shinoda, Noriyoshi (PN Japan A Delivery) ; pgsql-hackers

psql small improvement patch

Hi, Hackers. I propose a small improvement to the psql command. Currently, psql's help/quit/exit command needs to start from the first position of the prompt. For example, if you write a command after a space, the continuation prompt (PROMPT2) is displayed. --- postgres=> \set PROMPT2

RE: [DOC] Fix for the missing pg_stat_progress_cluster view phase column value

LUSTER statement is executed. When I read the table_relation_copy_for_cluster function, it seems to be a phase that is executed only during sorting. Regards, Noriyoshi Shinoda -Original Message- From: Kyotaro Horiguchi [mailto:horikyota@gmail.com] Sent: Monday, October 28, 2019 2:27

[DOC] Fix for the missing pg_stat_progress_cluster view phase column value

Hi, I found a missing column value in the pg_stat_progress_cluster view document. I read the src/backend/catalog/system_views.sql file, there seems to be a possibility that 'writing new heap' is output in the 'phase' column. The attached patch adds a description of the 'writing new heap' value

RE: REINDEX CONCURRENTLY 2.0

Hi hackers, I tried this great feature for partition index. The first time the REINDEX TABLE CONCURRENTLY statement is executed to the partition, then an error occurs. The second run succeeds but leaves an index with an INVALID status. I think this is not the desired behaviour. # TEST

RE: auto_explain: Include JIT output if applicable

:11 PM To: Shinoda, Noriyoshi (PN Japan GCS Delivery) Cc: Lukas Fittl ; Pg Hackers Subject: Re: auto_explain: Include JIT output if applicable Hi, On 2018-09-29 05:04:25 +, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: > I tried this feature. > I think that 'if (es->costs)' of

RE: auto_explain: Include JIT output if applicable

Hi, I tried this feature. I think that 'if (es->costs)' of the source code auto_explain.c will always be ‘true’. Because it is not changed after 'es-> cost = true' in NewExplainState () function several rows ago. So I attached a patch to delete this if statement. Regards, Noriyoshi Shinoda

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

noda -Original Message- From: Peter Eisentraut [mailto:peter.eisentr...@2ndquadrant.com] Sent: Friday, September 7, 2018 10:17 PM To: Shinoda, Noriyoshi (PN Japan GCS Delivery) ; fabriziome...@gmail.com; [pgdg] Robert Haas ; mich...@paquier.xyz Cc: Pgsql Hackers Subject: Re: [HACKERS] Prop

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

patch will change the behavior of official API PQconndefaults. Best Regards, Noriyoshi Shinoda -Original Message- From: Peter Eisentraut [mailto:peter.eisentr...@2ndquadrant.com] Sent: Friday, August 31, 2018 2:45 AM To: Shinoda, Noriyoshi (PN Japan GCS Delivery) ; fabriziome...@gmail.c

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

day, August 28, 2018 3:53 AM To: [pgdg] Robert Haas Cc: mich...@paquier.xyz; Shinoda, Noriyoshi (PN Japan GCS Delivery) ; Pgsql Hackers Subject: Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module On Mon, Aug 27, 2018 at 3:35 PM Robert Haas wrote: > > On Mon, Aug 27, 2018

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

urday, August 25, 2018 4:49 AM To: Shinoda, Noriyoshi (PN Japan GCS Delivery) Cc: pgsql-hack...@postgresql.org Subject: Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module On Fri, Aug 17, 2018 at 2:07 AM Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: The attached pa

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

Hi, Hackers. I updated the patch that I attached the other day. Added release of dynamically allocated memory and modified source according to coding rule. Regards, Noriyoshi Shinoda -- From: Shinoda, Noriyoshi (PN Japan GCS Delivery) Sent: Friday, August 17, 2018 3:07 PM To: pgsql-hack

[HACKERS] Proposal to add work_mem option to postgres_fdw module

Hello hackers, The attached patch adds a new option work_mem to postgres_fdw contrib module. Previously, it was impossible to change the setting of work_mem for remote session with connection by postgres_fdw. By adding this option to the CREATE SERVER statement, you can also change the

RE: Update comment in errcodes.txt correctly

hinoda -Original Message- From: Michael Paquier [mailto:mich...@paquier.xyz] Sent: Thursday, August 16, 2018 12:44 PM To: Shinoda, Noriyoshi (PN Japan GCS Delivery) Cc: pgsql-hack...@postgresql.org Subject: Re: Update comment in errcodes.txt correctly On Thu, Aug 16, 2018 at 01:18:21AM +, S

Update comment in errcodes.txt correctly

Hi, Hackers, The attached small patch updates src/backend/utils/errcode.txt. In the comment of this file, a list of file names generated from this file is written. However, the file name of the 'errcodes.sgml' file is incorrect. The attached patch fixes the incorrect path of errcodes.sgml file

RE: WIP: Covering + unique indexes.

Hi! Thank you for your response. I think that it is good with your proposal. Regards, Noriyoshi Shinoda From: Alexander Korotkov [mailto:a.korot...@postgrespro.ru] Sent: Monday, April 9, 2018 11:22 PM To: Shinoda, Noriyoshi <noriyoshi.shin...@hpe.com> Cc: PostgreSQL Hackers <pgsq

RE: WIP: Covering + unique indexes.

Hi, I tested this feature and found a document shortage in the columns added to the pg_constraint catalog. The attached patch will add the description of the 'conincluding' column to the manual of the pg_constraint catalog. Regards, Noriyoshi Shinoda -Original Message- From: Teodor

RE: unique indexes on partitioned tables

Hi Álvaro, Thank you for your developing the new patch. I will continue testing. -Original Message- From: Alvaro Herrera [mailto:alvhe...@2ndquadrant.com] Sent: Tuesday, March 13, 2018 7:51 AM To: Shinoda, Noriyoshi <noriyoshi.shin...@hpe.com> Cc: Amit Langote <lan

RE: [HACKERS] Commitfest 2018-9 duplicate patch deletion request.

Thank you so much. -Original Message- From: David Steele [mailto:da...@pgmasters.net] Sent: Monday, March 12, 2018 10:24 PM To: Shinoda, Noriyoshi <noriyoshi.shin...@hpe.com>; pgsql-hackers <pgsql-hack...@postgresql.org> Subject: Re: [HACKERS] Commitfest 2018-9 duplicate pa

[HACKERS] Commitfest 2018-9 duplicate patch deletion request.

Dear Hackers, CFM Last week, I posted a patch to Commitfest 2018-9 which title is "[WIP] Document update for Logical Replication security". I do not know the reason, but the same content duplicated. Since I can not delete posts, would you please delete either one? Best regards, Noriyoshi

RE: unique indexes on partitioned tables

Hi. I tried this feature with the latest snapshot. When I executed the following SQL statement, multiple primary keys were created on the partition. Is this the intended behavior? -- test postgres=> CREATE TABLE part1(c1 INT PRIMARY KEY, c2 INT, c3 VARCHAR(10)) PARTITION BY RANGE(c1) ; CREATE

[WIP] Document update for Logical Replication security

Hi, Hackers, The attached patch adds the following information to the document on Logical Replication. About the requirement of connection role of Logical Replication, written in 31.7 of the manual is as follows. -- The role used for the replication connection must have the REPLICATION