Re: [PATCH v20] GSSAPI encryption support

2019-04-04 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > Kerberos tests are now failing for me (macOS). I'm seeing > > psql: error: could not connect to server: Over-size error packet sent by > the server. > not ok 3 - GSS encryption without auth > > # Failed test 'GSS

Re: [PATCH v20] GSSAPI encryption support

2019-04-04 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> Well, if the caller thinks what is being passed back is an int, > >> it will do a 32-to-64-bit widening, which is almost certainly > >> go

Re: [PATCH v20] GSSAPI encryption support

2019-04-04 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> I'm not very sure why the integer/pointer confusion in pgstat_bestart > >> doesn't cause hard crashes when using gss auth --- or does > &

Re: [PATCH v20] GSSAPI encryption support

2019-04-04 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > On Thu, Apr 4, 2019 at 05:20 Peter Eisentraut < > > peter.eisentr...@2ndquadrant.com> wrote: > >> Kerberos tests are now failing for me (macOS). > > > Interesting, they work loca

Re: [PATCH v20] GSSAPI encryption support

2019-04-04 Thread Stephen Frost
Greetings, On Thu, Apr 4, 2019 at 05:20 Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > Kerberos tests are now failing for me (macOS). I'm seeing > > psql: error: could not connect to server: Over-size error packet sent by > the server. > not ok 3 - GSS encryption without auth > >

Re: [PATCH v20] GSSAPI encryption support

2019-04-03 Thread Stephen Frost
Greetings, On Wed, Apr 3, 2019 at 22:02 Michael Paquier wrote: > On Wed, Apr 03, 2019 at 05:51:06PM -0400, Stephen Frost wrote: > > Thanks so much for pushing on it for so long, it’s a great feature to > have! > > Glad to see that the final result is using an API laye

Re: [PATCH v20] GSSAPI encryption support

2019-04-03 Thread Stephen Frost
Greetings Robbie, On Wed, Apr 3, 2019 at 17:47 Robbie Harwood wrote: > Stephen Frost writes: > > > On Wed, Apr 3, 2019 at 16:01 Andres Freund wrote: > >> On 2019-04-03 10:43:33 -0400, Stephen Frost wrote: > >> > >>> I'll push this in a few hours unle

Re: [PATCH v20] GSSAPI encryption support

2019-04-03 Thread Stephen Frost
Greetings, On Wed, Apr 3, 2019 at 16:01 Andres Freund wrote: > Hi, > > On 2019-04-03 10:43:33 -0400, Stephen Frost wrote: > > I'll push this in a few hours unless there's anything else. > > The CF entry for this is still open - is there any work missing? Just >

Re: Concurrency bug with vacuum full (cluster) and toast

2019-04-03 Thread Stephen Frost
Greetings, * Justin Pryzby (pry...@telsasoft.com) wrote: > On Fri, Mar 22, 2019 at 02:27:07PM -0400, Robert Haas wrote: > > On Tue, Mar 19, 2019 at 1:37 PM Alexander Korotkov > > wrote: > > > Thank you for pointing, but none of the threads you pointed describe > > > this exact problem. Now I

Re: [PATCH v20] GSSAPI encryption support

2019-04-03 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Wed, Apr 3, 2019 at 12:22 AM Joe Conway wrote: > > On 4/2/19 6:18 PM, Stephen Frost wrote: > > > On Tue, Apr 2, 2019 at 18:10 Peter Eisentraut > > > > > <mailto:peter.eisentr...@2ndquadrant.com>

Re: [PATCH v20] GSSAPI encryption support

2019-04-02 Thread Stephen Frost
Greetings, On Tue, Apr 2, 2019 at 18:10 Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2019-02-23 17:27, Stephen Frost wrote: > >> About pg_hba.conf: The "hostgss" keyword seems a bit confusing. It only > >> applies to encrypted gss-using

Re: Compressed TOAST Slicing

2019-04-02 Thread Stephen Frost
Greetings, * Darafei "Komяpa" Praliaskouski (m...@komzpa.net) wrote: > > I'll plan to push this tomorrow with the above change (and a few > > additional comments to explain what all is going on..). > > Is everything ok? Can it be pushed? This has been pushed now. Thanks! Stephen

Re: [PATCH v22] GSSAPI encryption support

2019-04-02 Thread Stephen Frost
Greetings, * Robbie Harwood (rharw...@redhat.com) wrote: > Stephen Frost writes: > > * Robbie Harwood (rharw...@redhat.com) wrote: > >> Stephen Frost writes: > >> > >> I wanted to note a couple things about this approach. It now uses > >

Re: Compressed TOAST Slicing

2019-03-30 Thread Stephen Frost
Greetings, * Paul Ramsey (pram...@cleverelephant.ca) wrote: > > On Mar 19, 2019, at 4:47 AM, Stephen Frost wrote: > > * Paul Ramsey (pram...@cleverelephant.ca) wrote: > >>> On Mar 18, 2019, at 7:34 AM, Robert Haas wrote: > >>> +1. I think Paul had it right o

[PATCH v22] GSSAPI encryption support

2019-03-30 Thread Stephen Frost
Greetings, * Robbie Harwood (rharw...@redhat.com) wrote: > Stephen Frost writes: > > > One of the things that I really didn't care for in this patch was the > > use of the string buffers, without any real checks (except for "oh, > > you tried to alloca

Re: Online verification of checksums

2019-03-29 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-29 11:30:15 -0400, Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > > > On Thu, Mar 28, 2019 at 10:19 PM Tomas Vondra > > > > > > wrote: > > > > On Thu,

Re: Online verification of checksums

2019-03-29 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Thu, Mar 28, 2019 at 10:19 PM Tomas Vondra > wrote: > > > On Thu, Mar 28, 2019 at 01:11:40PM -0700, Andres Freund wrote: > > >Hi, > > > > > >On 2019-03-28 21:09:22 +0100, Michael Banck wrote: > > >> I agree that the current patch

Re: basebackup checksum verification

2019-03-26 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-26 21:01:27 -0400, Stephen Frost wrote: > > I'm also not convinced that these changes to pg_basebackup will be free > > of issues that may impact users in a negative way, making me concerned > > that we're

Re: basebackup checksum verification

2019-03-26 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-26 20:18:31 -0400, Stephen Frost wrote: > > > >>I thought Robert's response was generally good, pointing out that > > > >>we're talking about this being an issue if the corruption happens

Re: basebackup checksum verification

2019-03-26 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On Tue, Mar 26, 2019 at 08:18:31PM -0400, Stephen Frost wrote: > >* Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > >>On Tue, Mar 26, 2019 at 04:49:21PM -0700, Andres Freund wrote: > >>>On 2019

Re: basebackup checksum verification

2019-03-26 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On Tue, Mar 26, 2019 at 04:49:21PM -0700, Andres Freund wrote: > >On 2019-03-26 19:22:03 -0400, Stephen Frost wrote: > >>* Andres Freund (and...@anarazel.de) wrote: > >>> As detailed in > >&

Re: basebackup checksum verification

2019-03-26 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > As detailed in > https://postgr.es/m/20190319200050.ncuxejradurjakdc%40alap3.anarazel.de > the way the backend's basebackup checksum verification works makes its > error detection capabilities very dubious. I disagree that it's 'very

Re: BUG #15708: RLS 'using' running as wrong user when called from a view

2019-03-25 Thread Stephen Frost
Greetings, * Dean Rasheed (dean.a.rash...@gmail.com) wrote: > On Thu, 21 Mar 2019 at 00:39, PG Bug reporting form > wrote: > > > > This fails, seemingly because the RLS on 'bar' is being checked by alice, > > instead of the view owner bob: > > Yes I agree, that appears to be a bug. The subquery

Re: Special role for subscriptions

2019-03-23 Thread Stephen Frost
Greetings, * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > On 23/03/2019 02:38, Michael Paquier wrote: > > On Fri, Mar 22, 2019 at 08:41:06PM +0800, Andrey Borodin wrote: > >> 22 марта 2019 г., в 19:17, Petr Jelinek > >> написал(а): > >>> I still don't like that we are running the

Re: Online verification of checksums

2019-03-19 Thread Stephen Frost
Greetings, On Tue, Mar 19, 2019 at 23:59 Andres Freund wrote: > Hi, > > On 2019-03-19 16:52:08 +0100, Michael Banck wrote: > > Am Dienstag, den 19.03.2019, 11:22 -0400 schrieb Robert Haas: > > > It's torn pages that I am concerned about - the server is writing and > > > we are reading, and we

Re: Compressed TOAST Slicing

2019-03-19 Thread Stephen Frost
Greetings, * Paul Ramsey (pram...@cleverelephant.ca) wrote: > > On Mar 18, 2019, at 7:34 AM, Robert Haas wrote: > > +1. I think Paul had it right originally. > > In that spirit, here is a “one pglz_decompress function, new parameter” > version for commit. Alright, I've been working through

Re: Add exclusive backup deprecation notes to documentation

2019-03-18 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-18 23:35:07 -0400, Stephen Frost wrote: > > * Robert Haas (robertmh...@gmail.com) wrote: > > > On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > > > > I don't view it as up for much debat

Re: Add exclusive backup deprecation notes to documentation

2019-03-18 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > > I don't view it as up for much debate. > > In other words, you're not willing to listen to what other people > think about this issue. I have listened,

Re: Add exclusive backup deprecation notes to documentation

2019-03-18 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 2019-03-07 10:33, David Steele wrote: > > On 3/1/19 3:14 PM, Laurenz Albe wrote: > >> Magnus Hagander wrote: > >>> Maybe have the first note say "This method is deprecated bceause it has > >>> serious > >>> risks (see

Re: Online verification of checksums

2019-03-18 Thread Stephen Frost
Greetings, On Tue, Mar 19, 2019 at 04:15 Michael Banck wrote: > Am Montag, den 18.03.2019, 16:11 +0800 schrieb Stephen Frost: > > On Mon, Mar 18, 2019 at 15:52 Michael Banck > wrote: > > > Am Montag, den 18.03.2019, 03:34 -0400 schrieb Stephen Frost: > > > >

Re: Online verification of checksums

2019-03-18 Thread Stephen Frost
Greetings, On Mon, Mar 18, 2019 at 15:52 Michael Banck wrote: > Hi. > > Am Montag, den 18.03.2019, 03:34 -0400 schrieb Stephen Frost: > > * Michael Banck (michael.ba...@credativ.de) wrote: > > > Am Montag, den 18.03.2019, 02:38 -0400 schrieb Stephen Frost: > &g

Re: Online verification of checksums

2019-03-18 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Mon, Mar 18, 2019 at 02:38:10AM -0400, Stephen Frost wrote: > > Uh, we are, of course, going to have partial reads- we just need to > > handle them appropriately, and that's not hard to do in a way that we >

Re: Online verification of checksums

2019-03-18 Thread Stephen Frost
Greetings, * Michael Banck (michael.ba...@credativ.de) wrote: > Am Montag, den 18.03.2019, 02:38 -0400 schrieb Stephen Frost: > > * Michael Paquier (mich...@paquier.xyz) wrote: > > > On Mon, Mar 18, 2019 at 01:43:08AM -0400, Stephen Frost wrote: > > > > To be cle

Re: Online verification of checksums

2019-03-18 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Mon, Mar 18, 2019 at 01:43:08AM -0400, Stephen Frost wrote: > > To be clear, I agree completely that we don't want to be reporting false > > positives or "this might mean corruption!" to users running the too

Re: Data-only pg_rewind, take 2

2019-03-18 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Sun, Mar 17, 2019 at 09:00:57PM +0800, Chris Travers wrote: > > I also added test cases and some docs. I don't know if the docs are > > sufficient. Feedback is appreciated. > > To be honest, I don't think that this approach is a

Re: Google Summer of Code

2019-03-18 Thread Stephen Frost
Greetings, * Auguste Comte (minasi...@gmail.com) wrote: > Hello Moodle Team, This isn't the Moodle team, I'm guessing you sent this to the wrong place or at least forgot to update your email. > I am a student who is currently take computer science classes at Glendale > Community College, AZ

Re: pg_basebackup ignores the existing data directory permissions

2019-03-18 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Mar 14, 2019 at 7:34 PM Peter Eisentraut > wrote: > > I think the potential problems of getting this wrong are bigger than the > > issue we are trying to fix. > > I think the question is: how do we know what the user intended?

Re: Compressed TOAST Slicing

2019-03-17 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-12 14:42:14 +0900, Michael Paquier wrote: > > On Mon, Mar 11, 2019 at 08:38:56PM +, Regina Obe wrote: > > > I tested on windows mingw64 (as of a week ago) and confirmed the > > > patch applies cleanly and significantly faster

Re: Online verification of checksums

2019-03-17 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > If we want to run it from the server itself, then I guess a background > worker would be a better solution. Incidentally, that's something I've > been toying with some time ago, see [1]. So, I'm a big fan of this idea of having a

Re: Online verification of checksums

2019-03-17 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On 3/2/19 12:03 AM, Robert Haas wrote: > > On Tue, Sep 18, 2018 at 10:37 AM Michael Banck > > wrote: > >> I have added a retry for this as well now, without a pg_sleep() as well. > >> This catches around 80% of the half-reads, but

Re: [PATCH v20] GSSAPI encryption support

2019-03-16 Thread Stephen Frost
Greetings! * Robbie Harwood (rharw...@redhat.com) wrote: > Stephen Frost writes: > > * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > >> Or maybe we avoid that, and you rename be-secure-gssapi.c to just > >> be-gssapi.c and also combine that with the

Re: Special role for subscriptions

2019-03-13 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Mar 11, 2019 at 10:39 PM Michael Paquier wrote: > > On Mon, Mar 11, 2019 at 06:32:10PM -0700, Jeff Davis wrote: > > > * Is the original idea of a special role still viable? > > > > In my opinion, that part may be valuable. The

Re: Online verification of checksums

2019-03-05 Thread Stephen Frost
Greetings, On Tue, Mar 5, 2019 at 18:36 Michael Paquier wrote: > On Tue, Mar 05, 2019 at 02:08:03PM +0100, Tomas Vondra wrote: > > Based on quickly skimming that thread the main issue seems to be > > deciding which files in the data directory are expected to have > > checksums. Which is a valid

Re: GSoC 2019

2019-03-02 Thread Stephen Frost
Greetings, * Sumukha Pk (sumukhap...@gmail.com) wrote: > I am Sumukha PK a student of NITK. I am interested in the WAL-G backup tool. > I haven’t been able to catch hold of anyone through the IRC channels so I > need someone to point me to appropriate resources so that I can be introduced > to

Re: Online verification of checksums

2019-03-02 Thread Stephen Frost
Greetings, * Michael Banck (michael.ba...@credativ.de) wrote: > Am Freitag, den 01.03.2019, 18:03 -0500 schrieb Robert Haas: > > On Tue, Sep 18, 2018 at 10:37 AM Michael Banck > > wrote: > > > I have added a retry for this as well now, without a pg_sleep() as well. > > > This catches around 80%

PostgreSQL Participates in GSoC 2019!

2019-02-28 Thread Stephen Frost
Greetings, I'm pleased to announce that we have been accepted by Google to participate in the Summer of Code (GSoC) 2019 program. This will be the 12th time that the PostgreSQL Project will provide mentorship for students to help develop new features for PostgreSQL. We have the chance to accept

Re: Remove Deprecated Exclusive Backup Mode

2019-02-28 Thread Stephen Frost
Greetings, * Fujii Masao (masao.fu...@gmail.com) wrote: > On Wed, Feb 27, 2019 at 4:35 PM Laurenz Albe wrote: > > > > Fujii Masao wrote: > > > So, let me clarify the situations; > > > > > > (3) If backup_label.pending exists but recovery.signal doesn't, the server > > >ignores (or

Re: Remove Deprecated Exclusive Backup Mode

2019-02-26 Thread Stephen Frost
Greetings, * Laurenz Albe (laurenz.a...@cybertec.at) wrote: > I think the fundamental problem with all these approaches is that there is > no safe way to distinguish a server crashed in backup mode from a restored > backup. This is what makes the problem so hard. Right- if you want to just call

Re: Remove Deprecated Exclusive Backup Mode

2019-02-26 Thread Stephen Frost
Greetings, * Mark Kirkwood (mark.kirkw...@catalyst.net.nz) wrote: > On 26/02/19 5:41 PM, Stephen Frost wrote: > >* Mark Kirkwood (mark.kirkw...@catalyst.net.nz) wrote: > >>ISTM that the onus should be on the patch submitter to provide additions to > >>pg_baseback

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings Mark, * Mark Kirkwood (mark.kirkw...@catalyst.net.nz) wrote: > ISTM that the onus should be on the patch submitter to provide additions to > pg_basebackup that make it as painless as possible for those people *not* > using pgBackRest to continue making backups. Breaking this is just not

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > Hmm, so what you're saying is that you'd like to disable an API that > some non-backrest users are relying upon but which no backrest users > are relying upon. And you don't understand why some non-backrest > users are opposed to that plan.

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-02-25 08:42:02 -0500, Stephen Frost wrote: > > * Andres Freund (and...@anarazel.de) wrote: > > > On 2019-02-24 17:19:22 -0500, Stephen Frost wrote: > > > > You say above that the new interface is

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-02-25 08:14:16 -0500, Stephen Frost wrote: > > > It will be annoying if after this removal, companies must change their > > > backup strategy by using specific postgres tools (pgbackrest, barman). > > &

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * David Steele (da...@pgmasters.net) wrote: > On 2/25/19 7:50 PM, Fujii Masao wrote: > >Thought? > > Here's the really obvious bad thing: if users do not update their procedures > and we ignore backup_label.pending on startup then they will end up with a > corrupt database because it

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Christophe Pettus (x...@thebuild.com) wrote: > > On Feb 25, 2019, at 08:55, Stephen Frost wrote: > > > > I honestly do doubt that they have had the same experiences that I have > > had > > Well, I guarantee you that no two people on this list hav

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Feb 25, 2019 at 11:09 AM Stephen Frost wrote: > > I do think we can ask that people who wish to have a capability included > > in PG (or continue to be included when there are serious known issues > > wi

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Feb 25, 2019 at 11:33 AM Stephen Frost wrote: > > > Removing an option that people are currently using, and which they > > > find better than other available options for reasons with which I > > >

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Feb 25, 2019 at 11:23 AM Stephen Frost wrote: > > If that argument did matter, we could go back and find the prior > > discussions about the issues around the exclusive backup mode and about > > removing it,

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Fri, Feb 22, 2019 at 6:18 PM Stephen Frost wrote: > > What we need is a backup tool included in core that users feel > > comfortable using instead of trying to write their own. > > I agree. That's a great idea.

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Feb 25, 2019 at 8:42 AM Stephen Frost wrote: > > Alright, then how about we provide a bit of help for everyone who's got > > a system built around recovery.conf today, instead of just completely >

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Sun, Feb 24, 2019 at 3:00 PM Stephen Frost wrote: > > Ok, then please do so, and please be prepared to continue to maintain > > the documentation of both methods moving forward, because others have > > tried and ha

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Christophe Pettus (x...@thebuild.com) wrote: > > On Feb 25, 2019, at 05:18, Stephen Frost wrote: > > So.. We've more-or-less come full circle back to where the thread had > > left off last time- the plan is to update the documentation to make it > > clearer

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Laurenz Albe (laurenz.a...@cybertec.at) wrote: > Stephen Frost wrote: > > > It will be annoying if after this removal, companies must change their > > > backup strategy by using specific postgres tools (pgbackrest, barman). > > > > You don't write y

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-02-24 17:19:22 -0500, Stephen Frost wrote: > > You say above that the new interface is unquestionably an improvement > > FWIW, I think we didn't design it even remotely as well as we ought to > have. It

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Dagfinn Ilmari Mannsåker (ilm...@ilmari.org) wrote: > David Steele writes: > > On 2/25/19 12:35 AM, Christophe Pettus wrote: > >>> On Feb 24, 2019, at 14:19, Stephen Frost wrote: > >>> You say above that the new interface is unquestionably an impro

Re: Remove Deprecated Exclusive Backup Mode

2019-02-25 Thread Stephen Frost
Greetings, * Adrien NAYRAT (adrien.nay...@anayrat.info) wrote: > On 2/22/19 7:10 PM, Robert Haas wrote: > >On Fri, Feb 22, 2019 at 12:35 PM Fujii Masao wrote: > >>-1 for the removal. I think that there are still many users of an exclusive > >>backup API, and it's not so easy to migrate their

Re: Remove Deprecated Exclusive Backup Mode

2019-02-24 Thread Stephen Frost
Greetings, * Christophe Pettus (x...@thebuild.com) wrote: > > On Feb 24, 2019, at 13:44, Stephen Frost wrote: > > Right, and PG12 will be out for another *5* years beyond that, meaning > > people will have had 8.5 years to move from the exclusive API to the > > non-exclu

Re: Remove Deprecated Exclusive Backup Mode

2019-02-24 Thread Stephen Frost
Greetings, * Christophe Pettus (x...@thebuild.com) wrote: > > On Feb 24, 2019, at 13:00, Stephen Frost wrote: > > > > No, it *hasn't* been the only backup API for a long time- that was only > > true up until 9.6 was released, since then we've had both, and it's made &g

Re: Remove Deprecated Exclusive Backup Mode

2019-02-24 Thread Stephen Frost
Greetings, * Laurenz Albe (laurenz.a...@cybertec.at) wrote: > Stephen Frost wrote: > > Yes, it *is* impossible to do safe backups with the existing API. There > > is an unquestionable race condition where a system restart will cause > > your system to not come back

Re: Remove Deprecated Exclusive Backup Mode

2019-02-24 Thread Stephen Frost
Greetings, * Christophe Pettus (x...@thebuild.com) wrote: > > On Feb 24, 2019, at 12:00, Stephen Frost wrote: > > > > Do they realize how that existing backup strategy is flawed? > > Undoubtedly, some do, some don't. However, given that it has been the *only* >

Re: Remove Deprecated Exclusive Backup Mode

2019-02-24 Thread Stephen Frost
Greetings, * Christophe Pettus (x...@thebuild.com) wrote: > > On Feb 22, 2019, at 15:18, Stephen Frost wrote: > > Getting a solid and resiliant backup to work from a shell script is, imv > > anyway (though I might have a bit of experience, having tried numerou

Re: [PATCH v20] GSSAPI encryption support

2019-02-23 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > I don't know much about GSSAPI, but from what I can tell, this seems an > attractive feature, and the implementation is compact enough. I have > done a bit of work on the internal SSL API refactoring, so I have some >

Re: oddity with ALTER ROLE/USER

2019-02-23 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Joe Conway writes: > > I noticed that ALTER ROLE/USER succeeds even when called without any > > options: > > > postgres=# alter user foo; > > ALTER ROLE > > postgres=# alter role foo; > > ALTER ROLE > > postgres=# alter group foo; > > ERROR:

Re: Journal based VACUUM FULL

2019-02-22 Thread Stephen Frost
Greetings, * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > On 2/22/19 2:15 PM, Andres Freund wrote: > > On 2019-02-21 16:27:06 +0100, Andreas Karlsson wrote: > >> I have not heard many requests for bringing back the old behavior, but I > >> could easily have missed them. Either way I

Re: Remove Deprecated Exclusive Backup Mode

2019-02-22 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Fri, Feb 22, 2019 at 12:35 PM Fujii Masao wrote: > > -1 for the removal. I think that there are still many users of an exclusive > > backup API, and it's not so easy to migrate their backup scripts so that > > only non-exclusive one is

Re: Remove Deprecated Exclusive Backup Mode

2019-02-22 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Mon, Feb 18, 2019 at 6:13 AM David Steele wrote: > > On 2/16/19 5:57 AM, Andres Freund wrote: > > > On 2019-01-05 13:19:20 -0500, Stephen Frost wrote: > > >> * Peter Eisentraut (peter.eisentr...@2ndquad

Re: [PATCH v20] GSSAPI encryption support

2019-02-21 Thread Stephen Frost
Greetings, * Robbie Harwood (rharw...@redhat.com) wrote: > Stephen Frost writes: > > * Robbie Harwood (rharw...@redhat.com) wrote: > >> Sure! I'll go ahead and hack up the checks and lucid stuff and get > >> back to you. > > > > Great! I'll finish

Re: WAL insert delay settings

2019-02-21 Thread Stephen Frost
Greetings, * Ants Aasma (ants.aa...@eesti.ee) wrote: > On Thu, Feb 21, 2019 at 12:50 PM Stephen Frost wrote: > > > > Rate limit in front of WAL insertion would allow for allocating the > > > throughput between foreground and background tasks, and even allow for &g

Re: WAL insert delay settings

2019-02-21 Thread Stephen Frost
Greetings, * Ants Aasma (ants.aa...@eesti.ee) wrote: > On Thu, Feb 21, 2019 at 2:20 AM Stephen Frost wrote: > > The issue with hitting those bandwidth limits is that you end up with > > queues outside of your control and therefore are unable to prioritize > > the data g

Re: WAL insert delay settings

2019-02-20 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-02-20 18:46:09 -0500, Stephen Frost wrote: > > * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > > > On 2/20/19 10:43 PM, Stephen Frost wrote: > > > > Just to share a few addit

Re: WAL insert delay settings

2019-02-20 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On 2/20/19 10:43 PM, Stephen Frost wrote: > > Just to share a few additional thoughts after pondering this for a > > while, but the comment Andres made up-thread really struck a chord- we > > don't necessa

Re: WAL insert delay settings

2019-02-20 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On 2/19/19 8:40 PM, Andres Freund wrote: > > On 2019-02-19 20:34:25 +0100, Tomas Vondra wrote: > >> On 2/19/19 8:22 PM, Andres Freund wrote: > >>> And my main point is that even if you implement a proper bytes/sec limit > >>> ONLY

Re: Compressed TOAST Slicing

2019-02-20 Thread Stephen Frost
Greetings, * Paul Ramsey (pram...@cleverelephant.ca) wrote: > On Wed, Feb 20, 2019 at 10:50 AM Daniel Verite > wrote: > > > > Paul Ramsey wrote: > > > > > Oddly enough, I couldn't find many/any things that were sensitive to > > > left-end decompression. The only exception is "LIKE

Re: Some thoughts on NFS

2019-02-19 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Tue, Feb 19, 2019 at 2:03 AM Thomas Munro wrote: > > How can we achieve that, without writing our > > own NFS client? > > > > Instead of writing our own NFS client, how about writing our own > network storage protocol? Imagine a

Re: WAL insert delay settings

2019-02-18 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On 2/15/19 7:41 PM, Andres Freund wrote: > > On 2019-02-15 08:50:03 -0500, Stephen Frost wrote: > >> * Andres Freund (and...@anarazel.de) wrote: > >>> On 2019-02-14 11:02:24 -0500, Stephen Frost wrot

Re: [PATCH v20] GSSAPI encryption support

2019-02-18 Thread Stephen Frost
Greetings, * Robbie Harwood (rharw...@redhat.com) wrote: > Andres Freund writes: > > > On 2018-12-18 14:12:46 -0500, Robbie Harwood wrote: > > > >> Subject: [PATCH] libpq GSSAPI encryption support > > > > Could some of these be split into separate patches that could be more > > eagerly merged?

Re: Regarding participating in GSOC 2019 with PostgreSQL

2019-02-15 Thread Stephen Frost
Greetings, * Abhishek Agrawal (aagrawal...@gmail.com) wrote: > I am interested in doing GSOC with PostgreSQL if you guys are applying for it > this year. If anyone could direct me to proper links or some channel to > prepare for the same then it will be really helpful. I have some questions >

Re: WAL insert delay settings

2019-02-15 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-02-14 11:02:24 -0500, Stephen Frost wrote: > > On Thu, Feb 14, 2019 at 10:15 Peter Eisentraut < > > peter.eisentr...@2ndquadrant.com> wrote: > > > On 14/02/2019 11:03, Tomas Vondra wrote: > > &g

Re: WAL insert delay settings

2019-02-14 Thread Stephen Frost
Greetings, On Thu, Feb 14, 2019 at 10:15 Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 14/02/2019 11:03, Tomas Vondra wrote: > > But if you add extra sleep() calls somewhere (say because there's also > > limit on WAL throughput), it will affect how fast VACUUM works in > >

Re: WAL insert delay settings

2019-02-13 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > Bulk operations like CREATE INDEX, ALTER TABLE, or bulk loads can create > a lot of WAL. A lot of WAL at once can cause delays in replication. Agreed, though I think VACUUM should certainly be included in this. I'm all

Re: [PATCH v20] GSSAPI encryption support

2019-02-12 Thread Stephen Frost
Greetings, * Robbie Harwood (rharw...@redhat.com) wrote: > Stephen Frost writes: > > * Robbie Harwood (rharw...@redhat.com) wrote: > >> Stephen Frost writes: > >>> * Robbie Harwood (rharw...@redhat.com) wrote: > >>> > >>>> Attache

Re: [PATCH v20] GSSAPI encryption support

2019-02-11 Thread Stephen Frost
Greetings, * Robbie Harwood (rharw...@redhat.com) wrote: > Stephen Frost writes: > > * Robbie Harwood (rharw...@redhat.com) wrote: > >> Attached please find version 20 of the GSSAPI encryption support. > >> This has been rebased onto master (thanks Stephen f

Re: [PATCH v20] GSSAPI encryption support

2019-02-11 Thread Stephen Frost
Greetings Robbie, * Robbie Harwood (rharw...@redhat.com) wrote: > Attached please find version 20 of the GSSAPI encryption support. This > has been rebased onto master (thanks Stephen for calling out ab69ea9). > Other changes since v19 from Stephen's review: > > - About 100 lines of new

Re: Online verification of checksums

2019-02-06 Thread Stephen Frost
Greetings, * Michael Banck (michael.ba...@credativ.de) wrote: > Am Dienstag, den 05.02.2019, 11:30 +0100 schrieb Tomas Vondra: > > On 2/5/19 8:01 AM, Andres Freund wrote: > > > On 2019-02-05 06:57:06 +0100, Fabien COELHO wrote: > > > > > > > I'm wondering (possibly again) about the existing early

Re: ALTER SESSION

2019-01-29 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-01-29 21:09:22 -0500, Stephen Frost wrote: > > * Andres Freund (and...@anarazel.de) wrote: > > > On 2019-01-29 20:52:08 -0500, Stephen Frost wrote: > > > > * Andres Freund (and...@anaraze

Re: ALTER SESSION

2019-01-29 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-01-29 20:52:08 -0500, Stephen Frost wrote: > > * Andres Freund (and...@anarazel.de) wrote: > > > Leaving the desirability of the feature aside, isn't this racy as hell? > > > I.e. it seems entirely possib

Re: ALTER SESSION

2019-01-29 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-01-29 20:32:54 +0900, Kyotaro HORIGUCHI wrote: > > Hello. > > > > https://www.postgresql.org/message-id/20190128.133143.115303042.horiguchi.kyot...@lab.ntt.co.jp > > > > > C. Provide session-specific GUC variable (that overides

Re: pgsql: Remove references to Majordomo

2019-01-28 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Mon, Jan 28, 2019 at 7:26 PM Tom Lane wrote: > > > Stephen Frost writes: > > >> On Sun, Jan 27, 2019 at 2:28 AM Noah Misch wrote: > > >>> What are those blocked infrastructure improvemen

Re: pgsql: Remove references to Majordomo

2019-01-28 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Sun, Jan 27, 2019 at 2:28 AM Noah Misch wrote: > > > Does this also implicitly mean we've just agreed to push back the > > > retirement of the @postgresql.org aliases for the lists until v11 is > > > EOL..? > > > > > > I can understand

Re: Fwd: Google Summer Of Code

2019-01-22 Thread Stephen Frost
Greetings, * Vikramsingh Kushwaha (vskushw...@mitaoe.ac.in) wrote: > I, Vikramsingh Kushwaha, currently studying in B.Tech 3rd year computer > engineering in MIT Pune, India. I am very much interested to contribute in > the open source projects. But i am new to this so I needed some guidance. >

<    9   10   11   12   13   14   15   16   17   18   >