Re: Suggestion to add --continue-client-on-abort option to pgbench

Hi, Thank you very much for your valuable comments and kind advice. I'm currently working on revising the previous patch based on the feedback received. I would like to share my thoughts regarding the conditions under which the --continue-on-error option should initiate a new transaction or a

Re: Suggestion to add --continue-client-on-abort option to pgbench

Hi, Hackers. I've attached the patch that I failed to include in my previous email. (I'm still a bit confused about how to attach files using the standard Mail client on macOS.) Best Regards, Rintaro IkedaFrom fca20d18dbedc8a9c66408da3e7139cd4192ff5b Mon Sep 17 00:00:00 2001 From: "Rintaro.Ike

Re: Suggestion to add --continue-client-on-abort option to pgbench

Hi, hakers.On Tue, May 13, 2025 at 11:27 AM Dilip Kumar wrote:1. You need to update the stats for this new counter in the"accumStats()" function.2. IMHO, " continue-on-error " is more user-friendly than"continue-client-on-error".3. There are a lot of whitespace errors, so th

Suggestion to add --continue-client-on-abort option to pgbench

Hi hackers, I would like to suggest adding a new option to pgbench, which enables the client to continue processing transactions even if some errors occur during a transaction. Currently, a client stops sending requests when its transaction is aborted due to reasons other than serialization fa

Re: doc: modify the comment in function libpqrcv_check_conninfo()

- * Validate connection info string, and determine whether it might cause - * local filesystem access to be attempted. + * The function + * 1. validates connection info string and + * 2. checks a password is provided if must_use_password is true. IMO, "Validate connection info string" is suffici

Re: doc: modify the comment in function libpqrcv_check_conninfo()

On 2024-07-08 15:28, Fujii Masao wrote: On 2024/07/01 18:15, Jelte Fennema-Nio wrote: On Thu, 27 Jun 2024 at 12:27, ikedarintarof wrote: Thanks for your suggestion. I used ChatGPT to choose the wording, but it's still difficult for me. Looks good to me now (but obviously biased sinc

Re: doc: modify the comment in function libpqrcv_check_conninfo()

Thanks for your suggestion. I used ChatGPT to choose the wording, but it's still difficult for me. The new patch includes your suggestion. On 2024-06-27 17:18, Jelte Fennema-Nio wrote: On Thu, 27 Jun 2024 at 09:09, ikedarintarof wrote: Thank you for your comment! I've

Re: doc: modify the comment in function libpqrcv_check_conninfo()

Thank you for your comment! I've added the must_use_password argument. A new patch is attached. On 2024-06-26 23:36, Jelte Fennema-Nio wrote: On Wed, 26 Jun 2024 at 14:53, ikedarintarof wrote: The function 'libpqrcv_check_conninfo()' returns 'void', but the com

doc: modify the comment in function libpqrcv_check_conninfo()

Hi, The function 'libpqrcv_check_conninfo()' returns 'void', but the comment above says that the function returns true or false. I've attached a patch to modify the comment. Regard, Rintaro Ikedadiff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/