On Sat, Dec 9, 2023 at 9:30 AM Alexander Lakhin wrote:
>
> Hello hackers,
>
> While studying bug #18158, I've come to the conclusion that the existing
> testing infrastructure is unable to detect abnormal situations. of some
> kind.
>
> Just a simple example:
> With Assert(0) injected in
On Mon, Dec 11, 2023 at 1:22 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/8/23 10:06 AM, Amit Kapila wrote:
> > On Wed, Dec 6, 2023 at 4:53 PM shveta malik wrote:
> >>
> >> PFA v43, changes are:
> >>
> >
> > I wanted to discuss 0003 p
On Thu, Dec 7, 2023 at 1:33 PM Peter Smith wrote:
>
> Hi.
>
> Here are my review comments for patch v43-0002.
>
Thanks for the feedback. I have addressed most of these in v45. Please
find my response on a few which are pending or are not needed.
> ==
> Commit message
>
> 1.
> The nap time
On Sun, Dec 10, 2023 at 4:33 PM Amit Kapila wrote:
>
> On Wed, Dec 6, 2023 at 4:53 PM shveta malik wrote:
> >
> > v43-002:
> >
>
> Review comments on v43-0002:
> =
Thanks for the feedback Amit. Addressed these in v45. Please find my
On Mon, Dec 11, 2023 at 1:47 PM Dilip Kumar wrote:
>
> On Fri, Dec 8, 2023 at 2:36 PM Amit Kapila wrote:
> >
> > On Wed, Dec 6, 2023 at 4:53 PM shveta malik wrote:
> > >
> > > PFA v43, changes are:
> > >
> >
> > I wanted to discuss 0003 p
On Thu, Dec 7, 2023 at 2:57 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/7/23 10:07 AM, shveta malik wrote:
> > On Thu, Dec 7, 2023 at 1:19 PM Drouvot, Bertrand
> > wrote:
> >> Might be worth to add comments in the code (around the WalRcv->latestWalEnd
On Thu, Dec 7, 2023 at 1:19 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/6/23 11:58 AM, shveta malik wrote:
> > On Wed, Dec 6, 2023 at 3:00 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 12/6/23 7:18 AM, shveta ma
On Wed, Dec 6, 2023 at 3:00 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/6/23 7:18 AM, shveta malik wrote:
> > On Wed, Dec 6, 2023 at 10:56 AM Amit Kapila wrote:
> >>
> >> I feel that is indirectly relying on the fact that the primary won't
> >> adva
On Wed, Dec 6, 2023 at 10:56 AM Amit Kapila wrote:
>
> On Tue, Dec 5, 2023 at 7:38 PM Drouvot, Bertrand
> wrote:
> >
> > On 12/5/23 12:32 PM, Amit Kapila wrote:
> > > On Tue, Dec 5, 2023 at 10:38 AM shveta malik
> > > wrote:
> > >>
>
On Tue, Dec 5, 2023 at 2:18 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/5/23 6:08 AM, shveta malik wrote:
> > On Mon, Dec 4, 2023 at 10:07 PM Drouvot, Bertrand
> > wrote:
> >> Maybe another option could be to have the walreceiver a way to let the
On Mon, Dec 4, 2023 at 10:07 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/4/23 6:10 AM, shveta malik wrote:
> > On Fri, Dec 1, 2023 at 5:40 PM Nisha Moond wrote:
> >>
> >> Review for v41 patch.
> >
> > Thanks for the feedback.
> >
>
On Mon, Dec 4, 2023 at 10:40 AM shveta malik wrote:
>
> On Fri, Dec 1, 2023 at 5:40 PM Nisha Moond wrote:
> >
> > Review for v41 patch.
>
> Thanks for the feedback.
>
> >
> > 1.
> > ==
> > src/backend/utils/misc/postgresql.conf.s
On Fri, Dec 1, 2023 at 5:40 PM Nisha Moond wrote:
>
> Review for v41 patch.
Thanks for the feedback.
>
> 1.
> ==
> src/backend/utils/misc/postgresql.conf.sample
>
> +#enable_syncslot = on # enables slot synchronization on the physical
> standby from the primary
>
> enable_syncslot is
On Fri, Dec 1, 2023 at 3:43 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/30/23 1:06 PM, Ajin Cherian wrote:
> > On Wed, Nov 29, 2023 at 8:17 PM Zhijie Hou (Fujitsu)
> >
> > 3. If creation of a slot on the standby fails for one slot because a
> > slot of the same name exists, then thereafter no
On Fri, Dec 1, 2023 at 11:17 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Friday, December 1, 2023 12:51 PM shveta malik
> wrote:
>
> Hi,
>
> >
> > On Fri, Dec 1, 2023 at 9:40 AM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > On Wednesday, Nov
On Fri, Dec 1, 2023 at 9:40 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Wednesday, November 29, 2023 5:12 PM Zhijie Hou (Fujitsu)
> wrote:
>
> I was reviewing slotsync worker design and here
> are few comments on 0002 patch:
Thanks for reviewing the patch.
>
> 1.
>
> + if (!WalRcv ||
> +
On Thu, Nov 30, 2023 at 5:37 PM Ajin Cherian wrote:
>
> On Wed, Nov 29, 2023 at 8:17 PM Zhijie Hou (Fujitsu)
> wrote:
> >
> > This has been fixed.
> >
> > Best Regards,
> > Hou zj
>
> Thanks for addressing my comments. Some comments from my testing of patch v41
>
> 1. In my opinion, the second
On Tue, Nov 28, 2023 at 9:28 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/28/23 10:40 AM, shveta malik wrote:
> > On Tue, Nov 28, 2023 at 12:19 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 11/28/23 4:13 AM, shveta ma
On Fri, Nov 17, 2023 at 5:08 PM Amit Kapila wrote:
>
> On Thu, Nov 16, 2023 at 5:34 PM shveta malik wrote:
> >
> > PFA v35.
> >
>
> Review v35-0002*
> ==
> 1.
> As quoted in the commit message,
> >
> If a logical slot is invalid
On Tue, Nov 28, 2023 at 3:10 PM shveta malik wrote:
>
> On Tue, Nov 28, 2023 at 12:19 PM Drouvot, Bertrand
> wrote:
> >
> > Hi,
> >
> > On 11/28/23 4:13 AM, shveta malik wrote:
> > > On Mon, Nov 27, 2023 at 4:08 PM Amit Kapila
> > > wrote:
&
On Mon, Nov 27, 2023 at 4:08 PM Amit Kapila wrote:
>
> On Mon, Nov 27, 2023 at 2:27 PM Zhijie Hou (Fujitsu)
> wrote:
> >
> > Here is the updated version(v39_2) which include all the changes made in
> > 0002.
> > Please use for review, and sorry for the confusion.
> >
>
> ---
On Mon, Nov 27, 2023 at 2:15 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/27/23 7:02 AM, Zhijie Hou (Fujitsu) wrote:
> > On Monday, November 27, 2023 12:03 PM Zhijie Hou (Fujitsu)
> > wrote:
> >>
> >> Attach the V38 patch set which addressed all comments in [1][2] except for
> >> the
> >>
On Tue, Nov 21, 2023 at 1:13 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/21/23 6:16 AM, Amit Kapila wrote:
> > On Mon, Nov 20, 2023 at 6:51 PM Drouvot, Bertrand
> > wrote:
> >> As far the 'i' state here, from what I see, it is currently useful for:
> >>
> >> 1. Cascading standby to not sync
On Tue, Nov 21, 2023 at 10:02 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Friday, November 17, 2023 7:39 PM Amit Kapila
> wrote:
> >
> > On Thu, Nov 16, 2023 at 5:34 PM shveta malik
> > wrote:
> > >
> > > PFA v35.
> > >
> >
> > Review
On Tue, Nov 21, 2023 at 10:02 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Friday, November 17, 2023 7:39 PM Amit Kapila
> wrote:
> >
> > On Thu, Nov 16, 2023 at 5:34 PM shveta malik
> > wrote:
> > >
> > > PFA v35.
> > >
> >
> > Review
On Tue, Nov 21, 2023 at 10:01 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Saturday, November 18, 2023 6:46 PM Amit Kapila
> wrote:
> >
> > On Fri, Nov 17, 2023 at 5:18 PM Drouvot, Bertrand
> > wrote:
> > >
> > > On 11/17/23 2:46 AM, Zhijie Hou (Fujitsu) wrote:
> > > > On Tuesday, November 14, 2023
On Tue, Nov 14, 2023 at 7:56 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/13/23 2:57 PM, Zhijie Hou (Fujitsu) wrote:
> > On Friday, November 10, 2023 4:16 PM Drouvot, Bertrand
> > wrote:
> >> Yeah good point, agree to just error out in all the case then (if we
> >> discard the
> >> sync_
On Mon, Nov 13, 2023 at 11:02 AM Ajin Cherian wrote:
>
> On Thu, Nov 9, 2023 at 9:54 PM shveta malik wrote:
> >
> > PFA v32 patches which has below changes:
> Testing with this patch, I see that if the failover enabled slot is
> invalidated on the primary, then the c
On Thu, Nov 9, 2023 at 8:56 AM Amit Kapila wrote:
>
> On Thu, Nov 9, 2023 at 8:11 AM Amit Kapila wrote:
> >
> > On Wed, Nov 8, 2023 at 8:09 PM Drouvot, Bertrand
> > wrote:
> > >
> > > > Unrelated to above, if there is a user slot on standby with the same
> > > > name which the slot-sync worker
On Mon, Nov 13, 2023 at 6:19 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Thursday, November 9, 2023 6:54 PM shveta malik
> wrote:
> >
> >
> > PFA v32 patches which has below changes:
>
> Thanks for updating the patch.
>
> Here are few comments:
>
>
>
On Thu, Nov 9, 2023 at 9:15 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/9/23 11:54 AM, shveta malik wrote:
> >
> > PFA v32 patches which has below changes:
>
> Thanks!
>
> > 7) Added warning for cases where a user-slot with the same name is
> > alr
On Wed, Nov 8, 2023 at 3:19 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 11/8/23 9:57 AM, Amit Kapila wrote:
> > On Wed, Nov 8, 2023 at 12:32 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 11/8/23 4:50 AM, Amit Kapila wrote:
> >>
> >>> I think if we want to follow
> >>> this approach
On Mon, Nov 6, 2023 at 7:01 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Friday, November 3, 2023 7:32 PM Amit Kapila
> >
> > On Thu, Nov 2, 2023 at 2:35 PM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > Here is the new version patch set(V29) which addressed Peter
> > > comments[1][2] and fixed one doc
On Fri, Oct 27, 2023 at 8:43 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/27/23 11:56 AM, shveta malik wrote:
> > On Wed, Oct 25, 2023 at 3:15 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 10/25/23 5:00 AM, shveta
On Thu, Oct 26, 2023 at 5:43 PM Amit Kapila wrote:
>
> On Thu, Oct 26, 2023 at 5:38 PM Drouvot, Bertrand
> wrote:
> >
> > On 10/26/23 10:40 AM, Amit Kapila wrote:
> > > On Wed, Oct 25, 2023 at 8:49 PM Drouvot, Bertrand
> > > wrote:
> > >>
> > >
> > > Good point, I think we should enhance the
On Wed, Oct 25, 2023 at 3:15 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/25/23 5:00 AM, shveta malik wrote:
> > On Tue, Oct 24, 2023 at 11:54 AM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 10/23/23 2:56 PM, shveta malik wr
On Wed, Oct 25, 2023 at 3:15 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/25/23 5:00 AM, shveta malik wrote:
> > On Tue, Oct 24, 2023 at 11:54 AM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 10/23/23 2:56 PM, shveta malik wr
On Tue, Oct 24, 2023 at 11:54 AM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/23/23 2:56 PM, shveta malik wrote:
> > On Mon, Oct 23, 2023 at 5:52 PM Drouvot, Bertrand
> > wrote:
>
> >> We are waiting for DEFAULT_NAPTIME_PER_CYCLE (3 minutes) before checking
>
On Tue, Oct 24, 2023 at 3:35 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/24/23 7:44 AM, Ajin Cherian wrote:
> > On Mon, Oct 23, 2023 at 11:22 PM Drouvot, Bertrand
> > wrote:
> >>
> >> @@ -602,6 +602,9 @@ CreateDecodingContext(XLogRecPtr start_lsn,
> >>
On Mon, Oct 23, 2023 at 5:52 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/20/23 5:27 AM, shveta malik wrote:
> > On Wed, Oct 18, 2023 at 4:24 PM Amit Kapila wrote:
> >
> > PFA v25 patch set. The changes are:
> >
> > 1) 'enable_failover' is changed to 'f
On Tue, Oct 17, 2023 at 9:06 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/13/23 10:35 AM, shveta malik wrote:
> > On Thu, Oct 12, 2023 at 9:18 AM shveta malik wrote:
> >>
> >
> > PFA v24 patch set which has below changes:
> >
> > 1) 'enable
On Wed, Oct 18, 2023 at 4:24 PM Amit Kapila wrote:
>
> On Tue, Oct 17, 2023 at 2:01 PM shveta malik wrote:
> >
> > On Tue, Oct 17, 2023 at 12:44 PM Peter Smith wrote:
> > >
> > > FYI - the latest patch failed to apply.
> > >
> > &g
On Wed, Oct 18, 2023 at 10:20 AM Amit Kapila wrote:
>
> On Tue, Oct 17, 2023 at 9:06 PM Drouvot, Bertrand
> wrote:
> >
> > On 10/13/23 10:35 AM, shveta malik wrote:
> > > On Thu, Oct 12, 2023 at 9:18 AM shveta malik
> > > wrote:
> > >>
>
On Tue, Oct 17, 2023 at 9:06 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/13/23 10:35 AM, shveta malik wrote:
> > On Thu, Oct 12, 2023 at 9:18 AM shveta malik wrote:
> >>
> >
> > PFA v24 patch set which has below changes:
> >
> > 1) 'enable
On Tue, Oct 10, 2023 at 12:52 PM Peter Smith wrote:
>
> On Mon, Oct 9, 2023 at 9:34 PM shveta malik wrote:
> >
> > On Wed, Oct 4, 2023 at 8:53 AM Peter Smith wrote:
> > >
> > > Here are some review comments for v20-0002.
> > >
> >
> >
On Tue, Oct 10, 2023 at 12:52 PM Peter Smith wrote:
>
> On Mon, Oct 9, 2023 at 9:34 PM shveta malik wrote:
> >
> > On Wed, Oct 4, 2023 at 8:53 AM Peter Smith wrote:
> > >
> > > Here are some review comments for v20-0002.
> > >
> >
> >
On Mon, Oct 2, 2023 at 4:29 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Shveta,
>
> Thank you for updating the patch!
Thanks for the feedback Kuroda-san. I have addressed most of these in
v22. Please find my comments inline.
>
> I found another ERROR due to the slot removal. Is this a real
On Mon, Oct 9, 2023 at 3:24 AM Peter Smith wrote:
>
> On Fri, Oct 6, 2023 at 7:37 PM Alvaro Herrera wrote:
> >
> > On 2023-Sep-27, Peter Smith wrote:
> >
> > > 3. get_local_synced_slot_names
> > >
> > > + for (int i = 0; i < max_replication_slots; i++)
> > > + {
> > > + ReplicationSlot *s =
On Wed, Oct 4, 2023 at 8:53 AM Peter Smith wrote:
>
> Here are some review comments for v20-0002.
>
Thanks Peter for the feedback. Comments from 31 till end are addressed
in v22. First 30 comments will be addressed in the next version.
> ==
> 1. GENERAL - errmsg/elog messages
>
> There are
On Fri, Oct 6, 2023 at 2:07 PM Alvaro Herrera wrote:
>
> On 2023-Sep-27, Peter Smith wrote:
>
> > 3. get_local_synced_slot_names
> >
> > + for (int i = 0; i < max_replication_slots; i++)
> > + {
> > + ReplicationSlot *s = >replication_slots[i];
> > +
> > + /* Check if it is logical synchronized
On Wed, Oct 4, 2023 at 12:08 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/4/23 7:00 AM, shveta malik wrote:
> > On Wed, Oct 4, 2023 at 9:56 AM shveta malik wrote:
>
> > The most simplistic approach would be:
> >
> > 1) maintain standby_sl
On Wed, Oct 4, 2023 at 5:00 PM Amit Kapila wrote:
>
> On Wed, Oct 4, 2023 at 11:55 AM Drouvot, Bertrand
> wrote:
> >
> > On 10/4/23 6:26 AM, shveta malik wrote:
> > > On Wed, Oct 4, 2023 at 5:36 AM Amit Kapila
> > > wrote:
> > >>
> >
On Mon, Oct 2, 2023 at 4:29 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Shveta,
>
> Thank you for updating the patch!
>
> I found another ERROR due to the slot removal. Is this a real issue?
>
> 1. applied add_sleep.txt, which emulated the case the tablesync worker stucked
>and the primary
On Wed, Oct 4, 2023 at 9:56 AM shveta malik wrote:
>
> On Wed, Oct 4, 2023 at 5:36 AM Amit Kapila wrote:
> >
> > On Tue, Oct 3, 2023 at 9:27 PM shveta malik wrote:
> > >
> > > On Tue, Oct 3, 2023 at 7:56 PM Drouvot, Bertrand
> > > wrote:
> >
On Wed, Oct 4, 2023 at 5:36 AM Amit Kapila wrote:
>
> On Tue, Oct 3, 2023 at 9:27 PM shveta malik wrote:
> >
> > On Tue, Oct 3, 2023 at 7:56 PM Drouvot, Bertrand
> > wrote:
> > >
> > > Hi,
> > >
> > > On 10/3/23 12:54 PM, Amit K
On Tue, Oct 3, 2023 at 7:56 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/3/23 12:54 PM, Amit Kapila wrote:
> > On Mon, Oct 2, 2023 at 11:39 AM Drouvot, Bertrand
> > wrote:
> >>
> >> On 9/29/23 1:33 PM, Amit Kapila wrote:
> >>> On Thu, Sep 28, 2023 at 6:31 PM Drouvot, Bertrand
> >>> wrote:
>
On Mon, Sep 25, 2023 at 7:46 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Ajin, Shveta,
>
> Thank you for rebasing the patch set! Here are new comments for v19_2-0001.
>
Thank You Kuroda-san for the feedback. Most of these are addressed in
v20. Please find my response inline.
> 01.
On Fri, Sep 22, 2023 at 3:48 PM Amit Kapila wrote:
>
> On Thu, Sep 21, 2023 at 9:16 AM shveta malik wrote:
> >
> > On Tue, Sep 19, 2023 at 10:29 AM shveta malik
> > wrote:
> >
> > Currently in patch001, synchronize_slot_names is a GUC on both primary
>
On Fri, Sep 22, 2023 at 6:01 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> Thanks for all the work that has been done on this feature, and sorry
> to have been quiet on it for so long.
Thanks for looking into this.
>
> On 9/18/23 12:22 PM, shveta malik wrote:
> > On W
On Tue, Sep 19, 2023 at 10:29 AM shveta malik wrote:
>
> On Fri, Sep 15, 2023 at 2:22 PM Peter Smith wrote:
> >
> > Hi. Here are some review comments for v17-0002.
> >
>
> Thanks Peter for the feedback. I have addressed most of these in v18
> except 2. Ple
On Fri, Sep 15, 2023 at 2:22 PM Peter Smith wrote:
>
> Hi. Here are some review comments for v17-0002.
>
Thanks Peter for the feedback. I have addressed most of these in v18
except 2. Please find my comments for the ones not addressed.
> This is a WIP and a long way from complete, but I
On Wed, Sep 13, 2023 at 4:48 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Shveta,
>
> Sorry for the late response.
>
> > Thanks Kuroda-san for the feedback.
> > >
> > > 01. General
> > >
> > > I think the documentation can be added, not only GUCs. How about adding
> > examples
> > > for
On Wed, Sep 6, 2023 at 2:18 PM shveta malik wrote:
>
> On Fri, Sep 1, 2023 at 1:59 PM Peter Smith wrote:
> >
> > Hi Shveta. Here are some comments for patch v14-0002
> >
> > The patch is large, so my code review is a WIP... more later next week...
> >
>
On Fri, Sep 8, 2023 at 4:40 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Shveta,
>
> I resumed to check the thread. Here are my high-level comments.
> Sorry if you have been already discussed.
Thanks Kuroda-san for the feedback.
>
> 01. General
>
> I think the documentation can be added, not only
On Fri, Aug 25, 2023 at 2:15 PM Alvaro Herrera wrote:
>
> Wait a minute ...
>
> From bac0fbef8b203c530e5117b0b7cfee13cfab78b9 Mon Sep 17 00:00:00 2001
> From: Bharath Rupireddy
> Date: Sat, 22 Jul 2023 10:17:48 +
> Subject: [PATCH v13 1/2] Allow logical walsenders to wait for physical
>
On Fri, Sep 1, 2023 at 1:59 PM Peter Smith wrote:
>
> Hi Shveta. Here are some comments for patch v14-0002
>
> The patch is large, so my code review is a WIP... more later next week...
>
Thanks Peter for the feedback. I have tried to address most of these
in v15. Please find my response inline
On Wed, Aug 23, 2023 at 4:21 PM Dilip Kumar wrote:
>
> On Wed, Aug 23, 2023 at 3:38 PM shveta malik wrote:
> >
> I have reviewed the v12-0002 patch and I have some comments. I see the
> latest version posted sometime back and if any of this comment is
> already fixed in t
On Fri, Aug 25, 2023 at 11:09 AM shveta malik wrote:
>
> On Wed, Aug 23, 2023 at 4:21 PM Dilip Kumar wrote:
> >
> > On Wed, Aug 23, 2023 at 3:38 PM shveta malik wrote:
> > >
> > I have reviewed the v12-0002 patch and I have some comments. I see the
> &
On Wed, Aug 23, 2023 at 4:21 PM Dilip Kumar wrote:
>
> On Wed, Aug 23, 2023 at 3:38 PM shveta malik wrote:
> >
> I have reviewed the v12-0002 patch and I have some comments. I see the
> latest version posted sometime back and if any of this comment is
> already fixed in t
On Thu, Aug 17, 2023 at 4:09 PM shveta malik wrote:
>
> On Thu, Aug 17, 2023 at 11:55 AM shveta malik wrote:
> >
> > On Thu, Aug 17, 2023 at 11:44 AM Drouvot, Bertrand
> > wrote:
> > >
> > > Hi,
> > >
> > > On 8/14/23 11:52 AM, s
On Thu, Aug 17, 2023 at 11:55 AM shveta malik wrote:
>
> On Thu, Aug 17, 2023 at 11:44 AM Drouvot, Bertrand
> wrote:
> >
> > Hi,
> >
> > On 8/14/23 11:52 AM, shveta malik wrote:
> >
> > >
> > > We (myself and Ajin) performed the te
On Fri, Aug 18, 2023 at 8:50 AM Amit Kapila wrote:
>
> On Mon, Aug 14, 2023 at 12:08 PM Peter Smith wrote:
> >
> > The main patch for adding the worker type enum has been pushed [1].
> >
> > Here is the remaining (rebased) patch for changing some previous
> > cascading if/else to switch on the
On Thu, Aug 17, 2023 at 11:55 AM shveta malik wrote:
>
> On Thu, Aug 17, 2023 at 11:44 AM Drouvot, Bertrand
> wrote:
> >
> > Hi,
> >
> > On 8/14/23 11:52 AM, shveta malik wrote:
> >
> > >
> > > We (myself and Ajin) performed the te
On Thu, Aug 17, 2023 at 11:44 AM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 8/14/23 11:52 AM, shveta malik wrote:
>
> >
> > We (myself and Ajin) performed the tests to compute the lag in standby
> > slots as compared to primary slots with different number of
On Mon, Aug 14, 2023 at 3:22 PM shveta malik wrote:
>
> On Tue, Aug 8, 2023 at 11:11 AM Drouvot, Bertrand
> wrote:
> >
> > Hi,
> >
> > On 8/8/23 7:01 AM, shveta malik wrote:
> > > On Mon, Aug 7, 2023 at 3:17 PM Drouvot, Bertrand
> > > wrote
On Tue, Aug 8, 2023 at 11:11 AM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 8/8/23 7:01 AM, shveta malik wrote:
> > On Mon, Aug 7, 2023 at 3:17 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Hi,
> >>
> >> On 8/4/23 1:32 PM, shveta malik w
On Mon, Aug 7, 2023 at 3:17 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 8/4/23 1:32 PM, shveta malik wrote:
> > On Fri, Aug 4, 2023 at 2:44 PM Drouvot, Bertrand
> > wrote:
> >> On 7/28/23 4:39 PM, Bharath Rupireddy wrote:
>
> >> Sorry to be late, b
On Tue, Aug 1, 2023 at 4:52 PM shveta malik wrote:
>
> On Thu, Jul 27, 2023 at 12:13 PM shveta malik wrote:
> >
> > On Thu, Jul 27, 2023 at 10:55 AM Amit Kapila
> > wrote:
> > >
> > > On Wed, Jul 26, 2023 at 10:31 AM shveta malik
> > > wro
On Fri, Aug 4, 2023 at 2:44 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 7/28/23 4:39 PM, Bharath Rupireddy wrote:
> > On Mon, Jul 24, 2023 at 9:00 AM Amit Kapila wrote:
> >>
> >>> 2. All candidate standbys will start one slot sync worker per logical
> >>> slot which might not be scalable.
> >>
>
On Thu, Aug 3, 2023 at 12:28 AM Bharath Rupireddy
wrote:
>
> On Tue, Aug 1, 2023 at 5:01 PM shveta malik wrote:
> >
> > > The work division amongst the sync workers can
> > > be simple, the logical replication launcher builds a shared memory
> > > str
On Fri, Jul 28, 2023 at 8:54 PM Bharath Rupireddy
wrote:
>
> On Thu, Jul 27, 2023 at 10:55 AM Amit Kapila wrote:
> >
> > I wonder if we anyway some sort of design like this because we
> > shouldn't allow to spawn as many workers as the number of databases.
> > There has to be some existing or
On Thu, Jul 27, 2023 at 10:55 AM Amit Kapila wrote:
>
> On Wed, Jul 26, 2023 at 10:31 AM shveta malik wrote:
> >
> > On Mon, Jul 24, 2023 at 9:00 AM Amit Kapila wrote:
> > >
> > > On Mon, Jul 24, 2023 at 8:03 AM Bharath Rupireddy
> > > wrote:
On Mon, Jul 24, 2023 at 8:03 AM Bharath Rupireddy
wrote:
>
> On Fri, Jul 21, 2023 at 5:16 PM shveta malik wrote:
> >
> > Thanks Bharat for letting us know. It is okay to split the patch, it
> > may definitely help to understand the modules better but shall we take
On Mon, Jul 24, 2023 at 9:00 AM Amit Kapila wrote:
>
> On Mon, Jul 24, 2023 at 8:03 AM Bharath Rupireddy
> wrote:
> >
> > On Fri, Jul 21, 2023 at 5:16 PM shveta malik wrote:
> > >
> > > Thanks Bharat for letting us know. It is okay to split the patch, it
On Fri, Jul 21, 2023 at 11:36 AM Bharath Rupireddy
wrote:
>
> On Thu, Jul 20, 2023 at 5:05 PM shveta malik wrote:
> >
> > On Fri, Jun 16, 2023 at 3:26 PM Amit Kapila wrote:
> > >
> > > On Mon, Apr 17, 2023 at 7:37 PM Drouvot, Bertrand
> > &
On Fri, Jun 16, 2023 at 3:26 PM Amit Kapila wrote:
>
> On Mon, Apr 17, 2023 at 7:37 PM Drouvot, Bertrand
> wrote:
> >
> 3. As mentioned in the initial email, I think it would be better to
> replace LIST_SLOTS command with a SELECT query.
>
I had a look at this thread. I am interested to work
On Wed, Jun 21, 2023 at 6:38 PM Jelte Fennema wrote:
>
> (to be clear I only skimmed the end of this thread and did not look at
> all the previous messages)
>
> I took a quick look at the first patch (about deparsing table ddl) and
> it seems like this would also be very useful for a SHOW CREATE
On Mon, Jun 12, 2023 at 7:17 AM Wei Wang (Fujitsu)
wrote:
>
> On Thur, Jun 8, 2023 20:02 PM shveta malik wrote:
> > Thank You Vignesh for handling (a), Ajin for handling (b), Shi-san and
> > Hou-san for contributing in (c).
> >
> > The new changes are in p
As per suggestion by Amit, reviewed two more formats to be used for
DDL's WAL-logging purpose, analysis below:
NodeToString:
I do not think it is a good idea to use NodeToString in DDL Rep for
reasons below:
1) It consists of too much internal and not-needed information.
2) Too large to be logged
On Thu, Jun 8, 2023 at 5:31 PM shveta malik wrote:
>
> Please find new set of patches addressing below:
> a) Issue mentioned by Wang-san in [1],
> b) Comments from Peter given in [2]
> c) Comments from Amit given in the last 2 emails.
>
> [1]:
> https://www.p
On Tue, Jun 6, 2023 at 11:31 AM Wei Wang (Fujitsu)
wrote:
>
> On Thur, June 1, 2023 at 23:42 vignesh C wrote:
> > On Wed, 31 May 2023 at 14:32, Wei Wang (Fujitsu)
> > wrote:
> > > ~~~
> > >
> > > 2. Deparsed results of the partition table.
> > > When I run the following SQLs:
> > > ```
> > >
On Tue, Jun 6, 2023 at 4:26 PM Amit Kapila wrote:
>
> On Mon, Jun 5, 2023 at 3:00 PM shveta malik wrote:
> >
>
> Few assorted comments:
Hi Amit, thanks for the feedback. Addressed these in recent patch
posted (*2023_06_08.patch)
> ===
> 1. I see th
On Mon, May 29, 2023 at 6:16 PM vignesh C wrote:
>
> >
> > I found few comments while making some changes to the patch:
> > 1) Now that objtree is removed, these comments should be modified:
> > * Deparse object tree is created by using:
> > * a) new_objtree("know contents") where the complete
I have attempted to convert pg_get_indexdef() to use
systable_beginscan() based on transaction-snapshot rather than using
SearchSysCache(). The latter does not have any old info and thus
provides only the latest info as per the committed txns, which could
result in errors in some scenarios. One
On Mon, May 8, 2023 at 3:58 PM shveta malik wrote:
>
> On Tue, May 2, 2023 at 8:30 AM shveta malik wrote:
> >
> > On Fri, Apr 28, 2023 at 5:11 PM Amit Kapila wrote:
> > >
> > > Now, I think we can try to eliminate this entire ObjTree machinery and
>
On Fri, Apr 28, 2023 at 5:11 PM Amit Kapila wrote:
>
> On Tue, Apr 25, 2023 at 9:28 AM Zhijie Hou (Fujitsu)
> wrote:
> >
>
> I have a few high-level comments on the deparsing approach used in the
> patch. As per my understanding, we first build an ObjTree from the DDL
> command, then convert the
On Thu, Apr 20, 2023 at 3:40 PM Amit Kapila wrote:
>
> On Thu, Apr 20, 2023 at 9:11 AM shveta malik wrote:
> >
> >
> > Few comments for ddl_deparse.c in patch dated April17:
>
> >
> > 6) There are plenty of places where we use 'append_not_present'
> &g
On Thu, Apr 20, 2023 at 2:28 PM shveta malik wrote:
>
> On Thu, Apr 20, 2023 at 9:11 AM shveta malik wrote:
>>
>> On Mon, Apr 17, 2023 at 5:32 PM Zhijie Hou (Fujitsu)
>> wrote:
>> >
>> > Attach the new version patch set which include the following
On Thu, Apr 20, 2023 at 9:11 AM shveta malik wrote:
> On Mon, Apr 17, 2023 at 5:32 PM Zhijie Hou (Fujitsu)
> wrote:
> >
> > Attach the new version patch set which include the following changes:
> >
>
> Few comments for ddl_deparse.c in patch dated April17:
&g
On Mon, Apr 17, 2023 at 5:32 PM Zhijie Hou (Fujitsu)
wrote:
>
> On Monday, April 10, 2023 7:20 PM Amit Kapila wrote:
> >
> > On Fri, Apr 7, 2023 at 8:52 AM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > Sorry, there was a miss when rebasing the patch which could cause the
> > > CFbot to fail and
201 - 300 of 332 matches
Mail list logo
