Re: BackgroundPsql's set_query_timer_restart() may not work

2023-11-29 Thread Masahiko Sawada
On Wed, Nov 29, 2023 at 7:48 PM Bharath Rupireddy wrote: > > On Wed, Nov 29, 2023 at 1:49 PM Masahiko Sawada wrote: > > > > On Wed, Nov 29, 2023 at 4:30 PM Bharath Rupireddy > > wrote: > > > > > > On Tue, Nov 28, 2023 at 12:23 PM Tom Lane wrote: > > > > > > > > Bharath Rupireddy writes: > > >

Re: BackgroundPsql's set_query_timer_restart() may not work

2023-11-29 Thread Bharath Rupireddy
On Wed, Nov 29, 2023 at 1:49 PM Masahiko Sawada wrote: > > On Wed, Nov 29, 2023 at 4:30 PM Bharath Rupireddy > wrote: > > > > On Tue, Nov 28, 2023 at 12:23 PM Tom Lane wrote: > > > > > > Bharath Rupireddy writes: > > > > A nitpick on the patch - how about honoring the passed-in parameter > > >

Re: BackgroundPsql's set_query_timer_restart() may not work

2023-11-29 Thread Masahiko Sawada
On Wed, Nov 29, 2023 at 4:30 PM Bharath Rupireddy wrote: > > On Tue, Nov 28, 2023 at 12:23 PM Tom Lane wrote: > > > > Bharath Rupireddy writes: > > > A nitpick on the patch - how about honoring the passed-in parameter > > > with something like $self->{query_timer_restart} = 1 if !defined > > > $

Re: BackgroundPsql's set_query_timer_restart() may not work

2023-11-28 Thread Bharath Rupireddy
On Tue, Nov 28, 2023 at 12:23 PM Tom Lane wrote: > > Bharath Rupireddy writes: > > A nitpick on the patch - how about honoring the passed-in parameter > > with something like $self->{query_timer_restart} = 1 if !defined > > $self->{query_timer_restart}; instead of just setting it to 1 (a value >

Re: BackgroundPsql's set_query_timer_restart() may not work

2023-11-27 Thread Tom Lane
Bharath Rupireddy writes: > A nitpick on the patch - how about honoring the passed-in parameter > with something like $self->{query_timer_restart} = 1 if !defined > $self->{query_timer_restart}; instead of just setting it to 1 (a value > other than undef) $self->{query_timer_restart} = 1;? I wond

Re: BackgroundPsql's set_query_timer_restart() may not work

2023-11-27 Thread Bharath Rupireddy
On Tue, Nov 28, 2023 at 6:48 AM Masahiko Sawada wrote: > > Hi, > > While adding some TAP tests, I realized that set_query_timer_restart() > in BackgroundPsql may not work. Specifically, it seems not to work > unless we pass an argument to the function. Here is the test script I > used: > > If call

BackgroundPsql's set_query_timer_restart() may not work

2023-11-27 Thread Masahiko Sawada
Hi, While adding some TAP tests, I realized that set_query_timer_restart() in BackgroundPsql may not work. Specifically, it seems not to work unless we pass an argument to the function. Here is the test script I used: use strict; use warnings; use PostgreSQL::Test::Cluster; use PostgreSQL::Test::