max_slot_wal_keep_size and wal_keep_segments

2020-06-30 Thread Fujii Masao
Hi, When I talked about max_slot_wal_keep_size as new feature in v13 at the conference, I received the question like "Why are the units of setting values in max_slot_wal_keep_size and wal_keep_segments different?" from audience. That difference looks confusing for users and IMO it&#

Re: max_slot_wal_keep_size and wal_keep_segments

2020-06-30 Thread Kyotaro Horiguchi
At Tue, 30 Jun 2020 23:51:40 +0900, Fujii Masao wrote in > Hi, > > When I talked about max_slot_wal_keep_size as new feature in v13 > at the conference, I received the question like "Why are the units of > setting values in max_slot_wal_keep_size and wal_keep_segments

Re: max_slot_wal_keep_size and wal_keep_segments

2020-06-30 Thread Alvaro Herrera
On 2020-Jun-30, Fujii Masao wrote: > Hi, > > When I talked about max_slot_wal_keep_size as new feature in v13 > at the conference, I received the question like "Why are the units of > setting values in max_slot_wal_keep_size and wal_keep_segments different?" > fr

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-01 Thread Fujii Masao
On 2020/07/01 12:26, Alvaro Herrera wrote: On 2020-Jun-30, Fujii Masao wrote: Hi, When I talked about max_slot_wal_keep_size as new feature in v13 at the conference, I received the question like "Why are the units of setting values in max_slot_wal_keep_size and wal_keep_segments diff

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-01 Thread Alvaro Herrera
e the units of > > > setting values in max_slot_wal_keep_size and wal_keep_segments different?" > > > from audience. That difference looks confusing for users and > > > IMO it's better to use the same unit for them. Thought? > > > > Do we still need wal

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-01 Thread David Steele
ts of setting values in max_slot_wal_keep_size and wal_keep_segments different?" from audience. That difference looks confusing for users and IMO it's better to use the same unit for them. Thought? Do we still need wal_keep_segments for anything? Yeah, personally I like wal_keep_segme

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-01 Thread Bruce Momjian
t; > > > > > > > > When I talked about max_slot_wal_keep_size as new feature in v13 > > > > > at the conference, I received the question like "Why are the units of > > > > > setting values in max_slot_wal_keep_size and wal_keep_segments > > > >

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-01 Thread Alvaro Herrera
On 2020-Jul-01, Bruce Momjian wrote: > We have the following wal*size GUC settings: > > SELECT name FROM pg_settings WHERE name LIKE '%wal%size%'; > name > >max_slot_wal_keep_size >max_wal_size >min_wal_size >wal

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-01 Thread Bruce Momjian
On Wed, Jul 1, 2020 at 04:25:35PM -0400, Alvaro Herrera wrote: > On 2020-Jul-01, Bruce Momjian wrote: > > > We have the following wal*size GUC settings: > > > > SELECT name FROM pg_settings WHERE name LIKE '%wal%size%'; > > name > > > > max_slo

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-03 Thread Masahiko Sawada
>> When I talked about max_slot_wal_keep_size as new feature in v13 > >>>> at the conference, I received the question like "Why are the units of > >>>> setting values in max_slot_wal_keep_size and wal_keep_segments > >>>> different?"

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-08 Thread Fujii Masao
received the question like "Why are the units of setting values in max_slot_wal_keep_size and wal_keep_segments different?" from audience. That difference looks confusing for users and IMO it's better to use the same unit for them. Thought? Do we still need wal_keep_segments for a

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-08 Thread Alvaro Herrera
On 2020-Jul-09, Fujii Masao wrote: > I attached the patch that renames wal_keep_segments to wal_keep_size. Looks good in a quick once-over. Just two small wording comments: > > Independently of max_wal_size, > -+ 1 most recent WAL files are > + most recent megabytes > + WAL fil

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-08 Thread Kyotaro Horiguchi
ote: > >>>> On 2020-Jun-30, Fujii Masao wrote: > >>>> > >>>>> When I talked about max_slot_wal_keep_size as new feature in v13 > >>>>> at the conference, I received the question like "Why are the units of > >>>>> setting

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-12 Thread Fujii Masao
On 2020/07/09 1:20, Alvaro Herrera wrote: On 2020-Jul-09, Fujii Masao wrote: I attached the patch that renames wal_keep_segments to wal_keep_size. Looks good in a quick once-over. Just two small wording comments: Thanks for review comments! Independently of max_wal_size, -

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-12 Thread Fujii Masao
Masao wrote: When I talked about max_slot_wal_keep_size as new feature in v13 at the conference, I received the question like "Why are the units of setting values in max_slot_wal_keep_size and wal_keep_segments different?" from audience. That difference looks confusing for users an

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-13 Thread Kyotaro Horiguchi
>>>>>>> When I talked about max_slot_wal_keep_size as new feature in v13 > >>>>>>> at the conference, I received the question like "Why are the units of > >>>>>>> setting values in max_slot_wal_keep_size and wal_keep_segmen

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-13 Thread Fujii Masao
_size and wal_keep_segments different?" from audience. That difference looks confusing for users and IMO it's better to use the same unit for them. Thought? Do we still need wal_keep_segments for anything? Yeah, personally I like wal_keep_segments because its setting is very simp

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-14 Thread David Steele
On 7/14/20 12:00 AM, Fujii Masao wrote: The patch was no longer applied cleanly because of recent commit. So I updated the patch. Attached. Barring any objection, I will commit this patch. This doesn't look right: + the most recent megabytes + WAL files plus one WAL file are How about:

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-17 Thread Fujii Masao
On 2020/07/14 20:30, David Steele wrote: On 7/14/20 12:00 AM, Fujii Masao wrote: The patch was no longer applied cleanly because of recent commit. So I updated the patch. Attached. Barring any objection, I will commit this patch. This doesn't look right: +   the most recent megabytes + 

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-17 Thread David Steele
On 7/17/20 5:11 AM, Fujii Masao wrote: On 2020/07/14 20:30, David Steele wrote: On 7/14/20 12:00 AM, Fujii Masao wrote: The patch was no longer applied cleanly because of recent commit. So I updated the patch. Attached. Barring any objection, I will commit this patch. This doesn't look

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-19 Thread Fujii Masao
On 2020/07/17 20:24, David Steele wrote: On 7/17/20 5:11 AM, Fujii Masao wrote: On 2020/07/14 20:30, David Steele wrote: On 7/14/20 12:00 AM, Fujii Masao wrote: The patch was no longer applied cleanly because of recent commit. So I updated the patch. Attached. Barring any objection, I

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-20 Thread Fujii Masao
On 2020/07/20 13:48, Fujii Masao wrote: On 2020/07/17 20:24, David Steele wrote: On 7/17/20 5:11 AM, Fujii Masao wrote: On 2020/07/14 20:30, David Steele wrote: On 7/14/20 12:00 AM, Fujii Masao wrote: The patch was no longer applied cleanly because of recent commit. So I updated the p

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-20 Thread David Steele
On 7/20/20 6:02 AM, Fujii Masao wrote: On 2020/07/20 13:48, Fujii Masao wrote: On 2020/07/17 20:24, David Steele wrote: On 7/17/20 5:11 AM, Fujii Masao wrote: On 2020/07/14 20:30, David Steele wrote: On 7/14/20 12:00 AM, Fujii Masao wrote: The patch was no longer applied cleanly beca

Re: max_slot_wal_keep_size and wal_keep_segments

2020-07-27 Thread Fujii Masao
On 2020/07/20 21:21, David Steele wrote: On 7/20/20 6:02 AM, Fujii Masao wrote: On 2020/07/20 13:48, Fujii Masao wrote: On 2020/07/17 20:24, David Steele wrote: On 7/17/20 5:11 AM, Fujii Masao wrote: On 2020/07/14 20:30, David Steele wrote: On 7/14/20 12:00 AM, Fujii Masao wrote: