Re: Typo: llvm*.cpp files identified as llvm*.c

On Wed, Jan 23, 2019 at 7:24 PM Andrew Gierth wrote: > > "Andres" == Andres Freund writes: > > [IDENTIFICATION] > > Andres> I think we should just rip them out. It's useless noise. > > +1 Here's a patch like that. 948 files changed, 3215 deletions(-) -- Thomas Munro

Re: Typo: llvm*.cpp files identified as llvm*.c

Andres Freund writes: > On 2019-01-23 12:01:10 +0900, Michael Paquier wrote: >> I am not sure if anybody uses them for anything automatically, still I >> find myself from time to time looking at them to remember on which >> path the file is located when opened in emacs. > I often want to know

Re: Typo: llvm*.cpp files identified as llvm*.c

Hi, On 2019-01-23 12:01:10 +0900, Michael Paquier wrote: > On Tue, Jan 22, 2019 at 05:49:46PM -0800, Andres Freund wrote: > > On 2019-01-23 14:43:15 +1300, Thomas Munro wrote: > >> The function name comments are similar, though less consistent so I'm > >> too lazy to write a script to find one

Re: Typo: llvm*.cpp files identified as llvm*.c

> "Andres" == Andres Freund writes: [IDENTIFICATION] Andres> I think we should just rip them out. It's useless noise. +1 -- Andrew (irc:RhodiumToad)

Re: Typo: llvm*.cpp files identified as llvm*.c

Michael Paquier writes: > I am not sure if anybody uses them for anything automatically, still I > find myself from time to time looking at them to remember on which > path the file is located when opened in emacs. So I still like having > those references, perhaps I am just a minority. FWIW, I

Re: Typo: llvm*.cpp files identified as llvm*.c

On Tue, Jan 22, 2019 at 05:49:46PM -0800, Andres Freund wrote: > On 2019-01-23 14:43:15 +1300, Thomas Munro wrote: >> The function name comments are similar, though less consistent so I'm >> too lazy to write a script to find one that is actually wrong (with >> which to trigger Andres's

Re: Typo: llvm*.cpp files identified as llvm*.c

Hi Thomas, On 2019/01/23 9:37, Thomas Munro wrote: > On Wed, Jan 23, 2019 at 1:16 PM Amit Langote > wrote: >> On 2019/01/23 4:51, Andres Freund wrote: >>> On 2019-01-22 13:43:32 +0900, Amit Langote wrote: Attached find a patch to fix $subject. >>> >>> Thanks, pushed to master and 11. >> >>

RE: Typo: llvm*.cpp files identified as llvm*.c

Dear Hackers. > -Original Message- > From: Thomas Munro [mailto:thomas.mu...@enterprisedb.com] > Sent: Wednesday, January 23, 2019 9:38 AM > To: Amit Langote > Cc: Andres Freund; Pg Hackers > Subject: Re: Typo: llvm*.cpp files identified as llvm*.c > > On Wed,

Re: Typo: llvm*.cpp files identified as llvm*.c

On Wed, Jan 23, 2019 at 01:37:41PM +1300, Thomas Munro wrote: > It's not only the ending that's wrong. Here are some more source > files whose IDENTIFICATION heading doesn't exactly match their path: Good point. > $ git grep -A 1 IDENTIFICATION | grep -v IDENTIFICATION | grep -v -- > -- | sed

Re: Typo: llvm*.cpp files identified as llvm*.c

On 2019-01-23 14:43:15 +1300, Thomas Munro wrote: > The function name comments are similar, though less consistent so I'm > too lazy to write a script to find one that is actually wrong (with > which to trigger Andres's let's-delete-them-all response :-D). I wish function comment styles were more

Re: Typo: llvm*.cpp files identified as llvm*.c

On Wed, Jan 23, 2019 at 2:02 PM Andres Freund wrote: > On 2019-01-23 09:55:22 +0900, Michael Paquier wrote: > > On Wed, Jan 23, 2019 at 01:37:41PM +1300, Thomas Munro wrote: > > > This could be really confusing for erm, future people reading a dot > > > matrix print-out of the source code? > > I

Re: Typo: llvm*.cpp files identified as llvm*.c

Hi, On 2019-01-23 09:55:22 +0900, Michael Paquier wrote: > On Wed, Jan 23, 2019 at 01:37:41PM +1300, Thomas Munro wrote: > > This could be really confusing for erm, future people reading a dot > > matrix print-out of the source code? I think we should just rip them out. It's useless noise. >

Re: Typo: llvm*.cpp files identified as llvm*.c

On Wed, Jan 23, 2019 at 1:16 PM Amit Langote wrote: > On 2019/01/23 4:51, Andres Freund wrote: > > On 2019-01-22 13:43:32 +0900, Amit Langote wrote: > >> Attached find a patch to fix $subject. > > > > Thanks, pushed to master and 11. > > Thank you. It's not only the ending that's wrong. Here

Re: Typo: llvm*.cpp files identified as llvm*.c

On 2019/01/23 4:51, Andres Freund wrote: > Hi, > > On 2019-01-22 13:43:32 +0900, Amit Langote wrote: >> Attached find a patch to fix $subject. > > Thanks, pushed to master and 11. Thank you. Regards, Amit

Re: Typo: llvm*.cpp files identified as llvm*.c

Hi, On 2019-01-22 13:43:32 +0900, Amit Langote wrote: > Attached find a patch to fix $subject. Thanks, pushed to master and 11. Greetings, Andres Freund

Re: Typo: llvm*.cpp files identified as llvm*.c

On Tue, Jan 22, 2019 at 01:43:32PM +0900, Amit Langote wrote: > Hi, > > Attached find a patch to fix $subject. It is like that since 31bc604. Andres, would you take care of it? It is your commit after all.. -- Michael signature.asc Description: PGP signature

Typo: llvm*.cpp files identified as llvm*.c

Hi, Attached find a patch to fix $subject. Thanks, Amit diff --git a/src/backend/jit/llvm/llvmjit_error.cpp b/src/backend/jit/llvm/llvmjit_error.cpp index ba3907c452..9c6e8026e7 100644 --- a/src/backend/jit/llvm/llvmjit_error.cpp +++ b/src/backend/jit/llvm/llvmjit_error.cpp @@ -9,7 +9,7 @@ *