Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread Martijn van Oosterhout
On Sun, Sep 24, 2006 at 07:38:20PM -0400, Tom Lane wrote: > Hannu Krosing <[EMAIL PROTECTED]> writes: > > I don't think that any of our SGML documentation is actually in UCS-4 > > encoding. > > The source files use nothing beyond plain ASCII (and should remain that > way, IMHO) so there isn't any

[HACKERS] Questions about guc units

2006-09-24 Thread ITAGAKI Takahiro
Hi hackers, I have some questions about guc units, new feature in 8.2. #shared_buffers = 32000kB # min 128kB or max_connections*16kB #temp_buffers = 8000kB # min 800kB #effective_cache_size = 8000kB Are there any reasons to continue to use 1000-unit numbers? Megabyte-unit (32MB and

Re: [PATCHES] [HACKERS] large object regression tests

2006-09-24 Thread Jeremy Drake
On Sun, 24 Sep 2006, Jeremy Drake wrote: > On Thu, 21 Sep 2006, Tom Lane wrote: > > > I suggest that instead of testing the server-side lo_import/lo_export > > functions, perhaps you could test the psql equivalents and write and > > read a file in psql's working directory. > > I did not see any pr

[HACKERS] pls disregard, testing majordomo settings

2006-09-24 Thread Jeremy Drake
I just messed with a bunch of my majordomo settings and I wanted to make sure things are working the way I thought. Please disregard. Sorry to bother everyone -- I'll defend to the death your right to say that, but I never said I'd listen to it! -- Tom Galloway with apologies to

Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread Bruce Momjian
Tom Lane wrote: > Hannu Krosing <[EMAIL PROTECTED]> writes: > > I don't think that any of our SGML documentation is actually in UCS-4 > > encoding. > > The source files use nothing beyond plain ASCII (and should remain that > way, IMHO) so there isn't any need to inquire very far into exactly what

Re: [HACKERS] [PATCHES] Bad bug in fopen() wrapper code

2006-09-24 Thread Claudio Natoli
Hello guys, it's been a while, but... > What's bugging me is that 0 and O_EXCL give the same answer, and > O_TRUNC and O_TRUNC | O_EXCL give the same answer, This is ok, as (iirc) O_EXCL only has effect in the presence of O_CREAT. (a comment to this effect would help here, as well as perhaps l

[HACKERS] TODO: Fix CREATE CAST on DOMAIN Part II

2006-09-24 Thread Gevik Babakhani
Continuing the discussion about domain cast problem... http://archives.postgresql.org/pgsql-hackers/2006-09/msg01681.php Tom, I have done some playing and thinking about the problem... You are absolutely right about the points you mentioned on http://archives.postgresql.org/pgsql-hackers/2006-09/

Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread Tom Lane
Hannu Krosing <[EMAIL PROTECTED]> writes: > I don't think that any of our SGML documentation is actually in UCS-4 > encoding. The source files use nothing beyond plain ASCII (and should remain that way, IMHO) so there isn't any need to inquire very far into exactly what the toolchain thinks the "d

Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread Hannu Krosing
Ühel kenal päeval, E, 2006-09-25 kell 00:23, kirjutas Peter Eisentraut: > Andrew Dunstan wrote: > > If we want to quote references, we should quote the XML standard. For > > example, see here to see the exact charset supported by XML: > > http://www.w3.org/TR/2006/REC-xml11-20060816/#charsets. > >

Re: [HACKERS] AllocFile debug code

2006-09-24 Thread Bruce Momjian
Added to open items list. --- Tom Lane wrote: > "Magnus Hagander" <[EMAIL PROTECTED]> writes: > > http://archives.postgresql.org/pgsql-committers/2006-08/msg00410.php > > Should this be removed again now? > > I was intendin

Re: [PATCHES] [HACKERS] large object regression tests

2006-09-24 Thread Jeremy Drake
On Thu, 21 Sep 2006, Tom Lane wrote: > Jeremy Drake <[EMAIL PROTECTED]> writes: > > I put together a patch which adds a regression test for large objects, > > hopefully attached to this message. I would like some critique of it, to > > see if I have gone about it the right way. Also I would be h

Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread Peter Eisentraut
Andrew Dunstan wrote: > If we want to quote references, we should quote the XML standard. For > example, see here to see the exact charset supported by XML: > http://www.w3.org/TR/2006/REC-xml11-20060816/#charsets. The actual cause of the processing problems we have been seeing are the character s

Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread Andrew Dunstan
Hannu Krosing wrote: Ühel kenal päeval, P, 2006-09-24 kell 14:56, kirjutas Markus Schaber: Hi, Hannu, Hannu Krosing wrote: Are you sure it's UCS-4 ? I've always thought that XML is what is given in tag, and utf-8 if no charset is given. You have to distinguish between the s

Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread Hannu Krosing
Ühel kenal päeval, P, 2006-09-24 kell 14:56, kirjutas Markus Schaber: > Hi, Hannu, > > Hannu Krosing wrote: > > > Are you sure it's UCS-4 ? I've always thought that XML is what is given > > in tag, and utf-8 if no charset is given. > > You have to distinguish between the supported charset, and

Re: [HACKERS] [PATCHES] Include file in regress.c

2006-09-24 Thread Magnus Hagander
> > That definitely looks weird to me. Unfortunatly, it's way > above me wrt > > CVS knowledge. I'm just going to have to live with it and > remember to > > delete that part from my diffs... > > The weird thing is that it's not happening for other people. > Have you tried blowing away the wh

[HACKERS] Windows build farm failures

2006-09-24 Thread Dave Page
Snake and Bandicoot are still hanging in ECPG-Check at the moment. Killing the dt_test.exe program that the regression tests seem to be running frees it all up to properly report the failure. I don't have time to investigate further at the minute, but for anyone that does, Bandicoot's last run was

Re: [HACKERS] Logfile created when not needed?

2006-09-24 Thread Magnus Hagander
> > If I configure log_destination='eventlog', and then > > redirect_stderr='on', PostgreSQL will attempt to create a > logfile in > > pg_log anyway. > > So don't do that --- redirect_stderr is only sensible to turn > on if you mean to use logging to stderr. I don't. Normally. But I had it tu

Re: [HACKERS] Logfile created when not needed?

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > If I configure log_destination='eventlog', and then > redirect_stderr='on', PostgreSQL will attempt to create a logfile in > pg_log anyway. So don't do that --- redirect_stderr is only sensible to turn on if you mean to use logging to stderr. The re

Re: [HACKERS] [PATCHES] Bad bug in fopen() wrapper code

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > This is pretty bad and pretty urgent - with this, systems installed by > the MSI installer simply *do not start*, because they are by default > configured to write logs to a file... > Attached patch sets the O_CREAT option when appending to files.

Re: [HACKERS] [PATCHES] Bad bug in fopen() wrapper code

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > That is part of the original open() code that Claudio did back for 8.0, > so it has definitly been working since then. Hm, maybe best not to touch it, but still... > I haven't really read into > the code, though... But a qiuck look doesn't show me a

Re: [HACKERS] [PATCHES] Updates to pg_regress.c

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Found a couple of "XXX is there a way to do this on Windows" in > pg_regress.c that I had missed. The answer to the question is yes, > attached is a patch that does it. Applied, along with change to make it start the temp postmaster as "postgres" not

Re: [HACKERS] pg_regress starting postmaster

2006-09-24 Thread Magnus Hagander
> >> The question here > >> is whether you're ready to break existing custom scripts > for starting > >> the postmaster. Maybe there are none such in the wild on Windows, > >> but I'd be hesitant to assume that. > > > We're guessing there aren't - if there are, those are > scripts calling >

Re: [HACKERS] [PATCHES] Bad bug in fopen() wrapper code

2006-09-24 Thread Magnus Hagander
> > Attached patch sets the O_CREAT option when appending to files. > > That looks correct, but I went looking to see if there were > any other mistakes of the same ilk, and I'm wondering what > the sense is in openFlagsToCreateFileFlags ... seems like > it's ignoring O_EXCL in some combinatio

Re: [HACKERS] pg_regress starting postmaster

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> The question here >> is whether you're ready to break existing custom scripts for >> starting the postmaster. Maybe there are none such in the >> wild on Windows, but I'd be hesitant to assume that. > We're guessing there aren't - if there are,

Re: [HACKERS] [PATCHES] pg_ctl error msg on Windows 2000

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > On version of Windows prior to XP, pg_ctl will *always* log a warning > about not finding Job API functions. This is probably unnecessary, since > they are never present there. The check was originally intended to give > a warning if something was wro

Re: [HACKERS] [PATCHES] Bad bug in fopen() wrapper code

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Attached patch sets the O_CREAT option when appending to files. That looks correct, but I went looking to see if there were any other mistakes of the same ilk, and I'm wondering what the sense is in openFlagsToCreateFileFlags ... seems like it's ign

Re: [HACKERS] pg_regress starting postmaster

2006-09-24 Thread Magnus Hagander
> >> No. We're a very long way away from considering removing the > >> postmaster symlink, so it doesn't matter. > > > Well, per previous discussion, we're removing > postmaster.exe from the > > win32 installer, because it bloats the distribution wihtout > any gain > > (remember - windows doe

Re: [HACKERS] pg_regress starting postmaster

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> No. We're a very long way away from considering removing the >> postmaster symlink, so it doesn't matter. > Well, per previous discussion, we're removing postmaster.exe from the > win32 installer, because it bloats the distribution wihtout any gai

Re: [HACKERS] AllocFile debug code

2006-09-24 Thread Magnus Hagander
> > http://archives.postgresql.org/pgsql-committers/2006-08/msg00410.php > > Should this be removed again now? > > I was intending to remove it sometime before release, but > seeing that a number of the Windows buildfarm members have > been out of commission for the last several weeks, I'm unsur

Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread David Fetter
On Sun, Sep 24, 2006 at 10:20:22AM +0200, Peter Eisentraut wrote: > Alvaro Herrera wrote: > > On the other hand, I don't understand why DocBook would be Latin-1 > > only. What would be the point of that limitation? Some googling > > seems to reveal that people indeed uses other charsets, UTF-8 in

Re: [HACKERS] AllocFile debug code

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > http://archives.postgresql.org/pgsql-committers/2006-08/msg00410.php > Should this be removed again now? I was intending to remove it sometime before release, but seeing that a number of the Windows buildfarm members have been out of commission for t

Re: [HACKERS] pg_regress starting postmaster

2006-09-24 Thread Magnus Hagander
> > subject says it all. pg_regress starts "postmaster" (pg_regress.c, > > line 1515). Shouldn't this be "postgres" these days? > > No. We're a very long way away from considering removing the > postmaster symlink, so it doesn't matter. Well, per previous discussion, we're removing postmaster.

Re: [HACKERS] Buildfarm alarms

2006-09-24 Thread Andrew Dunstan
Tom Lane wrote: > "Andrew Dunstan" <[EMAIL PROTECTED]> writes: >> It could certainly be done. In general, I have generally taken the view >> that owners have the responsibility for monitoring their own machines. > > Sure, but providing them tools to do that seems within buildfarm's > purview. > > F

Re: [HACKERS] PostgreSQL 8.2beta1 w/ VALUES

2006-09-24 Thread Tom Lane
"Luke Lonergan" <[EMAIL PROTECTED]> writes: > If it's going to roll back the entire load after that one warning, it > should terminate there. This was a warning, not an error. regards, tom lane ---(end of broadcast)--- TIP 1

Re: [HACKERS] pg_regress starting postmaster

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Actually, a second thought given that I was just bitten by the > run-tests-as-admin-doesn't-work - should we use pg_ctl to start it? No, not unless you'd like to break pg_regress's ability to kill the postmaster --- we need the postmaster to be the d

Re: [HACKERS] pg_regress starting postmaster

2006-09-24 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > subject says it all. pg_regress starts "postmaster" (pg_regress.c, line > 1515). Shouldn't this be "postgres" these days? No. We're a very long way away from considering removing the postmaster symlink, so it doesn't matter.

Re: [HACKERS] pg_regress starting postmaster

2006-09-24 Thread Magnus Hagander
> subject says it all. pg_regress starts "postmaster" > (pg_regress.c, line 1515). Shouldn't this be "postgres" these days? > > (Yes, I'm aware that I wrote that code ;-) But this just occurred to > me..) Actually, a second thought given that I was just bitten by the run-tests-as-admin-doesn't-w

[HACKERS] pg_regress starting postmaster

2006-09-24 Thread Magnus Hagander
subject says it all. pg_regress starts "postmaster" (pg_regress.c, line 1515). Shouldn't this be "postgres" these days? (Yes, I'm aware that I wrote that code ;-) But this just occurred to me..) //Magnus ---(end of broadcast)--- TIP 1: if posting/r

[HACKERS] Logfile created when not needed?

2006-09-24 Thread Magnus Hagander
Digging into several win32 related issues right now, so I don't have the time to investigate ATM, but I figured I should get it out here: If I configure log_destination='eventlog', and then redirect_stderr='on', PostgreSQL will attempt to create a logfile in pg_log anyway. This file remains empty

[HACKERS] AllocFile debug code

2006-09-24 Thread Magnus Hagander
http://archives.postgresql.org/pgsql-committers/2006-08/msg00410.php Should this be removed again now? The actual fix should be http://archives.postgresql.org/pgsql-committers/2006-08/msg00504.php, and per http://archives.postgresql.org/pgsql-hackers/2006-08/msg01920.php it seems to have solved t

Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread Markus Schaber
Hi, Hannu, Hannu Krosing wrote: > Are you sure it's UCS-4 ? I've always thought that XML is what is given > in tag, and utf-8 if no charset is given. You have to distinguish between the supported charset, and the document encoding. HTH, Markus -- Markus Schaber | Logical Tracking&Tracing Inte

Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread Hannu Krosing
Ühel kenal päeval, P, 2006-09-24 kell 10:20, kirjutas Peter Eisentraut: > Alvaro Herrera wrote: > > On the other hand, I don't understand why DocBook would be Latin-1 > > only. What would be the point of that limitation? Some googling > > seems to reveal that people indeed uses other charsets, UTF

Re: [HACKERS] PostgreSQL 8.2beta1 w/ VALUES

2006-09-24 Thread Markus Schaber
Hi, Luke, Luke Lonergan wrote: > If it's going to roll back the entire load after that one warning, it > should terminate there. AFAIK, a warning is no reason for PostgreSQL to roll back anything. That's the difference between a warning and an error. HTH, Markus -- Markus Schaber | Logical T

Re: [HACKERS] Fwd: Is the fsync() fake on FreeBSD6.1?

2006-09-24 Thread Ron Mayer
Andrew - Supernews wrote: > > Whether the underlying device lies about the write completion is another > matter. All current SCSI disks have WCE enabled by default, which means > that they will lie about write completion if FUA was not set in the > request, which FreeBSD never sets. (It's not poss

Re: [HACKERS] Buildfarm alarms

2006-09-24 Thread Dave Page
> -Original Message- > From: Andrew Dunstan [mailto:[EMAIL PROTECTED] > Sent: 24 September 2006 03:13 > To: Dave Page > Cc: pgsql-hackers@postgresql.org > Subject: Re: Buildfarm alarms > > It could certainly be done. In general, I have generally > taken the view > that owners have the

Re: [HACKERS] pgsql: We're going to have to spell dotless i

2006-09-24 Thread Peter Eisentraut
Alvaro Herrera wrote: > On the other hand, I don't understand why DocBook would be Latin-1 > only. What would be the point of that limitation? Some googling > seems to reveal that people indeed uses other charsets, UTF-8 in > particular (but also Big5, Latin-2, etc), so apparently this isn't > set